Repository navigation
[backport cloud/1.56] FE-3260 fix(dialog): centre a dialog on the viewport when it cannot fit beside the docked panel - #20353
Conversation
…it beside the docked panel (#20328) ## Why With the Agent panel docked, a modal too wide to fit beside the panel (Templates, Choose a Plan, …) sits pinned to the left edge while still covering the panel. It is neither centered nor clear of the panel. Found while verifying 1.56 QA fixes on testcloud. Reported in [#bug-dump](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1791307152424699). ## Root cause `dialogContentVariants` (`maximized: false`) positions every modal with `translate-x: max(calc(min(0.5rem,100vw-100%)-50vw), calc(-50%-inset/2))` (#20002, PM-1865). - When the dialog fits beside the panel, the second term centers it there. That's PM-1865's intent and it's kept. - When it doesn't fit, `max()` falls back to the left-gutter floor, so the dialog stays shifted by up to `inset/2` and covers the panel anyway. At 1440px with a 420px panel, Templates (1296px wide) lands at x = 8 with 136px empty on the right. ## How Apply the inset shift only when the dialog fits beside the panel. Otherwise center on the viewport: ``` translate-x: calc(-50% - min(inset/2, max(0px, (50vw - 50% - inset/2 - 0.5rem + 1px) * 1000))) ``` `50vw - 50% - inset/2 - 0.5rem` is the room left of a panel-centered dialog. When it's positive (fits), the `min()` picks the full `inset/2` shift. When it's negative (doesn't fit), it picks `0`, so the dialog is viewport-centered. The `+1px` keeps a dialog sized exactly to the space beside the panel on the beside-the-panel branch: the 3D viewer caps itself at `100vw - inset - 1rem`, and `load3dAgentUpdate.spec.ts` asserts it stays clear of the panel. With no panel the inset is `0` and every dialog stays at `-50%`, so layout without a panel is unchanged. The offset stays on `translate`, for the reason in #20002: the zoom keyframes write `transform`. | Case | Before | After | | --- | --- | --- | | Templates, 1440px viewport, 420px panel (doesn't fit) | x = 8, covers the panel | x = 72, centered on the viewport | | Templates, 1920px viewport (fits) | x = 50, beside the panel | x = 50, unchanged | | `md` confirm, 1440px (fits) | x = 222, beside the panel | x = 222, unchanged | | `md` confirm, 640px (doesn't fit) | x = 8 | x = 32, centered | ## AS IS / TO BE Local cloud app against testcloud, 1440×900, Agent panel docked: | AS IS (`main`) | TO BE (this branch) | | --- | --- | | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/refs/heads/assets/fe-3260/as-is.jpg"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/refs/heads/assets/fe-3260/to-be.jpg"> | ## Test plan - [x] `dialogAgentPanelInset.spec.ts`: the 1440px Templates and 640px confirm rows now expect viewport-centered x (72 / 32). The 1920px "centres beside the panel" row is unchanged. - [x] Measured in the real app on this branch: Templates at 1440 → x = 72 (both sides 72); confirm at 1440 → x = 222 (beside the panel); confirm at 640 with a 420px inset → x = 32 - Fixes FE-3260 - Related: PM-1865, #20002
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 79e20583e75d2b712ad78ca8db68885d2dc7aaea
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-06T22:58:20.665Z",
"gitSha": "0aa6c10bfd14aac88de836d3010a3a28fa371c61",
"branch": "backport-20328-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.6789999999824,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.709,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.859,
"heapDeltaBytes": 519300,
"heapUsedBytes": 68497376,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.874,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2019.123000000036,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.1209999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.683,
"heapDeltaBytes": 584188,
"heapUsedBytes": 68592308,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.498000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1795.0240000000122,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.089000000000002,
"layouts": 12,
"layoutDurationMs": 4.708,
"taskDurationMs": 801.3770000000001,
"heapDeltaBytes": -2405284,
"heapUsedBytes": 65615712,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 168.13,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740745,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.9779999999937,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.953,
"layouts": 12,
"layoutDurationMs": 4.236,
"taskDurationMs": 781.2379999999999,
"heapDeltaBytes": -2453528,
"heapUsedBytes": 66195800,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 158.81,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.8300000000108,
"styleRecalcs": 29,
"styleRecalcDurationMs": 9.746999999999998,
"layouts": 6,
"layoutDurationMs": 1.156,
"taskDurationMs": 319.21299999999997,
"heapDeltaBytes": -234088,
"heapUsedBytes": 59644700,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.447999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.4019999999546,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.630999999999998,
"layouts": 6,
"layoutDurationMs": 1.319,
"taskDurationMs": 330.11400000000003,
"heapDeltaBytes": 3790304,
"heapUsedBytes": 71479316,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.42,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 686.6850000000113,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.920999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.029,
"heapDeltaBytes": -8166264,
"heapUsedBytes": 59549760,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 166.89000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 687.9959999999983,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.795999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.626,
"heapDeltaBytes": -6830504,
"heapUsedBytes": 61258240,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 165.173,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1147.6349999999798,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 794.906,
"heapDeltaBytes": 38970108,
"heapUsedBytes": 108086932,
"domNodes": 0,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 68.748,
"eventListeners": 0,
"totalBlockingTimeMs": 515,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1153.513000000089,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 808.1650000000001,
"heapDeltaBytes": 15675116,
"heapUsedBytes": 85216872,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 65.254,
"eventListeners": 0,
"totalBlockingTimeMs": 521,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.0900000000329,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.72999999999985,
"heapDeltaBytes": 17666268,
"heapUsedBytes": 105325456,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 164.43099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 24.762857142857165,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.2339999999149,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.51299999999986,
"heapDeltaBytes": 17663332,
"heapUsedBytes": 105195752,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 163.46499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10049.132999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9152.223000000002,
"heapDeltaBytes": 12092592,
"heapUsedBytes": 80593284,
"domNodes": -142,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 7594.932,
"eventListeners": -70,
"totalBlockingTimeMs": 1226,
"frameDurationMs": 33.837037037037035,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9557.16499999994,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.7589999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8729.866000000002,
"heapDeltaBytes": 7698012,
"heapUsedBytes": 92555188,
"domNodes": -142,
"jsHeapTotalBytes": -10096640,
"scriptDurationMs": 7195.5779999999995,
"eventListeners": -74,
"totalBlockingTimeMs": 748,
"frameDurationMs": 32.929655172413796,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8936.672999999984,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.4309999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8252.856,
"heapDeltaBytes": 23133132,
"heapUsedBytes": 92562472,
"domNodes": -142,
"jsHeapTotalBytes": -11669504,
"scriptDurationMs": 6743.449,
"eventListeners": -74,
"totalBlockingTimeMs": 588,
"frameDurationMs": 32.72124542124542,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10140.55499999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9359.927000000001,
"heapDeltaBytes": -2130240,
"heapUsedBytes": 82590132,
"domNodes": -142,
"jsHeapTotalBytes": -7213056,
"scriptDurationMs": 7803.593999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 1001,
"frameDurationMs": 34.00302013422819,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2009.301999999991,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.5299999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.46900000000005,
"heapDeltaBytes": -9647180,
"heapUsedBytes": 79128728,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.978000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2008.1860000000233,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.310999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.27799999999996,
"heapDeltaBytes": -9658860,
"heapUsedBytes": 79658028,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.37,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2243.5219999999845,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.224,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1422.844,
"heapDeltaBytes": -19475048,
"heapUsedBytes": 70441904,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 849.604,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666417910447763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2309.2309999999543,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.861,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1551.1770000000001,
"heapDeltaBytes": -19270968,
"heapUsedBytes": 70412724,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 834.742,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665942028985512,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3580.6139999999687,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.046999999999999,
"layouts": 60,
"layoutDurationMs": 13.887,
"taskDurationMs": 1617.039,
"heapDeltaBytes": 1518468,
"heapUsedBytes": 69753972,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 777.803,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3552.4090000000115,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.403,
"layouts": 60,
"layoutDurationMs": 14.240999999999998,
"taskDurationMs": 1682.3020000000001,
"heapDeltaBytes": 5188096,
"heapUsedBytes": 73910884,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 802.912,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665887850467286,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3068.368000000021,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.751000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1850.196,
"heapDeltaBytes": 8382600,
"heapUsedBytes": 76989384,
"domNodes": 0,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 978.0970000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756830601092897,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3146.755999999982,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.387000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1827.4859999999999,
"heapDeltaBytes": 7922840,
"heapUsedBytes": 77361220,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 964.2199999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755614973262038,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2012.4650000000202,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.8329999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.085,
"heapDeltaBytes": -9794652,
"heapUsedBytes": 79830064,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.168000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.1600000000235,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.1859999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.8999999999999,
"heapDeltaBytes": -9121432,
"heapUsedBytes": 80736804,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.461999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.8069999999698,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.299999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.26500000000004,
"heapDeltaBytes": 10402376,
"heapUsedBytes": 74423260,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 147.117,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 621.6300000000956,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.245000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.189,
"heapDeltaBytes": 9382952,
"heapUsedBytes": 72073080,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 142.644,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2021.4480000000208,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.52200000000005,
"heapDeltaBytes": 1022244,
"heapUsedBytes": 70364516,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.387000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.1849999999222,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.9410000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.32199999999995,
"heapDeltaBytes": 885864,
"heapUsedBytes": 70522148,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.392999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.291999999995,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.593,
"layouts": 16,
"layoutDurationMs": 5.869,
"taskDurationMs": 740.5219999999999,
"heapDeltaBytes": -6145816,
"heapUsedBytes": 63462732,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 111.299,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.7139999999526,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.764000000000003,
"layouts": 16,
"layoutDurationMs": 5.914,
"taskDurationMs": 729.5400000000001,
"heapDeltaBytes": -5927256,
"heapUsedBytes": 63815336,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.02899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352933,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1403.2320000000027,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.215999999999994,
"layouts": 5,
"layoutDurationMs": 14.557999999999998,
"taskDurationMs": 956.488,
"heapDeltaBytes": 1267028,
"heapUsedBytes": 94069688,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 30.872999999999998,
"eventListeners": 2463,
"totalBlockingTimeMs": 136,
"frameDurationMs": 19.143243243243248,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8234.199999999986,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.305,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5417.6,
"heapDeltaBytes": 7766340,
"heapUsedBytes": 96076664,
"domNodes": 0,
"jsHeapTotalBytes": 753664,
"scriptDurationMs": 2685.7000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666125760649088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8359.268000000044,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.541,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5552.532,
"heapDeltaBytes": -19379876,
"heapUsedBytes": 69214624,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 2725.715,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6994,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18306.79200000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17307.827,
"heapDeltaBytes": -36189684,
"heapUsedBytes": 180434432,
"domNodes": -3046,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 270.106,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.88684654300169,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 17644.77599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16811.952,
"heapDeltaBytes": -38344820,
"heapUsedBytes": 180213516,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 262.70000000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.506401384083045,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 21963.504,
"styleRecalcs": 177,
"styleRecalcDurationMs": 18.621,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21611.953,
"heapDeltaBytes": -49066116,
"heapUsedBytes": 167121908,
"domNodes": -3045,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 871.0949999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 21,
"frameDurationMs": 40.45267034990792,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 21500.279999999977,
"styleRecalcs": 177,
"styleRecalcDurationMs": 19.13899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21116.183,
"heapDeltaBytes": -43027864,
"heapUsedBytes": 170010756,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 869.818,
"eventListeners": -14915,
"totalBlockingTimeMs": 9,
"frameDurationMs": 39.66642066420663,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6361.642999999958,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.55600000000001,
"layouts": 20,
"layoutDurationMs": 23.694000000000006,
"taskDurationMs": 6237.753000000001,
"heapDeltaBytes": 14991368,
"heapUsedBytes": 214200504,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 102.994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.44941176470589,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6408.110999999963,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.339,
"layouts": 20,
"layoutDurationMs": 24.784,
"taskDurationMs": 6309.168000000001,
"heapDeltaBytes": 1245320,
"heapUsedBytes": 214156880,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 110.98799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.19285714285714,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9249.63600000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8756.343,
"heapDeltaBytes": -43067480,
"heapUsedBytes": 179671024,
"domNodes": -3045,
"jsHeapTotalBytes": 1941504,
"scriptDurationMs": 140.31900000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.249324324324323,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8828.556000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8549.453000000001,
"heapDeltaBytes": -28922516,
"heapUsedBytes": 185061628,
"domNodes": -3045,
"jsHeapTotalBytes": 13127680,
"scriptDurationMs": 145.264,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.987414965986392,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 136.86299999994844,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.928999999999998,
"layouts": 5,
"layoutDurationMs": 2.563,
"taskDurationMs": 104.41100000000003,
"heapDeltaBytes": 4026864,
"heapUsedBytes": 69198716,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.132999999999997,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 463.16699999999855,
"styleRecalcs": 13,
"styleRecalcDurationMs": 11.611999999999998,
"layouts": 3,
"layoutDurationMs": 0.8240000000000001,
"taskDurationMs": 99.93199999999999,
"heapDeltaBytes": 5518156,
"heapUsedBytes": 71345432,
"domNodes": 99,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.526,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 917.9170000001022,
"styleRecalcs": 78,
"styleRecalcDurationMs": 106.722,
"layouts": 76,
"layoutDurationMs": 25.381999999999998,
"taskDurationMs": 881.977,
"heapDeltaBytes": 18081400,
"heapUsedBytes": 84835724,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 363.762,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66545454545455,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 868.4450000000652,
"styleRecalcs": 78,
"styleRecalcDurationMs": 101.67099999999999,
"layouts": 76,
"layoutDurationMs": 26.006,
"taskDurationMs": 841.0020000000001,
"heapDeltaBytes": 17874348,
"heapUsedBytes": 82908996,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 345.001,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584904,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1432.3719999999867,
"styleRecalcs": 78,
"styleRecalcDurationMs": 267.399,
"layouts": 76,
"layoutDurationMs": 28.875,
"taskDurationMs": 1402.58,
"heapDeltaBytes": 8663780,
"heapUsedBytes": 115096412,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 468.86699999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.916250000000012,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1435.1039999999102,
"styleRecalcs": 78,
"styleRecalcDurationMs": 271.58700000000005,
"layouts": 76,
"layoutDurationMs": 28.99,
"taskDurationMs": 1418.0539999999999,
"heapDeltaBytes": -13195240,
"heapUsedBytes": 106679424,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 470.373,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.35316455696202,
"p95FrameDurationMs": 33.30000000000109
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of PR 20328.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #20353 +/- ##
=============================================
Coverage ? 85.95%
=============================================
Files ? 2461
Lines ? 140602
Branches ? 38231
=============================================
Hits ? 120853
Misses ? 19371
Partials ? 378
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #20328 to
cloud/1.56Automatically created by backport workflow.