Repository navigation
[backport core/1.56] FE-3260 fix(dialog): centre a dialog on the viewport when it cannot fit beside the docked panel - #20352
Conversation
…it beside the docked panel (#20328) ## Why With the Agent panel docked, a modal too wide to fit beside the panel (Templates, Choose a Plan, …) sits pinned to the left edge while still covering the panel. It is neither centered nor clear of the panel. Found while verifying 1.56 QA fixes on testcloud. Reported in [#bug-dump](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1791307152424699). ## Root cause `dialogContentVariants` (`maximized: false`) positions every modal with `translate-x: max(calc(min(0.5rem,100vw-100%)-50vw), calc(-50%-inset/2))` (#20002, PM-1865). - When the dialog fits beside the panel, the second term centers it there. That's PM-1865's intent and it's kept. - When it doesn't fit, `max()` falls back to the left-gutter floor, so the dialog stays shifted by up to `inset/2` and covers the panel anyway. At 1440px with a 420px panel, Templates (1296px wide) lands at x = 8 with 136px empty on the right. ## How Apply the inset shift only when the dialog fits beside the panel. Otherwise center on the viewport: ``` translate-x: calc(-50% - min(inset/2, max(0px, (50vw - 50% - inset/2 - 0.5rem + 1px) * 1000))) ``` `50vw - 50% - inset/2 - 0.5rem` is the room left of a panel-centered dialog. When it's positive (fits), the `min()` picks the full `inset/2` shift. When it's negative (doesn't fit), it picks `0`, so the dialog is viewport-centered. The `+1px` keeps a dialog sized exactly to the space beside the panel on the beside-the-panel branch: the 3D viewer caps itself at `100vw - inset - 1rem`, and `load3dAgentUpdate.spec.ts` asserts it stays clear of the panel. With no panel the inset is `0` and every dialog stays at `-50%`, so layout without a panel is unchanged. The offset stays on `translate`, for the reason in #20002: the zoom keyframes write `transform`. | Case | Before | After | | --- | --- | --- | | Templates, 1440px viewport, 420px panel (doesn't fit) | x = 8, covers the panel | x = 72, centered on the viewport | | Templates, 1920px viewport (fits) | x = 50, beside the panel | x = 50, unchanged | | `md` confirm, 1440px (fits) | x = 222, beside the panel | x = 222, unchanged | | `md` confirm, 640px (doesn't fit) | x = 8 | x = 32, centered | ## AS IS / TO BE Local cloud app against testcloud, 1440×900, Agent panel docked: | AS IS (`main`) | TO BE (this branch) | | --- | --- | | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/refs/heads/assets/fe-3260/as-is.jpg"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/refs/heads/assets/fe-3260/to-be.jpg"> | ## Test plan - [x] `dialogAgentPanelInset.spec.ts`: the 1440px Templates and 640px confirm rows now expect viewport-centered x (72 / 32). The 1920px "centres beside the panel" row is unchanged. - [x] Measured in the real app on this branch: Templates at 1440 → x = 72 (both sides 72); confirm at 1440 → x = 222 (beside the panel); confirm at 640 with a 420px inset → x = 32 - Fixes FE-3260 - Related: PM-1865, #20002
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e9b2614eb57771f5969d69b79c4bce5479ccf40a
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-06T22:55:55.294Z",
"gitSha": "1fc0fb926e0c2e5cbd5a19368951857e39c41b15",
"branch": "backport-20328-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2011.1779999999726,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.3480000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328,
"heapDeltaBytes": 563816,
"heapUsedBytes": 68279672,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.350999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2011.0939999999573,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.718999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.23300000000006,
"heapDeltaBytes": 551984,
"heapUsedBytes": 68012832,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.312999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1690.8709999999587,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.474000000000002,
"layouts": 12,
"layoutDurationMs": 3.965,
"taskDurationMs": 623.374,
"heapDeltaBytes": -2182620,
"heapUsedBytes": 66661220,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 118.82400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1729.1119999999864,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.560000000000002,
"layouts": 12,
"layoutDurationMs": 3.8609999999999998,
"taskDurationMs": 706.479,
"heapDeltaBytes": -2731412,
"heapUsedBytes": 64017860,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 141.50199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.777000000031,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.738000000000001,
"layouts": 6,
"layoutDurationMs": 1.053,
"taskDurationMs": 283.065,
"heapDeltaBytes": 4097592,
"heapUsedBytes": 72440160,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.253,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.3009999999958,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.440999999999997,
"layouts": 6,
"layoutDurationMs": 1.144,
"taskDurationMs": 348.40200000000004,
"heapDeltaBytes": 3804540,
"heapUsedBytes": 71377692,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.662999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 543.988000000013,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.079,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.54200000000003,
"heapDeltaBytes": -8094016,
"heapUsedBytes": 59834460,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 127.24000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 581.9119999999884,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.376999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.146,
"heapDeltaBytes": -6492280,
"heapUsedBytes": 61838668,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 139.127,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571433,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1021.8759999999634,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.584,
"heapDeltaBytes": 13860240,
"heapUsedBytes": 95908360,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 52.959,
"eventListeners": 0,
"totalBlockingTimeMs": 384,
"frameDurationMs": 29.902941176470584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1020.2470000000403,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 677.3799999999999,
"heapDeltaBytes": 38620364,
"heapUsedBytes": 108241540,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 57.403,
"eventListeners": 0,
"totalBlockingTimeMs": 389,
"frameDurationMs": 29.902941176470584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.2379999999735,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.8189999999999,
"heapDeltaBytes": 17186880,
"heapUsedBytes": 104420056,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 117.17700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 23.04117647058825,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 799.1989999999305,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.9609999999999,
"heapDeltaBytes": 18338592,
"heapUsedBytes": 104208564,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 128.93500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 22.857142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7090.386000000024,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0069999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6308.207,
"heapDeltaBytes": -4382512,
"heapUsedBytes": 80253372,
"domNodes": -142,
"jsHeapTotalBytes": -8523776,
"scriptDurationMs": 5068.994,
"eventListeners": -78,
"totalBlockingTimeMs": 45,
"frameDurationMs": 25.175886524822698,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7360.057000000097,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6623.181,
"heapDeltaBytes": -518552,
"heapUsedBytes": 84334324,
"domNodes": -142,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 5318.543,
"eventListeners": -74,
"totalBlockingTimeMs": 37,
"frameDurationMs": 25.313745704467355,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6696.058999999991,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0620000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6001.493,
"heapDeltaBytes": -566588,
"heapUsedBytes": 85180872,
"domNodes": -172,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 4788.760000000001,
"eventListeners": -86,
"totalBlockingTimeMs": 66,
"frameDurationMs": 25.571374045801527,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7139.560000000074,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6397.405,
"heapDeltaBytes": 7922592,
"heapUsedBytes": 93728828,
"domNodes": -143,
"jsHeapTotalBytes": -8261632,
"scriptDurationMs": 5073.4490000000005,
"eventListeners": -82,
"totalBlockingTimeMs": 47,
"frameDurationMs": 25.11654929577465,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2009.555999999975,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1260000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.92,
"heapDeltaBytes": -9844080,
"heapUsedBytes": 79600348,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.032000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.5659999999734,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.008000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.7509999999999,
"heapDeltaBytes": -9914836,
"heapUsedBytes": 78287564,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.342999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2121.174999999994,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.581,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1265.807,
"heapDeltaBytes": -18395580,
"heapUsedBytes": 70817748,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 678.8629999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2185.0089999999227,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.280999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1396.773,
"heapDeltaBytes": -20523280,
"heapUsedBytes": 68927468,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 725.182,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66564885496183,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3187.0720000000006,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.249999999999998,
"layouts": 60,
"layoutDurationMs": 13.321000000000002,
"taskDurationMs": 1322.635,
"heapDeltaBytes": 1241328,
"heapUsedBytes": 69937176,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 639.4580000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665968586387432,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3236.370999999963,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.989,
"layouts": 60,
"layoutDurationMs": 14.292,
"taskDurationMs": 1418.9260000000002,
"heapDeltaBytes": 1211764,
"heapUsedBytes": 70052040,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 662.586,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665463917525773,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2230.6969999999637,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.720999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1490.789,
"heapDeltaBytes": 4097520,
"heapUsedBytes": 73102068,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 789.5680000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79242424242424,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2473.2460000000174,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.775,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1626.7710000000002,
"heapDeltaBytes": 5826172,
"heapUsedBytes": 74347224,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 847.811,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77959183673469,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.050000000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2569999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.571,
"heapDeltaBytes": -9213716,
"heapUsedBytes": 80708864,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.787999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.926999999967,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4350000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.426,
"heapDeltaBytes": 13754972,
"heapUsedBytes": 81497588,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.349,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 527.8820000000337,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.958,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.843,
"heapDeltaBytes": -12339652,
"heapUsedBytes": 57499800,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 117.316,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.891999999938,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.362000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.105,
"heapDeltaBytes": -11999216,
"heapUsedBytes": 57943124,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 126.582,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669696969696968,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2011.7290000000025,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.027000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.104,
"heapDeltaBytes": 1114832,
"heapUsedBytes": 70499168,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.902999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.4110000000337,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.8070000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.71900000000005,
"heapDeltaBytes": 1025760,
"heapUsedBytes": 70752540,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.636,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.0879999999888,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.351000000000003,
"layouts": 16,
"layoutDurationMs": 5.148,
"taskDurationMs": 614.709,
"heapDeltaBytes": -6096232,
"heapUsedBytes": 63662480,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 91.631,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.3189999999786,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.851000000000003,
"layouts": 16,
"layoutDurationMs": 4.817,
"taskDurationMs": 644.93,
"heapDeltaBytes": -6334528,
"heapUsedBytes": 63415888,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 93.24200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1101.0519999999815,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.002000000000002,
"layouts": 5,
"layoutDurationMs": 10.965,
"taskDurationMs": 769.515,
"heapDeltaBytes": -1713952,
"heapUsedBytes": 83366444,
"domNodes": 14227,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 24.853,
"eventListeners": 2463,
"totalBlockingTimeMs": 85,
"frameDurationMs": 19.29999999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8163.3600000000115,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.572,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4331.246999999999,
"heapDeltaBytes": -19130448,
"heapUsedBytes": 69587656,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 2191.169,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666326530612245,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8264.396000000033,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.229,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4913.168,
"heapDeltaBytes": -19008604,
"heapUsedBytes": 69587468,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2413.289,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14729.355999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14167.496,
"heapDeltaBytes": -30994696,
"heapUsedBytes": 185879036,
"domNodes": -3046,
"jsHeapTotalBytes": 13651968,
"scriptDurationMs": 217.484,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.846842105263157,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 15650.05199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15062.746999999998,
"heapDeltaBytes": -41606708,
"heapUsedBytes": 181099664,
"domNodes": -3045,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 237.899,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.895365418894833,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 17758.842000000015,
"styleRecalcs": 150,
"styleRecalcDurationMs": 15.632000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17384.776,
"heapDeltaBytes": -21495620,
"heapUsedBytes": 192195984,
"domNodes": -3045,
"jsHeapTotalBytes": 7290880,
"scriptDurationMs": 692.908,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 33.1147113594041,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18585.85800000003,
"styleRecalcs": 142,
"styleRecalcDurationMs": 18.849000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18299.893999999997,
"heapDeltaBytes": -9794596,
"heapUsedBytes": 183031012,
"domNodes": -3044,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 749.7139999999999,
"eventListeners": -14907,
"totalBlockingTimeMs": 21,
"frameDurationMs": 34.86416510318949,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5389.805000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.71099999999999,
"layouts": 20,
"layoutDurationMs": 22.378000000000007,
"taskDurationMs": 5319.638,
"heapDeltaBytes": 786752,
"heapUsedBytes": 214727504,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 86.58999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.02515337423312,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6209.628000000066,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.43800000000003,
"layouts": 20,
"layoutDurationMs": 27.482000000000006,
"taskDurationMs": 6000.397,
"heapDeltaBytes": -13178248,
"heapUsedBytes": 222674164,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 105.88600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.78423913043479,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7926.836999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7651.857,
"heapDeltaBytes": -21750128,
"heapUsedBytes": 181403016,
"domNodes": -3045,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 119.57400000000007,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.63898916967509,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7839.098000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7630.3009999999995,
"heapDeltaBytes": -26996812,
"heapUsedBytes": 176073720,
"domNodes": -3045,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 118.78999999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.175899280575546,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 108.33500000001095,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.976,
"layouts": 3,
"layoutDurationMs": 1.5769999999999997,
"taskDurationMs": 73.351,
"heapDeltaBytes": 3807308,
"heapUsedBytes": 69696636,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.526000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 110.19499999997606,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.336,
"layouts": 3,
"layoutDurationMs": 1.488,
"taskDurationMs": 77.45600000000003,
"heapDeltaBytes": 3709852,
"heapUsedBytes": 68794300,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.981999999999994,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 744.8859999999513,
"styleRecalcs": 78,
"styleRecalcDurationMs": 99.699,
"layouts": 76,
"layoutDurationMs": 25.419,
"taskDurationMs": 719.543,
"heapDeltaBytes": -15568680,
"heapUsedBytes": 69277084,
"domNodes": 76,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 274.615,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444456,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 560.685000000035,
"styleRecalcs": 78,
"styleRecalcDurationMs": 80.248,
"layouts": 76,
"layoutDurationMs": 19.814,
"taskDurationMs": 521.829,
"heapDeltaBytes": -17641072,
"heapUsedBytes": 67237572,
"domNodes": 76,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 198.656,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.17272727272727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1304.7659999999723,
"styleRecalcs": 78,
"styleRecalcDurationMs": 272.14500000000004,
"layouts": 76,
"layoutDurationMs": 28.189,
"taskDurationMs": 1277.8280000000002,
"heapDeltaBytes": 8516560,
"heapUsedBytes": 114778092,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 390.11100000000005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538461,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1291.5719999999737,
"styleRecalcs": 78,
"styleRecalcDurationMs": 266.218,
"layouts": 76,
"layoutDurationMs": 27.167,
"taskDurationMs": 1260.905,
"heapDeltaBytes": 8351856,
"heapUsedBytes": 115340052,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 394.078,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666233766233756,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of PR 20328.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #20352 +/- ##
==========================================
Coverage 85.90% 85.90%
==========================================
Files 2461 2461
Lines 140588 140588
Branches 38212 38212
==========================================
+ Hits 120768 120774 +6
+ Misses 19442 19436 -6
Partials 378 378
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
🔗 Commit SHA: c4b6727 | Docs | View more details | Give us feedback! |
Backport of #20328 to
core/1.56Automatically created by backport workflow.