Repository navigation
fix: stop Nodes Manager grid overflowing the dialog at >=3000px viewports - #18605
Conversation
…orts The manager dialog declared its size in three places. Above a 3000px viewport two of them disagreed and the inner layout rendered 2200px wide inside the 1724px `overflow: hidden` dialog panel, slicing the rightmost card column. - GlobalDialog.vue carried an unlayered `.manager-dialog` rule that applied the panel's dimensions to the BaseModalLayout root, and its `@media (min-width: 3000px)` block raised that root to 2200px. - MANAGER_CONTENT_CLASS's `min-[3000px]:max-w-[2200px]` is emitted before `sm:max-w-[1724px]`, so the panel never widened to match. Make the dialog panel the single source of truth: drop the global rule, add a `fill` BaseModalLayout size that defers to the panel, and cap the panel through `w-*` so the 3000px override is a variant of the same utility rather than a lower-precedence `max-w-*`. Geometry below 3000px is unchanged; at >=3000px the panel now uses the 2200x1320 bounds it already declared.
Addresses review feedback: - useManagerDialog.test.ts asserted the `max-w-*` strings the fix replaces, so it went red on this branch. Assert the `w-*` caps instead and correct the stale docblock. - Drop the animation wait from the breakpoint test: `offsetWidth` ignores transforms, and PrimeVue's skeleton shimmer keeps `getAnimations()` non-zero until pack data lands, so the poll could time out. - Hoist the duplicated manager panel locator, and record why the styleless `manager-dialog` class and `sm:max-w-none` both have to stay. - Rename the BaseModalLayout size to `panel`; `fill` read as a synonym for the existing `full`.
…mment Second-round review feedback: - measureGridOverflow compared against the panel's border box, so up to ~1.5px of real clipping reported as zero. Derive the edge the browser actually clips at from clientLeft/clientWidth. - The `panel` size comment described the failure backwards: a max-width cap can only under-fill the panel, never overflow it. What overflowed was the viewport-relative width, which does not track the parent. - Record why the breakpoint assertion is relational rather than exact.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2242 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 382303f5ceabd3dbded47b433fcf838b2d1bf7eb
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.33 MB gzip 🟢 -60 BDetailsSummary
Category Glance App Entry Points — 4.25 kB (baseline 4.25 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.08 MB (baseline 2.08 MB) • 🟢 -76 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 144 kB (baseline 144 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 670 kB (baseline 670 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 18 unchanged User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 8 unchanged Editors & Dialogs — 133 kB (baseline 133 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 3 unchanged UI Components — 213 kB (baseline 213 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 15 unchanged Data & Services — 3.41 MB (baseline 3.41 MB) • 🔴 +23 BStores, services, APIs, and repositories
Status: 18 added / 18 removed / 4 unchanged Utilities & Hooks — 736 kB (baseline 736 kB) • 🔴 +18 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 27 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.7 MB (baseline 18.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 83 added / 83 removed / 252 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-08T03:41:15.035Z",
"gitSha": "9c866c17f94d6a2c1f6c41c04fab821115cf88ba",
"branch": "glary/fix-manager-dialog-width-overflow",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.3900000000012,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6950000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.039,
"heapDeltaBytes": 6311632,
"heapUsedBytes": 70641904,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.73,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2041.007000000036,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.2589999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.99399999999997,
"heapDeltaBytes": -52204732,
"heapUsedBytes": 56952576,
"domNodes": -212,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 12.378,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1752.443000000028,
"styleRecalcs": 53,
"styleRecalcDurationMs": 15.027000000000001,
"layouts": 12,
"layoutDurationMs": 5.518999999999999,
"taskDurationMs": 816.5260000000001,
"heapDeltaBytes": 970072,
"heapUsedBytes": 57466188,
"domNodes": -209,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 140.91099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1997.9429999999638,
"styleRecalcs": 50,
"styleRecalcDurationMs": 19.831,
"layouts": 12,
"layoutDurationMs": 6.698,
"taskDurationMs": 1134.354,
"heapDeltaBytes": 936548,
"heapUsedBytes": 58085384,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 199.587,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1742.5160000000233,
"styleRecalcs": 18,
"styleRecalcDurationMs": 7.612000000000001,
"layouts": 3,
"layoutDurationMs": 1.1959999999999997,
"taskDurationMs": 429.60999999999996,
"heapDeltaBytes": -50101368,
"heapUsedBytes": 59893532,
"domNodes": -167,
"jsHeapTotalBytes": -1835008,
"scriptDurationMs": 13.169999999999998,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.8000000000675,
"styleRecalcs": 19,
"styleRecalcDurationMs": 8.159,
"layouts": 3,
"layoutDurationMs": 1.277,
"taskDurationMs": 435.12899999999996,
"heapDeltaBytes": 7197276,
"heapUsedBytes": 70259376,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.802,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 744.3869999999606,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.876,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.077,
"heapDeltaBytes": -39688836,
"heapUsedBytes": 70145628,
"domNodes": -212,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 162.28199999999998,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.053488372093028,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 889.4070000000056,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.420999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 667.6850000000001,
"heapDeltaBytes": -37777632,
"heapUsedBytes": 72297132,
"domNodes": -212,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 191.908,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.979245283018876,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1161.077999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 825.197,
"heapDeltaBytes": 12621052,
"heapUsedBytes": 93275844,
"domNodes": 0,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 63.430000000000014,
"eventListeners": 0,
"totalBlockingTimeMs": 529,
"frameDurationMs": 34.31470588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1161.7670000000544,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 842.8509999999999,
"heapDeltaBytes": 16371680,
"heapUsedBytes": 98024140,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 61.93499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 539,
"frameDurationMs": 34.31470588235294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 813.7279999999691,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.37799999999993,
"heapDeltaBytes": -7436632,
"heapUsedBytes": 80981600,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 134.77,
"eventListeners": 0,
"totalBlockingTimeMs": 188,
"frameDurationMs": 24.020588235294085,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 827.619000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.6590000000005,
"heapDeltaBytes": 19036164,
"heapUsedBytes": 101318016,
"domNodes": 0,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 147.69700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 195,
"frameDurationMs": 24.508823529411742,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9655.119000000013,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.7430000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8749.086,
"heapDeltaBytes": 11032140,
"heapUsedBytes": 99775464,
"domNodes": -141,
"jsHeapTotalBytes": -2494464,
"scriptDurationMs": 7195.829000000001,
"eventListeners": -73,
"totalBlockingTimeMs": 1033,
"frameDurationMs": 33.74020979020979,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8434.063999999922,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7569.942000000001,
"heapDeltaBytes": 15127000,
"heapUsedBytes": 91592092,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6190.418000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 276,
"frameDurationMs": 32.18740458015267,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9236.937000000013,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.4389999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8414.638,
"heapDeltaBytes": 9718204,
"heapUsedBytes": 82307292,
"domNodes": -141,
"jsHeapTotalBytes": -11407360,
"scriptDurationMs": 6644.305,
"eventListeners": -69,
"totalBlockingTimeMs": 366,
"frameDurationMs": 31.19256756756757,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9516.963000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8685.974000000002,
"heapDeltaBytes": -11543368,
"heapUsedBytes": 71563104,
"domNodes": 0,
"jsHeapTotalBytes": -8650752,
"scriptDurationMs": 6882.43,
"eventListeners": 0,
"totalBlockingTimeMs": 569,
"frameDurationMs": 31.72066666666667,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2052.035999999987,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.529,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.431,
"heapDeltaBytes": -47774408,
"heapUsedBytes": 85487320,
"domNodes": -308,
"jsHeapTotalBytes": -3244032,
"scriptDurationMs": 41.38400000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.208999999919,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.354000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 804.19,
"heapDeltaBytes": 1739136,
"heapUsedBytes": 90402916,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 50.961999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2610.1939999999786,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.224,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1690.1999999999998,
"heapDeltaBytes": -4169980,
"heapUsedBytes": 79776868,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 876.4029999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.773548387096778,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3108.6420000000317,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.349999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2012.8270000000002,
"heapDeltaBytes": 1484840,
"heapUsedBytes": 94140292,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 1060.3690000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755675675675683,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3579.270000000008,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.194,
"layouts": 60,
"layoutDurationMs": 19.096999999999998,
"taskDurationMs": 1580.4099999999999,
"heapDeltaBytes": 9540952,
"heapUsedBytes": 76447512,
"domNodes": -284,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 790.586,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66588785046729,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4361.803000000009,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.376000000000001,
"layouts": 60,
"layoutDurationMs": 22.332,
"taskDurationMs": 2348.171,
"heapDeltaBytes": 15900916,
"heapUsedBytes": 87021660,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 1092.26,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.730384615384615,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3120.9910000000036,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.9620000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1792.197,
"heapDeltaBytes": 24413204,
"heapUsedBytes": 95282760,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 1013.403,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756216216216213,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3942.346000000043,
"styleRecalcs": 39,
"styleRecalcDurationMs": 5.575,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2608.333,
"heapDeltaBytes": 354132,
"heapUsedBytes": 67630332,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1287.137,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.808547008547013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2043.5529999999744,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.4200000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.6489999999999,
"heapDeltaBytes": -21345376,
"heapUsedBytes": 86251288,
"domNodes": -308,
"jsHeapTotalBytes": -3280896,
"scriptDurationMs": 36.074999999999996,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.973999999971,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.7279999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.302,
"heapDeltaBytes": 20619468,
"heapUsedBytes": 85899724,
"domNodes": -308,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 40.49900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.702000000012,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.5649999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.44499999999994,
"heapDeltaBytes": 13224816,
"heapUsedBytes": 70011800,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.18999999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 759.3040000000428,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.480999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.2439999999999,
"heapDeltaBytes": 13406028,
"heapUsedBytes": 77078736,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.911,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2010.2919999999926,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9860000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.17600000000004,
"heapDeltaBytes": 10419608,
"heapUsedBytes": 80529080,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.544999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2048.597000000086,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.348999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 617.494,
"heapDeltaBytes": -31520276,
"heapUsedBytes": 60641452,
"domNodes": -230,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 13.915000000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.4650000000133,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.422,
"layouts": 16,
"layoutDurationMs": 6.1450000000000005,
"taskDurationMs": 792.3739999999999,
"heapDeltaBytes": 23845068,
"heapUsedBytes": 80568336,
"domNodes": -227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 99.04199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1980.0570000001017,
"styleRecalcs": 80,
"styleRecalcDurationMs": 24.566000000000003,
"layouts": 16,
"layoutDurationMs": 8.307,
"taskDurationMs": 1164.8349999999998,
"heapDeltaBytes": 23794812,
"heapUsedBytes": 80451884,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 154.93699999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491525,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.6549999999916,
"styleRecalcs": 20,
"styleRecalcDurationMs": 27.058,
"layouts": 6,
"layoutDurationMs": 13.469999999999999,
"taskDurationMs": 926.8459999999999,
"heapDeltaBytes": 32014740,
"heapUsedBytes": 109783300,
"domNodes": 14650,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 34.297,
"eventListeners": 2456,
"totalBlockingTimeMs": 135,
"frameDurationMs": 19.109333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8676.593000000026,
"styleRecalcs": 251,
"styleRecalcDurationMs": 23.910999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6027.536,
"heapDeltaBytes": 646848,
"heapUsedBytes": 92302916,
"domNodes": 0,
"jsHeapTotalBytes": 1277952,
"scriptDurationMs": 2964.3489999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69826589595376,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12179.460999999947,
"styleRecalcs": 247,
"styleRecalcDurationMs": 29.824,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7461.713,
"heapDeltaBytes": -17252524,
"heapUsedBytes": 71113044,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 3443.2299999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.71181318681319,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17587.52800000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16912.038,
"heapDeltaBytes": -39451932,
"heapUsedBytes": 190172028,
"domNodes": -3046,
"jsHeapTotalBytes": 15532032,
"scriptDurationMs": 325.816,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.032935153583615,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 18061.53800000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17926.430000000004,
"heapDeltaBytes": -40095432,
"heapUsedBytes": 184891388,
"domNodes": -3046,
"jsHeapTotalBytes": 8966144,
"scriptDurationMs": 403.622,
"eventListeners": -14915,
"totalBlockingTimeMs": 16,
"frameDurationMs": 34.511089866156794,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 15492.773,
"styleRecalcs": 74,
"styleRecalcDurationMs": 9.25300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15052.831,
"heapDeltaBytes": -13420308,
"heapUsedBytes": 187047932,
"domNodes": -3046,
"jsHeapTotalBytes": 5890048,
"scriptDurationMs": 1014.116,
"eventListeners": -14913,
"totalBlockingTimeMs": 104,
"frameDurationMs": 28.500366972477064,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 22674.376999999935,
"styleRecalcs": 166,
"styleRecalcDurationMs": 25.005000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22592.051,
"heapDeltaBytes": -45155580,
"heapUsedBytes": 184942148,
"domNodes": -3046,
"jsHeapTotalBytes": 9863168,
"scriptDurationMs": 1053.966,
"eventListeners": -14913,
"totalBlockingTimeMs": 30,
"frameDurationMs": 45.33160000000001,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6387.682000000041,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.17299999999999,
"layouts": 20,
"layoutDurationMs": 29.65799999999999,
"taskDurationMs": 6306.977999999999,
"heapDeltaBytes": -21733748,
"heapUsedBytes": 208072892,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 133.77500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.54764705882352,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6620.8729999999605,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.81199999999998,
"layouts": 20,
"layoutDurationMs": 33.209,
"taskDurationMs": 6582.608,
"heapDeltaBytes": 754284,
"heapUsedBytes": 218521680,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 139.75799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.249112426035495,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8902.513999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8647.873000000001,
"heapDeltaBytes": -21174160,
"heapUsedBytes": 196525284,
"domNodes": -3046,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 165.26000000000008,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.96498316498316,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6698.197999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6536.246999999999,
"heapDeltaBytes": -32837772,
"heapUsedBytes": 189391720,
"domNodes": -3046,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 133.84799999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.59014084507042,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "workflow-execution",
"durationMs": 593.9730000000054,
"styleRecalcs": 21,
"styleRecalcDurationMs": 23.018,
"layouts": 6,
"layoutDurationMs": 3.2320000000000007,
"taskDurationMs": 276.806,
"heapDeltaBytes": -49090500,
"heapUsedBytes": 58434556,
"domNodes": -92,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 29.396,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.228125000000006,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 492.1199999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 13.377000000000002,
"layouts": 3,
"layoutDurationMs": 1.3650000000000004,
"taskDurationMs": 127.86899999999999,
"heapDeltaBytes": 6281796,
"heapUsedBytes": 62675264,
"domNodes": 105,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.265,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 920.5220000000054,
"styleRecalcs": 78,
"styleRecalcDurationMs": 95.979,
"layouts": 76,
"layoutDurationMs": 25.881,
"taskDurationMs": 885.2990000000001,
"heapDeltaBytes": 18381956,
"heapUsedBytes": 94823252,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 348.46,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 881.9110000000592,
"styleRecalcs": 78,
"styleRecalcDurationMs": 94.492,
"layouts": 76,
"layoutDurationMs": 27.589,
"taskDurationMs": 846.3589999999999,
"heapDeltaBytes": 17849964,
"heapUsedBytes": 94712288,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 335.778,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1535.2809999999408,
"styleRecalcs": 78,
"styleRecalcDurationMs": 282.81899999999996,
"layouts": 76,
"layoutDurationMs": 35.693999999999996,
"taskDurationMs": 1521.487,
"heapDeltaBytes": 10815864,
"heapUsedBytes": 124220808,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 490.82399999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.134567901234565,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1513.0409999999301,
"styleRecalcs": 78,
"styleRecalcDurationMs": 275.032,
"layouts": 76,
"layoutDurationMs": 34.516999999999996,
"taskDurationMs": 1488.85,
"heapDeltaBytes": -18818360,
"heapUsedBytes": 116105080,
"domNodes": 76,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 478.00399999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.72345679012346,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. 9 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe Manager dialog now uses viewport-clamped width classes and a panel-filling modal size. The change removes its global sizing rules and adds unit and browser tests for width breakpoints and grid overflow. ChangesManager dialog sizing
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The examined sizing concern is not a regression introduced by this PR. No actionable merge-blocking risk is established; the change appears mergeable after normal checks. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18605 +/- ##
==========================================
+ Coverage 85.72% 86.54% +0.81%
==========================================
Files 3562 2507 -1055
Lines 170649 142409 -28240
Branches 46785 38458 -8327
==========================================
- Hits 146293 123248 -23045
+ Misses 22341 18775 -3566
+ Partials 2015 386 -1629
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1063 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Thanks — noting the approval with no actionable comments, so there's nothing to change on my side. Recording the final CI state for whoever picks this up next:
The CI Playwright run is the meaningful one here: these three tests are new, and until this run they had only been executed locally. They pass on all 16 chromium shards. One thing worth pre-empting since it renders red: the bundle report currently shows +285 kB gzip. That is baseline drift, not this PR — the comparison ran against a 9.69 MB / 448-bundle baseline and reports Still worth a human call on one deliberate behaviour change, flagged in the description: at ≥3000px the panel now actually uses the 2200×1320 bounds it already declared (previously the width half of that breakpoint was dead code while the height half worked). Below 3000px the geometry is byte-identical to |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
| // Caps live in `w-*`, not `max-w-*`: a `min-[3000px]:max-w-*` is emitted before | ||
| // the `sm:max-w-*` that `dialogContentVariants` adds, so it never wins. | ||
| // `sm:max-w-none` drops that variant cap, making `size: 'full'` inert here. | ||
| const MANAGER_CONTENT_CLASS = |
There was a problem hiding this comment.
🟡 Medium — sm:max-w-none drops the size: 'full' cap sm:max-w-[calc(100vw-var(--workspace-inset-right,0px)-1rem)], yet the width is still measured against the full viewport (min(90vw,1724px)) while dialogContentVariants centres the panel at left: calc(50% - inset/2). With a non-zero --workspace-inset-right the panel's left edge goes negative and covers the left nav, and the cap was never what blocked the 3000px step since min(90vw, …) can never exceed 100vw - 1rem. Keep an inset-aware sm:max-w-[calc(100vw-var(--workspace-inset-right,0px)-1rem)] (as SETTINGS_CONTENT_CLASS, HUG_CONTENT_CLASS, useShareDialog and useAssetBrowserDialog all do) or fold the inset into the min(). Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
There was a problem hiding this comment.
No longer applies after merging main. #20002 dropped the inset from the size variants, so the full cap is now sm:max-w-[calc(100vw-1rem)], which min(90vw, …) never exceeds, and #20328 keeps the centring translate from pushing the panel off the left edge when it cannot fit beside a docked panel. Removing the cap with sm:max-w-none changes nothing there.
| // Derives the box from the dialog panel. Any independently specified width | ||
| // — `90vw` above especially — does not track the panel and is clipped by its | ||
| // `overflow: hidden` whenever it resolves wider. | ||
| panel: 'size-full' |
There was a problem hiding this comment.
🟢 Low — panel: 'size-full' is the only SIZE_CLASSES entry with no intrinsic dimensions, so it resolves to 0×0 unless an ancestor has a definite size; it works today only because MANAGER_CONTENT_CLASS supplies h-[80vh] max-h-[1026px] on the Reka DialogContent. That contract is now split across two files with nothing enforcing it, so dropping the height there or using size="panel" from a host without a definite height yields a silently invisible modal rather than a visible failure. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
There was a problem hiding this comment.
Fair, panel relies on the host giving the dialog content a definite size. The manager is its only user and MANAGER_CONTENT_CLASS supplies the height, so leaving it as is; a second user would be the point to make that contract explicit.
| const clipEdge = | ||
| panel.left + panelElement.clientLeft + panelElement.clientWidth | ||
| const overflowPx = (element: Element) => | ||
| Math.max(0, Math.round(element.getBoundingClientRect().right - clipEdge)) |
There was a problem hiding this comment.
🟢 Low — overflowPx clamps with Math.max(0, …) and only looks at the right edge, so both sizing tests assert one direction of a two-directional invariant. A layout that under-fills — narrower or shorter than the panel, which is exactly how size-full can fail — still reports { gridOverflowPx: 0, clippedCards: 0 } and passes; measuring the signed delta and also checking the bottom edge would actually pin the panel-derived box. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
There was a problem hiding this comment.
Agreed it is one-directional, but the regression is overflow, and the 3000px breakpoint test separately pins that the panel actually widens. An under-filling layout would be a different bug; not adding a check for it here.
jaeone94
left a comment
There was a problem hiding this comment.
LGTM. I confirmed the bug still reproduces on current main: running this PR's grid-sizing specs against a main build, the 3440px case overflows by 454px with 6 clipped cards and the panel stays at 1724px past the 3000px breakpoint. The compiled CSS shows the ordering described above, with min-[3000px]:max-w-[2200px] emitted before sm:max-w-[1724px].
Making the panel the single source of truth and moving the caps to w-* is the right fix. Widening to 2200px at 3000px+ matches what was already declared, so I'm fine keeping it.
I merged main and pushed b5c2ac0, which drops two explanatory comments. The ManagerDialog.vue note stays, since it guards the closest() boundary. The Cursor threads are answered; the inset concern no longer applies after #20002 and #20328. CI is green.
…omfy-Org#16352) ## Summary Replace the remaining PrimeVue dialog and simple-component usage with the Reka/shadcn-vue design system, keeping the global dialog service contract. ## Changes - **What**: Migrates global and node-search dialogs, skeletons, button stragglers, and the single knob consumer. Reduces the PrimeVue import allowlist from 46 to 23 files. - **What**: `DialogComponentProps` is a closed type listing only the fields `GlobalDialog` reads. The inert `renderer: 'reka'` option, `unstyled`, `position`, and the PrimeVue maximize/hide callbacks are gone. No internal caller or public custom-node code found by GitHub code search passes them; the documented extension API (`extensionManager.dialog.prompt`/`confirm`) is unchanged. - **What**: `rekaPrimeVueBridge` is renamed to `dialogDismissGuards` and drops the `.p-*` overlay selectors, because no PrimeVue overlay component remains. - **What**: Confirm dialogs settle once: repeated activation no longer calls `onConfirm` again. - **What**: The knob moves into the design system as `ui/knob/Knob.vue` (stories and tests, `defineModel`); `InputKnob` forwards `disabled` to it. `Skeleton` is back to the shadcn shape (`data-slot`, class only); callers size it with Tailwind classes instead of PrimeVue `width`/`height` props. - **What**: Every dialog is modal. `GlobalDialog` drops the `modal` and `dismissOnFocusOutside` options; Settings, Manager, the legacy pricing dialog and the folder customization dialog were non-modal only for PrimeVue overlays. `ui/dialog/Dialog.vue` now forwards props with `useForwardPropsEmits`, which fixes an omitted `modal` being boolean-cast to `false` (node search, its filter dialog, the secret and skill-pack forms and video help were silently non-modal). `DialogOverlay` is the plain Reka overlay again. `SearchableSingleSelect` wraps its content in a `FocusScope`, as `MultiSelectContent` already does, so it takes focus inside a modal dialog. - **What**: Escape is derived from the active dialog's `closable`; the `closeOnEscape` option and `updateCloseOnEscapeStates` are gone. `dismissableMask` is renamed `dismissOnPointerDownOutside` after the Reka event. `useOverlayChildStyle` and the `contentStyle` threading through the asset and manager dialogs are removed; the `ui/` selects already lift themselves above the modal. - **What**: The canvas toolbar is a plain flex container again, so it keeps the shared floating-panel radius; `ButtonGroup`'s `rounded-md` had overridden it. The design-system `Skeleton` carries `data-slot="skeleton"`, which the billing e2e uses to detect loading. - **What**: Dialog styling lives in the design system instead of callers. `contentClass`, `headerClass`, `bodyClass`, `footerClass` and `overlayClass` are gone. A **headless** dialog's component is the whole panel (surface, width, close button) and `GlobalDialog` gives it a transparent shell that hugs it; about 25 workspace, billing and agent panels already worked this way through a copied `SELF_STYLED` class. A **framed** dialog uses the standard card (`rounded-2xl border-border-default`) at a `size`: `sm`/`md`/`lg`/`xl`, `fit` (hug the content) or `full` (editors: 90vw × 90vh, inset-aware). `flush` replaces the three padding overrides for dialogs whose header, body and footer components pad themselves (confirm, the small layout dialogs, model upload, mask and layer editors). `BaseModalLayout` paints its own card and owns the large sizes (Settings, Templates and Publish at `md`; Manager, model selector and asset browser at `lg`, keeping Comfy-Org#18605's 3000px step). The mask editor e2e finds the dialog by its key instead of the `.mask-editor-dialog` hook class. - **What**: Toasts sit on the toast dock's fixed layer above every dialog, whatever opened first; before, a dialog opened after a toast covered it. While a modal dialog is open the toast column moves to the top of the window, into the scrim margin above the dialog, so it no longer covers the close button (WCAG 2.4.11 Focus Not Obscured: notifications that appear on their own must not hide the focused control). - **What**: `DialogContent` focuses a descendant marked `autofocus` on open, as the native `<dialog>` does; `GlobalDialog`'s copy of that logic is removed. Node search uses it instead of focusing its input on mount, and drops its inner `FocusScope`: once node search became modal, Reka's trapped scope (whose mutation observer runs even while paused) pulled focus off the input on the first re-render, so Enter and the arrow keys stopped working. - **Breaking (TypeScript only, accepted)**: `DialogComponentProps` no longer accepts PrimeVue-era options (`pt`, `unstyled`, `position`, `renderer`, `closeOnEscape`, `modal`, `dismissOnFocusOutside`, `contentClass`, `headerClass`, `bodyClass`, `footerClass`, `overlayClass`, arbitrary keys) and renames `dismissableMask` to `dismissOnPointerDownOutside`. TypeScript callers that pass them now get a type error. `GlobalDialog` already ignored the PrimeVue-only keys at runtime; a JavaScript caller passing `closeOnEscape`, `modal`, `dismissOnFocusOutside`, `dismissableMask` or one of the class options now loses that behavior silently (Escape follows `closable`, every dialog is modal, outside clicks do not dismiss). The search below found no such caller. This follows the no-compat-without-verified-usage rule. Evidence: GitHub code search outside this repo (`gh search code` for `dialogComponentProps`, `showExtensionDialog`, `showLayoutDialog`, `extensionManager.dialog`, `unstyled dialogComponentProps`) found no custom node passing dialog props. The only matches were copies of this repo's own `dialogStore.ts`/`dialogService.ts` and calls to `extensionManager.dialog.prompt`/`confirm` (Comfy-Org/docs `javascript_dialog.mdx`, ComfyUI-React-Extension-Template, ComfyUI-Manager, AlekPet, comfyui-deploy, ComfyUI-iTools) and `showErrorDialog` (VideoHelperSuite). None of them pass `dialogComponentProps`, and this PR leaves those signatures unchanged. - **Breaking (extension DOM, accepted)**: every dialog is modal, so while one is open the page outside it takes no pointer input. An extension that appends its own UI to `document.body` from inside a dialog gets no clicks until that dialog closes. Native `<dialog>` elements opened with `showModal()` are the exception: they take pointer input again, so rgthree-comfy's settings dialog, opened from its row in Settings, works on the first click. The mask editor no longer carries the `mask-editor-dialog` class, which cg-image-filter and Comfyui_LG_Tools use to find it. No compatibility shim is added for either; the supported path is `extensionManager.dialog` (`prompt`, `confirm`, `showExtensionDialog`), whose dialogs stack with the open one. ## Review Focus Global dialog stacking, dismissal, maximize behavior, nested overlay z-index, and node-search focus, dismissal, and placement. ## Screenshots Main on the left, this PR on the right. Each dialog is opened through the same opener on both builds, 1280×720 at 2×, against a local ComfyUI backend, and clipped to the dialog. Cloud-only panels (workspace, billing, pricing, SSO) render on the OSS build without account data, so some show empty or error states. Where an opener is gated on the cloud build or a feature flag, the component is opened through `dialogStore` with each build's own dialog props. <details> <summary>Toast over an open dialog</summary> A toast now stays above every dialog whatever opened first. While a modal dialog is open, the toast moves into the margin above the dialog instead of covering its close button. Settings open, then a toast arrives:  Toast shown, then Settings opens. On main the dialog covers the toast:  </details> <details> <summary>Framed dialogs (standard card)</summary> Framed dialogs use the design-system card: `rounded-2xl` and `border-border-default` instead of `rounded-lg` and `border-border-subtle`. Sign-in and update password size to their content with `size: 'fit'`. Prompt (`extensionManager.dialog.prompt`):  Confirm (`extensionManager.dialog.confirm`):  Error dialog:  Sign in:  Update password:  Billing coming soon (`size: 'sm'`; main narrowed it to 360px):  Typeform survey (the form itself is blocked offline on both):  Customize folder (node library), now a modal dialog:  </details> <details> <summary>Sectioned dialogs (<code>flush</code>)</summary> Dialogs whose header, body and footer components pad themselves use `flush` instead of zeroing padding with `headerClass`, `bodyClass` and `footerClass`. Confirm dialog with sections (`showConfirmDialog`). Width follows the standard `md` size: 576px instead of 512px:  Edit keybinding (small layout):  Node pack conflicts (small layout):  Import failed (small layout):  </details> <details> <summary>Editors (<code>full</code> size)</summary> `full` is the editor size: 90vw × 90vh, inset-aware. Mask editor:  Layer editor (maximized; the header border and padding now live in its header component):  3D viewer frame (placeholder content), now 90% of the screen instead of 80%:  </details> <details> <summary>Headless panels</summary> These components draw their own card. `headless` now gives them a transparent shell that hugs the panel, replacing the `SELF_STYLED` and 360px class strings the callers used to pass. They should look the same. Partner nodes sign-in:  Create workspace:  Delete workspace:  Leave workspace:  Invite members:  Invite link invalid:  Revoke invite:  Top up credits:  Insufficient credits (member):  Subscription paused:  Subscription inactive (member):  Cancel subscription:  SSO required:  Clear queue history:  Deploy to Comfy API:  Cloud notification:  Open shared workflow:  Share workflow:  Manager survey:  Builder: empty workflow:  </details> <details> <summary>Pricing dialogs</summary> The pricing surface (`bg-secondary-background` and its custom shadow) moves from the caller's `contentClass` onto each pricing component's root. The legacy workspace table is now modal; its popover stays keyboard-reachable. Legacy pricing:  Legacy workspace pricing:  Unified pricing:  </details> <details> <summary>Large layouts (<code>BaseModalLayout</code>)</summary> `BaseModalLayout` paints its own card and owns the large sizes: Settings, Templates and Publish use `md`; Manager, the model selector and the asset browser use `lg`. Settings:  Templates:  Manager:  Publish:  Model selector:  Asset browser:  </details> <details> <summary>Node search</summary> On main, node search is a PrimeVue dialog; it is now a modal Reka dialog. At this viewport, both versions keep main's position and width. Node search v2 (default):  Node search v1 (legacy):  </details> <details> <summary>Canvas toolbar</summary> The toolbar is a plain flex container again, so it keeps the shared floating-panel radius. Canvas toolbar:  </details> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com>
PR Created by the Glary-Bot Agent
Fixes the Nodes Manager truncation reported in FE-2807.
The bug
At a viewport width of exactly 3000px and above, the rightmost node pack column is sliced vertically. 2999px is fine; 3000px clips 477px off the right. That threshold is why it only reproduces on ultrawide/4K displays.
The dialog's size was declared in three places, and above 3000px two of them disagreed:
DialogContent,overflow: hidden)MANAGER_CONTENT_CLASSBaseModalLayoutroot).manager-dialogCSS inGlobalDialog.vueGlobalDialog.vuecarried an unscoped, unlayered.manager-dialogrule. That class sits on the innerBaseModalLayoutroot, and because plain rules outrank@layer utilities, its@media (min-width: 3000px) { max-width: 2200px }beat the element's ownmin-[1450px]:max-w-[1724px].min-[3000px]:max-w-[2200px](order 11490) beforesm:max-w-[1724px](order 11540). Equal specificity, later wins — so the panel stayed pinned at 1724px and itsmin-[3000px]widening was dead code. (min-[3000px]:max-h-[1320px]did apply, since nothing competes with it — hence the width/height asymmetry.)Inner 2200px inside a 1724px clipping parent → 477px clipped. The virtualized grid is not at fault:
VirtualGrid's column math is correct at every width tested; it faithfully filled a container CSS had already made too wide.The fix
Make the dialog panel the single source of truth.
.manager-dialogblock fromGlobalDialog.vue. It duplicated the panel's dimensions onto the wrong element. (Audited: every property it set is already covered by the panel's own classes.)panelsize toBaseModalLayout(size-full) and use it for the manager, so the layout root derives its box from the panel instead of from90vw. This is the structural guarantee — a parent-relative width cannot exceed the parent.w-*instead ofmax-w-*, so the 3000px override is a variant of the same utility. Tailwind always emits variants after their base, so ordering is no longer load-bearing.sm:max-w-nonedrops the capdialogContentVariantscontributes.class="manager-dialog"stays — it is now styleless but is still theclosest()boundary forPackVersionBadge's popover. That's commented so it doesn't get "cleaned up".Behaviour
Measured across 800 → 3840px: no overflow at any width, zero clipped cards.
Tests (TDD)
Three E2E cases added to
browser_tests/tests/dialogs/managerDialog.spec.ts. Verified red before the fix, green after:The 2560px case is a non-regression guard (below the breakpoint, passes on
maintoo); 3440px is the reported regression.Verification
pnpm test:browser:local managerDialog.spec.ts— 13/13 pass (10 pre-existing + 3 new), run against a live backend.pnpm test:uniton the touched areas — 657/657 pass, includinguseManagerDialog.test.ts, whose assertions are updated to the new caps.pnpm typecheck,pnpm format:checkclean;pnpm lint0 errors.mainand on this branch, none in touched areas.Screenshots
First is the originally reported bug; second is this branch at 3440×1440.
Noted, not changed
aspect-[20/13]inSIZE_CLASSES.lgis inert —widthandheightare both definite, so CSS ignores the ratio. Left alone; it affects other dialogs.size: 'full'on the manager'sdialogComponentPropsis provably inert, both before and after this change. Pre-existing; a separate cleanup.Screenshots