Repository navigation
[backport core/1.55] fix(dialog): keep modal size independent of the docked Agent panel - #20125
Conversation
…20002) *PR Created by the Glary-Bot Agent* --- ## Summary Dialogs no longer resize when the Agent panel is docked, and the panel can no longer push them off the left edge of the screen ([PM-1865](https://linear.app/comfyorg/issue/PM-1865/test-forced-open-agent-panel-overlaps-the-template-pop-up-for-first)). ## Changes - **What**: `dialogContentVariants` read `--workspace-inset-right` in two places: every `size` variant subtracted it from `max-width`, and the `maximized: false` variant shifted the box left by half of it. Large dialogs pin their own `max-width`, so they got the shift without the cap. At 1440px with a 420px panel, Templates rendered at `x = -138`, clipped on the left and still over the panel. - Size variants now resolve against the viewport alone (`sm:max-w-96 / xl / 3xl / 5xl`, the same 24/36/48/64rem), and the four call sites that only used the inset to shrink drop it. - The shift is clamped: `translate-x-[max(calc(min(0.5rem,100vw-100%)-50vw),calc(-50%-var(--workspace-inset-right,0px)/2))]`. A dialog keeps its size. It centres beside the panel when it fits there; otherwise it stops at the viewport gutter and covers the panel. `min(0.5rem,100vw-100%)` lets a viewport-wide dialog sit at `x = 0`. - The offset stays on `translate`: the `zoom-in-95` keyframes write `transform`, so an offset there would animate in from off screen. - `HUG_CONTENT_CLASS` and `SELF_STYLED_PANEL_CONTENT_CLASS` move next to `dialogContentVariants`, because the asset browser's class became identical to the latter. The share dialog drops a `sm:max-w-xl` that repeated the default `md` size. - **Breaking**: no API change; deliberate behaviour change below. ## Review Focus 1. Dialogs may now cover the docked panel instead of shrinking beside it. Keeping a dialog's size and keeping it on screen cannot both clear the panel once `dialogWidth > viewportWidth - panelWidth`. Stacking holds today: the docked panel is `relative` with no z-index, and `DialogContent` is `fixed z-1700`. 2. Two places keep the opposite policy. `load3dViewerDialog.ts` stays inset-aware (#19729; `load3dAgentUpdate.spec.ts` asserts the viewer clears the panel), and its own `max-w` keeps it on the centring branch of the clamp. #19972 would make Settings inset-aware too, and its centering unit test expects an inset-aware `left-*` class that this PR replaces with `left-1/2`, so whichever merges second fails that test. 3. With no panel (inset 0) the clamp resolves to `-50%` for every width the base `w-[calc(100vw-1rem)]` allows, so layout without a panel is unchanged. - Fixes PM-1865 ## Testing `browser_tests/tests/dialogs/dialogAgentPanelInset.spec.ts` opens real dialogs, publishes a 420px inset (the seam `toastNotifications.spec.ts` uses), and asserts that the box keeps its size and lands at a literal x: | Dialog | Viewport | x | On `main` | | --- | --- | --- | --- | | Templates | 1440 | 8 (covers the panel from the gutter) | fails, x = -138 | | Templates | 1920 | 50 (centred beside the panel) | passes; fails if the floor always wins | | `md` confirm | 640 | 8, width kept at 576 | fails, width shrinks | Real-dialog coverage for the entrance animation, the viewport-wide survey dialog, and stacking over the real panel is tracked in [FE-3198](https://linear.app/comfyorg/issue/FE-3198/playwright-coverage-of-real-dialogs-under-the-docked-agent-panel). ## Screenshots Simulated 420px docked panel on the right.      --------- Co-authored-by: Glary Bot <bot@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org>
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2151 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 21a2405b142dbe2f233b7f112a0cbcbe7dcd2c03
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-04T21:39:22.561Z",
"gitSha": "f07b224f657a1553a653927e7a5f4d2f637bc717",
"branch": "backport-20002-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.8839999999664,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.134000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.584,
"heapDeltaBytes": 9669848,
"heapUsedBytes": 78375420,
"domNodes": -258,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.174000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2000.0610000000734,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.553000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.37300000000005,
"heapDeltaBytes": -2286572,
"heapUsedBytes": 66542436,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.727,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1712.6889999999548,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.576999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.0489999999999,
"heapDeltaBytes": -7340644,
"heapUsedBytes": 61508328,
"domNodes": -258,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 115.963,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1685.4989999999361,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.758000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.239,
"heapDeltaBytes": -6545120,
"heapUsedBytes": 62228156,
"domNodes": -257,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 114.93,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.7969999999846,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.043000000000001,
"layouts": 6,
"layoutDurationMs": 0.9359999999999999,
"taskDurationMs": 262.096,
"heapDeltaBytes": 2923692,
"heapUsedBytes": 71446808,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.700999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.689000000063,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.663,
"layouts": 6,
"layoutDurationMs": 0.8920000000000001,
"taskDurationMs": 207.497,
"heapDeltaBytes": 3226196,
"heapUsedBytes": 71882060,
"domNodes": 76,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 9.601,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 534.5570000000066,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.263000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.993,
"heapDeltaBytes": 18183864,
"heapUsedBytes": 86709656,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 129.768,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 530.7820000000447,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.164,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.26,
"heapDeltaBytes": 18502156,
"heapUsedBytes": 87057236,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 129.389,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1035.7930000000124,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 688.6640000000001,
"heapDeltaBytes": -18205704,
"heapUsedBytes": 73009268,
"domNodes": -293,
"jsHeapTotalBytes": 19267584,
"scriptDurationMs": 48.91000000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 386,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1063.3530000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 717.8959999999998,
"heapDeltaBytes": -18087740,
"heapUsedBytes": 73241272,
"domNodes": -292,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 48.18899999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 411,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.1360000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.82400000000007,
"heapDeltaBytes": 14674304,
"heapUsedBytes": 90862720,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.90999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 766.7989999999918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.86600000000004,
"heapDeltaBytes": 15911332,
"heapUsedBytes": 91181532,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.71399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7660.459000000003,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.5770000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6689.950000000001,
"heapDeltaBytes": 12642636,
"heapUsedBytes": 93965924,
"domNodes": -16,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 5469.655,
"eventListeners": 0,
"totalBlockingTimeMs": 64,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7498.143000000027,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.9030000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6647.918,
"heapDeltaBytes": 16045248,
"heapUsedBytes": 95491388,
"domNodes": -268,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 5462.325,
"eventListeners": -174,
"totalBlockingTimeMs": 37,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7272.050999999976,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.598000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6488.878000000001,
"heapDeltaBytes": 16446544,
"heapUsedBytes": 95200776,
"domNodes": -268,
"jsHeapTotalBytes": 3137536,
"scriptDurationMs": 5275.028,
"eventListeners": -174,
"totalBlockingTimeMs": 101,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6703.728999999953,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.5730000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6003.982000000001,
"heapDeltaBytes": 5163860,
"heapUsedBytes": 83515036,
"domNodes": -271,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 4821.96,
"eventListeners": -174,
"totalBlockingTimeMs": 33,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2011.0879999999725,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.642,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.6519999999999,
"heapDeltaBytes": -16644120,
"heapUsedBytes": 72895776,
"domNodes": -237,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 27.793000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.395999999948,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.831000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.9429999999999,
"heapDeltaBytes": 9525272,
"heapUsedBytes": 73272780,
"domNodes": -237,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.296000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2084.8669999999743,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.697000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1174.5220000000002,
"heapDeltaBytes": 6496,
"heapUsedBytes": 64604180,
"domNodes": 10,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 641.577,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2094.1480000000183,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.341000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1170.3329999999999,
"heapDeltaBytes": 750344,
"heapUsedBytes": 65166668,
"domNodes": 12,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 633.861,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3223.6969999999587,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.411000000000001,
"layouts": 60,
"layoutDurationMs": 12.482999999999999,
"taskDurationMs": 1412.3520000000003,
"heapDeltaBytes": -18522488,
"heapUsedBytes": 73574380,
"domNodes": -236,
"jsHeapTotalBytes": 6582272,
"scriptDurationMs": 669.292,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3191.1830000000236,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.725,
"layouts": 60,
"layoutDurationMs": 12.677000000000001,
"taskDurationMs": 1362.8290000000002,
"heapDeltaBytes": -18708896,
"heapUsedBytes": 72309168,
"domNodes": -236,
"jsHeapTotalBytes": 5795840,
"scriptDurationMs": 633.512,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2262.6050000000077,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.827,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1451.034,
"heapDeltaBytes": 11358580,
"heapUsedBytes": 98494028,
"domNodes": 16,
"jsHeapTotalBytes": 5435392,
"scriptDurationMs": 763.227,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2502.7509999999893,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.704000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1491.604,
"heapDeltaBytes": 7671276,
"heapUsedBytes": 73575480,
"domNodes": 12,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 806.478,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2010.432000000037,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.142999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.531,
"heapDeltaBytes": -17416484,
"heapUsedBytes": 73443452,
"domNodes": -238,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 28.451999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.3619999999346,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.527000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.06499999999994,
"heapDeltaBytes": -23851144,
"heapUsedBytes": 67180456,
"domNodes": -255,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 28.980999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 503.7900000000377,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.495,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.086,
"heapDeltaBytes": 13478456,
"heapUsedBytes": 83863364,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 116.282,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 460.7469999999694,
"styleRecalcs": 50,
"styleRecalcDurationMs": 10.211000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 287.276,
"heapDeltaBytes": 13176480,
"heapUsedBytes": 84107892,
"domNodes": 26,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 115.49099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.265000000008,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.433000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.7,
"heapDeltaBytes": 11006144,
"heapUsedBytes": 81423572,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.204000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.0620000000326,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.707000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.12499999999994,
"heapDeltaBytes": -4160740,
"heapUsedBytes": 59842860,
"domNodes": -273,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.125000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.0429999999692,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.464,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.927,
"heapDeltaBytes": 7314288,
"heapUsedBytes": 77754700,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 79.15700000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.426000000045,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.728,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.5849999999999,
"heapDeltaBytes": -10364204,
"heapUsedBytes": 59988048,
"domNodes": -273,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 79.814,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 851.052999999979,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.801000000000002,
"layouts": 5,
"layoutDurationMs": 9.353,
"taskDurationMs": 662.9310000000002,
"heapDeltaBytes": 20176208,
"heapUsedBytes": 103523896,
"domNodes": 13667,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 20.782000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 88,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8192.467000000022,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.494,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4310.594,
"heapDeltaBytes": -6199136,
"heapUsedBytes": 83381808,
"domNodes": -246,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 2152.138,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8175.156000000015,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.541000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4253.534,
"heapDeltaBytes": -1451836,
"heapUsedBytes": 88076316,
"domNodes": -239,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 2127.158,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13897.359999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13780.173,
"heapDeltaBytes": -43357424,
"heapUsedBytes": 195126140,
"domNodes": -8062,
"jsHeapTotalBytes": -7798784,
"scriptDurationMs": 193.556,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 13860.519000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13642.024999999998,
"heapDeltaBytes": -50199568,
"heapUsedBytes": 176147620,
"domNodes": -8062,
"jsHeapTotalBytes": -15142912,
"scriptDurationMs": 192.07,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13535.182000000077,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13150.709000000003,
"heapDeltaBytes": -28718480,
"heapUsedBytes": 184034196,
"domNodes": -8062,
"jsHeapTotalBytes": -3653632,
"scriptDurationMs": 713.244,
"eventListeners": -14928,
"totalBlockingTimeMs": 54,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16607.038999999986,
"styleRecalcs": 108,
"styleRecalcDurationMs": 12.644000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16347.11,
"heapDeltaBytes": -41361828,
"heapUsedBytes": 180543784,
"domNodes": -8062,
"jsHeapTotalBytes": -22700032,
"scriptDurationMs": 689.615,
"eventListeners": -14928,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5031.846999999971,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.976999999999975,
"layouts": 20,
"layoutDurationMs": 21.313,
"taskDurationMs": 4979.327999999999,
"heapDeltaBytes": -43163728,
"heapUsedBytes": 184042576,
"domNodes": -8062,
"jsHeapTotalBytes": 12517376,
"scriptDurationMs": 78.84299999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 201,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5087.462999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.84700000000001,
"layouts": 20,
"layoutDurationMs": 21.40600000000001,
"taskDurationMs": 4990.257,
"heapDeltaBytes": -36847780,
"heapUsedBytes": 198733580,
"domNodes": -8062,
"jsHeapTotalBytes": 19013632,
"scriptDurationMs": 82.24199999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 177,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7021.670000000086,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6811.937,
"heapDeltaBytes": -19909860,
"heapUsedBytes": 164323628,
"domNodes": 0,
"jsHeapTotalBytes": -17039360,
"scriptDurationMs": 99.437,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7014.18799999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6897.639000000002,
"heapDeltaBytes": -1586404,
"heapUsedBytes": 180031148,
"domNodes": 0,
"jsHeapTotalBytes": -17039360,
"scriptDurationMs": 96.31599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 97.22600000009152,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.787000000000003,
"layouts": 6,
"layoutDurationMs": 2.221,
"taskDurationMs": 75.06299999999999,
"heapDeltaBytes": 3241724,
"heapUsedBytes": 69582840,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.59,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 445.76099999994767,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.507,
"layouts": 5,
"layoutDurationMs": 2.1060000000000003,
"taskDurationMs": 100.229,
"heapDeltaBytes": 4995832,
"heapUsedBytes": 71326660,
"domNodes": 148,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.300000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #20125 +/- ##
=============================================
- Coverage 84.88% 84.88% -0.01%
=============================================
Files 2327 2327
Lines 132831 132831
Branches 35521 33625 -1896
=============================================
- Hits 112750 112749 -1
- Misses 19719 19720 +1
Partials 362 362
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head backport review at fd308ca35a: source PR #20002 merged as 209054fdea8ce10c627743ff3e604fd77408cf39; the carrier preserves all six source files and the complete 102-addition/29-deletion change, including the black-box browser_tests/tests/dialogs/dialogAgentPanelInset.spec.ts coverage. I inspected every hunk. The only carrier-only delta is merge commit fd308ca35a, which incorporates current core/1.55 tip 21a2405b142dbe2f233b7f112a0cbcbe7dcd2c03; that target delta changes only src/platform/assets/services/assetService.ts and its unit test, with no conflict or semantic interaction with the dialog/modal change. No target-specific repair or exclusion is needed. No unresolved review finding is present on this carrier. Merge remains gated on exact-head required-green CI and the target-aware merge-ready guard.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| true: 'inset-2 top-2 left-2 size-auto max-h-none max-w-none sm:max-w-none', | ||
| false: | ||
| 'top-1/2 left-[calc(50%-var(--workspace-inset-right,0px)/2)] max-h-[85vh] w-[calc(100vw-1rem)] -translate-1/2' | ||
| 'top-1/2 left-1/2 max-h-[85vh] w-[calc(100vw-1rem)] translate-x-[max(calc(min(0.5rem,100vw-100%)-50vw),calc(-50%-var(--workspace-inset-right,0px)/2))] -translate-y-1/2' |
There was a problem hiding this comment.
🟡 Medium — Moving the panel offset out of left and into translate-x makes the left-1/2 opt-out that four shipped dialogs pass via contentClass inert (src/services/hdrViewerService.ts, src/components/sidebar/tabs/AssetsSidebarTab.vue, src/components/sidebar/tabs/JobHistorySidebarTab.vue, src/workbench/extensions/agent/components/agent/message/ReplyAssetGroup.vue): those classes used to beat the inset-shifted left, but they cannot override this translate-x, so those w-[80vw] media viewers move from the true viewport centre to the clamped gutter (x=192 to x=8 with a 420px panel at 1920px). Either preserve their centring explicitly or delete the now-dead left-1/2 overrides so the next editor isn't misled. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
There was a problem hiding this comment.
Confirmed. These four left-1/2 classes were introduced together in #16198 specifically as overrides of the inset-shifted base left; moving the offset to translate-x makes all four overrides dead and changes their docked-panel geometry. This is a source-level issue in merged #20002, not a core/1.55 target conflict. The carrier job authorizes only target-specific repair, so I am leaving this thread unresolved and holding the backport. Wake condition: a source fix/decision lands on main and is carried here, or the owning human explicitly rules that these media viewers should adopt the shifted/clamped policy and removes the misleading overrides.
There was a problem hiding this comment.
Measured, and the diagnosis needs correcting: this is not a source-level issue in #20002. Those four left-1/2 overrides do not exist on main.
#19729 (merged 2026-10-02, two days before #20002) deleted all four of them and routed every viewer entry point — HDR, Assets, Job History, Agent reply, the node, and viewer controls — through one shared LOAD3D_VIEWER_DIALOG_PROPS whose contentClass is inset-aware in both the unprefixed and sm:-prefixed max-w groups. That cap is exactly 100vw - inset - 1rem, which keeps the viewer on the centring branch of the new clamp. Measured against the real 420px docked panel at main 94ddfcc78d:
| viewport | viewer x | viewer right | panel left |
|---|---|---|---|
| 1280 | 8 | 852 | 860 |
| 1440 | 8 | 1012 | 1020 |
| 1920 | 8 | 1492 | 1500 |
It clears the panel at every width. There is nothing dead and nothing to repair at source.
The regression is real, but it is release-line-only, and it is caused by #19729 being absent there rather than by anything #20002 did. core/1.55, cloud/1.55, core/1.54 and cloud/1.54 all still carry the pre-#19729 contentClass (left-1/2 w-[80vw] sm:max-w-[80vw] …), because #19729 has no backport. Measured by restoring that string on top of each dialog variant:
| file state | viewer x | width | viewer right | panel left @1920 |
|---|---|---|---|---|
| release branches, pre-#20002 | 192 | 1536 | 1728 | 1500 |
| release branches + #20002 clamp | 8 | 1536 | 1544 | 1500 |
main (#19729 + #20002) |
8 | 1484 | 1492 | 1500 |
So the "x=192 → x=8" figure is right, and the override is genuinely inert in row 2 — but row 1 was already overlapping the panel by 228px. The 192px position was never correct docked behaviour; #19729 is what made it correct, and #20002 reduced the overlap from 228px to 44px rather than introducing it.
That makes this an already-merged bug-fix dependency of the carrier, so the unblock is to carry #19729 to the release lines, not to patch #20125 or change main. Two notes on urgency: cloud/1.55 already took #20002 via #20126, so it carries the 44px overlap today, independent of this PR; and core/1.55 has it at 228px right now, so merging #20125 improves that line rather than regressing it.
I have not touched the release branches — this comment is measurement only.
Separately, the gap that let this reach review is now closed at source: #20136 pins the viewer's docked-panel geometry at 1280px and 1920px. The guard in load3dAgentUpdate.spec.ts only ran at 500px and 400px, both under sm:, so it could not observe the sm:-prefixed cap at all — deleting only that declaration leaves the spec green on the parent while the viewer covers the panel by 180px at 1280px.
…er (#20141) ## Summary Backports merged #19729 to `core/1.54`, where generated 3D asset viewers still overlap the docked workspace inset. This is the dependency identified and measured by #20136; it does not include #20125. ## Changes - route Load3D/HDR viewers through the shared inset-aware dialog configuration - preserve caller-specific close behavior - add target-native browser coverage for the generated-asset viewer at a 1280px viewport with a 420px workspace inset Source: #19729, merge commit `3c4030d80e619e0276dcd65667dc793acccf1525` (cherry-picked with provenance). ## Validation - `browser_tests/tests/load3d/load3dViewer.spec.ts` — 4 passed on this exact branch - mutation restoring the target's pre-backport Assets viewer props fails the new case: dialog `x=128`, expected `8` - `pnpm typecheck` — passed - scoped oxfmt and ESLint — passed (one existing ignored-file warning for `src/extensions/core/load3d.ts`)
…wer (#20139) ## Summary Backports merged #19729 to cloud/1.55 so every Load3D/HDR viewer uses the shared inset-aware dialog configuration. This must land before or with #20125; #20136 demonstrates that #20125 without this dependency lets the viewer overlap the docked Agent panel. ## Changes - Cherry-pick source merge 3c4030d with provenance. - Preserve the shared full-size viewer configuration and responsive inset-aware width cap across all six viewer entry points. - Carry #20136 exact behavioral proof at 1280px and 1920px without changing #20125 or weakening its assertions. ## Review Focus - Confirm the unprefixed and sm-prefixed inset-aware max-width tokens remain paired with full size. - Confirm custom close behavior survives the shared configuration spread. - Confirm the above-sm browser assertion measures the real docked panel boundary and 8px gutter. ## Validation - pnpm typecheck — passed. - oxlint --type-aware on all changed files — passed. - oxfmt --check on all changed files — passed. - git diff --check — passed. - Local cloud Playwright reached fixture boot but the cloud/1.55 Load3D node rendered no canvas; all three cases stopped at the unchanged shared precondition before geometry. Hosted target-head CI is the acceptance gate. Source: #19729 Proof source: #20136 Dependency ordering: land before or with #20125.
…er (#20137) ## Summary Backports merged #19729 to core/1.55 so every Load3D/HDR viewer uses the shared inset-aware dialog configuration. This must land before or with #20125; #20136 demonstrates that #20125 without this dependency lets the viewer overlap the docked Agent panel. ## Changes - Cherry-pick source merge 3c4030d with provenance. - Preserve the shared full-size viewer configuration and responsive inset-aware width cap across all six viewer entry points. - Carry #20136 exact behavioral proof at 1280px and 1920px, without changing #20125 or weakening its assertions. ## Review Focus - Confirm the unprefixed and sm-prefixed inset-aware max-width tokens remain paired with size full. - Confirm custom close behavior survives the shared configuration spread. - Confirm the above-sm browser assertion measures the real docked panel boundary and 8px gutter. ## Validation - Playwright cloud: browser_tests/tests/load3d/load3dAgentUpdate.spec.ts, keeps the full-screen viewer inside the visible workspace inset — 1 passed. - pnpm typecheck:browser — passed. - oxlint --type-aware on all changed files — passed. - oxfmt --check on all changed files — passed. - git diff --check — passed. Source: #19729 Proof source: #20136 Dependency ordering: land before or with #20125.
Backport of #20002 to
core/1.55Automatically created by backport workflow.