Repository navigation
[backport core/1.54] fix(load3d): apply workspace inset to every viewer - #20141
christian-byrne merged 2 commits into
Conversation
## Summary - route every Load3D and HDR viewer through one inset-aware dialog configuration - remove raw-viewport centering overrides that let the docked Agent panel cover viewer content - keep the responsive 80vw cap paired with the full-size dialog variant This follows up on findings from the merged [core/1.55 backport](Comfy-Org#19702 (comment)) and [cloud/1.55 backport](Comfy-Org#19703 (comment)). ## Changes - apply the shared configuration to HDR, Agent reply, Assets, Job History, node, and viewer-control entry points - centralize `renderer`, `size`, `contentClass`, and `maximizable` so responsive geometry cannot drift across callers - remove brittle class-token assertions; browser coverage measures the visible viewer geometry ## Review Focus - confirm the shared `sm:max-w` override remains paired with `size: full` - confirm viewers with custom `onClose` behavior preserve it when spreading the shared configuration ## Validation - `oxfmt --check` passed for all nine changed files - `git diff --check` passed - the focused Vitest runner stalled before producing output in this workspace; CI is rerunning the affected suites (cherry picked from commit 3c4030d)
|
@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1984 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-05T00:13:27.863Z",
"gitSha": "b8cbe673186cc5f22bb6c55d208c13d35a613ed4",
"branch": "backport/op482-fe19729-core154",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2063.1230000000187,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.689999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.121,
"heapDeltaBytes": -12855252,
"heapUsedBytes": 61029992,
"domNodes": -279,
"jsHeapTotalBytes": 4751360,
"scriptDurationMs": 11.854999999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2034.355000000005,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.99100000000004,
"heapDeltaBytes": 5185112,
"heapUsedBytes": 76230000,
"domNodes": -285,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.059,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1751.6969999999787,
"styleRecalcs": 73,
"styleRecalcDurationMs": 23.781999999999996,
"layouts": 14,
"layoutDurationMs": 3.6209999999999996,
"taskDurationMs": 745.807,
"heapDeltaBytes": -7483680,
"heapUsedBytes": 63782004,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 127.307,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1791.7039999999815,
"styleRecalcs": 74,
"styleRecalcDurationMs": 33.118,
"layouts": 14,
"layoutDurationMs": 4.737,
"taskDurationMs": 811.5369999999999,
"heapDeltaBytes": -4349500,
"heapUsedBytes": 67510420,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 130.53799999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.4770000000162,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.894,
"layouts": 6,
"layoutDurationMs": 1.0379999999999998,
"taskDurationMs": 327.395,
"heapDeltaBytes": 4553092,
"heapUsedBytes": 74956912,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.048,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.533000000034,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.971,
"layouts": 6,
"layoutDurationMs": 0.9179999999999999,
"taskDurationMs": 333.155,
"heapDeltaBytes": 4512848,
"heapUsedBytes": 76441488,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.394,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 573.9480000000299,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.854000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.148,
"heapDeltaBytes": 18213704,
"heapUsedBytes": 89337052,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 127.743,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 602.314999999976,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.873,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.609,
"heapDeltaBytes": -9157616,
"heapUsedBytes": 64977312,
"domNodes": 20,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 130.06599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2026.1879999999906,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.913999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.677,
"heapDeltaBytes": -904804,
"heapUsedBytes": 76948352,
"domNodes": -269,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 37.251,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.1609999999923,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.3649999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.983,
"heapDeltaBytes": 12272612,
"heapUsedBytes": 90169012,
"domNodes": -281,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 35.749,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2168.6859999999797,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.629000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1339.367,
"heapDeltaBytes": -14223812,
"heapUsedBytes": 67194336,
"domNodes": -246,
"jsHeapTotalBytes": -1277952,
"scriptDurationMs": 684.184,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2188.274999999976,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.155000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1352.4689999999998,
"heapDeltaBytes": -10771824,
"heapUsedBytes": 67414240,
"domNodes": -286,
"jsHeapTotalBytes": 4874240,
"scriptDurationMs": 656.263,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3269.4419999999695,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.699000000000002,
"layouts": 60,
"layoutDurationMs": 12.307,
"taskDurationMs": 1471.8939999999998,
"heapDeltaBytes": -871892,
"heapUsedBytes": 78210676,
"domNodes": -267,
"jsHeapTotalBytes": 2514944,
"scriptDurationMs": 640.448,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3340.6219999999394,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.027,
"layouts": 60,
"layoutDurationMs": 12.701,
"taskDurationMs": 1522.4909999999998,
"heapDeltaBytes": 3354008,
"heapUsedBytes": 83157788,
"domNodes": -264,
"jsHeapTotalBytes": 3825664,
"scriptDurationMs": 660.845,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2444.817999999998,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.287999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1609.645,
"heapDeltaBytes": 7324184,
"heapUsedBytes": 89565836,
"domNodes": 12,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 804.0899999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2275.8120000000304,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.216,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1537.6060000000002,
"heapDeltaBytes": 11331712,
"heapUsedBytes": 93824360,
"domNodes": 10,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 769.4060000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.9669999999987,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.224999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.9860000000001,
"heapDeltaBytes": -11930064,
"heapUsedBytes": 67442012,
"domNodes": -285,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 31.52,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2015.3700000000754,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.439999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.587,
"heapDeltaBytes": 10703596,
"heapUsedBytes": 88949320,
"domNodes": -285,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 30.892000000000003,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 524.9410000000125,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.204,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.947,
"heapDeltaBytes": 14006780,
"heapUsedBytes": 86831272,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 117.369,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 512.3210000000427,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.777,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.97300000000007,
"heapDeltaBytes": 13744980,
"heapUsedBytes": 86857636,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 118.088,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.2159999999812,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.575,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.288,
"heapDeltaBytes": -9742576,
"heapUsedBytes": 63408652,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.478999999999997,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2017.9820000000177,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.1819999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.713,
"heapDeltaBytes": -6875760,
"heapUsedBytes": 66746084,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.918,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.8450000000203,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.304,
"layouts": 18,
"layoutDurationMs": 4.332,
"taskDurationMs": 710.905,
"heapDeltaBytes": -8786320,
"heapUsedBytes": 63845160,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 94.63099999999999,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.4070000000224,
"styleRecalcs": 78,
"styleRecalcDurationMs": 23.814,
"layouts": 18,
"layoutDurationMs": 4.244999999999999,
"taskDurationMs": 701.986,
"heapDeltaBytes": -10260396,
"heapUsedBytes": 63437304,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 90.46799999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1050.4530000000045,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.605000000000004,
"layouts": 16,
"layoutDurationMs": 12.254,
"taskDurationMs": 772.2650000000002,
"heapDeltaBytes": 22161264,
"heapUsedBytes": 105773740,
"domNodes": 13831,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 24.078999999999997,
"eventListeners": 2385,
"totalBlockingTimeMs": 98,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8307.380000000023,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.236,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4810.725,
"heapDeltaBytes": -9144624,
"heapUsedBytes": 67826936,
"domNodes": -281,
"jsHeapTotalBytes": 4087808,
"scriptDurationMs": 2216.885,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8383.55100000001,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.723,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4735.424999999999,
"heapDeltaBytes": 15960304,
"heapUsedBytes": 92447640,
"domNodes": -285,
"jsHeapTotalBytes": 3002368,
"scriptDurationMs": 2203.695,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15433.910000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14936.235,
"heapDeltaBytes": -30491252,
"heapUsedBytes": 183920668,
"domNodes": -8068,
"jsHeapTotalBytes": -13840384,
"scriptDurationMs": 230.14499999999998,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15524.876000000062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15002.909,
"heapDeltaBytes": -35126712,
"heapUsedBytes": 178816876,
"domNodes": -8068,
"jsHeapTotalBytes": -10805248,
"scriptDurationMs": 265.58899999999994,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17802.481,
"styleRecalcs": 126,
"styleRecalcDurationMs": 16.749999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17627.428000000004,
"heapDeltaBytes": -48205944,
"heapUsedBytes": 169440880,
"domNodes": -8068,
"jsHeapTotalBytes": -13672448,
"scriptDurationMs": 786.69,
"eventListeners": -14929,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18096.501999999986,
"styleRecalcs": 130,
"styleRecalcDurationMs": 17.74300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17908.631,
"heapDeltaBytes": -31818212,
"heapUsedBytes": 197361356,
"domNodes": -8068,
"jsHeapTotalBytes": -15757312,
"scriptDurationMs": 754.805,
"eventListeners": -14931,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5426.563999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.138999999999996,
"layouts": 20,
"layoutDurationMs": 22.24799999999999,
"taskDurationMs": 5390.213,
"heapDeltaBytes": -26849388,
"heapUsedBytes": 191411672,
"domNodes": -8068,
"jsHeapTotalBytes": 20201472,
"scriptDurationMs": 94.33100000000002,
"eventListeners": -14929,
"totalBlockingTimeMs": 259,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5557.045000000016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.68599999999996,
"layouts": 20,
"layoutDurationMs": 25.317000000000007,
"taskDurationMs": 5518.367999999999,
"heapDeltaBytes": -43344156,
"heapUsedBytes": 179925868,
"domNodes": -8072,
"jsHeapTotalBytes": 16539648,
"scriptDurationMs": 103.29999999999998,
"eventListeners": -14931,
"totalBlockingTimeMs": 256,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7413.966000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7280.858,
"heapDeltaBytes": 20910740,
"heapUsedBytes": 177535476,
"domNodes": 0,
"jsHeapTotalBytes": -9961472,
"scriptDurationMs": 138.805,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7548.5290000000305,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7390.827000000001,
"heapDeltaBytes": 20216960,
"heapUsedBytes": 185953420,
"domNodes": 0,
"jsHeapTotalBytes": -26738688,
"scriptDurationMs": 136.60300000000004,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 107.57599999999456,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.839,
"layouts": 3,
"layoutDurationMs": 1.2719999999999998,
"taskDurationMs": 74.02,
"heapDeltaBytes": 3042088,
"heapUsedBytes": 75065572,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.5569999999999995,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 458.9140000000498,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.918999999999993,
"layouts": 3,
"layoutDurationMs": 1.519,
"taskDurationMs": 100.89199999999998,
"heapDeltaBytes": 4907520,
"heapUsedBytes": 74555904,
"domNodes": 144,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.124,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Summary
Backports merged #19729 to
core/1.54, where generated 3D asset viewers still overlap the docked workspace inset. This is the dependency identified and measured by #20136; it does not include #20125.Changes
Source: #19729, merge commit
3c4030d80e619e0276dcd65667dc793acccf1525(cherry-picked with provenance).Validation
browser_tests/tests/load3d/load3dViewer.spec.ts— 4 passed on this exact branchx=128, expected8pnpm typecheck— passedsrc/extensions/core/load3d.ts)