Repository navigation
[backport core/1.55] fix(load3d): apply workspace inset to every viewer - #20137
Conversation
## Summary - route every Load3D and HDR viewer through one inset-aware dialog configuration - remove raw-viewport centering overrides that let the docked Agent panel cover viewer content - keep the responsive 80vw cap paired with the full-size dialog variant This follows up on findings from the merged [core/1.55 backport](#19702 (comment)) and [cloud/1.55 backport](#19703 (comment)). ## Changes - apply the shared configuration to HDR, Agent reply, Assets, Job History, node, and viewer-control entry points - centralize `renderer`, `size`, `contentClass`, and `maximizable` so responsive geometry cannot drift across callers - remove brittle class-token assertions; browser coverage measures the visible viewer geometry ## Review Focus - confirm the shared `sm:max-w` override remains paired with `size: full` - confirm viewers with custom `onClose` behavior preserve it when spreading the shared configuration ## Validation - `oxfmt --check` passed for all nine changed files - `git diff --check` passed - the focused Vitest runner stalled before producing output in this workspace; CI is rerunning the affected suites (cherry picked from commit 3c4030d)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2150 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 21a2405b142dbe2f233b7f112a0cbcbe7dcd2c03
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-04T23:51:50.865Z",
"gitSha": "54737f51b54a1174ba74a3824c3d778fdbfb1984",
"branch": "backport-19729-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.7469999999284,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.956000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.82399999999996,
"heapDeltaBytes": -10272900,
"heapUsedBytes": 58564480,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.741,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2000.2140000000281,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.535,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.86600000000004,
"heapDeltaBytes": 7954408,
"heapUsedBytes": 76456564,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.574,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1700.6240000000616,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.908999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 654.771,
"heapDeltaBytes": 9169516,
"heapUsedBytes": 77574500,
"domNodes": -257,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 122.01799999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1708.4630000000516,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.453999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 659.508,
"heapDeltaBytes": -7574452,
"heapUsedBytes": 61451892,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 121.276,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1690.967999999998,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.066,
"layouts": 6,
"layoutDurationMs": 0.9179999999999999,
"taskDurationMs": 299.643,
"heapDeltaBytes": 2947296,
"heapUsedBytes": 71815372,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.631,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.7469999999503,
"styleRecalcs": 29,
"styleRecalcDurationMs": 13.74,
"layouts": 6,
"layoutDurationMs": 1.085,
"taskDurationMs": 314.33900000000006,
"heapDeltaBytes": 3018912,
"heapUsedBytes": 71737488,
"domNodes": 78,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 13.370999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 524.1089999999531,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.597999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.047,
"heapDeltaBytes": 17889928,
"heapUsedBytes": 80569500,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 128.499,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 544.760999999994,
"styleRecalcs": 17,
"styleRecalcDurationMs": 9.142,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.15900000000005,
"heapDeltaBytes": -7950408,
"heapUsedBytes": 60783324,
"domNodes": 25,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 134.525,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1033.106000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 706.6909999999999,
"heapDeltaBytes": -14900032,
"heapUsedBytes": 72919684,
"domNodes": -295,
"jsHeapTotalBytes": 21626880,
"scriptDurationMs": 49.49200000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 399,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1032.67900000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.594,
"heapDeltaBytes": -18188524,
"heapUsedBytes": 73030496,
"domNodes": -295,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 48.729000000000006,
"eventListeners": -217,
"totalBlockingTimeMs": 387,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 769.5250000000442,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.4540000000004,
"heapDeltaBytes": 14613172,
"heapUsedBytes": 91937844,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.31999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 766.9909999999618,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.8560000000001,
"heapDeltaBytes": 14835256,
"heapUsedBytes": 90399676,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.33000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6922.825999999986,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6940000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6120.313,
"heapDeltaBytes": -9290724,
"heapUsedBytes": 71864864,
"domNodes": -16,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 5119.536,
"eventListeners": 0,
"totalBlockingTimeMs": 51,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.19999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6873.434999999972,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.5929999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6013.456,
"heapDeltaBytes": -2277236,
"heapUsedBytes": 76614684,
"domNodes": -264,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 4846.825,
"eventListeners": -174,
"totalBlockingTimeMs": 28,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6890.949999999975,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.965999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6150.594,
"heapDeltaBytes": -479940,
"heapUsedBytes": 76935084,
"domNodes": -246,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 5003.474999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 103,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6957.2449999999435,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6143.976,
"heapDeltaBytes": 8220296,
"heapUsedBytes": 83897332,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 5003.745,
"eventListeners": 0,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2023.977000000059,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.648000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.5429999999999,
"heapDeltaBytes": -23868076,
"heapUsedBytes": 65598768,
"domNodes": -252,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 29.425000000000008,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2008.0070000000205,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.567000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.27799999999996,
"heapDeltaBytes": -15410800,
"heapUsedBytes": 73655680,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.867000000000008,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2138.0960000000186,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.943999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1271.499,
"heapDeltaBytes": -2237088,
"heapUsedBytes": 87740220,
"domNodes": -251,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 651.2520000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2170.863000000054,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.196,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1411.8060000000003,
"heapDeltaBytes": 1816928,
"heapUsedBytes": 92088396,
"domNodes": -247,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 719.123,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3275.0429999999824,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.341,
"layouts": 60,
"layoutDurationMs": 13.767999999999999,
"taskDurationMs": 1467.2880000000002,
"heapDeltaBytes": -15299948,
"heapUsedBytes": 76259624,
"domNodes": -237,
"jsHeapTotalBytes": 5533696,
"scriptDurationMs": 670.1850000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3221.830999999952,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.757,
"layouts": 60,
"layoutDurationMs": 13.815000000000001,
"taskDurationMs": 1448.3349999999998,
"heapDeltaBytes": -18179980,
"heapUsedBytes": 73474480,
"domNodes": -238,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 654.845,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2533.9569999999867,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.415000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1525.283,
"heapDeltaBytes": 13733612,
"heapUsedBytes": 106594552,
"domNodes": 16,
"jsHeapTotalBytes": 6221824,
"scriptDurationMs": 806.461,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2284.0499999999793,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.372,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1565.778,
"heapDeltaBytes": -18156996,
"heapUsedBytes": 75495900,
"domNodes": 16,
"jsHeapTotalBytes": 7901184,
"scriptDurationMs": 813.805,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.661000000062,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.261000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.1979999999999,
"heapDeltaBytes": -22676916,
"heapUsedBytes": 68437604,
"domNodes": -251,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 37.20199999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2036.660999999981,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.540000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.3010000000001,
"heapDeltaBytes": -23796564,
"heapUsedBytes": 66859756,
"domNodes": -248,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 34.243,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.9960000000492,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.126,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.39799999999997,
"heapDeltaBytes": 13897236,
"heapUsedBytes": 84167860,
"domNodes": 23,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 121.55699999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 515.1270000000068,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.356,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.771,
"heapDeltaBytes": 13501384,
"heapUsedBytes": 84033976,
"domNodes": 23,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 123.199,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.1469999999517,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.674,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.61600000000004,
"heapDeltaBytes": 5411664,
"heapUsedBytes": 75949476,
"domNodes": -272,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.701000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.5619999999835,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.123,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.346,
"heapDeltaBytes": 10910696,
"heapUsedBytes": 81493980,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.721,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.2970000000587,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.08,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.849,
"heapDeltaBytes": 4184236,
"heapUsedBytes": 74648132,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 84.931,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.625000000111,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.584999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 651.611,
"heapDeltaBytes": 6937448,
"heapUsedBytes": 77329128,
"domNodes": -259,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 91.46600000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 884.5690000000559,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.15600000000001,
"layouts": 5,
"layoutDurationMs": 9.363999999999999,
"taskDurationMs": 686.828,
"heapDeltaBytes": -6267876,
"heapUsedBytes": 81619432,
"domNodes": 13667,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 20.653,
"eventListeners": 2383,
"totalBlockingTimeMs": 83,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8200.20199999999,
"styleRecalcs": 252,
"styleRecalcDurationMs": 43.276999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4725.7210000000005,
"heapDeltaBytes": -1950228,
"heapUsedBytes": 87437776,
"domNodes": -242,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 2270.1150000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8137.338,
"styleRecalcs": 251,
"styleRecalcDurationMs": 41.17399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4568.162,
"heapDeltaBytes": -968732,
"heapUsedBytes": 88020744,
"domNodes": -235,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2209.66,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 14708.387000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14598.753999999999,
"heapDeltaBytes": -42334500,
"heapUsedBytes": 179522932,
"domNodes": -8062,
"jsHeapTotalBytes": -19554304,
"scriptDurationMs": 217.66600000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11502.132999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11405.050000000003,
"heapDeltaBytes": -20900240,
"heapUsedBytes": 196149344,
"domNodes": -8092,
"jsHeapTotalBytes": -17272832,
"scriptDurationMs": 184.658,
"eventListeners": -14944,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17443.776999999955,
"styleRecalcs": 119,
"styleRecalcDurationMs": 16.347,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17404.082,
"heapDeltaBytes": -48692132,
"heapUsedBytes": 191356764,
"domNodes": -8061,
"jsHeapTotalBytes": -21807104,
"scriptDurationMs": 727.113,
"eventListeners": -14928,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17216.472000000067,
"styleRecalcs": 121,
"styleRecalcDurationMs": 15.574000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17146.873,
"heapDeltaBytes": -53221864,
"heapUsedBytes": 167646252,
"domNodes": -8062,
"jsHeapTotalBytes": -20193280,
"scriptDurationMs": 709.039,
"eventListeners": -14928,
"totalBlockingTimeMs": 62,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5282.603999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.948,
"layouts": 20,
"layoutDurationMs": 22.06699999999999,
"taskDurationMs": 5260.078,
"heapDeltaBytes": -56199932,
"heapUsedBytes": 184308396,
"domNodes": -8062,
"jsHeapTotalBytes": 13512704,
"scriptDurationMs": 87.11,
"eventListeners": -14928,
"totalBlockingTimeMs": 282,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4224.247999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.71300000000001,
"layouts": 20,
"layoutDurationMs": 29.39299999999999,
"taskDurationMs": 4201.7919999999995,
"heapDeltaBytes": -20032896,
"heapUsedBytes": 193078424,
"domNodes": -8099,
"jsHeapTotalBytes": 13647872,
"scriptDurationMs": 75.53099999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7392.628000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7362.078999999998,
"heapDeltaBytes": 14971396,
"heapUsedBytes": 176049996,
"domNodes": 0,
"jsHeapTotalBytes": -13893632,
"scriptDurationMs": 110.93199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7322.822000000087,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7210.018,
"heapDeltaBytes": -29903400,
"heapUsedBytes": 166581096,
"domNodes": 0,
"jsHeapTotalBytes": -31457280,
"scriptDurationMs": 104.91500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 107.12399999999889,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.161,
"layouts": 2,
"layoutDurationMs": 0.581,
"taskDurationMs": 73.14600000000002,
"heapDeltaBytes": 3198988,
"heapUsedBytes": 69581988,
"domNodes": 111,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.692999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 96.2690000000066,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.649999999999999,
"layouts": 3,
"layoutDurationMs": 1.449,
"taskDurationMs": 59.49499999999999,
"heapDeltaBytes": 2949524,
"heapUsedBytes": 69314612,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.838000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
…akpoint The Load3D/HDR viewer is the one dialog that stays inset-aware after #20002: its own `max-w-[min(80vw,calc(100vw-var(--workspace-inset-right,0px)-1rem))]` is what holds it on the centring branch of the new translate-x clamp instead of the viewport gutter floor, so it still clears the docked Agent panel while every other dialog keeps its size and covers the panel. That cap is declared twice — unprefixed and `sm:`-prefixed — because tailwind-merge treats prefixed and unprefixed `max-w-*` as separate groups, and above `sm:` only the prefixed one is live. The existing guard in this test runs at 500px and 400px, both under `sm:`, so it cannot see the prefixed cap at all: dropping it leaves this spec green while the viewer covers the panel by 180px at 1280px. Add a step at 1280px and 1920px asserting the real docked panel is flush with the right edge, the viewer sits at the 8px gutter, and its right edge stops 8px short of the panel. Measured against the real 420px docked panel at main 94ddfcc: | viewport | viewer x | viewer right | panel left | | --- | --- | --- | --- | | 1280 | 8 | 852 | 860 | | 1440 | 8 | 1012 | 1020 | | 1920 | 8 | 1492 | 1500 | (cherry picked from commit 3bca0a3)
90a325c to
94c8094
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
✅ No high-signal findings.
Panel: 1/8 reviewers contributed findings.
Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gpt-5.6-sol-max:adversarial (error), kimi-k3-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gemini-3.1-pro:edge-case (error), gpt-5.6-sol-max:edge-case (error), kimi-k3-max:edge-case (error)
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| renderer: 'reka', | ||
| size: 'full', | ||
| contentClass: | ||
| 'w-[80vw] max-w-[min(80vw,calc(100vw-var(--workspace-inset-right,0px)-1rem))] sm:max-w-[min(80vw,calc(100vw-var(--workspace-inset-right,0px)-1rem))] h-[80vh] max-h-[80vh]', |
There was a problem hiding this comment.
🟡 Medium — The inset-aware cap has no lower floor, so while the Agent panel is still docked (it only flips to overlay at roughly <=476px, publishing --workspace-inset-right: 420px) a 500px viewport resolves max-w to 100vw - 420px - 1rem = 64px, leaving an unusable sliver for a viewer whose controls sidebar alone is 288px. The three migrated callers (asset preview, job history, HDR viewer) previously used sm:max-w-[80vw] and stayed usable in that band, so they regress; wrapping the cap in max(20rem, ...) keeps the overlap fix without the degenerate range. Raised by 2 of 8 reviewers (gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial).
| // The cap is declared twice — unprefixed and `sm:`-prefixed — because | ||
| // tailwind-merge treats those as separate groups, so only the prefixed one | ||
| // is live here. The narrow-viewport steps below run under `sm:` and cannot | ||
| // see it: drop it and they still pass while the viewer covers the panel. |
There was a problem hiding this comment.
🟢 Low — The sm:-prefixed copy of the cap is a no-op, so this comment's rationale is inverted: with size: 'full', dialogContentVariants already emits sm:max-w-[calc(100vw-var(--workspace-inset-right,0px)-1rem)], and because w-[80vw] pins the width the used width is min(80vw, 100vw-inset-1rem) with or without the duplicate. Deleting it leaves both the 1280 and 1920 assertions passing rather than letting the viewer cover the panel — only the unprefixed cap is load-bearing, and the 500px step already exercises that. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| contentClass: 'left-1/2 w-[80vw] sm:max-w-[80vw] h-[80vh] max-h-[80vh]', | ||
| maximizable: true | ||
| } | ||
| dialogComponentProps: LOAD3D_VIEWER_DIALOG_PROPS |
There was a problem hiding this comment.
🟢 Low — This site hands the shared module-level object to the dialog store by reference (as do JobHistorySidebarTab.vue and hdrViewerService.ts) while the other three call sites spread it. It is safe only because createDialog shallow-copies before GlobalDialog.toggleMaximize writes maximized in place and before merge mutates pt; spread consistently or Object.freeze the constant so one viewer's maximize state cannot leak into the others. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| // The panel is docked against the right edge, so its left edge is the | ||
| // boundary of the visible workspace. | ||
| expect(panelBox.x + panelBox.width).toBeCloseTo(width, 1) | ||
| expect(dialogBox.x).toBeCloseTo(VIEWPORT_GUTTER, 1) |
There was a problem hiding this comment.
⚪ Nit — dialogBox.x === 8 only holds while the inset term of min(80vw, 100vw-inset-1rem) is the smaller one, i.e. while the panel inset exceeds 0.2 * viewport - 16px; that is true at 1280/1920 solely because the panel defaults to PANEL_MIN_WIDTH (420px), and above a ~2180px viewport — or after any step that narrows the panel — the 80vw branch binds and x becomes 32+, failing as a phantom positioning regression. Deriving the expected gutter from the measured panel inset would decouple it (the literal 8 also assumes a 16px root font size). Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial).
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Summary
Backports merged #19729 to core/1.55 so every Load3D/HDR viewer uses the shared inset-aware dialog configuration. This must land before or with #20125; #20136 demonstrates that #20125 without this dependency lets the viewer overlap the docked Agent panel.
Changes
Review Focus
Validation
Source: #19729
Proof source: #20136
Dependency ordering: land before or with #20125.