Skip to content

[backport cloud/1.55] fix(load3d): apply workspace inset to every viewer - #20139

Merged
christian-byrne merged 2 commits into
cloud/1.55from
christian-byrne/backport-19729-cloud-1.55
Oct 5, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.55from
christian-byrne/backport-19729-cloud-1.55

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports merged #19729 to cloud/1.55 so every Load3D/HDR viewer uses the shared inset-aware dialog configuration. This must land before or with #20125; #20136 demonstrates that #20125 without this dependency lets the viewer overlap the docked Agent panel.

Changes

Review Focus

  • Confirm the unprefixed and sm-prefixed inset-aware max-width tokens remain paired with full size.
  • Confirm custom close behavior survives the shared configuration spread.
  • Confirm the above-sm browser assertion measures the real docked panel boundary and 8px gutter.

Validation

  • pnpm typecheck — passed.
  • oxlint --type-aware on all changed files — passed.
  • oxfmt --check on all changed files — passed.
  • git diff --check — passed.
  • Local cloud Playwright reached fixture boot but the cloud/1.55 Load3D node rendered no canvas; all three cases stopped at the unchanged shared precondition before geometry. Hosted target-head CI is the acceptance gate.

Source: #19729
Proof source: #20136
Dependency ordering: land before or with #20125.

@christian-byrne
christian-byrne requested review from a team and jtydhr88 as code owners October 4, 2026 23:53
@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 457a907f-62e6-4090-9e45-defede77603f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 4, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release-backport self-review at head 10f0c5665320251877079778b407eb2c1430e672: diff matches merged source #19729 plus the exact geometry proof from #20136. The shared props retain renderer=reka, size=full, both unprefixed and sm-prefixed inset-aware max-width caps, and maximizable=true; both custom onClose callbacks still override only onClose after spreading the shared configuration. No unrelated product change found. Target-aware local typecheck, typed lint, formatting, and diff checks pass; local Playwright is blocked before geometry by cloud/1.55 fixture boot not rendering the Load3D canvas, so hosted exact-head browser CI remains required.

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2149 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2128 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/04/2026, 11:59:10 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since e20bf56342f33e3db34e0929b412cdc3992702ec

Full docs: ADR-DEVEX-LINT-0015

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.4 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 566ms TBT · 84.9 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 233ms TBT · 87.6 MB heap
extension-clean-combined-draw: · 51.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1445ms TBT · 68.2 MB heap
extension-rgthree-prototype-draw: · 51.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1077ms TBT · 73.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 141ms TBT · 99.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.2 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 51ms TBT · 178.4 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 480ms TBT · 170.7 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 453ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.7 MB
canvas-idle: DOM nodes -262
canvas-idle: event listeners -163
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 45
canvas-mouse-sweep: task duration 699ms
canvas-mouse-sweep: script duration 162ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 71.9 MB
canvas-mouse-sweep: DOM nodes -261
canvas-mouse-sweep: event listeners -152
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 348ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 68.2 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 429ms
dom-widget-clipping: script duration 167ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 58.4 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 891ms
dom-widget-order-dense-n200-w200-i120: script duration 69ms
dom-widget-order-dense-n200-w200-i120: TBT 566ms
dom-widget-order-dense-n200-w200-i120: heap used 84.9 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -296
dom-widget-order-dense-n200-w200-i120: event listeners -206
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 468ms
dom-widget-order-sparse-n1000-w20-i120: script duration 173ms
dom-widget-order-sparse-n1000-w20-i120: TBT 233ms
dom-widget-order-sparse-n1000-w20-i120: heap used 87.6 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 19ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9907ms
extension-clean-combined-draw: script duration 8332ms
extension-clean-combined-draw: TBT 1445ms
extension-clean-combined-draw: heap used 68.2 MB
extension-clean-combined-draw: DOM nodes -16
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 19ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 1
extension-rgthree-prototype-draw: task duration 9044ms
extension-rgthree-prototype-draw: script duration 7690ms
extension-rgthree-prototype-draw: TBT 1077ms
extension-rgthree-prototype-draw: heap used 73.4 MB
extension-rgthree-prototype-draw: DOM nodes -139
extension-rgthree-prototype-draw: event listeners -87
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 529ms
large-graph-idle: script duration 31ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 66.1 MB
large-graph-idle: DOM nodes -248
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1554ms
large-graph-pan: script duration 856ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 61.9 MB
large-graph-pan: DOM nodes -249
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 17ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 71
large-graph-zoom: task duration 1715ms
large-graph-zoom: script duration 825ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 77.8 MB
large-graph-zoom: DOM nodes -104
large-graph-zoom: event listeners -87
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1825ms
legacy-node-drag: script duration 1017ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 65.0 MB
legacy-node-drag: DOM nodes -111
legacy-node-drag: event listeners 104
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 9ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 547ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 63.9 MB
minimap-idle: DOM nodes -258
minimap-idle: event listeners -174
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 406ms
subgraph-dom-widget-clipping: script duration 148ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 79.9 MB
subgraph-dom-widget-clipping: DOM nodes 22
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 457ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 66.2 MB
subgraph-idle: DOM nodes -275
subgraph-idle: event listeners -209
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 15ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 46
subgraph-mouse-sweep: task duration 750ms
subgraph-mouse-sweep: script duration 110ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.0 MB
subgraph-mouse-sweep: DOM nodes -276
subgraph-mouse-sweep: event listeners -220
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 880ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 141ms
subgraph-transition-enter: heap used 99.3 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 5656ms
viewport-pan-sweep: script duration 2927ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.8 MB
viewport-pan-sweep: DOM nodes -248
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16752ms
vue-large-graph-idle: script duration 262ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 173.2 MB
vue-large-graph-idle: DOM nodes -8061
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 168
vue-large-graph-pan: task duration 20770ms
vue-large-graph-pan: script duration 942ms
vue-large-graph-pan: TBT 51ms
vue-large-graph-pan: heap used 178.4 MB
vue-large-graph-pan: DOM nodes -8061
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 80ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6057ms
vue-node-resize-workload: script duration 105ms
vue-node-resize-workload: TBT 480ms
vue-node-resize-workload: heap used 170.7 MB
vue-node-resize-workload: DOM nodes -8061
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8369ms
vue-zoom-out-idle: script duration 145ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.9 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 3
workflow-execution: style recalc count 12
workflow-execution: task duration 104ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.5 MB
workflow-execution: DOM nodes 116
workflow-execution: event listeners 57
Raw data
{
  "timestamp": "2026-10-05T00:18:45.025Z",
  "gitSha": "b2de8bb495c0c6f9b6e44605fc9c8bf20fd2fd3a",
  "branch": "christian-byrne/backport-19729-cloud-1.55",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2006.2249999999722,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.92,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.29499999999996,
      "heapDeltaBytes": -13297688,
      "heapUsedBytes": 55889660,
      "domNodes": -261,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.727999999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2014.919999999961,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.238999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.2670000000001,
      "heapDeltaBytes": 4791704,
      "heapUsedBytes": 73566272,
      "domNodes": -262,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.449999999999998,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1720.0619999999844,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 14.131,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 697.033,
      "heapDeltaBytes": 9946416,
      "heapUsedBytes": 78892232,
      "domNodes": -260,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 162.81799999999998,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1733.2979999999907,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 14.24,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 701.8839999999999,
      "heapDeltaBytes": 3076208,
      "heapUsedBytes": 71939024,
      "domNodes": -261,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 160.414,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.45799999998,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.722,
      "layouts": 6,
      "layoutDurationMs": 1.1890000000000003,
      "taskDurationMs": 367.43600000000004,
      "heapDeltaBytes": 2929580,
      "heapUsedBytes": 71531428,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 13.668,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.8359999999957,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.037,
      "layouts": 6,
      "layoutDurationMs": 1.19,
      "taskDurationMs": 327.741,
      "heapDeltaBytes": 2964532,
      "heapUsedBytes": 71432352,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.240000000000004,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 585.6130000000235,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.664000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.297,
      "heapDeltaBytes": -8063540,
      "heapUsedBytes": 60981032,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 166.50600000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 639.5559999999705,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 8.03,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 450.04,
      "heapDeltaBytes": -7661516,
      "heapUsedBytes": 61457728,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 168.38599999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1223.986000000025,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 905.578,
      "heapDeltaBytes": -17457356,
      "heapUsedBytes": 74029032,
      "domNodes": -296,
      "jsHeapTotalBytes": 21102592,
      "scriptDurationMs": 69.934,
      "eventListeners": -217,
      "totalBlockingTimeMs": 542,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1210.9510000000228,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 877.395,
      "heapDeltaBytes": 12490436,
      "heapUsedBytes": 103969092,
      "domNodes": -296,
      "jsHeapTotalBytes": 22433792,
      "scriptDurationMs": 67.33200000000001,
      "eventListeners": -195,
      "totalBlockingTimeMs": 589,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 865.9319999999866,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 454.7669999999995,
      "heapDeltaBytes": 16535556,
      "heapUsedBytes": 91892040,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 172.37399999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 233,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 845.5539999999928,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.88,
      "heapDeltaBytes": 15952660,
      "heapUsedBytes": 91765024,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 172.79,
      "eventListeners": 0,
      "totalBlockingTimeMs": 233,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10715.548000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9804.275,
      "heapDeltaBytes": -9250660,
      "heapUsedBytes": 71790328,
      "domNodes": -20,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 8180.4400000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1424,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10897.468000000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10010.218,
      "heapDeltaBytes": -10107308,
      "heapUsedBytes": 71232848,
      "domNodes": -12,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 8482.749,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1465,
      "frameDurationMs": 18.886666666666677,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10210.241000000053,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9334.144,
      "heapDeltaBytes": 4993480,
      "heapUsedBytes": 81365388,
      "domNodes": -16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 7866.482,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1071,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9554.680000000077,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.3419999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8754.578,
      "heapDeltaBytes": -5914464,
      "heapUsedBytes": 72628268,
      "domNodes": -262,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 7513.5,
      "eventListeners": -174,
      "totalBlockingTimeMs": 1082,
      "frameDurationMs": 18.886666666666677,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2033.284999999978,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 521.635,
      "heapDeltaBytes": -16410752,
      "heapUsedBytes": 72860212,
      "domNodes": -242,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 29.692000000000004,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.4720000000225,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.364,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 536.251,
      "heapDeltaBytes": -23423900,
      "heapUsedBytes": 65769856,
      "domNodes": -254,
      "jsHeapTotalBytes": 4222976,
      "scriptDurationMs": 31.936000000000007,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2299.1400000000226,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.547,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1552.8969999999997,
      "heapDeltaBytes": 20456,
      "heapUsedBytes": 64757268,
      "domNodes": -253,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 853.8639999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2216.0659999999552,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 11.74,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1555.593,
      "heapDeltaBytes": 763500,
      "heapUsedBytes": 65047988,
      "domNodes": -245,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 857.806,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3587.001999999984,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 16.761000000000003,
      "layouts": 60,
      "layoutDurationMs": 14.153,
      "taskDurationMs": 1733.6419999999998,
      "heapDeltaBytes": -26472508,
      "heapUsedBytes": 64990032,
      "domNodes": -243,
      "jsHeapTotalBytes": 4747264,
      "scriptDurationMs": 816.8820000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3539.6879999999555,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 16.499,
      "layouts": 60,
      "layoutDurationMs": 13.856,
      "taskDurationMs": 1696.3700000000001,
      "heapDeltaBytes": 6714992,
      "heapUsedBytes": 98241596,
      "domNodes": 36,
      "jsHeapTotalBytes": 6066176,
      "scriptDurationMs": 833.8089999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2940.046000000052,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.232000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1698.1970000000001,
      "heapDeltaBytes": 2884256,
      "heapUsedBytes": 69012728,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 1000.516,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3178.2380000000785,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.241000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1952.3350000000003,
      "heapDeltaBytes": -25653660,
      "heapUsedBytes": 67228408,
      "domNodes": -226,
      "jsHeapTotalBytes": 1077248,
      "scriptDurationMs": 1032.778,
      "eventListeners": 28,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2045.932999999991,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.894999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 552.4170000000001,
      "heapDeltaBytes": -23191836,
      "heapUsedBytes": 67485856,
      "domNodes": -258,
      "jsHeapTotalBytes": 4485120,
      "scriptDurationMs": 35.184,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.0860000000594,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 10.731000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 541.4539999999998,
      "heapDeltaBytes": -23976232,
      "heapUsedBytes": 66492440,
      "domNodes": -257,
      "jsHeapTotalBytes": 4747264,
      "scriptDurationMs": 34.659,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 588.0280000000084,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.07,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.9769999999999,
      "heapDeltaBytes": 13215756,
      "heapUsedBytes": 84098284,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 147.63199999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 609.986000000049,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 12.022,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 403.73199999999997,
      "heapDeltaBytes": 13493112,
      "heapUsedBytes": 83533100,
      "domNodes": 23,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 148.735,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.2560000000035,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.347,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.24399999999997,
      "heapDeltaBytes": 9257216,
      "heapUsedBytes": 79959284,
      "domNodes": -275,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.908000000000001,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.8709999999564,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.686,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 448.169,
      "heapDeltaBytes": -5274676,
      "heapUsedBytes": 58962168,
      "domNodes": -274,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.1720000000000015,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1706.6209999999842,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 15.987000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 751.6089999999999,
      "heapDeltaBytes": -10406304,
      "heapUsedBytes": 60468948,
      "domNodes": -276,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 107.98400000000001,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1722.8119999999763,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 14.642,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 747.663,
      "heapDeltaBytes": -5378564,
      "heapUsedBytes": 65297756,
      "domNodes": -276,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 112.03399999999999,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.2160000000376,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 29.105999999999995,
      "layouts": 5,
      "layoutDurationMs": 13.222999999999999,
      "taskDurationMs": 880.0139999999999,
      "heapDeltaBytes": 20291840,
      "heapUsedBytes": 104139308,
      "domNodes": 13667,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 28.785000000000004,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8325.949999999977,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 39.449,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5569.828,
      "heapDeltaBytes": -8132348,
      "heapUsedBytes": 80712776,
      "domNodes": -254,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 2845.7459999999996,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8394.092,
      "styleRecalcs": 252,
      "styleRecalcDurationMs": 39.193,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5742.246,
      "heapDeltaBytes": 3722532,
      "heapUsedBytes": 92904048,
      "domNodes": -241,
      "jsHeapTotalBytes": 1007616,
      "scriptDurationMs": 3008.278,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17232.883000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16703.069,
      "heapDeltaBytes": -62662296,
      "heapUsedBytes": 178581768,
      "domNodes": -8061,
      "jsHeapTotalBytes": -14880768,
      "scriptDurationMs": 259.707,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17429.17,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16801.024999999998,
      "heapDeltaBytes": -55729364,
      "heapUsedBytes": 184696136,
      "domNodes": -8061,
      "jsHeapTotalBytes": -14659584,
      "scriptDurationMs": 264.92,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21138.74199999998,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 17.92100000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20872.472999999998,
      "heapDeltaBytes": -33577368,
      "heapUsedBytes": 181386784,
      "domNodes": -8061,
      "jsHeapTotalBytes": -13492224,
      "scriptDurationMs": 954.217,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 38,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20912.180999999917,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 17.629999999999978,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20666.535000000003,
      "heapDeltaBytes": -48555000,
      "heapUsedBytes": 192762344,
      "domNodes": -8061,
      "jsHeapTotalBytes": -20389888,
      "scriptDurationMs": 928.8929999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 63,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6117.174999999975,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.98600000000003,
      "layouts": 20,
      "layoutDurationMs": 24.106,
      "taskDurationMs": 6056.857,
      "heapDeltaBytes": -64774304,
      "heapUsedBytes": 175542204,
      "domNodes": -8061,
      "jsHeapTotalBytes": 12341248,
      "scriptDurationMs": 103.72800000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 540,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6162.108999999987,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.38600000000001,
      "layouts": 20,
      "layoutDurationMs": 22.432999999999996,
      "taskDurationMs": 6057.454999999999,
      "heapDeltaBytes": -31769860,
      "heapUsedBytes": 182393852,
      "domNodes": -8061,
      "jsHeapTotalBytes": 15482880,
      "scriptDurationMs": 106.78900000000002,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 420,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8650.77599999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8391.107000000002,
      "heapDeltaBytes": -3688436,
      "heapUsedBytes": 191859052,
      "domNodes": 0,
      "jsHeapTotalBytes": -23855104,
      "scriptDurationMs": 131.18799999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8567.542000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8347.729000000001,
      "heapDeltaBytes": -29718292,
      "heapUsedBytes": 172804404,
      "domNodes": 0,
      "jsHeapTotalBytes": -27525120,
      "scriptDurationMs": 158.225,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 108.08199999996759,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.301000000000002,
      "layouts": 2,
      "layoutDurationMs": 0.5969999999999999,
      "taskDurationMs": 85.293,
      "heapDeltaBytes": 3204552,
      "heapUsedBytes": 69852640,
      "domNodes": 109,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.526000000000002,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 447.65399999994315,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 27.262,
      "layouts": 4,
      "layoutDurationMs": 1.8400000000000003,
      "taskDurationMs": 122.44400000000003,
      "heapDeltaBytes": 5003584,
      "heapUsedBytes": 71804308,
      "domNodes": 123,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.626000000000001,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52857 79938 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.9% 1183
src/LGraphNode.ts 70.6% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/platform/workspace/stores/billingOperationStore.ts 8.0% 332
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/LGraph.ts 78.9% 273
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/scripts/app.ts 73.2% 254
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/pnginfo.ts 20.7% 222

@christian-byrne
christian-byrne force-pushed the christian-byrne/backport-19729-cloud-1.55 branch from 10f0c56 to f732f23 Compare October 4, 2026 23:54
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 4, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Message-only release-carrier rewrite under program/release-backport-authority.md: old head 10f0c56, new head f732f23, identical tree 79053b3dafb9f0552f72b672678f49f05cf70daf. Removed only the release-branch-prohibited AI co-author trailer; preserved the source author and both cherry-pick provenance lines. Exact-lease force-push used. All hosted checks, review, and target-aware evidence must be fresh at the new head.

## Summary

- route every Load3D and HDR viewer through one inset-aware dialog
configuration
- remove raw-viewport centering overrides that let the docked Agent
panel cover viewer content
- keep the responsive 80vw cap paired with the full-size dialog variant

This follows up on findings from the merged [core/1.55
backport](#19702 (comment))
and [cloud/1.55
backport](#19703 (comment)).

## Changes

- apply the shared configuration to HDR, Agent reply, Assets, Job
History, node, and viewer-control entry points
- centralize `renderer`, `size`, `contentClass`, and `maximizable` so
responsive geometry cannot drift across callers
- remove brittle class-token assertions; browser coverage measures the
visible viewer geometry

## Review Focus

- confirm the shared `sm:max-w` override remains paired with `size:
full`
- confirm viewers with custom `onClose` behavior preserve it when
spreading the shared configuration

## Validation

- `oxfmt --check` passed for all nine changed files
- `git diff --check` passed
- the focused Vitest runner stalled before producing output in this
workspace; CI is rerunning the affected suites

(cherry picked from commit 3c4030d)
…akpoint

The Load3D/HDR viewer is the one dialog that stays inset-aware after #20002: its inset-aware max-width holds it beside the docked panel above the sm breakpoint. Add 1280px and 1920px assertions for the real panel boundary and 8px gutter.

(cherry picked from commit 3bca0a3)
@christian-byrne
christian-byrne force-pushed the christian-byrne/backport-19729-cloud-1.55 branch from f732f23 to 3818339 Compare October 4, 2026 23:57

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 4 finding(s).

Severity Count
🟢 Low 2
⚪ Nit 2

Panel: 8/8 reviewers contributed findings.

'w-[80vw] max-w-[min(80vw,calc(100vw-var(--workspace-inset-right,0px)-1rem))] h-[80vh] max-h-[80vh]'
import type { DialogComponentProps } from '@/stores/dialogStore'

export const LOAD3D_VIEWER_DIALOG_PROPS = {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — This shared object is neither frozen nor as const, and three of the five call sites (AssetsSidebarTab.vue, JobHistorySidebarTab.vue, hdrViewerService.ts) hand the module-level instance to showDialog by reference instead of spreading it. createDialog uses options.dialogComponentProps?.pt as the in-place target of es-toolkit's merge, so the day this constant gains a pt (or any other nested object) that mutation writes per-dialog state into the singleton and leaks it into every later viewer dialog. Freeze the constant or spread it at all five call sites. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).

// The panel is docked against the right edge, so its left edge is the
// boundary of the visible workspace.
expect(panelBox.x + panelBox.width).toBeCloseTo(width, 1)
expect(dialogBox.x).toBeCloseTo(VIEWPORT_GUTTER, 1)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — Asserting a fixed 8px left gutter only holds while the inset branch of min(80vw, 100vw - inset - 1rem) binds, i.e. while the panel is at least 0.2 * viewportWidth - 16 wide. That is true at 1280/1920 with the 420px panel default, but lowering PANEL_MIN_WIDTH or adding a wider viewport flips to the 80vw branch, where the viewer still centres correctly with a larger gutter and this step fails on correct layout. Since the step is named "centre the viewer", assert the centring relation (dialogBox.x close to (panelBox.x - dialogBox.width) / 2), which holds on both branches. Raised by 2 of 8 reviewers (gemini-3.1-pro edge-case, claude-opus-5-thinking-max edge-case).

contentClass: 'left-1/2 w-[80vw] sm:max-w-[80vw] h-[80vh] max-h-[80vh]',
maximizable: true
}
dialogComponentProps: LOAD3D_VIEWER_DIALOG_PROPS

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — The HDR viewer, assets sidebar, job history, and agent reply dialogs now all derive their geometry from a Load3D-owned constant, so any future Load3D-specific sizing tweak silently resizes four unrelated surfaces that have no test coverage outside the Load3D spec. Consider hoisting the shared geometry into a neutral viewer-dialog module so the blast radius of a change is explicit. Raised by 2 of 8 reviewers (gemini-3.1-pro edge-case, claude-opus-5-thinking-max adversarial).


export const LOAD3D_VIEWER_DIALOG_PROPS = {
renderer: 'reka',
size: 'full',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — size: 'full' is now inert for these dialogs: the only class that variant contributes is sm:max-w-*, and the newly added sm:max-w-[min(...)] in contentClass is merged after it, so tailwind-merge always drops it. Changing size here would have no visible effect, which could mislead a maintainer tuning the viewer width. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Playwright videos for new tests

Download the recorded videos and HTML report

Recorded projects: cloud

Recorded test titles:

  • all tests in browser_tests/tests/load3d/load3dAgentUpdate.spec.ts

@christian-byrne
christian-byrne merged commit 6801769 into cloud/1.55 Oct 5, 2026
100 checks passed
@christian-byrne
christian-byrne deleted the christian-byrne/backport-19729-cloud-1.55 branch October 5, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants