Repository navigation
fix(agent): make agent panel teardown total - #20078
Conversation
#20071 moved the `agent.graph-activity` minimap dispose into its own `onBeforeUnmount` so a throwing teardown step could no longer leave the layer id claimed. Review found that this rescues one victim and leaves the rest exposed: a throw anywhere in the large unmount hook still skips every later step, including the PM-1575 `setCanvasSyncGate` reset that the comment beside it calls the only thing standing between a resumed turn and a torn-down follower's gate. With no `app.config.errorHandler` registered, Vue's logError re-throws outside production, so the throw also abandons the remaining hooks and the rest of `unmountComponent`. Each step now runs through `runPanelTeardown`, which reports a failure as `failure_tearing_down_agent_panel` and continues -- the shape `runFollowerTeardown` already uses for the CRDT follower's own teardown. All three of this component's unmount hooks go through it, so no hook can abandon a later one.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since cb213e32e33e29aa0a6123c1a2b43f2532e8949d
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10.2 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.92 kB (baseline 3.92 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.47 MB (baseline 1.47 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 135 kB (baseline 135 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 648 kB (baseline 648 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 53.7 kB (baseline 53.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 15 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 194 kB (baseline 194 kB) • ⚪ 0 BReusable component library chunks Status: 18 unchanged Data & Services — 4.11 MB (baseline 4.11 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 14 unchanged Utilities & Hooks — 587 kB (baseline 587 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.2 MB (baseline 17.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.4 MB (baseline 18.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 306 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-04T07:46:25.814Z",
"gitSha": "6cf512fb6af373db90a718a7b14c7c66119b4d63",
"branch": "fix/agent-panel-total-teardown",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2041.415000000029,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.676999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.897,
"heapDeltaBytes": -31051072,
"heapUsedBytes": 72756716,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.399999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80327868852459,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.0370000000585,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.185,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.099,
"heapDeltaBytes": 558128,
"heapUsedBytes": 67404604,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.116000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1805.4819999999836,
"styleRecalcs": 77,
"styleRecalcDurationMs": 20.194,
"layouts": 12,
"layoutDurationMs": 4.805,
"taskDurationMs": 873.383,
"heapDeltaBytes": -3050124,
"heapUsedBytes": 64157944,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 164.208,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1768.7939999999571,
"styleRecalcs": 52,
"styleRecalcDurationMs": 15.898,
"layouts": 12,
"layoutDurationMs": 4.445,
"taskDurationMs": 775.729,
"heapDeltaBytes": 19562676,
"heapUsedBytes": 73593996,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 146.694,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.5799999999836,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.595999999999998,
"layouts": 6,
"layoutDurationMs": 1.25,
"taskDurationMs": 368.9669999999999,
"heapDeltaBytes": 3440180,
"heapUsedBytes": 71007440,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.880999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.7369999999937,
"styleRecalcs": 29,
"styleRecalcDurationMs": 9.334000000000001,
"layouts": 6,
"layoutDurationMs": 1.3670000000000002,
"taskDurationMs": 329.543,
"heapDeltaBytes": 25650056,
"heapUsedBytes": 79631408,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.107000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 731.7709999999806,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.264,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.5160000000001,
"heapDeltaBytes": -7469044,
"heapUsedBytes": 61000472,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.03500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909075,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 698.1980000000476,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.073,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.68600000000004,
"heapDeltaBytes": -8050020,
"heapUsedBytes": 59266532,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 166.118,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669047619047628,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1166.3919999999735,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 867.091,
"heapDeltaBytes": 15074444,
"heapUsedBytes": 84425260,
"domNodes": 0,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 62.218000000000025,
"eventListeners": 0,
"totalBlockingTimeMs": 541,
"frameDurationMs": 35.35151515151514,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1126.2000000000398,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 793.6659999999999,
"heapDeltaBytes": 14431016,
"heapUsedBytes": 92387328,
"domNodes": 0,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 55.579,
"eventListeners": 0,
"totalBlockingTimeMs": 500,
"frameDurationMs": 33.335294117647074,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.2249999999567,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.79799999999994,
"heapDeltaBytes": 17165904,
"heapUsedBytes": 118640528,
"domNodes": 0,
"jsHeapTotalBytes": 2887680,
"scriptDurationMs": 145.563,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.953999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.8170000000003,
"heapDeltaBytes": 17014252,
"heapUsedBytes": 98708804,
"domNodes": 0,
"jsHeapTotalBytes": 1576960,
"scriptDurationMs": 155.167,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.491176470588204,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8319.614000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7542.481,
"heapDeltaBytes": 15713992,
"heapUsedBytes": 92416780,
"domNodes": -142,
"jsHeapTotalBytes": -6426624,
"scriptDurationMs": 6264.293,
"eventListeners": -74,
"totalBlockingTimeMs": 257,
"frameDurationMs": 31.381886792452825,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8855.543000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7986.407,
"heapDeltaBytes": -9008640,
"heapUsedBytes": 70650208,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 6442.201,
"eventListeners": 0,
"totalBlockingTimeMs": 123,
"frameDurationMs": 29.541471571906353,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8495.713000000023,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.7950000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7753.342000000001,
"heapDeltaBytes": -15825852,
"heapUsedBytes": 68067196,
"domNodes": -143,
"jsHeapTotalBytes": -6426624,
"scriptDurationMs": 6256.402999999999,
"eventListeners": -82,
"totalBlockingTimeMs": 139,
"frameDurationMs": 30.735507246376812,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8852.499999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7986.399,
"heapDeltaBytes": -10303440,
"heapUsedBytes": 70154088,
"domNodes": 0,
"jsHeapTotalBytes": -11010048,
"scriptDurationMs": 6484.175,
"eventListeners": 0,
"totalBlockingTimeMs": 144,
"frameDurationMs": 29.942711864406775,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2035.3230000000053,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.9779999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 611.1860000000001,
"heapDeltaBytes": -53815492,
"heapUsedBytes": 72650124,
"domNodes": -328,
"jsHeapTotalBytes": -2981888,
"scriptDurationMs": 37.644000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2016.2990000000036,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.0630000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.24,
"heapDeltaBytes": 10288556,
"heapUsedBytes": 72636464,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.048000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2393.484000000001,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.870999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1607.3139999999996,
"heapDeltaBytes": -17933840,
"heapUsedBytes": 70551080,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 840.7760000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.783098591549294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2221.068999999943,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.734,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1497.426,
"heapDeltaBytes": 1437116,
"heapUsedBytes": 64570912,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 779.8439999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79242424242424,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3746.4149999999563,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.23,
"layouts": 60,
"layoutDurationMs": 16.111,
"taskDurationMs": 1728.781,
"heapDeltaBytes": 1646572,
"heapUsedBytes": 69572508,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 817.0200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66577777777778,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3587.58499999999,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.139,
"layouts": 60,
"layoutDurationMs": 15.300999999999998,
"taskDurationMs": 1663.17,
"heapDeltaBytes": -20258652,
"heapUsedBytes": 69781296,
"domNodes": 24,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 801.865,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186912,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3138.505000000009,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.279000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1923.1600000000003,
"heapDeltaBytes": 3473272,
"heapUsedBytes": 71756960,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1014.578,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755376344086027,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3085.6039999999894,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.207000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1826.5860000000002,
"heapDeltaBytes": 8134288,
"heapUsedBytes": 73410672,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 952.666,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757065217391304,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2019.2519999999945,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.243000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.9929999999998,
"heapDeltaBytes": -10170772,
"heapUsedBytes": 79544676,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.43900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.4429999999584,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.114999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.371,
"heapDeltaBytes": -26519376,
"heapUsedBytes": 73192232,
"domNodes": -328,
"jsHeapTotalBytes": -3018752,
"scriptDurationMs": 34.31000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 641.1370000000147,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.061000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.43199999999996,
"heapDeltaBytes": -12447036,
"heapUsedBytes": 56494344,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.07799999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.3070000000153,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.463,
"heapDeltaBytes": 9209844,
"heapUsedBytes": 63409700,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 146.592,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2024.4440000000168,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.4540000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.1929999999999,
"heapDeltaBytes": 696588,
"heapUsedBytes": 69495196,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.300999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2020.3050000000076,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8489999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.894,
"heapDeltaBytes": 766052,
"heapUsedBytes": 70427036,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.681000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.7179999999807,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.764999999999997,
"layouts": 16,
"layoutDurationMs": 5.944999999999999,
"taskDurationMs": 763.144,
"heapDeltaBytes": -6323876,
"heapUsedBytes": 63651560,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.42399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.3980000000274,
"styleRecalcs": 58,
"styleRecalcDurationMs": 18.958000000000002,
"layouts": 16,
"layoutDurationMs": 6.196000000000001,
"taskDurationMs": 776.121,
"heapDeltaBytes": -37261680,
"heapUsedBytes": 67845172,
"domNodes": -250,
"jsHeapTotalBytes": -1835008,
"scriptDurationMs": 109.03999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.5089999999036,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.179000000000002,
"layouts": 5,
"layoutDurationMs": 12.136000000000001,
"taskDurationMs": 932.1600000000001,
"heapDeltaBytes": 23977212,
"heapUsedBytes": 109105736,
"domNodes": 13747,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 29.743,
"eventListeners": 2383,
"totalBlockingTimeMs": 116,
"frameDurationMs": 19.212500000000002,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8622.05499999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 42.171,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5663.506,
"heapDeltaBytes": -18378624,
"heapUsedBytes": 69714656,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2779.9519999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8233.105999999907,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.339999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5325.66,
"heapDeltaBytes": -35138676,
"heapUsedBytes": 91346720,
"domNodes": -348,
"jsHeapTotalBytes": -2494464,
"scriptDurationMs": 2565.41,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.70020325203252,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18146.996000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17461.354,
"heapDeltaBytes": -25414288,
"heapUsedBytes": 185963520,
"domNodes": -3045,
"jsHeapTotalBytes": 8212480,
"scriptDurationMs": 301.094,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.756042031523638,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 18460.953000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17487.952,
"heapDeltaBytes": -30165004,
"heapUsedBytes": 178643408,
"domNodes": -3045,
"jsHeapTotalBytes": 10563584,
"scriptDurationMs": 301.505,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.283041958041956,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 23033.634000000005,
"styleRecalcs": 177,
"styleRecalcDurationMs": 27.463999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22680.891,
"heapDeltaBytes": -40075024,
"heapUsedBytes": 169343312,
"domNodes": -3045,
"jsHeapTotalBytes": 8396800,
"scriptDurationMs": 917.2,
"eventListeners": -14915,
"totalBlockingTimeMs": 28,
"frameDurationMs": 43.704743833017076,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 22070.565999999984,
"styleRecalcs": 166,
"styleRecalcDurationMs": 22.981,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21655.909,
"heapDeltaBytes": -28834376,
"heapUsedBytes": 173649736,
"domNodes": -3045,
"jsHeapTotalBytes": 8728576,
"scriptDurationMs": 884.973,
"eventListeners": -14915,
"totalBlockingTimeMs": 68,
"frameDurationMs": 41.16753731343283,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6603.339999999946,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.78899999999997,
"layouts": 20,
"layoutDurationMs": 26.91500000000001,
"taskDurationMs": 6447.003000000001,
"heapDeltaBytes": 958852,
"heapUsedBytes": 215275268,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 121.379,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.71257142857143,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6539.587000000097,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.37299999999996,
"layouts": 20,
"layoutDurationMs": 26.561999999999987,
"taskDurationMs": 6407.1449999999995,
"heapDeltaBytes": -5769604,
"heapUsedBytes": 203359304,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 120.57900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.70280898876405,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9045.929,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8790.195,
"heapDeltaBytes": -29798188,
"heapUsedBytes": 166020112,
"domNodes": -3046,
"jsHeapTotalBytes": 10825728,
"scriptDurationMs": 155.505,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.694736842105264,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8958.120000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8767.178000000002,
"heapDeltaBytes": -53498500,
"heapUsedBytes": 177873984,
"domNodes": -3045,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 148.72900000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.736524822695024,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 136.23299999994742,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.794999999999995,
"layouts": 4,
"layoutDurationMs": 2.363,
"taskDurationMs": 102.61299999999999,
"heapDeltaBytes": 4001540,
"heapUsedBytes": 57830184,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.407999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.042857142857038,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 127.69300000002204,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.717,
"layouts": 2,
"layoutDurationMs": 1.394,
"taskDurationMs": 78.34100000000002,
"heapDeltaBytes": 3620636,
"heapUsedBytes": 69089452,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.0059999999999985,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1116.463000000067,
"styleRecalcs": 78,
"styleRecalcDurationMs": 121.934,
"layouts": 76,
"layoutDurationMs": 31.447000000000003,
"taskDurationMs": 1101.439,
"heapDeltaBytes": 20287460,
"heapUsedBytes": 86000044,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 466.05400000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1094.1970000000083,
"styleRecalcs": 78,
"styleRecalcDurationMs": 127.938,
"layouts": 76,
"layoutDurationMs": 32.59,
"taskDurationMs": 1041.329,
"heapDeltaBytes": 18921908,
"heapUsedBytes": 83888120,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 427.207,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.472580645161294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1543.8060000000178,
"styleRecalcs": 78,
"styleRecalcDurationMs": 304.411,
"layouts": 76,
"layoutDurationMs": 32.016999999999996,
"taskDurationMs": 1518.826,
"heapDeltaBytes": 8590200,
"heapUsedBytes": 114343148,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 499.50600000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.135802469135804,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1440.9189999998944,
"styleRecalcs": 78,
"styleRecalcDurationMs": 287.017,
"layouts": 76,
"layoutDurationMs": 30.37,
"taskDurationMs": 1413.471,
"heapDeltaBytes": 8483432,
"heapUsedBytes": 115241576,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 450.436,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.14303797468356,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2193 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughAgent panel teardown actions now report failures through ChangesAgent panel teardown
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The panel’s cleanup can continue after the tested failures. No actionable merge-blocking risk is established by the supplied evidence. 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The title and commit subjects use the bug-fix signal “fix.” The PR changes
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20078 +/- ##
==========================================
+ Coverage 85.01% 85.76% +0.74%
==========================================
Files 3458 2430 -1028
Lines 166374 138841 -27533
Branches 45406 37640 -7766
==========================================
- Hits 141438 119072 -22366
+ Misses 22965 19394 -3571
+ Partials 1971 375 -1596
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1034 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| () => docOpMinter.detach(), | ||
| () => restoreOpMinter.detach(), | ||
| () => exitNodeSelectionMode(), | ||
| () => stop(), |
There was a problem hiding this comment.
🟢 Low — Containment stops at step granularity, but several steps are themselves multi-release sequences with no internal try/catch: stop() runs unsubscribe?.() before unsubscribeStatus?.() and the recoveringTurns abort loop, docOpMinter.detach() runs detachIntents() before unregisterDocBoundProbe(), and exitNodeSelectionMode() runs the store exit before canvas.deselectAll(). A throw partway through one of those still strands its later releases on singletons that outlive the panel — a leaked status subscription and un-aborted recovery requests for the rest of the session, with no owner left to clean them up. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
There was a problem hiding this comment.
Valid, and I checked all three rather than taking it on faith — stop() (useAgentSession.ts:783), docOpMinter.detach() and exitNodeSelectionMode() each do run multiple releases with no internal guard. Not fixing it here, with a specific reason per step rather than a general one:
exitNodeSelectionMode()is local to this file and looks like the cheap one, but it is re-entrant by design:agentNodeSelectionStore.exit()synchronously trips the watcher at :1572 which calls back into it, and the function clearsnodeSelectionCanvas/selectingNodesfirst so that re-entry is a no-op. Splitting it into two steps either duplicates that logic or reorders it, and reordering is what makes the re-entry unsafe. It needs to become total at its own seam, not at the call site.stop()has seven other callers; guarding its interior changes what a mid-session stop does, not just an unmount.docOpMinter.detach()is undersrc/workbench/extensions/agent/crdt/.
So the honest shape is three small per-module changes, each with its own blast radius, rather than anything this call site can express. Happy to take them as a follow-up if you want them tracked — say the word and I will file it.
What this PR does settle is that a throw in any one step no longer costs the other nine, the later hooks, or scope.stop(), and that tags.step now names which step failed so a partial release inside one of them is at least attributable.
There was a problem hiding this comment.
Line correction on the above: the re-entrant watcher is AgentPanelRoot.vue:1607 at this head, not :1572. The point stands.
Review findings on this PR, all three real: - `() => void` accepts an async step, whose rejection would escape the try/catch while still looking contained. Steps now return `undefined`, which rejects a promise-returning step at compile time. - `reportError` was the one call in the loop outside its own try/catch, so a failing telemetry sink aborted the teardown it was reporting on. It is wrapped now. - One undifferentiated `errorType` for ten steps left telemetry unable to tell a `stopSession` failure (a leaked event-stream subscription and un-aborted turn recovery for the session) from a benign `clearCreatingTab` one. Steps are keyed and the key rides on `tags`, which is the only remaining signal now that the error is swallowed. Keys are not integer-like, so `Object.entries` order is specified and insertion order stays the run order. Tests assert the `step` tag on both existing cases and add one that arms the reporter to throw; it fails against the unguarded reporter.
|
|
|
|
…0078) (#20102) ## Summary Manual target-aware backport of #20078 after the automatic cherry-pick conflicted. This preserves cloud/1.55's target-specific active-tab invalidation order while applying the merged total-teardown contract to every panel release. The target-native canvas-gate regression proves a throwing doc-op minter detach cannot skip the PM-1575 reset. Source: #20078 (`8ae1b91f5bd3ad15b926953998edd07c287a4ed5`) ## Verification - `pnpm test:unit src/workbench/extensions/agent/AgentPanelRoot.test.ts --testTimeout=30000` — 356 passed - `NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheck` - `pnpm exec eslint src/workbench/extensions/agent/AgentPanelRoot.vue src/workbench/extensions/agent/AgentPanelRoot.test.ts` - `pnpm exec oxfmt --check src/workbench/extensions/agent/AgentPanelRoot.vue src/workbench/extensions/agent/AgentPanelRoot.test.ts`
The #20078 backport reframed the unmount hook as keyed teardown steps and, in doing so, moved `++activeTabGeneration` from the first statement to the sixth on this release line. `cloud/1.54` raises that fence before anything else, and #20078's contract is that step order is unchanged -- so the move was an unrelated behavioral delta, not part of the error containment. Restore the release line's order: the fence is the first key again, so the steps that synchronously notify listeners and `flush: 'sync'` watchers (`releaseCoachCompletionWaiters`, submission invalidation, `mintPortWiring.detach()`, `exitNodeSelectionMode()`, `stop()`) can no longer run while the old generation still looks current. The keys now map 1:1, in order, onto the pre-backport statements, and `cloud/1.55` carries the same fence-first order via #20102.
…0078) (#20100) ## Summary Manual target-aware backport of #20078 after the automatic cherry-pick conflicted. `cloud/1.54` still uses `mintPortWiring`, so the conflict resolution preserves that target API while applying the source's total-teardown contract, minimap cleanup, and target-native regression coverage. The older telemetry type does not expose `surface`; the stable error type and per-step tag are retained. Source: #20078 (`8ae1b91f5bd3ad15b926953998edd07c287a4ed5`) ## Verification - `NODE_OPTIONS=--no-experimental-webstorage pnpm vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts` — 376 passed - pre-commit `pnpm typecheck:app` — passed - pre-commit format/style/oxlint/eslint — passed
) (#20101) ## Summary Manual target-aware backport of #20078 after the automatic cherry-pick conflicted. The release line already has the doc/restore minters and minimap lifecycle, so this preserves those target APIs and applies the source's report-and-continue teardown contract and regressions. The release-line telemetry type does not yet expose `surface`; the stable error type and per-step tag are retained. Source: #20078 (`8ae1b91f5bd3ad15b926953998edd07c287a4ed5`) ## Verification - `NODE_OPTIONS=--no-experimental-webstorage pnpm vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts` — 333 passed - pre-commit `pnpm typecheck:app` — passed on Node 26 - pre-commit format/style/oxlint/eslint — passed
) (#20099) ## Summary Manual target-aware backport of #20078 after the automatic cherry-pick conflicted. `core/1.54` predates the doc/restore minters and minimap layer in the source diff, so this carrier applies the same total-teardown contract to the line's `mintPortWiring`, session, tab, canvas-gate, upload, and timer releases. It includes a target-native regression proving a throwing `mintPortWiring.detach()` cannot skip the PM-1575 canvas-sync gate reset. Source: #20078 (`8ae1b91f5bd3ad15b926953998edd07c287a4ed5`) ## Verification - `NODE_OPTIONS=--no-experimental-webstorage pnpm vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts` — 284 passed - `pnpm exec oxfmt --check src/workbench/extensions/agent/AgentPanelRoot.vue src/workbench/extensions/agent/AgentPanelRoot.test.ts`
Summary
Follow-up to #20071: make the agent panel's unmount total, so no teardown step can be skipped by an earlier one throwing.
Context
#20071 moved the
agent.graph-activityminimap dispose into its ownonBeforeUnmount, ahead of the large unmount hook, so a throwing teardown step could no longer leave the layer id claimed in the module registry. Review (thread, raised by 4 of 8 reviewers) found that this rescues one victim and leaves the rest exposed, and the PR merged with the thread open and the fix deferred to a follow-up. This is that follow-up.A throw in
releaseCoachCompletionWaiters(),invalidateSubmission(),docOpMinter.detach(),restoreOpMinter.detach(),exitNodeSelectionMode(),stop()orsetEditing/setCreatingstill skips every later step in the same hook — including the PM-1575setCanvasSyncGatereset, which the comment beside it calls the only thing standing between a turn resumed in the meantime and a torn-down follower's gate on the store singleton. The gate is not merely late in that case, it is never reset: a reverted-fix run of the new test records zerosetCanvasSyncGatecalls during unmount.It is also wider than one hook. No
app.config.errorHandleris registered anywhere in the app, so Vue'slogErrorre-throws outside production builds; the throw escapesinvokeArrayFnsand abandons the remainingbeforeUnmounthooks (attachment.cancelAllUploads()) and the rest ofunmountComponent, includingscope.stop().Changes
AgentPanelRoot.vue's unmount now runs through a localrunPanelTeardown, which reports a failing step asfailure_tearing_down_agent_paneland continues to the next one. All three of the component'sonBeforeUnmounthooks go through it, so no hook can abandon a later one either. Step order is unchanged.tags.step, because the error is swallowed now and the report is the only remaining signal that a release was skipped — telemetry has to be able to tell astopSessionfailure (a leaked event-stream subscription and un-aborted turn recovery for the session) from a benignclearCreatingTabone. No key is integer-like, soObject.entriesorder is specified and insertion order stays the run order. Steps returnundefinedrather thanvoidso an async step — whose rejection would escape the catch while still looking contained — fails to compile. ThereportErrorcall has its own try/catch, since it was the one call in the loop that could abort the teardown it was reporting on.docOpMinter.detach()to throw and asserts the PM-1575 gate is still reset to the always-safe default (gate() === false,outcomeCount() === 0); it fails on the primary assertion againstmain(expected to be called once, but got 0 times). The existing throwing-teardown case now asserts the error is contained and reported rather than escaping to Vue's handler, and also fails againstmain. A third case arms the reporter itself to throw and asserts the gate is still reset; it fails against an unguarded reporter. Both pre-existing cases assert thesteptag. The minimap duplicate-free remount assertion from fix(agent): release minimap graph-activity layer reliably on unmount #20071 is unchanged.Review Focus
Four review findings came back on the first revision; three are fixed in 6234899 (async-step typing, the unguarded reporter, the undifferentiated
errorType). The fourth — that several steps are themselves multi-release sequences with no internal guard — is real and is answered on the thread: it needs three small per-module changes rather than anything this call site can express, andexitNodeSelectionMode()in particular is re-entrant by design so splitting it at the call site is unsafe.This deliberately mirrors
runFollowerTeardownincrdt/useAgentCrdtFollower.ts— same rationale, same report-and-continue shape — rather than sharing it, because that file is the CRDT follower's own teardown and its reporter is hard-coded to a differenterrorType. Say the word if you would rather have one shared helper and I will extract it.The second-order question the thread raises and this does not answer: registering an
app.config.errorHandlerwould make unmount resilient app-wide instead of one component at a time. That is a global behavior change well outside a teardown fix, so it is not attempted here.