Repository navigation
[backport cloud/1.54] fix(agent): make agent panel teardown total (#20078) - #20100
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1988 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-04T15:31:00.368Z",
"gitSha": "bc324696abe85008f67c7646d33de1a035546201",
"branch": "backport-20078-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2102.204000000029,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.305000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.999,
"heapDeltaBytes": -7704920,
"heapUsedBytes": 65512944,
"domNodes": -279,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 10.674999999999997,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2040.1229999999941,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.732000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.33000000000004,
"heapDeltaBytes": 1595036,
"heapUsedBytes": 72448864,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.687000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1829.0470000000596,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.423999999999992,
"layouts": 14,
"layoutDurationMs": 3.7209999999999996,
"taskDurationMs": 869.9449999999999,
"heapDeltaBytes": 5603112,
"heapUsedBytes": 77195236,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 141.621,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1873.7840000000006,
"styleRecalcs": 78,
"styleRecalcDurationMs": 30.322999999999997,
"layouts": 14,
"layoutDurationMs": 4.0680000000000005,
"taskDurationMs": 890.702,
"heapDeltaBytes": -1554744,
"heapUsedBytes": 69791512,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 147.445,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.2839999999978,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.02,
"layouts": 6,
"layoutDurationMs": 1.114,
"taskDurationMs": 351.41200000000003,
"heapDeltaBytes": 4352824,
"heapUsedBytes": 75816204,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.207999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.7149999999701,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.862999999999998,
"layouts": 6,
"layoutDurationMs": 1.224,
"taskDurationMs": 393.4080000000001,
"heapDeltaBytes": 4486684,
"heapUsedBytes": 76021880,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.662,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 710.4380000000674,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.634000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.673,
"heapDeltaBytes": -7479928,
"heapUsedBytes": 66714880,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 156.302,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 676.3670000000275,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.855,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.895,
"heapDeltaBytes": -7246240,
"heapUsedBytes": 66768528,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 157.47699999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2054.114000000027,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.7410000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.546,
"heapDeltaBytes": 11993464,
"heapUsedBytes": 89300356,
"domNodes": -280,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 38.26299999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2017.4899999999525,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.401,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.802,
"heapDeltaBytes": -7692280,
"heapUsedBytes": 69800600,
"domNodes": -286,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 39.047,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2182.4169999999867,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.236999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1544.432,
"heapDeltaBytes": -10111632,
"heapUsedBytes": 68481840,
"domNodes": -285,
"jsHeapTotalBytes": 3305472,
"scriptDurationMs": 776.581,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2273.076999999944,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.436000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1628.8590000000004,
"heapDeltaBytes": -11744456,
"heapUsedBytes": 67353276,
"domNodes": -249,
"jsHeapTotalBytes": 421888,
"scriptDurationMs": 804.008,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3523.1340000000273,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.625999999999998,
"layouts": 60,
"layoutDurationMs": 12.699,
"taskDurationMs": 1622.442,
"heapDeltaBytes": 624468,
"heapUsedBytes": 68125572,
"domNodes": 26,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 777.087,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3586.024000000066,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.122999999999998,
"layouts": 60,
"layoutDurationMs": 14.172,
"taskDurationMs": 1804.5800000000002,
"heapDeltaBytes": -13294212,
"heapUsedBytes": 66727948,
"domNodes": -265,
"jsHeapTotalBytes": 4091904,
"scriptDurationMs": 806.44,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3197.240000000079,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.766000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1978.9990000000003,
"heapDeltaBytes": -1083948,
"heapUsedBytes": 82046848,
"domNodes": 6,
"jsHeapTotalBytes": 7655424,
"scriptDurationMs": 1050.8840000000002,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3139.0219999999545,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.274000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2009.003,
"heapDeltaBytes": -13077200,
"heapUsedBytes": 69698772,
"domNodes": 10,
"jsHeapTotalBytes": 5140480,
"scriptDurationMs": 1061.9429999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 15,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.9399999999732,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.384000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.8290000000001,
"heapDeltaBytes": -8749876,
"heapUsedBytes": 71645532,
"domNodes": -282,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 39.297000000000004,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.9580000000178,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.458,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.654,
"heapDeltaBytes": -5610624,
"heapUsedBytes": 76856584,
"domNodes": -272,
"jsHeapTotalBytes": -2322432,
"scriptDurationMs": 40.892,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.2250000000795,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.201,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.277,
"heapDeltaBytes": 14893656,
"heapUsedBytes": 88411228,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.079,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 627.2190000000819,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.634,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.85200000000003,
"heapDeltaBytes": -10525736,
"heapUsedBytes": 65224488,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 150.476,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.090000000062,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.57,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.326,
"heapDeltaBytes": 2467832,
"heapUsedBytes": 75971236,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.811,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1990.7969999999295,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.703000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.642,
"heapDeltaBytes": 740472,
"heapUsedBytes": 67462828,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.052999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1767.6099999999906,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.53,
"layouts": 18,
"layoutDurationMs": 5.046,
"taskDurationMs": 806.959,
"heapDeltaBytes": 3683484,
"heapUsedBytes": 77086508,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 109.60499999999999,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.2320000000445,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.023999999999997,
"layouts": 18,
"layoutDurationMs": 5.461,
"taskDurationMs": 832.266,
"heapDeltaBytes": -5150892,
"heapUsedBytes": 70923164,
"domNodes": -297,
"jsHeapTotalBytes": 4231168,
"scriptDurationMs": 112.812,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.988999999905,
"styleRecalcs": 21,
"styleRecalcDurationMs": 31.947000000000003,
"layouts": 17,
"layoutDurationMs": 15.235,
"taskDurationMs": 941.107,
"heapDeltaBytes": 22098360,
"heapUsedBytes": 106586124,
"domNodes": 13831,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.07699999999999,
"eventListeners": 2385,
"totalBlockingTimeMs": 131,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8228.98500000008,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.133,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5448.750999999999,
"heapDeltaBytes": 19901016,
"heapUsedBytes": 100113292,
"domNodes": -271,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 2628.304,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8318.528000000015,
"styleRecalcs": 247,
"styleRecalcDurationMs": 41.573,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5649.587,
"heapDeltaBytes": -11338224,
"heapUsedBytes": 67095856,
"domNodes": -270,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 2654.208,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18023.90200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17298.8,
"heapDeltaBytes": -53532896,
"heapUsedBytes": 177095468,
"domNodes": -8068,
"jsHeapTotalBytes": -12333056,
"scriptDurationMs": 307.865,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18232.42999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17793.357999999997,
"heapDeltaBytes": -52109060,
"heapUsedBytes": 178614712,
"domNodes": -8068,
"jsHeapTotalBytes": -10235904,
"scriptDurationMs": 311.094,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22915.054000000055,
"styleRecalcs": 174,
"styleRecalcDurationMs": 24.29899999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22723.625000000004,
"heapDeltaBytes": -38293884,
"heapUsedBytes": 179910296,
"domNodes": -8068,
"jsHeapTotalBytes": -12042240,
"scriptDurationMs": 1008.6680000000001,
"eventListeners": -14925,
"totalBlockingTimeMs": 142,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22789.88799999979,
"styleRecalcs": 173,
"styleRecalcDurationMs": 23.951,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22540.089,
"heapDeltaBytes": -38312596,
"heapUsedBytes": 184735712,
"domNodes": -8068,
"jsHeapTotalBytes": -14757888,
"scriptDurationMs": 924.7789999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 114,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-node-resize-workload",
"durationMs": 6516.511000000037,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.19100000000002,
"layouts": 20,
"layoutDurationMs": 27.24499999999999,
"taskDurationMs": 6439.225,
"heapDeltaBytes": -42012000,
"heapUsedBytes": 169629508,
"domNodes": -8068,
"jsHeapTotalBytes": 17580032,
"scriptDurationMs": 121.625,
"eventListeners": -14927,
"totalBlockingTimeMs": 548,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6521.255999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.98699999999997,
"layouts": 20,
"layoutDurationMs": 24.927000000000003,
"taskDurationMs": 6440.955,
"heapDeltaBytes": -45077084,
"heapUsedBytes": 184322372,
"domNodes": -8068,
"jsHeapTotalBytes": 12435456,
"scriptDurationMs": 118.67899999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 466,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9026.410000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8767.782000000003,
"heapDeltaBytes": 12217856,
"heapUsedBytes": 193359164,
"domNodes": 0,
"jsHeapTotalBytes": -22806528,
"scriptDurationMs": 147.62400000000002,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9227.846,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8843.312999999998,
"heapDeltaBytes": 31629940,
"heapUsedBytes": 190701692,
"domNodes": 0,
"jsHeapTotalBytes": -6291456,
"scriptDurationMs": 162.184,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 477.2530000000188,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.492,
"layouts": 4,
"layoutDurationMs": 2.0280000000000005,
"taskDurationMs": 127.14200000000001,
"heapDeltaBytes": 5115356,
"heapUsedBytes": 74774128,
"domNodes": 145,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.305,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 476.85900000010406,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.427999999999997,
"layouts": 3,
"layoutDurationMs": 0.8560000000000002,
"taskDurationMs": 108.39699999999999,
"heapDeltaBytes": 4867324,
"heapUsedBytes": 74644560,
"domNodes": 115,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.738,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #20100 +/- ##
=============================================
Coverage ? 84.26%
=============================================
Files ? 2131
Lines ? 128098
Branches ? 32597
=============================================
Hits ? 107941
Misses ? 19976
Partials ? 181
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 4 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
The #20078 backport reframed the unmount hook as keyed teardown steps and, in doing so, moved `++activeTabGeneration` from the first statement to the sixth on this release line. `cloud/1.54` raises that fence before anything else, and #20078's contract is that step order is unchanged -- so the move was an unrelated behavioral delta, not part of the error containment. Restore the release line's order: the fence is the first key again, so the steps that synchronously notify listeners and `flush: 'sync'` watchers (`releaseCoachCompletionWaiters`, submission invalidation, `mintPortWiring.detach()`, `exitNodeSelectionMode()`, `stop()`) can no longer run while the old generation still looks current. The keys now map 1:1, in order, onto the pre-backport statements, and `cloud/1.55` carries the same fence-first order via #20102.
Summary
Manual target-aware backport of #20078 after the automatic cherry-pick conflicted.
cloud/1.54still usesmintPortWiring, so the conflict resolution preserves that target API while applying the source's total-teardown contract, minimap cleanup, and target-native regression coverage. The older telemetry type does not exposesurface; the stable error type and per-step tag are retained.Source: #20078 (
8ae1b91f5bd3ad15b926953998edd07c287a4ed5)Verification
NODE_OPTIONS=--no-experimental-webstorage pnpm vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts— 376 passedpnpm typecheck:app— passed