Skip to content

[backport cloud/1.54] fix(agent): make agent panel teardown total (#20078) - #20100

Merged
christian-byrne merged 2 commits into
cloud/1.54from
backport-20078-to-cloud-1.54
Oct 4, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
backport-20078-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Manual target-aware backport of #20078 after the automatic cherry-pick conflicted.

cloud/1.54 still uses mintPortWiring, so the conflict resolution preserves that target API while applying the source's total-teardown contract, minimap cleanup, and target-native regression coverage. The older telemetry type does not expose surface; the stable error type and per-step tag are retained.

Source: #20078 (8ae1b91f5bd3ad15b926953998edd07c287a4ed5)

Verification

  • NODE_OPTIONS=--no-experimental-webstorage pnpm vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts — 376 passed
  • pre-commit pnpm typecheck:app — passed
  • pre-commit format/style/oxlint/eslint — passed

@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 4, 2026
@vercel

vercel Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 4, 2026 3:19pm UTC
billing-web-test Ignored Ignored Oct 4, 2026 3:19pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/04/2026, 03:21:20 PM UTC

Links

🎭 Playwright: ✅ 1988 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1967 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 8ms TBT · 72.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 131ms TBT · 101.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.7 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.6 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 128ms TBT · 173.9 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 507ms TBT · 168.8 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 183.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 527ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.8 MB
canvas-idle: DOM nodes -131
canvas-idle: event listeners -94
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 880ms
canvas-mouse-sweep: script duration 145ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 70.1 MB
canvas-mouse-sweep: DOM nodes -278
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 372ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.4 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 451ms
dom-widget-clipping: script duration 157ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 63.6 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 599ms
large-graph-idle: script duration 39ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 75.9 MB
large-graph-idle: DOM nodes -283
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1587ms
large-graph-pan: script duration 790ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 64.8 MB
large-graph-pan: DOM nodes -267
large-graph-pan: event listeners -178
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 68
large-graph-zoom: task duration 1714ms
large-graph-zoom: script duration 792ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 64.3 MB
large-graph-zoom: DOM nodes -120
large-graph-zoom: event listeners -95
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 9ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1994ms
legacy-node-drag: script duration 1056ms
legacy-node-drag: TBT 8ms
legacy-node-drag: heap used 72.4 MB
legacy-node-drag: DOM nodes 8
legacy-node-drag: event listeners -5
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 608ms
minimap-idle: script duration 40ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.8 MB
minimap-idle: DOM nodes -277
minimap-idle: event listeners -178
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 422ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 73.3 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 472ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.4 MB
subgraph-idle: DOM nodes -138
subgraph-idle: event listeners -102
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 820ms
subgraph-mouse-sweep: script duration 111ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 70.6 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -227
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 941ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 131ms
subgraph-transition-enter: heap used 101.6 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5549ms
viewport-pan-sweep: script duration 2641ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 79.7 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -148
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17546ms
vue-large-graph-idle: script duration 309ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.6 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 24ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 174
vue-large-graph-pan: task duration 22632ms
vue-large-graph-pan: script duration 967ms
vue-large-graph-pan: TBT 128ms
vue-large-graph-pan: heap used 173.9 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14926
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 77ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6440ms
vue-node-resize-workload: script duration 120ms
vue-node-resize-workload: TBT 507ms
vue-node-resize-workload: heap used 168.8 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14926
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8806ms
vue-zoom-out-idle: script duration 155ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 183.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 4
workflow-execution: style recalc count 15
workflow-execution: task duration 118ms
workflow-execution: script duration 13ms
workflow-execution: TBT 0ms
workflow-execution: heap used 71.2 MB
workflow-execution: DOM nodes 130
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-10-04T15:31:00.368Z",
  "gitSha": "bc324696abe85008f67c7646d33de1a035546201",
  "branch": "backport-20078-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2102.204000000029,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.305000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 592.999,
      "heapDeltaBytes": -7704920,
      "heapUsedBytes": 65512944,
      "domNodes": -279,
      "jsHeapTotalBytes": 5017600,
      "scriptDurationMs": 10.674999999999997,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2040.1229999999941,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.732000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.33000000000004,
      "heapDeltaBytes": 1595036,
      "heapUsedBytes": 72448864,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 9.687000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1829.0470000000596,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 31.423999999999992,
      "layouts": 14,
      "layoutDurationMs": 3.7209999999999996,
      "taskDurationMs": 869.9449999999999,
      "heapDeltaBytes": 5603112,
      "heapUsedBytes": 77195236,
      "domNodes": -275,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 141.621,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1873.7840000000006,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 30.322999999999997,
      "layouts": 14,
      "layoutDurationMs": 4.0680000000000005,
      "taskDurationMs": 890.702,
      "heapDeltaBytes": -1554744,
      "heapUsedBytes": 69791512,
      "domNodes": -281,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 147.445,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.2839999999978,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.02,
      "layouts": 6,
      "layoutDurationMs": 1.114,
      "taskDurationMs": 351.41200000000003,
      "heapDeltaBytes": 4352824,
      "heapUsedBytes": 75816204,
      "domNodes": 75,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.207999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.7149999999701,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.862999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.224,
      "taskDurationMs": 393.4080000000001,
      "heapDeltaBytes": 4486684,
      "heapUsedBytes": 76021880,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 14.662,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 710.4380000000674,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.634000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.673,
      "heapDeltaBytes": -7479928,
      "heapUsedBytes": 66714880,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 156.302,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 676.3670000000275,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.855,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 450.895,
      "heapDeltaBytes": -7246240,
      "heapUsedBytes": 66768528,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 157.47699999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.114000000027,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.7410000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 577.546,
      "heapDeltaBytes": 11993464,
      "heapUsedBytes": 89300356,
      "domNodes": -280,
      "jsHeapTotalBytes": -364544,
      "scriptDurationMs": 38.26299999999999,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2017.4899999999525,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.401,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 619.802,
      "heapDeltaBytes": -7692280,
      "heapUsedBytes": 69800600,
      "domNodes": -286,
      "jsHeapTotalBytes": -626688,
      "scriptDurationMs": 39.047,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2182.4169999999867,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.236999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1544.432,
      "heapDeltaBytes": -10111632,
      "heapUsedBytes": 68481840,
      "domNodes": -285,
      "jsHeapTotalBytes": 3305472,
      "scriptDurationMs": 776.581,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2273.076999999944,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.436000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1628.8590000000004,
      "heapDeltaBytes": -11744456,
      "heapUsedBytes": 67353276,
      "domNodes": -249,
      "jsHeapTotalBytes": 421888,
      "scriptDurationMs": 804.008,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3523.1340000000273,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.625999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.699,
      "taskDurationMs": 1622.442,
      "heapDeltaBytes": 624468,
      "heapUsedBytes": 68125572,
      "domNodes": 26,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 777.087,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3586.024000000066,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 16.122999999999998,
      "layouts": 60,
      "layoutDurationMs": 14.172,
      "taskDurationMs": 1804.5800000000002,
      "heapDeltaBytes": -13294212,
      "heapUsedBytes": 66727948,
      "domNodes": -265,
      "jsHeapTotalBytes": 4091904,
      "scriptDurationMs": 806.44,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3197.240000000079,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 7.766000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1978.9990000000003,
      "heapDeltaBytes": -1083948,
      "heapUsedBytes": 82046848,
      "domNodes": 6,
      "jsHeapTotalBytes": 7655424,
      "scriptDurationMs": 1050.8840000000002,
      "eventListeners": -197,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3139.0219999999545,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.274000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2009.003,
      "heapDeltaBytes": -13077200,
      "heapUsedBytes": 69698772,
      "domNodes": 10,
      "jsHeapTotalBytes": 5140480,
      "scriptDurationMs": 1061.9429999999998,
      "eventListeners": 188,
      "totalBlockingTimeMs": 15,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2045.9399999999732,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.384000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 575.8290000000001,
      "heapDeltaBytes": -8749876,
      "heapUsedBytes": 71645532,
      "domNodes": -282,
      "jsHeapTotalBytes": -364544,
      "scriptDurationMs": 39.297000000000004,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.9580000000178,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.458,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 640.654,
      "heapDeltaBytes": -5610624,
      "heapUsedBytes": 76856584,
      "domNodes": -272,
      "jsHeapTotalBytes": -2322432,
      "scriptDurationMs": 40.892,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 588.2250000000795,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 12.201,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.277,
      "heapDeltaBytes": 14893656,
      "heapUsedBytes": 88411228,
      "domNodes": 24,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 140.079,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 627.2190000000819,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.634,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 437.85200000000003,
      "heapDeltaBytes": -10525736,
      "heapUsedBytes": 65224488,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 150.476,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.090000000062,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.57,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.326,
      "heapDeltaBytes": 2467832,
      "heapUsedBytes": 75971236,
      "domNodes": -297,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.811,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1990.7969999999295,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.703000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.642,
      "heapDeltaBytes": 740472,
      "heapUsedBytes": 67462828,
      "domNodes": 22,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 9.052999999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1767.6099999999906,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 27.53,
      "layouts": 18,
      "layoutDurationMs": 5.046,
      "taskDurationMs": 806.959,
      "heapDeltaBytes": 3683484,
      "heapUsedBytes": 77086508,
      "domNodes": -294,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 109.60499999999999,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1757.2320000000445,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 28.023999999999997,
      "layouts": 18,
      "layoutDurationMs": 5.461,
      "taskDurationMs": 832.266,
      "heapDeltaBytes": -5150892,
      "heapUsedBytes": 70923164,
      "domNodes": -297,
      "jsHeapTotalBytes": 4231168,
      "scriptDurationMs": 112.812,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.988999999905,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 31.947000000000003,
      "layouts": 17,
      "layoutDurationMs": 15.235,
      "taskDurationMs": 941.107,
      "heapDeltaBytes": 22098360,
      "heapUsedBytes": 106586124,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 30.07699999999999,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 131,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8228.98500000008,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 39.133,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5448.750999999999,
      "heapDeltaBytes": 19901016,
      "heapUsedBytes": 100113292,
      "domNodes": -271,
      "jsHeapTotalBytes": -786432,
      "scriptDurationMs": 2628.304,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8318.528000000015,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 41.573,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5649.587,
      "heapDeltaBytes": -11338224,
      "heapUsedBytes": 67095856,
      "domNodes": -270,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 2654.208,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18023.90200000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17298.8,
      "heapDeltaBytes": -53532896,
      "heapUsedBytes": 177095468,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12333056,
      "scriptDurationMs": 307.865,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18232.42999999991,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17793.357999999997,
      "heapDeltaBytes": -52109060,
      "heapUsedBytes": 178614712,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10235904,
      "scriptDurationMs": 311.094,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22915.054000000055,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 24.29899999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22723.625000000004,
      "heapDeltaBytes": -38293884,
      "heapUsedBytes": 179910296,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12042240,
      "scriptDurationMs": 1008.6680000000001,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 142,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22789.88799999979,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 23.951,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22540.089,
      "heapDeltaBytes": -38312596,
      "heapUsedBytes": 184735712,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14757888,
      "scriptDurationMs": 924.7789999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 114,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999995634
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6516.511000000037,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.19100000000002,
      "layouts": 20,
      "layoutDurationMs": 27.24499999999999,
      "taskDurationMs": 6439.225,
      "heapDeltaBytes": -42012000,
      "heapUsedBytes": 169629508,
      "domNodes": -8068,
      "jsHeapTotalBytes": 17580032,
      "scriptDurationMs": 121.625,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 548,
      "frameDurationMs": 17.773333333333298,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6521.255999999994,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.98699999999997,
      "layouts": 20,
      "layoutDurationMs": 24.927000000000003,
      "taskDurationMs": 6440.955,
      "heapDeltaBytes": -45077084,
      "heapUsedBytes": 184322372,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12435456,
      "scriptDurationMs": 118.67899999999999,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 466,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9026.410000000054,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8767.782000000003,
      "heapDeltaBytes": 12217856,
      "heapUsedBytes": 193359164,
      "domNodes": 0,
      "jsHeapTotalBytes": -22806528,
      "scriptDurationMs": 147.62400000000002,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9227.846,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8843.312999999998,
      "heapDeltaBytes": 31629940,
      "heapUsedBytes": 190701692,
      "domNodes": 0,
      "jsHeapTotalBytes": -6291456,
      "scriptDurationMs": 162.184,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 477.2530000000188,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 22.492,
      "layouts": 4,
      "layoutDurationMs": 2.0280000000000005,
      "taskDurationMs": 127.14200000000001,
      "heapDeltaBytes": 5115356,
      "heapUsedBytes": 74774128,
      "domNodes": 145,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 16.305,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 476.85900000010406,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 19.427999999999997,
      "layouts": 3,
      "layoutDurationMs": 0.8560000000000002,
      "taskDurationMs": 108.39699999999999,
      "heapDeltaBytes": 4867324,
      "heapUsedBytes": 74644560,
      "domNodes": 115,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 9.738,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51050 76442 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 65bb2992-a9e1-4c91-ac5f-33224ac2b8b0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot requested a review from ryan-di October 4, 2026 13:44
@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 4, 2026
@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #20100   +/-   ##
=============================================
  Coverage              ?   84.26%           
=============================================
  Files                 ?     2131           
  Lines                 ?   128098           
  Branches              ?    32597           
=============================================
  Hits                  ?   107941           
  Misses                ?    19976           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.83% <ø> (?)
unit 79.57% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/AgentPanelRoot.vue 92.76% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 7 finding(s).

Severity Count
🟡 Medium 1
🟢 Low 4
⚪ Nit 2

Panel: 8/8 reviewers contributed findings.

@christian-byrne christian-byrne assigned DrJKL and unassigned ryan-di Oct 4, 2026
@christian-byrne
christian-byrne requested a review from DrJKL October 4, 2026 15:03
The #20078 backport reframed the unmount hook as keyed teardown steps and,
in doing so, moved `++activeTabGeneration` from the first statement to the
sixth on this release line. `cloud/1.54` raises that fence before anything
else, and #20078's contract is that step order is unchanged -- so the move
was an unrelated behavioral delta, not part of the error containment.

Restore the release line's order: the fence is the first key again, so the
steps that synchronously notify listeners and `flush: 'sync'` watchers
(`releaseCoachCompletionWaiters`, submission invalidation,
`mintPortWiring.detach()`, `exitNodeSelectionMode()`, `stop()`) can no
longer run while the old generation still looks current. The keys now map
1:1, in order, onto the pre-backport statements, and `cloud/1.55` carries
the same fence-first order via #20102.
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 4, 2026
@christian-byrne
christian-byrne removed the request for review from ryan-di October 4, 2026 16:22
@christian-byrne
christian-byrne merged commit ec8a404 into cloud/1.54 Oct 4, 2026
109 checks passed
@christian-byrne
christian-byrne deleted the backport-20078-to-cloud-1.54 branch October 4, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants