Repository navigation
[backport cloud/1.55] fix(agent): make agent panel teardown total (#20078) - #20102
Conversation
Follow-up to #20071: make the agent panel's unmount total, so no teardown step can be skipped by an earlier one throwing. `onBeforeUnmount`, ahead of the large unmount hook, so a throwing teardown step could no longer leave the layer id claimed in the module registry. Review ([thread](#20071 (comment)), raised by 4 of 8 reviewers) found that this rescues one victim and leaves the rest exposed, and the PR merged with the thread open and the fix deferred to a follow-up. This is that follow-up. A throw in `releaseCoachCompletionWaiters()`, `invalidateSubmission()`, `docOpMinter.detach()`, `restoreOpMinter.detach()`, `exitNodeSelectionMode()`, `stop()` or `setEditing`/`setCreating` still skips every later step in the same hook — including the PM-1575 `setCanvasSyncGate` reset, which the comment beside it calls the only thing standing between a turn resumed in the meantime and a torn-down follower's gate on the store singleton. The gate is not merely late in that case, it is never reset: a reverted-fix run of the new test records **zero** `setCanvasSyncGate` calls during unmount. It is also wider than one hook. No `app.config.errorHandler` is registered anywhere in the app, so Vue's `logError` re-throws outside production builds; the throw escapes `invokeArrayFns` and abandons the remaining `beforeUnmount` hooks (`attachment.cancelAllUploads()`) and the rest of `unmountComponent`, including `scope.stop()`. - **What**: every step of `AgentPanelRoot.vue`'s unmount now runs through a local `runPanelTeardown`, which reports a failing step as `failure_tearing_down_agent_panel` and continues to the next one. All three of the component's `onBeforeUnmount` hooks go through it, so no hook can abandon a later one either. Step order is unchanged. - **Steps are keyed, not positional**: the key rides on `tags.step`, because the error is swallowed now and the report is the only remaining signal that a release was skipped — telemetry has to be able to tell a `stopSession` failure (a leaked event-stream subscription and un-aborted turn recovery for the session) from a benign `clearCreatingTab` one. No key is integer-like, so `Object.entries` order is specified and insertion order stays the run order. Steps return `undefined` rather than `void` so an async step — whose rejection would escape the catch while still looking contained — fails to compile. The `reportError` call has its own try/catch, since it was the one call in the loop that could abort the teardown it was reporting on. - **Tests**: a new case arms `docOpMinter.detach()` to throw and asserts the PM-1575 gate is still reset to the always-safe default (`gate() === false`, `outcomeCount() === 0`); it fails on the primary assertion against `main` (`expected to be called once, but got 0 times`). The existing throwing-teardown case now asserts the error is *contained and reported* rather than escaping to Vue's handler, and also fails against `main`. A third case arms the reporter itself to throw and asserts the gate is still reset; it fails against an unguarded reporter. Both pre-existing cases assert the `step` tag. The minimap duplicate-free remount assertion from #20071 is unchanged. Four review findings came back on the first revision; three are fixed in 6234899 (async-step typing, the unguarded reporter, the undifferentiated `errorType`). The fourth — that several steps are themselves multi-release sequences with no internal guard — is real and is answered on the thread: it needs three small per-module changes rather than anything this call site can express, and `exitNodeSelectionMode()` in particular is re-entrant by design so splitting it at the call site is unsafe. This deliberately mirrors `runFollowerTeardown` in `crdt/useAgentCrdtFollower.ts` — same rationale, same report-and-continue shape — rather than sharing it, because that file is the CRDT follower's own teardown and its reporter is hard-coded to a different `errorType`. Say the word if you would rather have one shared helper and I will extract it. The second-order question the thread raises and this does not answer: registering an `app.config.errorHandler` would make unmount resilient app-wide instead of one component at a time. That is a global behavior change well outside a teardown fix, so it is not attempted here.
🎭 Playwright: ✅ 2148 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b6c760c1a1cf288541b5aee69679a0ba7f9b3117
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-04T14:03:46.131Z",
"gitSha": "ba7520a336b6b4dc00bb5fa0f52bbd7a6a2fa17a",
"branch": "backport-20078-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.5389999999757,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.624,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.234,
"heapDeltaBytes": 6988300,
"heapUsedBytes": 75944844,
"domNodes": -264,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 13.033999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2021.7719999999417,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.638,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.0849999999999,
"heapDeltaBytes": -3727452,
"heapUsedBytes": 59242708,
"domNodes": -259,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 12.16,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1791.7259999999828,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.577999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 899.994,
"heapDeltaBytes": 1538344,
"heapUsedBytes": 70404932,
"domNodes": -258,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 171.624,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.4540000000052,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.953000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 797.716,
"heapDeltaBytes": 2886176,
"heapUsedBytes": 71753484,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 175.47899999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1680.2260000000047,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.625,
"layouts": 6,
"layoutDurationMs": 1.1260000000000001,
"taskDurationMs": 415.38700000000006,
"heapDeltaBytes": 2972052,
"heapUsedBytes": 72025796,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 16.473,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.2699999999195,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.662999999999997,
"layouts": 6,
"layoutDurationMs": 1.2139999999999997,
"taskDurationMs": 376.19,
"heapDeltaBytes": 2956864,
"heapUsedBytes": 71953084,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.762,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 692.026999999996,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.779,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.52400000000006,
"heapDeltaBytes": 18451724,
"heapUsedBytes": 87157636,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 171.432,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 711.8209999999863,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.871,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.91299999999995,
"heapDeltaBytes": -7662480,
"heapUsedBytes": 61336920,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 174.814,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.7860000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 874.496,
"heapDeltaBytes": 39313768,
"heapUsedBytes": 106704196,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 72.019,
"eventListeners": 0,
"totalBlockingTimeMs": 577,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1205.8809999999767,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 918.344,
"heapDeltaBytes": 38536008,
"heapUsedBytes": 107950012,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 78.87299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 587,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.0510000000222,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.1410000000004,
"heapDeltaBytes": 15066748,
"heapUsedBytes": 91246832,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 184.62800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 238,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 887.260000000083,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.347,
"heapDeltaBytes": 16570628,
"heapUsedBytes": 93944892,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 193.31199999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 245,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12685.824999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11605.476999999999,
"heapDeltaBytes": 890132,
"heapUsedBytes": 82416372,
"domNodes": -14,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 9735.892999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 2351,
"frameDurationMs": 19.996666666666595,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11101.804000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10088.347,
"heapDeltaBytes": 15014632,
"heapUsedBytes": 96605764,
"domNodes": -16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8412.759,
"eventListeners": 0,
"totalBlockingTimeMs": 1513,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11367.050000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10323.858999999999,
"heapDeltaBytes": 14076756,
"heapUsedBytes": 95321140,
"domNodes": -16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8594.259000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 1610,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11430.286000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10402.578,
"heapDeltaBytes": -7398240,
"heapUsedBytes": 72839344,
"domNodes": -10,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8691.985,
"eventListeners": 0,
"totalBlockingTimeMs": 1555,
"frameDurationMs": 19.996666666666595,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2031.4420000000268,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.179000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 681.46,
"heapDeltaBytes": -16030488,
"heapUsedBytes": 73318320,
"domNodes": -242,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 42.177,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2031.4769999999953,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.369000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.534,
"heapDeltaBytes": -15984004,
"heapUsedBytes": 73149780,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 40.657,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3005.4000000000087,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.773000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1905.494,
"heapDeltaBytes": 7907188,
"heapUsedBytes": 97794684,
"domNodes": -247,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 1022.5260000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2599.668000000065,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.929,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1784.207,
"heapDeltaBytes": -233772,
"heapUsedBytes": 89860296,
"domNodes": -258,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 956.8370000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3641.116000000011,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.332,
"layouts": 60,
"layoutDurationMs": 14.048000000000002,
"taskDurationMs": 1777.57,
"heapDeltaBytes": -1729872,
"heapUsedBytes": 89441204,
"domNodes": -231,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 820.825,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3593.8249999999243,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.827,
"layouts": 60,
"layoutDurationMs": 14.376,
"taskDurationMs": 1749.5069999999998,
"heapDeltaBytes": 25845780,
"heapUsedBytes": 91002788,
"domNodes": -223,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 829.086,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3141.3109999999733,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1963.914,
"heapDeltaBytes": 7960808,
"heapUsedBytes": 74068660,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 1037.428,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3244.933999999944,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.376999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2080.241,
"heapDeltaBytes": -8335764,
"heapUsedBytes": 84661316,
"domNodes": -266,
"jsHeapTotalBytes": 7262208,
"scriptDurationMs": 1093.081,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.2110000000312,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.002000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.8169999999999,
"heapDeltaBytes": 9509536,
"heapUsedBytes": 73745224,
"domNodes": -246,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.457,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2058.8280000000623,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 621.9340000000001,
"heapDeltaBytes": -23443392,
"heapUsedBytes": 67592740,
"domNodes": -254,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 37.611999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 641.8110000000183,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.014999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.333,
"heapDeltaBytes": 13122096,
"heapUsedBytes": 83932792,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 150.62499999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.1919999999973,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.174000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.22300000000007,
"heapDeltaBytes": 13219432,
"heapUsedBytes": 83986652,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 149.137,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.7330000000165,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.301000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.09099999999995,
"heapDeltaBytes": 10623300,
"heapUsedBytes": 80929240,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.4999999999227,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.668000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.426,
"heapDeltaBytes": -6818184,
"heapUsedBytes": 64118068,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.383999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.0850000000355,
"styleRecalcs": 45,
"styleRecalcDurationMs": 17.995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 855.162,
"heapDeltaBytes": 7603432,
"heapUsedBytes": 77870900,
"domNodes": -259,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 123.03900000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.1109999999408,
"styleRecalcs": 44,
"styleRecalcDurationMs": 16.088,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 813.892,
"heapDeltaBytes": 3944592,
"heapUsedBytes": 74826380,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 119.70199999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.9939999999688,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.471999999999998,
"layouts": 5,
"layoutDurationMs": 13.204000000000004,
"taskDurationMs": 965.791,
"heapDeltaBytes": -6312096,
"heapUsedBytes": 82102740,
"domNodes": 13667,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 34.147999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9026.285000000029,
"styleRecalcs": 250,
"styleRecalcDurationMs": 46.40899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6134.219,
"heapDeltaBytes": -701532,
"heapUsedBytes": 88636388,
"domNodes": -243,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 3015.4869999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8475.496000000021,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.836999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5829.606,
"heapDeltaBytes": -1284928,
"heapUsedBytes": 88340644,
"domNodes": -241,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 2903.029,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17514.32,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17205.9,
"heapDeltaBytes": -63249424,
"heapUsedBytes": 172451256,
"domNodes": -8061,
"jsHeapTotalBytes": -10870784,
"scriptDurationMs": 282.586,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17877.340000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17547.12,
"heapDeltaBytes": -46462312,
"heapUsedBytes": 194879572,
"domNodes": -8061,
"jsHeapTotalBytes": -16191488,
"scriptDurationMs": 294.332,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21799.155000000042,
"styleRecalcs": 155,
"styleRecalcDurationMs": 23.906999999999957,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21664.646,
"heapDeltaBytes": -57511892,
"heapUsedBytes": 170384848,
"domNodes": -8061,
"jsHeapTotalBytes": -20123648,
"scriptDurationMs": 1040.709,
"eventListeners": -14928,
"totalBlockingTimeMs": 376,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21891.427999999905,
"styleRecalcs": 153,
"styleRecalcDurationMs": 21.395999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21786.496999999996,
"heapDeltaBytes": -41917724,
"heapUsedBytes": 192319952,
"domNodes": -8061,
"jsHeapTotalBytes": -11878400,
"scriptDurationMs": 927.5850000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 93,
"frameDurationMs": 17.779999999999806,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-node-resize-workload",
"durationMs": 6490.229999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.90999999999998,
"layouts": 20,
"layoutDurationMs": 26.913000000000007,
"taskDurationMs": 6433.549000000001,
"heapDeltaBytes": -37347988,
"heapUsedBytes": 196926440,
"domNodes": -8061,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 116.45800000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 421,
"frameDurationMs": 19.44333333333331,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6411.2010000000055,
"styleRecalcs": 20,
"styleRecalcDurationMs": 94.59499999999998,
"layouts": 20,
"layoutDurationMs": 34.784,
"taskDurationMs": 6384.4259999999995,
"heapDeltaBytes": -62607832,
"heapUsedBytes": 178592044,
"domNodes": -8061,
"jsHeapTotalBytes": 5566464,
"scriptDurationMs": 114.495,
"eventListeners": -14928,
"totalBlockingTimeMs": 433,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8813.632999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8659.233000000002,
"heapDeltaBytes": -18543164,
"heapUsedBytes": 172387360,
"domNodes": 0,
"jsHeapTotalBytes": -7602176,
"scriptDurationMs": 134.30900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8711.238999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8582.294000000002,
"heapDeltaBytes": 12402812,
"heapUsedBytes": 169860824,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 144.89300000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 136.71499999998105,
"styleRecalcs": 9,
"styleRecalcDurationMs": 25.242,
"layouts": 5,
"layoutDurationMs": 2.823,
"taskDurationMs": 116.55000000000001,
"heapDeltaBytes": 3337768,
"heapUsedBytes": 65724576,
"domNodes": 137,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.492000000000003,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 114.68400000001111,
"styleRecalcs": 8,
"styleRecalcDurationMs": 20.054,
"layouts": 4,
"layoutDurationMs": 1.987,
"taskDurationMs": 89.01100000000001,
"heapDeltaBytes": 3101692,
"heapUsedBytes": 69871208,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.587,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #20102 +/- ##
=============================================
Coverage ? 84.94%
=============================================
Files ? 2327
Lines ? 133481
Branches ? 33885
=============================================
Hits ? 113389
Misses ? 19730
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The #20078 backport reframed the unmount hook as keyed teardown steps and, in doing so, moved `++activeTabGeneration` from the first statement to the sixth on this release line. `cloud/1.54` raises that fence before anything else, and #20078's contract is that step order is unchanged -- so the move was an unrelated behavioral delta, not part of the error containment. Restore the release line's order: the fence is the first key again, so the steps that synchronously notify listeners and `flush: 'sync'` watchers (`releaseCoachCompletionWaiters`, submission invalidation, `mintPortWiring.detach()`, `exitNodeSelectionMode()`, `stop()`) can no longer run while the old generation still looks current. The keys now map 1:1, in order, onto the pre-backport statements, and `cloud/1.55` carries the same fence-first order via #20102.
Summary
Manual target-aware backport of #20078 after the automatic cherry-pick conflicted.
This preserves cloud/1.55's target-specific active-tab invalidation order while applying the merged total-teardown contract to every panel release. The target-native canvas-gate regression proves a throwing doc-op minter detach cannot skip the PM-1575 reset.
Source: #20078 (
8ae1b91f5bd3ad15b926953998edd07c287a4ed5)Verification
pnpm test:unit src/workbench/extensions/agent/AgentPanelRoot.test.ts --testTimeout=30000— 356 passedNODE_OPTIONS=--max-old-space-size=8192 pnpm typecheckpnpm exec eslint src/workbench/extensions/agent/AgentPanelRoot.vue src/workbench/extensions/agent/AgentPanelRoot.test.tspnpm exec oxfmt --check src/workbench/extensions/agent/AgentPanelRoot.vue src/workbench/extensions/agent/AgentPanelRoot.test.ts