Repository navigation
[backport core/1.54] fix(agent): make agent panel teardown total (#20078) - #20099
Conversation
Follow-up to #20071: make the agent panel's unmount total, so no teardown step can be skipped by an earlier one throwing. `onBeforeUnmount`, ahead of the large unmount hook, so a throwing teardown step could no longer leave the layer id claimed in the module registry. Review ([thread](#20071 (comment)), raised by 4 of 8 reviewers) found that this rescues one victim and leaves the rest exposed, and the PR merged with the thread open and the fix deferred to a follow-up. This is that follow-up. A throw in `releaseCoachCompletionWaiters()`, `invalidateSubmission()`, `docOpMinter.detach()`, `restoreOpMinter.detach()`, `exitNodeSelectionMode()`, `stop()` or `setEditing`/`setCreating` still skips every later step in the same hook — including the PM-1575 `setCanvasSyncGate` reset, which the comment beside it calls the only thing standing between a turn resumed in the meantime and a torn-down follower's gate on the store singleton. The gate is not merely late in that case, it is never reset: a reverted-fix run of the new test records **zero** `setCanvasSyncGate` calls during unmount. It is also wider than one hook. No `app.config.errorHandler` is registered anywhere in the app, so Vue's `logError` re-throws outside production builds; the throw escapes `invokeArrayFns` and abandons the remaining `beforeUnmount` hooks (`attachment.cancelAllUploads()`) and the rest of `unmountComponent`, including `scope.stop()`. - **What**: every step of `AgentPanelRoot.vue`'s unmount now runs through a local `runPanelTeardown`, which reports a failing step as `failure_tearing_down_agent_panel` and continues to the next one. All three of the component's `onBeforeUnmount` hooks go through it, so no hook can abandon a later one either. Step order is unchanged. - **Steps are keyed, not positional**: the key rides on `tags.step`, because the error is swallowed now and the report is the only remaining signal that a release was skipped — telemetry has to be able to tell a `stopSession` failure (a leaked event-stream subscription and un-aborted turn recovery for the session) from a benign `clearCreatingTab` one. No key is integer-like, so `Object.entries` order is specified and insertion order stays the run order. Steps return `undefined` rather than `void` so an async step — whose rejection would escape the catch while still looking contained — fails to compile. The `reportError` call has its own try/catch, since it was the one call in the loop that could abort the teardown it was reporting on. - **Tests**: a new case arms `docOpMinter.detach()` to throw and asserts the PM-1575 gate is still reset to the always-safe default (`gate() === false`, `outcomeCount() === 0`); it fails on the primary assertion against `main` (`expected to be called once, but got 0 times`). The existing throwing-teardown case now asserts the error is *contained and reported* rather than escaping to Vue's handler, and also fails against `main`. A third case arms the reporter itself to throw and asserts the gate is still reset; it fails against an unguarded reporter. Both pre-existing cases assert the `step` tag. The minimap duplicate-free remount assertion from #20071 is unchanged. Four review findings came back on the first revision; three are fixed in 6234899 (async-step typing, the unguarded reporter, the undifferentiated `errorType`). The fourth — that several steps are themselves multi-release sequences with no internal guard — is real and is answered on the thread: it needs three small per-module changes rather than anything this call site can express, and `exitNodeSelectionMode()` in particular is re-entrant by design so splitting it at the call site is unsafe. This deliberately mirrors `runFollowerTeardown` in `crdt/useAgentCrdtFollower.ts` — same rationale, same report-and-continue shape — rather than sharing it, because that file is the CRDT follower's own teardown and its reporter is hard-coded to a different `errorType`. Say the word if you would rather have one shared helper and I will extract it. The second-order question the thread raises and this does not answer: registering an `app.config.errorHandler` would make unmount resilient app-wide instead of one component at a time. That is a global behavior change well outside a teardown fix, so it is not attempted here.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🎭 Playwright: ✅ 1981 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-04T17:54:34.124Z",
"gitSha": "6caad95cc2635e90cc0f281d0732ce8bce0229a1",
"branch": "backport-20078-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2104.1849999999727,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.577,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.438,
"heapDeltaBytes": 9014764,
"heapUsedBytes": 80428016,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.068999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2048.2540000000427,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.084,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.4259999999999,
"heapDeltaBytes": 2531656,
"heapUsedBytes": 73538060,
"domNodes": -283,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.613999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2045.094000000006,
"styleRecalcs": 82,
"styleRecalcDurationMs": 36.293000000000006,
"layouts": 14,
"layoutDurationMs": 4.592,
"taskDurationMs": 1001.538,
"heapDeltaBytes": -11950700,
"heapUsedBytes": 62026724,
"domNodes": -279,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 171.238,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1844.620999999961,
"styleRecalcs": 75,
"styleRecalcDurationMs": 32.379,
"layouts": 14,
"layoutDurationMs": 3.7180000000000004,
"taskDurationMs": 938.7350000000001,
"heapDeltaBytes": 7839160,
"heapUsedBytes": 79389596,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 165.06699999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.6710000000912,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.307,
"layouts": 6,
"layoutDurationMs": 1.212,
"taskDurationMs": 372.022,
"heapDeltaBytes": 4572408,
"heapUsedBytes": 75939760,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.139999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.819000000056,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.531,
"layouts": 6,
"layoutDurationMs": 1.053,
"taskDurationMs": 375.39500000000004,
"heapDeltaBytes": 4726788,
"heapUsedBytes": 78874504,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.335999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 643.2469999999739,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.911999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.69000000000005,
"heapDeltaBytes": -7437608,
"heapUsedBytes": 63524600,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 165.45499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 674.8999999999796,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.341999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.4800000000001,
"heapDeltaBytes": -8264372,
"heapUsedBytes": 63108940,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 160.81799999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.0709999999744,
"styleRecalcs": 3,
"styleRecalcDurationMs": 5.603000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.998,
"heapDeltaBytes": -1038564,
"heapUsedBytes": 77416912,
"domNodes": -273,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 36.38000000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2038.4020000000191,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.249,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.9769999999999,
"heapDeltaBytes": -6400204,
"heapUsedBytes": 71123488,
"domNodes": -282,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 40.288000000000004,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2176.8409999999676,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.056000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1586.732,
"heapDeltaBytes": 736956,
"heapUsedBytes": 67110792,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 823.9380000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2260.9120000000757,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.099,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1644.628,
"heapDeltaBytes": -11177652,
"heapUsedBytes": 67567344,
"domNodes": -266,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 829.597,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3459.445999999957,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.155000000000001,
"layouts": 60,
"layoutDurationMs": 11.944,
"taskDurationMs": 1649.12,
"heapDeltaBytes": 60956,
"heapUsedBytes": 67415376,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 765.996,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3656.8529999999555,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.338000000000001,
"layouts": 60,
"layoutDurationMs": 12.551,
"taskDurationMs": 1734.459,
"heapDeltaBytes": 536904,
"heapUsedBytes": 68567152,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 825.9559999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3081.4599999999928,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.949000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1867.9920000000002,
"heapDeltaBytes": -15086488,
"heapUsedBytes": 68012664,
"domNodes": -283,
"jsHeapTotalBytes": -102400,
"scriptDurationMs": 930.3399999999999,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3074.4529999999486,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.775000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1861.9650000000001,
"heapDeltaBytes": 849492,
"heapUsedBytes": 68258948,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 940.8590000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1997.2149999999829,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.787,
"heapDeltaBytes": 11244264,
"heapUsedBytes": 77442100,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.277,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.0920000000096,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.413000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.601,
"heapDeltaBytes": 12880656,
"heapUsedBytes": 92003296,
"domNodes": -284,
"jsHeapTotalBytes": -102400,
"scriptDurationMs": 36.838,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.9919999999966,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.951,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.469,
"heapDeltaBytes": 14475848,
"heapUsedBytes": 88065776,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 150.727,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 640.7859999999346,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.041999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.288,
"heapDeltaBytes": 15118940,
"heapUsedBytes": 90829536,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 151.13899999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.1330000000153,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.788000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.08399999999995,
"heapDeltaBytes": -15150900,
"heapUsedBytes": 58077180,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.119000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2021.5009999999438,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.146999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.76,
"heapDeltaBytes": -6150140,
"heapUsedBytes": 67045524,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.898,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.1879999999655,
"styleRecalcs": 76,
"styleRecalcDurationMs": 27.904999999999998,
"layouts": 18,
"layoutDurationMs": 4.889,
"taskDurationMs": 817.359,
"heapDeltaBytes": 5600816,
"heapUsedBytes": 79281908,
"domNodes": -298,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 112.238,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1769.0169999999625,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.733999999999998,
"layouts": 18,
"layoutDurationMs": 5.053,
"taskDurationMs": 868.6720000000001,
"heapDeltaBytes": -15971584,
"heapUsedBytes": 57470120,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 117.68299999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.4869999999746,
"styleRecalcs": 18,
"styleRecalcDurationMs": 33.142999999999994,
"layouts": 14,
"layoutDurationMs": 15.791000000000002,
"taskDurationMs": 993.6680000000002,
"heapDeltaBytes": -6867352,
"heapUsedBytes": 83474776,
"domNodes": 13831,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 34.402,
"eventListeners": 2385,
"totalBlockingTimeMs": 151,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8420.284000000038,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5656.746,
"heapDeltaBytes": 7170880,
"heapUsedBytes": 85058136,
"domNodes": -281,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2697.711,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8418.630000000008,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.663,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5847.375,
"heapDeltaBytes": 7030792,
"heapUsedBytes": 85013608,
"domNodes": -280,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 2772.119,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17717.923000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17211.755,
"heapDeltaBytes": -42855048,
"heapUsedBytes": 177154772,
"domNodes": -8068,
"jsHeapTotalBytes": -11591680,
"scriptDurationMs": 343.509,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17724.604999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17017.714,
"heapDeltaBytes": -57825984,
"heapUsedBytes": 179100008,
"domNodes": -8068,
"jsHeapTotalBytes": -14884864,
"scriptDurationMs": 281.438,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21594.440999999963,
"styleRecalcs": 163,
"styleRecalcDurationMs": 20.496999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21281.881999999998,
"heapDeltaBytes": -31614396,
"heapUsedBytes": 193263256,
"domNodes": -8068,
"jsHeapTotalBytes": -14221312,
"scriptDurationMs": 986.9670000000001,
"eventListeners": -14925,
"totalBlockingTimeMs": 65,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21994.514999999978,
"styleRecalcs": 173,
"styleRecalcDurationMs": 20.86899999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21678.818,
"heapDeltaBytes": -65390992,
"heapUsedBytes": 169719224,
"domNodes": -8068,
"jsHeapTotalBytes": -14848000,
"scriptDurationMs": 919.4480000000001,
"eventListeners": -14921,
"totalBlockingTimeMs": 99,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6502.182999999945,
"styleRecalcs": 20,
"styleRecalcDurationMs": 99.28999999999999,
"layouts": 20,
"layoutDurationMs": 32.056000000000004,
"taskDurationMs": 6439.059,
"heapDeltaBytes": -45389404,
"heapUsedBytes": 177199592,
"domNodes": -8068,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 134.263,
"eventListeners": -14927,
"totalBlockingTimeMs": 442,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6313.658000000032,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.667,
"layouts": 20,
"layoutDurationMs": 24.943999999999996,
"taskDurationMs": 6245.629999999999,
"heapDeltaBytes": -36221920,
"heapUsedBytes": 183930112,
"domNodes": -8068,
"jsHeapTotalBytes": 18554880,
"scriptDurationMs": 112.77,
"eventListeners": -14929,
"totalBlockingTimeMs": 551,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8938.35200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8602.688,
"heapDeltaBytes": 10560740,
"heapUsedBytes": 180804704,
"domNodes": -1,
"jsHeapTotalBytes": -24641536,
"scriptDurationMs": 175.28,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9089.675000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8719.780000000002,
"heapDeltaBytes": 16530004,
"heapUsedBytes": 178999424,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 146.08499999999992,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 472.323000000074,
"styleRecalcs": 17,
"styleRecalcDurationMs": 20.11,
"layouts": 3,
"layoutDurationMs": 1.5339999999999998,
"taskDurationMs": 113.32499999999997,
"heapDeltaBytes": 4902100,
"heapUsedBytes": 76495284,
"domNodes": 145,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.443,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 453.3890000000156,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.674000000000003,
"layouts": 2,
"layoutDurationMs": 0.5559999999999998,
"taskDurationMs": 102.81599999999999,
"heapDeltaBytes": 4757528,
"heapUsedBytes": 74111076,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.161000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #20099 +/- ##
=============================================
+ Coverage 84.39% 84.40% +0.01%
=============================================
Files 2125 2125
Lines 127483 127501 +18
Branches 34359 34359
=============================================
+ Hits 107593 107622 +29
+ Misses 19702 19691 -11
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Addresses review feedback: #20099 (comment)
Addresses review feedback: #20099 (comment)
Summary
Manual target-aware backport of #20078 after the automatic cherry-pick conflicted.
core/1.54predates the doc/restore minters and minimap layer in the source diff, so this carrier applies the same total-teardown contract to the line'smintPortWiring, session, tab, canvas-gate, upload, and timer releases. It includes a target-native regression proving a throwingmintPortWiring.detach()cannot skip the PM-1575 canvas-sync gate reset.Source: #20078 (
8ae1b91f5bd3ad15b926953998edd07c287a4ed5)Verification
NODE_OPTIONS=--no-experimental-webstorage pnpm vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts— 284 passedpnpm exec oxfmt --check src/workbench/extensions/agent/AgentPanelRoot.vue src/workbench/extensions/agent/AgentPanelRoot.test.ts