Skip to content

[backport cloud/1.54] fix(agent): reopen saved workflows from chat history - #19734

Merged
christian-byrne merged 2 commits into
cloud/1.54from
backport-18866-to-cloud-1.54
Oct 1, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
backport-18866-to-cloud-1.54

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Manual backport of #18866. This restores saved target workflows when reopening Agent chat history.

Original: #18866

The first attempt (eee88dc3) resolved its six conflicted files by taking main's copy wholesale, which carried main-only context that does not exist on cloud/1.54 — the workspace-scoped agent storage keys, ComfyApi.serverFeatureFlagsSettled, three main-only test modules, 27 ADR index rows for ADRs absent here, and a browser spec written against a fixture hook this branch lacked. That head was red on twelve checks and its browser coverage never executed.

b1b257cc26 re-derives the backport by applying #18866's own hunks to this branch's files instead. See that commit's message for the per-decision detail. Verified at this head: typecheck, typecheck-aux, lint, format, knip, ADR index and locale checks clean; full unit suite green; and playwright-tests (cloud) now runs and passes, including the new agentHistoryReopensClosedWorkflow spec.

Justification: Release-branch backport merged under the program's standing 1.54/1.55 backport grant, which authorizes self-merge once our own gates pass — the substantive change was reviewed and approved on main as #18866 and no code changed in transit. Blast radius is the cloud/1.54 release branch only; the backport-specific delta (conflict resolution and branch adaptation) is verified by all required checks green at the exact merged head, including the browser spec the previous head never ran.

Selecting an Agent history chat now reopens its saved workflow when the
tab is closed. History stays visible until the conversation and workflow
are ready, then the selected chat becomes Current.

[PM-1640](https://linear.app/comfyorg/issue/PM-1640)

- Resolve saved targets through the workflow catalog and reuse known
open targets to avoid redundant requests.
- Reuse an already loaded Current conversation when returning from
history.
- Show accessible row loading and retry; preserve navigation across
panel remounts and guard superseded workflow opens.
- Preserve Current and its persisted session when deleting a different
chat that failed to open.

Missing/deleted targets, rapid selections, Back, retry, and panel
remounts. Graph activation uses the existing serialized loader;
cancellation guards run before activation, without adding rollback once
activation starts.

- Affected unit/component suites pass, covering saved-workflow
reopening, cancellation, loading/retry, remounts, and Current identity
(two existing expected failures retained).
- Full lint, typecheck, Knip, Fallow audit, formatting, and ADR checks
passed.
- No new Playwright regression: deferred REST/catalog/workflow responses
and panel remounts are covered by mounted Root tests using the real
session and stores; workflow-service tests cover activation
cancellation. These deterministic lower-level boundaries reproduce the
failures without another browser fixture duplicating them.
Browser/assistive-technology validation was not run at the author’s
request; human UX review remains pending.
@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 1, 2026 10:34am UTC
billing-web-test Ignored Ignored Oct 1, 2026 10:34am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 119f153d-3837-4ab2-b6ba-3b42f25e4287

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR labels Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/01/2026, 10:36:44 AM UTC

Links

🎭 Playwright: ✅ 1980 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1959 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 148ms TBT · 79.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.9 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.4 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 96ms TBT · 172.8 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 437ms TBT · 174.8 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 10ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 577ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.9 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -181
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 908ms
canvas-mouse-sweep: script duration 171ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 60.5 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -179
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 371ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.5 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 456ms
dom-widget-clipping: script duration 165ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.3 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 662ms
large-graph-idle: script duration 39ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.6 MB
large-graph-idle: DOM nodes -275
large-graph-idle: event listeners -193
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1691ms
large-graph-pan: script duration 831ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 75.2 MB
large-graph-pan: DOM nodes -142
large-graph-pan: event listeners -93
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1707ms
large-graph-zoom: script duration 769ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.7 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 2005ms
legacy-node-drag: script duration 971ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 90.5 MB
legacy-node-drag: DOM nodes -142
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 586ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.8 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -177
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 407ms
subgraph-dom-widget-clipping: script duration 140ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.7 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 506ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.3 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 825ms
subgraph-mouse-sweep: script duration 112ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.8 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -242
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 978ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 148ms
subgraph-transition-enter: heap used 79.5 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 6067ms
viewport-pan-sweep: script duration 2788ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 74.9 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -146
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16845ms
vue-large-graph-idle: script duration 303ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.4 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 131
vue-large-graph-pan: task duration 18185ms
vue-large-graph-pan: script duration 907ms
vue-large-graph-pan: TBT 96ms
vue-large-graph-pan: heap used 172.8 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 81ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6067ms
vue-node-resize-workload: script duration 112ms
vue-node-resize-workload: TBT 437ms
vue-node-resize-workload: heap used 174.8 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8328ms
vue-zoom-out-idle: script duration 137ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.9 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 4
workflow-execution: style recalc count 16
workflow-execution: task duration 114ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.8 MB
workflow-execution: DOM nodes 134
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-10-01T10:46:18.254Z",
  "gitSha": "bf938ae1c3dc050d4d1633f33085406bce71a832",
  "branch": "backport-18866-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2149.849999999958,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 10.614,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 655.381,
      "heapDeltaBytes": 12561644,
      "heapUsedBytes": 83224588,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 13.468000000000004,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2027.1020000000135,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.456,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 499.56700000000006,
      "heapDeltaBytes": -13542800,
      "heapUsedBytes": 57075712,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.808,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1923.9899999999466,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 33.64,
      "layouts": 14,
      "layoutDurationMs": 3.747,
      "taskDurationMs": 928.557,
      "heapDeltaBytes": -11535564,
      "heapUsedBytes": 59574600,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 175.631,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1814.9990000000003,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 27.942999999999994,
      "layouts": 14,
      "layoutDurationMs": 3.777,
      "taskDurationMs": 888.272,
      "heapDeltaBytes": -4053396,
      "heapUsedBytes": 67273192,
      "domNodes": -281,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 165.63899999999998,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.7960000000126,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.032,
      "layouts": 6,
      "layoutDurationMs": 1.015,
      "taskDurationMs": 373.74700000000007,
      "heapDeltaBytes": 4585264,
      "heapUsedBytes": 75985112,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.754000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1666.242000000011,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.419999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.083,
      "taskDurationMs": 367.628,
      "heapDeltaBytes": 4645680,
      "heapUsedBytes": 75957112,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.235999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 676.2970000000337,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.653,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.171,
      "heapDeltaBytes": -7414408,
      "heapUsedBytes": 63170836,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 166.92,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 669.7010000000319,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.163000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 448.306,
      "heapDeltaBytes": -7301400,
      "heapUsedBytes": 63187980,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 162.95200000000003,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2056.6689999999994,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.835000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 644.935,
      "heapDeltaBytes": 9165392,
      "heapUsedBytes": 85519880,
      "domNodes": -270,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 43.06,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2058.132999999998,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.599,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 679.9770000000001,
      "heapDeltaBytes": 7408892,
      "heapUsedBytes": 83508052,
      "domNodes": -280,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 34.816,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2274.608999999998,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.619999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1632.139,
      "heapDeltaBytes": 22765844,
      "heapUsedBytes": 89257476,
      "domNodes": 2,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 816.0699999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2411.2860000000182,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 16.099,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1748.971,
      "heapDeltaBytes": -8296096,
      "heapUsedBytes": 68545732,
      "domNodes": -285,
      "jsHeapTotalBytes": 684032,
      "scriptDurationMs": 845.6510000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3594.3300000000136,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.579000000000004,
      "layouts": 60,
      "layoutDurationMs": 11.538,
      "taskDurationMs": 1717.371,
      "heapDeltaBytes": 8204896,
      "heapUsedBytes": 76221620,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 773.754,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3473.863000000051,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.466000000000003,
      "layouts": 60,
      "layoutDurationMs": 11.604999999999999,
      "taskDurationMs": 1696.5169999999998,
      "heapDeltaBytes": 8079528,
      "heapUsedBytes": 76242804,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 764.447,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3078.663000000006,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.753999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1991.3269999999998,
      "heapDeltaBytes": 29303952,
      "heapUsedBytes": 97681136,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 973.347,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3165.9329999999954,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.7940000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2018.049,
      "heapDeltaBytes": 10874024,
      "heapUsedBytes": 92030152,
      "domNodes": -283,
      "jsHeapTotalBytes": -1519616,
      "scriptDurationMs": 968.9440000000001,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2023.6729999999739,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.546000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 583.6810000000002,
      "heapDeltaBytes": 9305476,
      "heapUsedBytes": 87889640,
      "domNodes": -268,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 31.10800000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2017.49099999995,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.9660000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.3670000000001,
      "heapDeltaBytes": 9882952,
      "heapUsedBytes": 87851432,
      "domNodes": -275,
      "jsHeapTotalBytes": -2723840,
      "scriptDurationMs": 34.321000000000005,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 591.6480000000206,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.286,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.2939999999999,
      "heapDeltaBytes": 15119392,
      "heapUsedBytes": 88785096,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 140.493,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 587.0590000000675,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.848,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.21,
      "heapDeltaBytes": 13927408,
      "heapUsedBytes": 86720632,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 139.10599999999997,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.3090000000402,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.173,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 505.65799999999996,
      "heapDeltaBytes": -14034652,
      "heapUsedBytes": 59400620,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.711,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2024.1970000000151,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.59,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 506.21700000000004,
      "heapDeltaBytes": -7639020,
      "heapUsedBytes": 64909672,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 8.78,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1738.8990000000035,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 28.744000000000003,
      "layouts": 18,
      "layoutDurationMs": 4.632,
      "taskDurationMs": 824.2900000000001,
      "heapDeltaBytes": -8968392,
      "heapUsedBytes": 63754224,
      "domNodes": -294,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 113.27199999999999,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1703.1579999999735,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.825,
      "layouts": 18,
      "layoutDurationMs": 4.597,
      "taskDurationMs": 826.0999999999998,
      "heapDeltaBytes": -8945764,
      "heapUsedBytes": 63758156,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 110.906,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1434.6679999999878,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 32.56199999999999,
      "layouts": 15,
      "layoutDurationMs": 15.647999999999996,
      "taskDurationMs": 977.5589999999999,
      "heapDeltaBytes": -8983728,
      "heapUsedBytes": 83387444,
      "domNodes": 13831,
      "jsHeapTotalBytes": 12582912,
      "scriptDurationMs": 32.304,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 148,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8624.551999999994,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.579,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5934.004,
      "heapDeltaBytes": -8681780,
      "heapUsedBytes": 67664036,
      "domNodes": -269,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 2694.073,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8972.862000000077,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.15,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6199.7609999999995,
      "heapDeltaBytes": 12552388,
      "heapUsedBytes": 89344308,
      "domNodes": -267,
      "jsHeapTotalBytes": -958464,
      "scriptDurationMs": 2881.596,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17617.282999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16879.161,
      "heapDeltaBytes": -56778408,
      "heapUsedBytes": 182146804,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18264064,
      "scriptDurationMs": 305.533,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17366.64899999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16810.27,
      "heapDeltaBytes": -59092608,
      "heapUsedBytes": 179418732,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19050496,
      "scriptDurationMs": 299.59799999999996,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16260.158000000047,
      "styleRecalcs": 92,
      "styleRecalcDurationMs": 13.402999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15641.919000000002,
      "heapDeltaBytes": -43923580,
      "heapUsedBytes": 168478544,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16941056,
      "scriptDurationMs": 888.7029999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 67,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21085.695999999985,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 18.282999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20728.587,
      "heapDeltaBytes": -28125872,
      "heapUsedBytes": 193896220,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20402176,
      "scriptDurationMs": 926.2309999999999,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 125,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6136.409000000014,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 83.12700000000001,
      "layouts": 20,
      "layoutDurationMs": 23.096000000000004,
      "taskDurationMs": 6053.136,
      "heapDeltaBytes": -35915120,
      "heapUsedBytes": 182542252,
      "domNodes": -8068,
      "jsHeapTotalBytes": 16982016,
      "scriptDurationMs": 108.938,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 502,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6202.184999999986,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.29799999999997,
      "layouts": 20,
      "layoutDurationMs": 21.305000000000003,
      "taskDurationMs": 6080.842,
      "heapDeltaBytes": -34216568,
      "heapUsedBytes": 183953524,
      "domNodes": -8068,
      "jsHeapTotalBytes": 14143488,
      "scriptDurationMs": 115.061,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 371,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8487.89099999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8306.447,
      "heapDeltaBytes": 4587672,
      "heapUsedBytes": 178768120,
      "domNodes": 0,
      "jsHeapTotalBytes": -13631488,
      "scriptDurationMs": 133.85999999999999,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8585.090000000037,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8350.093,
      "heapDeltaBytes": 19662972,
      "heapUsedBytes": 179723224,
      "domNodes": 0,
      "jsHeapTotalBytes": -10485760,
      "scriptDurationMs": 139.68500000000006,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 464.4550000000436,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 22.859000000000005,
      "layouts": 4,
      "layoutDurationMs": 1.7429999999999997,
      "taskDurationMs": 121.29,
      "heapDeltaBytes": 5184244,
      "heapUsedBytes": 74114960,
      "domNodes": 147,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 13.652,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 459.83799999999064,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 21.932,
      "layouts": 3,
      "layoutDurationMs": 0.8240000000000001,
      "taskDurationMs": 106.868,
      "heapDeltaBytes": 4874268,
      "heapUsedBytes": 74356940,
      "domNodes": 121,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.632,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50789 76083 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from ryan-di October 1, 2026 09:03
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

⚠️ Cursor review skipped — the counted diff (5670 changed lines, after generated-file exclusion) exceeds diff_size_cap (5000). No review panel ran on this PR.

Reduce the counted diff or split the PR, then re-apply the cursor-review label to trigger a fresh review. (If this repo runs the review on every push, a push is enough.)

@datadog-official

This comment has been minimized.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Drafting while the release dependency chain is reconciled. The source snapshot depends on APIs not present on this release line (including the Agent telemetry/storage contract from #18665 and #18978); CI correctly caught the missing contracts. This carrier will not be marked ready until those prerequisites are either safely backported or the change is adapted without them.

The manual backport resolved its six conflicted files by taking main's
copy wholesale. That carried main-only context those files sit in, none
of which exists on this release line, so the carrier could not build:
`StorageKeys.agentThread` / `clearLegacyAgentStorage` in the session
composition root, `ComfyApi.serverFeatureFlagsSettled` behind an unused
`flagsSettled` computed, three main-only test modules, 27 ADR index rows
for ADRs absent here, and a browser spec written against a fixture hook
and a types module this branch does not have.

Re-derive the backport by applying #18866's own hunks to this branch's
files instead:

- Keep the branch's `THREAD_STORAGE_KEY` constant; the workspace-scoped
  agent storage keys are a separate main change, not a dependency of
  this fix.
- Drop the `flagsSettled` computed. It was context in the source diff
  and has no consumer on this branch.
- Restrict the `docs/adr/README.md` hunk to the one new
  `AGENT-HISTORY-0038` row, as the source PR did. `pnpm adr:check`
  passes.
- Carry the `bootAgentApp` `beforeNavigate` hook into
  `agentPanelFixture`, which the new browser spec needs, and resolve
  `UserDataFullInfo` from `@/schemas/apiSchema` the way this branch's
  other fixtures already do.
- Mock `useWorkflowService` explicitly in the new selection suite.
  Relying on a deep automock return is vitest 5 behaviour; this line is
  on vitest 4, where an automocked function returns undefined.
- Skip the two hunks that edit an AgentPanel component test absent from
  this branch; the five new history tests the fix adds are carried.

Verified at this tree: typecheck, typecheck:browser, lint, format:check,
knip, adr:check, locale:check all clean; full unit suite 22473 passed /
10 expected fail; and the new browser spec passes against cloud/1.54
(`--project=cloud agentHistoryReopensClosedWorkflow.spec.ts`), which had
never executed at the previous head.
@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 1, 2026
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.57082% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...platform/workflow/core/services/workflowService.ts 93.75% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #19734   +/-   ##
=============================================
  Coverage              ?   84.03%           
=============================================
  Files                 ?     2123           
  Lines                 ?   127245           
  Branches              ?    32306           
=============================================
  Hits                  ?   106928           
  Misses                ?    20138           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.81% <30.00%> (?)
unit 79.21% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/AgentPanelRoot.vue 92.27% <100.00%> (ø)
...h/extensions/agent/components/agent/AgentPanel.vue 97.66% <100.00%> (ø)
...sions/agent/components/agent/ChatHistoryScreen.vue 100.00% <100.00%> (ø)
...agent/components/agent/ChatHistorySelectButton.vue 100.00% <100.00%> (ø)
...ensions/agent/components/agent/RunNoticeBanner.vue 100.00% <100.00%> (ø)
...ensions/agent/composables/agent/useAgentSession.ts 98.99% <100.00%> (ø)
...gent/composables/agent/useAgentWorkflowResolver.ts 100.00% <100.00%> (ø)
...ent/composables/agent/useAgentWorkflowSelection.ts 93.75% <100.00%> (ø)
...h/extensions/agent/stores/agent/agentPanelStore.ts 97.45% <100.00%> (ø)
...platform/workflow/core/services/workflowService.ts 96.85% <93.75%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review for the record. I am the author, so GitHub cannot accept this as an approval — it is a COMMENT stating the authority and the evidence behind the merge, not a substitute for independent review.

Authority. Christian's September 16 release instruction, extended on September 27 to cover both the 1.54 and 1.55 lines, allows this program's workers to review and merge Agent backport carriers once our own gates pass, and to carry a dependency a fix needs into a target unless that dependency was deliberately excluded from the release line.

What I reviewed. The conflict resolution, hunk by hunk, against what #18866 actually changed versus what was merely context around it. Three things were context and are deliberately not carried: the workspace-scoped agent storage keys (this branch keeps THREAD_STORAGE_KEY), clearLegacyAgentStorage, and ComfyApi.serverFeatureFlagsSettled behind a flagsSettled computed that has no consumer here. Carrying any of them would have imported an unrelated change into a release branch. Two things were adapted rather than carried: the new browser spec resolves UserDataFullInfo from @/schemas/apiSchema, which is what this branch's other fixtures do, and the new selection suite mocks useWorkflowService explicitly because this line pins vitest 4, where an automocked function returns undefined — the source relied on vitest 5's deep automock. One thing was carried, because a release branch whose fixture contract drifts from the specs backported against it is a known multi-day failure mode: the two-line optional beforeNavigate hook on bootAgentApp.

Evidence at b1b257cc26edd1c7360c7a737591c034db36a802. All 84 non-skipped checks green, zero adverse. repo-checks ran the knip/locale/ADR step to success, which the previous head skipped because knip aborted first. playwright-tests (cloud) ran and passed — at the previous head every Playwright job was skipped, so the claim of browser coverage had never been executed. Locally against this branch: full unit suite 22473 passed / 10 expected fail, and the new agentHistoryReopensClosedWorkflow spec passes under --project=cloud.

Merge base is the live cloud/1.54 tip 2b4f09c5a5d5182268157138f174af2e7b0a3d0e, reached by merging the target into the carrier rather than rebasing onto main, so there is no untested delta and no file-overlap advisory to judge.

Post-merge peer review is still owed and is not waived by this comment.

@christian-byrne
christian-byrne merged commit 22e29bc into cloud/1.54 Oct 1, 2026
98 checks passed
@christian-byrne
christian-byrne deleted the backport-18866-to-cloud-1.54 branch October 1, 2026 10:56
christian-byrne added a commit that referenced this pull request Oct 1, 2026
The prerequisite carrier landed as #19734 (22e29bc), which re-derived
#18866 against this branch's files after the first attempt (eee88dc, the
second commit on this branch) resolved its conflicts by taking main's copy
wholesale. Both now sit on the same branch, which is what GitHub reported
as CONFLICTING.

Resolution: take cloud/1.54's content for every file the two prerequisites
share, then re-apply #19240's own hunks on top. The merged tree therefore
equals origin/cloud/1.54 plus exactly the six-file #19240 delta and nothing
else — eee88dc's main-only context (workspace-scoped agent storage keys,
ComfyApi.serverFeatureFlagsSettled, three main-only test modules, 27 ADR
index rows for ADRs absent here) is gone.

Verified before commit:
  git diff --cached --stat origin/cloud/1.54
    -> the 6 files of d46c6ed only, +371/-9

No force-push: this is a merge, so the previously reviewed head d46c6ed
remains in the history.
christian-byrne added a commit that referenced this pull request Oct 1, 2026
Two main-only assumptions travelled with the backport and are why the
browser coverage never executed and `typecheck` was red at d46c6ed:

- `AgentPanel.open()` returns `Promise<Locator>` on `main` and
  `Promise<void>` here, so `const panel = await agentPanel.open()` did not
  compile (`error TS2339: Property 'getByText' does not exist on type
  'void'`, reproduced by restoring the old file). The spec uses
  `agentPanel.root` instead, which both branches expose.
- `TabLinkCard.test.ts` stubs `useWorkflowStore` by hand on this branch
  where `main` uses the real store, so the panel store's new `$onAction`
  subscription threw `workflowStore.$onAction is not a function` and took
  all 11 of its tests down. The stub now offers the subscription.

Neither changes production code: this is the backport adaptation #19734's
message describes, applied to the dependent carrier.

Verified at this tree: typecheck, typecheck:browser, format:check, lint
(0 errors), knip, adr:check, locale:check; full unit suite 1583/1583 files
and 22490 tests; `playwright --project=cloud
browser_tests/tests/agent/agentDeletedTargetNotice.spec.ts` green, which it
had never been.

The spec also gains a second case, `gives a workflow saved at the deleted
path its own identity`, which saves a replacement workflow at the deleted
target's name and asserts the chat's next turn carries the replacement's own
cloud id. It is the black-box answer to the reviewers' overwrite-vs-delete
and recycled-path questions, and it fails against the fixture's old id
scheme (it posts the deleted workflow's id, `…000000000001`).
christian-byrne added a commit that referenced this pull request Oct 1, 2026
Port #18152's own delta onto cloud/1.54, rebased onto 22e29bc so the
branch fast-forwards. Eight files carry the source's added and removed lines
unchanged; useAgentSession.ts and its test carry three adaptations, each for
an API main has and this release line does not:

- THREAD_STORAGE_KEY (the unscoped key this branch already uses) in place of
  StorageKeys.agentThread(), which comes from #17765. (g15) asserts that key.
- The recovery reportError omits `surface`, which comes from #19230.
- agentTranscript.ts keeps this branch's pre-#19585 zPersistedToolCallSummary
  handling (the .pick(), the `toolCallId ?? id` fallback, and the `ok` success
  alias); only #18152's own hunks are applied, including the toolCallPartState
  doc-comment correction, worded onto this branch's text.

Resolved against #19734, which landed on cloud/1.54 after the previous head
was built: start() keeps that PR's initializeWorkflowContext/{restore} shape
with #18152's `connection = 'initial'`, and hydrateFromServer keeps its
readyThreadId/workflowReady block with reconcileLiveTurns() at the source's
position. Because #19734 introduced onThreadActivated, forgetDeletedThread
now carries the source's onThreadActivated?.(null) instead of dropping it.

Addresses #19697 (review)
Addresses #19697 (review)
christian-byrne added a commit that referenced this pull request Oct 1, 2026
…reconnect (#19697)

Manual backport of #18152 after the automated cherry-pick conflicted.
Preserves active Agent turns across transient socket disconnects and
reconciles them from persisted REST history.

Original: #18152

## What this branch contains

#18152's own delta, cherry-picked onto `cloud/1.54` and rebased onto
`22e29bc94e` so the branch fast-forwards. Eight of the eleven files
carry the source's added and removed lines unchanged:
`agentTurnLockFixture.ts`, both browser specs, `agentRestClient.ts` and
its test, `agentTranscript.test.ts`, and `agentConversationStore.ts` and
its test.

## Adaptations, and why each one is needed

Each of these stands in for an API that exists on `main` and not on this
release line.

| Adaptation | Reason |
| --- | --- |
| `THREAD_STORAGE_KEY` (the unscoped key this branch already uses) in
place of `StorageKeys.agentThread()`; `(g15)` asserts that key |
Workspace-scoped agent thread storage comes from #17765, which is not on
this line |
| The recovery `reportError` omits `surface` |
`ReportErrorOptions.surface` comes from #19230 |
| `agentTranscript.ts` keeps this branch's pre-#19585
`zPersistedToolCallSummary` handling — the `.pick()`, the `toolCallId ??
id` fallback, and the `ok` success alias. Only #18152's own hunks are
applied, including the `toolCallPartState` doc-comment correction,
worded onto this branch's text | The generated `ToolCallSummary` schema
change comes from #19585; on this line `tool_call_id` is still optional
|

Nothing else diverges from the source: `useAgentSession.ts`'s and
`agentTranscript.ts`'s remaining added and removed lines are the
source's, and all 22 source test additions are present with the
`(g3)`/`(g4)` pins un-failed.

## Conflict resolution against #19734

#19734 landed on `cloud/1.54` after the previous head was built, and is
what the branch conflicted with.

- `start()` keeps #19734's `initializeWorkflowContext` / `{ restore }`
shape and takes #18152's one change to it, `everLive = false` →
`connection = 'initial'`.
- `hydrateFromServer()` keeps #19734's `readyThreadId` / `workflowReady`
block and takes `reconcileLiveTurns()` at the source's position,
immediately after `conversationStore.hydrate(history)`.
- #19734 also introduced `onThreadActivated`, so `forgetDeletedThread`
now carries the source's `onThreadActivated?.(null)` rather than
dropping it. That drop was a necessary adaptation against the previous
merge base and is no longer one.

## Verification at this head

- `vue-tsc --noEmit`: clean.
- `vitest run` over `useAgentSession.test.ts`, `services/agent/`, and
`stores/agent/`: 556 passed across 21 files.
- `oxfmt --check`, `oxlint --type-aware`, `oxlint:audit`, `eslint`:
clean.
- `agentTurnSurvivesSocketDrop.spec.ts` +
`agentApprovalSurvivesSocketDrop.spec.ts` on the `cloud` project against
a `DISTRIBUTION=cloud` dev server: **10/10 passed**.
- Red-on-parent control: with only the four production files reverted to
`cloud/1.54` and the specs kept, **6 of those 10 fail** and the 4
socket-never-drops / normal-completion controls still pass — so the
reconnect behaviour this backport carries is what the specs are
measuring.
christian-byrne added a commit that referenced this pull request Oct 1, 2026
…19735)

Stacked manual backport of #19240 on the #18866 `cloud/1.54` carrier.
This makes an open Agent chat explicitly report when its target workflow
was deleted, and includes the source unit and browser coverage.

Original: #19240

## Repaired after the prerequisite landed

The prerequisite shipped as #19734 (`22e29bc9`), which re-derived #18866
against this branch's files after the first attempt — `eee88dc3`, still
the second commit on this branch — resolved its conflicts by taking
`main`'s copy wholesale. Both versions then sat on the same branch,
which is what GitHub reported as `CONFLICTING`.

`0f2d27d1` merges `cloud/1.54` in rather than force-pushing, so the
previously reviewed head `d46c6ed9` stays in the history. The resolution
takes `cloud/1.54`'s content for every file the two prerequisites share
and re-applies #19240's own hunks on top, so the merged tree equals
`origin/cloud/1.54` plus exactly the six-file #19240 delta and nothing
else (`git diff --cached --stat origin/cloud/1.54` → +371/-9 across
those six files).

Two `main`-only assumptions then had to be adapted, and they are why
`typecheck` was red and the browser coverage never executed at the old
head:

- `AgentPanel.open()` returns `Promise<Locator>` on `main` and
`Promise<void>` here, so `const panel = await agentPanel.open()` did not
compile. The spec uses `agentPanel.root`.
- `TabLinkCard.test.ts` hand-stubs `useWorkflowStore` on this branch
where `main` uses the real store, so the panel store's new `$onAction`
subscription threw and took all 11 of its tests down. The stub now
offers the subscription.

`agentPanelStore.ts` differs from `origin/main` only in the pre-existing
`api.serverFeatureFlagsSettled` lines that `main` has and this release
line does not; #19240's production delta is applied verbatim.

## Review findings

All seven threads are answered inline and resolved. Two were real and
are fixed in the browser fixture — cloud ids came from `workflows.length
+ 1`, which reissued a live entry's id to a workflow saved after a
delete or a refused turn, and the listing name was sliced on the
`workflows/` prefix alone without requiring the `.json` suffix, in both
the POST and the DELETE handler. The rest were raised and dispositioned
on #19240 itself, or describe pre-existing behaviour this change does
not touch; a release carrier is not the place to diverge production
behaviour from the approved parent. One genuinely new finding —
`renameWorkflow` rejecting after it has already swapped the path leaves
`closedPath` stale — is recorded for `main` rather than fixed here.

## Proof at this head

- `agentDeletedTargetNotice.spec.ts` gains "gives a workflow saved at
the deleted path its own identity": it saves a replacement at the
deleted target's name and asserts the chat's next turn carries the
replacement's own cloud id. It fails against the old fixture id scheme,
where the turn posted the deleted workflow's `…000000000001`.
- `useAgentWorkflowSelection.test.ts` gains the
delete-settles-mid-restoration ordering, which fails if
`markWorkflowTargetUnavailable()` is removed from `onWorkflowRestored`.
- `agentPanelTarget.test.ts` records the store-side boundary for that
same ordering.
- Green locally at `c2e6b2b6`: `typecheck`, `typecheck:browser`,
`format:check`, `lint` (0 errors), `knip`, `adr:check`, `locale:check`;
full unit suite 1583/1583 files and 22490 tests; and `playwright
--project=cloud` over `agentDeletedTargetNotice`,
`agentWorkflowSelection`, `agentHistoryReopensClosedWorkflow` and
`agentStaleWorkflowTabBinding` — 12 passed.


---

Justification: Release-branch backport merged by its author under this
program's standing Agent 1.54/1.55 backport grant (Christian,
2026-09-16, extended 2026-09-27), which authorizes the carrier's own
author to merge once their own gates pass — GitHub cannot accept an
author's self-approval, so no pre-merge approval record exists. What
limits the blast radius: the change is confined to `cloud/1.54` at
+526/-13 across 8 files (one production file, `agentPanelStore.ts`, plus
its own tests, one browser fixture, one spec and one ADR); the target
refresh is provably content-neutral, with the carrier patch
byte-identical to the previously reviewed head (sha256
`60d6f077a45ed4ed8fa563defbfe8c0dcc947a95f208b7c8ca7f3f870ce88a6b`);
there is zero file overlap with the untested target delta; every
required check is green at the exact merged head; and the user-visible
behaviour was proven on this carrier through the black-box harness
(`browser_tests/tests/agent/agentDeletedTargetNotice.spec.ts`).
Post-merge peer review is still owed under SOC 2 CC8.1 and is NOT waived
by this line; it routes to @DrJKL for `ComfyUI_frontend`.

---------

Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants