Repository navigation
[backport cloud/1.54] fix(agent): keep the turn live across a socket reconnect - #19697
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🎭 Playwright: ✅ 1980 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-01T18:06:35.285Z",
"gitSha": "09d898e50b94f800bf2ff9a2a029ccc197007c9a",
"branch": "backport-18152-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2134.824999999978,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.615999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.568,
"heapDeltaBytes": -11546932,
"heapUsedBytes": 59368980,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.37,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2005.404999999996,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.473,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.191,
"heapDeltaBytes": 1744844,
"heapUsedBytes": 71586936,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6.805000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1770.341999999971,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.332,
"layouts": 14,
"layoutDurationMs": 2.863,
"taskDurationMs": 648.106,
"heapDeltaBytes": -5028552,
"heapUsedBytes": 65909716,
"domNodes": -277,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 97.46400000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.0659999999307,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.615,
"layouts": 14,
"layoutDurationMs": 2.7430000000000003,
"taskDurationMs": 606.7360000000001,
"heapDeltaBytes": 13498800,
"heapUsedBytes": 83522388,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 89.04500000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.7910000000052,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.772,
"layouts": 6,
"layoutDurationMs": 1.096,
"taskDurationMs": 252.323,
"heapDeltaBytes": 4567968,
"heapUsedBytes": 75701184,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8.929,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1657.6599999999644,
"styleRecalcs": 29,
"styleRecalcDurationMs": 9.671,
"layouts": 6,
"layoutDurationMs": 0.9219999999999998,
"taskDurationMs": 252.44100000000003,
"heapDeltaBytes": 4664012,
"heapUsedBytes": 75707108,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8.499,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 524.2319999999836,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.677999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.182,
"heapDeltaBytes": 18899640,
"heapUsedBytes": 88912672,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 103.77900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 520.9229999999252,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.86,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 300.78499999999997,
"heapDeltaBytes": 18716640,
"heapUsedBytes": 83319268,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 100.491,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2037.193000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.233,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.063,
"heapDeltaBytes": -15510500,
"heapUsedBytes": 87532572,
"domNodes": -263,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 31.633999999999997,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.6959999999117,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.079999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.651,
"heapDeltaBytes": 9514160,
"heapUsedBytes": 85669016,
"domNodes": -268,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 28.388000000000005,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2150.4540000000247,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.804,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1173.512,
"heapDeltaBytes": 11511512,
"heapUsedBytes": 88856704,
"domNodes": -272,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 542.5340000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2092.604999999935,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.499999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1173.1850000000002,
"heapDeltaBytes": 23835884,
"heapUsedBytes": 90303236,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 564.894,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3075.4400000000146,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.575000000000001,
"layouts": 60,
"layoutDurationMs": 11.945,
"taskDurationMs": 1187.5959999999998,
"heapDeltaBytes": 8223492,
"heapUsedBytes": 76268396,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 511.292,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3140.5690000000277,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.934999999999997,
"layouts": 60,
"layoutDurationMs": 12.232,
"taskDurationMs": 1300.894,
"heapDeltaBytes": -8619068,
"heapUsedBytes": 70566820,
"domNodes": -288,
"jsHeapTotalBytes": 3829760,
"scriptDurationMs": 541.846,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2096.192999999971,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.961,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1286.63,
"heapDeltaBytes": 21053368,
"heapUsedBytes": 89214828,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 608.686,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2151.6279999999597,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.014999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1247.34,
"heapDeltaBytes": 19862380,
"heapUsedBytes": 101272280,
"domNodes": 14,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 584.04,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2015.3080000000045,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.267000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.86600000000004,
"heapDeltaBytes": 1710568,
"heapUsedBytes": 82332668,
"domNodes": -272,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 28.435000000000002,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.5400000000636,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.668000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.07399999999996,
"heapDeltaBytes": 9862504,
"heapUsedBytes": 87724368,
"domNodes": -270,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 25.999000000000002,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 465.0940000000219,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.803,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 279.115,
"heapDeltaBytes": 14814104,
"heapUsedBytes": 88541628,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 86.484,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 427.4990000000116,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.375,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 273.231,
"heapDeltaBytes": 15114672,
"heapUsedBytes": 88109296,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 87.674,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.6690000000117,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.916000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.12300000000005,
"heapDeltaBytes": -8814200,
"heapUsedBytes": 64559748,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 5.8,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1993.7720000000354,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.2250000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.26000000000005,
"heapDeltaBytes": -9181896,
"heapUsedBytes": 63577052,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 5.892000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.7729999999979,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.957,
"layouts": 18,
"layoutDurationMs": 3.933,
"taskDurationMs": 594.857,
"heapDeltaBytes": 5981040,
"heapUsedBytes": 78388364,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 72.644,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.0509999999977,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.944,
"layouts": 18,
"layoutDurationMs": 2.9330000000000007,
"taskDurationMs": 557.421,
"heapDeltaBytes": -10309260,
"heapUsedBytes": 63272640,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 64.121,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 866.1539999999377,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.901999999999997,
"layouts": 16,
"layoutDurationMs": 9.654,
"taskDurationMs": 636.2289999999999,
"heapDeltaBytes": -5125188,
"heapUsedBytes": 89601104,
"domNodes": 13831,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 19.639000000000003,
"eventListeners": 2385,
"totalBlockingTimeMs": 99,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8151.2869999999675,
"styleRecalcs": 249,
"styleRecalcDurationMs": 31.214,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3898.313,
"heapDeltaBytes": -7996472,
"heapUsedBytes": 67745796,
"domNodes": -282,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 1702.61,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8161.462000000029,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4088.97,
"heapDeltaBytes": 9564064,
"heapUsedBytes": 86278232,
"domNodes": -262,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 1815.261,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11470.226999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10482.410999999998,
"heapDeltaBytes": -39225428,
"heapUsedBytes": 179048672,
"domNodes": -8067,
"jsHeapTotalBytes": -11792384,
"scriptDurationMs": 162.79399999999998,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 10890.21200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9888.027999999998,
"heapDeltaBytes": -18897580,
"heapUsedBytes": 185607916,
"domNodes": -8068,
"jsHeapTotalBytes": -3403776,
"scriptDurationMs": 142.27200000000002,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13809.776999999996,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.431999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13297.401999999998,
"heapDeltaBytes": -38365756,
"heapUsedBytes": 166452304,
"domNodes": -8068,
"jsHeapTotalBytes": -13148160,
"scriptDurationMs": 756.03,
"eventListeners": -14929,
"totalBlockingTimeMs": 66,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13868.86800000002,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.078000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13251.829000000002,
"heapDeltaBytes": -39165864,
"heapUsedBytes": 167893472,
"domNodes": -8068,
"jsHeapTotalBytes": -13918208,
"scriptDurationMs": 649.9970000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3960.0510000000213,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.96700000000001,
"layouts": 20,
"layoutDurationMs": 21.391999999999996,
"taskDurationMs": 3831.9770000000003,
"heapDeltaBytes": -34472896,
"heapUsedBytes": 184746168,
"domNodes": -8068,
"jsHeapTotalBytes": 13410304,
"scriptDurationMs": 63.62800000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 59,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4183.152000000064,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.675000000000004,
"layouts": 20,
"layoutDurationMs": 25.32799999999999,
"taskDurationMs": 4017.4,
"heapDeltaBytes": -39487424,
"heapUsedBytes": 178729736,
"domNodes": -8072,
"jsHeapTotalBytes": 18878464,
"scriptDurationMs": 69.897,
"eventListeners": -14933,
"totalBlockingTimeMs": 80,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5567.930000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5260.124,
"heapDeltaBytes": 11266548,
"heapUsedBytes": 179776396,
"domNodes": 0,
"jsHeapTotalBytes": -22020096,
"scriptDurationMs": 80.79000000000003,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6141.9329999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5639.673,
"heapDeltaBytes": 13170452,
"heapUsedBytes": 185116532,
"domNodes": 0,
"jsHeapTotalBytes": -2097152,
"scriptDurationMs": 84.01599999999992,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 80.2209999999377,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.418000000000001,
"layouts": 3,
"layoutDurationMs": 1.119,
"taskDurationMs": 54.82299999999999,
"heapDeltaBytes": 3090116,
"heapUsedBytes": 71710724,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.297000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 437.01400000009016,
"styleRecalcs": 18,
"styleRecalcDurationMs": 16.358999999999998,
"layouts": 3,
"layoutDurationMs": 1.3259999999999998,
"taskDurationMs": 88.12800000000001,
"heapDeltaBytes": 5002936,
"heapUsedBytes": 73778044,
"domNodes": 144,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.898,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 6 |
| 🟢 Low | 1 |
Panel: 8/8 reviewers contributed findings.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. This branch replaces four files with main's post-#18152 contents instead of porting #18152's delta, which pulls in main-only changes that cloud/1.54 lacks and breaks typecheck and the unit tests.
I compared this branch, against its merge base 327e65b (the current cloud/1.54 tip), with #18152's merged diff (d90c109 against its parent 1519cc0).
What matches: agentTurnLockFixture.ts, agentTurnSurvivesSocketDrop.spec.ts, the approval spec (renamed to agentApprovalSurvivesSocketDrop.spec.ts on this branch), agentRestClient.ts and its test, agentTranscript.test.ts, and agentConversationStore.test.ts carry exactly the source's added and removed lines.
What diverges:
useAgentSession.ts,useAgentSession.test.ts,agentTranscript.ts, andagentConversationStore.tsare byte-identical to their contents at d90c109 onmain. The source changes these files by +223/-26, +752/-90, +14/-24, and +195/-15. Here they change by +391/-122, +1045/-188, +115/-80, and +228/-26. The extra lines are the gap betweencloud/1.54andmain's pre-image of these files, about +606/-272 lines. That gap includes workspace-scoped agent thread storage (#17765), errorsurfacetags (#19230), the generatedToolCallSummaryschema (#19585), and the store's per-thread attachment-name memory.- Checks at this head fail. Hosted
setup/ typecheck reports 30 errors, all in these files or inAgentPanelRoot.vue, which consumes them. Hostedtestreports 494 failed out of 22,453. Locally at d97f80c,vitest runoveruseAgentSession.test.ts,agentTranscript.test.ts, andagentConversationStore.test.tsgives 152 failed and 98 passed. 135 of those failures areTypeError: StorageKeys.agentThread is not a function. Lint, build, and e2e jobs fail downstream.
The inline comments point at representative lines; each one marks a whole class of the same problem. The fix is to cherry-pick #18152's own delta onto cloud/1.54 and resolve each conflict against the API this branch actually has. Each adaptation should then be named in the description.
Port the source PR hunks onto the cloud 1.54 APIs while retaining its approval, telemetry, and request-handling behavior. Addresses #19697 (review)
d97f80c to
f1319d2
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #19697 +/- ##
=============================================
Coverage ? 84.06%
=============================================
Files ? 2123
Lines ? 127472
Branches ? 34262
=============================================
Hits ? 107153
Misses ? 20140
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. The new head is now a real port of #18152 and fixes the whole-file copy, but it drops three source hunks that apply cleanly to cloud/1.54.
I compared this branch, at f1319d2 against its merge base 327e65b, with #18152's merged diff (d90c109 against its parent 1519cc0). The branch merges cleanly into the current cloud/1.54 tip, 2b4f09c.
What matches:
- Eight files carry exactly the source's added and removed lines:
agentTurnLockFixture.ts, both browser specs,agentRestClient.tsand its test,agentTranscript.test.ts, andagentConversationStore.tsand its test. - In
useAgentSession.tsand its test, these adaptations account for somethingcloud/1.54lacks:- The unscoped
THREAD_STORAGE_KEYreplacesStorageKeys.agentThread(), and(g15)asserts that key. onThreadActivated?.(null)is dropped.- The recovery
reportErroromitssurface.
All three aremain-only APIs here.
- The unscoped
- All 22 source test additions are present, and the pins are un-failed.
- At f1319d2:
vitest runoveruseAgentSession.test.ts,services/agent/, andstores/agent/passed 547/547 across 21 files, andvue-tsc --noEmitpassed. All hosted checks at this head passed.
What diverges is inline.
Port #18152's own delta onto cloud/1.54, rebased onto 22e29bc so the branch fast-forwards. Eight files carry the source's added and removed lines unchanged; useAgentSession.ts and its test carry three adaptations, each for an API main has and this release line does not: - THREAD_STORAGE_KEY (the unscoped key this branch already uses) in place of StorageKeys.agentThread(), which comes from #17765. (g15) asserts that key. - The recovery reportError omits `surface`, which comes from #19230. - agentTranscript.ts keeps this branch's pre-#19585 zPersistedToolCallSummary handling (the .pick(), the `toolCallId ?? id` fallback, and the `ok` success alias); only #18152's own hunks are applied, including the toolCallPartState doc-comment correction, worded onto this branch's text. Resolved against #19734, which landed on cloud/1.54 after the previous head was built: start() keeps that PR's initializeWorkflowContext/{restore} shape with #18152's `connection = 'initial'`, and hydrateFromServer keeps its readyThreadId/workflowReady block with reconcileLiveTurns() at the source's position. Because #19734 introduced onThreadActivated, forgetDeletedThread now carries the source's onThreadActivated?.(null) instead of dropping it. Addresses #19697 (review) Addresses #19697 (review)
f1319d2 to
d433e54
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. The rebased port of #18152 is faithful in production code, but (g15) still drops the source's onThreadActivated assertion, which cloud/1.54 now supports.
I compared this branch, at d433e54 against its merge base 22e29bc (the current cloud/1.54 tip), with #18152's merged diff (d90c109 against its parent 1519cc0).
What matches:
- Eight files carry exactly the source's added and removed lines:
agentTurnLockFixture.ts, both browser specs,agentRestClient.tsand its test,agentTranscript.test.ts, andagentConversationStore.tsand its test. - The rebase onto #19734 brought
onThreadActivatedto this branch, soforgetDeletedThreadnow carries the source'sonThreadActivated?.(null). TheSessionNoticeun-export and thehandleMessageDoneswitch tomarkStoppedTurnReadyare carried too, which resolves my earlier comments. - Remaining adaptations in
useAgentSession.ts:- The unscoped
THREAD_STORAGE_KEYreplacesStorageKeys.agentThread(), because workspace-scoped storage is not oncloud/1.54. - The recovery
reportErroromitssurface, because this branch'sReportErrorOptionshas no such field. - In
agentTranscript.ts, thetoolCallPartStatecomment edit is applied to this branch's older wording of that comment.
- The unscoped
- All 22 source test additions are present, and the pins are un-failed.
- At d433e54:
vitest runoveruseAgentSession.test.ts,services/agent/, andstores/agent/passed 556/556 across 21 files, andvue-tsc --noEmitpassed. When I posted, hosted checks had no failures so far and some were still running.
What diverges is inline.
Preserve locally streamed content when a terminal history row is empty, retain successor recovery ownership, and cover refresh-only completion in the browser harness.\n\nReview: https://github.com/Comfy-Org/ComfyUI_frontend/pull/19697#discussion_r4152078247\nReview: #19697 (comment)
Superseded by the exact-head adapted port at e357667: all review threads are resolved, the requested onThreadActivated assertion is present, and exact-head CI has no failures. Dismissing this stale review so current checks govern merge readiness.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #18152 to cloud/1.54, with each adaptation accounted for by the target.
I compared this branch, at e357667 against its merge base 22e29bc, with #18152's merged diff (d90c109 against its parent 1519cc0). e357667 restores the source's onThreadActivated setup and its toHaveBeenLastCalledWith(null) assertion in (g15), which resolves my earlier comment.
Eight files carry exactly the source's added and removed lines: agentTurnLockFixture.ts, both browser specs, agentRestClient.ts and its test, agentTranscript.test.ts, and agentConversationStore.ts and its test. In useAgentSession.ts, the source's SessionNotice un-export, the handleMessageDone switch to markStoppedTurnReady, and onThreadActivated?.(null) are carried as written.
Adaptations:
- The unscoped
THREAD_STORAGE_KEYreplacesStorageKeys.agentThread()inforgetDeletedThread, and(g15)asserts that key. Workspace-scoped agent thread storage is not oncloud/1.54. - The recovery job's
reportErroromitssurface, because this branch'sReportErrorOptionshas no such field. - In
agentTranscript.ts, thetoolCallPartStatecomment edit is applied to this branch's older wording of that comment.
All 22 source test additions are present, and the it.fails / test.fail pins are un-failed.
Checks:
- I merged the current
cloud/1.54tip, 01475ca, into this head locally. The merge is clean. - On the merged tree,
vitest runoveruseAgentSession.test.ts,services/agent/, andstores/agent/passed 559/559 across 21 files, andvue-tsc --noEmitpassed. - All PR checks at this head passed.
The PR merged at 18:19Z, as da27da8, while I was waiting on the last check, so this review is post-merge verification. The only red run on this SHA is the post-merge Cloud Backport Tag / create-tag job. It reported that it could not verify da27da8 on cloud/1.54, but that commit is the current cloud/1.54 tip, so this looks like a timing race in the tag job rather than a problem with the backport.
…1998) (#19901) ## Summary A `409 TURN_IN_PROGRESS` on send was a dead end; it now re-attaches to the turn that is holding the thread, so the user gets a Stop control instead of a raw server string. FE-1998. ## Changes - **What**: `useAgentSession` reads the 409 conflict body the agent service has sent since [cloud#8275](Comfy-Org/cloud#8275) (`type: "TURN_IN_PROGRESS"`, `active_message_id`, `turn_id`) and re-reads the thread on it. The re-read adopts the still-running assistant row as the active turn, which is what puts **Stop** where Send was; when that turn settles the composer unlocks on its own. The notice copy changes from the raw server message to `agent.sendTurnInProgress`. - **Dependencies**: none. ### Why the refusal was terminal The server's single-active-turn signal is a `status='streaming'` assistant row, durable in Postgres and deliberately surviving a worker restart (`services/agent/server/agent_handler.go`, `ThreadActiveTurn` → `rejectTurnInProgress`). So the thread stays locked until that row goes terminal, and nothing the user could reach from the panel cleared it: no stop control, no retry, and no way to tell a working turn from a dead one. ## Review Focus **Scope — this is the 409 route that composer gating does not close.** A turn *this* client can see already renders Stop and never offers Send, so it cannot reach the guard; #19697/#18152 and #18154 closed the reload and socket-drop routes. What remains is a turn started from a second tab, window or device: this client has no local signal, offers Send, and is refused. That is what the new spec exercises, and it is the only shape that can reach the refusal path at all now. **The re-read is bounded, on `reconcileSnapshotTurn`'s reasoning.** `performSend` awaits it and the composer sits in `sending` until it returns, so an unbounded await would let a slow workflow restore hold the one control the user needs. If the bound wins before the transcript lands, the reattachment is invalidated and the late snapshot is discarded. If the transcript has already landed and only workflow restore is still outstanding, the active turn remains adopted and the send reports that reattachment. **It goes through `hydrateFromServer`, not a bare `getMessages` + `hydrate`.** That is the one path which arms the hydration mailbox, so WS frames for the running turn that land during the GET are replayed rather than dropped. A second re-attach path would drift from it. **The discriminator is load-bearing** and has its own negative test: a 409 from another endpoint, or one whose body this client cannot parse, stays an ordinary send failure and triggers no re-read. **Fixture fidelity (please look at this).** `agentTurnLockFixture` answered a refused post with the 409's *message only*, so no spec could distinguish a client that reads the conflict ids from one that ignores them — the comment claimed the body was verbatim from `agent_handler.go` and it was not. It now sends the whole body. The generated `AgentError` type describes only `error`, because the OpenAPI schema does not cover this endpoint's conflict body; the fixture types the body as `AgentError & z.infer<typeof zTurnInProgressError>`, reusing the client's runtime schema for the conflict fields. *Filed as an upstream hypothesis for the ingest schema* rather than fixed here. ## Testing Black-box, red on the parent and green here: ``` browser_tests/tests/agent/agentSendRefusedByRunningTurn.spec.ts ``` On `origin/main` it fails at `expect(turnLock.stopButton).toBeVisible()` with "element(s) not found" — the dead end itself. It also drives the escape hatch end to end: Stop unlocks the composer and the retry is accepted with no second refusal and no page reload, which is this ticket's stated acceptance criterion. Unit: ``` useAgentSession.test.ts › re-attaches to the running turn when a send is refused with TURN_IN_PROGRESS useAgentSession.test.ts › does not let a timed-out re-attachment replace a newer turn useAgentSession.test.ts › records no failed send when the re-read finds the refused thread deleted useAgentSession.test.ts › leaves an undiscriminated 409 on an existing thread as a plain failure useAgentSession.test.ts › applies a pending stop to an active turn adopted after a refused send useAgentSession.test.ts › clears a pending stop when the send fails before adopting a turn ``` The first is also red on the parent (`expected false to be true` on `isStreaming`). Run locally against `origin/main` at `dd630e6c04`: - `useAgentSession` / `agentConversationStore` / `agentTranscript` / `agentRestClient` — 413 passed - the four sibling turn-lock specs that share the fixture (`agentTurnSurvivesRefresh`, `agentTurnSurvivesSocketDrop`, `agentTurnSurvivesPanelMinimize`, `agentEscapeStopsClickedTurn`) — 15 passed - `typecheck:app`, `typecheck:browser`, `oxlint`, `eslint`, `locale:check`, and the `fallow` pre-push audit gate — clean ## Production context Measured 2026-10-02 (read-only): `comfy.agent.turn_rejected{reason:in_progress}` ran at **19.9% of `agent_turn_started`** over a four-hour window, and **30.0% of threads** contained at least one ten-minute-plus window in which the next send is answered 409. That figure is dominated by the reload route this PR does *not* cover, and should fall sharply once the fix already on `cloud/1.54`/`cloud/1.55` reaches the production stable arm — re-measure before citing it as this change's justification. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
Manual backport of #18152 after the automated cherry-pick conflicted. Preserves active Agent turns across transient socket disconnects and reconciles them from persisted REST history.
Original: #18152
What this branch contains
#18152's own delta, cherry-picked onto
cloud/1.54and rebased onto22e29bc94eso the branch fast-forwards. Eight of the eleven files carry the source's added and removed lines unchanged:agentTurnLockFixture.ts, both browser specs,agentRestClient.tsand its test,agentTranscript.test.ts, andagentConversationStore.tsand its test.Adaptations, and why each one is needed
Each of these stands in for an API that exists on
mainand not on this release line.THREAD_STORAGE_KEY(the unscoped key this branch already uses) in place ofStorageKeys.agentThread();(g15)asserts that keyreportErroromitssurfaceReportErrorOptions.surfacecomes from #19230agentTranscript.tskeeps this branch's pre-#19585zPersistedToolCallSummaryhandling — the.pick(), thetoolCallId ?? idfallback, and theoksuccess alias. Only #18152's own hunks are applied, including thetoolCallPartStatedoc-comment correction, worded onto this branch's textToolCallSummaryschema change comes from #19585; on this linetool_call_idis still optionalNothing else diverges from the source:
useAgentSession.ts's andagentTranscript.ts's remaining added and removed lines are the source's, and all 22 source test additions are present with the(g3)/(g4)pins un-failed.Conflict resolution against #19734
#19734 landed on
cloud/1.54after the previous head was built, and is what the branch conflicted with.start()keeps [backport cloud/1.54] fix(agent): reopen saved workflows from chat history #19734'sinitializeWorkflowContext/{ restore }shape and takes fix(agent): keep the turn live across a socket reconnect and reconcile from REST (PM-1199) #18152's one change to it,everLive = false→connection = 'initial'.hydrateFromServer()keeps [backport cloud/1.54] fix(agent): reopen saved workflows from chat history #19734'sreadyThreadId/workflowReadyblock and takesreconcileLiveTurns()at the source's position, immediately afterconversationStore.hydrate(history).onThreadActivated, soforgetDeletedThreadnow carries the source'sonThreadActivated?.(null)rather than dropping it. That drop was a necessary adaptation against the previous merge base and is no longer one.Verification at this head
vue-tsc --noEmit: clean.vitest runoveruseAgentSession.test.ts,services/agent/, andstores/agent/: 556 passed across 21 files.oxfmt --check,oxlint --type-aware,oxlint:audit,eslint: clean.agentTurnSurvivesSocketDrop.spec.ts+agentApprovalSurvivesSocketDrop.spec.tson thecloudproject against aDISTRIBUTION=clouddev server: 10/10 passed.cloud/1.54and the specs kept, 6 of those 10 fail and the 4 socket-never-drops / normal-completion controls still pass — so the reconnect behaviour this backport carries is what the specs are measuring.