Repository navigation
[backport cloud/1.55] fix(agent): reopen saved workflows from chat history - #19732
Conversation
Selecting an Agent history chat now reopens its saved workflow when the tab is closed. History stays visible until the conversation and workflow are ready, then the selected chat becomes Current. [PM-1640](https://linear.app/comfyorg/issue/PM-1640) - Resolve saved targets through the workflow catalog and reuse known open targets to avoid redundant requests. - Reuse an already loaded Current conversation when returning from history. - Show accessible row loading and retry; preserve navigation across panel remounts and guard superseded workflow opens. - Preserve Current and its persisted session when deleting a different chat that failed to open. Missing/deleted targets, rapid selections, Back, retry, and panel remounts. Graph activation uses the existing serialized loader; cancellation guards run before activation, without adding rollback once activation starts. - Affected unit/component suites pass, covering saved-workflow reopening, cancellation, loading/retry, remounts, and Current identity (two existing expected failures retained). - Full lint, typecheck, Knip, Fallow audit, formatting, and ADR checks passed. - No new Playwright regression: deferred REST/catalog/workflow responses and panel remounts are covered by mounted Root tests using the real session and stores; workflow-service tests cover activation cancellation. These deterministic lower-level boundaries reproduce the failures without another browser fixture duplicating them. Browser/assistive-technology validation was not run at the author’s request; human UX review remains pending.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2146 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (29 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9a5ce830e1fd0a5de45d896574e7ae86acc06c39
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-01T23:42:09.756Z",
"gitSha": "817344eab4f77d6d710ef00f2624e98ad869ba6f",
"branch": "backport-18866-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.9099999999576,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.334999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.598,
"heapDeltaBytes": -5125888,
"heapUsedBytes": 61749476,
"domNodes": -257,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.289,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2002.8149999999414,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.264,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.89300000000003,
"heapDeltaBytes": 10598512,
"heapUsedBytes": 78267612,
"domNodes": -258,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.7090000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.8849999999952,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.54,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.737,
"heapDeltaBytes": -5393208,
"heapUsedBytes": 57153200,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 117.87199999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1704.8240000000305,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.081000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.614,
"heapDeltaBytes": 10202636,
"heapUsedBytes": 78061744,
"domNodes": -256,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 116.73,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.1429999999636,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.953,
"layouts": 6,
"layoutDurationMs": 0.9790000000000001,
"taskDurationMs": 263.135,
"heapDeltaBytes": 3167792,
"heapUsedBytes": 70923576,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.815000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.3719999999776,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.484000000000002,
"layouts": 6,
"layoutDurationMs": 0.966,
"taskDurationMs": 257.60699999999997,
"heapDeltaBytes": 2182056,
"heapUsedBytes": 64749596,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.507,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 561.0889999999813,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.888,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.64599999999996,
"heapDeltaBytes": 18652816,
"heapUsedBytes": 86680924,
"domNodes": 25,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 135.164,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 560.7539999999744,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.387,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.354,
"heapDeltaBytes": 18579492,
"heapUsedBytes": 86444180,
"domNodes": 25,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 132.107,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1038.5180000000105,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.3510000000001,
"heapDeltaBytes": -12329412,
"heapUsedBytes": 73890304,
"domNodes": -297,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 51.982,
"eventListeners": -217,
"totalBlockingTimeMs": 394,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1068.6729999999898,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.212,
"heapDeltaBytes": -14706092,
"heapUsedBytes": 73223360,
"domNodes": -295,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 50.04,
"eventListeners": -217,
"totalBlockingTimeMs": 394,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 763.3849999999711,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.0089999999997,
"heapDeltaBytes": 14177552,
"heapUsedBytes": 90685784,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.66699999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 783.7899999999536,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.81399999999996,
"heapDeltaBytes": 14533392,
"heapUsedBytes": 89697408,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.69799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 163,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7496.460999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6585.009999999999,
"heapDeltaBytes": 12859860,
"heapUsedBytes": 95026552,
"domNodes": -14,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 5466.47,
"eventListeners": 0,
"totalBlockingTimeMs": 53,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7444.877999999903,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.0879999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6617.633,
"heapDeltaBytes": -5990696,
"heapUsedBytes": 71096268,
"domNodes": -263,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 5283.933,
"eventListeners": -174,
"totalBlockingTimeMs": 56,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7782.609000000037,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.09699999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6926.288,
"heapDeltaBytes": 18801760,
"heapUsedBytes": 93557524,
"domNodes": -6,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 5561.541,
"eventListeners": 0,
"totalBlockingTimeMs": 148,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7282.370000000014,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.3060000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6481.5019999999995,
"heapDeltaBytes": -4906892,
"heapUsedBytes": 73484816,
"domNodes": -266,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 5147.831,
"eventListeners": -174,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2022.6999999999862,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.161999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.27,
"heapDeltaBytes": -7764628,
"heapUsedBytes": 79894040,
"domNodes": -243,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 28.666999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2026.817000000051,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.7970000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.0540000000001,
"heapDeltaBytes": -2832516,
"heapUsedBytes": 78288344,
"domNodes": -241,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 28.768,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2182.907,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.159999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1342.964,
"heapDeltaBytes": -8405588,
"heapUsedBytes": 80523912,
"domNodes": -212,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 673.5060000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2187.3339999999644,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.599000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1331.375,
"heapDeltaBytes": -11936996,
"heapUsedBytes": 76409548,
"domNodes": -217,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 666.67,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3199.6940000000222,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.860000000000003,
"layouts": 60,
"layoutDurationMs": 12.972,
"taskDurationMs": 1350.3229999999999,
"heapDeltaBytes": 7813160,
"heapUsedBytes": 73890004,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 639.149,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3266.368000000057,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.839,
"layouts": 60,
"layoutDurationMs": 13.023,
"taskDurationMs": 1412.423,
"heapDeltaBytes": -5903560,
"heapUsedBytes": 78027372,
"domNodes": -259,
"jsHeapTotalBytes": 5795840,
"scriptDurationMs": 644.789,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2325.7489999999734,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.716999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1522.28,
"heapDeltaBytes": 18026508,
"heapUsedBytes": 84025220,
"domNodes": 10,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 771.578,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2212.8639999999677,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.402999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1421.018,
"heapDeltaBytes": -9913100,
"heapUsedBytes": 75260324,
"domNodes": 16,
"jsHeapTotalBytes": 5804032,
"scriptDurationMs": 778.553,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2067.1439999999848,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.700999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.049,
"heapDeltaBytes": -9929368,
"heapUsedBytes": 78783080,
"domNodes": -256,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 30.675,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.6610000000892,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.9910000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.58600000000007,
"heapDeltaBytes": -8999656,
"heapUsedBytes": 80118968,
"domNodes": -243,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 29.335000000000008,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 510.4989999999816,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.056000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.973,
"heapDeltaBytes": 13665492,
"heapUsedBytes": 83798212,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 114.341,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 461.687999999981,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.605,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.835,
"heapDeltaBytes": 13635028,
"heapUsedBytes": 83779684,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 121.07699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2019.6730000000116,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.299,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.188,
"heapDeltaBytes": -14394920,
"heapUsedBytes": 55544036,
"domNodes": -272,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.026999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1987.9700000000184,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.186,
"heapDeltaBytes": 9513832,
"heapUsedBytes": 79297112,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.174000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.6369999999765,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.59,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.521,
"heapDeltaBytes": 5891928,
"heapUsedBytes": 75870568,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 80.86900000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1668.7789999999723,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.745,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.034,
"heapDeltaBytes": -9756452,
"heapUsedBytes": 60431028,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 77.768,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 866.7550000000119,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.266000000000002,
"layouts": 5,
"layoutDurationMs": 9.735,
"taskDurationMs": 682.8460000000001,
"heapDeltaBytes": 20204852,
"heapUsedBytes": 103296552,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 21.713000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 90,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8230.005000000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.514,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4607.157000000001,
"heapDeltaBytes": -18733080,
"heapUsedBytes": 68782844,
"domNodes": -220,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 2228.466,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8213.141999999949,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.839999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4601.1939999999995,
"heapDeltaBytes": -20446216,
"heapUsedBytes": 67006972,
"domNodes": -211,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 2230.898,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14061.80500000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13821.224,
"heapDeltaBytes": -42668168,
"heapUsedBytes": 194625220,
"domNodes": -8063,
"jsHeapTotalBytes": -10596352,
"scriptDurationMs": 199.49500000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13950.11999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13669.579000000002,
"heapDeltaBytes": -49828288,
"heapUsedBytes": 165649852,
"domNodes": -8062,
"jsHeapTotalBytes": -12115968,
"scriptDurationMs": 197.152,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17057.875999999964,
"styleRecalcs": 129,
"styleRecalcDurationMs": 13.572000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16721.262000000002,
"heapDeltaBytes": -36228484,
"heapUsedBytes": 179052044,
"domNodes": -8062,
"jsHeapTotalBytes": -13426688,
"scriptDurationMs": 696.346,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16841.925999999945,
"styleRecalcs": 112,
"styleRecalcDurationMs": 13.897999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16593.016,
"heapDeltaBytes": -31312968,
"heapUsedBytes": 189617472,
"domNodes": -8066,
"jsHeapTotalBytes": -21434368,
"scriptDurationMs": 695.76,
"eventListeners": -14928,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5184.7380000000385,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.95599999999998,
"layouts": 20,
"layoutDurationMs": 22.24899999999999,
"taskDurationMs": 5105.799,
"heapDeltaBytes": -53950528,
"heapUsedBytes": 183762428,
"domNodes": -8062,
"jsHeapTotalBytes": 17715200,
"scriptDurationMs": 81.919,
"eventListeners": -14928,
"totalBlockingTimeMs": 286,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5189.975000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.782000000000004,
"layouts": 20,
"layoutDurationMs": 21.192000000000004,
"taskDurationMs": 5130.950000000001,
"heapDeltaBytes": -52665908,
"heapUsedBytes": 184767960,
"domNodes": -6546,
"jsHeapTotalBytes": 18763776,
"scriptDurationMs": 82.562,
"eventListeners": -14928,
"totalBlockingTimeMs": 179,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7059.3750000000455,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6877.616000000002,
"heapDeltaBytes": 20883160,
"heapUsedBytes": 184759400,
"domNodes": 0,
"jsHeapTotalBytes": -24117248,
"scriptDurationMs": 100.98800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7202.2269999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7140.217999999999,
"heapDeltaBytes": -10449780,
"heapUsedBytes": 171853840,
"domNodes": -1,
"jsHeapTotalBytes": -9961472,
"scriptDurationMs": 100.47600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 420.6169999999929,
"styleRecalcs": 16,
"styleRecalcDurationMs": 20.066,
"layouts": 4,
"layoutDurationMs": 1.873,
"taskDurationMs": 102.81899999999999,
"heapDeltaBytes": 5069244,
"heapUsedBytes": 70851576,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.168,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 94.21399999996538,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.424999999999999,
"layouts": 4,
"layoutDurationMs": 1.5650000000000002,
"taskDurationMs": 66.09500000000001,
"heapDeltaBytes": 3049848,
"heapUsedBytes": 68910972,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.352000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
|
Reduce the counted diff or split the PR, then re-apply the |
|
Drafting while the release dependency chain is reconciled. The source snapshot depends on APIs not present on this release line (including the Agent telemetry/storage contract from #18665 and #18978); CI correctly caught the missing contracts. This carrier will not be marked ready until those prerequisites are either safely backported or the change is adapted without them. |
Restore the release-compatible agent session and test implementations while preserving the history-reopen behavior from #18866.
…-18866-to-cloud-1.55 # Conflicts: # src/workbench/extensions/agent/composables/agent/useAgentSession.ts
## Summary Consolidates the verified fixes that landed on `cloud/1.54` but were absent from `cloud/1.55`: - #17486 keeps promoted dynamic-combo child links when loading workflows. - #18599 gives unified-remint retries a fresh timeout window. - #18093 allows nodes to shrink after content growth and tab switches. - #18155 resolves stale Agent bindings when workflows share a name. - #18693 keeps the Agent target aligned with the visible workflow until send or node reference. - #18619 waits for open dialogs before showing Agent consent. - #18061 deselects a node when its composer reference is removed. - #18392 marks video reply assets correctly. - #18664 records Agent panel visibility and page-hide teardown correctly. - #18911 restores Agent onboarding focus, navigation, and replay behavior. - #18911 remains deliberately excluded: its activation-telemetry substrate is cloud/1.54-only, and the original backport records that scope. This is the consolidated `cloud/1.55` carrier from the 1.54→1.55 release audit. The already-open saved-workflow backport remains in #19732 and is intentionally not duplicated here. ## Validation - Release-branch conflicts were resolved against the current cloud/1.55 Agent targeting, consent, and onboarding implementations. - CI is the authoritative full suite. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com> Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
The carrier had resolved its conflicts by taking main's copy of the shared files wholesale, which carried main-only context that does not exist on this release line: workspace-scoped agent storage keys (StorageKeys.agentThread / agentWorkflowTabBindings, clearLegacyAgentStorage), api.serverFeatureFlagsSettled / flagsSettled, the deferred pendingSend / reportPendingSend send-reporting path, a duplicate trackWorkflowOpenFailure, and 96 ADR index rows for ADRs absent here. That is what made the whole tree fail to build. Re-derived instead: take cloud/1.55's content for every shared file and re-apply only #18866's own delta on top, adapted to this branch's idioms - THREAD_STORAGE_KEY for the thread key, `connection` rather than `everLive`, the module-level workflowService helper, and reconcileLiveTurns() kept in hydrateFromServer. docs/adr/README.md now gains exactly the one AGENT-HISTORY-0038 row. The two large test files had diverged too far for hunk application, so they were merged whole-file against #18866's parent: AgentPanelRoot.test.ts by diff3, and AgentPanel.test.ts by adding the five history-selection tests #18866 introduces plus its mountHistory helper, since this branch deliberately carries a trimmed suite. Verified: the merged tree is cloud/1.55 plus exactly #18866's 25-file delta, 21 of those files matching the upstream delta line-for-line.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19732 +/- ##
=============================================
Coverage ? 84.90%
=============================================
Files ? 2318
Lines ? 132667
Branches ? 33597
=============================================
Hits ? 112640
Misses ? 19666
Partials ? 361
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Review under the 1.54/1.55 Agent backport grant — COMMENT, not an approval.
I am the pushing identity on this carrier, so GitHub cannot accept a self-approval and none was manufactured. program/release-backport-authority.md authorizes the carrying worker to review and merge these backports once its own gates pass, and states that REVIEW_REQUIRED alone is not a further human-approval requirement; unresolved human objections would still block, and there are none.
What I actually checked, rather than re-running CI and calling it a review:
- The conflict resolution, which was the defect. The prior resolution took
main's copy of the shared files wholesale, importingmain-only APIs that do not exist oncloud/1.55— that is whysetupandlintwere red together. Re-derived fromcloud/1.55's content plus only #18866's own delta. - That the result is the target plus exactly this carrier's delta. The 25-file set is identical to upstream
8f8e863efd's (commempty both ways), 21 files matching its per-file line counts exactly; the four that differ are the files this release line had diverged.docs/adr/README.mdis +1, not +97. - That no assertion was weakened to make anything pass. The adaptations are name-level (
THREAD_STORAGE_KEY,connection,workflowService) plus imports the branch lacked.AgentPanel.test.tsgained the five history-selection tests #18866 adds and nothing else; no recording was hand-edited. - That production behaviour is unchanged. The delta is tests, fixtures, test adaptation and one ADR index row.
Gates at 3dff667966737b547612cfbaeb6916081a165787: typecheck:app, typecheck:browser, format:check, knip, adr:check clean; lint 0 errors (198 pre-existing warnings); locale:check exit 0; fallow audit --changed-since HEAD^1 pass; pnpm test:unit 1691 files / 24078 passed, 13 expected-fail, 7 skipped. Hosted: 90 pass, 0 fail, 15 skipping — against the 13-check adverse cluster before. check-merge-ready.sh … --target-branch cloud/1.55 printed MERGE READY (104 checks, success/neutral/skipped only, zero unresolved threads).
Merged, not rebased, so 9372d5061e stays an ancestor and the earlier review history remains readable. Derivation: reports/jobs/op256-fe19732-stackrepair.md.
#19732 squash-landed as e9a89db, so this carrier's base branch is gone and GitHub retargeted it to cloud/1.55. That left it CONFLICTING: the merge base falls back to 9a5ce83, before the squash, so git tried to re-merge #18866's content against the copy this branch already carries. Resolving that merge directly produced real damage - a duplicated markWorkflowTargetUnavailable and a mangled TargetTracking union. Re-derived instead, on the proof that e9a89db's tree is byte-identical to the reviewed 3dff667 (both f622a76): take the landed tip's content wholesale and apply exactly #19240's delta on top, with the same two release-line adaptations as before - agentPanel.root in place of the Promise<Locator> return main's AgentPanel.open() has, and the targetTracking export main has carried since #18693. The tree is therefore cloud/1.55 plus exactly #19240's 6-file delta, matching the upstream 2595efc file set.
Manual backport of #18866 after the automated cherry-pick failed. This restores saved target workflows when reopening Agent chat history and carries the source unit and browser coverage.
Original: #18866
Repair, 2026-10-01
The branch had resolved its conflicts by taking
main's copy of the shared files wholesale, which carriedmain-only context that does not exist oncloud/1.55. That is why the whole tree failed to build (setupandlintred together, 13 adverse checks): workspace-scoped agent storage keys (StorageKeys.agentThread/agentWorkflowTabBindings,clearLegacyAgentStorage),api.serverFeatureFlagsSettled/flagsSettled, the deferredpendingSend/reportPendingSendsend-reporting path (whosereportPendingSendhad no call site and whoseAgentMessageSentMetadatawas not imported), a duplicatetrackWorkflowOpenFailure,vuefire,./crdt/mintPortWiring, thecanvasStore.updateSelectedItemsshape, and 96 ADR index rows for ADRs absent here.Re-derived instead: take
cloud/1.55's content for every shared file and re-apply only #18866's own delta on top, adapted to this branch's idioms —THREAD_STORAGE_KEY,connectionrather thaneverLive, the module-levelworkflowServicehelper, andreconcileLiveTurns()kept inhydrateFromServer.docs/adr/README.mdnow gains exactly the oneAGENT-HISTORY-0038row rather than 97.The two large test files had diverged too far for hunk application and were merged whole-file against #18866's parent:
AgentPanelRoot.test.tsby diff3, andAgentPanel.test.tsby adding the five history-selection tests #18866 introduces plus itsmountHistoryhelper, since this branch deliberately carries a trimmed suite. No assertion was weakened and no recording hand-edited.Verified:
git diff origin/cloud/1.55 HEADis 25 files / +3050-329, and that file set is identical to upstream8f8e863efd's, with 21 of the 25 matching its per-file line counts exactly. The four that differ are precisely the files where this release line had diverged.Local gates at this head:
typecheck:app,typecheck:browser,format:check,knip,adr:checkclean;lint0 errors;locale:checkexit 0;fallow audit --changed-since HEAD^1pass;pnpm test:unit1691 files, 24078 passed, 13 expected-fail, 7 skipped.Merged as a release-branch carrier, not rebased —
9372d5061eremains an ancestor, so the earlier review history stays readable.Justification: Agent release backport to
cloud/1.55merged under the standing 1.54/1.55 backport grant recorded inprogram/release-backport-authority.md(Christian, 2026-09-16, extended 2026-09-27 to cover both release lines), which authorizes the carrying worker to review and merge these backports once its own gates pass and states thatREVIEW_REQUIREDalone is not a further human-approval requirement. I am the pushing identity on this carrier, so GitHub cannot accept a self-approval; an honestCOMMENTreview carries the evidence instead and no approval record was manufactured. Gate:scripts/check-merge-ready.sh Comfy-Org/ComfyUI_frontend 19732 --target-branch cloud/1.55printed MERGE READY at head3dff667966737b547612cfbaeb6916081a165787with 104 checks completed, success/neutral/skipped only, and zero unresolved threads or reviewer objections. Production behaviour is unchanged relative to the approved parent #18866 (8f8e863efd); the delta is tests, fixtures, test adaptation and one ADR index row. Derivation:reports/jobs/op256-fe19732-stackrepair.md.