Repository navigation
[backport cloud/1.55] Complete 1.54 parity sweep - #19790
Conversation
…58) (#17486) *PR Created by the Glary-Bot Agent* --- Fixes the `scale_multiplier` widget on the `utility_seedvr2_3b_int8_upscale_image` template rendering as a disconnected input slot, with a duplicate `resize_type.multiplier_1` appended below it. Reproduces on current `main`; neither #16717 nor its backport #16751 touched the failing path. - Fixes FE-258 ## Root cause A node is constructed with its dynamic combo's **default** option laid out (`resize_type.width/height/crop`), and `ComfyNode.configure` rewrites `data.inputs` into that definition order, appending the serialized inputs the definition lacks. Serialized `target_slot` values count the **saved** layout, so link `50` — saved on `resize_type.multiplier` at slot 1 — lands on slot 1 of the rebuilt layout, which is a different input. Applying the combo's serialized value then tears the group down and hands each surviving link to the new input of the same name. The link is sitting on `resize_type.width`, which the selected option does not define, so it is dropped. Across a subgraph boundary the promoted input is demoted to a bare slot and a duplicate `_1` promotion is auto-created. ## Fix Realign the node's input links by name in `LGraphNode.configure`, after slots are wired and before widget values are applied — the window in which the correct slot exists. Scoped to nodes that have a group widget child input; `LGraph.configure`'s existing pass still runs for everything else once all nodes are configured. The node's ordinary inputs join the batch so a link still occupying a child's destination slot moves in the same atomic update instead of blocking it. Inputs owned by a group that is not a widget (autogrow) stay out because their slots grow and renumber during configure. ## Verification - `pnpm test:unit src/lib/litegraph/src/LGraph.inputSlotRealign.test.ts`: 21 passed. - `pnpm test:browser:local browser_tests/tests/subgraph/subgraphPromotedDynamicComboChild.spec.ts`: 2 passed after the development server warmed up. The first cold-start run timed out before the app became ready; its second test passed. - `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm lint`, `pnpm format:check`, and `pnpm knip` passed. ## Unverified residuals - An excluded autogrow link can block the early batch and produce a `Failed to realign input link slots` log. This PR does not include a complete-config base/head test for the final topology in that case. - A nested dynamic combo under a non-default outer option is excluded because its widget does not exist at this point in configure. Base/head parity for that case was not reverified in this review round. ## Screenshots   --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> (cherry picked from commit 3f29ced) (cherry picked from commit 3ebfb0c)
The automatic "Meet Comfy Agent" card opened on top of whatever dialog was already up, including the desktop sign-in approval, so people had to dismiss it before they could approve. It now waits until no dialog is open and shows in the same visit. - **What**: - The automatic consent offer holds while any dialog from the dialog store is open (desktop sign-in approval, sign-in, invite links, errors, the startup template browser) and offers once the last one closes. - It retries once, and only when an offer was actually held, so ordinary dialog closes don't re-read consent. - Once someone has seen the card this visit, from the Agent button or on its own, the automatic offer is done until the next visit. Skipping a card opened from the button no longer brings it straight back. - The Agent button is unchanged and still opens the card right away. - The hold reads `dialogStack.length`, the rule the first-run nudge already uses, not `isModalOpen`. `isModalOpen` also sees modals outside the store, which the retry can't see close, so hold and release would disagree. The trade-off: a lightbox open at the exact moment of the offer won't hold it. - The startup template browser now comes first and the card waits for it to close. That was a product call and it's agreed. - `CONSENT_DIALOG_KEY` is exported from `useAgentConsent` so the extension can tell when the card itself is open. - Unit, `agentPanel.test.ts`: hold, same-session release, a dialog opening mid-offer, a tour ending while a dialog is still open, manual Skip not re-popping, the card seen this visit, and a failing consent read not retried on every dialog close. These fail against the old code. - E2E, `agentConsent.spec.ts` (cloud): boots on a desktop sign-in link; the approval is on top and clickable, and the card appears only after approving. Red 5/5 on the old bundle, green 5/5 on the fix. - Mutation testing on the changed lines: 6/6 killed. - Fixes FE-2808 (cherry picked from commit c10ba49) (cherry picked from commit 87366ab)
<!-- ccr-slack-attribution --> _Requested via [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1790161872557349)_ ## Summary Fixes the pattern behind Sentry `CLOUD-FRONTEND-STAGING-4MF`/`4MG`: the unified-remint retry fetch could spuriously time out under staging load because it inherited whatever was left of the original request's 60s deadline instead of getting a full one. ## Changes - **What**: `fetchApi()` (`src/scripts/api.ts`) armed a single 60s `AbortSignal` and passed it straight through to `fetchWithUnifiedRemint()`. On a 401, that function re-mints the unified Cloud JWT (`tryRemintToken` → `workspaceAuthStore.remintUnifiedOnce()` → `unifiedUser()` → `unifiedSessionClient.remint()` → `exchangeToken()`, each step with its own independent ~15s ceiling) before retrying the original request — but the retry reused the *same* original signal, so its effective budget was `60s minus whatever the re-mint round trip already spent`, not a fresh 60s. Under load, a slower-than-usual re-mint could leave the retry only a few seconds before it was aborted with `TimeoutError: Fetch timeout`, even though every individual step was within its own budget. `fetchWithUnifiedRemint()` (`src/platform/auth/unified/remintRetry.ts`) now takes an optional 4th parameter, `freshRetrySignal?: () => AbortSignal | undefined`, called only if a retry actually happens; its return value replaces the original `init.signal` on the retry `fetch`. `fetchApi()` passes a callback that mints a new `AbortController` + `setTimeout` (same duration, same `DOMException('Fetch timeout', 'TimeoutError')` construction as the existing timeout, so Sentry grouping stays consistent) combined with the caller's own `signal` via `AbortSignal.any`, and cleans up the new timer in the existing `.finally()`. `fetchWithUnifiedRemint()` has two other call sites (`globalSettingsApi.ts`, `authStore.ts`) that pass no signal at all today; the new parameter is optional and defaults to `undefined`, which keeps their behavior byte-for-byte unchanged (they can't produce this `TimeoutError` in the first place — only a benign `TypeError: Failed to fetch`). - **Breaking**: none - **Dependencies**: none ## How - `remintRetry.ts`: build the retry `fetch`'s `init` from `freshRetrySignal()` when supplied, instead of always spreading the original `init` (which carried the shrunk signal). - `api.ts`: `freshRetrySignal` is only constructed when `timeout` is non-null (i.e. `timeoutMs` wasn't explicitly disabled), and only actually invoked by `fetchWithUnifiedRemint` if a 401 retry happens — a request that never gets a 401 pays no extra cost. ## Review Focus - `src/scripts/api.ts`, `fetchApi()`: the new `freshRetrySignal` closure and its timer's cleanup in `.finally()` (no leaked timers on either the happy path or an error path). - `src/platform/auth/unified/remintRetry.ts`, `fetchWithUnifiedRemint()`: the retry `init` construction now branches on whether `freshRetrySignal` was supplied. - Confirmed the two other callers (`globalSettingsApi.ts`, `authStore.ts`) are unaffected — they don't pass a signal today, and the new parameter is optional and off by default. ## Tests - `src/platform/auth/unified/remintRetry.test.ts`: new cases assert the retry `fetch` receives the object returned by `freshRetrySignal()` (not the original `init.signal`) when supplied, and that the callback is never called when no retry happens. - `src/scripts/api.fetchApi.test.ts`: new regression test with fake timers simulates a 401 → 55s re-mint → 30s retry sequence. Verified (via `git stash` of only the source changes, keeping the new tests) that both new tests fail against the pre-fix code — the retry test rejects with the abort from the stale signal at t=60s — and pass once the fix is restored. Fixes the pattern behind Sentry `CLOUD-FRONTEND-STAGING-4MF`/`CLOUD-FRONTEND-STAGING-4MG`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY --- _Generated by [Claude Code](https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY)_ --------- Co-authored-by: dante01yoon <bunggl@naver.com> (cherry picked from commit e346ef9) (cherry picked from commit 4c0e45e)
## Summary Reject stale Agent workflow bindings when the target ID has a duplicated cloud name instead of resolving the unrelated saved tab and graph. ## Changes - **What**: Resolve ID-to-name identity from the full cloud index while retaining the duplicate-filtered name-to-ID inference map. Add fresh-store regressions for both resolver entry points and a browser scenario with duplicate target IDs plus a uniquely named saved `Portrait` tab. - **Dependencies**: None. ## Review Focus The lookup is intentionally asymmetric: duplicated names remain unsafe for name-to-ID inference, while an exact target ID can still retrieve its indexed name for stale-binding rejection. This is separate from the refresh-cache work in #17509 and does not modify that branch. Focused Vitest is red on `origin/main` (both entry points select `Portrait`) and green here (14/14). ESLint, formatting, full `pnpm typecheck`, browser typecheck, and the push-time `knip` gate pass. The new Playwright case is checked in but runtime proof is blocked on this worker: both it and the unchanged `agentWorkflowSelection` smoke case time out before assertions because the Agent entry button is absent on the local current-main surface. No live model call was made. ## Screenshots (if applicable) The browser run produced traces/video for the pre-assertion harness blocker; no passing screenshot is claimed. (cherry picked from commit e5a6ab0) (cherry picked from commit 15ce2ee)
…8693) Internal testers reported friction from having to choose a target workflow before chatting. This PR selects the visible workflow automatically and makes the target behavior clear: - Fresh chats follow tab changes, keeping the typed draft, until a successful manual target selection, a node reference, or Send. Workflow references alone do not stop following. - These actions retain the target; Send does so even if the request fails. Users can still change targets explicitly. - New Chat resumes following unless the carried draft contains node references; those keep their original target. Reopened conversations retain their target. - The existing composer tip explains following or a visible/target mismatch. **Show target** opens the target without changing it. (cherry picked from commit facbca7) (cherry picked from commit 67fedce)
… (PM-1227) (#18061) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789585023130639?thread_ts=1789585023.130639&cid=C0BGH348Z0C)_ ## Summary Removing a node's reference chip from the agent composer left the node highlighted on canvas. This fixes that, and adds the e2e regression test that covers it. **This PR carries the fix, not just a repro.** It started as a `test.fail()`-pinned repro; commits `3564898d6`, `fab0b2c13` and `d0af7f19f9` added the fix, removed the pin, and moved the spec to asserting the corrected behaviour. The title and this body have been corrected to match — earlier revisions described it as test-only. ## Changes - **What**: - `src/workbench/extensions/agent/AgentPanelRoot.vue` (+6) — `onRemoveSelectionTag` now resolves the node the chip refers to out of the current canvas selection and deselects it after removing the chip. - `browser_tests/tests/agent/agentNodeSelectionChipRemoval.spec.ts` (+65) — black-box regression spec. Enters agent node-selection mode, captures the unselected canvas, stages a node as a composer chip, removes the chip, and waits for the rendered canvas to return to its unselected pixels. - `browser_tests/fixtures/helpers/CanvasHelper.ts` (+25) — owns the shared canvas-view readiness check used by this spec and the composer placeholder regression spec. - **Breaking**: none - **Dependencies**: none ## Root cause `onRemoveSelectionTag` in `AgentPanelRoot.vue` called `removeSelectionTag(id)` and nothing else. That `remove()` (from `useCanvasSelection`) only filters the composer's local `staged` list; it has no canvas dependency, so the node's LiteGraph selection survived. The only other deselect on that surface is in `exitNodeSelectionMode()`, which runs when leaving node-selection mode entirely — never on a single chip removal. **Before**: selecting a node on canvas while in agent node-selection mode adds a reference chip and highlights the node. Removing that chip clears the chip but leaves the node highlighted. **After**: removing the chip also deselects the node, and the highlight clears. The fix is at the panel rather than inside `remove()` deliberately: `useCanvasSelection.ts` imports only `vue` and a type, and the composable is generic over staged selections. Pushing `canvas.deselect` into it would give it a canvas dependency it does not currently have. ## Review Focus - **The deselect goes through the canonical API**, not a direct store mutation: `canvas.deselect(node)` → `setCanvasItemSelected(..., false)` → the selection store that `canvasStore.selectedItems` is computed from. Commit `d0af7f19f9` is what moved it onto that API; an earlier revision used `canvas.deselectAll()` / `canvasStore.updateSelectedItems()` and those are gone. - **This is the only call site.** `removeSelectionTag` is referenced exactly three times in `src/`, all in `AgentPanelRoot.vue` — the destructure, this function, and the `@remove-tag` binding. There is no second path that can leave a node lit. - **Ordering** (`removeSelectionTag` before `deselect`) through `useCanvasSelection`'s `flush: 'sync'` watcher: single-chip — `remove()` empties `staged` and latches `dismissedSig`, then the deselect fires the watcher with an empty selection, clearing `dismissedSig` again. Multi-chip — the watcher re-stages the remaining nodes from the new selection. Consistent in both. - The spec reuses existing agent e2e infra (`agentTest`/`agentPanel` from `browser_tests/tests/agent/agentPanelMocks.ts`, plus `comfyPage.nodeOps`/`NodeReference`) and the shared `CanvasHelper` readiness check rather than adding spec-local fixtures or polling. **Verification note.** CI ran the original state-based spec green in `playwright-tests (cloud, frontend-dist-cloud)`; 91/91 checks were green at `d0af7f19f9`. The revised rendered-canvas assertion was verified red by temporarily removing `canvas.deselect(node)`, then green after restoring it. The focused cloud run and the neighboring composer placeholder spec both pass locally at `24025ec535`. ## Screenshots (if applicable) N/A (no visual change beyond the highlight clearing) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_014TL6Z2fYevRQcChLMRy6Pk --- _Generated by [Claude Code](https://claude.ai/code/session_014TL6Z2fYevRQcChLMRy6Pk)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit e968f00) (cherry picked from commit c32dd29)
## Summary - add a persistent play badge to generated video reply tiles - leave image and 3D reply tiles unmarked - preserve hover playback and gallery inspection behavior Linear: PM-1306, PM-1315 ## Testing - `pnpm vitest run src/workbench/extensions/agent/components/agent/message/ReplyAssetGroup.test.ts` (15 passed) - ESLint and formatting on changed files - `pnpm typecheck` - pre-commit and pre-push checks Justification: The author completed a focused self-review after the PR waited five days without human review; the change is a 33-line visual affordance limited to video tiles, covered by focused component tests and fully green CI. (cherry picked from commit fef4b2b) (cherry picked from commit 8d105fd)
…8093) ## Summary - Let an explicit node resize override a stale content-size measurement so an auto-grown Flux2ImageNode can shrink again. - Preserve ResizeObserver measurements across hidden/visible tab transitions; genuinely changed nodes re-report, unchanged siblings do not. - Convert the existing PM-1304 / PM-1312 expected-failure unit, observer, and real-browser regressions into passing assertions. Linear: PM-1304, PM-1312 ## Test plan - `pnpm exec vitest run src/renderer/core/layout/operations/graphLayoutAttachment.test.ts src/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.test.ts` (18 passed) - Full app and browser typechecks via pre-commit - ESLint, oxlint, and oxfmt via pre-commit - CI runs the two real Flux2ImageNode Playwright cases against cloud Justification: confirmed fix for the two linked resize regressions, with red-before/green-after coverage already present on this PR. --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit 0e8b66a) (cherry picked from commit d6de74a)
…18664) Makes panel-open time measurable: fires a `pagehide`-sourced close event when the agent panel is open on tab close/reload (G2), and adds an `agent_panel_open` flag to the existing page-visibility event as the denominator for panel-open share (G3). - **What**: - G2: `agentPanelStore` reports `app:agent_panel_closed` with `source: 'pagehide'` from a `pagehide` listener, without touching the persisted `isOpen`/localStorage state (preserves the FE-1284/PM-648 reload-restore behavior). A per-epoch flag dedupes repeated `pagehide` firing (e.g. bfcache freeze) so one open session yields one duration; a `pageshow` listener with `event.persisted` restarts the interval on bfcache resume so a later close only measures time since resume, rather than double-counting the already-reported span. PostHog sends this specific event via `sendBeacon` + `send_instantly`, since a normal batched `capture()` can be dropped once the tab is gone. - G3: adds `agent_panel_open: boolean` to `PageVisibilityMetadata`, read from the existing `agentPanelStore.isVisible` and wired into `GraphView.vue`'s existing `visibilitychange` listener via a small pure helper (`getPageVisibilityMetadata`). Extends GTM's explicit field mapping for parity — Mixpanel, PostHog, and the Host sink already forward the whole metadata object. - **Breaking**: none - `agentPanelStore.ts`'s `pagehide`/`pageshow` handling — verifies against a design validation pass that flagged G2 as non-trivial (see PM-1475 comments). Passed an internal `review_run` (one substantive medium-severity finding on the bfcache-resume interval reset, fixed and re-reviewed clean). - `PAGE_VISIBILITY_CHANGED` stays in PostHog's/Mixpanel's default-disabled-event list; whether the deployed `/features.telemetry_disabled_events` override actually enables it in prod is an operational check, not something this diff changes. - Fixes PM-1475 (cherry picked from commit 293a17f)
…and replay (#18911) (#19045) Backport of #18911 to `cloud/1.54`. Cherry-picked cleanly — no conflicts, no manual resolution. **This is the only branch #18911 can go to.** The automated run also tried `core/1.54`, `core/1.55` and `cloud/1.55`, and all three conflicted on `AgentPanelRoot.vue`, `OnboardingCoach.vue` and `OnboardingCoach.test.ts`. The cause is not a merge accident: those branches lack the onboarding telemetry this change builds on — no `trackAgentOnboardingStep`, no `AgentOnboardingAction`, and no `previous` on `useOnboarding`. That substrate came from #18503 ("complete the agent activation funnel", PM-1474), which was labelled **`cloud/1.54` only** — deliberately, by its author. It is 934 insertions across 23 files touching the telemetry registry, both providers and the composer store. Carrying it into three more release branches to land a UX refinement would be well out of proportion for a patch release, and would override a scoping decision someone already made on purpose. The alternative — backporting #18911 with its telemetry calls stripped — would leave three bespoke variants of `OnboardingCoach` across release branches. Not worth it. So the other three labels are being removed from #18911 rather than left to fail silently. Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit 31f142b)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2144 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (61 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ba8eb99f43d5205889dd0756a49f02882aa12d0b
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-01T19:55:53.936Z",
"gitSha": "0f91ebd55caf9a1b2f64229e346997db5ed03c57",
"branch": "christian/complete-cloud-1.55-backports",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.5229999999683,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.79,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.18300000000005,
"heapDeltaBytes": 7870452,
"heapUsedBytes": 75541240,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.453999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2000.2960000000485,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.136,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.571,
"heapDeltaBytes": -8012596,
"heapUsedBytes": 54490100,
"domNodes": 21,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.404000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1744.164000000012,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.346999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 727.336,
"heapDeltaBytes": -6223720,
"heapUsedBytes": 61468300,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 127.45600000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.1909999999853,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.343,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 679.056,
"heapDeltaBytes": -2727924,
"heapUsedBytes": 65135784,
"domNodes": -258,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 119.71500000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.0759999999623,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.44,
"layouts": 6,
"layoutDurationMs": 1.2240000000000002,
"taskDurationMs": 282.58299999999997,
"heapDeltaBytes": 3123772,
"heapUsedBytes": 70921712,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.99,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.3879999999663,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.879000000000003,
"layouts": 6,
"layoutDurationMs": 1.089,
"taskDurationMs": 293.41200000000003,
"heapDeltaBytes": 3106984,
"heapUsedBytes": 70830316,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.761000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 550.7109999999784,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.508,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.84200000000004,
"heapDeltaBytes": 18892800,
"heapUsedBytes": 86753336,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.64,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 544.5250000000215,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.893999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.536,
"heapDeltaBytes": 17955032,
"heapUsedBytes": 80519956,
"domNodes": 23,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.30299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1022.1559999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 685.132,
"heapDeltaBytes": 39530436,
"heapUsedBytes": 106992484,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 57.518,
"eventListeners": 0,
"totalBlockingTimeMs": 402,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1065.8180000000357,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 719.0409999999999,
"heapDeltaBytes": -18060852,
"heapUsedBytes": 72883492,
"domNodes": -293,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 56.343999999999994,
"eventListeners": -217,
"totalBlockingTimeMs": 415,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 764.5140000000197,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.3470000000003,
"heapDeltaBytes": 14716592,
"heapUsedBytes": 91576672,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.252,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 767.6089999999931,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.1669999999999,
"heapDeltaBytes": 14762936,
"heapUsedBytes": 90583260,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.27600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7753.0590000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6799.193,
"heapDeltaBytes": -333144,
"heapUsedBytes": 81707024,
"domNodes": -16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 5553.909,
"eventListeners": 0,
"totalBlockingTimeMs": 45,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8617.815999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7686.995,
"heapDeltaBytes": 11610240,
"heapUsedBytes": 75933020,
"domNodes": -272,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 6253.549999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 51,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7827.1519999999555,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6935.53,
"heapDeltaBytes": -13784792,
"heapUsedBytes": 68519724,
"domNodes": -16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 5509.794999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 132,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 33.19999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7745.1939999999695,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.8900000000000019,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6948.876,
"heapDeltaBytes": 2999844,
"heapUsedBytes": 79890232,
"domNodes": -272,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 5495.637000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 66,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2026.4970000000062,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.0230000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.694,
"heapDeltaBytes": -3316988,
"heapUsedBytes": 83562500,
"domNodes": -234,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 33.695,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2042.1830000000227,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.6829999999999,
"heapDeltaBytes": -4378084,
"heapUsedBytes": 83358572,
"domNodes": -240,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 33.668000000000006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2169.230999999968,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.862000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1407.993,
"heapDeltaBytes": 15630100,
"heapUsedBytes": 80183636,
"domNodes": 10,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 706.5049999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2148.6509999999726,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.149999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1332.797,
"heapDeltaBytes": 16119676,
"heapUsedBytes": 80300624,
"domNodes": -241,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 664.8799999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3343.279999999993,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.722000000000001,
"layouts": 60,
"layoutDurationMs": 13.879000000000001,
"taskDurationMs": 1512.251,
"heapDeltaBytes": 8114416,
"heapUsedBytes": 74073844,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 676.588,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3303.47299999994,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.147,
"layouts": 60,
"layoutDurationMs": 13.555000000000001,
"taskDurationMs": 1540.384,
"heapDeltaBytes": -16062432,
"heapUsedBytes": 74214356,
"domNodes": -252,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 681.015,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2604.608999999982,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.152999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1797.768,
"heapDeltaBytes": -16392768,
"heapUsedBytes": 74959240,
"domNodes": -222,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 855.292,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2465.759000000048,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.728,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1580.5259999999998,
"heapDeltaBytes": -17290548,
"heapUsedBytes": 74198188,
"domNodes": -222,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 847.899,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1999.1639999999506,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.3310000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.7540000000001,
"heapDeltaBytes": 19772148,
"heapUsedBytes": 84924020,
"domNodes": 12,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.78099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1994.12499999994,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.7159999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.343,
"heapDeltaBytes": 20123596,
"heapUsedBytes": 84934588,
"domNodes": 12,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.207,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 527.2560000000226,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.790999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.60100000000006,
"heapDeltaBytes": 13661820,
"heapUsedBytes": 83960088,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 120.48100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 515.38400000004,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.382000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.385,
"heapDeltaBytes": 14099016,
"heapUsedBytes": 84121580,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 121.24499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2004.6859999999924,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.633999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.483,
"heapDeltaBytes": -5806244,
"heapUsedBytes": 64196624,
"domNodes": -272,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.085,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.5430000000079,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.27599999999995,
"heapDeltaBytes": -7362632,
"heapUsedBytes": 62965500,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.924,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.130000000001,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.474,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.081,
"heapDeltaBytes": 8667816,
"heapUsedBytes": 78521952,
"domNodes": -273,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 85.425,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.5439999999508,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.544999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.528,
"heapDeltaBytes": -6230624,
"heapUsedBytes": 57191432,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 89.437,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 901.5610000000152,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.092,
"layouts": 5,
"layoutDurationMs": 9.585,
"taskDurationMs": 698.55,
"heapDeltaBytes": 20205856,
"heapUsedBytes": 103229896,
"domNodes": 13667,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 21.657999999999998,
"eventListeners": 2383,
"totalBlockingTimeMs": 91,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8195.270999999992,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.932,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4653.409,
"heapDeltaBytes": -16060644,
"heapUsedBytes": 65238108,
"domNodes": -245,
"jsHeapTotalBytes": 2912256,
"scriptDurationMs": 2202.668,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8257.862000000045,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.54299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4960.824,
"heapDeltaBytes": -10672692,
"heapUsedBytes": 76864932,
"domNodes": -240,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 2348.9320000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 14638.93100000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14500.696000000002,
"heapDeltaBytes": -43489308,
"heapUsedBytes": 179580480,
"domNodes": -8062,
"jsHeapTotalBytes": -19369984,
"scriptDurationMs": 209.49699999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14882.354000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14696.297999999999,
"heapDeltaBytes": -56251152,
"heapUsedBytes": 181298708,
"domNodes": -8062,
"jsHeapTotalBytes": -16101376,
"scriptDurationMs": 216.822,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17381.74199999992,
"styleRecalcs": 120,
"styleRecalcDurationMs": 16.042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17291.13,
"heapDeltaBytes": -43997064,
"heapUsedBytes": 190041100,
"domNodes": -8062,
"jsHeapTotalBytes": -13422592,
"scriptDurationMs": 722.987,
"eventListeners": -14928,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17493.696999999996,
"styleRecalcs": 123,
"styleRecalcDurationMs": 15.565999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17370.773999999998,
"heapDeltaBytes": -59081096,
"heapUsedBytes": 180968080,
"domNodes": -8062,
"jsHeapTotalBytes": -18972672,
"scriptDurationMs": 732.626,
"eventListeners": -14928,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5184.537999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.79799999999999,
"layouts": 20,
"layoutDurationMs": 21.686999999999998,
"taskDurationMs": 5125.458999999999,
"heapDeltaBytes": 7104860,
"heapUsedBytes": 190649816,
"domNodes": 0,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 87.49600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 249,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5475.34399999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.941000000000024,
"layouts": 20,
"layoutDurationMs": 23.816000000000003,
"taskDurationMs": 5448.043000000001,
"heapDeltaBytes": -64726848,
"heapUsedBytes": 176409164,
"domNodes": -8062,
"jsHeapTotalBytes": 13500416,
"scriptDurationMs": 90.02,
"eventListeners": -14928,
"totalBlockingTimeMs": 341,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7529.988000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7486.125999999998,
"heapDeltaBytes": -9595672,
"heapUsedBytes": 173407188,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 117.79499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7557.438999999931,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7479.6889999999985,
"heapDeltaBytes": -1603320,
"heapUsedBytes": 189756568,
"domNodes": 0,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 130.18400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 424.69999999991614,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.328999999999997,
"layouts": 4,
"layoutDurationMs": 1.906,
"taskDurationMs": 111.79499999999999,
"heapDeltaBytes": 5122276,
"heapUsedBytes": 70837860,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.535,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 425.7320000000391,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.004,
"layouts": 4,
"layoutDurationMs": 1.6669999999999998,
"taskDurationMs": 101.445,
"heapDeltaBytes": 4894516,
"heapUsedBytes": 67020900,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.611999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999272
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
90401fe to
d34281d
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed exact head fdb5645 against the cloud/1.54-to-cloud/1.55 parity set and the target branch. Corrected three carrier defects: removed deliberately cloud/1.54-only #18911 instead of importing its excluded activation-telemetry substrate, removed the duplicate session start left by the #18693 conflict resolution, and gated #18664 pagehide-close telemetry on accepted consent. Also replaced the two pre-#18693 unit expectations with the carried follow-visible/node-reference behavior. Local evidence at this head: application typecheck passed; AgentPanelRoot and agentPanelStore 350/350 passed; the broader focused carrier set had 723/728 before these corrections, with all five failures accounted for and the affected suites now green. No unresolved review threads exist; hosted exact-head CI remains authoritative.
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.55 #19790 +/- ##
=============================================
Coverage ? 84.79%
=============================================
Files ? 2316
Lines ? 132312
Branches ? 35647
=============================================
Hits ? 112199
Misses ? 19751
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed exact head 46005d8bc94a1b6765f5e9e3d7b811dc574479e5 against cloud/1.55.
Validated the carrier diff and repaired the branch-specific conflicts: duplicate agent start, pagehide telemetry consent, stale unit assertions, release-health findings, and cloud/1.55 harness expectations. Confirmed #18911 remains excluded because its source backport explicitly targets cloud/1.54 and cloud/1.55 lacks that telemetry substrate.
Evidence: focused agent panel/store tests pass (350/350); app and browser typechecks pass; affected black-box agent cases pass, including exact PM-1415 rerun; the complete GitHub unit, lint, fallow, ecosystem, and Playwright matrices are green at this exact head. No blocking findings remain.
…18664, #18665, #18401, #18413, #18390, #18974) (#19803) ## Summary Single consolidated backport into `cloud/1.55` of Hunter's agent telemetry / paywall attribution cluster. Each PR was cherry-picked individually, in merge order, with conflicts resolved and typecheck + the affected suites run before each commit. | # | PR | Commit | |---|---|---| | 1 | [#18665](#18665) instrument agent panel actions | `f937e5573a` | | 2 | [#18401](#18401) `agent_panel_open` on run attribution events (PM-1471) | `437f420c53` | | 3 | [#18413](#18413) read `agent_panel_open` fresh (PM-1472) | `f70be945cd` | | 4 | [#18390](#18390) attribute agent paywall purchases through checkout telemetry | `ffbaaaea8d` | | 5 | [#18974](#18974) close E1/E3 agent paywall attribution gaps | `c1607791f0` | ### #18664 is not here — it already landed The request listed six PRs. [#18664](#18664) (panel open time: pagehide teardown + visibility flag, G2/G3) **is already on `cloud/1.55`**, backported as part of [#19790](#19790) ("Complete 1.54 parity sweep"), which merged while this branch was being built. Its commit body lists #18664 explicitly, and `getPageVisibilityMetadata.{ts,test.ts}` are present on the base. This branch was rebased onto the new `cloud/1.55` and the now-redundant #18664 cherry-pick dropped. **All six PRs from the request are on `cloud/1.55` once this merges.** Applied in merge order rather than the order listed in the request: #18390 (Sep 25) merged three days before #18974 (Sep 28), which is a direct follow-up fixing #18390's E1/E3 gaps. Applying #18974 first would have meant resolving the follow-up against a base missing the thing it fixes. ### Two backport-specific commits on top - `29fc07f3d6` **refactor(agent): split `reportWorkflowBound` for the fallow CRAP gate.** #18665's `reportWorkflowBound` lands at cyclomatic 13 / CRAP 49.5 on this base, which `fallow` gates as a newly introduced finding (it was the only one of the 9 reported findings actually attributed to this PR — `complexity_introduced: 1`, the other 25 are inherited). Extracted the pending-bind parking, the pending-bind take, and the last-reported lookup into named helpers. Behaviour is unchanged: the fallback passed to `lastReportedWorkflowFor` is the same expression the old ternary's else branch computed, and it has no side effects. `npx fallow audit --changed-since <base>` now returns `verdict: pass`, `complexity_introduced: 0`. - The five cherry-picks had their upstream **AI-agent `Co-authored-by:` trailers stripped** (`Claude Fable 5`, `Amp`), which `.github/scripts/check-ai-co-authors.sh` rejects. No human co-author attribution was removed. The script passes locally against this base. ## Conflict resolutions The recurring cause is that `cloud/1.55` already carries later work these PRs predate — chiefly the #19521 backport (standing credits-exhausted paywall), which introduced `AgentPaywallSurface`; the #19497 backport (`app:agent_error` / TEL-8); and #19790's agent-panel target handling. **#18665 — `useAgentSession.ts`.** The incoming patch and `cloud/1.55` both rewrote the malformed-event / message-done region. `cloud/1.55`'s version is the superset: it has `trackMalformedStreamEvent` (TEL-8), `markStoppedTurnReady`, and `handleActiveTab`. Kept that and folded in #18665's additions — `turnStartedAt` cleanup on `agent_message_done` and in the malformed path, `forgetActiveTurnStartedAt()`, and the `onAskResolved` callback. Dropped #18665's `handleMessageDone`, whose inline stopping→ready transition `markStoppedTurnReady` already performs. **#18665 — `AgentPanelRoot.vue`, against #19790.** Two conflicts introduced by the rebase: - #18665 relocates `start()` next to its new approval handlers. #19790 had already moved `start()` deliberately, with a comment explaining the ordering against target startup. Kept #19790's call site and added only the approval handlers, avoiding a second `start()`. - `onNewChat` — #19790 replaced `setWorkflowTarget(activeWorkflow)` with `retainWorkflowTarget()` / `startFollowingVisibleWorkflow()` keyed on selection tags. Kept #19790's logic; #18665's contribution there is only threading `source` into `newChat(source)`. **#18390 / #18974 — `surface` field.** Roughly 20 conflicts across `types.ts`, `PostHogTelemetryProvider`, `HostTelemetrySink`, `TelemetryRegistry`, and `AgentPanelRoot` were the same shape: `cloud/1.55` carries `surface` on `AgentPaywallShownMetadata` / `AgentPaywallCtaMetadata`, #18390 branched before it existed. Kept `cloud/1.55` in every case and folded in #18390's actual contribution, the `{ source: 'agent_paywall' }` argument to `openAccountPrecondition`. **#18390 — duplicates from a clean auto-merge.** Several files auto-merged without a conflict but produced duplicate declarations, because #18390 re-added what #19521 already backported. Removed the duplicate copy in each: the paywall-impression `watch` in `AgentPanelRoot.vue`, `claimPaywallImpression` in `agentConversationStore.ts`, `trackAgentPaywallShown` / `trackAgentPaywallCtaClicked` in `PostHogTelemetryProvider.ts`, and duplicate type imports in `TelemetryRegistry.ts` and `agentPaywallPresentation.ts`. `resolvePaywalls` was kept over the incoming `setPaywallsResolved`, which has no definition on this branch. **#18401 — `agentPanelStore.test.ts`.** Both sides appended tests at the same point; kept both. ## Deliberately dropped `#18974`'s one-line addition to the **`intent`-stage top-up event** in `TopUpCreditsDialogContentWorkspace.vue`. `cloud/1.55`'s `TopupBillingEvent` stage union is `BillingStarted | BillingSucceeded | BillingFailed` — there is no `intent` stage, and `handlePrimaryAction` emits no telemetry on the amount→confirm step. #18974 only *added `payment_intent_source` to* an event that does not exist here, so there was nothing to attribute. The field itself **is** on the type, and the other five `payment_intent_source` call sites (`started`, two synchronous failures, `succeeded`, `reportPurchaseError`) plus the `adoptPendingOperation` poller hand-off all applied. E3's actual coverage is intact. Two test expectations were adjusted to match the branch rather than upstream: - `TopUpCreditsDialogContentWorkspace.test.ts` — the four `carries the opening surface onto every top-up event` rows drop `'intent'` from their expected stage collections, matching the dropped emit. They still assert the whole projected `(stage, source)` collection, so the falsifier #18974 relied on is preserved for every remaining site. - `AgentPanelRoot.test.ts` — `attributes its CTA to the credits_exhausted surface` now expects `openAccountPrecondition('credits', { source: 'agent_paywall' })`. That test came from #19521 and predates #18390's new argument. ## Tests On `3b81246105`, rebased onto `b064d929ce`: - `pnpm typecheck` — exit 0 across all five projects (app, account-core, billing-web, account-ui, billing-contract). - `pnpm lint` — **0 errors**, 198 warnings, all pre-existing `import-x/no-restricted-paths` and `import-x/no-named-as-default-member` in files this PR does not touch. - `pnpm format:check` — clean. - `pnpm vitest run src/workbench/extensions/agent src/platform/telemetry src/extensions/core/agentPanel.test.ts` — **167 files passed, 2826 passed, 2 expected fail**, 0 failures. - `pnpm test:unit` (whole suite) passed exit 0 on the pre-rebase tree; it is re-running against this base, and CI is the authority on the result. Browser/Playwright tests were not run locally — those only run in CI, and no claim is made about them here.
Summary
Consolidates the verified fixes that landed on
cloud/1.54but were absent fromcloud/1.55:fix(litegraph): keep promoted dynamic combo child links on load (FE-258) #17486 keeps promoted dynamic-combo child links when loading workflows.
Give unified-remint retry fetch its own timeout window #18599 gives unified-remint retries a fresh timeout window.
fix(nodes): allow shrinking after content growth and tab switches #18093 allows nodes to shrink after content growth and tab switches.
Fix duplicate-name stale workflow binding resolution #18155 resolves stale Agent bindings when workflows share a name.
feat(agent): follow visible workflow until send or node reference #18693 keeps the Agent target aligned with the visible workflow until send or node reference.
fix(agent): wait for open dialogs before offering Agent consent #18619 waits for open dialogs before showing Agent consent.
fix(agent): deselect node when its composer reference chip is removed (PM-1227) #18061 deselects a node when its composer reference is removed.
feat(agent): mark video reply assets #18392 marks video reply assets correctly.
feat: panel open time — pagehide teardown + visibility flag (G2, G3) #18664 records Agent panel visibility and page-hide teardown correctly.
feat(agent): improve onboarding card focus, navigation, and replay #18911 restores Agent onboarding focus, navigation, and replay behavior.
feat(agent): improve onboarding card focus, navigation, and replay #18911 remains deliberately excluded: its activation-telemetry substrate is cloud/1.54-only, and the original backport records that scope.
This is the consolidated
cloud/1.55carrier from the 1.54→1.55 release audit. The already-open saved-workflow backport remains in #19732 and is intentionally not duplicated here.Validation