Skip to content

[chore] Update Ingest API types from cloud@44b2ac7 - #19524

Merged
christian-byrne merged 17 commits into
cloud/1.55from
update-ingest-types-cloud-1.55
Oct 3, 2026
Merged

christian-byrne merged 17 commits into
cloud/1.55from
update-ingest-types-cloud-1.55

Conversation

@comfy-pr-bot

@comfy-pr-bot comfy-pr-bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Automated Ingest API Type Update

This PR updates the Ingest API TypeScript types and Zod schemas from the latest cloud OpenAPI specification.

  • Cloud commit: 44b2ac7
  • Generated using @hey-api/openapi-ts with Zod plugin

These types cover the FE-facing ingest API (workspaces, billing, secrets, assets, tasks, etc.).
Cloud's internal / machine-to-machine surface — x-internal operations and the
/admin/, /api/internal/, /api/webhooks/ rails — is stripped before generation
(BE-2669), so it is not code-generated into this public package.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎭 Playwright: ✅ 2146 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2125 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/03/2026, 12:18:25 AM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since a9968daf959f722c7461c3a48efee1d8b5404d91

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 591ms TBT · 84.8 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 226ms TBT · 86.7 MB heap
extension-clean-combined-draw: · 51.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1505ms TBT · 80.5 MB heap
extension-rgthree-prototype-draw: · 51.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1077ms TBT · 73.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 140ms TBT · 79.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.8 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.9 MB heap
vue-large-graph-pan: · 53.7 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 61ms TBT · 178.4 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 394ms TBT · 176.2 MB heap
vue-zoom-out-idle: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 182.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 461ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.3 MB
canvas-idle: DOM nodes -259
canvas-idle: event listeners -152
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 45
canvas-mouse-sweep: task duration 751ms
canvas-mouse-sweep: script duration 162ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 56.3 MB
canvas-mouse-sweep: DOM nodes -261
canvas-mouse-sweep: event listeners -174
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 334ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 67.7 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 461ms
dom-widget-clipping: script duration 176ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 82.5 MB
dom-widget-clipping: DOM nodes 22
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 908ms
dom-widget-order-dense-n200-w200-i120: script duration 73ms
dom-widget-order-dense-n200-w200-i120: TBT 591ms
dom-widget-order-dense-n200-w200-i120: heap used 84.8 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -296
dom-widget-order-dense-n200-w200-i120: event listeners -206
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 462ms
dom-widget-order-sparse-n1000-w20-i120: script duration 163ms
dom-widget-order-sparse-n1000-w20-i120: TBT 226ms
dom-widget-order-sparse-n1000-w20-i120: heap used 86.7 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 19ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9653ms
extension-clean-combined-draw: script duration 8255ms
extension-clean-combined-draw: TBT 1505ms
extension-clean-combined-draw: heap used 80.5 MB
extension-clean-combined-draw: DOM nodes -16
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 19ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 9379ms
extension-rgthree-prototype-draw: script duration 7842ms
extension-rgthree-prototype-draw: TBT 1077ms
extension-rgthree-prototype-draw: heap used 73.6 MB
extension-rgthree-prototype-draw: DOM nodes -142
extension-rgthree-prototype-draw: event listeners -87
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 594ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.0 MB
large-graph-idle: DOM nodes -240
large-graph-idle: event listeners -152
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1671ms
large-graph-pan: script duration 881ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 70.5 MB
large-graph-pan: DOM nodes -251
large-graph-pan: event listeners -87
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1668ms
large-graph-zoom: script duration 795ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.1 MB
large-graph-zoom: DOM nodes 4
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1953ms
legacy-node-drag: script duration 1012ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.9 MB
legacy-node-drag: DOM nodes -123
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 571ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 78.9 MB
minimap-idle: DOM nodes -120
minimap-idle: event listeners -87
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 404ms
subgraph-dom-widget-clipping: script duration 147ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 80.1 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 493ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.8 MB
subgraph-idle: DOM nodes -277
subgraph-idle: event listeners -220
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 16ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 46
subgraph-mouse-sweep: task duration 738ms
subgraph-mouse-sweep: script duration 105ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 74.0 MB
subgraph-mouse-sweep: DOM nodes -276
subgraph-mouse-sweep: event listeners -198
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 913ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 140ms
subgraph-transition-enter: heap used 79.6 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 5610ms
viewport-pan-sweep: script duration 2920ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 79.8 MB
viewport-pan-sweep: DOM nodes -241
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16119ms
vue-large-graph-idle: script duration 253ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.9 MB
vue-large-graph-idle: DOM nodes -8061
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 19ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 164
vue-large-graph-pan: task duration 20168ms
vue-large-graph-pan: script duration 913ms
vue-large-graph-pan: TBT 61ms
vue-large-graph-pan: heap used 178.4 MB
vue-large-graph-pan: DOM nodes -8061
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 78ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5982ms
vue-node-resize-workload: script duration 107ms
vue-node-resize-workload: TBT 394ms
vue-node-resize-workload: heap used 176.2 MB
vue-node-resize-workload: DOM nodes -8061
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7070ms
vue-zoom-out-idle: script duration 125ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 182.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 3
workflow-execution: style recalc count 8
workflow-execution: task duration 85ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 65.8 MB
workflow-execution: DOM nodes 109
workflow-execution: event listeners 33
Raw data
{
  "timestamp": "2026-10-03T00:29:15.263Z",
  "gitSha": "95a192bd8117276105fddf51ddb5be7eb5d17849",
  "branch": "update-ingest-types-cloud-1.55",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 1999.0179999999782,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.464,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.20699999999994,
      "heapDeltaBytes": 7104000,
      "heapUsedBytes": 75257944,
      "domNodes": -256,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.733,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2006.042999999977,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.350000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.83699999999993,
      "heapDeltaBytes": 2182420,
      "heapUsedBytes": 69998640,
      "domNodes": -262,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.351,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1737.9250000000184,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 13.965000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 698.226,
      "heapDeltaBytes": -6348416,
      "heapUsedBytes": 61522420,
      "domNodes": -259,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 158.856,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1739.512999999988,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 13.780000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 803.728,
      "heapDeltaBytes": -6225332,
      "heapUsedBytes": 56457804,
      "domNodes": -262,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 165.413,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1666.1530000000084,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 15.270000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.029,
      "taskDurationMs": 343.68,
      "heapDeltaBytes": 3146836,
      "heapUsedBytes": 70882472,
      "domNodes": 80,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 10.786999999999997,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1665.091000000075,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 12.780999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.0040000000000002,
      "taskDurationMs": 325.032,
      "heapDeltaBytes": 2912780,
      "heapUsedBytes": 71189660,
      "domNodes": 77,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 10.225000000000001,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 624.7589999999832,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 9.568000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 461.022,
      "heapDeltaBytes": 18679364,
      "heapUsedBytes": 86483064,
      "domNodes": 24,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 176.69199999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 644.1730000000234,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.917999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 461.939,
      "heapDeltaBytes": 18613436,
      "heapUsedBytes": 86539564,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 175.19600000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1222.879999999975,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 913.8689999999999,
      "heapDeltaBytes": -17071172,
      "heapUsedBytes": 73244436,
      "domNodes": -295,
      "jsHeapTotalBytes": 20054016,
      "scriptDurationMs": 75.174,
      "eventListeners": -217,
      "totalBlockingTimeMs": 567,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1243.1379999999308,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 901.51,
      "heapDeltaBytes": 14044208,
      "heapUsedBytes": 104664668,
      "domNodes": -296,
      "jsHeapTotalBytes": 21909504,
      "scriptDurationMs": 70.31599999999999,
      "eventListeners": -195,
      "totalBlockingTimeMs": 615,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 842.0249999999783,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 457.68699999999995,
      "heapDeltaBytes": 15724672,
      "heapUsedBytes": 91248124,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 161.13299999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 222,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 844.7629999999435,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.62800000000004,
      "heapDeltaBytes": 13933464,
      "heapUsedBytes": 90539292,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 165.669,
      "eventListeners": 0,
      "totalBlockingTimeMs": 229,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10623.270999999988,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9618.849,
      "heapDeltaBytes": 11288436,
      "heapUsedBytes": 93530468,
      "domNodes": -16,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 8242.205,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1465,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10691.845999999941,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9686.238,
      "heapDeltaBytes": -6962544,
      "heapUsedBytes": 75393972,
      "domNodes": -16,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 8267.287,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1544,
      "frameDurationMs": 19.996666666666655,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10091.486999999972,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9166.008,
      "heapDeltaBytes": 183328,
      "heapUsedBytes": 82397308,
      "domNodes": -14,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 7798.027,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1111,
      "frameDurationMs": 18.889999999999965,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10422.35500000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9592.367999999999,
      "heapDeltaBytes": -5327144,
      "heapUsedBytes": 72057216,
      "domNodes": -270,
      "jsHeapTotalBytes": 1040384,
      "scriptDurationMs": 7886.380999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 1043,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 49.899999999999636
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2029.9679999999967,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.226,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 598.261,
      "heapDeltaBytes": -3888548,
      "heapUsedBytes": 83886884,
      "domNodes": -240,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 33.824999999999996,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.4310000000123,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.338999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.8200000000002,
      "heapDeltaBytes": -3561400,
      "heapUsedBytes": 83866644,
      "domNodes": -240,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 32.355,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2347.8039999999964,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.882000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1694.136,
      "heapDeltaBytes": -13153316,
      "heapUsedBytes": 67493388,
      "domNodes": -256,
      "jsHeapTotalBytes": -8192,
      "scriptDurationMs": 905.906,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2309.53599999998,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.329000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1647.203,
      "heapDeltaBytes": 15735428,
      "heapUsedBytes": 80275928,
      "domNodes": -246,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 855.962,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3453.950999999961,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 10.503000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.596,
      "taskDurationMs": 1655.5539999999999,
      "heapDeltaBytes": 8333584,
      "heapUsedBytes": 74452644,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 784.474,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3536.4550000000463,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 10.825000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.786999999999999,
      "taskDurationMs": 1680.778,
      "heapDeltaBytes": 7818488,
      "heapUsedBytes": 74575720,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 805.191,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3165.4960000000187,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.699000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1924.0009999999997,
      "heapDeltaBytes": 23251028,
      "heapUsedBytes": 89676192,
      "domNodes": 4,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 1010.0830000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3127.701000000002,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 6.677999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1982.989,
      "heapDeltaBytes": 26695104,
      "heapUsedBytes": 92463352,
      "domNodes": -250,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 1014.357,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.8280000000095,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.655,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 636.293,
      "heapDeltaBytes": -8818512,
      "heapUsedBytes": 80534672,
      "domNodes": -250,
      "jsHeapTotalBytes": -233472,
      "scriptDurationMs": 40.60700000000002,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2001.1739999999918,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.733,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 504.815,
      "heapDeltaBytes": 20092576,
      "heapUsedBytes": 85000760,
      "domNodes": 10,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.42199999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 590.9469999999715,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.395999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.567,
      "heapDeltaBytes": 13809276,
      "heapUsedBytes": 83843124,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 146.761,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 579.3290000000297,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.61,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 410.522,
      "heapDeltaBytes": 13983268,
      "heapUsedBytes": 84238480,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 148.14300000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.1159999999732,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.815000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.913,
      "heapDeltaBytes": -2158792,
      "heapUsedBytes": 68009696,
      "domNodes": -275,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.187999999999997,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2024.0780000000314,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.260000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 527.311,
      "heapDeltaBytes": 3765840,
      "heapUsedBytes": 67887892,
      "domNodes": -278,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 10.313000000000002,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1727.0809999999983,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 15.027,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 722.7640000000001,
      "heapDeltaBytes": 6207212,
      "heapUsedBytes": 76701860,
      "domNodes": -275,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 101.586,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.5379999999623,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 16.006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 753.6550000000001,
      "heapDeltaBytes": 8399364,
      "heapUsedBytes": 78403824,
      "domNodes": -276,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 108.089,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.8169999999982,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 28.653000000000006,
      "layouts": 5,
      "layoutDurationMs": 13.008,
      "taskDurationMs": 913.0619999999998,
      "heapDeltaBytes": -6292736,
      "heapUsedBytes": 83483180,
      "domNodes": 13667,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 29.429999999999996,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8460.974000000022,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 39.345000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5790.35,
      "heapDeltaBytes": -1998600,
      "heapUsedBytes": 85156044,
      "domNodes": -242,
      "jsHeapTotalBytes": 253952,
      "scriptDurationMs": 2817.149,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8407.493000000046,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 34.746,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5430.072000000001,
      "heapDeltaBytes": 417652,
      "heapUsedBytes": 82288820,
      "domNodes": -239,
      "jsHeapTotalBytes": 1794048,
      "scriptDurationMs": 3022.6169999999997,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16780.888000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16238.941,
      "heapDeltaBytes": -68790600,
      "heapUsedBytes": 171672328,
      "domNodes": -8061,
      "jsHeapTotalBytes": -18243584,
      "scriptDurationMs": 249.583,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16506.599999999933,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15998.425000000001,
      "heapDeltaBytes": 10485964,
      "heapUsedBytes": 184700124,
      "domNodes": -8061,
      "jsHeapTotalBytes": -16252928,
      "scriptDurationMs": 256.89399999999995,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20439.01900000003,
      "styleRecalcs": 158,
      "styleRecalcDurationMs": 17.957999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20186.864,
      "heapDeltaBytes": -38785244,
      "heapUsedBytes": 181742180,
      "domNodes": -8061,
      "jsHeapTotalBytes": -17694720,
      "scriptDurationMs": 908.5190000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 72,
      "frameDurationMs": 18.886666666666738,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20495.452999999998,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 17.788000000000025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20148.822000000004,
      "heapDeltaBytes": -33261328,
      "heapUsedBytes": 192369056,
      "domNodes": -8061,
      "jsHeapTotalBytes": -16068608,
      "scriptDurationMs": 916.5179999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 49,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6108.901999999944,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.08500000000002,
      "layouts": 20,
      "layoutDurationMs": 23.064,
      "taskDurationMs": 6005.946000000001,
      "heapDeltaBytes": -41088176,
      "heapUsedBytes": 184826472,
      "domNodes": -8061,
      "jsHeapTotalBytes": 15912960,
      "scriptDurationMs": 105.19000000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 418,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6039.664000000016,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.38899999999998,
      "layouts": 20,
      "layoutDurationMs": 22.93200000000001,
      "taskDurationMs": 5958.423000000001,
      "heapDeltaBytes": -35705332,
      "heapUsedBytes": 184669988,
      "domNodes": -8061,
      "jsHeapTotalBytes": 21512192,
      "scriptDurationMs": 109.34299999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 369,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8273.319000000014,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8046.294,
      "heapDeltaBytes": -12059356,
      "heapUsedBytes": 179985644,
      "domNodes": 0,
      "jsHeapTotalBytes": -14155776,
      "scriptDurationMs": 148.83,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6377.011000000039,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6093.454999999999,
      "heapDeltaBytes": 16039116,
      "heapUsedBytes": 201844564,
      "domNodes": 0,
      "jsHeapTotalBytes": -28835840,
      "scriptDurationMs": 101.68899999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 104.57399999995687,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 14.854999999999999,
      "layouts": 2,
      "layoutDurationMs": 0.5970000000000001,
      "taskDurationMs": 78.95200000000003,
      "heapDeltaBytes": 3203728,
      "heapUsedBytes": 68989504,
      "domNodes": 109,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.387,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 126.05099999996128,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 20.043,
      "layouts": 3,
      "layoutDurationMs": 1.4329999999999998,
      "taskDurationMs": 90.04900000000002,
      "heapDeltaBytes": 3198580,
      "heapUsedBytes": 69055508,
      "domNodes": 109,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.668000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52703 79663 66.2% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.8% 1153
src/LGraphNode.ts 70.6% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/platform/workspace/stores/billingOperationStore.ts 8.0% 332
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/LGraph.ts 79.2% 267
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.2% 252
src/scripts/pnginfo.ts 20.7% 222

@github-actions
github-actions Bot requested a review from ryan-di September 30, 2026 01:12
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.55   #19524   +/-   ##
=============================================
  Coverage              ?   84.05%           
=============================================
  Files                 ?     3080           
  Lines                 ?   151859           
  Branches              ?    39095           
=============================================
  Hits                  ?   127639           
  Misses                ?    22811           
  Partials              ?     1409           
Flag Coverage Δ
billing-web-unit 91.45% <ø> (?)
e2e 66.20% <100.00%> (?)
unit 80.99% <100.00%> (?)
website-unit 76.24% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ages/account-core/src/core/billing/capabilities.ts 85.71% <ø> (ø)
...ages/account-core/src/core/billing/moneySchemas.ts 100.00% <100.00%> (ø)
...ccount-core/src/core/billing/operationLifecycle.ts 73.10% <100.00%> (ø)
...es/account-core/src/core/billing/operationState.ts 79.51% <100.00%> (ø)
...ount-core/src/core/billing/subscriptionCommands.ts 83.59% <ø> (ø)
packages/ingest-types/src/zod.gen.ts 100.00% <100.00%> (ø)
...c/platform/workspace/api/__mocks__/workspaceApi.ts 16.21% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 30, 2026
@comfy-pr-bot
comfy-pr-bot force-pushed the update-ingest-types-cloud-1.55 branch from 7fbf0bb to f46a2fa Compare September 30, 2026 03:20
@comfy-pr-bot comfy-pr-bot changed the title [chore] Update Ingest API types from cloud@f304d5a [chore] Update Ingest API types from cloud@7db7c53 Sep 30, 2026
@datadog-official

This comment has been minimized.

@christian-byrne christian-byrne assigned DrJKL and unassigned wei-hai Sep 30, 2026
@christian-byrne
christian-byrne requested review from a team and dante01yoon as code owners September 30, 2026 05:14
@comfy-pr-bot comfy-pr-bot changed the title [chore] Update Ingest API types from cloud@7db7c53 [chore] Update Ingest API types from cloud@228ec30 Sep 30, 2026
@comfy-pr-bot
comfy-pr-bot force-pushed the update-ingest-types-cloud-1.55 branch 2 times, most recently from 2006485 to 9b4acad Compare September 30, 2026 15:11
@comfy-pr-bot comfy-pr-bot changed the title [chore] Update Ingest API types from cloud@228ec30 [chore] Update Ingest API types from cloud@7d01f2c Sep 30, 2026
@comfy-pr-bot comfy-pr-bot changed the title [chore] Update Ingest API types from cloud@7d01f2c [chore] Update Ingest API types from cloud@b1a9431 Sep 30, 2026
@comfy-pr-bot
comfy-pr-bot force-pushed the update-ingest-types-cloud-1.55 branch 2 times, most recently from c327dfc to fc70f56 Compare September 30, 2026 16:21
@comfy-pr-bot comfy-pr-bot changed the title [chore] Update Ingest API types from cloud@b1a9431 [chore] Update Ingest API types from cloud@96a29d7 Sep 30, 2026
'processing_error',
'payment_not_completed',
'generic'
] as const satisfies readonly NonNullable<OpStatus['decline_reason']>[]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not just use this directly?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the copied decline-reason list in commit 9226516.

@comfy-pr-bot
comfy-pr-bot force-pushed the update-ingest-types-cloud-1.55 branch from fc70f56 to 5c024a1 Compare September 30, 2026 19:14
@comfy-pr-bot comfy-pr-bot changed the title [chore] Update Ingest API types from cloud@96a29d7 [chore] Update Ingest API types from cloud@b7db355 Sep 30, 2026
@DrJKL
DrJKL self-requested a review September 30, 2026 19:35

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: changes requested. The head fails typecheck because the regenerated int64 fields reach account-core and the app as bigint, and billing-web handles payment_not_completed as a card decline.

Since my last review at fc70f56, the branch was rebuilt. The regen commit is now 25b0910, from cloud@b7db355, and it adds balance_applied_cents. The account-core commit 5c024a1 did not change (git range-diff shows =). I also missed the red typecheck when I approved fc70f56. It was failing there too, so that approval should not count.

Pre-merge blockers

  1. P1, inline on zod.gen.ts:1049. The new preview money fields parse to bigint. The account-core adapter and its compile-time pins were not updated, so pnpm typecheck fails in account-core and in the app.
  2. P1, inline on zod.gen.ts:2556. amount_charged_cents and credits_added parse to bigint through BillingOpStatus, and customerActionParity.test.ts:43 fails typecheck.
  3. P1, body item 1 below. billing-web shows payment_not_completed as a declined card and renders a missing translation key.
Findings without an anchorable line (3)
  1. P1: billing-web classifies payment_not_completed as a card decline and has no copy for it. apps/billing-web/src/checkout/payVerdict.ts:93-109 routes a decline to the not_completed card only when the reason is in UNAUTHENTICATED_REASONS (authentication_failed, authentication_required) or is generic with a retry action. The new reason is in neither, and stepForReason in paymentProjection.ts maps it to declined. So a customer who abandoned approval gets the "declined" outcome, and InlineOutcomeCard.vue:50 renders t('checkout.fullPage.outcome.reasons.payment_not_completed'). That key is missing from apps/billing-web/src/locales/en/main.json:226-236, so vue-i18n prints the key path. I checked this with a throwaway billing-web test at this head:

    • operationOutcomeOf(failedOperation('payment_not_completed', 'op_9')) returned { kind: 'declined', reason: 'payment_not_completed', operationId: 'op_9' }.
    • operationOutcomeOf(failedOperation('authentication_failed', 'op_8')) returned { kind: 'not_completed', operationId: 'op_8' }.
    • Object.keys(en.checkout.fullPage.outcome.reasons) does not contain payment_not_completed.

    The server's own description ("customer non-approval or an expired attempt") matches billing-web's not_completed card. Adding 'payment_not_completed' to UNAUTHENTICATED_REASONS fixes the card. Add a row for it in the existing payVerdict.test.ts operationOutcomeOf table next to the authentication_failed row. Also add the reasons.payment_not_completed locale key so a future declined path cannot print a raw key.

  2. P2: the declineDetailKey table in paymentCopy.test.ts has no row for the new reason. In packages/account-core/src/core/billing/paymentCopy.test.ts:100-112 every other decline reason has a row. I changed the payment_not_completed case in paymentCopy.ts to return paymentDeclinedDetail, ran vitest run src/core/billing/paymentCopy, and all 16 tests still passed. So the mapping this commit adds is unpinned. One row fixes it: ['payment_not_completed', 'authenticationFailedDetail'], or whatever the inline question on paymentCopy.ts:96 settles on. The new DEFAULT_PAYMENT_COPY key needs no test, because Record<PaymentCopyKey, string> already fails compilation without it.

  3. P3: the PR description does not mention the hand-authored commit. The body is the generator template. 5c024a1 changes customer-facing copy and decline handling in account-core, and a reviewer reading "Automated Ingest API Type Update" would skip it. A line naming that commit, the new decline reason, and the account-core/billing-web follow-through would help.

My earlier findings (2, still open)
  • Shouldn't this reference a generated type? (billingOpStatus.contract.test.ts:35) is still open. The code did not change. I've refined it in the inline comment on line 114.
  • Can we not just use this directly? (billingOpStatus.contract.test.ts:45) is also still open. Using the zod enum's .options would remove the copied literals. It would also leave the it.for checking that a schema accepts its own options. Because production code already enforces exhaustiveness, I now think the table should go (see the line 114 comment).
Checked and cleared (0 rejected)

No candidate was rejected. I lowered two rows from the lane severity:

  • The paymentCopy.ts:96 mapping went from P2 to a P3 question, because billing-web already groups authentication declines as "not completed", so the author's grouping is consistent.
  • The missing declineDetailKey row went from P1 to P2. It is a regression-test gap, not a runtime defect.

Other checks:

  • git range-diff fc70f56~2..fc70f56 5c024a1~2..5c024a1 shows the account-core commit unchanged. The regen delta is the b7db355 field additions only.
  • pnpm exec eslint and oxfmt --check pass on the two hand-edited files.
  • The generated files match the openapi-ts.config.ts plugin set (@hey-api/typescript plus zod, compatibility version 3). I could not regenerate them, because openapi.yaml is not in the repository.
Coverage
  • Depth: standard. Lanes run as separate reviewers: correctness, maintainability, idiomaticity, tests. I skipped documentation because the PR body is generator boilerplate with no behavior or compatibility claim, and one body item above covers it.
  • Lenses (standard set): blast-radius, regression-risk-reviewer, idempotency, shared-state, boundary-discipline, fix-root-causes; ponytail, no-comments (applied by hand, no sub-dispatch available), minimize-reader-load, subtract-before-you-add, laziness-protocol, migrate-callers; typescript-best-practices, type-system-discipline; designing-test-suites, reviewing-unit-tests, test-mock-quality-analysis, consolidating-test-setup, prove-it-works.
  • Checks at 5c024a1: pnpm typecheck exit 2 (8 errors in src/platform/workspace/**). pnpm typecheck:account-core exit 2 (3 pin errors). vitest run src/core/billing in account-core: 37 files, 551 passed. CI typecheck, typecheck-aux, lint-and-format, and verify-pack-contents (account-core) fail on this head and pass on base 44cbbe35.
  • Nobody traced: apps/website. It does not import the changed shapes.

message: 'Invalid value: Expected int64 to be <= 9223372036854775807'
})
.optional(),
balance_applied_cents: z.coerce

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1. This new int64 field, together with subtotal_cents (line 1113), PreviewPlanInfo.list_price_cents (line 1011), and SubscriptionDiscount.duration_in_months (line 554), parses to bigint, but types.gen.ts declares all four as number. Account-core's PreviewSchema / PlanInfoSchema in packages/account-core/src/core/billing/subscriptionCommands.ts:125-146 convert each money field to a safe number one by one, and nobody added these four. So SubscriptionPreview now carries bigint for them, and that breaks every place the app hands it back as a generated PreviewSubscribeResponse:

  • pnpm typecheck at this head fails in subscriptionOperationView.ts:199, useSubscriptionCheckout.ts:661 and :715, SubscriptionAddPaymentPreviewWorkspace.vue:11, SubscriptionSuccessWorkspace.vue:6, SubscriptionTransitionPreviewWorkspace.vue:3, and useWorkspaceBilling.subscriptionRail.test.ts:482.
  • pnpm typecheck:account-core fails where the compile-time pins were built to catch exactly this. previewSubscribe.contract.test.ts:75 wants balance_applied_cents and subtotal_cents in MONEY_FIELDS. subscriptionCommands.test.ts:809 wants them in QUOTE_CENT_FIELDS, and :812 wants list_price_cents in PLAN_CENT_FIELDS.
  • At runtime, once the server sends these fields, createBillingCommands().previewSubscribe returns cost_today_cents as a number and the new fields as bigint. JSON.stringify on the result throws "Do not know how to serialize a BigInt", and adding them to a number throws.

Smallest fix: add balance_applied_cents: cents.optional() and subtotal_cents: cents.optional() to PreviewSchema, list_price_cents: cents.optional() to PlanInfoSchema, and duration_in_months: z.number().int().safe().optional() to the discount extension. Then add the three _cents names to the three pin tables. The existing coercion, int64-range, and rejectsQuote rows then cover the new fields with no new test bodies.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalized the new preview fields and extended the existing field-table coverage in commit 9965529.

*/
export const zBillingOpStatusResponse = z.object({
action_url: z.string().optional(),
amount_charged_cents: z.coerce

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1. amount_charged_cents (here) and credits_added (line 2575) parse to bigint, but BillingOpStatusResponse in types.gen.ts types them as number. Account-core derives BillingOpStatus straight from zBillingOpStatusResponse (operationState.ts:19) with no number adapter. So a polled status now carries bigint, and src/platform/workspace/billing/customerActionParity.test.ts:43 fails typecheck: status.amount_charged_cents is number | undefined against bigint | undefined.

The server only sends these on succeeded operations, and they are display-only. Nothing reads them yet, so the runtime risk today is serialization: a status that reaches JSON.stringify (logging, persistence, cross-tab messaging) throws. I'd normalize them where the preview does. Extend the status schema with amount_charged_cents: cents.optional() and credits_added: z.number().int().safe().optional(), and derive BillingOpStatus from that, so the parity fixture typechecks without changes.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalized operation status amounts through the Account Core schema in commit 9965529.

* What a credit top-up of the requested amount would grant.
*/
export const zTopupQuoteResponse = z.object({
amount_cents: z.coerce

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3. Every int64 field is emitted twice with different types: number in types.gen.ts, z.coerce.bigint() here. TopupQuoteResponse.amount_cents / credits is the newest case. It has no consumer yet, so the first caller of zCreateTopupQuoteResponse gets bigint where the generated type says number. This PR adds seven more fields with the split, and each one needs a hand-written adapter in account-core, which is how the two P1s above happened. Not a blocker here, but it would be worth a follow-up to set the int64 handling in packages/ingest-types/openapi-ts.config.ts, so the Zod output matches the TS output and account-core can drop its per-field cents overrides.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #19704 to align generated Zod int64 output with the generated TypeScript number fields.

return 'incorrectCvcDetail'
case 'authentication_required':
case 'authentication_failed':
case 'payment_not_completed':

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3, question. The generated doc defines payment_not_completed as "Stripe explicitly reported customer non-approval or an expired attempt". This routes it to authenticationFailedDetail ("We couldn't complete payment verification. Please try again."). That fits an abandoned 3DS or wallet approval, and it matches billing-web, which counts authentication declines as "not completed". It reads oddly for an attempt that simply expired. Is "verification" the wording you want, or should this get its own detail key? Either way, please pin the answer with a row in the declineDetailKey table in paymentCopy.test.ts (see the review body).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This left the PR at 2ebe00f, where the hand-authored account-core commit was dropped. #19670 (27c2559) landed the same authenticationFailedDetail mapping on cloud/1.55, pinned by the ['payment_not_completed', 'authenticationFailedDetail'] row in paymentCopy.test.ts, so nothing is left to do here.

}
)

it.for(DECLINE_REASONS)(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3. This carries forward my two earlier comments on lines 35 and 45. I'd delete DECLINE_REASONS, its toEqualTypeOf pin on line 57, and this it.for, instead of deriving the list from the generated enum:

  • The rows come from the enum that zBillingOpStatusResponse defines, and the test asserts that the same schema accepts them. No wrong implementation fails here that the compiler doesn't already catch.
  • Production already makes a regen fail when a reason is added. Removing the payment_not_completed case from declineDetailKey fails account-core typecheck with TS2366 at paymentCopy.ts:86. Removing its DEFAULT_PAYMENT_COPY entry fails with TS2741 at paymentCopy.ts:29.
  • Switching to zBillingOpStatusResponse.shape.decline_reason.unwrap().options would remove the copied literals but make the test fully tautological.

Deleting these 28 lines adds no new typecheck error. The regeneration guard stays in paymentCopy.ts, and the behavior guard is the declineDetailKey table row I asked for in the body.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the redundant enum pin and tautological schema loop in commit 9226516.

@comfy-pr-bot
comfy-pr-bot force-pushed the update-ingest-types-cloud-1.55 branch from 5c024a1 to 0d6a4e0 Compare September 30, 2026 21:48
@comfy-pr-bot comfy-pr-bot changed the title [chore] Update Ingest API types from cloud@b7db355 [chore] Update Ingest API types from cloud@8295427 Sep 30, 2026
christian-byrne added a commit that referenced this pull request Oct 2, 2026
christian-byrne added a commit that referenced this pull request Oct 2, 2026
christian-byrne added a commit that referenced this pull request Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: one P2 left before approval. The charge-breakdown blocker is fixed and pnpm typecheck is green, but the new shared centsSchema coerces, so every money field now accepts null, "", and booleans as amounts.

Since my last review at b89d5e9:

  • The branch was rebuilt on cloud/1.55 at e9a89db. The new base commits are agent backports (#19732, #19803).
  • The six earlier commits are unchanged (git range-diff shows =).
  • 7f25acb adds moneySchemas.ts, normalizes charge_breakdown through it, moves PreviewSchema / PlanInfoSchema onto the shared schemas, and adds a breakdown test.
  • 8e510b6 is the formatter.

The author already replied in the charge-breakdown thread, so I posted no thread reply this round.

Remaining

  1. P2, inline on moneySchemas.ts:4. z.coerce.number() turns null, "", " ", false, and [] into 0, and true into 1, for every preview and op-status amount, including required ones like cost_today_cents. The previous z.number() rejected all of them. The coercion is only needed because the new test feeds bigint literals: reverting it fails that one test and nothing else.
  2. P3 Nit, inline on subscriptionCommands.ts:123. The int64 rationale docblock now sits above PlanInfoSchema instead of the cents definition it explains.
Earlier findings (all from prior rounds)
Coverage

Depth: standard, delta-scoped to 7f25acb and 8e510b6. The six earlier commits are byte-identical to the ones I reviewed at b89d5e9. Checks at 8e510b6:

  • pnpm typecheck exit 0 (app, account-core, billing-web, account-ui, billing-contract).
  • vitest run src/core/billing in account-core: 566 passed. With centsSchema reverted to z.number().int().safe(), 1 failed (normalizes charge breakdown amounts to numbers) and 565 passed.
  • Scratch probe of centsSchema against z.number().int().safe() over null, "", " ", "abc", "12", true, false, [], 12.5, 1999, 1999n: results in the inline table.
  • ESLint on the four changed account-core files exit 0.
  • CI: verify-pack-contents (account-core) passed. typecheck and typecheck-aux were still running when I posted.

import { zSubscriptionDiscount } from '@comfyorg/ingest-types/zod'
import { z } from 'zod'

export const centsSchema = z.coerce.number().int().safe()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2. Switching to z.coerce.number() loosens every money field account-core parses, not just the new breakdown. Coercion runs Number(x) before .int().safe(), so values that used to be MALFORMED_RESPONSE now parse as amounts. I ran both schemas at this head (scratch test, deleted after):

input z.coerce.number().int().safe() previous z.number().int().safe()
null 0 rejected
"" / " " 0 rejected
false / true 0 / 1 rejected
[] 0 rejected
"12" 12 rejected
1999n 1999 rejected

That includes required quote fields like cost_today_cents, which the docblock in subscriptionCommands.ts describes as "confirmed as charges". A null there now renders as a $0.00 charge instead of failing the quote.

Coercion seems to exist only because the new breakdown test feeds bigint literals (1999n, 500n, 3n), which never appear in a JSON body. With this line set back to z.number().int().safe(), that test is the only one of 566 that fails. The rest of src/core/billing passes. I'd revert the coercion here and on line 8, and give the breakdown test plain numbers. If the OpStatusBody fixture type objects to numbers there, type that one body as z.input<typeof BillingOpStatusSchema>. That is the shape the lifecycle actually parses, so no cast is needed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9629acb. Money schemas are strict again, and the breakdown regression now uses JSON number inputs.

*/
const cents = z.number().int().safe()

const PlanInfoSchema = zPreviewPlanInfo.extend({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3, Nit. This docblock explained the const cents that used to sit right below it. With cents moved to moneySchemas.ts, it now reads as documentation for PlanInfoSchema, and "so the cents are read as numbers" no longer points at anything. Moving it onto centsSchema in moneySchemas.ts keeps the rationale with the one definition both schemas now share.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the rationale beside centsSchema in 2b5653a.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: one P2 left before approval. The money-parsing and docblock findings are fixed, but this head adds an unrelated #19635 cherry-pick whose AI co-author trailer fails the trailer check.

Since my last review at 8e510b6, three commits landed on the same base, e9a89db:

  • 9629acb sets centsSchema and duration_in_months back to z.number().int().safe() and feeds the breakdown test JSON numbers. The author replied.
  • 2b5653a moves the int64 rationale docblock onto centsSchema. The author replied.
  • b464087 cherry-picks #19635, which deletes a live-fetch test from apps/website/src/config/router-providers.test.ts.

The author answered both of my threads, so I posted no thread replies.

Remaining

  1. P2, inline on the deleted router-providers.test.ts hunk. b464087 is unrelated to this PR and carries Co-authored-by: Cursor Agent. Check for AI agent co-author trailers fails on this head. Drop it here and backport #19635 separately without the trailer.

The account-core and remote-config side is done. Once b464087 is out and CI is green, I have nothing left that blocks.

Findings and where they stand
Coverage

Depth: standard, delta-scoped to 9629acb, 2b5653a, and b464087. Checks at b464087:

  • pnpm typecheck exit 0.
  • vitest run src/core/billing in account-core: 566 passed. With the charge_breakdown override removed, the breakdown row fails (1999n).
  • git log origin/cloud/1.55..HEAD: b464087 is the only commit with a Co-authored-by trailer. #19635 merged to main on 2026-09-30 and is not on cloud/1.55.
  • CI: Check for AI agent co-author trailers failed. typecheck-aux and verify-pack-contents (account-core) passed. typecheck and website-unit were still running when I posted.

)
})

it('counts the models the docs catalog lists', async (ctx) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2. This deletion arrives through b464087, a cherry-pick of #19635, which has nothing to do with the ingest types. It also brings over the original commit's Co-authored-by: Cursor Agent <cursoragent@cursor.com> trailer. The repo's Check for AI agent co-author trailers job fails on this head for that reason ("AI agent Co-authored-by trailers detected in PR commits"), and b464087 is the only commit here with a Co-authored-by line. apps/website/AGENTS.md describes that check as failing the whole PR.

I'd drop b464087 from this branch and backport #19635 to cloud/1.55 as its own PR, with the trailer removed from the cherry-pick message. That keeps this PR to the regen plus its account-core and remote-config follow-through. It also means the next regen push doesn't have to replay an unrelated website change.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped the unrelated #19635 cherry-pick. Current head f1969adad279 contains the ingest update and the capability fixture repairs required by its generated type changes.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: changes requested. The #19635 cherry-pick is gone and the trailer check passes, but the cloud@44b2ac7 regen adds a required can_revert_scheduled_change capability: four builders weren't updated, so account-core and billing-web typecheck are red. The runtime parse also needs a deploy-order answer.

Since my last review at b464087:

  • The branch was rebuilt on cloud/1.55 at f1b9f07; the new base commits are agent backports #19832, #19727, and #19733.
  • The ten account-core and remote-config commits are unchanged (git range-diff shows =).
  • b464087 is dropped, so this addresses my trailer P2, which the author already answered in the thread.
  • The regen, 91cdce7, adds:
    • the revert-scheduled-change endpoint and BillingCapabilities.can_revert_scheduled_change,
    • 'cancelled' on the TaskEntry / TaskResponse / AssetDownloadResponse statuses,
    • CancelTask*.
  • 62c8ed4 is the formatter.
  • f1969ad adds the new key to five capability fixtures.

Pre-merge blockers

  1. P1, inline on zod.gen.ts:2812. Four capability builders still lack can_revert_scheduled_change: billingCapabilities.contract.test.ts:17 and :55, billing-web e2e/fixtures/scenario.ts:36, and src/test/fakeBillingClient.ts:186. typecheck:account-core and typecheck:billing-web exit 2. CI typecheck and verify-pack-contents (account-core) fail.
  2. P1 question, inline on types.gen.ts:4587. capabilities.ts parses capabilities with the generated schema, so a backend that doesn't send the new key makes every capabilities read malformed. Please confirm the deploy order, or default the key to false in CapabilitiesBodySchema.
Earlier findings
Checked and cleared
  • The new 'cancelled' task status: nothing in src/, packages/, or apps/ consumes TaskEntry, TaskResponse, or AssetDownloadResponse outside the generated package, so no switch or mapping misses the new member.
  • RevertScheduledChange* and CancelTask* are new endpoint types with no consumer yet.
Coverage

Depth: standard, delta-scoped to the regen, 62c8ed4, and f1969ad. Checks at f1969ad:

  • pnpm typecheck:app exit 0. pnpm typecheck:account-core exit 2 (TS2741 at :17, TS2344 at :55). pnpm typecheck:billing-web exit 2 (2 errors). typecheck:account-ui, typecheck:billing-contract, and typecheck:browser exit 0.
  • zBillingCapabilities.safeParse on the pre-regen capabilities object: success=false, can_revert_scheduled_change: Required.
  • CI: typecheck and verify-pack-contents (account-core) failed. typecheck-aux and Check for AI agent co-author trailers passed. website-unit was still running when I posted.

can_downgrade_to_personal: z.boolean(),
can_invite_members: z.boolean(),
can_reactivate: z.boolean(),
can_revert_scheduled_change: z.boolean(),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1. The cloud@44b2ac7 regen adds a required can_revert_scheduled_change: boolean to BillingCapabilities. f1969ad updates five fixtures, but four more places still build a capabilities object without the key, so typecheck is red at this head:

  • packages/account-core/src/core/billing/contracts/billingCapabilities.contract.test.ts:17, the capabilities() builder: TS2741, Property 'can_revert_scheduled_change' is missing.
  • The same file at :55, the expectTypeOf<Capabilities>().toEqualTypeOf<{ ... }>() pin: TS2344. The pin is supposed to fail on a regen like this; it just needs the new key.
  • apps/billing-web/e2e/fixtures/scenario.ts:36 (capabilitiesWith): can_revert_scheduled_change?: boolean | undefined is not assignable to BillingCapabilities.
  • apps/billing-web/src/test/fakeBillingClient.ts:186 (capabilitiesSnapshot): same error.

pnpm typecheck:account-core and pnpm typecheck:billing-web both exit 2. CI typecheck and verify-pack-contents (account-core) fail on the first two. typecheck:app, typecheck:browser, typecheck:account-ui, and typecheck:billing-contract pass. Adding can_revert_scheduled_change: false to each of the three builders and to the pin clears them.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in fc67699. The remaining capability builders and compile-time pin now include can_revert_scheduled_change.

/**
* Stripe-billed only; false within 1 hour of the change.
*/
can_revert_scheduled_change: boolean

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1, question on deploy order. This field is also required at runtime, not just in types. capabilities.ts parses GET capabilities through CapabilitiesBodySchema, which embeds the generated zBillingCapabilities. Against a body without the key, zBillingCapabilities.safeParse returns success=false with [["can_revert_scheduled_change","Required"]] (checked at this head). So if cloud/1.55 reaches staging or prod before the backend that emits this field, every capabilities read comes back malformed. Every billing gate that reads capabilities then loses its snapshot, not just the new revert action. That is the same ordering hazard #19670 described for decline_reason, and the field only landed in cloud between 2e53e9f and 44b2ac7.

Is the backend that sends can_revert_scheduled_change already deployed everywhere this frontend will ship? If it isn't, or nobody is sure, I'd make the reader tolerant for this one key: zBillingCapabilities.extend({ can_revert_scheduled_change: z.boolean().default(false) }) in CapabilitiesBodySchema. That fails closed for the new action only, which fits the schema's own "conservative UI guidance" description, and BillingCapabilities stays boolean for consumers.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the fail-closed compatibility path in 7d8ed09. Older responses now default only can_revert_scheduled_change to false; focused capability tests pass 33/33.

github-actions Bot and others added 15 commits October 2, 2026 22:45

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: one P2 left before approval. Both capability findings are fixed and typecheck is green, but the rebase typed #19830's raw placement flag as the generated enum, and the follow-up test fix gets past that type with Reflect.set.

Since my last review at f1969ad:

  • The branch was rebuilt on cloud/1.55 at 40a0284, ten base commits later. One of them is #19830, the free-use placement experiment.
  • git range-diff shows every replayed commit unchanged except b2c89df (the RemoteConfig change). Its conflict resolution dropped #19830's line.
  • Three commits are new:
    • fc67699 adds can_revert_scheduled_change to the remaining capability builders and the contract pin. The author replied.
    • 7d8ed09 defaults that key to false in CapabilitiesBodySchema. The author replied.
    • dcdd347 switches freeUsePlacement.test.ts:43 to Reflect.set to clear the CI typecheck failure.

The author answered both of my capability threads, so I posted no thread replies.

Remaining

  1. P2, inline on types.ts:89 and freeUsePlacement.test.ts:43. RemoteConfig types 'agent-free-use-message-placement' as the generated enum, but the config is stored without validation, and #19830's isFreeUseVariant exists for exactly the unknown values the type rules out. Restore the raw string line, drop the Partial<Pick<...>>, and revert dcdd347. I verified that this combination typechecks.
Earlier findings
Coverage

Depth: standard, delta-scoped to fc67699, 7d8ed09, dcdd347, and the changed replay of b2c89df against the new base. Checks:

  • At 7d8ed09: pnpm typecheck:app exit 2 at freeUsePlacement.test.ts:44. With the suggested types.ts change applied locally, exit 0.
  • At dcdd347: pnpm typecheck:app exit 0. typecheck:account-core, typecheck:billing-web, typecheck:account-ui, typecheck:billing-contract, and typecheck:browser exit 0 (run at 7d8ed09, and dcdd347 changes only the test).
  • vitest run src/core/billing in account-core: 566 passed. freeUsePlacement tests: 4 passed.
  • ESLint on freeUsePlacement.test.ts is clean.
  • CI at dcdd347: typecheck, typecheck-aux, verify-pack-contents (account-core), and Check for AI agent co-author trailers passed, and the rest were still running when I posted.

Comment thread src/platform/remoteConfig/types.ts Outdated
[K in keyof FeaturesResponse as K extends PlacementKey
? never
: K]: FeaturesResponse[K]
} & Partial<Pick<FeaturesResponse, PlacementKey>> & {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2. The rebase onto cloud/1.55 dropped a field the base had just added. #19830 (80673ee) declared 'agent-free-use-message-placement'?: string in this literal. That is the raw wire value, which useFreeUsePlacement checks with isFreeUseVariant and treats as 'control' when it's unknown. The replayed b2c89df removed that line, so the key now comes from Partial<Pick<FeaturesResponse, PlacementKey>> typed as the generated five-arm enum.

The value is never validated at the boundary. commitRemoteConfigSuccess stores the response as-is, so an unknown string can reach remoteConfig while the type says it can't. That is why #19830's it.for([undefined, 'unknown'])('keeps control for %s') row stopped compiling at 7d8ed09, and why dcdd347 now writes it with Reflect.set (see the comment on that line). The honest type is the raw string this literal already uses for hosted_billing_destination and signup_turnstile.

Fix: keep the mapped type that drops the key, remove the Partial<Pick<...>> part, and put #19830's line back:

} & {
    ...
    'agent-in-app-experience'?: boolean
    'agent-free-use-message-placement'?: string

I applied that at 7d8ed09, with the test still using the plain remoteConfig.value = { ... } assignment, and pnpm typecheck:app exited 0. Then dcdd347 can be reverted. This is a deliberate exception to the "don't re-declare an omitted generated field" rule in typescript.md. The field is unvalidated wire data with a validator downstream, so typing it as the contract enum hides the cases that validator handles.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 84c05b3: the placement field is raw optional string data again, while the mapped generated response still excludes its narrower enum type. App typecheck passes.

remoteConfig.value = {
'agent-free-use-message-placement': value
}
Reflect.set(remoteConfig.value, 'agent-free-use-message-placement', value)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2, same root cause as my comment on src/platform/remoteConfig/types.ts:89. Reflect.set writes a value the declared type forbids, which works the same as a cast. AGENTS.md and docs/guidance/typescript.md ask tests to model malformed wire input as data rather than bypass the type to get it in. The test has to do this only because RemoteConfig now types the field as the generated enum. Once the field is back to string, the original remoteConfig.value = { 'agent-free-use-message-placement': value } compiles again, and this commit can be reverted.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 42e61a8: the test models the unknown wire value with the typed remote-config assignment again; the focused suite passes 4/4.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ready to approve. 84c05b3 puts #19830's raw 'agent-free-use-message-placement'?: string back in RemoteConfig, and 42e61a8 reverts the Reflect.set workaround. Every typecheck is green. Two P3 items stay open, and neither blocks.

The author answered both threads from my last review: types.ts and the test. So I posted no thread replies. The mapped type still drops the generated enum for that key, so the placement value has a single type: the raw string isFreeUseVariant checks. freeUsePlacement.test.ts is now identical to cloud/1.55, so this PR no longer touches it.

Still open, not blocking:

  • P3 strict parse of the display-only receipt fields. I'm fine leaving it as is.
  • P3 Nit: previewSubscribe.contract.test.ts:76 still says "so a seventh amount reaches both the coercion rows and the int64 rows", and MONEY_FIELDS has ten entries.
Review record

Commit SHAs below are the ones on the current head. The branch was rebased and replayed several times, so earlier rounds cited other SHAs for the same commits.

Round 1, comments and approval at fc70f56:

Round 2, changes requested at 5c024a1:

Round 3, changes requested at 2ebe00f:

Round 4, ready to approve at 9226516:

Round 6, ready to approve at c8fdd78: no new findings.

Round 7, changes requested at 3a62316:

Round 9, changes requested at eb145b4:

Round 10, changes requested at b89d5e9:

Round 11, one P2 left at 8e510b6:

Round 12, one P2 left at b464087:

Round 13, changes requested at f1969ad:

Round 14, one P2 left at dcdd347:

Rounds 5 and 8 were replays with no change, so I posted nothing.

Checks at 42e61a8:

  • pnpm typecheck exit 0 (app, account-core, billing-web, account-ui, billing-contract), and pnpm typecheck:browser exit 0.
  • vitest run src/core/billing in account-core: 566 passed. freeUsePlacement and src/platform/remoteConfig: 2 files, 28 passed.
  • ESLint and oxfmt --check on src/platform/remoteConfig/types.ts are clean.
  • CI: typecheck, typecheck-aux, lint-and-format, verify-pack-contents (account-core), billing-web-unit-gate, and Check for AI agent co-author trailers succeeded, with no failures so far. test and 15 other jobs were still running when I posted.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on exact head 42e61a8 after self-review, DrJKL’s final ready-to-approve review, and final required CI/browser rollup completion. The two documented P3 follow-ups are non-blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants