Repository navigation
[backport core/1.54] fix(agent): keep the turn live across a socket reconnect - #19696
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1976 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T10:34:47.201Z",
"gitSha": "f4d2c2ed1a099ca95d47481ba1d7fb52f1c7d2e0",
"branch": "backport-18152-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2051.183999999978,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.117999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.9649999999999,
"heapDeltaBytes": 2211020,
"heapUsedBytes": 72768240,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.148999999999998,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1990.4089999999997,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.414,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.004,
"heapDeltaBytes": -7920448,
"heapUsedBytes": 62971688,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 5.704999999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1708.7040000000115,
"styleRecalcs": 75,
"styleRecalcDurationMs": 22.759999999999998,
"layouts": 14,
"layoutDurationMs": 3.786,
"taskDurationMs": 596.0360000000001,
"heapDeltaBytes": 9950592,
"heapUsedBytes": 80260760,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 107.932,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1689.5579999999768,
"styleRecalcs": 74,
"styleRecalcDurationMs": 20.185,
"layouts": 14,
"layoutDurationMs": 3.457,
"taskDurationMs": 504.41400000000004,
"heapDeltaBytes": 6565836,
"heapUsedBytes": 76629300,
"domNodes": -279,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 86.467,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.8580000000097,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.66,
"layouts": 6,
"layoutDurationMs": 0.905,
"taskDurationMs": 208.742,
"heapDeltaBytes": 7948492,
"heapUsedBytes": 82910096,
"domNodes": 78,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 7.057999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.812000000023,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.497,
"layouts": 6,
"layoutDurationMs": 0.9549999999999998,
"taskDurationMs": 201.35699999999997,
"heapDeltaBytes": 4315028,
"heapUsedBytes": 74782016,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 6.841000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 416.5850000000262,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.3069999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 273.324,
"heapDeltaBytes": 17731972,
"heapUsedBytes": 88211284,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 96.197,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 415.5230000000074,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.561,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 274.05800000000005,
"heapDeltaBytes": 17762584,
"heapUsedBytes": 88215432,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 95.797,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2017.6359999999818,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.889000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.96099999999996,
"heapDeltaBytes": 11256544,
"heapUsedBytes": 87407836,
"domNodes": -266,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 19.758,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2009.0730000000008,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.255999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.3070000000001,
"heapDeltaBytes": 5970636,
"heapUsedBytes": 81924500,
"domNodes": -278,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 19.420999999999992,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2156.2390000000278,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.992999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1051.9560000000001,
"heapDeltaBytes": 7633056,
"heapUsedBytes": 85136080,
"domNodes": -268,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 538.7869999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2231.2259999999924,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.331999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1111.001,
"heapDeltaBytes": -8820948,
"heapUsedBytes": 68776116,
"domNodes": -273,
"jsHeapTotalBytes": 1470464,
"scriptDurationMs": 554.3889999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3021.0839999999735,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.113000000000001,
"layouts": 60,
"layoutDurationMs": 12.524000000000001,
"taskDurationMs": 1075.593,
"heapDeltaBytes": 7602776,
"heapUsedBytes": 75832448,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 495.154,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3223.9110000000437,
"styleRecalcs": 64,
"styleRecalcDurationMs": 17.627000000000002,
"layouts": 60,
"layoutDurationMs": 12.533,
"taskDurationMs": 1106.8100000000002,
"heapDeltaBytes": 9517604,
"heapUsedBytes": 76974144,
"domNodes": 10,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 510.93,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2290.4100000000085,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.490999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1237.297,
"heapDeltaBytes": 18344784,
"heapUsedBytes": 86043868,
"domNodes": 8,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 619.104,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2112.835000000018,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.554,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1200.1350000000002,
"heapDeltaBytes": 11638648,
"heapUsedBytes": 81499828,
"domNodes": 8,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 606.0169999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2015.4699999999934,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.578999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.87999999999994,
"heapDeltaBytes": -16658544,
"heapUsedBytes": 88216312,
"domNodes": -267,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 19.590000000000003,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.8869999999783,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.024000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.9,
"heapDeltaBytes": 7529040,
"heapUsedBytes": 86439720,
"domNodes": -269,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 17.672,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.6700000000051,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.616,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 252.52700000000002,
"heapDeltaBytes": 14728232,
"heapUsedBytes": 88088908,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 87.133,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.90400000003956,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.388999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 256.013,
"heapDeltaBytes": 14929424,
"heapUsedBytes": 87511800,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 90.002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1991.2330000000225,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.233,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.575,
"heapDeltaBytes": 7197956,
"heapUsedBytes": 80078716,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 4.923,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.959000000038,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.085999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.262,
"heapDeltaBytes": -8528232,
"heapUsedBytes": 64038364,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 4.8839999999999995,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.3599999999747,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.413999999999998,
"layouts": 18,
"layoutDurationMs": 4.29,
"taskDurationMs": 519.9019999999999,
"heapDeltaBytes": -9604044,
"heapUsedBytes": 62983776,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 74.002,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.4400000000237,
"styleRecalcs": 79,
"styleRecalcDurationMs": 21.207,
"layouts": 18,
"layoutDurationMs": 4.247,
"taskDurationMs": 530.1669999999999,
"heapDeltaBytes": 5502032,
"heapUsedBytes": 78530528,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 74.378,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 800.2539999999954,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.840000000000003,
"layouts": 16,
"layoutDurationMs": 10.038,
"taskDurationMs": 548.9820000000001,
"heapDeltaBytes": 19309744,
"heapUsedBytes": 110059216,
"domNodes": 13831,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 18.048000000000002,
"eventListeners": 2385,
"totalBlockingTimeMs": 68,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8148.150999999984,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.838,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3608.4990000000003,
"heapDeltaBytes": 12994196,
"heapUsedBytes": 89295848,
"domNodes": -264,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 1780.132,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8232.923999999968,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.131,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3512.2299999999996,
"heapDeltaBytes": 12905972,
"heapUsedBytes": 89261868,
"domNodes": -266,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 1735.579,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11057.394999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10236.52,
"heapDeltaBytes": -40547780,
"heapUsedBytes": 184759636,
"domNodes": -8068,
"jsHeapTotalBytes": -11214848,
"scriptDurationMs": 156.37599999999998,
"eventListeners": -14934,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10960.74299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10174.167000000001,
"heapDeltaBytes": -40178388,
"heapUsedBytes": 180000436,
"domNodes": -8069,
"jsHeapTotalBytes": -14430208,
"scriptDurationMs": 143.289,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14116.105000000005,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.340000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13499.677,
"heapDeltaBytes": -54092976,
"heapUsedBytes": 170384676,
"domNodes": -8068,
"jsHeapTotalBytes": -13115392,
"scriptDurationMs": 567.061,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14002.927,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.822,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13400.897,
"heapDeltaBytes": -39286940,
"heapUsedBytes": 180192756,
"domNodes": -8068,
"jsHeapTotalBytes": -13615104,
"scriptDurationMs": 590.6320000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4380.761999999948,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.804,
"layouts": 20,
"layoutDurationMs": 26.146,
"taskDurationMs": 4319.963,
"heapDeltaBytes": -37377828,
"heapUsedBytes": 182289884,
"domNodes": -8068,
"jsHeapTotalBytes": 13619200,
"scriptDurationMs": 70.10300000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 62,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4167.277000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.237,
"layouts": 20,
"layoutDurationMs": 19.540000000000003,
"taskDurationMs": 4007.6730000000007,
"heapDeltaBytes": -38102820,
"heapUsedBytes": 181204080,
"domNodes": -8067,
"jsHeapTotalBytes": 14946304,
"scriptDurationMs": 62.952999999999996,
"eventListeners": -14931,
"totalBlockingTimeMs": 4,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6135.063000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5565.258,
"heapDeltaBytes": 15285604,
"heapUsedBytes": 180633560,
"domNodes": 0,
"jsHeapTotalBytes": -24379392,
"scriptDurationMs": 100.65800000000003,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5424.4169999999485,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5115.124,
"heapDeltaBytes": -1272684,
"heapUsedBytes": 185645392,
"domNodes": 0,
"jsHeapTotalBytes": -27262976,
"scriptDurationMs": 70.76499999999997,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 419.71399999999903,
"styleRecalcs": 16,
"styleRecalcDurationMs": 18.217,
"layouts": 3,
"layoutDurationMs": 0.8200000000000001,
"taskDurationMs": 98.796,
"heapDeltaBytes": 4775032,
"heapUsedBytes": 73665724,
"domNodes": 124,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.809000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 60.61099999999442,
"styleRecalcs": 5,
"styleRecalcDurationMs": 8.216,
"layouts": 2,
"layoutDurationMs": 0.616,
"taskDurationMs": 42.440999999999995,
"heapDeltaBytes": 3031460,
"heapUsedBytes": 72585832,
"domNodes": 102,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.2529999999999997,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 7 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
| // A live `agent_tool_call` frame keys its update on `tool_call_id`, so a | ||
| // restored part uses the same id to match a live frame that arrives for | ||
| // it later. | ||
| callId: toolCallId, |
There was a problem hiding this comment.
🟠 High — zPersistedToolCallSummary is unchanged by this PR and still declares tool_call_id optional, so dropping the ?? id fallback makes callId string | undefined against ToolPart.callId: string, and every historical row recorded before tool_call_id existed keys into parseToolCalls' map under undefined — collapsing all such calls in a row into a single part. Restore the fallback to the required id, or tighten the schema in the same change.
Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case).
| malformedStreamReports.size >= 32 | ||
| ) | ||
| return | ||
| malformedStreamReports.set(turnId, visible) |
There was a problem hiding this comment.
🟡 Medium — The malformedStreamReports.size >= 32 cap was deleted at the same time the key widened from a hasPendingTurn()-validated turn to any message_id string lifted off the wire, so a peer sending malformed frames with a fresh id each time grows this Map without bound and fires a reportError + trackAgentError per frame — the map is only cleared on newChat/loadThread. Line 388 compounds it by forwarding the whole cause.issues array instead of the previous slice(0, 10) projection, which can ship an arbitrarily large (and payload-echoing) context to telemetry. Restore both bounds.
Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, gemini-3.1-pro adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| * reach the continuation that acks. One owner: armed while a send is in | ||
| * flight, consumed exactly once at ack. | ||
| */ | ||
| let sendInFlight = false |
There was a problem hiding this comment.
🟡 Medium — sendInFlight/stopPendingAck are module-level but carry no session or request identity, so the comment's "one owner" invariant does not hold: if a remounted panel sends while the predecessor's POST is still in flight, the new sendMessage wipes the predecessor's stopPendingAck and whichever send settles first clears sendInFlight for both. A Stop clicked in the pre-ack window is then silently dropped, or is consumed by the wrong send and cancels a turn the user did not mean to stop. Key this state to the send that armed it.
Raised by 5 of 8 reviewers (gpt-5.6-sol-max adversarial, gemini-3.1-pro adversarial, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).
| duration_ms: true | ||
| }) | ||
| .safeParse(entry) | ||
| const parsed = zPersistedToolCallSummary.safeParse(entry) |
There was a problem hiding this comment.
🟡 Medium — Both historical-row tolerances in this path were removed while zPersistedToolCallSummary is unchanged and still permits the shapes they covered. Validating the full schema instead of .pick()ing the four fields actually read here lets an unrelated field (a non-RFC3339 started_at/finished_at, say) fail safeParse and silently drop the tool call from a restored transcript, and toolCallOk at line 199 no longer accepts the documented legacy status: 'ok', so historical successes now render as failures. The deleted comments named both risks explicitly.
Raised by 5 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case, claude-opus-5-thinking-max edge-case).
| onAskResolved, | ||
| workflow | ||
| } = deps | ||
| const threadStorageKey = StorageKeys.agentThread(getWorkspaceId()) |
There was a problem hiding this comment.
🟡 Medium — threadStorageKey resolves getWorkspaceId() once at composable construction and is then captured by every read, write and removal of the thread pointer (start, acceptTurn, newChat, loadThread, forgetDeletedThread). A workspace switch that does not recreate the session keeps persisting the new workspace's thread id under the previous workspace's key, so a later visit to that workspace restores and fetches a thread belonging to the other one. Resolve the key at each use, or re-key the session on workspace change.
Raised by 3 of 8 reviewers (kimi-k3-max adversarial, claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial).
| message: AssistantMessage, | ||
| persistedParts: AssistantMessage['parts'] | undefined | ||
| ): void { | ||
| if (persistedParts === undefined) { |
There was a problem hiding this comment.
🟡 Medium — Only undefined preserves the locally streamed parts; an empty persisted array is treated as authoritative, and anchorLocalParts carries over just tabLink/thinking parts. So when fetchTurnOutcome returns { kind: 'terminal', parts: [] } for a terminal row with no content — plausible for an interrupted or error row the backend never filled in — settling erases every text and tool part the user already watched stream in. Treat an empty persisted list the same as undefined.
Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| text: string | ||
| ): NormalizedAgentTranscript['pending'] { | ||
| message.streaming = false | ||
| message.streaming = row.status === 'streaming' |
There was a problem hiding this comment.
🟡 Medium — applyAssistantRow now returns a pending entry for every streaming row rather than only a mid-ask one, while normalizeAgentTranscript keeps the last truthy pending and then forces message.streaming = message === pending?.message. A turn whose rows are e.g. [seq2 streaming, seq3 complete] therefore hydrates as streaming again and gets a live transport nothing will ever feed, and tool parts on any earlier streaming row stay streaming with no transport that can settle them — recovery cannot clear it either, since fetchTurnOutcome answers streaming whenever any row of the turn is non-terminal.
Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
| turnId: promptEditState.value.turnId | ||
| } | ||
| .sort((a, b) => a.seq - b.seq) | ||
| if (rows.some((row) => !isTerminalTurnStatus(row.status))) |
There was a problem hiding this comment.
🟡 Medium — Any non-terminal row collapses to a bare { kind: 'streaming' }, so a pending_ask the server persisted while the socket was down is never merged into the live message: the approval card never renders, the server waits indefinitely for an answer the user cannot give, and every later poll repeats the same outcome. The new fixture adds primePendingAsk()/pendingAskIsPrimed() and serves pending_ask from transcript() for exactly this case, but no spec exercises it.
Raised by 1 of 8 reviewers (gpt-5.6-sol-max adversarial).
| onThreadActivated?.(null) | ||
| boundWorkflowId.value = null | ||
| rememberedWorkflowId = null | ||
| localStorage.removeItem(threadStorageKey) |
There was a problem hiding this comment.
🟢 Low — This removal is unguarded, unlike the sibling 404 path in handleHistoryLoadError, which first checks localStorage.getItem(threadStorageKey) === threadId. Because loadThread now writes the key only after a successful hydrate, the stored id can still name the previously persisted thread when a 404 recovery lands here, so the resume pointer for a thread that still exists gets wiped.
Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| const entries: unknown[] = rawAttachments | ||
| postedNames = entries.filter(isNamedAttachment) | ||
| } | ||
| const names = postedNames ?? refs.map(({ ref }) => ref) |
There was a problem hiding this comment.
🟢 Low — postedNames is [], not undefined, whenever content.attachments is an array containing no plain strings (an empty array, or the legacy object entries the removed parseAttachment used to accept), and [] is not nullish — so the attachment_refs fallback never runs and a row whose refs resolved perfectly well hydrates with no attachments at all. Fall back to refs whenever postedNames is empty.
Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case, claude-opus-5-thinking-max edge-case).
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. This branch copies main's whole post-#18152 versions of four files instead of porting #18152's delta, which pulls in features missing from core/1.54 and breaks typecheck and the unit tests.
I compared this branch, against its merge base 74934bd, with #18152's merged diff (d90c109 against its parent 1519cc0).
What matches: agentTurnSurvivesSocketDrop.spec.ts, the approval spec (renamed to agentApprovalSurvivesSocketDrop.spec.ts on this branch), agentRestClient.ts and its test, and agentTranscript.test.ts carry exactly the source's added and removed lines. agentConversationStore.test.ts has the source's lines with one hunk boundary shifted.
What diverges:
useAgentSession.ts,useAgentSession.test.ts,agentTranscript.ts, andagentConversationStore.tsare byte-identical to their contents at d90c109 onmain. The source changes these files by +223/-26, +752/-90, +14/-24, and +195/-15. Here they change by +933/-331, +1388/-145, +113/-119, and +296/-49. The extra lines are the gap betweencore/1.54andmain's pre-image of these files, about 1,800 lines from roughly two dozen unrelatedmainPRs. Examples include workspace-scoped agent storage (#17765), agent stop and thread-start telemetry (#18665), error surface tags (#19230), the generatedToolCallSummaryschema (#19585), attachment presentation (#19516), and disowned-workflow unbinding (#18280).agentTurnLockFixture.tsalso takesmain's pending-ask transcript support (#18952) on top of the source hunk.- Checks at this head fail. Hosted
typecheckreports about 50 errors. All of them are in these files or in their consumers (AgentPanelRoot.vue,UserMessage.vue), which depend on APIscore/1.54does not have. Hostedtestreports 437 failed out of 22,282. Locally at 897e8f4,vitest runoveruseAgentSession.test.ts,agentTranscript.test.ts, andagentConversationStore.test.tsgives 156 failed and 97 passed. 39 of those failures areTypeError: StorageKeys.agentThread is not a function. Build, lint, and e2e jobs fail downstream.
The inline comments point at representative lines; each one marks a whole class of the same problem. The fix is to cherry-pick #18152's own delta onto core/1.54 and resolve each conflict against the API this branch actually has. Each adaptation should then be named in the description.
| AgentErrorClass, | ||
| AgentErrorMetadata | ||
| AgentErrorMetadata, | ||
| AgentStopClickedMetadata, |
There was a problem hiding this comment.
AgentStopClickedMetadata, AgentStopMethod, AgentThreadStartSource, and AgentWorkflowBindSource do not exist in @/platform/telemetry/types on core/1.54 (TS2305). They belong to main-only agent telemetry and are not part of #18152's diff. Please drop them along with the stop, thread-start, and workflow-bound telemetry calls (trackAgentStopClicked at line 925, trackAgentWorkflowBound at line 334).
There was a problem hiding this comment.
Rebuilt the branch from core/1.54 with only the adapted source hunks in commit 4f1869e. Full typecheck and 258 focused unit tests pass.
| AgentThreadStartSource, | ||
| AgentWorkflowBindSource | ||
| } from '@/platform/telemetry/types' | ||
| import { clearLegacyAgentStorage } from '@/platform/workflow/persistence/base/storageIO' |
There was a problem hiding this comment.
There was a problem hiding this comment.
Rebuilt the branch from core/1.54 with only the adapted source hunks in commit 4f1869e. Full typecheck and 258 focused unit tests pass.
| toTurnId, | ||
| zAgentAdmissionError | ||
| zAgentAdmissionError, | ||
| zDisownedWorkflowError |
There was a problem hiding this comment.
zDisownedWorkflowError is not exported from agentApiSchema on core/1.54, and bindingStore.unbindWorkflow (line 803) does not exist there. This is main's disowned-workflow handling, not #18152.
There was a problem hiding this comment.
Rebuilt the branch from core/1.54 with only the adapted source hunks in commit 4f1869e. Full typecheck and 258 focused unit tests pass.
| return | ||
| malformedStreamReports.set(turnId, visible) | ||
| reportError(new Error('Malformed agent stream event'), { | ||
| surface: 'agent', |
There was a problem hiding this comment.
Rebuilt the branch from core/1.54 with only the adapted source hunks in commit 4f1869e. Full typecheck and 258 focused unit tests pass.
| // A live `agent_tool_call` frame keys its update on `tool_call_id`, so a | ||
| // restored part uses the same id to match a live frame that arrives for | ||
| // it later. | ||
| callId: toolCallId, |
There was a problem hiding this comment.
#18152's change to this file is the streaming row as pending in applyAssistantRow, plus toTurnId. This version also carries #19585's generated ToolCallSummary changes, including dropping the ?? id fallback and narrowing success to 'success'. On core/1.54, zPersistedToolCallSummary still has an optional tool_call_id, so this line fails typecheck (TS2322). Please apply only the #18152 hunks to this branch's version of the file.
There was a problem hiding this comment.
Rebuilt the branch from core/1.54 with only the adapted source hunks in commit 4f1869e. Full typecheck and 258 focused unit tests pass.
| text: string, | ||
| message?: string | ||
| ): void { | ||
| recordSettledReply(turnId, text, [{ type: 'paywall', message }]) |
There was a problem hiding this comment.
PaywallPart on core/1.54 has no message field (TS2353). This is main-only paywall drift that came in with the whole-file copy. #18152's change to this store is liveTurns(), settleTurn(), and their helpers.
There was a problem hiding this comment.
Rebuilt the branch from core/1.54 with only the adapted source hunks in commit 4f1869e. Full typecheck and 258 focused unit tests pass.
| resolvePost({ thread_id: 'th-late', message_id: 'msg-late' }) | ||
|
|
||
| await expect(send).resolves.toBe(false) | ||
| expect(localStorage.getItem(StorageKeys.agentThread('personal'))).toBeNull() |
There was a problem hiding this comment.
The test file is also main's full post-image. It uses StorageKeys.agentThread, which accounts for the 39 TypeError: StorageKeys.agentThread is not a function failures, and the trackAgentStopClicked mock (line 273). It also carries other main-only cases. Please carry #18152's test additions, (g3) through (g22) and the un-failed pins, and adapt only the assertions that depend on a missing target API.
There was a problem hiding this comment.
Rebuilt the branch from core/1.54 with only the adapted source hunks in commit 4f1869e. Full typecheck and 258 focused unit tests pass.
| AgentCancelAccepted, | ||
| AgentError, | ||
| AgentMessage, | ||
| AgentPendingAsk, |
There was a problem hiding this comment.
There was a problem hiding this comment.
Rebuilt the branch from core/1.54 with only the adapted source hunks in commit 4f1869e. Full typecheck and 258 focused unit tests pass.
There was a problem hiding this comment.
Removed the unavailable pending-ask fixture hooks in commit 2205c1d. The browser-test typecheck now passes.
Port the source PR hunks onto the 1.54 APIs without main-only storage, telemetry, schema, paywall, or fixture dependencies. Addresses #19696 (review)
897e8f4 to
4f1869e
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. The new head is now a real port of #18152 and fixes the whole-file copy, but three spots diverge from the source without a target reason.
I compared this branch, at 2205c1d against its merge base 74934bd, with #18152's merged diff (d90c109 against its parent 1519cc0). The branch merges cleanly into the current core/1.54 tip, 84219de.
What matches:
- Five files carry exactly the source's added and removed lines: both browser specs,
agentRestClient.tsand its test, andagentTranscript.test.ts.agentConversationStore.test.tshas the source's lines with one hunk boundary shifted. - These adaptations account for something
core/1.54lacks:- In
agentConversationStore.ts, the target's inline hydrated-copy check is extracted intoremoveHydratedCopy. That helper is identical tomain's, which came from #17730 and is not on 1.54. #18152's new code calls it. - In
agentTurnLockFixture.ts, the persisted streaming row omitspending_ask: this.pendingAsk, because the fixture's pending-ask state (#18952) is not on 1.54. - The unscoped
THREAD_STORAGE_KEYreplacesStorageKeys.agentThread(), and(g15)asserts that key.onThreadActivated?.(null)andturnStartedAt.clear()are dropped, and the recoveryreportErroromitssurface. All of these aremain-only APIs.
- In
- All 22 source test additions are present, and the pins are un-failed.
- At 2205c1d:
vitest runoveruseAgentSession.test.ts,services/agent/, andstores/agent/passed 474/474 across 20 files, andvue-tsc --noEmitpassed. When I posted, 71 hosted checks had passed, none had failed, and 4 were still running.
What diverges is inline.
| import type { LiveTurn } from '../../stores/agent/agentConversationStore' | ||
| import { useAgentConversationStore } from '../../stores/agent/agentConversationStore' | ||
| import { useAgentWorkflowTabBindingStore } from '../../stores/agent/agentWorkflowTabBindingStore' | ||
| import type { WorkflowReference } from '../../types/workflowReference' |
There was a problem hiding this comment.
This is about line 47, just outside this hunk. #18152 changes export interface SessionNotice to interface SessionNotice, and this branch keeps the export. Nothing on core/1.54 imports SessionNotice from outside useAgentSession.ts, so the target needs no change here. Please carry the un-export.
| }) | ||
| } | ||
|
|
||
| function applyActiveTabEvent( |
There was a problem hiding this comment.
#18152 only changes how the stop gate is reached: the inline promptEditState check becomes markStoppedTurnReady({...}) from the agent_message_done path. On core/1.54 the smallest equivalent is to replace the inline check in the default: branch of the existing switch (event.type) with that call. This branch instead rewrites the switch into a single conversationStore.ingest(event) plus a new applyActiveTabEvent helper, and adds an AgentWsEvent import for it. That refactor is behavior-preserving as far as I can tell, but it is not in the source, not on main, which inlines the active-tab branch, and not needed by the target. Please keep the target's switch and change only the stop gate.
| * running message. `isLive` is true only when this row is the one that will | ||
| * be handed a live `AgentEventTransport` (the run_approval mid-ask case), so | ||
| * its still-in-flight tool parts may legitimately stay `streaming`. | ||
| * running message. `isLive` is true when this row will be handed a live |
There was a problem hiding this comment.
#18152 also edits the toolCallPartState doc comment, at line 156 here, which is just outside the hunks. It changes "only isLive (the row is the one actively backed by a live transport — the run_approval mid-ask case) keeps it streaming" to "(the row is backed by a live transport)", because after this change every still-streaming row is live, not just the mid-ask one. This branch takes the matching edit here but leaves line 156 claiming isLive is only the mid-ask case, which is no longer true. Please apply the source's wording there too.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #19696 +/- ##
===========================================
Coverage 84.17% 84.18%
===========================================
Files 2112 2113 +1
Lines 126575 126811 +236
Branches 34051 34123 +72
===========================================
+ Hits 106547 106754 +207
- Misses 19842 19871 +29
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Addresses review feedback: #19696 (comment)
Addresses review feedback: #19696 (comment)
Addresses review feedback: #19696 (comment)
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #18152 to core/1.54, with each adaptation accounted for by the target.
I compared this branch, at c10202e against its merge base 74934bd, with #18152's merged diff (d90c109 against its parent 1519cc0). The branch merges cleanly into the current core/1.54 tip, 84219de.
The three new commits resolve my earlier comments:
- 77e838e carries the
SessionNoticeun-export. - 7be27a1 keeps the target's
switch (event.type)and changes only the stop gate tomarkStoppedTurnReady({...}). - c10202e drops the run_approval mid-ask restriction from the
toolCallPartStatedoc comment.
Five files carry exactly the source's added and removed lines: both browser specs, agentRestClient.ts and its test, and agentTranscript.test.ts. agentConversationStore.test.ts has the source's lines with one hunk boundary shifted.
Adaptations:
- In
agentConversationStore.ts, the target's inline hydrated-copy check is extracted intoremoveHydratedCopy. That helper is identical tomain's, which came from #17730 and is not on 1.54. #18152's new code calls it. - In
agentTurnLockFixture.ts, the persisted streaming row omitspending_ask: this.pendingAsk, because the fixture's pending-ask state (#18952) is not on 1.54. - In
useAgentSession.ts, the unscopedTHREAD_STORAGE_KEYreplacesStorageKeys.agentThread(), and(g15)asserts that key.onThreadActivated?.(null)andturnStartedAt.clear()are dropped, and the recoveryreportErroromitssurface. All of these aremain-only APIs. - In
useAgentSession.ts, the stop-gate change is applied to the target'sswitchrather thanmain'shandleMessageDone. - In
agentTranscript.ts, thetoolCallPartStatecomment edit is applied to this branch's older wording of that comment.
All 22 source test additions are present, and the pins are un-failed.
Checks: at c10202e, vitest run over useAgentSession.test.ts, services/agent/, and stores/agent/ passed 474/474 across 20 files, and vue-tsc --noEmit passed. All hosted checks at this head passed.
Manual backport of #18152 after the automated cherry-pick conflicted. Preserves active Agent turns across transient socket disconnects and reconciles them from persisted REST history.\n\nOriginal: #18152