Repository navigation
FE-3129 feat(billing): gate Members credit limits behind their own flag - #19641
Conversation
billing_control_enabled gated both the team lifecycle banners and the Members credit column + Set credit limit action. The limit is not persisted yet (FE-1278), so move the Members surfaces behind member_credit_limits_enabled (default off) and let billing_control_enabled ramp with the banners only. Also add Storybook states for the scheduled plan change and Enterprise ending banners, and fix the useWorkspaceUI Storybook mock missing canReactivatePlan, which broke the Ending stories.
🎭 Playwright: ✅ 2160 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 836aea2c94a19e8be49abd1e631e7864e5ed9bde
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10.1 MB gzip 🔴 +373 kBDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.73 kB) • 🔴 +38 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.43 MB) • 🔴 +32.3 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 124 kB) • 🔴 +9.61 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 643 kB (baseline 621 kB) • 🔴 +21.7 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 39.4 kB (baseline 27.8 kB) • 🔴 +11.6 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +691 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 150 kB (baseline 117 kB) • 🔴 +32.9 kBReusable component library chunks
Status: 17 added / 15 removed Data & Services — 4.1 MB (baseline 3.6 MB) • 🔴 +494 kBStores, services, APIs, and repositories
Status: 15 added / 16 removed Utilities & Hooks — 582 kB (baseline 559 kB) • 🔴 +23.6 kBHelpers, composables, and utility bundles
Status: 32 added / 31 removed / 5 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -689 kBExternal libraries and shared vendor chunks
Status: 14 added / 14 removed / 4 unchanged Other — 18 MB (baseline 16.4 MB) • 🔴 +1.57 MBBundles that do not match a named category
Status: 183 added / 175 removed / 121 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T17:17:20.444Z",
"gitSha": "fb2b5f70acb25d1519ce486f67c41959044ffb93",
"branch": "jaewon/fe-3129-split-members-credit-limit-surfaces-off",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.1840000000147,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.314,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.90600000000006,
"heapDeltaBytes": -34193260,
"heapUsedBytes": 64429428,
"domNodes": -228,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.743,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.8870000000725,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.561,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.0030000000001,
"heapDeltaBytes": -236412,
"heapUsedBytes": 65969328,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.927000000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1833.4710000000314,
"styleRecalcs": 75,
"styleRecalcDurationMs": 21.128,
"layouts": 12,
"layoutDurationMs": 4.64,
"taskDurationMs": 735.718,
"heapDeltaBytes": -16622004,
"heapUsedBytes": 62728976,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.65,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1934.0409999999792,
"styleRecalcs": 73,
"styleRecalcDurationMs": 21.572,
"layouts": 12,
"layoutDurationMs": 5.187,
"taskDurationMs": 993.22,
"heapDeltaBytes": -21496252,
"heapUsedBytes": 77458332,
"domNodes": -228,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 193.55700000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66551724137931,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.9930000000031,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.425,
"layouts": 6,
"layoutDurationMs": 1.273,
"taskDurationMs": 362.94000000000005,
"heapDeltaBytes": -18185808,
"heapUsedBytes": 80321980,
"domNodes": 53,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 12.716999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.9630000000652,
"styleRecalcs": 33,
"styleRecalcDurationMs": 11.259,
"layouts": 6,
"layoutDurationMs": 1.387,
"taskDurationMs": 337.858,
"heapDeltaBytes": -18270240,
"heapUsedBytes": 80560888,
"domNodes": 53,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.296999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 739.4479999999817,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.052,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.119,
"heapDeltaBytes": 18682796,
"heapUsedBytes": 97378156,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 170.61700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 752.6889999999185,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9159999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.56800000000004,
"heapDeltaBytes": -1752728,
"heapUsedBytes": 97150348,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 180.795,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1161.1330000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 826.285,
"heapDeltaBytes": 9634676,
"heapUsedBytes": 85730652,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 70.65500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 546,
"frameDurationMs": 35.351515151515166,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1249.9200000000883,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 935.604,
"heapDeltaBytes": 9674412,
"heapUsedBytes": 85663124,
"domNodes": 0,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 79.31700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 610,
"frameDurationMs": 36.76470588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 863.4509999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.23099999999954,
"heapDeltaBytes": -16307392,
"heapUsedBytes": 69450364,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 171.90399999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 894.3140000000085,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.1080000000006,
"heapDeltaBytes": 14273868,
"heapUsedBytes": 90020128,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 184.26399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 238,
"frameDurationMs": 24.997222222222213,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11050.86399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10067.715999999999,
"heapDeltaBytes": -1294340,
"heapUsedBytes": 79324028,
"domNodes": 0,
"jsHeapTotalBytes": -14942208,
"scriptDurationMs": 8322.619,
"eventListeners": 0,
"totalBlockingTimeMs": 1508,
"frameDurationMs": 33.483636363636364,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10817.649999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9899.111,
"heapDeltaBytes": 2951264,
"heapUsedBytes": 78360852,
"domNodes": 0,
"jsHeapTotalBytes": -6291456,
"scriptDurationMs": 8392.753,
"eventListeners": 0,
"totalBlockingTimeMs": 1683,
"frameDurationMs": 35.6970297029703,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10744.085000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9800.177,
"heapDeltaBytes": 11233300,
"heapUsedBytes": 92084756,
"domNodes": 0,
"jsHeapTotalBytes": -8650752,
"scriptDurationMs": 8138.008999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 1370,
"frameDurationMs": 32.873394495412846,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10269.175000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9393.378,
"heapDeltaBytes": -703828,
"heapUsedBytes": 80238248,
"domNodes": 0,
"jsHeapTotalBytes": -13107200,
"scriptDurationMs": 7930.298000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1445,
"frameDurationMs": 34.68310810810811,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2036.0029999999938,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.984000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.2479999999999,
"heapDeltaBytes": -35679548,
"heapUsedBytes": 83623372,
"domNodes": -228,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 33.884,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2046.9600000000128,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.995000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.1260000000001,
"heapDeltaBytes": -35229200,
"heapUsedBytes": 83622020,
"domNodes": -228,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 41.10599999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80245901639344,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2466.1910000000375,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.066,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1640.5939999999998,
"heapDeltaBytes": -38011376,
"heapUsedBytes": 83153976,
"domNodes": -228,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 852.297,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77959183673469,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2510.5139999999437,
"styleRecalcs": 66,
"styleRecalcDurationMs": 9.753000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1542.2150000000001,
"heapDeltaBytes": 23173324,
"heapUsedBytes": 86589776,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 875.1750000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66622516556291,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3732.9709999999636,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.667,
"layouts": 60,
"layoutDurationMs": 13.963999999999999,
"taskDurationMs": 1723.5510000000002,
"heapDeltaBytes": 12503396,
"heapUsedBytes": 76996272,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 817.509,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4055.1060000000234,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.451999999999998,
"layouts": 60,
"layoutDurationMs": 15.391,
"taskDurationMs": 1926.6089999999997,
"heapDeltaBytes": 10671004,
"heapUsedBytes": 74887544,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 903.3679999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665843621399176,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3101.8569999999954,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.697999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1900.64,
"heapDeltaBytes": 26107932,
"heapUsedBytes": 91081136,
"domNodes": -228,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 965.3009999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756521739130427,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3183.029999999917,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.354000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2069.7479999999996,
"heapDeltaBytes": 1348180,
"heapUsedBytes": 65241180,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1089.442,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84308510638298,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2013.4390000000053,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.2489999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.41400000000004,
"heapDeltaBytes": 21519296,
"heapUsedBytes": 84369340,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.336000000000006,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2018.0540000000065,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.695000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.984,
"heapDeltaBytes": 20969208,
"heapUsedBytes": 84454132,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.462999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.8449999999789,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.238,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.887,
"heapDeltaBytes": 13317976,
"heapUsedBytes": 93769684,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 148.08599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 665.4419999999845,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.1240000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.835,
"heapDeltaBytes": 13391648,
"heapUsedBytes": 93984724,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 153.91299999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2014.237000000037,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.688,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.766,
"heapDeltaBytes": -15222968,
"heapUsedBytes": 65252136,
"domNodes": -244,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 7.615,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2056.43699999996,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.195000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.2239999999999,
"heapDeltaBytes": -2181080,
"heapUsedBytes": 78002676,
"domNodes": -244,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 13.462000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.5610000000183,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.509,
"layouts": 16,
"layoutDurationMs": 5.604,
"taskDurationMs": 772.066,
"heapDeltaBytes": -21453904,
"heapUsedBytes": 59723136,
"domNodes": -244,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 111.30199999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1793.7309999999798,
"styleRecalcs": 76,
"styleRecalcDurationMs": 21.625,
"layouts": 16,
"layoutDurationMs": 5.611,
"taskDurationMs": 838.965,
"heapDeltaBytes": -20043628,
"heapUsedBytes": 60753092,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 122.57499999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.9009999999444,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.8,
"layouts": 5,
"layoutDurationMs": 13.615000000000002,
"taskDurationMs": 1018.575,
"heapDeltaBytes": 23252996,
"heapUsedBytes": 105217196,
"domNodes": 13667,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 34.605,
"eventListeners": 2383,
"totalBlockingTimeMs": 152,
"frameDurationMs": 19.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8756.394,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.757999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5744.758,
"heapDeltaBytes": -36126856,
"heapUsedBytes": 83429632,
"domNodes": -228,
"jsHeapTotalBytes": 94208,
"scriptDurationMs": 2833.038,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.729885057471265,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10084.69100000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6445.438999999999,
"heapDeltaBytes": -29238236,
"heapUsedBytes": 90358916,
"domNodes": -228,
"jsHeapTotalBytes": 356352,
"scriptDurationMs": 3066.673,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666003316749585,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12902.837999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12251.846999999998,
"heapDeltaBytes": -38073780,
"heapUsedBytes": 186136880,
"domNodes": -3046,
"jsHeapTotalBytes": 11845632,
"scriptDurationMs": 226.011,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.67983193277311,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 16706.074999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16270.268000000002,
"heapDeltaBytes": -23499008,
"heapUsedBytes": 162631772,
"domNodes": -8049,
"jsHeapTotalBytes": -24379392,
"scriptDurationMs": 253.44099999999997,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.252536231884054,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 21409.499000000098,
"styleRecalcs": 151,
"styleRecalcDurationMs": 20.059999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21268.05,
"heapDeltaBytes": -32567896,
"heapUsedBytes": 168673076,
"domNodes": -3046,
"jsHeapTotalBytes": 6295552,
"scriptDurationMs": 929.1600000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 52,
"frameDurationMs": 41.7785575048733,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 21218.19599999992,
"styleRecalcs": 171,
"styleRecalcDurationMs": 18.12500000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20816.609,
"heapDeltaBytes": -21860756,
"heapUsedBytes": 191640932,
"domNodes": -3042,
"jsHeapTotalBytes": 14086144,
"scriptDurationMs": 960.4499999999999,
"eventListeners": -14905,
"totalBlockingTimeMs": 95,
"frameDurationMs": 38.68448905109489,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6448.7870000000385,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.59900000000003,
"layouts": 20,
"layoutDurationMs": 26.08300000000001,
"taskDurationMs": 6410.207,
"heapDeltaBytes": -14226404,
"heapUsedBytes": 173769128,
"domNodes": -8049,
"jsHeapTotalBytes": 17563648,
"scriptDurationMs": 118.62000000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 435,
"frameDurationMs": 38.62155688622754,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6308.046999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.63200000000002,
"layouts": 20,
"layoutDurationMs": 24.040000000000006,
"taskDurationMs": 6207.205,
"heapDeltaBytes": 1216292,
"heapUsedBytes": 212497972,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 118.19,
"eventListeners": 0,
"totalBlockingTimeMs": 478,
"frameDurationMs": 37.498214285714276,
"p95FrameDurationMs": 66.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8996.988999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8885.2,
"heapDeltaBytes": -65922496,
"heapUsedBytes": 170295808,
"domNodes": -3046,
"jsHeapTotalBytes": 4968448,
"scriptDurationMs": 152.744,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.55,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8773.531000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8529.335,
"heapDeltaBytes": -48622736,
"heapUsedBytes": 168237100,
"domNodes": -3045,
"jsHeapTotalBytes": 2301952,
"scriptDurationMs": 217.24499999999992,
"eventListeners": -14915,
"totalBlockingTimeMs": 31,
"frameDurationMs": 30.5445993031359,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 526.9530000000486,
"styleRecalcs": 24,
"styleRecalcDurationMs": 27.306000000000004,
"layouts": 5,
"layoutDurationMs": 2.691,
"taskDurationMs": 187.574,
"heapDeltaBytes": -14460240,
"heapUsedBytes": 82652940,
"domNodes": 129,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 19.738,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 120.23699999997461,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.064,
"layouts": 3,
"layoutDurationMs": 1.4459999999999997,
"taskDurationMs": 97.141,
"heapDeltaBytes": -16739932,
"heapUsedBytes": 80041580,
"domNodes": 113,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.631000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66249999999991,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 878.0100000000175,
"styleRecalcs": 78,
"styleRecalcDurationMs": 106.907,
"layouts": 76,
"layoutDurationMs": 26.627000000000002,
"taskDurationMs": 845.2420000000001,
"heapDeltaBytes": 17379036,
"heapUsedBytes": 89440968,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 339.914,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664150943396223,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1097.627999999986,
"styleRecalcs": 78,
"styleRecalcDurationMs": 126.163,
"layouts": 76,
"layoutDurationMs": 32.330999999999996,
"taskDurationMs": 1079.896,
"heapDeltaBytes": 19966072,
"heapUsedBytes": 91958076,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 466.89000000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66567164179105,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1363.207999999986,
"styleRecalcs": 78,
"styleRecalcDurationMs": 238.76,
"layouts": 76,
"layoutDurationMs": 28,
"taskDurationMs": 1344.3850000000002,
"heapDeltaBytes": 8838748,
"heapUsedBytes": 115760272,
"domNodes": 76,
"jsHeapTotalBytes": 6848512,
"scriptDurationMs": 457.183,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.520512820512803,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1406.1470000000327,
"styleRecalcs": 78,
"styleRecalcDurationMs": 252.5,
"layouts": 76,
"layoutDurationMs": 30.58,
"taskDurationMs": 1386.0919999999999,
"heapDeltaBytes": -18700400,
"heapUsedBytes": 111181424,
"domNodes": 76,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 461.132,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.916250000000012,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (9)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughChangesWorkspace billing UI
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The credit-limit UI remains off unless its dedicated flag is enabled, and the supplied tests cover its separation from billing controls. No merge-blocking issue is identified. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The split lets billing notices roll out without exposing unfinished credit-limit controls. Existing owner and member-management permissions remain, and missing or invalid flag values disable the new controls. Risk is low, but server rollout behavior and dialog cleanup during identity or workspace changes are not fully verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #19641 +/- ##
==========================================
+ Coverage 84.46% 85.19% +0.73%
==========================================
Files 3341 2355 -986
Lines 161168 135204 -25964
Branches 41915 34499 -7416
==========================================
- Hits 136131 115192 -20939
+ Misses 23141 19648 -3493
+ Partials 1896 364 -1532
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 992 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
- The dedicated flag cleanly separates unfinished Member credit-limit controls from the billing-banner ramp.
- Missing or non-boolean values fail closed, and the tests pin both the new flag and the old flag's non-effect.
Full context for agent readers
Reviewed the feature-flag resolution, telemetry exposure, Members menu and credits-column gates, their focused tests, and the Storybook mock repair. The current head is thread-free, mergeable, and settled green. The new surface remains disabled until the backend delivers member_credit_limits_enabled, so this does not expose the non-persistent credit-limit control during the billing-banner rollout.
|
|
…d renewals (Comfy-Org#19677) ## Summary Show the Subscription paused copy for `payment_failed` renewals instead of "update payment to avoid a pause", and give the member Subscription paused banner the informational (grey) icon. ## Why `v1_payment_recovery` went to 100% in prod today, so this banner is live. For a `payment_failed` renewal the run button is already locked (`CloudRunButtonWrapper` locks on `payment_failed` regardless of the flag), yet the settings banner says "Update payment to avoid a pause", which describes a warning stage that does not exist. Per design review (Alex), until BE-6970 records failed renewals as `paused`, `payment_failed` should read as paused. About 850 workspaces are in `payment_failed` today. ## Root cause The banner copy for `payment_failed` was written for a dunning model where a failed payment is a warning before a pause. The backend never set `paused` on renewal failure (BE-6970), so `payment_failed` is the blocked state in practice, and the copy disagrees with the run lock. ## Changes - **What**: - `paymentFailedView` reuses `pausedView` (title, body, Update payment) and keeps Pay invoice when a hosted https invoice URL exists. - Paused member banner is muted (grey circle-alert), matching the design reference; owner stays amber. - Removes the now-unused `billingStatus.warning` strings and the invoice amount formatting (Stripe decimal tables) that only fed that copy. - Who sees it is unchanged: `payment_failed` is still owner-only. ## Review Focus - Temporary mapping, tied to BE-6970 in a one-line comment. When failed renewals arrive as `paused`, `payment_failed` stops being the blocked state and this can be revisited. - No E2E added: this is copy and icon selection inside the settings banner, driven by billing state that Playwright cannot put a real workspace into; `BillingStatusBanner.test.ts` covers the payment_failed copy and actions. - Design reference: [Subscription paused, owner](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7186-30645), [member](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7186-30669). ## Plan position | # | Step | Status | |---|------|--------| | 1 | Ramp `v1_payment_recovery` to 100% | done | | **2** | **Payment failed reads as paused; member paused icon grey (this PR)** | **this PR** | | 3 | Split Members credit limits off `billing_control_enabled` (Comfy-Org#19641) | in review | | 4 | `billing_control_enabled` banner copy/roles per design review | next | | 5 | New "Plan ended" banner + Members footer | after 4 | | 6 | Ramp `billing_control_enabled`, then remove both gates | after 3-5 | ```mermaid flowchart LR A[1 ramp v1_payment_recovery] --> B[2 payment_failed copy - this PR]:::me C[3 split flags Comfy-Org#19641] --> D[4 banner copy fixes] D --> F[6 ramp + remove gates] E[5 Plan ended banner] --> F B --> F classDef me fill:#3b5bdb,color:#fff ``` ## Screenshots **AS IS** — `payment_failed`, owner: "Payment failed … update payment to avoid a pause". Paused member: amber icon. Captured from Storybook (`DISTRIBUTION=cloud`): real banner logic, demo billing data. `payment_failed`, owner (old): <img width="900" alt="AS IS payment_failed owner" src="https://github.com/user-attachments/assets/6c46c7dc-99ae-4f75-b3a8-d2c93157e236" /> Paused, member (old): <img width="900" alt="AS IS paused member" src="https://github.com/user-attachments/assets/d8bf876f-cfc5-4db9-9ad3-7127bd8e621c" /> **TO BE** — `payment_failed`, owner: "Subscription paused … Update payment to resume". Paused member: grey icon. `payment_failed`, owner (new): <img width="900" alt="TO BE payment_failed owner" src="https://github.com/user-attachments/assets/36cbf1db-c745-44e7-a74b-b776aecfd253" /> Paused, member (new): <img width="900" alt="TO BE paused member" src="https://github.com/user-attachments/assets/deedd2e7-4c1d-4f8d-8568-e192fa0bcd72" /> - Fixes FE-3135
Comfy-Org#19680) ## Summary Bring the `billing_control_enabled` banners in line with the design review before the flag ramps: copy, roles, actions, and dates now match the [Billing banners reference](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7186-30627). Rebased on main after Comfy-Org#19677 merged. ## Why `billing_control_enabled` is still 0% in prod. Design reviewed the built banners (Slack rollout thread) and asked for these changes before it ramps. The amber/grey split was confirmed as is. ## Changes - **What**: - **Out of credits**: shorter copy ("Add more credits or wait until credits refill on {date}"). Members get "Ask your workspace owner…" instead of "admins". An owner who can't buy credits gets no banner; that only happens once the plan has ended, and the upcoming Plan ended banner covers it. - **Plan ending**: the button is now "Resume plan", and the body says "…keep your team's shared credits" with no mention of seats. Members now see the banner too, reading "You can run workflows until then." with no action. - **Scheduled plan change**: owner-only, as in the reference. It gains Dismiss, which lasts the session (shared state, like the out-of-credits dismissal). The title ends with a period, per the reference. - **Enterprise plan ending**: owners get **Contact sales**, which opens `ENTERPRISE_URL`. Members now see the banner too, reading "You can run workflows until then." - **Payment failed, members**: members now get the paused member banner ("Ask your workspace owner to restore the workspace's subscription.", grey icon, no actions), since their runs are blocked too. Requested by design after Comfy-Org#19677. - **Dates**: full month and year everywhere ("October 1, 2026"). The out-of-credits refill date and the scheduled change date used short forms. - Storybook: drops `OutOfCreditsSelfServe` and adds `EndingMember` and `EndingEnterpriseMember`. ## Review Focus - Role changes live in `deriveBillingBanner`. Ending (team and Enterprise) no longer requires `canManage`, and plan change now requires it. The view picks owner or member copy. - Not done, on purpose: - The reference's plan change body ("We'll automatically charge $X to your card on file") needs the upcoming charge amount. The client has only the target plan slug, and deriving a price from the catalog would miss proration and tax. That needs the backend to return the amount on the scheduled change, so the current body stays. - **Stay on {plan}** waits on BE-10873. - `UnifiedPricingTable.test.ts > prompts free-tier users to subscribe` fails locally on clean `main` too ("INTERNAL ASSERTION FAILED: Expected a class definition"), so it's unrelated to this PR. - No E2E added. These are banner copy and role rules driven by billing states Playwright can't put a real workspace into. `deriveBillingBanner.test.ts` and `BillingStatusBanner.test.ts` cover each case. ## Plan position | # | Step | Status | |---|------|--------| | 1 | Ramp `v1_payment_recovery` to 100% | done | | 2 | Split Members credit limits off `billing_control_enabled` (Comfy-Org#19641) | merged | | 3 | Payment failed reads as paused (Comfy-Org#19677) | merged | | **4** | **Banner copy/roles per design review (this PR)** | **this PR** | | 5 | New "Plan ended" banner + Members footer | next | | 6 | Ramp `billing_control_enabled`, then remove both gates | after 4-5 | ```mermaid flowchart LR B[2 split flags Comfy-Org#19641] --> D[4 design review - this PR]:::me C[3 payment_failed copy Comfy-Org#19677] --> D D --> E[5 Plan ended banner] E --> F[6 ramp + remove gates] classDef me fill:#3b5bdb,color:#fff ``` ## Screenshots **AS IS** See table below (left column). **TO BE** Captured from Storybook (`Platform/Workspace/BillingStatusBanner`) with demo billing data. | State | AS IS | TO BE | |---|---|---| | Out of credits (owner) | <img width="480" alt="asis-out-of-credits-owner" src="https://github.com/user-attachments/assets/4fbdd77c-57c4-4e3f-944d-a9aa2fccc82d" /> | <img width="480" alt="tobe-out-of-credits-owner" src="https://github.com/user-attachments/assets/eb4397b6-fd6e-4802-b1e8-06f1f1ca04b9" /> | | Out of credits (member) | <img width="480" alt="asis-out-of-credits-member" src="https://github.com/user-attachments/assets/46fea3ac-5527-4fd9-9062-e28dbfe57f0e" /> | <img width="480" alt="tobe-out-of-credits-member" src="https://github.com/user-attachments/assets/24e86885-cd41-49a4-af55-ea56ed6c6023" /> | | Out of credits (self-serve) | <img width="480" alt="asis-out-of-credits-self-serve" src="https://github.com/user-attachments/assets/275fd8db-dec1-4830-867d-848ad8013a28" /> | Variant removed (no banner) | | Plan ending (owner) | <img width="480" alt="asis-ending-owner" src="https://github.com/user-attachments/assets/b0ad8743-d7b4-4cd1-b0a1-80cb278396de" /> | <img width="480" alt="tobe-ending-owner" src="https://github.com/user-attachments/assets/84ecbf66-2cf2-46f1-9283-20704351dc3e" /> | | Plan ending (member) | No banner (members were not shown one; no story in base) | <img width="480" alt="tobe-ending-member" src="https://github.com/user-attachments/assets/be0d6730-5ca8-4ac7-9383-2dca653553af" /> | | Scheduled plan change (owner) | <img width="480" alt="asis-plan-change-owner" src="https://github.com/user-attachments/assets/035f0192-d0e9-44ad-8f61-c850d656ca03" /> | <img width="480" alt="tobe-plan-change-owner" src="https://github.com/user-attachments/assets/a2a208db-4e98-457a-9d79-90363cb84b64" /> | | Enterprise ending (owner) | <img width="480" alt="asis-ending-enterprise-owner" src="https://github.com/user-attachments/assets/ac90ddaf-c473-402f-ad4b-c26d595ecda7" /> | <img width="480" alt="tobe-ending-enterprise-owner" src="https://github.com/user-attachments/assets/0a665c5d-c514-4ca5-983e-0c7e64d26e57" /> | | Enterprise ending (member) | No banner (members were not shown one; no story in base) | <img width="480" alt="tobe-ending-enterprise-member" src="https://github.com/user-attachments/assets/01eae6fe-d2b1-413e-ae8c-691c9db7b1a2" /> | - Fixes FE-3138
…y-Org#19682) ## Summary Add a **Plan ended** state to the workspace billing banner. It shows on every workspace tab, for team and Enterprise plans, to owners and members, and it ships without the billing control flag. The Members footer now explains why invites are closed, and it can't be dismissed. The Members-only ended banner (Comfy-Org#19455) stays for now and is retired in a follow-up once this is live, per the FE-3136 rollout. Stacked on Comfy-Org#19680. Review only the top commit until it merges. ## Why When a plan ends today, only the Members page says so (Comfy-Org#19455), and only to owners. Every other tab looks normal, so members hit a locked run button with no explanation. Design review asked for one ended banner in the shared banner slot, with a route back from any tab. ## Changes - **What**: - `usePlanEnded` holds the existing plan-ended rules, moved out of `useMembersPanel` unchanged (`subscription_status` `ended`, or cancelled with access closed, on a team or sales-managed tier). The banner and the Members page now read the same rules. - `deriveBillingBanner` gains `planEnded`. It ranks paused > paymentFailed > **planEnded** > outOfCredits > ending > planChange, and is not gated on `billing_control_enabled`. - Banner copy and actions per the reference, all with the grey icon and Dismiss (lasts the session): | Plan | Owner | Member | |---|---|---| | Team | "Your team plan ended on {date}" + Resubscribe (opens the pricing table) | "Ask your workspace owner to resubscribe." | | Enterprise | "Your Enterprise plan ended on {date}" + Contact sales (`ENTERPRISE_URL`) | "Ask your workspace owner to contact sales." | | Unrecognized sales-managed tier | Plan-neutral copy ("Your plan ended…", "start a new plan"), same sales route | "Ask your workspace owner to contact sales." | - Members page: - The ended variants of `MemberUpsellBanner` stay until this is live; a follow-up retires them. - The footer reads "Your plan has ended, so you can't add new members." with Resubscribe or Contact sales for managers. - The ended footer replaces the "N of M total members" line, since `max_seats` collapses to 1 once the plan ends. ## Review Focus - The Members tab shows both ended banners until the follow-up lands. That's intentional (FE-3136 rollout): if this reaches a release branch later than Comfy-Org#19455, the Members page still explains the ended state. - Answers the DES-1223 open question: the ended rules live in a shared helper (`usePlanEnded`) that the banner and the footer both consume. If the backend later returns an explicit denial reason (FE-2030 direction), only `usePlanEnded` changes. - Ended plans have a real tier on the subscription (team plans carry e.g. `PRO`). A missing tier still fails closed to the sales route, matching the Members-page behaviour this replaces. - `UnifiedPricingTable.test.ts > prompts free-tier users to subscribe` also fails on clean `main` locally, so it's unrelated to this PR. - No E2E added. The ended state needs a real workspace whose plan has ended. `deriveBillingBanner.test.ts`, `BillingStatusBanner.test.ts` and `MembersPanelContent.test.ts` cover priority, flag independence, roles, actions and dismissal. ## Plan position | # | Step | Status | |---|------|--------| | 1 | Ramp `v1_payment_recovery` to 100% | done | | 2 | Split Members credit limits off `billing_control_enabled` (Comfy-Org#19641) | merged | | 3 | Payment failed reads as paused (Comfy-Org#19677) | merged | | 4 | Banner copy/roles per design review (Comfy-Org#19680) | in review | | **5** | **Plan ended banner + Members footer (this PR)** | **this PR** | | 6 | Ramp `billing_control_enabled`, then remove both gates | after 3-5 | ```mermaid flowchart LR C[3 payment_failed copy Comfy-Org#19677] --> D[4 design review Comfy-Org#19680] D --> E[5 Plan ended - this PR]:::me E --> F[6 ramp + remove gates] classDef me fill:#3b5bdb,color:#fff ``` ## Screenshots Storybook captures with demo billing data (`DISTRIBUTION=cloud`). | State | AS IS | TO BE | |---|---|---| | Team plan ended, owner | No workspace billing banner for an ended plan; only the Members page banner below | <img width="480" alt="plan-ended-owner" src="https://github.com/user-attachments/assets/b94187be-15d5-4e49-bc04-f26357c67a72" /> | | Team plan ended, member | No workspace billing banner for an ended plan; only the Members page banner below | <img width="480" alt="plan-ended-member" src="https://github.com/user-attachments/assets/0cfc7d59-652d-4b72-9585-e266c333fabe" /> | | Enterprise plan ended, owner | No workspace billing banner for an ended plan; only the Members page banner below | <img width="480" alt="plan-ended-enterprise-owner" src="https://github.com/user-attachments/assets/f1da50cf-38f3-4f78-bbc0-93ca52320156" /> | | Enterprise plan ended, member | No workspace billing banner for an ended plan; only the Members page banner below | <img width="480" alt="plan-ended-enterprise-member" src="https://github.com/user-attachments/assets/829ca4db-a06e-40f2-87f9-a59f89c19955" /> | | Members page, team plan ended | <img width="480" alt="members-reactivate" src="https://github.com/user-attachments/assets/36445f76-579b-40f6-b16e-ddf2a9bb75ac" /> | Banner unchanged (retired in a follow-up); new footer reads "Your plan has ended, so you can't add new members." + Resubscribe (covered by `MembersPanelContent.test.ts`, no story) | | Members page, Enterprise plan ended | <img width="480" alt="members-contact-sales" src="https://github.com/user-attachments/assets/e527735d-d961-4b8b-aa2c-b9ca7e934cb9" /> | Banner unchanged (retired in a follow-up); new footer with Contact sales (covered by `MembersPanelContent.test.ts`, no story) | - Fixes FE-3136
|
Manual backports (auto-backport hit cherry-pick conflicts): |
…s behind their own flag (#19641) (#20006) Backport of #19641 to `core/1.55`. ## Why On 1.55 `billing_control_enabled` still gates the Members credit column and "Set credit limit" alongside the billing banners. The credit-limit UI is not shippable (the limit only lives in the local store; persistence is FE-1278), so it must move off the flag before `billing_control_enabled` ramps on cloud. After this, `billing_control_enabled` gates only the banners, same as main. comfy-pr-bot's auto-backport failed on cherry-pick conflicts. ## How - Ported as on main: `member_credit_limits_enabled` in `ServerFeatureFlag`, `RemoteConfig`, `useFeatureFlags` (strict boolean, default off), RUM flag reporting, and the `__mocks__` default. `useWorkspaceUI.showCreditsColumn` and the `useMembersPanel` credit-limit menu item read the new flag. Banners (`useBillingBanner`) stay on `billing_control_enabled`. - Conflict: `useWorkspaceUI.test.ts`. 1.55 mocks `useFeatureFlags` with getters and loads the composable via dynamic import, while main uses the shared mock and an effect scope. Kept the 1.55 harness, added a `memberCreditLimitsEnabled` getter, and ported the two tests ("hidden under billing controls alone", "shown when member credit limits are enabled"). `useMembersPanel.test.ts` applied cleanly, including the new "billing controls alone" case. - Skipped: the new `PlanChangeOwner` / `EndingEnterpriseOwner` stories in `BillingStatusBanner.stories.ts`. 1.55 has no Enterprise two-week ending notice, and the stories are not part of the flag split. Kept the `canReactivatePlan` fix in the Storybook `useWorkspaceUI` mock, since 1.55's `BillingStatusBanner` reads it too. ## Testing - `pnpm test:unit` on `useWorkspaceUI.test.ts`, `useMembersPanel.test.ts`, `useFeatureFlags.test.ts`: 192 passed. - Red/green: with both gates temporarily set back to `billingControlEnabled`, 7 tests fail (both "billing controls alone" cases, the credit-column case, and the credit-limit menu cases). Restored, all pass. - `pnpm typecheck`, `oxlint --type-aware` and `oxfmt --check` on the touched files pass. - Fixes FE-3129
…ts behind their own flag (#19641) (#20007) Backport of #19641 to `cloud/1.55`. ## Why On 1.55 `billing_control_enabled` still gates the Members credit column and "Set credit limit" alongside the billing banners. The credit-limit UI is not shippable (the limit only lives in the local store; persistence is FE-1278), so it must move off the flag before `billing_control_enabled` ramps on cloud. After this, `billing_control_enabled` gates only the banners, same as main. comfy-pr-bot's auto-backport failed on cherry-pick conflicts. ## How - Ported as on main: `member_credit_limits_enabled` in `ServerFeatureFlag`, `RemoteConfig`, `useFeatureFlags` (strict boolean, default off), RUM flag reporting, and the `__mocks__` default. `useWorkspaceUI.showCreditsColumn` and the `useMembersPanel` credit-limit menu item read the new flag. Banners (`useBillingBanner`) stay on `billing_control_enabled`. - Conflict: `useWorkspaceUI.test.ts`. 1.55 mocks `useFeatureFlags` with getters and loads the composable via dynamic import, while main uses the shared mock and an effect scope. Kept the 1.55 harness, added a `memberCreditLimitsEnabled` getter, and ported the two tests ("hidden under billing controls alone", "shown when member credit limits are enabled"). `useMembersPanel.test.ts` applied cleanly, including the new "billing controls alone" case. - Skipped: the new `PlanChangeOwner` / `EndingEnterpriseOwner` stories in `BillingStatusBanner.stories.ts`. 1.55 has no Enterprise two-week ending notice, and the stories are not part of the flag split. Kept the `canReactivatePlan` fix in the Storybook `useWorkspaceUI` mock, since 1.55's `BillingStatusBanner` reads it too. ## Testing - `pnpm test:unit` on `useWorkspaceUI.test.ts`, `useMembersPanel.test.ts`, `useFeatureFlags.test.ts`: 192 passed. - Red/green: with both gates temporarily set back to `billingControlEnabled`, 7 tests fail (both "billing controls alone" cases, the credit-column case, and the credit-limit menu cases). Restored, all pass. - `pnpm typecheck`, `oxlint --type-aware` and `oxfmt --check` on the touched files pass. - Fixes FE-3129
Summary
Move the Members credit column and "Set credit limit" action off
billing_control_enabledonto a newmember_credit_limits_enabledflag, sobilling_control_enabledcan ramp with only the billing banners.Why
billing_control_enabledis off for 100% of prod users (Datadog RUM, 30 days). It gates two unrelated things:setMemberCreditLimitonly updates the local store (persistence is FE-1278), so a limit looks saved, disappears on reload, and caps nothing. Not shippable.One flag for both kept the banners parked behind the unfinished Spend Controls work.
Changes
member_credit_limits_enabledflag (strict boolean, default off), reported to RUM like the other flags.useWorkspaceUI.showCreditsColumnand theuseMembersPanelcredit-limit menu item read the new flag.billing_control_enablednow gates only the banners.billing_control_enabledalone no longer shows either Members surface (verified red against the old gating).PlanChangeOwnerandEndingEnterpriseOwnerbanner states; add the missingcanReactivatePlanto theuseWorkspaceUImock, which made the existingEnding*stories throw.Review Focus
member_credit_limits_enabledmust be delivered by/featuresbefore it can be turned on. Nothing to do now since it stays off until Spend Controls ships.billing_control_enabled10% → 50% → 100% and watch RUM, then remove the gate (BE-17912). Banner states reviewed with design: https://claude.ai/artifact/FoTcznmY138JjXb15s3rj5Plan position
v1_payment_recoveryto 100% (fixes paused workspace falling through to "Subscribe to run")billing_control_enabled10% → 100%v1_payment_recovery/billing_control_enabledgatesmember_credit_limits_enabledwith Spend Controls (FE-1278)Screenshots
Real app (
pnpm dev:cloud→ testcloud), team workspace as owner,billing_control_enabledviaff:dev override. The workspace has one real member, so a second row (Alex Member) was injected into the members store to open the ⋯ menu; AS IS runs origin/main'suseWorkspaceUI/useMembersPanel.AS IS — billing controls on: Members credit column + Set credit limit show alongside banners.
TO BE — billing controls on, member credit limits off: banners show, Members has no credit column or Set credit limit.
TO BE,
member_credit_limits_enabledon — the Credits column and Set credit limit return.