Repository navigation
[backport cloud/1.55] FE-3129 feat(billing): gate Members credit limits behind their own flag (#19641) - #20007
Conversation
…ag (#19641) Move the Members credit column and "Set credit limit" action off `billing_control_enabled` onto a new `member_credit_limits_enabled` flag, so `billing_control_enabled` can ramp with only the billing banners. `billing_control_enabled` is off for 100% of prod users (Datadog RUM, 30 days). It gates two unrelated things: - Team lifecycle banners (out of credits, plan ending, scheduled plan change) and the Enterprise 2-week ending notice. Display-only, reuse live actions, no new API. Ready to ramp. - The Members credit column and "Set credit limit". `setMemberCreditLimit` only updates the local store (persistence is FE-1278), so a limit looks saved, disappears on reload, and caps nothing. Not shippable. One flag for both kept the banners parked behind the unfinished Spend Controls work. - **What**: - New `member_credit_limits_enabled` flag (strict boolean, default off), reported to RUM like the other flags. - `useWorkspaceUI.showCreditsColumn` and the `useMembersPanel` credit-limit menu item read the new flag. `billing_control_enabled` now gates only the banners. - Tests pin the split: `billing_control_enabled` alone no longer shows either Members surface (verified red against the old gating). - Storybook: add `PlanChangeOwner` and `EndingEnterpriseOwner` banner states; add the missing `canReactivatePlan` to the `useWorkspaceUI` mock, which made the existing `Ending*` stories throw. - `member_credit_limits_enabled` must be delivered by `/features` before it can be turned on. Nothing to do now since it stays off until Spend Controls ships. - Rollout after merge: ramp `billing_control_enabled` 10% → 50% → 100% and watch RUM, then remove the gate (BE-17912). Banner states reviewed with design: https://claude.ai/artifact/FoTcznmY138JjXb15s3rj5 | # | Step | Status | |---|------|--------| | 1 | Ramp `v1_payment_recovery` to 100% (fixes paused workspace falling through to "Subscribe to run") | PostHog | | **2** | **Split Members credit-limit surfaces onto their own flag (this PR)** | **this PR** | | 3 | Design check of banner states (Alex) | in review | | 4 | Ramp `billing_control_enabled` 10% → 100% | after 2 + 3 | | 5 | Remove `v1_payment_recovery` / `billing_control_enabled` gates | after ramps | | 6 | Turn on `member_credit_limits_enabled` with Spend Controls (FE-1278) | later | ```mermaid flowchart LR A[1 ramp v1_payment_recovery] --> E[5 remove gates] B[2 split flags - this PR]:::me --> D[4 ramp billing_control_enabled] C[3 design check] --> D D --> E F[FE-1278 persistence] --> G[6 enable member_credit_limits_enabled] B --> G classDef me fill:#3b5bdb,color:#fff ``` Real app (`pnpm dev:cloud` → testcloud), team workspace as owner, `billing_control_enabled` via `ff:` dev override. The workspace has one real member, so a second row (Alex Member) was injected into the members store to open the ⋯ menu; AS IS runs origin/main's `useWorkspaceUI`/`useMembersPanel`. **AS IS** — billing controls on: Members credit column + Set credit limit show alongside banners. <img width="1568" height="782" alt="AS IS" src="https://github.com/user-attachments/assets/720f9a11-ee74-4913-99df-74af7b02a451" /> **TO BE** — billing controls on, member credit limits off: banners show, Members has no credit column or Set credit limit. <img width="1568" height="782" alt="TO BE" src="https://github.com/user-attachments/assets/2209f847-f96f-4927-a05e-9945c075f7de" /> **TO BE, `member_credit_limits_enabled` on** — the Credits column and Set credit limit return. <img width="1568" height="737" alt="TO BE flag on" src="https://github.com/user-attachments/assets/ce7d5dac-ea7d-4e41-a509-793158360983" /> - Fixes FE-3129 (cherry picked from commit 6392fab)
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2145 passed, 0 failed · 2 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since bd42f172fceeeb47ab875ffce26c2416d5f63cd2
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-03T10:41:16.284Z",
"gitSha": "6413fbfc7ca4f8e815fc524c0f233b3ee3ded744",
"branch": "backport-19641-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.6199999999744,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.933,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.502,
"heapDeltaBytes": -9822476,
"heapUsedBytes": 59516760,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.493,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2012.4470000000656,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.752999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.446,
"heapDeltaBytes": 7273752,
"heapUsedBytes": 75749148,
"domNodes": -259,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.493,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1756.4140000000066,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.144,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 812.195,
"heapDeltaBytes": -7106964,
"heapUsedBytes": 61556044,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 167.97099999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.1569999999301,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.156999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.979,
"heapDeltaBytes": -9452264,
"heapUsedBytes": 59389292,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 160.744,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1663.9559999999847,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.296000000000001,
"layouts": 6,
"layoutDurationMs": 1.0370000000000001,
"taskDurationMs": 327.66900000000004,
"heapDeltaBytes": 2153640,
"heapUsedBytes": 64910076,
"domNodes": 77,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.377999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.8319999999394,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.239,
"layouts": 6,
"layoutDurationMs": 1.1829999999999998,
"taskDurationMs": 252.97199999999998,
"heapDeltaBytes": 2138204,
"heapUsedBytes": 64967660,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 12.183,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 617.507000000046,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.437999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.44399999999996,
"heapDeltaBytes": 18050280,
"heapUsedBytes": 86831952,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 165.87400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 657.8419999999596,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.091000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.91100000000006,
"heapDeltaBytes": 18147748,
"heapUsedBytes": 86965380,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 171.29500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1200.1360000000432,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 891.523,
"heapDeltaBytes": -18199264,
"heapUsedBytes": 72699736,
"domNodes": -294,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 68.09200000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 539,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1218.8129999999546,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 887.1960000000001,
"heapDeltaBytes": 12659380,
"heapUsedBytes": 103890896,
"domNodes": -295,
"jsHeapTotalBytes": 23482368,
"scriptDurationMs": 71.38299999999998,
"eventListeners": -195,
"totalBlockingTimeMs": 595,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.2459999999887,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.5210000000002,
"heapDeltaBytes": 15313732,
"heapUsedBytes": 92097952,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.221,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.0820000000904,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.3440000000001,
"heapDeltaBytes": 15802220,
"heapUsedBytes": 91197540,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.547,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9818.340999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8939.049,
"heapDeltaBytes": -655260,
"heapUsedBytes": 80725804,
"domNodes": -16,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7724.78,
"eventListeners": 0,
"totalBlockingTimeMs": 1267,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10994.37999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10048.227,
"heapDeltaBytes": 3043520,
"heapUsedBytes": 84071020,
"domNodes": -16,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 8520.141000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1537,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.99999999999818
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9385.819000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8612.937,
"heapDeltaBytes": 538408,
"heapUsedBytes": 76658588,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7478.084,
"eventListeners": 0,
"totalBlockingTimeMs": 931,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9584.16299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8766.364000000001,
"heapDeltaBytes": 11782748,
"heapUsedBytes": 89842772,
"domNodes": -265,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7599.103999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 1037,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2026.2139999999818,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.340999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.52499999999986,
"heapDeltaBytes": -15636172,
"heapUsedBytes": 73369496,
"domNodes": -244,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 33.036,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.3750000000255,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.655000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.79699999999997,
"heapDeltaBytes": -16034496,
"heapUsedBytes": 73002252,
"domNodes": -241,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.178,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2256.86300000001,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.372000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1579.5970000000002,
"heapDeltaBytes": 1111952,
"heapUsedBytes": 65201012,
"domNodes": -246,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 874.749,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2227.967000000035,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.761999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1610.0860000000002,
"heapDeltaBytes": -1382484,
"heapUsedBytes": 88525524,
"domNodes": -254,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 859.457,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3523.0400000000373,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.805,
"layouts": 60,
"layoutDurationMs": 13.405999999999999,
"taskDurationMs": 1642.529,
"heapDeltaBytes": 6653756,
"heapUsedBytes": 97620804,
"domNodes": 38,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 807.0110000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3521.0550000000467,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.032999999999998,
"layouts": 60,
"layoutDurationMs": 12.778,
"taskDurationMs": 1607.758,
"heapDeltaBytes": -279112,
"heapUsedBytes": 65642168,
"domNodes": 28,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 794.371,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3022.0860000000016,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.504,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1783.5939999999998,
"heapDeltaBytes": 7653040,
"heapUsedBytes": 73368232,
"domNodes": 6,
"jsHeapTotalBytes": 454656,
"scriptDurationMs": 971.9649999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3066.6270000000395,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.8100000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1857.837,
"heapDeltaBytes": 7524384,
"heapUsedBytes": 73214980,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1012.2319999999997,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2003.2940000000394,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.816999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.58299999999986,
"heapDeltaBytes": 9890172,
"heapUsedBytes": 73871084,
"domNodes": -246,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.038,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.1259999999866,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.647,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.1729999999999,
"heapDeltaBytes": -16980496,
"heapUsedBytes": 73660100,
"domNodes": -248,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 36.26700000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.3749999999513,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.55299999999994,
"heapDeltaBytes": 13774812,
"heapUsedBytes": 83541596,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 149.09900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.9300000000421,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.321,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.1840000000001,
"heapDeltaBytes": 14159384,
"heapUsedBytes": 85035960,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 141.067,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.5009999999947,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.068,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.92,
"heapDeltaBytes": 8917332,
"heapUsedBytes": 79852940,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.734000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1990.7680000000028,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.577999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.40399999999994,
"heapDeltaBytes": -2913596,
"heapUsedBytes": 68132556,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.565000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.7689999999889,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.741000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 739.6709999999999,
"heapDeltaBytes": -5894716,
"heapUsedBytes": 57210868,
"domNodes": -275,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 107.646,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.2740000000758,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.53,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 732.0759999999999,
"heapDeltaBytes": -6561800,
"heapUsedBytes": 64192172,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 107.391,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 933.6590000000342,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.154,
"layouts": 5,
"layoutDurationMs": 13.171999999999999,
"taskDurationMs": 708.2660000000001,
"heapDeltaBytes": -6231312,
"heapUsedBytes": 82665684,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 26.62599999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8324.048000000004,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.704,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5539.36,
"heapDeltaBytes": -5221428,
"heapUsedBytes": 84070868,
"domNodes": -252,
"jsHeapTotalBytes": 4939776,
"scriptDurationMs": 2825.0069999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8392.330000000016,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.666000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5497.358,
"heapDeltaBytes": -4634200,
"heapUsedBytes": 84716936,
"domNodes": -252,
"jsHeapTotalBytes": 4415488,
"scriptDurationMs": 2814.3190000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16823.627999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16359.119999999997,
"heapDeltaBytes": -55432036,
"heapUsedBytes": 184811132,
"domNodes": -8061,
"jsHeapTotalBytes": -16232448,
"scriptDurationMs": 252.03300000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16927.430000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16453.802,
"heapDeltaBytes": -61520716,
"heapUsedBytes": 178869580,
"domNodes": -8061,
"jsHeapTotalBytes": -14135296,
"scriptDurationMs": 266.453,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20427.504,
"styleRecalcs": 162,
"styleRecalcDurationMs": 17.30000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20023.781,
"heapDeltaBytes": -47811188,
"heapUsedBytes": 192461088,
"domNodes": -8061,
"jsHeapTotalBytes": -17088512,
"scriptDurationMs": 898.332,
"eventListeners": -14928,
"totalBlockingTimeMs": 47,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20221.314000000006,
"styleRecalcs": 160,
"styleRecalcDurationMs": 15.705999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19816.65,
"heapDeltaBytes": -29409292,
"heapUsedBytes": 192803356,
"domNodes": -8061,
"jsHeapTotalBytes": -20488192,
"scriptDurationMs": 882.0120000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6112.103000000047,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.53200000000002,
"layouts": 20,
"layoutDurationMs": 22.530999999999995,
"taskDurationMs": 6026.830999999999,
"heapDeltaBytes": -51605136,
"heapUsedBytes": 182085096,
"domNodes": -8060,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 110.77899999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 386,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6092.03500000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.19300000000001,
"layouts": 20,
"layoutDurationMs": 22.613999999999994,
"taskDurationMs": 5999.267000000001,
"heapDeltaBytes": -51370268,
"heapUsedBytes": 182571064,
"domNodes": -8061,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 108.661,
"eventListeners": -14928,
"totalBlockingTimeMs": 435,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8379.974999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8206.351999999999,
"heapDeltaBytes": 21665472,
"heapUsedBytes": 187348356,
"domNodes": 0,
"jsHeapTotalBytes": -11010048,
"scriptDurationMs": 129.23300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8430.899000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8209.869999999999,
"heapDeltaBytes": -5085580,
"heapUsedBytes": 192238728,
"domNodes": 0,
"jsHeapTotalBytes": -26476544,
"scriptDurationMs": 125.75200000000002,
"eventListeners": -1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 461.53400000002875,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.387,
"layouts": 4,
"layoutDurationMs": 2.19,
"taskDurationMs": 131.67000000000002,
"heapDeltaBytes": 5297884,
"heapUsedBytes": 71740416,
"domNodes": 149,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.302000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 113.91500000001997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 18.093,
"layouts": 3,
"layoutDurationMs": 1.6449999999999998,
"taskDurationMs": 78.676,
"heapDeltaBytes": 3004372,
"heapUsedBytes": 69367248,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.072000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #20007 +/- ##
=============================================
Coverage ? 84.94%
=============================================
Files ? 2327
Lines ? 133219
Branches ? 33804
=============================================
Hits ? 113157
Misses ? 19700
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at exact head beda69f119afc3b909eaa365bffef76c92793d40.
Full context for agent readers
The backport preserves the original feature-flag split on the older branch. The mechanical line comparison differs only where the older test and storybook seams require branch-specific adaptation; the resulting behavior and files are aligned, and no package manifest changed.
Backport of #19641 to
cloud/1.55.Why
On 1.55
billing_control_enabledstill gates the Members credit column and "Set credit limit" alongside the billing banners. The credit-limit UI is not shippable (the limit only lives in the local store; persistence is FE-1278), so it must move off the flag beforebilling_control_enabledramps on cloud. After this,billing_control_enabledgates only the banners, same as main. comfy-pr-bot's auto-backport failed on cherry-pick conflicts.How
member_credit_limits_enabledinServerFeatureFlag,RemoteConfig,useFeatureFlags(strict boolean, default off), RUM flag reporting, and the__mocks__default.useWorkspaceUI.showCreditsColumnand theuseMembersPanelcredit-limit menu item read the new flag. Banners (useBillingBanner) stay onbilling_control_enabled.useWorkspaceUI.test.ts. 1.55 mocksuseFeatureFlagswith getters and loads the composable via dynamic import, while main uses the shared mock and an effect scope. Kept the 1.55 harness, added amemberCreditLimitsEnabledgetter, and ported the two tests ("hidden under billing controls alone", "shown when member credit limits are enabled").useMembersPanel.test.tsapplied cleanly, including the new "billing controls alone" case.PlanChangeOwner/EndingEnterpriseOwnerstories inBillingStatusBanner.stories.ts. 1.55 has no Enterprise two-week ending notice, and the stories are not part of the flag split. Kept thecanReactivatePlanfix in the StorybookuseWorkspaceUImock, since 1.55'sBillingStatusBannerreads it too.Testing
pnpm test:unitonuseWorkspaceUI.test.ts,useMembersPanel.test.ts,useFeatureFlags.test.ts: 192 passed.Red/green: with both gates temporarily set back to
billingControlEnabled, 7 tests fail (both "billing controls alone" cases, the credit-column case, and the credit-limit menu cases). Restored, all pass.pnpm typecheck,oxlint --type-awareandoxfmt --checkon the touched files pass.Fixes FE-3129