Repository navigation
[backport cloud/1.55] feat(agent): keep panel open through activation - #19632
christian-byrne merged 7 commits into
Conversation
Keep the Agent panel open after the startup/onboarding decision across cloud and local sessions, while preserving authentication and consent at the first-send boundary. - **What**: Opens the panel from the approved activation flow, allows the pre-consent panel shell to render, and holds the submitted draft while the existing login/consent flow completes. - **What**: Keeps workflow-selection restoration consent-gated and records distinct `activation` / `first_message` telemetry sources. - **Dependencies**: None. Please verify the cloud/local × logged-in/logged-out × consent state matrix and that a first send resumes exactly once after the existing handoff. - `pnpm test:unit src/workbench/extensions/agent/stores/agent/agentPanelStore.test.ts src/extensions/core/agentPanel.test.ts src/components/topbar/WorkflowTabs.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts --testTimeout=30000` (454 passed) - `NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheck` - changed-file ESLint and full format check --------- Co-authored-by: GitHub Action <action@github.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2123 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-30T20:57:38.079Z",
"gitSha": "34732cfa914d35759c29afaf11cf5842de0af1b3",
"branch": "backport-19154-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.6220000000167,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.312000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.692,
"heapDeltaBytes": 2675988,
"heapUsedBytes": 70497360,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.259000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.0050000000492,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.569,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.84599999999995,
"heapDeltaBytes": 9185716,
"heapUsedBytes": 76929200,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.970999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1706.6710000000285,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.997999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 813.956,
"heapDeltaBytes": 12214088,
"heapUsedBytes": 80014144,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 165.822,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1756.625999999983,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.455000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 802.443,
"heapDeltaBytes": 6014468,
"heapUsedBytes": 73716912,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 158.49,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.771000000023,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.645999999999999,
"layouts": 6,
"layoutDurationMs": 1.0119999999999998,
"taskDurationMs": 342.793,
"heapDeltaBytes": 3106040,
"heapUsedBytes": 70850964,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.075000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.5539999999583,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.155999999999999,
"layouts": 6,
"layoutDurationMs": 1.1640000000000001,
"taskDurationMs": 338.09,
"heapDeltaBytes": 3089420,
"heapUsedBytes": 71078876,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.598000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 648.5339999999837,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.04,
"heapDeltaBytes": 18607756,
"heapUsedBytes": 86517984,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 166.297,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 663.0040000000008,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.719,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.12399999999997,
"heapDeltaBytes": 18629624,
"heapUsedBytes": 86394816,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 173.506,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1229.5140000000515,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 863.194,
"heapDeltaBytes": 14002640,
"heapUsedBytes": 104422524,
"domNodes": -296,
"jsHeapTotalBytes": 21123072,
"scriptDurationMs": 74.59100000000001,
"eventListeners": -195,
"totalBlockingTimeMs": 611,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1177.2399999999834,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 848.9550000000002,
"heapDeltaBytes": 38460000,
"heapUsedBytes": 109012040,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 71.2,
"eventListeners": 0,
"totalBlockingTimeMs": 575,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.3079999999554,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.85299999999984,
"heapDeltaBytes": 14468768,
"heapUsedBytes": 89834660,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.96899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.1340000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.88,
"heapDeltaBytes": 14669764,
"heapUsedBytes": 91117576,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.91400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 236,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10478.853999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9544.538,
"heapDeltaBytes": -25140,
"heapUsedBytes": 82385272,
"domNodes": -16,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 8174.9890000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 1530,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10384.650000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9509.773000000001,
"heapDeltaBytes": -632448,
"heapUsedBytes": 81329992,
"domNodes": -16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7832.618,
"eventListeners": 0,
"totalBlockingTimeMs": 1035,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9954.193999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9047.01,
"heapDeltaBytes": -12585124,
"heapUsedBytes": 69809564,
"domNodes": -16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7670.852,
"eventListeners": 0,
"totalBlockingTimeMs": 1085,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10540.213999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9649.733999999999,
"heapDeltaBytes": 29365100,
"heapUsedBytes": 93585752,
"domNodes": -267,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 7860.0380000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 1119,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2028.8479999999822,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.219000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.4069999999999,
"heapDeltaBytes": -3266956,
"heapUsedBytes": 83673028,
"domNodes": -241,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.06099999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.81699999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.766999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.435,
"heapDeltaBytes": -3204940,
"heapUsedBytes": 83673672,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 36.519,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2360.7790000000364,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.330000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1666.9070000000002,
"heapDeltaBytes": 20352792,
"heapUsedBytes": 84534820,
"domNodes": -243,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 867.8359999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2318.033000000014,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.891,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1648.37,
"heapDeltaBytes": -7615512,
"heapUsedBytes": 80670260,
"domNodes": -244,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 874.252,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3598.5070000000405,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.789000000000001,
"layouts": 60,
"layoutDurationMs": 13.347999999999999,
"taskDurationMs": 1716.04,
"heapDeltaBytes": 8935748,
"heapUsedBytes": 74799032,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 809.7879999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3502.651999999898,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.085999999999999,
"layouts": 60,
"layoutDurationMs": 13.120000000000001,
"taskDurationMs": 1677.0020000000002,
"heapDeltaBytes": 8445144,
"heapUsedBytes": 74567908,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 793.507,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3182.3180000000093,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.287000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1989.512,
"heapDeltaBytes": 29475360,
"heapUsedBytes": 95419404,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1033.183,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3055.413000000044,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.232999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1882.443,
"heapDeltaBytes": 21447540,
"heapUsedBytes": 87819780,
"domNodes": 6,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 970.3580000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2019.4970000000012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.439000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.84299999999996,
"heapDeltaBytes": -4773176,
"heapUsedBytes": 84269728,
"domNodes": -244,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.093999999999994,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2025.9770000000117,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.561000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.527,
"heapDeltaBytes": -4407808,
"heapUsedBytes": 84183344,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.714000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.6360000000368,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.248,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.63899999999995,
"heapDeltaBytes": 13791280,
"heapUsedBytes": 83784996,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 146.285,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 570.8690000000161,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.892000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.751,
"heapDeltaBytes": 13731844,
"heapUsedBytes": 84036204,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 144.39100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2001.244999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.649000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.015,
"heapDeltaBytes": 7542864,
"heapUsedBytes": 77230968,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.207,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.1949999999815,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.231,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.538,
"heapDeltaBytes": 5809124,
"heapUsedBytes": 75796172,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.273,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.0420000000013,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.180000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 777.73,
"heapDeltaBytes": 3721160,
"heapUsedBytes": 73712364,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 110.178,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.2449999998908,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.330000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 742.239,
"heapDeltaBytes": 1503464,
"heapUsedBytes": 71524988,
"domNodes": -275,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 106.425,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.017000000048,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.20199999999999,
"layouts": 5,
"layoutDurationMs": 13.492,
"taskDurationMs": 961.754,
"heapDeltaBytes": -6459600,
"heapUsedBytes": 86030012,
"domNodes": 13667,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 32.129999999999995,
"eventListeners": 2383,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8509.186999999998,
"styleRecalcs": 252,
"styleRecalcDurationMs": 38.65200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5911.998,
"heapDeltaBytes": 11446116,
"heapUsedBytes": 98889224,
"domNodes": -254,
"jsHeapTotalBytes": 2842624,
"scriptDurationMs": 2891.216,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8461.192999999981,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.96099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5859.0070000000005,
"heapDeltaBytes": -19768172,
"heapUsedBytes": 67707436,
"domNodes": -222,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 2859.083,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16959.790999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16434.115999999998,
"heapDeltaBytes": -28986944,
"heapUsedBytes": 187843016,
"domNodes": -8061,
"jsHeapTotalBytes": -8499200,
"scriptDurationMs": 268.05,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17345.32100000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16831.915,
"heapDeltaBytes": -37932724,
"heapUsedBytes": 189166432,
"domNodes": -8061,
"jsHeapTotalBytes": -18677760,
"scriptDurationMs": 261.69100000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20589.870000000017,
"styleRecalcs": 149,
"styleRecalcDurationMs": 17.72399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20327.707,
"heapDeltaBytes": -71616404,
"heapUsedBytes": 169370312,
"domNodes": -8061,
"jsHeapTotalBytes": -17764352,
"scriptDurationMs": 911.7320000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 119,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21019.50199999999,
"styleRecalcs": 161,
"styleRecalcDurationMs": 18.333000000000045,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20752.855,
"heapDeltaBytes": -40115932,
"heapUsedBytes": 181489608,
"domNodes": -8061,
"jsHeapTotalBytes": -14225408,
"scriptDurationMs": 952.854,
"eventListeners": -14928,
"totalBlockingTimeMs": 47,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6176.2410000000045,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.30100000000002,
"layouts": 20,
"layoutDurationMs": 24.705999999999992,
"taskDurationMs": 6105.244,
"heapDeltaBytes": -35177328,
"heapUsedBytes": 182904292,
"domNodes": -8061,
"jsHeapTotalBytes": 13959168,
"scriptDurationMs": 111.24899999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 454,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6191.913999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.48399999999997,
"layouts": 20,
"layoutDurationMs": 25.301999999999992,
"taskDurationMs": 6090.526999999999,
"heapDeltaBytes": -44996520,
"heapUsedBytes": 196077704,
"domNodes": -8061,
"jsHeapTotalBytes": 11333632,
"scriptDurationMs": 107.63400000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 382,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8427.720000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8183.021000000002,
"heapDeltaBytes": -7539536,
"heapUsedBytes": 177010704,
"domNodes": 0,
"jsHeapTotalBytes": -17039360,
"scriptDurationMs": 120.39699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8556.595000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8409.741999999998,
"heapDeltaBytes": -13893396,
"heapUsedBytes": 163765996,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 139.876,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 111.6109999999253,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.405,
"layouts": 4,
"layoutDurationMs": 2.2039999999999997,
"taskDurationMs": 96.716,
"heapDeltaBytes": 3240784,
"heapUsedBytes": 69204712,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.033000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 466.8020000000297,
"styleRecalcs": 17,
"styleRecalcDurationMs": 26.005999999999997,
"layouts": 3,
"layoutDurationMs": 1.061,
"taskDurationMs": 128.946,
"heapDeltaBytes": 4983320,
"heapUsedBytes": 70720996,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.135,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19632 +/- ##
=============================================
Coverage ? 84.62%
=============================================
Files ? 2314
Lines ? 131755
Branches ? 33307
=============================================
Hits ? 111500
Misses ? 19895
Partials ? 360
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
…end (#19667) ## Summary Backports #19619 onto `cloud/1.55` after prerequisite #19632 merged. ## Changes - **What**: Keeps activation-opened Agent available for the first message, holds that send through consent and the onboarding coach, resumes it exactly once after Finish or Skip, and cancels it when the panel closes. - **Dependencies**: Requires the panel activation behavior already merged in #19632. ## Review Focus Please verify the target-specific unmount reconciliation: App Mode remounts preserve the consent-held submission, while an actual panel close invalidates it. Local verification: - 421 focused consent/onboarding unit tests passed - 22 focused Cloud browser tests passed - Cloud build passed - app and browser typechecks passed - changed-file ESLint and `git diff --check` passed Original PR: #19619
Summary
Backports merged #19154 to
cloud/1.55.cloud/1.55starter-prompt telemetry, CRDT teardown, and target-deleted browser suitesVerification
pnpm test:unit --run src/extensions/core/agentPanel.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts src/workbench/extensions/agent/stores/agent/agentPanelStore.test.ts src/components/LiteGraphCanvasSplitterOverlay.test.ts src/components/topbar/WorkflowTabs.test.ts --testTimeout=30000— 435 passedbash scripts/test-browser-offline.sh --project=cloud browser_tests/tests/agent/agentActivationConsent.spec.ts --workers=1— 4 passedNODE_OPTIONS=--max-old-space-size=8192 pnpm typecheckpnpm lint— 0 errors (target has inherited warnings)pnpm format:check