Repository navigation
[backport cloud/1.55] fix(agent): sequence consent tour before held send - #19667
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2123 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9bef583697680b857a7989af6b2eb10467cda376
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-30T21:41:55.067Z",
"gitSha": "1bcf5083c98a827806650a9375674537d021e93f",
"branch": "backport-19619-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1989.9669999999787,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.385999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.726,
"heapDeltaBytes": 14433232,
"heapUsedBytes": 76921268,
"domNodes": -257,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.764999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.8729999999705,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.6019999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.39099999999996,
"heapDeltaBytes": -7233012,
"heapUsedBytes": 55255384,
"domNodes": 21,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.810000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.323000000003,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.001000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 679.381,
"heapDeltaBytes": 8376452,
"heapUsedBytes": 76014328,
"domNodes": -258,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 116.93799999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.7809999999736,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.779,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.546,
"heapDeltaBytes": 5213224,
"heapUsedBytes": 73159584,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 126.40100000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.8989999999976,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.035000000000002,
"layouts": 6,
"layoutDurationMs": 1.1540000000000001,
"taskDurationMs": 304.778,
"heapDeltaBytes": 2817168,
"heapUsedBytes": 70511892,
"domNodes": 79,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.519,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.8109999999924,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.108000000000002,
"layouts": 6,
"layoutDurationMs": 1.0380000000000003,
"taskDurationMs": 301.05899999999997,
"heapDeltaBytes": 3018324,
"heapUsedBytes": 71028328,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.391,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 565.3509999999642,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.341,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.9440000000001,
"heapDeltaBytes": 18592848,
"heapUsedBytes": 86819812,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 139.69500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 598.1769999999642,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.321000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.30300000000005,
"heapDeltaBytes": 18531452,
"heapUsedBytes": 86451652,
"domNodes": 23,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 144.31699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1133.1569999999829,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 786.233,
"heapDeltaBytes": 11733188,
"heapUsedBytes": 102456804,
"domNodes": -292,
"jsHeapTotalBytes": 25317376,
"scriptDurationMs": 52.891000000000005,
"eventListeners": -195,
"totalBlockingTimeMs": 514,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1106.924000000049,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 781.732,
"heapDeltaBytes": -14777608,
"heapUsedBytes": 73048124,
"domNodes": -294,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 49.589000000000006,
"eventListeners": -217,
"totalBlockingTimeMs": 457,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 760.9810000000152,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.7939999999999,
"heapDeltaBytes": 14226712,
"heapUsedBytes": 90623100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 109.19000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 762.6169999999775,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.02600000000007,
"heapDeltaBytes": 14403948,
"heapUsedBytes": 91493444,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 124.694,
"eventListeners": 0,
"totalBlockingTimeMs": 150,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7888.184000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6937.552999999999,
"heapDeltaBytes": 11094156,
"heapUsedBytes": 93121132,
"domNodes": -12,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 5470.982,
"eventListeners": 0,
"totalBlockingTimeMs": 70,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7638.140000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6689.347,
"heapDeltaBytes": -10480352,
"heapUsedBytes": 71808884,
"domNodes": -16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 5236.164,
"eventListeners": 0,
"totalBlockingTimeMs": 44,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7922.903000000019,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.732,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7059.7609999999995,
"heapDeltaBytes": -3186092,
"heapUsedBytes": 73215984,
"domNodes": -265,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 5579.82,
"eventListeners": -174,
"totalBlockingTimeMs": 162,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8325.466000000006,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.4079999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7414.772999999999,
"heapDeltaBytes": -4760712,
"heapUsedBytes": 72052748,
"domNodes": -268,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 5892.1,
"eventListeners": -174,
"totalBlockingTimeMs": 84,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2035.0009999999656,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.955000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.675,
"heapDeltaBytes": -2810240,
"heapUsedBytes": 84051616,
"domNodes": -244,
"jsHeapTotalBytes": -1806336,
"scriptDurationMs": 30.184999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.0080000000435,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.553000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.1619999999999,
"heapDeltaBytes": -5574440,
"heapUsedBytes": 81760000,
"domNodes": -240,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 30.991000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2201.2399999999843,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.622,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1417.6329999999998,
"heapDeltaBytes": -15252676,
"heapUsedBytes": 66338080,
"domNodes": -247,
"jsHeapTotalBytes": 2613248,
"scriptDurationMs": 682.961,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2148.6489999999776,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.198000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1357.272,
"heapDeltaBytes": 14201872,
"heapUsedBytes": 79025672,
"domNodes": 10,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 678.1160000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3389.724000000001,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.549999999999995,
"layouts": 60,
"layoutDurationMs": 13.468,
"taskDurationMs": 1533.6009999999999,
"heapDeltaBytes": -15961920,
"heapUsedBytes": 73856816,
"domNodes": -252,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 662.2289999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3277.302999999961,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.379,
"layouts": 60,
"layoutDurationMs": 12.108,
"taskDurationMs": 1423.0539999999999,
"heapDeltaBytes": 8021084,
"heapUsedBytes": 74261788,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 628.42,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2472.266999999988,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.904,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1595.4979999999998,
"heapDeltaBytes": 22152592,
"heapUsedBytes": 88249660,
"domNodes": 8,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 797.239,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2362.859999999955,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.12,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1651.5680000000002,
"heapDeltaBytes": -8603236,
"heapUsedBytes": 82775072,
"domNodes": -249,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 787.5600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2013.1190000000743,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.0500000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.42600000000004,
"heapDeltaBytes": -5104168,
"heapUsedBytes": 83772824,
"domNodes": -242,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 31.80200000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2017.8849999999784,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.510999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.3040000000001,
"heapDeltaBytes": -4856152,
"heapUsedBytes": 84262792,
"domNodes": -243,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 30.639,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 529.0559999999687,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.046,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.65599999999995,
"heapDeltaBytes": 13764580,
"heapUsedBytes": 83887072,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 117.199,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 526.1450000000423,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.477999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.53900000000004,
"heapDeltaBytes": 14155312,
"heapUsedBytes": 84101172,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 114.641,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2002.9680000000099,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.3389999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.42900000000003,
"heapDeltaBytes": -6560120,
"heapUsedBytes": 63399808,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.819000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.4609999999348,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.908999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.327,
"heapDeltaBytes": 7868480,
"heapUsedBytes": 77890388,
"domNodes": -272,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.923000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.4759999999187,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.221,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.852,
"heapDeltaBytes": -750612,
"heapUsedBytes": 69098348,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 77.916,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.126999999985,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.989999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.451,
"heapDeltaBytes": 11749608,
"heapUsedBytes": 81640812,
"domNodes": -272,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 77.42699999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 950.2140000000736,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.739000000000004,
"layouts": 5,
"layoutDurationMs": 9.766,
"taskDurationMs": 752.228,
"heapDeltaBytes": -6278724,
"heapUsedBytes": 81576712,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 24.111,
"eventListeners": 2383,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8185.490999999956,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.517,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4889.186,
"heapDeltaBytes": -2102776,
"heapUsedBytes": 85109896,
"domNodes": -241,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2231.0240000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8167.823999999996,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4862.566999999999,
"heapDeltaBytes": -12697424,
"heapUsedBytes": 67838380,
"domNodes": -216,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 2251.0919999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13051.124999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12406.114,
"heapDeltaBytes": -37005476,
"heapUsedBytes": 190044748,
"domNodes": -8061,
"jsHeapTotalBytes": -16842752,
"scriptDurationMs": 177.68100000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12907.153000000108,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12301.045,
"heapDeltaBytes": -55011464,
"heapUsedBytes": 182971140,
"domNodes": -8061,
"jsHeapTotalBytes": -16973824,
"scriptDurationMs": 181.709,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17102.573000000008,
"styleRecalcs": 113,
"styleRecalcDurationMs": 17.22500000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16814.459,
"heapDeltaBytes": -58501328,
"heapUsedBytes": 181250212,
"domNodes": -8061,
"jsHeapTotalBytes": -19030016,
"scriptDurationMs": 837.6729999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 16,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16637.08399999996,
"styleRecalcs": 115,
"styleRecalcDurationMs": 15.438000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16214.109,
"heapDeltaBytes": -44522484,
"heapUsedBytes": 181403544,
"domNodes": -8062,
"jsHeapTotalBytes": -17047552,
"scriptDurationMs": 759.2829999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4626.14700000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.48500000000001,
"layouts": 20,
"layoutDurationMs": 20.688,
"taskDurationMs": 4485.032999999999,
"heapDeltaBytes": -63211300,
"heapUsedBytes": 177767080,
"domNodes": -8062,
"jsHeapTotalBytes": 13168640,
"scriptDurationMs": 72.6,
"eventListeners": -14928,
"totalBlockingTimeMs": 72,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4650.225000000091,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.33600000000001,
"layouts": 20,
"layoutDurationMs": 22.436999999999998,
"taskDurationMs": 4550.412,
"heapDeltaBytes": -59994036,
"heapUsedBytes": 167436692,
"domNodes": -8062,
"jsHeapTotalBytes": 2555904,
"scriptDurationMs": 103.852,
"eventListeners": -14928,
"totalBlockingTimeMs": 75,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6339.346999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5994.1799999999985,
"heapDeltaBytes": 13637180,
"heapUsedBytes": 191453536,
"domNodes": 0,
"jsHeapTotalBytes": -12320768,
"scriptDurationMs": 89.19399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5216.471999999953,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.09000000000000674,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4557.403000000001,
"heapDeltaBytes": 8693448,
"heapUsedBytes": 202570088,
"domNodes": 0,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 80.698,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 95.63500000001568,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.401,
"layouts": 5,
"layoutDurationMs": 1.876,
"taskDurationMs": 69.55600000000001,
"heapDeltaBytes": 3219188,
"heapUsedBytes": 68911272,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.6850000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 446.0550000000012,
"styleRecalcs": 16,
"styleRecalcDurationMs": 17.336000000000002,
"layouts": 3,
"layoutDurationMs": 0.815,
"taskDurationMs": 104.17099999999999,
"heapDeltaBytes": 4973668,
"heapUsedBytes": 70666784,
"domNodes": 124,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.053,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19667 +/- ##
=============================================
Coverage ? 84.62%
=============================================
Files ? 2314
Lines ? 131794
Branches ? 33316
=============================================
Hits ? 111532
Misses ? 19902
Partials ? 360
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Backports #19619 onto
cloud/1.55after prerequisite #19632 merged.Changes
Review Focus
Please verify the target-specific unmount reconciliation: App Mode remounts preserve the consent-held submission, while an actual panel close invalidates it.
Local verification:
git diff --checkpassedOriginal PR: #19619