Repository navigation
FE-3106 test(billing): expect the lifecycle started event to carry its operation id - #19648
Conversation
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 934af0705efb127c9c9530e98a5531bff88aba05
Full docs: ADR-DEVEX-LINT-0015 |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe telemetry test adds a started lifecycle event that includes ChangesBilling telemetry tests
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to The checkout and resubscribe expectations match the emitted lifecycle event. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19648 +/- ##
==========================================
+ Coverage 84.45% 85.20% +0.75%
==========================================
Files 3345 2357 -988
Lines 161299 135267 -26032
Branches 43845 36422 -7423
==========================================
- Hits 136233 115261 -20972
+ Misses 23169 19644 -3525
+ Partials 1897 362 -1535
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved. The two lifecycle-owned expectations now match the merged mapper contract: started retains billing_op_id.
Full context for agent readers
Reviewed the complete test-only diff at 6adcac8aa239e435f0477b753e7cbfb2fe7e3682. The change is limited to the legacy subscribe and workspace resubscribe rows that receive lifecycle-owned started events; the caller-owned rows remain unchanged. Exact-head CI is settled green and there are no unresolved review threads.
|
|
Summary
Make the SDK-rail ownership test expect the operation id on a lifecycle-sent
startedevent. Two rows of that test fail onmaintoday.Why
Unit tests that run against
mainfail onbillingSdkTelemetryOwnership.test.ts, so every branch that merges withmaininherits two red rows.Root cause
Two merged PRs each passed CI on their own and were never run together. FE-3110 (#19623) made the SDK event mapper keep
billing_op_idonstarted. FE-3106 (#19620), branched earlier, added the ownership test withSTARTED = { stage: 'started' }, which asserts the pre-FE-3110 shape. The rows where the lifecycle, not the caller, sendsstarted(a checkout that reports no started, and resubscribe) now receive the id and fail.How
A separate
LIFECYCLE_STARTEDexpectation carriesbilling_op_id: 'op-1'and is used by exactly those two rows.STARTEDstays as is for the rows where the caller sendsstarted, which has no operation id yet. Test-only change, no production code.Review Focus
startedstill has no id, so the two expectations are deliberately different.UnifiedPricingTable.test.ts("prompts free-tier users to subscribe") fails locally onorigin/maintoo (INTERNAL ASSERTION FAILED: Expected a class definition, local Node 24 against engine 26). This diff does not touch it.AS IS / TO BE
AS IS:
TO BE:
The evidence is the ownership test's result on
mainand on this branch: 2 failed, 10 passed before; 12 passed after.Where this sits in the plan
Linear: FE-3106, part of FE-3105. Plan, event catalog and dependency graph: action items.