Repository navigation
BE-17784 fix(billing): accept and show the payment_not_completed decline reason - #19531
Conversation
…m cloud#11119 Generated with the push-ingest-types-to-frontend pipeline (openapi-project -fe, pnpm generate, oxfmt) against cloud@485b263, whose spec differs from the last sync (cloud@3932a04) only by this enum value.
…ent not completed cloud#11119 reports payment_method_customer_decline and payment_intent_payment_attempt_expired (an Alipay payment the customer did not approve, or an attempt that expired) as decline_reason payment_not_completed. Read it like an unfinished authentication: billing-web's full page shows the Payment not completed card, the embedded checkout and the app show the verification detail, and the legacy store maps the raw Stripe codes the same way.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2158 passed, 0 failed · 1 flaky📊 Browser Reports
🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (18 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e06becb6e0360e1efc6ca0cc32d3391f2b4c9bb3
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzip 🟢 -15 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 133 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 643 kB (baseline 643 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 4.07 MB (baseline 4.07 MB) • 🔴 +185 BStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 582 kB (baseline 582 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category
Status: 74 added / 74 removed / 226 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T03:38:15.402Z",
"gitSha": "c15be39bdee7c0b7e3e68c0c1c3bbbc2a7c080e5",
"branch": "jaewon/be-17784-payment-not-completed",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2057.254999999998,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.715999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.564,
"heapDeltaBytes": -21499492,
"heapUsedBytes": 77098028,
"domNodes": -228,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 13.899000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2032.8220000000101,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.528,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.597,
"heapDeltaBytes": -17370836,
"heapUsedBytes": 61493992,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.58,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1974.2019999999911,
"styleRecalcs": 75,
"styleRecalcDurationMs": 22.885,
"layouts": 12,
"layoutDurationMs": 5.329,
"taskDurationMs": 997.578,
"heapDeltaBytes": -35579500,
"heapUsedBytes": 63135820,
"domNodes": -228,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 176.184,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1924.621000000002,
"styleRecalcs": 80,
"styleRecalcDurationMs": 21.26,
"layouts": 12,
"layoutDurationMs": 5.25,
"taskDurationMs": 868.268,
"heapDeltaBytes": -38657788,
"heapUsedBytes": 60095684,
"domNodes": -228,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 159.479,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.81228070175439,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.0349999999962,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.251,
"layouts": 6,
"layoutDurationMs": 1.3159999999999998,
"taskDurationMs": 346.2099999999999,
"heapDeltaBytes": 1482648,
"heapUsedBytes": 80443404,
"domNodes": 53,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 13.002000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.2659999999623,
"styleRecalcs": 33,
"styleRecalcDurationMs": 10.26,
"layouts": 6,
"layoutDurationMs": 1.1839999999999997,
"taskDurationMs": 324.014,
"heapDeltaBytes": 1524396,
"heapUsedBytes": 80069936,
"domNodes": 53,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.985000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 766.5809999999738,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.278000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.003,
"heapDeltaBytes": -3129920,
"heapUsedBytes": 94835808,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 172.111,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 713.8259999999264,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.989999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.744,
"heapDeltaBytes": -2795120,
"heapUsedBytes": 95306516,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 162.499,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1144.3830000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 801.3919999999999,
"heapDeltaBytes": 9460252,
"heapUsedBytes": 86923856,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 64.13900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 516,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1155.842000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 796.8639999999999,
"heapDeltaBytes": 10001780,
"heapUsedBytes": 85348980,
"domNodes": 0,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 66.348,
"eventListeners": 0,
"totalBlockingTimeMs": 515,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.8109999999692,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.19000000000034,
"heapDeltaBytes": 17029044,
"heapUsedBytes": 90887876,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 146.6,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.5129999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.95899999999966,
"heapDeltaBytes": 12637844,
"heapUsedBytes": 93591132,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 142.85799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9206.305999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8272.85,
"heapDeltaBytes": 2262912,
"heapUsedBytes": 82899504,
"domNodes": 0,
"jsHeapTotalBytes": -11010048,
"scriptDurationMs": 6586.117,
"eventListeners": 0,
"totalBlockingTimeMs": 311,
"frameDurationMs": 29.966449511400654,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8906.071999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8030.010000000001,
"heapDeltaBytes": -9710120,
"heapUsedBytes": 70708760,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 6434.292,
"eventListeners": 0,
"totalBlockingTimeMs": 148,
"frameDurationMs": 28.80129449838188,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8887.968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8041.2789999999995,
"heapDeltaBytes": 2863936,
"heapUsedBytes": 82109112,
"domNodes": -30,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 6376.224999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 185,
"frameDurationMs": 30.737024221453286,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8746.459999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8028.295999999999,
"heapDeltaBytes": -360516,
"heapUsedBytes": 80606776,
"domNodes": 0,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 6752.932,
"eventListeners": 0,
"totalBlockingTimeMs": 592,
"frameDurationMs": 32.64776119402985,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2058.419000000015,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.1930000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 751.7919999999999,
"heapDeltaBytes": -37285636,
"heapUsedBytes": 82677692,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 40.936,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.2410000000136,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.4620000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.523,
"heapDeltaBytes": -36176280,
"heapUsedBytes": 83065108,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 35.46500000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66475409836065,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3120.383000000004,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.403999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1862.9250000000002,
"heapDeltaBytes": -31598676,
"heapUsedBytes": 88678032,
"domNodes": -228,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 907.005,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666310160427805,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2584.7029999999904,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.435999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1686.169,
"heapDeltaBytes": 24312568,
"heapUsedBytes": 87118908,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 873.9950000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77516339869281,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3823.5799999999927,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.02,
"layouts": 60,
"layoutDurationMs": 16.275000000000002,
"taskDurationMs": 1817.269,
"heapDeltaBytes": 11762156,
"heapUsedBytes": 76150360,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 831.823,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666086956521738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3662.0020000000295,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.544000000000002,
"layouts": 60,
"layoutDurationMs": 15.217,
"taskDurationMs": 1665.372,
"heapDeltaBytes": 12904760,
"heapUsedBytes": 77058604,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 787.951,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3210.8289999999897,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.554999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2066.8930000000005,
"heapDeltaBytes": 25219492,
"heapUsedBytes": 89556048,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1037.199,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84157894736842,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3126.8760000000384,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.971000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1892.5510000000002,
"heapDeltaBytes": 2486232,
"heapUsedBytes": 67943144,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 976.0710000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755913978494622,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2057.1429999999964,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.4509999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 691.642,
"heapDeltaBytes": -37579224,
"heapUsedBytes": 83786248,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 38.525000000000006,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.5069999999614,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.8150000000002,
"heapDeltaBytes": 20944932,
"heapUsedBytes": 84120324,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.717999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 688.6049999999955,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.789999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.16900000000004,
"heapDeltaBytes": -20199516,
"heapUsedBytes": 60168932,
"domNodes": -214,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 168.04999999999998,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926822,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.4300000000221,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.774,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.97700000000003,
"heapDeltaBytes": 12309324,
"heapUsedBytes": 93731492,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.96800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2035.9800000000519,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.306,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.228,
"heapDeltaBytes": -5834240,
"heapUsedBytes": 74845748,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.302000000000003,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2072.181999999998,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.217000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.721,
"heapDeltaBytes": -10315644,
"heapUsedBytes": 71195776,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 8.635,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1810.165999999981,
"styleRecalcs": 80,
"styleRecalcDurationMs": 23.731,
"layouts": 16,
"layoutDurationMs": 6.45,
"taskDurationMs": 910.033,
"heapDeltaBytes": -21144824,
"heapUsedBytes": 60205284,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 124.24000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740745,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.6530000000184,
"styleRecalcs": 80,
"styleRecalcDurationMs": 18.619000000000003,
"layouts": 16,
"layoutDurationMs": 5.986,
"taskDurationMs": 761.197,
"heapDeltaBytes": -16230436,
"heapUsedBytes": 65170388,
"domNodes": -244,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 101.294,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 917.2179999999344,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.814,
"layouts": 5,
"layoutDurationMs": 12.156,
"taskDurationMs": 714.82,
"heapDeltaBytes": 21716404,
"heapUsedBytes": 103234008,
"domNodes": 13667,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.340000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 126,
"frameDurationMs": 21.318604651162786,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8550.374000000033,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.37400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5815.114,
"heapDeltaBytes": -40561228,
"heapUsedBytes": 78653768,
"domNodes": -228,
"jsHeapTotalBytes": 94208,
"scriptDurationMs": 2747.371,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698630136986303,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8650.574000000006,
"styleRecalcs": 246,
"styleRecalcDurationMs": 38.966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5746.84,
"heapDeltaBytes": -36764976,
"heapUsedBytes": 82890460,
"domNodes": -228,
"jsHeapTotalBytes": 356352,
"scriptDurationMs": 2763.076,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.828906250000003,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18149.54399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18016.714999999997,
"heapDeltaBytes": -13149224,
"heapUsedBytes": 184865272,
"domNodes": -3045,
"jsHeapTotalBytes": 14041088,
"scriptDurationMs": 310.562,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.005306122448985,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 17406.870999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16847.908,
"heapDeltaBytes": -46976996,
"heapUsedBytes": 182097272,
"domNodes": -3045,
"jsHeapTotalBytes": 5267456,
"scriptDurationMs": 287.515,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.577858439201453,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 22701.58200000003,
"styleRecalcs": 165,
"styleRecalcDurationMs": 22.94799999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22561.534000000003,
"heapDeltaBytes": -20854592,
"heapUsedBytes": 177900204,
"domNodes": -3046,
"jsHeapTotalBytes": 6828032,
"scriptDurationMs": 944.941,
"eventListeners": -14915,
"totalBlockingTimeMs": 161,
"frameDurationMs": 45.09423459244533,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 21612.308999999983,
"styleRecalcs": 160,
"styleRecalcDurationMs": 19.68500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21394.936,
"heapDeltaBytes": -36105836,
"heapUsedBytes": 178093684,
"domNodes": -3042,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 891.679,
"eventListeners": -14905,
"totalBlockingTimeMs": 51,
"frameDurationMs": 42.16842105263158,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 6400.303000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.929,
"layouts": 20,
"layoutDurationMs": 25.173000000000002,
"taskDurationMs": 6348.820000000001,
"heapDeltaBytes": 886032,
"heapUsedBytes": 226606316,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 118.937,
"eventListeners": 0,
"totalBlockingTimeMs": 443,
"frameDurationMs": 40.656687898089174,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6336.842000000047,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.10999999999999,
"layouts": 20,
"layoutDurationMs": 24.46999999999999,
"taskDurationMs": 6277.991999999999,
"heapDeltaBytes": -6090784,
"heapUsedBytes": 201572520,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 123.50000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 402,
"frameDurationMs": 38.71829268292684,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9106.01200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9021.904,
"heapDeltaBytes": -34635576,
"heapUsedBytes": 191090120,
"domNodes": -3045,
"jsHeapTotalBytes": 8617984,
"scriptDurationMs": 159.56099999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.12692307692308,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8761.811999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8636.864000000001,
"heapDeltaBytes": -38816888,
"heapUsedBytes": 170527604,
"domNodes": -3045,
"jsHeapTotalBytes": 10027008,
"scriptDurationMs": 146.235,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.71007462686567,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 475.8170000000064,
"styleRecalcs": 15,
"styleRecalcDurationMs": 20.826999999999998,
"layouts": 4,
"layoutDurationMs": 2.077,
"taskDurationMs": 153.087,
"heapDeltaBytes": -14404712,
"heapUsedBytes": 82518572,
"domNodes": 104,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.681000000000003,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 127.80499999996664,
"styleRecalcs": 9,
"styleRecalcDurationMs": 12.132,
"layouts": 3,
"layoutDurationMs": 1.12,
"taskDurationMs": 97.966,
"heapDeltaBytes": -16408644,
"heapUsedBytes": 80580420,
"domNodes": 94,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 9.177,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65000000000009,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1105.3799999999683,
"styleRecalcs": 78,
"styleRecalcDurationMs": 127.21,
"layouts": 76,
"layoutDurationMs": 26.852,
"taskDurationMs": 1079.0659999999998,
"heapDeltaBytes": 19940940,
"heapUsedBytes": 91754208,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 437.526,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66417910447761,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1035.7709999999543,
"styleRecalcs": 78,
"styleRecalcDurationMs": 123.111,
"layouts": 76,
"layoutDurationMs": 26.28,
"taskDurationMs": 1007.1999999999998,
"heapDeltaBytes": 18995708,
"heapUsedBytes": 90872316,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 412.496,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1451.3680000000022,
"styleRecalcs": 78,
"styleRecalcDurationMs": 280.82,
"layouts": 76,
"layoutDurationMs": 28.073,
"taskDurationMs": 1433.985,
"heapDeltaBytes": 8438480,
"heapUsedBytes": 115163056,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 469.873,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.77594936708862,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1482.101000000057,
"styleRecalcs": 78,
"styleRecalcDurationMs": 306.184,
"layouts": 76,
"layoutDurationMs": 26.798,
"taskDurationMs": 1468.067,
"heapDeltaBytes": -18718744,
"heapUsedBytes": 111049232,
"domNodes": 76,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 464.671,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.95625,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe billing status contract now accepts ChangesPayment Not Completed Handling
Priority: ⬆️ High Estimated code review effort: 2 (Simple) | ~15 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The new decline reason is accepted and presented as a payment-not-completed outcome with retry available. No concrete merge-blocking issue is evident; proceed with normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change is bounded to accepting and presenting a new billing failure reason. Existing checkout safeguards remain in place. Deployment ordering matters, and backend retry and settlement guarantees have not been independently verified. Retained concerns Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR title contains the bug-fix signal
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19531 +/- ##
=========================================
Coverage 84.33% 84.33%
=========================================
Files 3301 3301
Lines 159044 159048 +4
Branches 43247 41389 -1858
=========================================
+ Hits 134123 134129 +6
+ Misses 23049 23047 -2
Partials 1872 1872
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
CI failures were from main, not this PR. Merged origin/main (eaffd58), no code changes.
Verified locally: typecheck, account-core (1356), billing-web (829), and the touched workspace billing tests (166) pass. |
# Conflicts: # apps/billing-web/e2e/full-page-checkout.spec.ts
|
Merged main (83bd3e2) to clear the conflict from #19537. Conflict: Verified: root typecheck, account-core unit (1356), billing-web typecheck / unit (852) / lint / Playwright (96 passed), root billingOperationStore + subscriptionOperationView unit (166), knip. |
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at 83bd3e2dd3f433a82b1a1ea554d223faa05ef01f.
- The generated contract now accepts
payment_not_completedfrom the merged backend schema change without weakening strict parsing. - Shared SDK, full-page checkout, embedded checkout, and the legacy operation store consistently treat it as a retryable payment-verification outcome.
- The change does not alter workspace selection or tab-local workspace scope.
Full context for agent readers
I reviewed the exact-head generated types, Zod contract, payment projection and copy mappings, legacy fallback codes, and regression coverage. The backend dependency is merged, the enum table now pins every supported decline reason, and the new value retains the server-provided retry action while avoiding a misleading card-decline presentation. All exact-head checks are settled green and no review threads are open.
|
|
…g table (Comfy-Org#19611) ## Summary A checkout link with no `plan` now sends the customer to pick a plan instead of to the `return_to` home. ## Changes - **Why**: DES-1209 rule for a no-`plan` link is "bounce back to the host's pricing table". Alex's answer (b) for Platform, which has no pricing table: "go to return_to. If that's missing or bad, go to the platform's billing page." Item 12 of the 2026-09-29 UX review. - **Root cause**: Comfy-Org#19462 routed a planless link through the same `sendToHost` as a `pricing` link, which resolves `return_to` to its registered home (`router.ts` `hostReturnHref`). It never looked at the pricing table. - **How**: - `router.ts` `planPickerHref` picks the destination. Any product but `platform` gets `pricingTableUrl` (the URL View plans already uses), on the Team tab when the link carries `team_credit_stop_id`. A `platform` link gets its own `return_to` when billing may follow it, else Platform's billing page. - "May follow" is read from the raw link, because `withCheckoutReturn` rewrites a missing or unregistered `return_to` to `comfyui_credits` before parsing. - `billing-contract` gains a `platform_billing` return target: `https://platform.comfy.org/profile/billing` and `https://stagingplatform.comfy.org/profile/billing`. That route is `pages/profile/billing.vue` in Comfy-Org/platform. The registry had no Platform billing URL, only the origin root (`platform_account`). Like `platform_account`, it has no `test`-family destination, so there a Platform link that needs the fallback is the existing "doesn't name a place we can send you back to" entry error. - **Flag off / M2**: this runs in the router before the session and the `billing_web_checkout_ui` read, so it applies to M2 and M3 alike, as the rule intends. The flag-off parity tests from Comfy-Org#19462 are unchanged except the expected URL. Signed-out, pending, minting, failed-sign-in and signed-in `embedded`/unreachable visitors still leave at once, with no sign-in page, no workspace bind and no flag fetch. An already-signed-in tab on `full_page` still gets Plan not available. The superseded-navigation guard is untouched. ## Review Focus - "Cloud host" is read as every product except `platform` (`comfyui`, `workshop`, `models`). The pricing table only exists in cloud, and cloud is already the checkout's fallback host. - `platform_billing` is also a registered `return_to` that a product may now send. It sits in the closed registry like the other targets. ## Screenshots (if applicable) Fixture build (`VITE_BILLING_ENV=test`, mocked `testcloud.comfy.org`). This is a URL-level change, so the evidence is where the tab lands, from the e2e run before and after the fix: | Link (`/v1/checkout?…`) | AS IS | TO BE | | --- | --- | --- | | `product=comfyui&return_to=comfyui_workspace&workspace=ws_team_e2e`, signed out | `testcloud.comfy.org/?workspace=ws_team_e2e` | `testcloud.comfy.org/?pricing=1&workspace=ws_team_e2e` | | same, signed in, new tab | `testcloud.comfy.org/?workspace=ws_e2e` | `testcloud.comfy.org/?pricing=1&workspace=ws_e2e` | | `…&team_credit_stop_id=stop_700` | `testcloud.comfy.org/?workspace=ws_team_e2e` | `testcloud.comfy.org/?pricing=team&workspace=ws_team_e2e` | | `product=platform&return_to=comfyui_workspace` | `testcloud.comfy.org/?workspace=ws_e2e` | unchanged (a followable `return_to`) | | `product=platform&return_to=nowhere` | `testcloud.comfy.org/?settings=plan-credits` | stays on billing, entry error (no Platform page in `test`) | The Platform billing page itself has no `test`-family destination, so unit tests cover it with `VITE_BILLING_ENV` stubbed to staging and production (`router.planless.test.ts`): unregistered `return_to` → `https://stagingplatform.comfy.org/profile/billing?workspace=ws-1`, missing `return_to` → `https://platform.comfy.org/profile/billing`, `return_to=platform_account` → `https://stagingplatform.comfy.org/?workspace=ws-1`. The first commit holds only the tests. Against the old router they fail with the AS IS URLs above (15 unit, 8 e2e). ## Where this PR sits in Milestone 3 | State | PR / ticket | Scope | |---|---|---| | Merged | Comfy-Org#19253 | M3 stack: FE-3018..3022 full page behind billing_web_checkout_ui | | Merged | Comfy-Org#19462 / Comfy-Org#19487 | Design review rounds 3-4 | | Merged | Comfy-Org#19540 Comfy-Org#19538 Comfy-Org#19536 Comfy-Org#19537 | UX pass: money state, lock/redirect, promo, summary/copy | | Merged | Comfy-Org#19531 | Accept `payment_not_completed` (must ship before cloud#11119) | | Open | **Comfy-Org#19611** (this PR) | Planless link goes to the plan picker | | Open | Comfy-Org#19612 | Visual pass: checkbox, dark dropdown, unbroken dates/IDs, settled copy | | Open | Comfy-Org#19613 | Restore a promo this page applied; discount rows in server order | | Blocked on BE | FE-3072 (BE-17842) | Top-up on the full page; op facts for receipt/credits lines | | Blocked on BE | BE-13104 / BE-17785 / BE-10064 | $0 due card, subtotal + list price + renewal_at, Phase-A cancel | | Next | M3-9 / M3-10 | Rollout via the flag, then delete the M2 path and the flag | ```mermaid flowchart LR classDef done fill:#e3f5e1,stroke:#2e7d32 classDef open fill:#dff0ff,stroke:#1f6feb classDef be fill:#fde2e2,stroke:#c0392b classDef me fill:#fff4cc,stroke:#b58900,stroke-width:3px S["PR 19253 M3 stack"]:::done --> R["PR 19462 / PR 19487 design rounds"]:::done R --> U["UX pass PR 19540 PR 19538 PR 19536 PR 19537"]:::done R --> PNC["PR 19531 payment_not_completed"]:::done U --> P611["PR 19611 planless destination"]:::open U --> P612["PR 19612 visual pass"]:::open U --> P613["PR 19613 promo restore + order"]:::open BE1["BE-17842 op facts + top-up quote"]:::be --> TU["FE-3072 top-up"]:::open BE2["BE-13104 / BE-17785 / BE-10064"]:::be -.-> FU["$0 card, subtotal, cancel"]:::open P611 --> RO["M3-9 rollout"] P612 --> RO P613 --> RO PNC --> BEDEP["cloud PR 11119 deploy after FE release"]:::be RO --> CL["M3-10 delete M2 path + flag"] class P611 me ```
…wn, unbroken dates and IDs, settled copy (Comfy-Org#19612) ## Summary Alex Tov's visual pass on the M3 full-page checkout (Slack, 2026-09-29): a checkbox outline that reads on its card, a saved-card list that opens dark, dates and reference codes that wrap in one piece, and settled-payment copy that names the workspace. ## Why Five findings from the designer's pass over the fixture build. The unticked box was near-invisible, the saved-card list opened white on a dark page, dates split before the year on phones ("…refill monthly after July 28, / 2026"), long UUID reference codes could split mid-segment, and the settled-while-watched body didn't match Figma 717-14670. ## Root cause - Checkbox: the unticked outline used `border-border-default`, which sits too close to `bg-tertiary-background`. - Dropdown: `dark-theme` lived on each view's wrapper, but Reka's `SelectPortal` teleports the list to `<body>`, outside every wrapper, so it resolved light tokens. - Dates: each formatter produced ordinary spaces, and there were three of them (`longDate`, the summary ledger's inline `Intl.DateTimeFormat` pair, `useHostedCopy().date`). - Code card: break opportunities were inserted only after underscores. Op IDs are UUIDs with hyphens. ## Changes - **What**: - Keep-subscription checkbox: the unticked outline is `border-muted-foreground`. Ticked and invalid states are unchanged. - Saved-card dropdown: `dark-theme` now sits on `<html>` in `apps/billing-web/index.html`. Every billing-web surface is dark, so portalled UI now gets the dark tokens too, and the list's `bg-base-background` matches the trigger. - Dates: `longDate.ts` owns every date in billing-web copy and joins it with non-breaking spaces (`unbrokenDate`). The summary ledger's `date`/`monthDay` and `useHostedCopy().date` now go through it. - Reference code card: splits on `/(?<=[_-])/`, adding a break opportunity after each hyphen as well as each underscore (372-4951). - Settled while watched (717-14670): "A payment for {workspace} went through. Check your plan in settings for the details." `{workspace}` is the session's workspace name, which the page already passes to every ending. Without a session name it falls back to the existing `ending.thisWorkspace` copy ("A payment for this workspace went through."). ## How TDD. Tests were changed first and confirmed red, then the fix turned them green. - Pure-string tests (`summaryLedger.test.ts`, `keepSubscription.test.ts`) now spell dates with ` `. DOM tests using `getByText`/`toHaveTextContent` normalise whitespace (NBSP included), so they can't observe the change and stay as they were. - `CheckoutEnding.test.ts` pins the code card's break opportunities for a UUID and an underscore code, plus the new settled copy. - New e2e in `full-page-checkout.spec.ts`: the open saved-card list's computed background equals its trigger's. Before the fix it was `rgb(255, 255, 255)` against `rgb(23, 23, 24)`. ## Review Focus - `dark-theme` on `<html>` makes the per-view wrapper classes redundant. I left those untouched to keep this diff off files other in-flight PRs are editing. Removing them is a follow-up. - Chromium already breaks after a hyphen before a digit, so the code card looks the same in both builds there. The explicit `<wbr>` covers engines that apply UAX Comfy-Org#14 LB25 (no break between a hyphen and a number) and fall back to `wrap-anywhere` mid-segment. ## Screenshots (if applicable) All images are from the **fixture build**: the billing-web Playwright fixtures (mocked Cloud, fake Stripe.js), production `vite build`, dark theme, 1512×982 unless the row says phone (390×844). AS IS is `origin/main`, TO BE is this PR. None are from a real backend. ### AS IS / TO BE | Item | AS IS (fixture build) | TO BE (fixture build) | | --- | --- | --- | | 1. Unticked keep-subscription box, close-up | <img width="384" alt="checkbox close-up AS IS" src="https://github.com/user-attachments/assets/87363a1f-b7c9-42a8-8c2c-257102f31abb" /> | <img width="384" alt="checkbox close-up TO BE" src="https://github.com/user-attachments/assets/f1d97bbe-f956-49e4-8902-cf5aacd822c1" /> | | 1. Unticked keep-subscription box, full page | <img width="420" alt="checkbox AS IS" src="https://github.com/user-attachments/assets/09d2695e-9169-4c3d-becf-27ad97db9ee9" /> | <img width="420" alt="checkbox TO BE" src="https://github.com/user-attachments/assets/1c636614-e243-4161-9a91-95467ba1818b" /> | | 2. Saved-card dropdown open | <img width="420" alt="dropdown AS IS" src="https://github.com/user-attachments/assets/71a7474e-965f-4404-b7e3-e550476edf99" /> | <img width="420" alt="dropdown TO BE" src="https://github.com/user-attachments/assets/ecc37316-ed0d-480d-a9e2-4848946b9a52" /> | | 3. Scheduled downgrade summary, phone: "refill monthly after July 28, 2026" | <img width="220" alt="dates phone AS IS" src="https://github.com/user-attachments/assets/edba88d1-5c17-4570-91f0-b76cccb34241" /> | <img width="220" alt="dates phone TO BE" src="https://github.com/user-attachments/assets/f749c264-1a0a-4455-80c0-b56bdcab28e3" /> | | 4. Payment in progress with a UUID reference, phone. Same render in Chromium (see Review Focus) | <img width="220" alt="code phone AS IS" src="https://github.com/user-attachments/assets/94605dba-b20d-4363-9d2c-1ff7552c581e" /> | <img width="220" alt="code phone TO BE" src="https://github.com/user-attachments/assets/def1eb20-e316-4701-bc2e-3a5937dd8e30" /> | | 5. Payment in progress settles while watched (717-14670); fixture workspace is "Personal" | <img width="420" alt="settled AS IS" src="https://github.com/user-attachments/assets/b2612aea-503e-4988-b04f-732cbbf7a3ae" /> | <img width="420" alt="settled TO BE" src="https://github.com/user-attachments/assets/9271831b-a733-493b-b2b9-c5d5b0a5f6b3" /> | ## Where this PR sits in Milestone 3 | State | PR / ticket | Scope | |---|---|---| | Merged | Comfy-Org#19253 | M3 stack: FE-3018..3022 full page behind billing_web_checkout_ui | | Merged | Comfy-Org#19462 / Comfy-Org#19487 | Design review rounds 3-4 | | Merged | Comfy-Org#19540 Comfy-Org#19538 Comfy-Org#19536 Comfy-Org#19537 | UX pass: money state, lock/redirect, promo, summary/copy | | Merged | Comfy-Org#19531 | Accept `payment_not_completed` (must ship before cloud#11119) | | Open | Comfy-Org#19611 | Planless link goes to the plan picker | | Open | **Comfy-Org#19612** (this PR) | Visual pass: checkbox, dark dropdown, unbroken dates/IDs, settled copy | | Open | Comfy-Org#19613 | Restore a promo this page applied; discount rows in server order | | Blocked on BE | FE-3072 (BE-17842) | Top-up on the full page; op facts for receipt/credits lines | | Blocked on BE | BE-13104 / BE-17785 / BE-10064 | $0 due card, subtotal + list price + renewal_at, Phase-A cancel | | Next | M3-9 / M3-10 | Rollout via the flag, then delete the M2 path and the flag | ```mermaid flowchart LR classDef done fill:#e3f5e1,stroke:#2e7d32 classDef open fill:#dff0ff,stroke:#1f6feb classDef be fill:#fde2e2,stroke:#c0392b classDef me fill:#fff4cc,stroke:#b58900,stroke-width:3px S["PR 19253 M3 stack"]:::done --> R["PR 19462 / PR 19487 design rounds"]:::done R --> U["UX pass PR 19540 PR 19538 PR 19536 PR 19537"]:::done R --> PNC["PR 19531 payment_not_completed"]:::done U --> P611["PR 19611 planless destination"]:::open U --> P612["PR 19612 visual pass"]:::open U --> P613["PR 19613 promo restore + order"]:::open BE1["BE-17842 op facts + top-up quote"]:::be --> TU["FE-3072 top-up"]:::open BE2["BE-13104 / BE-17785 / BE-10064"]:::be -.-> FU["$0 card, subtotal, cancel"]:::open P611 --> RO["M3-9 rollout"] P612 --> RO P613 --> RO PNC --> BEDEP["cloud PR 11119 deploy after FE release"]:::be RO --> CL["M3-10 delete M2 path + flag"] class P612 me ```
… discount rows in server order (Comfy-Org#19613) ## Summary Implements Alex Tov's decisions (a) and (c) from the M3 design review: a promo code applied on the full-page checkout survives a reload or a 3DS/Alipay return, and the summary lists discount rows in the order the server returns them. ## Changes - **Why**: - (a) A code applied on this page was lost after a reload or a provider return, and the price rose with no explanation. The no-auto-apply rule covers codes arriving from outside links; a code applied here must come back. - (c) The entered code rendered in its own slot after the held discounts, whatever order the quote listed them in. - **Root cause**: - (a) The applied code lived only in the in-memory `PromoEntry` state. The subscribe return URL carries only the link's own `promo`, so every fresh mount started from the link, not from what the customer applied. - (c) `summaryLedger.ts` split promotions into `adjustments` (held) and a separate `promo` row (entered), and `CheckoutLedger.vue` rendered them in two places. - **How**: - New `checkout/promoMemory.ts` keeps one `{ identity, code }` record in `sessionStorage`. The identity is the checkout request (workspace, product, plan, team credit stop), so another checkout reads nothing and drops the stale record. Every storage access sits in try/catch; without storage the page behaves as before. Nothing is written to the page URL or the return URL. - `initialPromoEntry` takes the recalled code and starts `applied`, so the existing capture read (`requoteWithPromo`) re-prices it through the normal quote. A server refusal lands on the existing "Your promo code expired" card (Figma 476-14445). - `useCheckoutPromo` writes the remembered code after each reducer transition that changes it (pure `codeToRemember`), so Remove and an expiry clear it. `useFullPageCheckout` clears it when the page reaches a terminal state. - `SummaryLedger.discounts` replaces `adjustments`, `promo` and `subtotal`: every `promotion` discount becomes a row in server order, labelled `name ?? "Promo code"`, at the server's amount. The removable chip on the entered code is unchanged. `subtotal` was never populated (the quote reports no pre-discount base) and had no position once the entered-code slot went away, so it is removed with its i18n key. ## Review Focus - Chips keep their existing order (held codes, then the entered code). Only the money rows follow server order. - A restored code outranks a link's `promo` prefill for the same checkout identity. - Tests: reducer seed cases, `promoMemory` (identity scoping, malformed records, throwing storage), ledger server order, view-level reload/refuse/remove/success/other-plan/return-URL cases, and four new e2e specs (reload keeps the discount, refusal on reload shows the expired card, a copied URL carries no applied code, entered code listed first renders first). ## Screenshots (if applicable) Fixture build (billing-web e2e mocks), dark, 1512×982. | Case | AS IS | TO BE | | --- | --- | --- | | Apply LAUNCH20, reload | <img width="600" alt="AS IS reload" src="https://github.com/user-attachments/assets/bf222d93-cdf2-49b3-88c0-c9d8a7ee2986" /> | <img width="600" alt="TO BE reload" src="https://github.com/user-attachments/assets/552839e4-240b-404a-9d09-351f9e7b5901" /> | | Apply, server refuses the code on reload | <img width="600" alt="AS IS refused" src="https://github.com/user-attachments/assets/f73a8a14-784a-4cb4-bc30-545dfefe558e" /> | <img width="600" alt="TO BE refused" src="https://github.com/user-attachments/assets/63d358de-0cb2-4e74-9ad6-451d88ae3525" /> | | Server lists the entered code first | <img width="600" alt="AS IS order" src="https://github.com/user-attachments/assets/26af2ea4-6d98-42f6-8b4d-8601310b49c9" /> | <img width="600" alt="TO BE order" src="https://github.com/user-attachments/assets/86a12997-06ca-4a12-baf1-4e169afb8ce5" /> | ## Where this PR sits in Milestone 3 | State | PR / ticket | Scope | |---|---|---| | Merged | Comfy-Org#19253 | M3 stack: FE-3018..3022 full page behind billing_web_checkout_ui | | Merged | Comfy-Org#19462 / Comfy-Org#19487 | Design review rounds 3-4 | | Merged | Comfy-Org#19540 Comfy-Org#19538 Comfy-Org#19536 Comfy-Org#19537 | UX pass: money state, lock/redirect, promo, summary/copy | | Merged | Comfy-Org#19531 | Accept `payment_not_completed` (must ship before cloud#11119) | | Open | Comfy-Org#19611 | Planless link goes to the plan picker | | Open | Comfy-Org#19612 | Visual pass: checkbox, dark dropdown, unbroken dates/IDs, settled copy | | Open | **Comfy-Org#19613** (this PR) | Restore a promo this page applied; discount rows in server order | | Blocked on BE | FE-3072 (BE-17842) | Top-up on the full page; op facts for receipt/credits lines | | Blocked on BE | BE-13104 / BE-17785 / BE-10064 | $0 due card, subtotal + list price + renewal_at, Phase-A cancel | | Next | M3-9 / M3-10 | Rollout via the flag, then delete the M2 path and the flag | ```mermaid flowchart LR classDef done fill:#e3f5e1,stroke:#2e7d32 classDef open fill:#dff0ff,stroke:#1f6feb classDef be fill:#fde2e2,stroke:#c0392b classDef me fill:#fff4cc,stroke:#b58900,stroke-width:3px S["PR 19253 M3 stack"]:::done --> R["PR 19462 / PR 19487 design rounds"]:::done R --> U["UX pass PR 19540 PR 19538 PR 19536 PR 19537"]:::done R --> PNC["PR 19531 payment_not_completed"]:::done U --> P611["PR 19611 planless destination"]:::open U --> P612["PR 19612 visual pass"]:::open U --> P613["PR 19613 promo restore + order"]:::open BE1["BE-17842 op facts + top-up quote"]:::be --> TU["FE-3072 top-up"]:::open BE2["BE-13104 / BE-17785 / BE-10064"]:::be -.-> FU["$0 card, subtotal, cancel"]:::open P611 --> RO["M3-9 rollout"] P612 --> RO P613 --> RO PNC --> BEDEP["cloud PR 11119 deploy after FE release"]:::be RO --> CL["M3-10 delete M2 path + flag"] class P613 me ```
…ompleted decline reason (#19670) ## Summary Backport of #19531 to `cloud/1.55`. Accepts the op-status `decline_reason` value `payment_not_completed` so checkout settles once Comfy-Org/cloud#11119 deploys. ## Why Comfy-Org/cloud#11119 is merged on cloud main and ships with the next backend release, before frontend 1.56 reaches cloud prod. On 1.55, `operationLifecycle.ts` parses `GET /billing/ops/:id` with `zBillingOpStatusResponse.safeParse`, whose `decline_reason` is a closed 8-value enum. A `payment_not_completed` value fails the whole parse, so Pay spins and checkout never settles. Prod runs 1.54.15 today, which does not zod-parse op status, so there the new value only degrades copy. 1.55 is what cloud staging and prod move to next. ## Changes Cherry-picked from #19531 (`-x`), one conflict resolved. - `packages/ingest-types`: adds `payment_not_completed` to the op-status `decline_reason` enum and its doc line in `types.gen.ts` and `zod.gen.ts`. No regeneration against cloud main, so no unrelated spec drift. - `account-core` `paymentCopy.ts`: `declineDetailKey` maps it to `authenticationFailedDetail`; adds `billing.reason.payment_not_completed`. - billing-web `payVerdict.ts`: joins the not-completed reasons. The M3 full-page checkout is already on 1.55 (#19460 backport), so this hunk applies as on main. - `billingOperationStore.ts`: `payment_not_completed` plus the raw `payment_method_customer_decline` / `payment_intent_payment_attempt_expired` codes read as the verification detail. - Tests: contract `DECLINE_REASONS` table with a parse row per reason, `paymentCopy`, `paymentProjection`, `payVerdict`, `CheckoutView`, `FullPageCheckoutView`, `subscriptionOperationView`, `billingOperationStore` rows, and the full-page e2e test. Not included: the e2e conflict pulled in a neighbouring main-only test (`314-10612` processing-error card) as hunk context. It is dropped; only the `payment_not_completed` e2e test is kept. ## Verification On the branch after `pnpm install`: - `pnpm typecheck` (root, `--max-old-space-size=8192`): clean. Pre-commit also ran `typecheck:app`, `typecheck:billing-web`, `typecheck:account-core`. - Unit: account-core 1246 passed, billing-web 774 passed, app `src/platform/workspace/billing` + `billingOperationStore` 353 passed. - `pnpm lint`: 0 errors. `pnpm knip`: clean. - Mutation check: removing `'payment_not_completed'` from `zBillingOpStatusResponse` fails `accepts a failed status declined as payment_not_completed`. Refs BE-17784, Comfy-Org/cloud#11119
…e, discount duration, balance and receipts (Comfy-Org#19672) ## Summary The full-page checkout now shows the numbers the backend started reporting on 2026-09-30: the pre-discount subtotal, a discounted plan's list price, each coupon's term, the account balance applied today, and what a settled payment charged, added and bought. ## Changes - **Why**: cloud Comfy-Org#11148 (BE-17785) added `subtotal_cents`, `new_plan.list_price_cents` and `discounts[].duration` / `duration_in_months` to the checkout quote; cloud Comfy-Org#11223 added `balance_applied_cents`; cloud Comfy-Org#11199 (BE-17842) added `amount_charged_cents`, `credits_added` and `plan` to a succeeded op status. Alex's decisions in DES-1210 / DES-1211 / DES-1212 held these slots until the backend reported them ("no Subtotal until the quote reports one", "no discounted-rate strikethrough until the quote has a list price", "Success credits line stays off until BE-17842"). All four are on cloud main. - **Root cause** (the monthly-to-yearly `renewal_at` gap): our e2e fixture quoted that transition without `renewal_at`; the real backend returns it, so the undated copy was never the backend's answer. - **How**: - `@comfyorg/ingest-types` regenerated from cloud@0dbfffb the way cloud's push-ingest-types workflow does it (`openapi-project -fe`, `pnpm generate`, `oxfmt`). account-core reads the new int64 amounts as safe integers, like the existing cents (shared `wireCents`), and keeps the generated Zod strict. - account-core: a succeeded operation carries a `receipt` (amount charged, credits added, plan), each absent while the server cannot say it. `recover({ includeSettled: true })` re-reads a success whose credits are still landing, the way it already re-reads a parked reconciliation. - Summary (`summaryLedger.ts`, `CheckoutLedger.vue` split into `LedgerRows` / `LedgerItem` / `LedgerDeduction`): a discounted plan rate shows its list price struck through; a discount row states its term ("First year" / "First month" for `once`, "For N months" for `repeating`, nothing for `forever` or an unknown term); "Account balance −$X / Credit already on your account" is the last deduction (744-15697) and keeps the prorated row it explains instead of dropping it; Subtotal (re-added after Comfy-Org#19613 removed it) shows only where a discount follows two or more money rows. - Endings (`endingScreen.ts`, `CheckoutEnding.vue`): Success counts the credits the op reports (77-4068). Already completed and You're all set name the plan the receipt names, priced from the catalog (328-4444), in place of the reference code. A top-up's Already completed lists Added and Amount paid and no balance (410-5225). A charge whose credits are still landing reads Payment received with Payment / Credits added "Adding…" / Plan rows (390-4947), re-reads on the parked cadence, and resolves to Success or Already completed once the credits land. - Success card, paid today (Alex, FE-3021 "Added 2026-09-30", 758-15763 / 765-15713; same bug as FE-2119 in the old flow): the card priced the plan from `new_plan.price_cents`, so a promo showed the full rate. When the server-reported charge differs from that rate, the card keeps the rate, adds a divider, one row per reason, then "Paid today". `successBreakdown.ts` decides the rows as a pure projection and reuses the summary's discount and balance rows (`LedgerDeduction` / `LedgerItem`). Paid today is `amount_charged_cents` from the succeeded op when the page read one, else the quote's `amount_due_cents` for this page's own Pay. Reasons: the entered code, a discount the subscription already holds (with its term), and the account balance. A prorated change reads only Paid today with "Prorated for the rest of this billing period". A plan-level rate, a scheduled change, and a charge equal to the rate get no rows. - e2e fixtures: `switchToYearly` quotes a monthly-to-yearly switch the way the real backend does, with `renewal_at`, `list_price_cents` and `subtotal_cents`. The earlier "renewal_at BE gap" on this transition came from our fixture, not the backend. - **Breaking**: none. Every field is optional and each slot renders only when the server reports its number. **Rule 2.** Every amount and count on these screens is a number the server reported: quote fields, op status fields, or the plan catalog. The page adds, subtracts, divides and converts nothing; `centsToCredits` is not used on any outcome screen. ## Review Focus - **Needs a decision: per-month compare price.** Figma shows "$630 ~~$700~~ /mo × 12 months, billed yearly". The quote reports `price_cents` and `list_price_cents` per billing period, so a yearly plan renders "$7,560 ~~$8,400~~ /yr, billed yearly". The per-month form would need either a `/ 12` on the page (Rule 2) or per-month fields from the backend. - **Subtotal is not reachable yet.** Every family has at most one money row today, so the ≥2-rows rule never fires. It fires once itemized proration lands. - **Itemized proration is left out.** cloud Comfy-Org#11252 (`proration_remaining_cents` / `proration_unused_cents`, plus `renewal_at` without the embedded flag) is still open, so the prorated row keeps its single stand-in subline. - **Discount term for `once` on a monthly plan** reads "First month". DES-1211 only specifies "first year" (on yearly). - **Server gap on the Success breakdown.** After a payment-provider return (3DS, Alipay) the page reads only the op status, so the card shows "Paid today" (`amount_charged_cents`) against the catalog rate with no reason rows: the op status reports no promo, discount, balance or proration. It also cannot say a charge was prorated, so the subline is absent there. Itemized reasons on that path need the op status to report them. - `settledPlanRead` now applies to any settled page this tab did not price (receipt plan, else the status's plan for a returned payment); the page's own Pay still names the plan from its quote. - The generated `new_free_tier_subscriptions` field disappears from `GetFeaturesResponse`. It was hand-added to the generated files in Comfy-Org#12170 and is not in the cloud spec; `apps/website` extends the schema with it and `RemoteConfig` declares it, so nothing reads it from ingest-types. ## Screenshots (if applicable) Fixture build (billing-web e2e mocks), dark, 1512×982. | Case | AS IS | TO BE | | --- | --- | --- | | Monthly to yearly, list price, first-year promo | <img width="600" alt="asis-summary-yearly" src="https://github.com/user-attachments/assets/6164b359-33f5-4143-94df-3f852b45eb49" /> | <img width="600" alt="tobe-summary-yearly" src="https://github.com/user-attachments/assets/86eef478-c83f-4880-a7b0-d5d4963b32dc" /> | | Prorated upgrade over an account balance | <img width="600" alt="asis-summary-balance" src="https://github.com/user-attachments/assets/e2786a06-da16-41c0-b96b-f677172f2aab" /> | <img width="600" alt="tobe-summary-balance" src="https://github.com/user-attachments/assets/db103f1b-badb-4d65-8d52-b58ea542e6d7" /> | | Success with the credits the op reports | <img width="600" alt="asis-ending-success" src="https://github.com/user-attachments/assets/65d79420-51d4-415b-ad00-5b7b060cdf02" /> | <img width="600" alt="tobe-ending-success" src="https://github.com/user-attachments/assets/6e4b6f36-95e4-4b23-b57b-601401c60d7e" /> | | Charge whose credits are still landing | <img width="600" alt="asis-ending-received" src="https://github.com/user-attachments/assets/7902f4bc-39a2-4c29-b6ad-447d3d7bf28f" /> | <img width="600" alt="tobe-ending-received" src="https://github.com/user-attachments/assets/a6b4e9f2-aad7-4496-9592-311e8de8eaec" /> | | Reload once the credits landed | <img width="600" alt="asis-ending-already" src="https://github.com/user-attachments/assets/83e80707-2f11-4971-af86-6620e00d76d9" /> | <img width="600" alt="tobe-ending-already" src="https://github.com/user-attachments/assets/477429b2-7cc6-4dc2-a8e5-a8a08880be02" /> | | Success under a promo code | <img width="600" alt="asis-success-discount" src="https://github.com/user-attachments/assets/8bdf911e-f195-4968-a069-5790303e5ec3" /> | <img width="600" alt="tobe-success-discount" src="https://github.com/user-attachments/assets/c3d5f7ae-f466-4df8-bdf1-6dd22ec62951" /> | | Success after a prorated upgrade | <img width="600" alt="asis-success-prorated" src="https://github.com/user-attachments/assets/b1cd2088-a8d2-4afe-a7a0-3a5d43f2b06f" /> | <img width="600" alt="tobe-success-prorated" src="https://github.com/user-attachments/assets/b66e7c28-e2c6-4e1d-8e42-c82879553548" /> | ## Where this PR sits in Milestone 3 | State | PR / ticket | Scope | |---|---|---| | Merged | Comfy-Org#19253 | M3 stack: FE-3018..3022 full page behind `billing_web_checkout_ui` | | Merged | Comfy-Org#19462 / Comfy-Org#19487 | Design review rounds 3-4 | | Merged | Comfy-Org#19540 Comfy-Org#19538 Comfy-Org#19536 Comfy-Org#19537 | UX pass: money state, lock/redirect, promo, summary/copy | | Merged | Comfy-Org#19531 | Accept `payment_not_completed` | | Merged | Comfy-Org#19611 Comfy-Org#19612 Comfy-Org#19613 | Follow-ups: planless link, visual pass, promo restore + server order | | Merged (BE) | cloud Comfy-Org#11148 Comfy-Org#11223 Comfy-Org#11188 Comfy-Org#11199 | Quote subtotal / list price / discount term / balance, top-up quote, op receipt | | Open (BE) | cloud Comfy-Org#11252 | `renewal_at` without the flag, itemized proration | | Open | **this PR** | Server-reported subtotal, list price, discount term, balance and receipts | | Open | Comfy-Org#19673 (stacked on this PR) | FE-3072 credit top-up on the full page | | Next | M3-9 / M3-10 | Rollout via the flag, then delete the M2 path and the flag | ```mermaid flowchart LR classDef done fill:#e3f5e1,stroke:#2e7d32 classDef open fill:#dff0ff,stroke:#1f6feb classDef be fill:#fde2e2,stroke:#c0392b classDef me fill:#fff4cc,stroke:#b58900,stroke-width:3px S["PR 19253 M3 stack"]:::done --> R["PR 19462 / PR 19487 design rounds"]:::done R --> U["UX pass PR 19540 PR 19538 PR 19536 PR 19537"]:::done R --> PNC["PR 19531 payment_not_completed"]:::done U --> F["Follow-ups PR 19611 PR 19612 PR 19613"]:::done BE1["cloud 11148 / 11223 quote fields"]:::done --> ME["FE-3019 server-reported fields"] BE2["cloud 11199 op receipt"]:::done --> ME F --> ME BE3["cloud 11188 top-up quote"]:::done --> TU["FE-3072 top-up on the full page"]:::open ME --> TU BE4["cloud 11252 itemized proration"]:::be -.-> PR["Proration rows"]:::open TU --> RO["M3-9 rollout"] ME --> RO RO --> CL["M3-10 delete M2 path + flag"] class ME me ```
…omfy-Org#19673) ## Summary A `/v1/top-up` link now opens a credit top-up on the full-page checkout: the summary leads with the credits the server quotes for the link's amount, Pay charges the method on file through the billing SDK's top-up command, and the endings report what the operation added and cost. Builds on Comfy-Org#19672 (merged). ## Changes - **Why**: FE-3072 (Alex's M3 review, 2026-09-28): the full-page checkout handles top-ups too. Figma 265-4362 (summary: credits first, expiry from the server, no promo), 77-3783 (Success and Already completed, op facts only), 394-4991 (receipt). cloud Comfy-Org#11188 (BE-17842) added the read-only top-up quote this needs, and cloud Comfy-Org#11199 the op receipt the endings read. Both are on cloud main. - **Root cause** (why a top-up link failed before): the entry contract had no top-up intent, so `/v1/top-up` was an unreadable link, and billing-web had no quote or route for it. - **How**: - `@comfyorg/billing-contract`: a `top-up` intent with `amount_cents`, the amount the product asks for in whole cents. The builder and the parser refuse anything but a positive whole number of cents with `INVALID_AMOUNT`. The amount is the customer's quantity, not a price. - `@comfyorg/account-core`: `topup.quoteTopup({ amountCents })` reads `POST /billing/topup/quote` (no idempotency key; nothing is charged). A 404 is `NOT_AVAILABLE`, a refused amount `INVALID_AMOUNT`, and the credits and amount are read as safe integers. - billing-web: `TopupRouteView` renders `FullPageTopupView` on the `billing_web_checkout_ui` full-page flag. `useFullPageTopup` drives the same `CheckoutPage` reducer as the subscription checkout: it reconciles first, reads `can_top_up`, quotes the amount, and pays through `useTopUp` (the SDK top-up command on the `billing_sdk_topup_enabled` rail), on the method on file. `topupVerdictOf` maps the command's result onto the existing Pay verdicts. `buildTopupLedger` leads with the quoted credits and dates them "Expire {date}" from the quote's `expires_at`, with no promo entry. Success reads "{N} credits added" with Added and Amount paid; credits still landing read Payment received; a revisit is Already completed. - `useCheckoutExit` and `reconciledEvent` move out of `useFullPageCheckout` so both checkouts share them. - Design review answers (Alex, 2026-09-30): - A one-time code reads "This payment only" on a change to a monthly plan. A new monthly subscription keeps "First month", and a yearly plan keeps "First year" (DES-1211) for a new subscription and a change alike. `discountTerm` picks the copy from the quote's `transition_type` and the new plan's duration; no money logic changes. - Top-up Success and Already completed put the credits icon (`icon-[lucide--coins]`, as on the plan card and summary) on the Added value (77-4102, 410-5225). - Top-up Pay reads "Pay", and the terms line reads "…charge your payment method once for this purchase." with Terms and Privacy Policy linked through the shared `CheckoutTermsNote` (180-6679). - A top-up link with no amount or an unreadable amount ends on "This link isn't valid" with `CHECKOUT_LINK_INVALID`, Add credits to the workspace's Plan & Credits settings, and Contact support (769-15773). It is a new `amount_invalid` reason mapped to a `link_invalid` ending. `App.vue` lets the top-up route explain an `INVALID_AMOUNT` link instead of the generic entry error. Subscription links keep "This plan isn't available". - **Breaking**: none. `TopupCommand` gains `quoteTopup`, so its fakes gain one too. **Rule 2.** The credits, the expiry, the amount charged and the credits added are the server's numbers. The page does not convert the amount into credits, and it states no expiry policy of its own. ## Review Focus - A revisit of a top-up this tab already saw succeed ends on Already completed. A top-up link is always for sale, so without this the page would offer a second form. - Top-up Success leaves out the Previous balance and New balance rows from 77-3783. They would need two balance reads around the charge, and DES-1212 already keeps balance rows off Already completed because a balance can be stale. Say if Success should show them. - "This payment only" is limited to monthly plan changes, the case Alex's answer named. A one-time code on a yearly plan still reads "First year", on a switch to yearly too. - A top-up link that is unreadable for any reason other than its amount (an unknown product, say) still ends on the generic entry error page, as before. - Nothing in the host app builds a top-up link yet. This PR adds the contract, the page and the quote. - On the embedded variant of the flag the route shows the entry error. There is no embedded top-up on billing-web. ## Screenshots (if applicable) Fixture build (billing-web e2e mocks), dark, 1512×982. | Case | AS IS | TO BE | | --- | --- | --- | | `/v1/top-up?amount_cents=2500` | <img width="600" alt="asis-topup-summary" src="https://github.com/user-attachments/assets/e54024c4-1c18-493a-9503-2150244a90a5" /> | <img width="600" alt="tobe-topup-summary" src="https://github.com/user-attachments/assets/3f964432-279e-4850-805b-89a36d2a1889" /> | | Pay goes through | n/a | <img width="600" alt="tobe-topup-success" src="https://github.com/user-attachments/assets/af7607ee-9134-44be-bd03-388239133b70" /> | | Credits still landing | n/a | <img width="600" alt="tobe-topup-received" src="https://github.com/user-attachments/assets/88b5bf5b-3705-4d72-81da-b2066a46c1b4" /> | | Reload once they land | n/a | <img width="600" alt="tobe-topup-already" src="https://github.com/user-attachments/assets/5d91e64d-a2da-4ede-956e-41132bf5d9c0" /> | Design review answers, fixture build (billing-web e2e mocks), 1280×860. AS IS is the previous head `a893946ddc`. | Case | AS IS | TO BE | | --- | --- | --- | | Top-up Success, credits icon on Added (77-4102) | <img width="600" alt="asis-topup-success" src="https://github.com/user-attachments/assets/124b0226-3cbc-4ae2-a34e-28120cd8bc83" /> | <img width="600" alt="tobe-topup-success" src="https://github.com/user-attachments/assets/dc68d101-41a1-4251-a77f-6c949411e261" /> | | Top-up Pay button and terms (180-6679) | <img width="600" alt="asis-topup-pay" src="https://github.com/user-attachments/assets/bf977000-5be6-457c-8a90-187d401e1c14" /> | <img width="600" alt="tobe-topup-pay" src="https://github.com/user-attachments/assets/ec51cc45-39cd-4a27-9165-0e7e2e2af8c4" /> | | `/v1/top-up` with no amount (769-15773) | <img width="600" alt="asis-topup-invalid" src="https://github.com/user-attachments/assets/e9f8b70d-bd09-458a-9411-64f1ddc7da10" /> | <img width="600" alt="tobe-topup-invalid" src="https://github.com/user-attachments/assets/9bd1399c-11e7-48d4-8e5e-4d600de0ea3c" /> | | One-time code on a plan change | <img width="600" alt="asis-change-once" src="https://github.com/user-attachments/assets/a2d0b587-f42e-4f37-a584-f59044883496" /> | <img width="600" alt="tobe-change-once" src="https://github.com/user-attachments/assets/1153d17c-34a8-4c1c-8369-33f3cb616295" /> | ## Where this PR sits in Milestone 3 | State | PR / ticket | Scope | |---|---|---| | Merged | Comfy-Org#19253 | M3 stack: FE-3018..3022 full page behind `billing_web_checkout_ui` | | Merged | Comfy-Org#19462 / Comfy-Org#19487 | Design review rounds 3-4 | | Merged | Comfy-Org#19540 Comfy-Org#19538 Comfy-Org#19536 Comfy-Org#19537 | UX pass: money state, lock/redirect, promo, summary/copy | | Merged | Comfy-Org#19531 | Accept `payment_not_completed` | | Merged | Comfy-Org#19611 Comfy-Org#19612 Comfy-Org#19613 | Follow-ups: planless link, visual pass, promo restore + server order | | Merged (BE) | cloud Comfy-Org#11148 Comfy-Org#11223 Comfy-Org#11188 Comfy-Org#11199 | Quote subtotal / list price / discount term / balance, top-up quote, op receipt | | Open (BE) | cloud Comfy-Org#11252 | `renewal_at` without the flag, itemized proration | | Merged | Comfy-Org#19672 | FE-3019 server-reported subtotal, list price, discount term, balance and receipts | | Open | **this PR** | FE-3072 credit top-up on the full page | | Next | M3-9 / M3-10 | Rollout via the flag, then delete the M2 path and the flag | ```mermaid flowchart LR classDef done fill:#e3f5e1,stroke:#2e7d32 classDef open fill:#dff0ff,stroke:#1f6feb classDef be fill:#fde2e2,stroke:#c0392b classDef me fill:#fff4cc,stroke:#b58900,stroke-width:3px S["PR 19253 M3 stack"]:::done --> R["PR 19462 / PR 19487 design rounds"]:::done R --> U["UX pass PR 19540 PR 19538 PR 19536 PR 19537"]:::done R --> PNC["PR 19531 payment_not_completed"]:::done U --> F["Follow-ups PR 19611 PR 19612 PR 19613"]:::done BE1["cloud 11148 / 11223 quote fields"]:::done --> SR["PR 19672 server-reported fields"]:::done BE2["cloud 11199 op receipt"]:::done --> SR F --> SR BE3["cloud 11188 top-up quote"]:::done --> ME["FE-3072 top-up on the full page"] SR --> ME BE4["cloud 11252 itemized proration"]:::be -.-> PR["Proration rows"]:::open ME --> RO["M3-9 rollout"] SR --> RO RO --> CL["M3-10 delete M2 path + flag"] class ME me ```
Summary
Accept the new
decline_reasonvaluepayment_not_completedfrom Comfy-Org/cloud#11119 (BE-17784) and show it as "Payment not completed", the same outcome asauthentication_failed/authentication_required.Deploy order: this must reach prod before cloud#11119 deploys.
Why
cloud#11119 reports Stripe
payment_method_customer_declineandpayment_intent_payment_attempt_expired(an Alipay payment the customer did not approve, or an attempt that expired) asdecline_reason: payment_not_completedonGET /api/billing/ops/{id}. The frontend parses that response strictly:zBillingOpStatusResponsehasdecline_reasonas a closed 8-value enum. Once the backend ships, every op status carrying the new value fails to parse, and checkout never settles. The embedded checkout in the app and billing-web both read this response.Root cause
packages/ingest-typesis generated from the cloud OpenAPI spec, and the spec change in cloud#11119 has not been synced yet. The mapping sites (declineDetailKey, billing-web's not-completed verdict, the legacy store's detail switch) also don't know the value.Changes
packages/ingest-types: regenerated with the cloud sync pipeline (openapi-project -fe,pnpm generate,oxfmt) against cloud#11119's head. Its spec differs from the last sync (cloud@3932a04, [chore] Update Ingest API types from cloud@3932a04 #19427) only by this enum value, so the diff is exactly the new member and its doc line. Zod stays strict.account-coredeclineDetailKey:payment_not_completedmaps toauthenticationFailedDetail("We couldn't complete payment verification. Please try again."), used by the M2 embedded checkout and the app's billing SDK views. Newbilling.reason.payment_not_completedcopy.payVerdict:payment_not_completedjoins the not-completed reasons, so the full page shows the "Payment not completed" card with no "Reported issue" line.billingOperationStore:payment_not_completed, plus the rawpayment_method_customer_decline/payment_intent_payment_attempt_expiredcodes that can arrive inerror_message, read as the verification detail.Review Focus
recovery_action: retry/retryable: true.retryis already in the FE enum and handled, so no change is needed for it.decline_reasonto aDECLINE_REASONStable that each row parses, so the next enum change fails a named test.Refs BE-17784, Comfy-Org/cloud#11119
Screenshots
billing-web full page, e2e fixture build, Pay returns an op with
decline_reason: payment_not_completed.AS IS: the op status fails the Zod parse, so Pay spins indefinitely (still spinning 25s later). TO BE: the Payment not completed card, with Pay usable again.