Repository navigation
[backport cloud/1.55] BE-17784 fix(billing): accept the payment_not_completed decline reason - #19670
Conversation
…ompleted decline reason Backport of #19531. Adds payment_not_completed to the op-status decline_reason enum so GET /billing/ops/:id still parses once Comfy-Org/cloud#11119 deploys, and maps it to the payment verification copy in account-core, billing-web's full-page verdict, and the app's billingOperationStore. The e2e conflict keeps only this change's test; the neighbouring main-only test is not part of this backport. (cherry picked from commit b2b0925)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 2123 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (18 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9bef583697680b857a7989af6b2eb10467cda376
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-30T21:52:45.555Z",
"gitSha": "4c6fdeb4e8c41bff5a4988d753b2d6bcaabf58a4",
"branch": "backport/cloud-1.55-payment-not-completed",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.6190000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.705,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.22600000000006,
"heapDeltaBytes": 4014328,
"heapUsedBytes": 71727856,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.379,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2001.1850000000777,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.270999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.897,
"heapDeltaBytes": 8471004,
"heapUsedBytes": 76304500,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.437999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1714.4080000000486,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.324,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 815.615,
"heapDeltaBytes": -7548276,
"heapUsedBytes": 59763800,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 162.487,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.1530000000303,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.244,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 775.044,
"heapDeltaBytes": 5679440,
"heapUsedBytes": 73328172,
"domNodes": -259,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 158.693,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.1660000000015,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.448999999999998,
"layouts": 6,
"layoutDurationMs": 1.19,
"taskDurationMs": 353.8229999999999,
"heapDeltaBytes": 2828512,
"heapUsedBytes": 70483884,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.585000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.589999999982,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.867999999999999,
"layouts": 6,
"layoutDurationMs": 1.0070000000000001,
"taskDurationMs": 325.22299999999996,
"heapDeltaBytes": 3098016,
"heapUsedBytes": 71267336,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.905000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 649.7190000000046,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.944000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.44899999999996,
"heapDeltaBytes": 18977176,
"heapUsedBytes": 86287840,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 169.00799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 648.9500000000135,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.893999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.747,
"heapDeltaBytes": 18946640,
"heapUsedBytes": 86691692,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 164.15099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1206.6259999999716,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 874.9150000000001,
"heapDeltaBytes": 35124504,
"heapUsedBytes": 101650364,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 71.039,
"eventListeners": 0,
"totalBlockingTimeMs": 588,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1214.2470000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 904.1649999999998,
"heapDeltaBytes": -16881008,
"heapUsedBytes": 73524636,
"domNodes": -295,
"jsHeapTotalBytes": 19267584,
"scriptDurationMs": 70.399,
"eventListeners": -217,
"totalBlockingTimeMs": 555,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 878.0550000000176,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.18299999999994,
"heapDeltaBytes": 14487712,
"heapUsedBytes": 89955876,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 180.448,
"eventListeners": 0,
"totalBlockingTimeMs": 244,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.1900000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.989,
"heapDeltaBytes": 14904864,
"heapUsedBytes": 91601860,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.40900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11597.692999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10648.601,
"heapDeltaBytes": 12763860,
"heapUsedBytes": 94882524,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8843.458,
"eventListeners": 0,
"totalBlockingTimeMs": 1508,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11617.342000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10743.097,
"heapDeltaBytes": 15678152,
"heapUsedBytes": 97671852,
"domNodes": -14,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 8992.381,
"eventListeners": 0,
"totalBlockingTimeMs": 1727,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11978.33300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11120.476,
"heapDeltaBytes": 16201252,
"heapUsedBytes": 98280436,
"domNodes": -12,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 9311.05,
"eventListeners": 0,
"totalBlockingTimeMs": 2177,
"frameDurationMs": 19.996666666666716,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10206.97800000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9384.841999999999,
"heapDeltaBytes": 18591508,
"heapUsedBytes": 94781352,
"domNodes": -8,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 7743.385,
"eventListeners": 0,
"totalBlockingTimeMs": 1019,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2033.2760000000007,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.720000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.9069999999999,
"heapDeltaBytes": -3262932,
"heapUsedBytes": 83668284,
"domNodes": -245,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.90599999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2031.0530000000426,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.258000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.793,
"heapDeltaBytes": -3003736,
"heapUsedBytes": 83649452,
"domNodes": -238,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 33.138,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2384.3890000000556,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.790000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1750.495,
"heapDeltaBytes": -10754636,
"heapUsedBytes": 77149008,
"domNodes": -221,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 884.621,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2154.886999999917,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.398000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1466.684,
"heapDeltaBytes": 15406960,
"heapUsedBytes": 79970804,
"domNodes": -246,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 835.276,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3668.276999999989,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.479999999999997,
"layouts": 60,
"layoutDurationMs": 13.235,
"taskDurationMs": 1748.8870000000002,
"heapDeltaBytes": 8481392,
"heapUsedBytes": 74506504,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 813.0840000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3583.998999999949,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.834000000000001,
"layouts": 60,
"layoutDurationMs": 12.904,
"taskDurationMs": 1677.686,
"heapDeltaBytes": 9437808,
"heapUsedBytes": 75024776,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 791.283,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3136.3130000000297,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.720999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1937.1480000000001,
"heapDeltaBytes": 21930668,
"heapUsedBytes": 87960540,
"domNodes": 6,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 988.8549999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3078.871000000049,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.510000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1958.02,
"heapDeltaBytes": -15285684,
"heapUsedBytes": 75343144,
"domNodes": -224,
"jsHeapTotalBytes": 3137536,
"scriptDurationMs": 984.337,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.249000000002,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.224999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.625,
"heapDeltaBytes": -4374556,
"heapUsedBytes": 84294308,
"domNodes": -243,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 34.958000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2017.3889999999801,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.638999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.7890000000001,
"heapDeltaBytes": -4827596,
"heapUsedBytes": 84220860,
"domNodes": -245,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 32.842,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.7860000000087,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.502999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.28,
"heapDeltaBytes": 14022804,
"heapUsedBytes": 83257548,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 146.227,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.7930000000524,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.351,
"heapDeltaBytes": 14075188,
"heapUsedBytes": 83265220,
"domNodes": 23,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.565,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.8219999999624,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.043999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.205,
"heapDeltaBytes": -7978900,
"heapUsedBytes": 62403132,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.339,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.3580000000056,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.278999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.51,
"heapDeltaBytes": -5434084,
"heapUsedBytes": 64651424,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.268,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.8229999999994,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.596,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 782.7620000000001,
"heapDeltaBytes": -8744484,
"heapUsedBytes": 60400944,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 111.38100000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.5869999999659,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.444,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 738.2990000000001,
"heapDeltaBytes": 2460284,
"heapUsedBytes": 71631108,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 103.96,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.2149999999183,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.116999999999997,
"layouts": 5,
"layoutDurationMs": 13.246,
"taskDurationMs": 986.2899999999998,
"heapDeltaBytes": -6249632,
"heapUsedBytes": 81307556,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 31.738999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8372.34699999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.878,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5397.097000000001,
"heapDeltaBytes": 6164192,
"heapUsedBytes": 93257080,
"domNodes": -218,
"jsHeapTotalBytes": 1269760,
"scriptDurationMs": 2888.942,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8391.694000000029,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.352000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5926.842000000001,
"heapDeltaBytes": -5795988,
"heapUsedBytes": 81857664,
"domNodes": -247,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2883.4990000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16947.947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16542.405,
"heapDeltaBytes": -63071172,
"heapUsedBytes": 171370436,
"domNodes": -8061,
"jsHeapTotalBytes": -12070912,
"scriptDurationMs": 258.21700000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16751.41400000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16188.079000000002,
"heapDeltaBytes": -43833096,
"heapUsedBytes": 196042980,
"domNodes": -8061,
"jsHeapTotalBytes": -21213184,
"scriptDurationMs": 272.345,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20723.311000000023,
"styleRecalcs": 145,
"styleRecalcDurationMs": 18.338000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20571.710000000003,
"heapDeltaBytes": -33512276,
"heapUsedBytes": 192179672,
"domNodes": -8061,
"jsHeapTotalBytes": -17903616,
"scriptDurationMs": 907.26,
"eventListeners": -14928,
"totalBlockingTimeMs": 219,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19969.14000000004,
"styleRecalcs": 158,
"styleRecalcDurationMs": 16.222000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19674.847,
"heapDeltaBytes": -49410244,
"heapUsedBytes": 191843564,
"domNodes": -8061,
"jsHeapTotalBytes": -18485248,
"scriptDurationMs": 852.165,
"eventListeners": -14928,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6139.500999999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.293,
"layouts": 20,
"layoutDurationMs": 22.599999999999994,
"taskDurationMs": 6081.850000000001,
"heapDeltaBytes": -41673620,
"heapUsedBytes": 198540308,
"domNodes": -8065,
"jsHeapTotalBytes": 12726272,
"scriptDurationMs": 112.934,
"eventListeners": -14928,
"totalBlockingTimeMs": 425,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5899.9710000000505,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.317,
"layouts": 20,
"layoutDurationMs": 22.002999999999993,
"taskDurationMs": 5822.1089999999995,
"heapDeltaBytes": -61000912,
"heapUsedBytes": 194759068,
"domNodes": -8061,
"jsHeapTotalBytes": 2899968,
"scriptDurationMs": 111.162,
"eventListeners": -14928,
"totalBlockingTimeMs": 370,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8462.671999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8329.317000000001,
"heapDeltaBytes": -3267224,
"heapUsedBytes": 186950716,
"domNodes": -1,
"jsHeapTotalBytes": -9961472,
"scriptDurationMs": 130.26099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6316.369000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6035.877999999999,
"heapDeltaBytes": -7113856,
"heapUsedBytes": 168443072,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 101.02100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 459.8590000000513,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.486,
"layouts": 4,
"layoutDurationMs": 2.1220000000000003,
"taskDurationMs": 135.805,
"heapDeltaBytes": 5222720,
"heapUsedBytes": 70903032,
"domNodes": 153,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.289000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 470.4119999998966,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.794999999999998,
"layouts": 4,
"layoutDurationMs": 1.94,
"taskDurationMs": 126.884,
"heapDeltaBytes": 5118692,
"heapUsedBytes": 70806784,
"domNodes": 146,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.084999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19670 +/- ##
=============================================
Coverage ? 83.76%
=============================================
Files ? 3072
Lines ? 150606
Branches ? 40859
=============================================
Hits ? 126153
Misses ? 23046
Partials ? 1407
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport fidelity matches the merged original, the package surface is unchanged, and the full current-head CI wave is settled green. The decline mapping remains workspace-neutral, so tab-local workspace selection is preserved.
Full context for agent readers
Reviewed at e795e380afade8f07db751f10042a7f02f9e9f64, based on 9bef583697680b857a7989af6b2eb10467cda376. The sorted changed lines and file set match the merged source change, all 106 executed checks passed, and the nine skipped checks are intentional.
… models catalogue budget (#19968) ## Summary Backport of #19669 to `cloud/1.55`: drop the whole-route JavaScript ceiling from the models catalogue budget test, which on this release line is a coin flip that blocks website- and `packages/`-touching carriers. ## Changes - **What**: Remove `expect(totalBytes).toBeLessThan(1_815_000)` from `apps/website/e2e/models-performance.spec.ts`. Keep the catalogue-only delta budget (`< 900_000`). The resulting test body is **identical to `main`'s**. ## Review Focus **The ceiling is non-deterministic on this branch, not merely outgrown.** On one fixed build of `cloud/1.55` (`a9968daf95`) the assertion reports two discrete values with the ceiling sitting between them: | mode | scripts | route total | vs 1,815,000 | |---|---|---|---| | low | 85 | 1,803,417 | passes | | high | 93 | 1,835,228 | fails | Ten consecutive focused runs against that single build: **5 failed, 5 passed**. The 31,811-byte swing is eight homepage/brand chunks and **no catalogue code**: `ProductShowcaseSection` (10,626), `GalleryDetailModal` (9,623), `AIModelsSection` (4,412), `ModelCreationsSection` (3,836), `BrandButton` (1,177), `brandButton.variants` (1,039), `CardArrow` (1,004), `cta` (94). They race the `shared` baseline captured on `/`: when they have not arrived before the baseline is sampled they are absent from `shared`, then charged in full against `/models/`. That explains a result that otherwise looks like drift: the gate passed on #19670 (152/152, 2026-09-30) and failed 3/3 on #19953 (1,835,341, 2026-10-02) with no catalogue change in between. Hosted runners are slower, which biases them toward the failing mode. The ceiling had also been ratcheted by unrelated billing work, exactly as #19669 describes upstream: #17971 set 1,810,000, and the #19120 billing backport (#19207) raised it to 1,815,000 on this line while measuring over it. **What still guards the route:** - The catalogue-only delta budget is kept and binds: measured 507,500–526,375 against 900,000. Tightening it to 500,000 **fails** at 507,500, so it is not vacuous. - The regression this test was written for — server catalogue data in the client bundle (#17604) — is caught at build time by `apps/website/src/integrations/workshop-client-boundary.ts`, which is present on this branch. **Validation** (`cloud/1.55` @ `a9968daf95`, local production build, port 6255): - Before: 5/10 focused runs failed at 1,835,228. - After: `models-performance.spec.ts` passes **10/10** (2 tests each). - `pnpm --filter @comfyorg/website typecheck` — 0 errors; `oxfmt --check`, `oxlint --type-aware`, `eslint` clean. I am not merging this; it needs a frontend reviewer's approval. Alexander Brown (@DrJKL) authored #19669 and is the natural reviewer. ## Screenshots (if applicable) Not applicable; this removes a test assertion and changes no product code.
Summary
Backport of #19531 to
cloud/1.55. Accepts the op-statusdecline_reasonvaluepayment_not_completedso checkout settles once Comfy-Org/cloud#11119 deploys.Why
Comfy-Org/cloud#11119 is merged on cloud main and ships with the next backend release, before frontend 1.56 reaches cloud prod. On 1.55,
operationLifecycle.tsparsesGET /billing/ops/:idwithzBillingOpStatusResponse.safeParse, whosedecline_reasonis a closed 8-value enum. Apayment_not_completedvalue fails the whole parse, so Pay spins and checkout never settles. Prod runs 1.54.15 today, which does not zod-parse op status, so there the new value only degrades copy. 1.55 is what cloud staging and prod move to next.Changes
Cherry-picked from #19531 (
-x), one conflict resolved.packages/ingest-types: addspayment_not_completedto the op-statusdecline_reasonenum and its doc line intypes.gen.tsandzod.gen.ts. No regeneration against cloud main, so no unrelated spec drift.account-corepaymentCopy.ts:declineDetailKeymaps it toauthenticationFailedDetail; addsbilling.reason.payment_not_completed.payVerdict.ts: joins the not-completed reasons. The M3 full-page checkout is already on 1.55 ([backport cloud/1.55] FE-3018 / FE-3019 / FE-3020 / FE-3021 / FE-3022 feat(billing-web): Milestone 3 full-page checkout behind billing_web_checkout_ui #19460 backport), so this hunk applies as on main.billingOperationStore.ts:payment_not_completedplus the rawpayment_method_customer_decline/payment_intent_payment_attempt_expiredcodes read as the verification detail.DECLINE_REASONStable with a parse row per reason,paymentCopy,paymentProjection,payVerdict,CheckoutView,FullPageCheckoutView,subscriptionOperationView,billingOperationStorerows, and the full-page e2e test.Not included: the e2e conflict pulled in a neighbouring main-only test (
314-10612processing-error card) as hunk context. It is dropped; only thepayment_not_completede2e test is kept.Verification
On the branch after
pnpm install:pnpm typecheck(root,--max-old-space-size=8192): clean. Pre-commit also rantypecheck:app,typecheck:billing-web,typecheck:account-core.src/platform/workspace/billing+billingOperationStore353 passed.pnpm lint: 0 errors.pnpm knip: clean.'payment_not_completed'fromzBillingOpStatusResponsefailsaccepts a failed status declined as payment_not_completed.Refs BE-17784, Comfy-Org/cloud#11119