Repository navigation
FE-3019 feat(billing-web): render server-reported subtotal, list price, discount duration, balance and receipts - #19672
Conversation
Picks up the checkout quote subtotal, list price, discount term and applied balance (cloud #11148, #11223), the read-only top-up quote (cloud #11188) and the succeeded operation receipt fields (cloud #11199). account-core reads the new int64 amounts as safe integers, like the existing cents, instead of the generated bigint. Drops new_free_tier_subscriptions, which was hand-added to the generated files and is not in the cloud spec; both consumers declare it themselves.
…ports A succeeded operation now carries the amount charged, credits added and plan the op status reports, each absent while the server cannot say it. A success whose credits are still landing is read again for a caller recovering settled operations, the way a parked reconciliation already is.
…unt term, balance and receipts Summary: a discounted plan rate shows its list price struck through, a discount row states its term (first period, N months), the account balance the server applied is the last deduction and keeps the row it explains, and Subtotal shows only where a discount follows two or more money rows. Endings: Success counts the credits the operation reports, Already completed and You're all set name the plan its receipt names from the catalog, a top-up lists Added and Amount paid, and a charge whose credits are still landing reads Payment received until a re-read reports them. The e2e fixtures gain a monthly-to-yearly quote carrying renewal_at, list price and subtotal the way the real backend quotes it.
🎭 Playwright: ✅ 2176 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 771bb7250e67637711c06caa15754afd6b34baf2
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10.1 MB gzip 🔴 +787 BDetailsSummary
Category Glance App Entry Points — 3.84 kB (baseline 3.84 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 133 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 643 kB (baseline 643 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 49.9 kB (baseline 49.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 7 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 150 kB (baseline 150 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 9 unchanged Data & Services — 4.11 MB (baseline 4.11 MB) • 🔴 +4.82 kBStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 584 kB (baseline 584 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 76 added / 76 removed / 229 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T00:38:04.590Z",
"gitSha": "6300cc0c06ede2a125b892fb2e197309a517ad7c",
"branch": "jaewon/fe-3019-server-reported-fields",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2012.153000000012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0739999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.429,
"heapDeltaBytes": 22321628,
"heapUsedBytes": 76084596,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.512,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2014.026000000058,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.896000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.23099999999994,
"heapDeltaBytes": 22294864,
"heapUsedBytes": 76373620,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.357000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.7319999999563,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.046999999999997,
"layouts": 12,
"layoutDurationMs": 3.7110000000000003,
"taskDurationMs": 730.162,
"heapDeltaBytes": -2956084,
"heapUsedBytes": 63541164,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 134.742,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1714.3500000000813,
"styleRecalcs": 72,
"styleRecalcDurationMs": 17.218000000000004,
"layouts": 12,
"layoutDurationMs": 4.1739999999999995,
"taskDurationMs": 713.5169999999999,
"heapDeltaBytes": -2930100,
"heapUsedBytes": 63768876,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 132.255,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.537000000002,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.678999999999998,
"layouts": 6,
"layoutDurationMs": 1.335,
"taskDurationMs": 324.12699999999995,
"heapDeltaBytes": 25263304,
"heapUsedBytes": 79322636,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.153999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.0129999999754,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.848,
"layouts": 6,
"layoutDurationMs": 1.105,
"taskDurationMs": 269.69699999999995,
"heapDeltaBytes": 25260284,
"heapUsedBytes": 78929228,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.396999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 589.1790000000015,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0080000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.498,
"heapDeltaBytes": 15185068,
"heapUsedBytes": 68939764,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 136.856,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 555.1600000000008,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.9380000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.723,
"heapDeltaBytes": -7595740,
"heapUsedBytes": 59323804,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 138.24900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1011.2050000000181,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 653.2690000000001,
"heapDeltaBytes": 14637540,
"heapUsedBytes": 92580160,
"domNodes": 0,
"jsHeapTotalBytes": 8814592,
"scriptDurationMs": 48.509999999999984,
"eventListeners": 0,
"totalBlockingTimeMs": 394,
"frameDurationMs": 30.80606060606059,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1007.7420000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 648.162,
"heapDeltaBytes": 15179200,
"heapUsedBytes": 83335868,
"domNodes": 0,
"jsHeapTotalBytes": 6979584,
"scriptDurationMs": 52.41000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 392,
"frameDurationMs": 29.90000000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 784.9370000000135,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.7380000000002,
"heapDeltaBytes": -13868368,
"heapUsedBytes": 80406248,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 125.95199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 163,
"frameDurationMs": 23.041176470588226,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 795.5309999999827,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.2729999999999,
"heapDeltaBytes": -13826544,
"heapUsedBytes": 80291152,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 136.73899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 22.857142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7193.843000000015,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8489999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6369.34,
"heapDeltaBytes": -14598960,
"heapUsedBytes": 68840268,
"domNodes": -142,
"jsHeapTotalBytes": -7213056,
"scriptDurationMs": 5021.8820000000005,
"eventListeners": -78,
"totalBlockingTimeMs": 27,
"frameDurationMs": 24.57235494880546,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8087.3470000000225,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.174999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7147.671,
"heapDeltaBytes": 1703916,
"heapUsedBytes": 77689876,
"domNodes": -142,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 5761.909000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 47,
"frameDurationMs": 25.579430379746835,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7038.821000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6359.211,
"heapDeltaBytes": 6416128,
"heapUsedBytes": 81102672,
"domNodes": 0,
"jsHeapTotalBytes": -14942208,
"scriptDurationMs": 5149.812,
"eventListeners": 0,
"totalBlockingTimeMs": 117,
"frameDurationMs": 25.85698529411765,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7066.623999999933,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3370000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6355.647999999999,
"heapDeltaBytes": -13575300,
"heapUsedBytes": 67109516,
"domNodes": 0,
"jsHeapTotalBytes": -19922944,
"scriptDurationMs": 4997.816,
"eventListeners": 0,
"totalBlockingTimeMs": 82,
"frameDurationMs": 24.822887323943664,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2008.4040000000414,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.316999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.23600000000005,
"heapDeltaBytes": -737840,
"heapUsedBytes": 85221536,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.605,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2018.2489999999689,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.4670000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.0910000000001,
"heapDeltaBytes": 20675520,
"heapUsedBytes": 83024024,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.249,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2160.34499999995,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.214000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1286.9830000000002,
"heapDeltaBytes": -40928828,
"heapUsedBytes": 83411048,
"domNodes": -328,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 618.6610000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615384615385,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2100.2580000000535,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.177999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1272.1260000000002,
"heapDeltaBytes": 19512096,
"heapUsedBytes": 82573084,
"domNodes": -167,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 619.147,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66587301587302,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3340.340000000026,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.843,
"layouts": 60,
"layoutDurationMs": 14.356,
"taskDurationMs": 1539.3080000000002,
"heapDeltaBytes": -10473776,
"heapUsedBytes": 78226128,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 709.703,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3235.2829999999813,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.032,
"layouts": 60,
"layoutDurationMs": 13.721,
"taskDurationMs": 1426.978,
"heapDeltaBytes": 7833988,
"heapUsedBytes": 72494052,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 641.042,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665463917525773,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2556.1500000000024,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.294000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1665.422,
"heapDeltaBytes": 16569460,
"heapUsedBytes": 81338324,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 811.9530000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601307189542,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2408.4629999999834,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.435000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1573.7510000000002,
"heapDeltaBytes": 18472268,
"heapUsedBytes": 84626528,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 771.3559999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.783216783216783,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2023.6600000000067,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.9379999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.1500000000001,
"heapDeltaBytes": 20370520,
"heapUsedBytes": 83340316,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.557,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2017.1609999999873,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1709999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.9559999999999,
"heapDeltaBytes": -1178672,
"heapUsedBytes": 77908888,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 36.394999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 556.7059999999628,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.835999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.818,
"heapDeltaBytes": -11672188,
"heapUsedBytes": 57005896,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 121.95,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.2080000000078,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.058000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.578,
"heapDeltaBytes": -41428712,
"heapUsedBytes": 63313372,
"domNodes": -249,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 121.51299999999999,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.8240000000328,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4989999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.80800000000005,
"heapDeltaBytes": 22327144,
"heapUsedBytes": 76149928,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.494000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2015.3360000000475,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.673,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.01200000000006,
"heapDeltaBytes": 22301440,
"heapUsedBytes": 76307604,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.753999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1696.9940000000179,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.067,
"layouts": 16,
"layoutDurationMs": 5.737,
"taskDurationMs": 626.572,
"heapDeltaBytes": 15000220,
"heapUsedBytes": 69303548,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 94.77499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.0789999999924,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.181,
"layouts": 16,
"layoutDurationMs": 5.180000000000001,
"taskDurationMs": 607.9590000000001,
"heapDeltaBytes": 14946176,
"heapUsedBytes": 69383008,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 89.732,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1251.6859999999497,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.246000000000002,
"layouts": 5,
"layoutDurationMs": 9.628999999999998,
"taskDurationMs": 781.0659999999998,
"heapDeltaBytes": 22107488,
"heapUsedBytes": 107435848,
"domNodes": 13747,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 26.361000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 90,
"frameDurationMs": 18.65522388059701,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8230.773999999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.298,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5232.4039999999995,
"heapDeltaBytes": -140380,
"heapUsedBytes": 83319528,
"domNodes": -142,
"jsHeapTotalBytes": -8523776,
"scriptDurationMs": 2398.753,
"eventListeners": -78,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666125760649088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8265.528000000017,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.489,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4814.815,
"heapDeltaBytes": 950424,
"heapUsedBytes": 87285948,
"domNodes": -142,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 2226.2110000000002,
"eventListeners": -78,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592741935484,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15493.056000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14814.251,
"heapDeltaBytes": -37298544,
"heapUsedBytes": 181012964,
"domNodes": -3045,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 237.18900000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.35459363957597,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 15008.330999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14544.747999999998,
"heapDeltaBytes": -44080488,
"heapUsedBytes": 183763604,
"domNodes": -3045,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 238.58,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.074729241877257,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 17776.951999999994,
"styleRecalcs": 133,
"styleRecalcDurationMs": 19.090999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17494.983,
"heapDeltaBytes": -35018416,
"heapUsedBytes": 167523664,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 758.6389999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 27,
"frameDurationMs": 33.61550094517958,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17574.747000000003,
"styleRecalcs": 140,
"styleRecalcDurationMs": 16.554000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17230.506999999998,
"heapDeltaBytes": -33713580,
"heapUsedBytes": 177995704,
"domNodes": -3045,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 745.9140000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 33.05,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5368.88399999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.74799999999997,
"layouts": 20,
"layoutDurationMs": 23.511000000000003,
"taskDurationMs": 5271.489999999999,
"heapDeltaBytes": -19255668,
"heapUsedBytes": 203533808,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 86.332,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.3277108433735,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5578.935000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.279,
"layouts": 20,
"layoutDurationMs": 23.54200000000001,
"taskDurationMs": 5436.906000000001,
"heapDeltaBytes": 692364,
"heapUsedBytes": 212494192,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 96.59200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.04329268292682,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7537.955000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7338.695,
"heapDeltaBytes": -33695404,
"heapUsedBytes": 173926316,
"domNodes": -3045,
"jsHeapTotalBytes": 14745600,
"scriptDurationMs": 117.732,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.713120567375896,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7634.724000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7462.568000000001,
"heapDeltaBytes": -13135020,
"heapUsedBytes": 189587668,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 117.539,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.655797101449274,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 111.31699999998546,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.105999999999998,
"layouts": 3,
"layoutDurationMs": 1.56,
"taskDurationMs": 78.36099999999999,
"heapDeltaBytes": 3941704,
"heapUsedBytes": 57461528,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.357,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 468.73599999992166,
"styleRecalcs": 18,
"styleRecalcDurationMs": 14.526,
"layouts": 4,
"layoutDurationMs": 1.761,
"taskDurationMs": 102.40900000000003,
"heapDeltaBytes": 5842496,
"heapUsedBytes": 59287540,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.854999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 576.6080000000784,
"styleRecalcs": 78,
"styleRecalcDurationMs": 84.38,
"layouts": 76,
"layoutDurationMs": 20.972,
"taskDurationMs": 548.641,
"heapDeltaBytes": -9736700,
"heapUsedBytes": 79099332,
"domNodes": 76,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 201.55900000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 506.3879999999017,
"styleRecalcs": 78,
"styleRecalcDurationMs": 78.669,
"layouts": 76,
"layoutDurationMs": 19.331,
"taskDurationMs": 478.12,
"heapDeltaBytes": 13778516,
"heapUsedBytes": 77409428,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 170.821,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483896,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1178.720999999996,
"styleRecalcs": 78,
"styleRecalcDurationMs": 241.985,
"layouts": 76,
"layoutDurationMs": 25.222,
"taskDurationMs": 1168.063,
"heapDeltaBytes": -20370544,
"heapUsedBytes": 112199580,
"domNodes": -7799,
"jsHeapTotalBytes": -4177920,
"scriptDurationMs": 345.00899999999996,
"eventListeners": -868,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1270.990000000097,
"styleRecalcs": 78,
"styleRecalcDurationMs": 275.518,
"layouts": 76,
"layoutDurationMs": 27.525000000000002,
"taskDurationMs": 1239.8069999999998,
"heapDeltaBytes": -19801096,
"heapUsedBytes": 107012052,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 375.137,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.340540540540538,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (9)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughBilling responses now include operation receipt details and additional quote fields. Checkout reconciliation uses receipt and status data to resolve settled payments. Checkout endings display available receipt details, and quote summaries show list-price comparisons, discount terms, subtotals, and applied account balances. ChangesBilling checkout details
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant BillingStatusAPI
participant operationLifecycle
participant useFullPageCheckout
participant CheckoutPage
participant CheckoutEnding
useFullPageCheckout->>operationLifecycle: Read operation status
operationLifecycle->>BillingStatusAPI: Request operation status
BillingStatusAPI-->>operationLifecycle: Return charge, credits, and plan facts
operationLifecycle-->>useFullPageCheckout: Return succeeded operation with receipt
useFullPageCheckout->>CheckoutPage: Reconcile operation and settled plan
CheckoutPage-->>CheckoutEnding: Provide terminal page and receipt
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The changes display server-reported checkout totals and payment details, with coverage for discounts, balances, and delayed credits. No actionable merge blocker is established; merge after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The changed financial values remain display data, and the inspected paths do not introduce a new payment-authority or unsafe rendering path. The main uncertainty is whether refreshing a settled payment can discard previously confirmed receipt facts and prematurely stop tracking pending credits. Retained concerns
Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #19672 +/- ##
==========================================
- Coverage 84.54% 84.51% -0.03%
==========================================
Files 3357 3371 +14
Lines 161826 162421 +595
Branches 44034 44495 +461
==========================================
+ Hits 136812 137278 +466
- Misses 23104 23216 +112
- Partials 1910 1927 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 123 files with indirect coverage changes 🚀 New features to boost your workflow:
|
… from the plan rate The Success card priced the plan from new_plan.price_cents, so a promo, a held discount, an account balance or a proration never showed on it. When the server-reported charge differs from that rate, the card now adds a divider, one row per reason the server reported, then Paid today: amount_charged_cents from the succeeded op, else the quote's amount_due_cents for this page's own Pay. A prorated change reads only Paid today with its reason. A provider return knows only the op status, so it shows Paid today alone.
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at 3c7214b28a0c7f52e175e2dd3f0a3d73a9919a74.
- Server-reported subtotal, list price, discount duration, balance, and receipt fields remain authoritative throughout the checkout and ending screens.
- The yearly comparison-price question is resolved for this slice: keep the server-reported per-year form until the backend supplies per-month display fields; do not divide prices in the client.
- CI is settled green and there are no unresolved review threads.
Full context for agent readers
Reviewed the complete current diff, the watched product-answer thread, live review state, and current checks. Checkout and recovery remain bound to the invoking workspace; no global workspace selector or persistence was introduced, so two tabs may intentionally use different workspaces.
…omfy-Org#19673) ## Summary A `/v1/top-up` link now opens a credit top-up on the full-page checkout: the summary leads with the credits the server quotes for the link's amount, Pay charges the method on file through the billing SDK's top-up command, and the endings report what the operation added and cost. Builds on Comfy-Org#19672 (merged). ## Changes - **Why**: FE-3072 (Alex's M3 review, 2026-09-28): the full-page checkout handles top-ups too. Figma 265-4362 (summary: credits first, expiry from the server, no promo), 77-3783 (Success and Already completed, op facts only), 394-4991 (receipt). cloud Comfy-Org#11188 (BE-17842) added the read-only top-up quote this needs, and cloud Comfy-Org#11199 the op receipt the endings read. Both are on cloud main. - **Root cause** (why a top-up link failed before): the entry contract had no top-up intent, so `/v1/top-up` was an unreadable link, and billing-web had no quote or route for it. - **How**: - `@comfyorg/billing-contract`: a `top-up` intent with `amount_cents`, the amount the product asks for in whole cents. The builder and the parser refuse anything but a positive whole number of cents with `INVALID_AMOUNT`. The amount is the customer's quantity, not a price. - `@comfyorg/account-core`: `topup.quoteTopup({ amountCents })` reads `POST /billing/topup/quote` (no idempotency key; nothing is charged). A 404 is `NOT_AVAILABLE`, a refused amount `INVALID_AMOUNT`, and the credits and amount are read as safe integers. - billing-web: `TopupRouteView` renders `FullPageTopupView` on the `billing_web_checkout_ui` full-page flag. `useFullPageTopup` drives the same `CheckoutPage` reducer as the subscription checkout: it reconciles first, reads `can_top_up`, quotes the amount, and pays through `useTopUp` (the SDK top-up command on the `billing_sdk_topup_enabled` rail), on the method on file. `topupVerdictOf` maps the command's result onto the existing Pay verdicts. `buildTopupLedger` leads with the quoted credits and dates them "Expire {date}" from the quote's `expires_at`, with no promo entry. Success reads "{N} credits added" with Added and Amount paid; credits still landing read Payment received; a revisit is Already completed. - `useCheckoutExit` and `reconciledEvent` move out of `useFullPageCheckout` so both checkouts share them. - Design review answers (Alex, 2026-09-30): - A one-time code reads "This payment only" on a change to a monthly plan. A new monthly subscription keeps "First month", and a yearly plan keeps "First year" (DES-1211) for a new subscription and a change alike. `discountTerm` picks the copy from the quote's `transition_type` and the new plan's duration; no money logic changes. - Top-up Success and Already completed put the credits icon (`icon-[lucide--coins]`, as on the plan card and summary) on the Added value (77-4102, 410-5225). - Top-up Pay reads "Pay", and the terms line reads "…charge your payment method once for this purchase." with Terms and Privacy Policy linked through the shared `CheckoutTermsNote` (180-6679). - A top-up link with no amount or an unreadable amount ends on "This link isn't valid" with `CHECKOUT_LINK_INVALID`, Add credits to the workspace's Plan & Credits settings, and Contact support (769-15773). It is a new `amount_invalid` reason mapped to a `link_invalid` ending. `App.vue` lets the top-up route explain an `INVALID_AMOUNT` link instead of the generic entry error. Subscription links keep "This plan isn't available". - **Breaking**: none. `TopupCommand` gains `quoteTopup`, so its fakes gain one too. **Rule 2.** The credits, the expiry, the amount charged and the credits added are the server's numbers. The page does not convert the amount into credits, and it states no expiry policy of its own. ## Review Focus - A revisit of a top-up this tab already saw succeed ends on Already completed. A top-up link is always for sale, so without this the page would offer a second form. - Top-up Success leaves out the Previous balance and New balance rows from 77-3783. They would need two balance reads around the charge, and DES-1212 already keeps balance rows off Already completed because a balance can be stale. Say if Success should show them. - "This payment only" is limited to monthly plan changes, the case Alex's answer named. A one-time code on a yearly plan still reads "First year", on a switch to yearly too. - A top-up link that is unreadable for any reason other than its amount (an unknown product, say) still ends on the generic entry error page, as before. - Nothing in the host app builds a top-up link yet. This PR adds the contract, the page and the quote. - On the embedded variant of the flag the route shows the entry error. There is no embedded top-up on billing-web. ## Screenshots (if applicable) Fixture build (billing-web e2e mocks), dark, 1512×982. | Case | AS IS | TO BE | | --- | --- | --- | | `/v1/top-up?amount_cents=2500` | <img width="600" alt="asis-topup-summary" src="https://github.com/user-attachments/assets/e54024c4-1c18-493a-9503-2150244a90a5" /> | <img width="600" alt="tobe-topup-summary" src="https://github.com/user-attachments/assets/3f964432-279e-4850-805b-89a36d2a1889" /> | | Pay goes through | n/a | <img width="600" alt="tobe-topup-success" src="https://github.com/user-attachments/assets/af7607ee-9134-44be-bd03-388239133b70" /> | | Credits still landing | n/a | <img width="600" alt="tobe-topup-received" src="https://github.com/user-attachments/assets/88b5bf5b-3705-4d72-81da-b2066a46c1b4" /> | | Reload once they land | n/a | <img width="600" alt="tobe-topup-already" src="https://github.com/user-attachments/assets/5d91e64d-a2da-4ede-956e-41132bf5d9c0" /> | Design review answers, fixture build (billing-web e2e mocks), 1280×860. AS IS is the previous head `a893946ddc`. | Case | AS IS | TO BE | | --- | --- | --- | | Top-up Success, credits icon on Added (77-4102) | <img width="600" alt="asis-topup-success" src="https://github.com/user-attachments/assets/124b0226-3cbc-4ae2-a34e-28120cd8bc83" /> | <img width="600" alt="tobe-topup-success" src="https://github.com/user-attachments/assets/dc68d101-41a1-4251-a77f-6c949411e261" /> | | Top-up Pay button and terms (180-6679) | <img width="600" alt="asis-topup-pay" src="https://github.com/user-attachments/assets/bf977000-5be6-457c-8a90-187d401e1c14" /> | <img width="600" alt="tobe-topup-pay" src="https://github.com/user-attachments/assets/ec51cc45-39cd-4a27-9165-0e7e2e2af8c4" /> | | `/v1/top-up` with no amount (769-15773) | <img width="600" alt="asis-topup-invalid" src="https://github.com/user-attachments/assets/e9f8b70d-bd09-458a-9411-64f1ddc7da10" /> | <img width="600" alt="tobe-topup-invalid" src="https://github.com/user-attachments/assets/9bd1399c-11e7-48d4-8e5e-4d600de0ea3c" /> | | One-time code on a plan change | <img width="600" alt="asis-change-once" src="https://github.com/user-attachments/assets/a2d0b587-f42e-4f37-a584-f59044883496" /> | <img width="600" alt="tobe-change-once" src="https://github.com/user-attachments/assets/1153d17c-34a8-4c1c-8369-33f3cb616295" /> | ## Where this PR sits in Milestone 3 | State | PR / ticket | Scope | |---|---|---| | Merged | Comfy-Org#19253 | M3 stack: FE-3018..3022 full page behind `billing_web_checkout_ui` | | Merged | Comfy-Org#19462 / Comfy-Org#19487 | Design review rounds 3-4 | | Merged | Comfy-Org#19540 Comfy-Org#19538 Comfy-Org#19536 Comfy-Org#19537 | UX pass: money state, lock/redirect, promo, summary/copy | | Merged | Comfy-Org#19531 | Accept `payment_not_completed` | | Merged | Comfy-Org#19611 Comfy-Org#19612 Comfy-Org#19613 | Follow-ups: planless link, visual pass, promo restore + server order | | Merged (BE) | cloud Comfy-Org#11148 Comfy-Org#11223 Comfy-Org#11188 Comfy-Org#11199 | Quote subtotal / list price / discount term / balance, top-up quote, op receipt | | Open (BE) | cloud Comfy-Org#11252 | `renewal_at` without the flag, itemized proration | | Merged | Comfy-Org#19672 | FE-3019 server-reported subtotal, list price, discount term, balance and receipts | | Open | **this PR** | FE-3072 credit top-up on the full page | | Next | M3-9 / M3-10 | Rollout via the flag, then delete the M2 path and the flag | ```mermaid flowchart LR classDef done fill:#e3f5e1,stroke:#2e7d32 classDef open fill:#dff0ff,stroke:#1f6feb classDef be fill:#fde2e2,stroke:#c0392b classDef me fill:#fff4cc,stroke:#b58900,stroke-width:3px S["PR 19253 M3 stack"]:::done --> R["PR 19462 / PR 19487 design rounds"]:::done R --> U["UX pass PR 19540 PR 19538 PR 19536 PR 19537"]:::done R --> PNC["PR 19531 payment_not_completed"]:::done U --> F["Follow-ups PR 19611 PR 19612 PR 19613"]:::done BE1["cloud 11148 / 11223 quote fields"]:::done --> SR["PR 19672 server-reported fields"]:::done BE2["cloud 11199 op receipt"]:::done --> SR F --> SR BE3["cloud 11188 top-up quote"]:::done --> ME["FE-3072 top-up on the full page"] SR --> ME BE4["cloud 11252 itemized proration"]:::be -.-> PR["Proration rows"]:::open ME --> RO["M3-9 rollout"] SR --> RO RO --> CL["M3-10 delete M2 path + flag"] class ME me ```
…harge breakdown (Comfy-Org#19814) ## Summary billing-web renders the display prices and the charge breakdown the server now reports, instead of deriving them on the client. Builds on Comfy-Org#19526 (merged). ## Why - The frontend must not derive server state. The summary decided whether to strike a price by comparing two server amounts, and the Success card decided whether to show reasons the same way. - A Success card reached by returning from a payment provider (Alipay and other redirect methods) showed only "Paid today" with no reasons, because the reasons came from a quote that tab no longer had. ## Root cause - `summaryLedger.ts` `comparedRateOf` compared `list_price_cents` to `price_cents`. - `successBreakdown.ts` compared the charge to `price_cents` and rebuilt the reasons from the pre-payment quote (`ChargeSource`, `quotedSource`, `opStatusSource`, and a switch on the ledger family). On a provider return there is no quote, so there were no reasons. ## How - Summary. A yearly plan reads `monthly_price_cents`, struck against `monthly_list_price_cents` when sent ([cloud#11318](Comfy-Org/cloud#11318)). Other plans strike whenever the server sends `list_price_cents`. No client comparison remains. - Success card. Rows come from the operation's `charge_breakdown` ([cloud#11327](Comfy-Org/cloud#11327)): one row per reason (`promo_code`, `subscription_discount`, `account_balance`), "Paid today" from `amount_charged_cents`, and the proration line from `prorated`. There are no rows when the server reports no breakdown. The client comparisons, `ChargeSource` and its helpers are deleted. - account-core. The receipt keeps the strict-zod `charge_breakdown` (wire cents coerced, unknown reason kinds rejected), the types are exported, and one `SubscriptionDiscountSchema` is shared by the preview and the op status. - Does not touch `packages/ingest-types`. ## Testing - Unit: billing-web 1065 passed, account-core 1431 passed. - Typecheck: root, billing-web and account-core are clean. oxlint, oxfmt, knip and fallow are clean. - billing-web e2e with `CI=1` and `--retries=0`: 127 passed. The new provider-return test fails on the old `successBreakdown` (received `Paid today$40.00` with no reasons) and passed 10/10 with `--repeat-each=10`. ## Known follow-up When [cloud#11446](Comfy-Org/cloud#11446) (`term` on `SubscriptionDiscount`) merges, `discountTerm` becomes a plain lookup on `discount.term`, and the summary and Success card copy will match. ## Where this PR sits in Milestone 3 | Step | PR | State | | --- | --- | --- | | Server display fields, first pass | [PR 19672](Comfy-Org#19672) | merged | | Top-up on full-page checkout | [PR 19673](Comfy-Org#19673) | merged | | Per-month prices for yearly plans | [cloud 11318](Comfy-Org/cloud#11318) | merged | | Charge breakdown on succeeded ops | [cloud 11327](Comfy-Org/cloud#11327) | merged | | Ingest types sync | [PR 19526](Comfy-Org#19526) | merged | | **Render display prices and breakdown** | **this PR** | **open** | | Discount term | [cloud 11446](Comfy-Org/cloud#11446) | open | ```mermaid flowchart LR A["PR 19672 (merged)"] --> F B["PR 19673 (merged)"] --> F C["cloud 11318 (merged)"] --> E["PR 19526 ingest types (merged)"] D["cloud 11327 (merged)"] --> E E --> F["this PR"] G["cloud 11446 discount term (open)"] -.-> H["follow-up: discountTerm reads discount.term"] F -.-> H style F fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:3px ``` ## Screenshots | | AS IS (main) | TO BE (this PR) | | --- | --- | --- | | Yearly summary: monthly figures, struck monthly list price | <img width="420" alt="asis-yearly-summary" src="https://github.com/user-attachments/assets/e26b1679-db4e-48de-80ba-cb4566b10297" /> | <img width="420" alt="tobe-yearly-summary" src="https://github.com/user-attachments/assets/7fad36b0-92f2-4b2d-9a73-069c83a8a52b" /> | | Success after a provider return: reasons from charge_breakdown | <img width="420" alt="asis-success-breakdown" src="https://github.com/user-attachments/assets/f351285b-eb43-41f2-878d-797fb66c8437" /> | <img width="420" alt="tobe-success-breakdown" src="https://github.com/user-attachments/assets/1f420e5a-d66f-4162-86a4-bcb393d0e61c" /> | | Prorated Success: unchanged copy, now from charge_breakdown.prorated | <img width="420" alt="asis-prorated-success" src="https://github.com/user-attachments/assets/185ca5be-46ad-436f-a5c7-8fa03b9a414f" /> | <img width="420" alt="tobe-prorated-success" src="https://github.com/user-attachments/assets/108529c4-37fa-474e-8e8b-3f2afccd778e" /> | Captured from the local billing-web production build (`vite build` and `vite preview` on :4174) against the e2e mock Cloud, the same scenarios for both builds.
…omfy-Org#19878) ## Summary billing-web words a discount's term from the `term` the server reports on `SubscriptionDiscount`, instead of picking the copy on the client. Builds on Comfy-Org#19877 (merged). ## Why - The frontend must not derive copy from server metadata. The summary chose a discount's subline from `transition_type`, the plan duration and the coupon duration. - The summary and the Success card disagreed. A one-time code on a monthly plan change read "This payment only" on the summary and "First month" on Success. ## Root cause - `summaryLedger.ts` `discountTerm` mapped `duration: 'once'` to "This payment only" when `transition_type` was not `new_subscription` and the plan was monthly, otherwise to the plan's first period. - The op status has no `transition_type`, so `successBreakdown.ts` could only pass the plan duration, and the same code read "First month" there. ## How - [cloud#11446](Comfy-Org/cloud#11446) adds `term` (`this_payment`, `first_month`, `first_year`, `months`, `ongoing`) to `SubscriptionDiscount`, in both the preview's `discounts` and the op status `charge_breakdown` reasons. - `discountRow` looks the subline up in a `TERM_LINE` table keyed by `term`. `this_payment`, `first_month` and `first_year` reuse the existing keys, `months` uses the `forMonths` plural with `duration_in_months`, and `ongoing` or an absent term has no subline. The reads of `transition_type`, plan duration and `discount.duration`, `DeductionFormat.duration`, and `BY_DURATION.onceTerm` are deleted. The Success card shares `discountRow`, so it reads the same copy. - account-core. `SubscriptionDiscountSchema` extends the generated `zSubscriptionDiscount`, which already carries `term` as an optional strict enum, so the schema is not redeclared. A new `subscriptionDiscount.test.ts` pins the inferred type to the five values, parses each, and rejects an unknown term. ## Testing - Unit: billing-web 1344 passed, account-core 1468 passed (rebased on main). The new term table, the Success "This payment only" case, and a guard (same `term` across `new_subscription`, `upgrade`, `downgrade` and `duration_change` reads the same copy) fail 8 tests against the previous `summaryLedger.ts`/`successBreakdown.ts`. - Typecheck: root, billing-web and account-core are clean. oxlint, oxfmt and knip are clean. - billing-web e2e with `CI=1` and `--retries=0` on :4174: 127 passed. Scenario discounts now carry `term`, and the monthly-change test asserts "This payment only" on Success. ## Where this PR sits in Milestone 3 | Step | PR | State | | --- | --- | --- | | Server display fields, first pass | [PR 19672](Comfy-Org#19672) | merged | | Top-up on full-page checkout | [PR 19673](Comfy-Org#19673) | merged | | Per-month prices for yearly plans | [cloud 11318](Comfy-Org/cloud#11318) | merged | | Charge breakdown on succeeded ops | [cloud 11327](Comfy-Org/cloud#11327) | merged | | Ingest types sync | [PR 19526](Comfy-Org#19526) | merged | | Render display prices and breakdown | [PR 19814](Comfy-Org#19814) | merged | | Discount term | [cloud 11446](Comfy-Org/cloud#11446) | merged | | Ingest types sync (cloud@4b1fa05) | [PR 19877](Comfy-Org#19877) | merged | | **Render the server-reported discount term** | **this PR** | **open** | ```mermaid flowchart LR A["PR 19672 (merged)"] --> F["PR 19814 display prices (merged)"] B["PR 19673 (merged)"] --> F C["cloud 11318 (merged)"] --> E["PR 19526 ingest types (merged)"] D["cloud 11327 (merged)"] --> E E --> F G["cloud 11446 discount term (merged)"] --> H["PR 19877 ingest types sync (merged)"] F --> I["this PR"] H --> I style I fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:3px ``` ## Screenshots | | AS IS (main) | TO BE (this PR) | | --- | --- | --- | | Success after a monthly plan change with a one-time code (`term: this_payment`) | <img width="420" alt="asis-success" src="https://github.com/user-attachments/assets/afaaf895-13f6-4c92-9cf2-885900575f5f" /> | <img width="420" alt="tobe-success" src="https://github.com/user-attachments/assets/9c0204b3-e31b-48db-94fb-8dd3edbea3ca" /> | Captured from the local billing-web production build (`vite build` and `vite preview` on :4174) against the e2e mock Cloud, with the same scenario on `main` and on this branch. The summary already read "This payment only" on `main`; Success read "First month".
…kout summary (Comfy-Org#19931) ## Summary A prorated plan upgrade on the full-page checkout now shows what the customer pays for the rest of the period on the new plan and the credit for unused time on the old plan, as two rows at the amounts the server reports. ## Why cloud#11252 (merged 2026-10-01) returns `proration_remaining_cents` and `proration_unused_cents` on the checkout quote for an immediate prorated upgrade. DES-1210 wants the Figma pair of rows (294-8378) once the backend splits proration, in place of the single "{plan} - Prorated" row and its stand-in subline. Comfy-Org#19672 left this out while cloud#11252 was open. ## How - `summaryLedger.ts`: `proratedItems` is a pure projection. With both fields, the prorated family renders "Remaining time on {plan}" at `proration_remaining_cents` (with the credits refill subline) and "Unused time on {current plan}" as `−` `proration_unused_cents`. When either field is missing, the single net row stays exactly as before. The page does no arithmetic on either amount. - `moneyItems` now takes finished rows and a net amount, so one reconciliation rule gates the single row and the pair alike: the rows show when `cost_today_cents` equals the amount due or a discount or balance row explains the gap. - The existing Subtotal, discount and balance rules apply unchanged. With two money rows and a code, the server's `subtotal_cents` now shows above the discount, as DES-1210 specifies. A balance alone adds its row and no Subtotal. - `LedgerItem.vue`: a row marked `credit` renders its amount muted, like other deductions. No strikethrough. - account-core already parsed both fields onto `SubscriptionPreview`, so nothing changes there. The flag-off M2 `CheckoutView.vue` is untouched. - Out of scope: the Success card (`successBreakdown.ts`) reads the operation status, not the quote, and the op status does not itemize proration. It keeps "Paid today" with the prorated subline. ## Review Focus - **Open copy question.** DES-1210 has no exact copy for the pair, so the labels follow Stripe's invoice wording: "Remaining time on Pro Plan" and "Unused time on Creator Plan". When the change crosses cadences, both name it ("Remaining time on Pro Yearly", "Unused time on Creator Monthly"). The refill subline sits under the remaining-time row. Design should confirm against 294-8378. - If only one of the two fields arrives (the server contract says they come together), the summary falls back to the single row instead of rendering half a pair. ## Testing - `summaryLedger.test.ts`: a table over both fields present, a code on top (Subtotal plus discount), an account balance on top, a gap nothing explains (no rows), and only one field present (the single row). A second case covers plan names across cadences. - `e2e/full-page-summary.spec.ts`: the upgrade and account-balance fixtures now quote both fields the way the real backend does, and they assert both rows. Both specs fail against a build that ignores the fields (single "Pro Plan - Prorated" row) and pass with this change. ## Where this sits in the plan | State | PR / ticket | Scope | |---|---|---| | Merged | Comfy-Org#19248 | FE-3067 gate `/v1/checkout` on `billing_web_checkout_ui` | | Merged | Comfy-Org#19253 | FE-3018 / FE-3019 / FE-3020 / FE-3021 / FE-3022 full-page checkout | | Merged | Comfy-Org#19672 | FE-3019 server-reported subtotal, list price, discount term, balance, receipts | | Merged | Comfy-Org#19673 | FE-3072 credit top-up on the full page | | Merged (BE) | cloud#11252 | Itemized proration on the quote | | Open | **this PR** | FE-3177 itemized proration rows | | In progress | FE-3176 | Phase-A cancel while a 3DS challenge is open | | Next | M3-8 / M3-9 / M3-10 | QA, rollout via the flag, then delete the M2 path and the flag | ```mermaid flowchart LR G["FE-3067 PR 19248 flag gate"] --> S["FE-3018 PR 19253 full-page checkout"] S --> F19["FE-3019 summary + PR 19672"] S --> F20["FE-3020 promo codes"] S --> F21["FE-3021 endings"] S --> F22["FE-3022 payment authentication"] S --> F72["FE-3072 PR 19673 top-up"] BE["cloud 11252 itemized proration"] --> ME["FE-3177 proration rows (this PR)"] F19 --> ME F22 --> C["FE-3176 Phase-A cancel"] ME --> QA["M3-8 QA"] C --> QA F20 --> QA F21 --> QA F72 --> QA QA --> RO["M3-9 rollout"] RO --> DEL["M3-10 delete M2 path + flag"] style ME stroke-width:3px ``` Fixes FE-3177 ## AS IS / TO BE Fixture build (billing-web e2e mocks), Creator to Pro mid-period upgrade. | Case | AS IS | TO BE | | --- | --- | --- | | Prorated upgrade | <img src="https://github.com/user-attachments/assets/006990dc-a8b4-4e81-b5af-d08afb87bb6d" width="400"> | <img src="https://github.com/user-attachments/assets/87333a69-f08b-440e-b2c3-1eb6c7ec03c4" width="400"> | | Prorated upgrade with a code | n/a | <img src="https://github.com/user-attachments/assets/b3408b0e-d5e0-467a-9ade-8dfb210ae5c1" width="400"> |
Summary
The full-page checkout now shows the numbers the backend started reporting on 2026-09-30: the pre-discount subtotal, a discounted plan's list price, each coupon's term, the account balance applied today, and what a settled payment charged, added and bought.
Changes
subtotal_cents,new_plan.list_price_centsanddiscounts[].duration/duration_in_monthsto the checkout quote; cloud ops: add patch release support to ComfyUI release workflow #11223 addedbalance_applied_cents; cloud [backport cloud/1.42] fix: persist subgraph viewport across navigation and tab switches (#10247) #11199 (BE-17842) addedamount_charged_cents,credits_addedandplanto a succeeded op status. Alex's decisions in DES-1210 / DES-1211 / DES-1212 held these slots until the backend reported them ("no Subtotal until the quote reports one", "no discounted-rate strikethrough until the quote has a list price", "Success credits line stays off until BE-17842"). All four are on cloud main.renewal_atgap): our e2e fixture quoted that transition withoutrenewal_at; the real backend returns it, so the undated copy was never the backend's answer.@comfyorg/ingest-typesregenerated from cloud@0dbfffb the way cloud's push-ingest-types workflow does it (openapi-project -fe,pnpm generate,oxfmt). account-core reads the new int64 amounts as safe integers, like the existing cents (sharedwireCents), and keeps the generated Zod strict.receipt(amount charged, credits added, plan), each absent while the server cannot say it.recover({ includeSettled: true })re-reads a success whose credits are still landing, the way it already re-reads a parked reconciliation.summaryLedger.ts,CheckoutLedger.vuesplit intoLedgerRows/LedgerItem/LedgerDeduction): a discounted plan rate shows its list price struck through; a discount row states its term ("First year" / "First month" foronce, "For N months" forrepeating, nothing forforeveror an unknown term); "Account balance −$X / Credit already on your account" is the last deduction (744-15697) and keeps the prorated row it explains instead of dropping it; Subtotal (re-added after FE-3020 fix(billing-web): restore a promo this page applied, and keep discount rows in server order #19613 removed it) shows only where a discount follows two or more money rows.endingScreen.ts,CheckoutEnding.vue): Success counts the credits the op reports (77-4068). Already completed and You're all set name the plan the receipt names, priced from the catalog (328-4444), in place of the reference code. A top-up's Already completed lists Added and Amount paid and no balance (410-5225). A charge whose credits are still landing reads Payment received with Payment / Credits added "Adding…" / Plan rows (390-4947), re-reads on the parked cadence, and resolves to Success or Already completed once the credits land.new_plan.price_cents, so a promo showed the full rate. When the server-reported charge differs from that rate, the card keeps the rate, adds a divider, one row per reason, then "Paid today".successBreakdown.tsdecides the rows as a pure projection and reuses the summary's discount and balance rows (LedgerDeduction/LedgerItem). Paid today isamount_charged_centsfrom the succeeded op when the page read one, else the quote'samount_due_centsfor this page's own Pay. Reasons: the entered code, a discount the subscription already holds (with its term), and the account balance. A prorated change reads only Paid today with "Prorated for the rest of this billing period". A plan-level rate, a scheduled change, and a charge equal to the rate get no rows.switchToYearlyquotes a monthly-to-yearly switch the way the real backend does, withrenewal_at,list_price_centsandsubtotal_cents. The earlier "renewal_at BE gap" on this transition came from our fixture, not the backend.Rule 2. Every amount and count on these screens is a number the server reported: quote fields, op status fields, or the plan catalog. The page adds, subtracts, divides and converts nothing;
centsToCreditsis not used on any outcome screen.Review Focus
$700/mo × 12 months, billed yearly". The quote reportsprice_centsandlist_price_centsper billing period, so a yearly plan renders "$7,560$8,400/yr, billed yearly". The per-month form would need either a/ 12on the page (Rule 2) or per-month fields from the backend.proration_remaining_cents/proration_unused_cents, plusrenewal_atwithout the embedded flag) is still open, so the prorated row keeps its single stand-in subline.onceon a monthly plan reads "First month". DES-1211 only specifies "first year" (on yearly).amount_charged_cents) against the catalog rate with no reason rows: the op status reports no promo, discount, balance or proration. It also cannot say a charge was prorated, so the subline is absent there. Itemized reasons on that path need the op status to report them.settledPlanReadnow applies to any settled page this tab did not price (receipt plan, else the status's plan for a returned payment); the page's own Pay still names the plan from its quote.new_free_tier_subscriptionsfield disappears fromGetFeaturesResponse. It was hand-added to the generated files in feat(website): hide free tier behind cloudFreeTier feature flag #12170 and is not in the cloud spec;apps/websiteextends the schema with it andRemoteConfigdeclares it, so nothing reads it from ingest-types.Screenshots (if applicable)
Fixture build (billing-web e2e mocks), dark, 1512×982.
Where this PR sits in Milestone 3
billing_web_checkout_uipayment_not_completedrenewal_atwithout the flag, itemized proration