Repository navigation
FE-3018 fix(billing-web): send a planless checkout link to the pricing table - #19611
Conversation
A cloud link goes to the host's pricing table, on the Team tab when it names a team. A platform link goes to its return_to when billing may follow it, otherwise to Platform's billing page.
…g table A checkout link with no plan went to its return_to home. Per DES-1209 it now goes where a plan is picked: the cloud pricing table (Team tab for a team link), or for a platform link its return_to, falling back to a new platform_billing return target (platform.comfy.org/profile/billing). Only the destination changes; the planless routing still runs before any session or flag read.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2160 passed, 0 failed📊 Browser Reports
🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 28d0e3c573963fb13b2474ce93e3f97f0334bb84
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzip 🔴 +355 kBDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.73 kB) • 🔴 +38 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.43 MB) • 🔴 +32.1 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 124 kB) • 🔴 +9.54 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 643 kB (baseline 621 kB) • 🔴 +21.7 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 39.4 kB (baseline 27.8 kB) • 🔴 +11.6 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +691 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 125 kB (baseline 117 kB) • 🔴 +8.07 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 4.09 MB (baseline 3.6 MB) • 🔴 +492 kBStores, services, APIs, and repositories
Status: 15 added / 16 removed Utilities & Hooks — 582 kB (baseline 559 kB) • 🔴 +23.3 kBHelpers, composables, and utility bundles
Status: 31 added / 30 removed / 6 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -689 kBExternal libraries and shared vendor chunks
Status: 13 added / 13 removed / 5 unchanged Other — 17.9 MB (baseline 16.4 MB) • 🔴 +1.55 MBBundles that do not match a named category
Status: 178 added / 174 removed / 122 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T10:36:52.990Z",
"gitSha": "7859f990d861ade5d21feaadc7c626ba7383ed2d",
"branch": "jaewon/fe-3018-planless-destination",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.9919999999975,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.186000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.983,
"heapDeltaBytes": -38510536,
"heapUsedBytes": 59790528,
"domNodes": -228,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 9.942999999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2031.704999999988,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.730000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.319,
"heapDeltaBytes": -2516240,
"heapUsedBytes": 76364104,
"domNodes": -228,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.209000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1761.4100000000121,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.532,
"layouts": 12,
"layoutDurationMs": 4.616,
"taskDurationMs": 819.4060000000001,
"heapDeltaBytes": -32106668,
"heapUsedBytes": 65724912,
"domNodes": -228,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 156.374,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1843.6530000000175,
"styleRecalcs": 79,
"styleRecalcDurationMs": 18.032,
"layouts": 12,
"layoutDurationMs": 4.9719999999999995,
"taskDurationMs": 838.592,
"heapDeltaBytes": -34268772,
"heapUsedBytes": 64289456,
"domNodes": -228,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 153.445,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.7629999999917,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.183000000000002,
"layouts": 6,
"layoutDurationMs": 1.3780000000000001,
"taskDurationMs": 336.79600000000005,
"heapDeltaBytes": -18563604,
"heapUsedBytes": 79868840,
"domNodes": 53,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.931999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1758.715000000052,
"styleRecalcs": 33,
"styleRecalcDurationMs": 10.147,
"layouts": 6,
"layoutDurationMs": 1.327,
"taskDurationMs": 332.305,
"heapDeltaBytes": -18708620,
"heapUsedBytes": 80004332,
"domNodes": 53,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 12.343000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 699.3360000000166,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.8329999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.246,
"heapDeltaBytes": 18661780,
"heapUsedBytes": 97910076,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 168.68,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 669.8860000000195,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.514,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.04200000000003,
"heapDeltaBytes": 18261348,
"heapUsedBytes": 97703960,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 162.52,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000018,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1158.001000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 799.492,
"heapDeltaBytes": 6123928,
"heapUsedBytes": 83775324,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 62.018000000000015,
"eventListeners": 0,
"totalBlockingTimeMs": 519,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1186.0399999999345,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 838.297,
"heapDeltaBytes": 9967572,
"heapUsedBytes": 87178140,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 67.756,
"eventListeners": 0,
"totalBlockingTimeMs": 550,
"frameDurationMs": 34.80000000000002,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.3480000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.7440000000001,
"heapDeltaBytes": -16902272,
"heapUsedBytes": 68451332,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 143.905,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.5680000000102,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.6899999999998,
"heapDeltaBytes": 15340152,
"heapUsedBytes": 89741828,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 148.356,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10058.197999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9105.135,
"heapDeltaBytes": -13082228,
"heapUsedBytes": 66945032,
"domNodes": 0,
"jsHeapTotalBytes": -16515072,
"scriptDurationMs": 7392.436,
"eventListeners": 0,
"totalBlockingTimeMs": 464,
"frameDurationMs": 31.307165109034262,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9072.464999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8212.894,
"heapDeltaBytes": -949844,
"heapUsedBytes": 79870112,
"domNodes": 0,
"jsHeapTotalBytes": -9175040,
"scriptDurationMs": 6622.244,
"eventListeners": 0,
"totalBlockingTimeMs": 190,
"frameDurationMs": 30.120930232558138,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8988.113999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8127.62,
"heapDeltaBytes": -1198548,
"heapUsedBytes": 79353920,
"domNodes": 0,
"jsHeapTotalBytes": -13369344,
"scriptDurationMs": 6554.019,
"eventListeners": 0,
"totalBlockingTimeMs": 146,
"frameDurationMs": 29.205863192182406,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9160.757999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8306.076000000001,
"heapDeltaBytes": 11171364,
"heapUsedBytes": 92254108,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 6686.531,
"eventListeners": 0,
"totalBlockingTimeMs": 147,
"frameDurationMs": 29.41993569131833,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2048.607000000004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.236,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.9849999999999,
"heapDeltaBytes": -35746972,
"heapUsedBytes": 83127392,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 31.097,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2033.6790000000065,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.5909999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.075,
"heapDeltaBytes": -35948136,
"heapUsedBytes": 83189076,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 31.196,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80327868852459,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2244.2609999999945,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.193999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1526.675,
"heapDeltaBytes": 19457192,
"heapUsedBytes": 83165608,
"domNodes": 0,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 793.4010000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666417910447763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2212.2289999999794,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.049,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1543.442,
"heapDeltaBytes": 20299852,
"heapUsedBytes": 83000600,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 789.8870000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666412213740454,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3567.169999999976,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.23,
"layouts": 60,
"layoutDurationMs": 14.955,
"taskDurationMs": 1631.013,
"heapDeltaBytes": 12627796,
"heapUsedBytes": 77253116,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 771.93,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186912,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3685.8290000000125,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.959,
"layouts": 60,
"layoutDurationMs": 14.956999999999999,
"taskDurationMs": 1667.498,
"heapDeltaBytes": 13045884,
"heapUsedBytes": 77538736,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 797.07,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66621621621622,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3068.2350000000156,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.397,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1752.3609999999999,
"heapDeltaBytes": 27450868,
"heapUsedBytes": 92619768,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 985.7090000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75737704918033,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3101.9000000000005,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.506999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1910.7610000000002,
"heapDeltaBytes": 24126832,
"heapUsedBytes": 89155400,
"domNodes": -228,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 975.125,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75621621621622,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2040.506999999991,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6119999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.394,
"heapDeltaBytes": -37788816,
"heapUsedBytes": 83166320,
"domNodes": -228,
"jsHeapTotalBytes": -98304,
"scriptDurationMs": 34.747,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2061.5249999999605,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4620000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.8659999999999,
"heapDeltaBytes": -37545768,
"heapUsedBytes": 83166620,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 36.08599999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.4940000000261,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.864000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.99800000000005,
"heapDeltaBytes": 12407520,
"heapUsedBytes": 93830996,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 141.67000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.3390000000672,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.258,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.3759999999999,
"heapDeltaBytes": 12730264,
"heapUsedBytes": 94115668,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 143.80399999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567588,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.1200000000154,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.727999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.28599999999994,
"heapDeltaBytes": -25847840,
"heapUsedBytes": 55709092,
"domNodes": -244,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 8.739999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.0429999999205,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.439,
"heapDeltaBytes": -15507876,
"heapUsedBytes": 65921728,
"domNodes": -244,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 8.418999999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.8839999999886,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.817,
"layouts": 16,
"layoutDurationMs": 5.792999999999999,
"taskDurationMs": 742.804,
"heapDeltaBytes": -8162760,
"heapUsedBytes": 73457152,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 104.21,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66699029126214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1785.5620000000272,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.081,
"layouts": 16,
"layoutDurationMs": 6.053,
"taskDurationMs": 761.373,
"heapDeltaBytes": -22822604,
"heapUsedBytes": 58711164,
"domNodes": -244,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 106.02000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.82264150943396,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.6459999999556,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.313999999999993,
"layouts": 5,
"layoutDurationMs": 11.857,
"taskDurationMs": 867.2390000000001,
"heapDeltaBytes": 23298448,
"heapUsedBytes": 104765880,
"domNodes": 13667,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.354999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 122,
"frameDurationMs": 19.212500000000016,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8336.229000000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.86599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5483.812,
"heapDeltaBytes": -36041428,
"heapUsedBytes": 83971536,
"domNodes": -228,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 2613.78,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666132264529057,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8334.967000000006,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.417,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5519.504,
"heapDeltaBytes": -35800432,
"heapUsedBytes": 84036028,
"domNodes": -228,
"jsHeapTotalBytes": 1404928,
"scriptDurationMs": 2633.305,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17416.181999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16840.954,
"heapDeltaBytes": -21795296,
"heapUsedBytes": 177087956,
"domNodes": -3045,
"jsHeapTotalBytes": 9203712,
"scriptDurationMs": 287.892,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.43664259927798,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 17488.895999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16839.832000000002,
"heapDeltaBytes": -28093532,
"heapUsedBytes": 196552360,
"domNodes": -3045,
"jsHeapTotalBytes": 8306688,
"scriptDurationMs": 278.088,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.58718411552347,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 21069.675000000017,
"styleRecalcs": 163,
"styleRecalcDurationMs": 17.824000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20755.203,
"heapDeltaBytes": -56834724,
"heapUsedBytes": 168378068,
"domNodes": -3045,
"jsHeapTotalBytes": 7831552,
"scriptDurationMs": 877.436,
"eventListeners": -14915,
"totalBlockingTimeMs": 138,
"frameDurationMs": 40.04904942965779,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 21438.256000000023,
"styleRecalcs": 153,
"styleRecalcDurationMs": 18.833000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21157.945,
"heapDeltaBytes": -68751788,
"heapUsedBytes": 178016116,
"domNodes": -8049,
"jsHeapTotalBytes": -20242432,
"scriptDurationMs": 888.353,
"eventListeners": -14923,
"totalBlockingTimeMs": 167,
"frameDurationMs": 41.120000000000005,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6183.051999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.22600000000001,
"layouts": 20,
"layoutDurationMs": 24.332000000000008,
"taskDurationMs": 6120.807999999999,
"heapDeltaBytes": -3684372,
"heapUsedBytes": 182434996,
"domNodes": -8049,
"jsHeapTotalBytes": 21495808,
"scriptDurationMs": 111.17999999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 399,
"frameDurationMs": 37.70182926829268,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6168.51900000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.30300000000001,
"layouts": 20,
"layoutDurationMs": 23.749999999999993,
"taskDurationMs": 6110.999,
"heapDeltaBytes": -9520032,
"heapUsedBytes": 178975064,
"domNodes": -8049,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 110.44900000000001,
"eventListeners": -3,
"totalBlockingTimeMs": 448,
"frameDurationMs": 39.170700636942684,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8624.058000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8479.402,
"heapDeltaBytes": -16718660,
"heapUsedBytes": 174935196,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 166.25999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.105415162454875,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8602.988000000096,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8449.067,
"heapDeltaBytes": -31349756,
"heapUsedBytes": 185535488,
"domNodes": -3045,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 138.91000000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.850370370370364,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 144.4179999999733,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.157,
"layouts": 4,
"layoutDurationMs": 2.194,
"taskDurationMs": 122.29199999999999,
"heapDeltaBytes": -16159244,
"heapUsedBytes": 80754848,
"domNodes": 123,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 12.606,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.737500000000068,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 132.49200000007022,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.638,
"layouts": 2,
"layoutDurationMs": 1.4820000000000002,
"taskDurationMs": 89.46900000000001,
"heapDeltaBytes": -16496120,
"heapUsedBytes": 79595336,
"domNodes": 113,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 6.101999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1004.2210000000296,
"styleRecalcs": 78,
"styleRecalcDurationMs": 118.70100000000001,
"layouts": 76,
"layoutDurationMs": 28.332,
"taskDurationMs": 967.6139999999999,
"heapDeltaBytes": 18794988,
"heapUsedBytes": 90762040,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 381.51199999999994,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.949152542372882,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 966.2120000000414,
"styleRecalcs": 78,
"styleRecalcDurationMs": 117.282,
"layouts": 76,
"layoutDurationMs": 27.078000000000003,
"taskDurationMs": 943.228,
"heapDeltaBytes": 18587328,
"heapUsedBytes": 90295836,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 390.899,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664406779661014,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1384.0660000000753,
"styleRecalcs": 78,
"styleRecalcDurationMs": 279.814,
"layouts": 76,
"layoutDurationMs": 29.322,
"taskDurationMs": 1373.038,
"heapDeltaBytes": -19055712,
"heapUsedBytes": 110899216,
"domNodes": 76,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 435.407,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.161538461538466,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1458.752000000004,
"styleRecalcs": 78,
"styleRecalcDurationMs": 276.023,
"layouts": 76,
"layoutDurationMs": 31.291,
"taskDurationMs": 1438.105,
"heapDeltaBytes": -18681484,
"heapUsedBytes": 111231964,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 473.581,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.541250000000012,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19611 +/- ##
==========================================
- Coverage 84.40% 84.40% -0.01%
==========================================
Files 3326 3326
Lines 160434 160441 +7
Branches 43700 43703 +3
==========================================
- Hits 135419 135417 -2
- Misses 23120 23130 +10
+ Partials 1895 1894 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (8)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughPlanless checkout now routes non-platform entries to default or team pricing tables. Platform entries return to a recognized target or platform billing. Updated tests cover these destinations, return-target resolution, and checkout navigation conditions. ChangesPlanless checkout routing
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant Checkout
participant BillingRouter
participant ReturnTargets
participant Destination
Checkout->>BillingRouter: Open planless checkout
BillingRouter->>ReturnTargets: Resolve platform return_to target
ReturnTargets-->>BillingRouter: Return recognized target or no match
BillingRouter->>Destination: Navigate to selected pricing or platform URL
Merge Risk: ⚪ Minimal · up to Planless links now select cloud pricing or registered Platform destinations, with coverage for fallback and navigation behavior. No actionable merge-blocking risk is established; merge after normal checks pass. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The routing change keeps destinations restricted to registered or configured hosts and preserves stale-navigation protections. No introduced security bypass was identified. The receiving Platform page’s access controls and deployed behavior were not verified. Retained concerns Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 6 | ❓ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR has a bug-fix signal ( ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the exact head against the stated account-layer behavior, tests, existing review threads, and settled CI. No blocking issue found.
…wn, unbroken dates and IDs, settled copy (Comfy-Org#19612) ## Summary Alex Tov's visual pass on the M3 full-page checkout (Slack, 2026-09-29): a checkbox outline that reads on its card, a saved-card list that opens dark, dates and reference codes that wrap in one piece, and settled-payment copy that names the workspace. ## Why Five findings from the designer's pass over the fixture build. The unticked box was near-invisible, the saved-card list opened white on a dark page, dates split before the year on phones ("…refill monthly after July 28, / 2026"), long UUID reference codes could split mid-segment, and the settled-while-watched body didn't match Figma 717-14670. ## Root cause - Checkbox: the unticked outline used `border-border-default`, which sits too close to `bg-tertiary-background`. - Dropdown: `dark-theme` lived on each view's wrapper, but Reka's `SelectPortal` teleports the list to `<body>`, outside every wrapper, so it resolved light tokens. - Dates: each formatter produced ordinary spaces, and there were three of them (`longDate`, the summary ledger's inline `Intl.DateTimeFormat` pair, `useHostedCopy().date`). - Code card: break opportunities were inserted only after underscores. Op IDs are UUIDs with hyphens. ## Changes - **What**: - Keep-subscription checkbox: the unticked outline is `border-muted-foreground`. Ticked and invalid states are unchanged. - Saved-card dropdown: `dark-theme` now sits on `<html>` in `apps/billing-web/index.html`. Every billing-web surface is dark, so portalled UI now gets the dark tokens too, and the list's `bg-base-background` matches the trigger. - Dates: `longDate.ts` owns every date in billing-web copy and joins it with non-breaking spaces (`unbrokenDate`). The summary ledger's `date`/`monthDay` and `useHostedCopy().date` now go through it. - Reference code card: splits on `/(?<=[_-])/`, adding a break opportunity after each hyphen as well as each underscore (372-4951). - Settled while watched (717-14670): "A payment for {workspace} went through. Check your plan in settings for the details." `{workspace}` is the session's workspace name, which the page already passes to every ending. Without a session name it falls back to the existing `ending.thisWorkspace` copy ("A payment for this workspace went through."). ## How TDD. Tests were changed first and confirmed red, then the fix turned them green. - Pure-string tests (`summaryLedger.test.ts`, `keepSubscription.test.ts`) now spell dates with ` `. DOM tests using `getByText`/`toHaveTextContent` normalise whitespace (NBSP included), so they can't observe the change and stay as they were. - `CheckoutEnding.test.ts` pins the code card's break opportunities for a UUID and an underscore code, plus the new settled copy. - New e2e in `full-page-checkout.spec.ts`: the open saved-card list's computed background equals its trigger's. Before the fix it was `rgb(255, 255, 255)` against `rgb(23, 23, 24)`. ## Review Focus - `dark-theme` on `<html>` makes the per-view wrapper classes redundant. I left those untouched to keep this diff off files other in-flight PRs are editing. Removing them is a follow-up. - Chromium already breaks after a hyphen before a digit, so the code card looks the same in both builds there. The explicit `<wbr>` covers engines that apply UAX Comfy-Org#14 LB25 (no break between a hyphen and a number) and fall back to `wrap-anywhere` mid-segment. ## Screenshots (if applicable) All images are from the **fixture build**: the billing-web Playwright fixtures (mocked Cloud, fake Stripe.js), production `vite build`, dark theme, 1512×982 unless the row says phone (390×844). AS IS is `origin/main`, TO BE is this PR. None are from a real backend. ### AS IS / TO BE | Item | AS IS (fixture build) | TO BE (fixture build) | | --- | --- | --- | | 1. Unticked keep-subscription box, close-up | <img width="384" alt="checkbox close-up AS IS" src="https://github.com/user-attachments/assets/87363a1f-b7c9-42a8-8c2c-257102f31abb" /> | <img width="384" alt="checkbox close-up TO BE" src="https://github.com/user-attachments/assets/f1d97bbe-f956-49e4-8902-cf5aacd822c1" /> | | 1. Unticked keep-subscription box, full page | <img width="420" alt="checkbox AS IS" src="https://github.com/user-attachments/assets/09d2695e-9169-4c3d-becf-27ad97db9ee9" /> | <img width="420" alt="checkbox TO BE" src="https://github.com/user-attachments/assets/1c636614-e243-4161-9a91-95467ba1818b" /> | | 2. Saved-card dropdown open | <img width="420" alt="dropdown AS IS" src="https://github.com/user-attachments/assets/71a7474e-965f-4404-b7e3-e550476edf99" /> | <img width="420" alt="dropdown TO BE" src="https://github.com/user-attachments/assets/ecc37316-ed0d-480d-a9e2-4848946b9a52" /> | | 3. Scheduled downgrade summary, phone: "refill monthly after July 28, 2026" | <img width="220" alt="dates phone AS IS" src="https://github.com/user-attachments/assets/edba88d1-5c17-4570-91f0-b76cccb34241" /> | <img width="220" alt="dates phone TO BE" src="https://github.com/user-attachments/assets/f749c264-1a0a-4455-80c0-b56bdcab28e3" /> | | 4. Payment in progress with a UUID reference, phone. Same render in Chromium (see Review Focus) | <img width="220" alt="code phone AS IS" src="https://github.com/user-attachments/assets/94605dba-b20d-4363-9d2c-1ff7552c581e" /> | <img width="220" alt="code phone TO BE" src="https://github.com/user-attachments/assets/def1eb20-e316-4701-bc2e-3a5937dd8e30" /> | | 5. Payment in progress settles while watched (717-14670); fixture workspace is "Personal" | <img width="420" alt="settled AS IS" src="https://github.com/user-attachments/assets/b2612aea-503e-4988-b04f-732cbbf7a3ae" /> | <img width="420" alt="settled TO BE" src="https://github.com/user-attachments/assets/9271831b-a733-493b-b2b9-c5d5b0a5f6b3" /> | ## Where this PR sits in Milestone 3 | State | PR / ticket | Scope | |---|---|---| | Merged | Comfy-Org#19253 | M3 stack: FE-3018..3022 full page behind billing_web_checkout_ui | | Merged | Comfy-Org#19462 / Comfy-Org#19487 | Design review rounds 3-4 | | Merged | Comfy-Org#19540 Comfy-Org#19538 Comfy-Org#19536 Comfy-Org#19537 | UX pass: money state, lock/redirect, promo, summary/copy | | Merged | Comfy-Org#19531 | Accept `payment_not_completed` (must ship before cloud#11119) | | Open | Comfy-Org#19611 | Planless link goes to the plan picker | | Open | **Comfy-Org#19612** (this PR) | Visual pass: checkbox, dark dropdown, unbroken dates/IDs, settled copy | | Open | Comfy-Org#19613 | Restore a promo this page applied; discount rows in server order | | Blocked on BE | FE-3072 (BE-17842) | Top-up on the full page; op facts for receipt/credits lines | | Blocked on BE | BE-13104 / BE-17785 / BE-10064 | $0 due card, subtotal + list price + renewal_at, Phase-A cancel | | Next | M3-9 / M3-10 | Rollout via the flag, then delete the M2 path and the flag | ```mermaid flowchart LR classDef done fill:#e3f5e1,stroke:#2e7d32 classDef open fill:#dff0ff,stroke:#1f6feb classDef be fill:#fde2e2,stroke:#c0392b classDef me fill:#fff4cc,stroke:#b58900,stroke-width:3px S["PR 19253 M3 stack"]:::done --> R["PR 19462 / PR 19487 design rounds"]:::done R --> U["UX pass PR 19540 PR 19538 PR 19536 PR 19537"]:::done R --> PNC["PR 19531 payment_not_completed"]:::done U --> P611["PR 19611 planless destination"]:::open U --> P612["PR 19612 visual pass"]:::open U --> P613["PR 19613 promo restore + order"]:::open BE1["BE-17842 op facts + top-up quote"]:::be --> TU["FE-3072 top-up"]:::open BE2["BE-13104 / BE-17785 / BE-10064"]:::be -.-> FU["$0 card, subtotal, cancel"]:::open P611 --> RO["M3-9 rollout"] P612 --> RO P613 --> RO PNC --> BEDEP["cloud PR 11119 deploy after FE release"]:::be RO --> CL["M3-10 delete M2 path + flag"] class P612 me ```
… discount rows in server order (Comfy-Org#19613) ## Summary Implements Alex Tov's decisions (a) and (c) from the M3 design review: a promo code applied on the full-page checkout survives a reload or a 3DS/Alipay return, and the summary lists discount rows in the order the server returns them. ## Changes - **Why**: - (a) A code applied on this page was lost after a reload or a provider return, and the price rose with no explanation. The no-auto-apply rule covers codes arriving from outside links; a code applied here must come back. - (c) The entered code rendered in its own slot after the held discounts, whatever order the quote listed them in. - **Root cause**: - (a) The applied code lived only in the in-memory `PromoEntry` state. The subscribe return URL carries only the link's own `promo`, so every fresh mount started from the link, not from what the customer applied. - (c) `summaryLedger.ts` split promotions into `adjustments` (held) and a separate `promo` row (entered), and `CheckoutLedger.vue` rendered them in two places. - **How**: - New `checkout/promoMemory.ts` keeps one `{ identity, code }` record in `sessionStorage`. The identity is the checkout request (workspace, product, plan, team credit stop), so another checkout reads nothing and drops the stale record. Every storage access sits in try/catch; without storage the page behaves as before. Nothing is written to the page URL or the return URL. - `initialPromoEntry` takes the recalled code and starts `applied`, so the existing capture read (`requoteWithPromo`) re-prices it through the normal quote. A server refusal lands on the existing "Your promo code expired" card (Figma 476-14445). - `useCheckoutPromo` writes the remembered code after each reducer transition that changes it (pure `codeToRemember`), so Remove and an expiry clear it. `useFullPageCheckout` clears it when the page reaches a terminal state. - `SummaryLedger.discounts` replaces `adjustments`, `promo` and `subtotal`: every `promotion` discount becomes a row in server order, labelled `name ?? "Promo code"`, at the server's amount. The removable chip on the entered code is unchanged. `subtotal` was never populated (the quote reports no pre-discount base) and had no position once the entered-code slot went away, so it is removed with its i18n key. ## Review Focus - Chips keep their existing order (held codes, then the entered code). Only the money rows follow server order. - A restored code outranks a link's `promo` prefill for the same checkout identity. - Tests: reducer seed cases, `promoMemory` (identity scoping, malformed records, throwing storage), ledger server order, view-level reload/refuse/remove/success/other-plan/return-URL cases, and four new e2e specs (reload keeps the discount, refusal on reload shows the expired card, a copied URL carries no applied code, entered code listed first renders first). ## Screenshots (if applicable) Fixture build (billing-web e2e mocks), dark, 1512×982. | Case | AS IS | TO BE | | --- | --- | --- | | Apply LAUNCH20, reload | <img width="600" alt="AS IS reload" src="https://github.com/user-attachments/assets/bf222d93-cdf2-49b3-88c0-c9d8a7ee2986" /> | <img width="600" alt="TO BE reload" src="https://github.com/user-attachments/assets/552839e4-240b-404a-9d09-351f9e7b5901" /> | | Apply, server refuses the code on reload | <img width="600" alt="AS IS refused" src="https://github.com/user-attachments/assets/f73a8a14-784a-4cb4-bc30-545dfefe558e" /> | <img width="600" alt="TO BE refused" src="https://github.com/user-attachments/assets/63d358de-0cb2-4e74-9ad6-451d88ae3525" /> | | Server lists the entered code first | <img width="600" alt="AS IS order" src="https://github.com/user-attachments/assets/26af2ea4-6d98-42f6-8b4d-8601310b49c9" /> | <img width="600" alt="TO BE order" src="https://github.com/user-attachments/assets/86a12997-06ca-4a12-baf1-4e169afb8ce5" /> | ## Where this PR sits in Milestone 3 | State | PR / ticket | Scope | |---|---|---| | Merged | Comfy-Org#19253 | M3 stack: FE-3018..3022 full page behind billing_web_checkout_ui | | Merged | Comfy-Org#19462 / Comfy-Org#19487 | Design review rounds 3-4 | | Merged | Comfy-Org#19540 Comfy-Org#19538 Comfy-Org#19536 Comfy-Org#19537 | UX pass: money state, lock/redirect, promo, summary/copy | | Merged | Comfy-Org#19531 | Accept `payment_not_completed` (must ship before cloud#11119) | | Open | Comfy-Org#19611 | Planless link goes to the plan picker | | Open | Comfy-Org#19612 | Visual pass: checkbox, dark dropdown, unbroken dates/IDs, settled copy | | Open | **Comfy-Org#19613** (this PR) | Restore a promo this page applied; discount rows in server order | | Blocked on BE | FE-3072 (BE-17842) | Top-up on the full page; op facts for receipt/credits lines | | Blocked on BE | BE-13104 / BE-17785 / BE-10064 | $0 due card, subtotal + list price + renewal_at, Phase-A cancel | | Next | M3-9 / M3-10 | Rollout via the flag, then delete the M2 path and the flag | ```mermaid flowchart LR classDef done fill:#e3f5e1,stroke:#2e7d32 classDef open fill:#dff0ff,stroke:#1f6feb classDef be fill:#fde2e2,stroke:#c0392b classDef me fill:#fff4cc,stroke:#b58900,stroke-width:3px S["PR 19253 M3 stack"]:::done --> R["PR 19462 / PR 19487 design rounds"]:::done R --> U["UX pass PR 19540 PR 19538 PR 19536 PR 19537"]:::done R --> PNC["PR 19531 payment_not_completed"]:::done U --> P611["PR 19611 planless destination"]:::open U --> P612["PR 19612 visual pass"]:::open U --> P613["PR 19613 promo restore + order"]:::open BE1["BE-17842 op facts + top-up quote"]:::be --> TU["FE-3072 top-up"]:::open BE2["BE-13104 / BE-17785 / BE-10064"]:::be -.-> FU["$0 card, subtotal, cancel"]:::open P611 --> RO["M3-9 rollout"] P612 --> RO P613 --> RO PNC --> BEDEP["cloud PR 11119 deploy after FE release"]:::be RO --> CL["M3-10 delete M2 path + flag"] class P613 me ```
…e, discount duration, balance and receipts (Comfy-Org#19672) ## Summary The full-page checkout now shows the numbers the backend started reporting on 2026-09-30: the pre-discount subtotal, a discounted plan's list price, each coupon's term, the account balance applied today, and what a settled payment charged, added and bought. ## Changes - **Why**: cloud Comfy-Org#11148 (BE-17785) added `subtotal_cents`, `new_plan.list_price_cents` and `discounts[].duration` / `duration_in_months` to the checkout quote; cloud Comfy-Org#11223 added `balance_applied_cents`; cloud Comfy-Org#11199 (BE-17842) added `amount_charged_cents`, `credits_added` and `plan` to a succeeded op status. Alex's decisions in DES-1210 / DES-1211 / DES-1212 held these slots until the backend reported them ("no Subtotal until the quote reports one", "no discounted-rate strikethrough until the quote has a list price", "Success credits line stays off until BE-17842"). All four are on cloud main. - **Root cause** (the monthly-to-yearly `renewal_at` gap): our e2e fixture quoted that transition without `renewal_at`; the real backend returns it, so the undated copy was never the backend's answer. - **How**: - `@comfyorg/ingest-types` regenerated from cloud@0dbfffb the way cloud's push-ingest-types workflow does it (`openapi-project -fe`, `pnpm generate`, `oxfmt`). account-core reads the new int64 amounts as safe integers, like the existing cents (shared `wireCents`), and keeps the generated Zod strict. - account-core: a succeeded operation carries a `receipt` (amount charged, credits added, plan), each absent while the server cannot say it. `recover({ includeSettled: true })` re-reads a success whose credits are still landing, the way it already re-reads a parked reconciliation. - Summary (`summaryLedger.ts`, `CheckoutLedger.vue` split into `LedgerRows` / `LedgerItem` / `LedgerDeduction`): a discounted plan rate shows its list price struck through; a discount row states its term ("First year" / "First month" for `once`, "For N months" for `repeating`, nothing for `forever` or an unknown term); "Account balance −$X / Credit already on your account" is the last deduction (744-15697) and keeps the prorated row it explains instead of dropping it; Subtotal (re-added after Comfy-Org#19613 removed it) shows only where a discount follows two or more money rows. - Endings (`endingScreen.ts`, `CheckoutEnding.vue`): Success counts the credits the op reports (77-4068). Already completed and You're all set name the plan the receipt names, priced from the catalog (328-4444), in place of the reference code. A top-up's Already completed lists Added and Amount paid and no balance (410-5225). A charge whose credits are still landing reads Payment received with Payment / Credits added "Adding…" / Plan rows (390-4947), re-reads on the parked cadence, and resolves to Success or Already completed once the credits land. - Success card, paid today (Alex, FE-3021 "Added 2026-09-30", 758-15763 / 765-15713; same bug as FE-2119 in the old flow): the card priced the plan from `new_plan.price_cents`, so a promo showed the full rate. When the server-reported charge differs from that rate, the card keeps the rate, adds a divider, one row per reason, then "Paid today". `successBreakdown.ts` decides the rows as a pure projection and reuses the summary's discount and balance rows (`LedgerDeduction` / `LedgerItem`). Paid today is `amount_charged_cents` from the succeeded op when the page read one, else the quote's `amount_due_cents` for this page's own Pay. Reasons: the entered code, a discount the subscription already holds (with its term), and the account balance. A prorated change reads only Paid today with "Prorated for the rest of this billing period". A plan-level rate, a scheduled change, and a charge equal to the rate get no rows. - e2e fixtures: `switchToYearly` quotes a monthly-to-yearly switch the way the real backend does, with `renewal_at`, `list_price_cents` and `subtotal_cents`. The earlier "renewal_at BE gap" on this transition came from our fixture, not the backend. - **Breaking**: none. Every field is optional and each slot renders only when the server reports its number. **Rule 2.** Every amount and count on these screens is a number the server reported: quote fields, op status fields, or the plan catalog. The page adds, subtracts, divides and converts nothing; `centsToCredits` is not used on any outcome screen. ## Review Focus - **Needs a decision: per-month compare price.** Figma shows "$630 ~~$700~~ /mo × 12 months, billed yearly". The quote reports `price_cents` and `list_price_cents` per billing period, so a yearly plan renders "$7,560 ~~$8,400~~ /yr, billed yearly". The per-month form would need either a `/ 12` on the page (Rule 2) or per-month fields from the backend. - **Subtotal is not reachable yet.** Every family has at most one money row today, so the ≥2-rows rule never fires. It fires once itemized proration lands. - **Itemized proration is left out.** cloud Comfy-Org#11252 (`proration_remaining_cents` / `proration_unused_cents`, plus `renewal_at` without the embedded flag) is still open, so the prorated row keeps its single stand-in subline. - **Discount term for `once` on a monthly plan** reads "First month". DES-1211 only specifies "first year" (on yearly). - **Server gap on the Success breakdown.** After a payment-provider return (3DS, Alipay) the page reads only the op status, so the card shows "Paid today" (`amount_charged_cents`) against the catalog rate with no reason rows: the op status reports no promo, discount, balance or proration. It also cannot say a charge was prorated, so the subline is absent there. Itemized reasons on that path need the op status to report them. - `settledPlanRead` now applies to any settled page this tab did not price (receipt plan, else the status's plan for a returned payment); the page's own Pay still names the plan from its quote. - The generated `new_free_tier_subscriptions` field disappears from `GetFeaturesResponse`. It was hand-added to the generated files in Comfy-Org#12170 and is not in the cloud spec; `apps/website` extends the schema with it and `RemoteConfig` declares it, so nothing reads it from ingest-types. ## Screenshots (if applicable) Fixture build (billing-web e2e mocks), dark, 1512×982. | Case | AS IS | TO BE | | --- | --- | --- | | Monthly to yearly, list price, first-year promo | <img width="600" alt="asis-summary-yearly" src="https://github.com/user-attachments/assets/6164b359-33f5-4143-94df-3f852b45eb49" /> | <img width="600" alt="tobe-summary-yearly" src="https://github.com/user-attachments/assets/86eef478-c83f-4880-a7b0-d5d4963b32dc" /> | | Prorated upgrade over an account balance | <img width="600" alt="asis-summary-balance" src="https://github.com/user-attachments/assets/e2786a06-da16-41c0-b96b-f677172f2aab" /> | <img width="600" alt="tobe-summary-balance" src="https://github.com/user-attachments/assets/db103f1b-badb-4d65-8d52-b58ea542e6d7" /> | | Success with the credits the op reports | <img width="600" alt="asis-ending-success" src="https://github.com/user-attachments/assets/65d79420-51d4-415b-ad00-5b7b060cdf02" /> | <img width="600" alt="tobe-ending-success" src="https://github.com/user-attachments/assets/6e4b6f36-95e4-4b23-b57b-601401c60d7e" /> | | Charge whose credits are still landing | <img width="600" alt="asis-ending-received" src="https://github.com/user-attachments/assets/7902f4bc-39a2-4c29-b6ad-447d3d7bf28f" /> | <img width="600" alt="tobe-ending-received" src="https://github.com/user-attachments/assets/a6b4e9f2-aad7-4496-9592-311e8de8eaec" /> | | Reload once the credits landed | <img width="600" alt="asis-ending-already" src="https://github.com/user-attachments/assets/83e80707-2f11-4971-af86-6620e00d76d9" /> | <img width="600" alt="tobe-ending-already" src="https://github.com/user-attachments/assets/477429b2-7cc6-4dc2-a8e5-a8a08880be02" /> | | Success under a promo code | <img width="600" alt="asis-success-discount" src="https://github.com/user-attachments/assets/8bdf911e-f195-4968-a069-5790303e5ec3" /> | <img width="600" alt="tobe-success-discount" src="https://github.com/user-attachments/assets/c3d5f7ae-f466-4df8-bdf1-6dd22ec62951" /> | | Success after a prorated upgrade | <img width="600" alt="asis-success-prorated" src="https://github.com/user-attachments/assets/b1cd2088-a8d2-4afe-a7a0-3a5d43f2b06f" /> | <img width="600" alt="tobe-success-prorated" src="https://github.com/user-attachments/assets/b66e7c28-e2c6-4e1d-8e42-c82879553548" /> | ## Where this PR sits in Milestone 3 | State | PR / ticket | Scope | |---|---|---| | Merged | Comfy-Org#19253 | M3 stack: FE-3018..3022 full page behind `billing_web_checkout_ui` | | Merged | Comfy-Org#19462 / Comfy-Org#19487 | Design review rounds 3-4 | | Merged | Comfy-Org#19540 Comfy-Org#19538 Comfy-Org#19536 Comfy-Org#19537 | UX pass: money state, lock/redirect, promo, summary/copy | | Merged | Comfy-Org#19531 | Accept `payment_not_completed` | | Merged | Comfy-Org#19611 Comfy-Org#19612 Comfy-Org#19613 | Follow-ups: planless link, visual pass, promo restore + server order | | Merged (BE) | cloud Comfy-Org#11148 Comfy-Org#11223 Comfy-Org#11188 Comfy-Org#11199 | Quote subtotal / list price / discount term / balance, top-up quote, op receipt | | Open (BE) | cloud Comfy-Org#11252 | `renewal_at` without the flag, itemized proration | | Open | **this PR** | Server-reported subtotal, list price, discount term, balance and receipts | | Open | Comfy-Org#19673 (stacked on this PR) | FE-3072 credit top-up on the full page | | Next | M3-9 / M3-10 | Rollout via the flag, then delete the M2 path and the flag | ```mermaid flowchart LR classDef done fill:#e3f5e1,stroke:#2e7d32 classDef open fill:#dff0ff,stroke:#1f6feb classDef be fill:#fde2e2,stroke:#c0392b classDef me fill:#fff4cc,stroke:#b58900,stroke-width:3px S["PR 19253 M3 stack"]:::done --> R["PR 19462 / PR 19487 design rounds"]:::done R --> U["UX pass PR 19540 PR 19538 PR 19536 PR 19537"]:::done R --> PNC["PR 19531 payment_not_completed"]:::done U --> F["Follow-ups PR 19611 PR 19612 PR 19613"]:::done BE1["cloud 11148 / 11223 quote fields"]:::done --> ME["FE-3019 server-reported fields"] BE2["cloud 11199 op receipt"]:::done --> ME F --> ME BE3["cloud 11188 top-up quote"]:::done --> TU["FE-3072 top-up on the full page"]:::open ME --> TU BE4["cloud 11252 itemized proration"]:::be -.-> PR["Proration rows"]:::open TU --> RO["M3-9 rollout"] ME --> RO RO --> CL["M3-10 delete M2 path + flag"] class ME me ```
…omfy-Org#19673) ## Summary A `/v1/top-up` link now opens a credit top-up on the full-page checkout: the summary leads with the credits the server quotes for the link's amount, Pay charges the method on file through the billing SDK's top-up command, and the endings report what the operation added and cost. Builds on Comfy-Org#19672 (merged). ## Changes - **Why**: FE-3072 (Alex's M3 review, 2026-09-28): the full-page checkout handles top-ups too. Figma 265-4362 (summary: credits first, expiry from the server, no promo), 77-3783 (Success and Already completed, op facts only), 394-4991 (receipt). cloud Comfy-Org#11188 (BE-17842) added the read-only top-up quote this needs, and cloud Comfy-Org#11199 the op receipt the endings read. Both are on cloud main. - **Root cause** (why a top-up link failed before): the entry contract had no top-up intent, so `/v1/top-up` was an unreadable link, and billing-web had no quote or route for it. - **How**: - `@comfyorg/billing-contract`: a `top-up` intent with `amount_cents`, the amount the product asks for in whole cents. The builder and the parser refuse anything but a positive whole number of cents with `INVALID_AMOUNT`. The amount is the customer's quantity, not a price. - `@comfyorg/account-core`: `topup.quoteTopup({ amountCents })` reads `POST /billing/topup/quote` (no idempotency key; nothing is charged). A 404 is `NOT_AVAILABLE`, a refused amount `INVALID_AMOUNT`, and the credits and amount are read as safe integers. - billing-web: `TopupRouteView` renders `FullPageTopupView` on the `billing_web_checkout_ui` full-page flag. `useFullPageTopup` drives the same `CheckoutPage` reducer as the subscription checkout: it reconciles first, reads `can_top_up`, quotes the amount, and pays through `useTopUp` (the SDK top-up command on the `billing_sdk_topup_enabled` rail), on the method on file. `topupVerdictOf` maps the command's result onto the existing Pay verdicts. `buildTopupLedger` leads with the quoted credits and dates them "Expire {date}" from the quote's `expires_at`, with no promo entry. Success reads "{N} credits added" with Added and Amount paid; credits still landing read Payment received; a revisit is Already completed. - `useCheckoutExit` and `reconciledEvent` move out of `useFullPageCheckout` so both checkouts share them. - Design review answers (Alex, 2026-09-30): - A one-time code reads "This payment only" on a change to a monthly plan. A new monthly subscription keeps "First month", and a yearly plan keeps "First year" (DES-1211) for a new subscription and a change alike. `discountTerm` picks the copy from the quote's `transition_type` and the new plan's duration; no money logic changes. - Top-up Success and Already completed put the credits icon (`icon-[lucide--coins]`, as on the plan card and summary) on the Added value (77-4102, 410-5225). - Top-up Pay reads "Pay", and the terms line reads "…charge your payment method once for this purchase." with Terms and Privacy Policy linked through the shared `CheckoutTermsNote` (180-6679). - A top-up link with no amount or an unreadable amount ends on "This link isn't valid" with `CHECKOUT_LINK_INVALID`, Add credits to the workspace's Plan & Credits settings, and Contact support (769-15773). It is a new `amount_invalid` reason mapped to a `link_invalid` ending. `App.vue` lets the top-up route explain an `INVALID_AMOUNT` link instead of the generic entry error. Subscription links keep "This plan isn't available". - **Breaking**: none. `TopupCommand` gains `quoteTopup`, so its fakes gain one too. **Rule 2.** The credits, the expiry, the amount charged and the credits added are the server's numbers. The page does not convert the amount into credits, and it states no expiry policy of its own. ## Review Focus - A revisit of a top-up this tab already saw succeed ends on Already completed. A top-up link is always for sale, so without this the page would offer a second form. - Top-up Success leaves out the Previous balance and New balance rows from 77-3783. They would need two balance reads around the charge, and DES-1212 already keeps balance rows off Already completed because a balance can be stale. Say if Success should show them. - "This payment only" is limited to monthly plan changes, the case Alex's answer named. A one-time code on a yearly plan still reads "First year", on a switch to yearly too. - A top-up link that is unreadable for any reason other than its amount (an unknown product, say) still ends on the generic entry error page, as before. - Nothing in the host app builds a top-up link yet. This PR adds the contract, the page and the quote. - On the embedded variant of the flag the route shows the entry error. There is no embedded top-up on billing-web. ## Screenshots (if applicable) Fixture build (billing-web e2e mocks), dark, 1512×982. | Case | AS IS | TO BE | | --- | --- | --- | | `/v1/top-up?amount_cents=2500` | <img width="600" alt="asis-topup-summary" src="https://github.com/user-attachments/assets/e54024c4-1c18-493a-9503-2150244a90a5" /> | <img width="600" alt="tobe-topup-summary" src="https://github.com/user-attachments/assets/3f964432-279e-4850-805b-89a36d2a1889" /> | | Pay goes through | n/a | <img width="600" alt="tobe-topup-success" src="https://github.com/user-attachments/assets/af7607ee-9134-44be-bd03-388239133b70" /> | | Credits still landing | n/a | <img width="600" alt="tobe-topup-received" src="https://github.com/user-attachments/assets/88b5bf5b-3705-4d72-81da-b2066a46c1b4" /> | | Reload once they land | n/a | <img width="600" alt="tobe-topup-already" src="https://github.com/user-attachments/assets/5d91e64d-a2da-4ede-956e-41132bf5d9c0" /> | Design review answers, fixture build (billing-web e2e mocks), 1280×860. AS IS is the previous head `a893946ddc`. | Case | AS IS | TO BE | | --- | --- | --- | | Top-up Success, credits icon on Added (77-4102) | <img width="600" alt="asis-topup-success" src="https://github.com/user-attachments/assets/124b0226-3cbc-4ae2-a34e-28120cd8bc83" /> | <img width="600" alt="tobe-topup-success" src="https://github.com/user-attachments/assets/dc68d101-41a1-4251-a77f-6c949411e261" /> | | Top-up Pay button and terms (180-6679) | <img width="600" alt="asis-topup-pay" src="https://github.com/user-attachments/assets/bf977000-5be6-457c-8a90-187d401e1c14" /> | <img width="600" alt="tobe-topup-pay" src="https://github.com/user-attachments/assets/ec51cc45-39cd-4a27-9165-0e7e2e2af8c4" /> | | `/v1/top-up` with no amount (769-15773) | <img width="600" alt="asis-topup-invalid" src="https://github.com/user-attachments/assets/e9f8b70d-bd09-458a-9411-64f1ddc7da10" /> | <img width="600" alt="tobe-topup-invalid" src="https://github.com/user-attachments/assets/9bd1399c-11e7-48d4-8e5e-4d600de0ea3c" /> | | One-time code on a plan change | <img width="600" alt="asis-change-once" src="https://github.com/user-attachments/assets/a2d0b587-f42e-4f37-a584-f59044883496" /> | <img width="600" alt="tobe-change-once" src="https://github.com/user-attachments/assets/1153d17c-34a8-4c1c-8369-33f3cb616295" /> | ## Where this PR sits in Milestone 3 | State | PR / ticket | Scope | |---|---|---| | Merged | Comfy-Org#19253 | M3 stack: FE-3018..3022 full page behind `billing_web_checkout_ui` | | Merged | Comfy-Org#19462 / Comfy-Org#19487 | Design review rounds 3-4 | | Merged | Comfy-Org#19540 Comfy-Org#19538 Comfy-Org#19536 Comfy-Org#19537 | UX pass: money state, lock/redirect, promo, summary/copy | | Merged | Comfy-Org#19531 | Accept `payment_not_completed` | | Merged | Comfy-Org#19611 Comfy-Org#19612 Comfy-Org#19613 | Follow-ups: planless link, visual pass, promo restore + server order | | Merged (BE) | cloud Comfy-Org#11148 Comfy-Org#11223 Comfy-Org#11188 Comfy-Org#11199 | Quote subtotal / list price / discount term / balance, top-up quote, op receipt | | Open (BE) | cloud Comfy-Org#11252 | `renewal_at` without the flag, itemized proration | | Merged | Comfy-Org#19672 | FE-3019 server-reported subtotal, list price, discount term, balance and receipts | | Open | **this PR** | FE-3072 credit top-up on the full page | | Next | M3-9 / M3-10 | Rollout via the flag, then delete the M2 path and the flag | ```mermaid flowchart LR classDef done fill:#e3f5e1,stroke:#2e7d32 classDef open fill:#dff0ff,stroke:#1f6feb classDef be fill:#fde2e2,stroke:#c0392b classDef me fill:#fff4cc,stroke:#b58900,stroke-width:3px S["PR 19253 M3 stack"]:::done --> R["PR 19462 / PR 19487 design rounds"]:::done R --> U["UX pass PR 19540 PR 19538 PR 19536 PR 19537"]:::done R --> PNC["PR 19531 payment_not_completed"]:::done U --> F["Follow-ups PR 19611 PR 19612 PR 19613"]:::done BE1["cloud 11148 / 11223 quote fields"]:::done --> SR["PR 19672 server-reported fields"]:::done BE2["cloud 11199 op receipt"]:::done --> SR F --> SR BE3["cloud 11188 top-up quote"]:::done --> ME["FE-3072 top-up on the full page"] SR --> ME BE4["cloud 11252 itemized proration"]:::be -.-> PR["Proration rows"]:::open ME --> RO["M3-9 rollout"] SR --> RO RO --> CL["M3-10 delete M2 path + flag"] class ME me ```
Summary
A checkout link with no
plannow sends the customer to pick a plan instead of to thereturn_tohome.Changes
planlink is "bounce back to the host's pricing table". Alex's answer (b) for Platform, which has no pricing table: "go to return_to. If that's missing or bad, go to the platform's billing page." Item 12 of the 2026-09-29 UX review.sendToHostas apricinglink, which resolvesreturn_toto its registered home (router.tshostReturnHref). It never looked at the pricing table.router.tsplanPickerHrefpicks the destination. Any product butplatformgetspricingTableUrl(the URL View plans already uses), on the Team tab when the link carriesteam_credit_stop_id. Aplatformlink gets its ownreturn_towhen billing may follow it, else Platform's billing page.withCheckoutReturnrewrites a missing or unregisteredreturn_totocomfyui_creditsbefore parsing.billing-contractgains aplatform_billingreturn target:https://platform.comfy.org/profile/billingandhttps://stagingplatform.comfy.org/profile/billing. That route ispages/profile/billing.vuein Comfy-Org/platform. The registry had no Platform billing URL, only the origin root (platform_account). Likeplatform_account, it has notest-family destination, so there a Platform link that needs the fallback is the existing "doesn't name a place we can send you back to" entry error.billing_web_checkout_uiread, so it applies to M2 and M3 alike, as the rule intends. The flag-off parity tests from FE-3018 fix(billing-web): apply the third design-review round #19462 are unchanged except the expected URL. Signed-out, pending, minting, failed-sign-in and signed-inembedded/unreachable visitors still leave at once, with no sign-in page, no workspace bind and no flag fetch. An already-signed-in tab onfull_pagestill gets Plan not available. The superseded-navigation guard is untouched.Review Focus
platform(comfyui,workshop,models). The pricing table only exists in cloud, and cloud is already the checkout's fallback host.platform_billingis also a registeredreturn_tothat a product may now send. It sits in the closed registry like the other targets.Screenshots (if applicable)
Fixture build (
VITE_BILLING_ENV=test, mockedtestcloud.comfy.org). This is a URL-level change, so the evidence is where the tab lands, from the e2e run before and after the fix:/v1/checkout?…)product=comfyui&return_to=comfyui_workspace&workspace=ws_team_e2e, signed outtestcloud.comfy.org/?workspace=ws_team_e2etestcloud.comfy.org/?pricing=1&workspace=ws_team_e2etestcloud.comfy.org/?workspace=ws_e2etestcloud.comfy.org/?pricing=1&workspace=ws_e2e…&team_credit_stop_id=stop_700testcloud.comfy.org/?workspace=ws_team_e2etestcloud.comfy.org/?pricing=team&workspace=ws_team_e2eproduct=platform&return_to=comfyui_workspacetestcloud.comfy.org/?workspace=ws_e2ereturn_to)product=platform&return_to=nowheretestcloud.comfy.org/?settings=plan-creditstest)The Platform billing page itself has no
test-family destination, so unit tests cover it withVITE_BILLING_ENVstubbed to staging and production (router.planless.test.ts): unregisteredreturn_to→https://stagingplatform.comfy.org/profile/billing?workspace=ws-1, missingreturn_to→https://platform.comfy.org/profile/billing,return_to=platform_account→https://stagingplatform.comfy.org/?workspace=ws-1.The first commit holds only the tests. Against the old router they fail with the AS IS URLs above (15 unit, 8 e2e).
Where this PR sits in Milestone 3
payment_not_completed(must ship before cloud#11119)