Repository navigation
[backport cloud/1.55] FE-3018 / FE-3019 / FE-3020 / FE-3021 / FE-3022 feat(billing-web): Milestone 3 full-page checkout behind billing_web_checkout_ui - #19460
Conversation
…lestone 3 full-page checkout behind billing_web_checkout_ui (#19253) > **Now carries the whole Milestone 3 full-page checkout.** The approved stacked PRs above were squash-merged top-down into this branch; each was reviewed and approved at its own head: #19263 (saved methods, rail failures), #19264 (inline outcomes, keep-subscription consent, re-quote failure), #19268 (mount reconciliation), #19271 (bfcache, cross-tab), #19279 (ending screens), #19280 (refusal, plan not available, couldn't load), #19285 (3DS / redirect two-phase submit), #19266 + #19267 (summary ledger), #19276 + #19277 + #19278 (promo codes). Everything stays behind `billing_web_checkout_ui = full_page`; flag off is the Milestone 2 checkout unchanged. Design review: Alex Tov confirmed the PRs match the guidebooks (#proj-billing, 2026-09-28). ## Why FE-3018 (Milestone 3, checkout guidebook 1: flow and entry). With `billing_web_checkout_ui = full_page`, `/v1/checkout` rendered an empty "Checkout" stub. This PR turns it into the two-tone full-page capture from Figma 187-8080, with the loading rule from 479-4848 (DES-1014) and the element-failure column from 360-4874. ## Root cause n/a, feature. ## How - `useFullPageCheckout` reads capabilities, the quote and the Stripe key in parallel on arrival and dispatches one event into the `CheckoutPage` reducer from the PR below: a denied `can_subscribe_self_serve` goes to `refused`, a failed read goes to `unavailable`, a quote goes to `capture`. Nothing renders capture before all three are in; the key is awaited because `StripePaymentForm` reads it only on mount. - Skeleton: the header, the "Total due today" label, both payment group labels, the Pay button and the terms line render for real; eyebrow, headline and total are skeleton bars. No spinner. - Pay enables only when the quote has arrived and the Stripe payment element reports `payment_element_ready` (the address element's ready does not count). A started operation keeps Pay locked so a second click cannot charge twice; rendering the post-Pay outcome is PR 2 / PR 3. - Eyebrow is `Subscribe to {tier} Plan · {workspace.name}`, with the name read from the minted session credential, not the quote. - The back arrow goes to the entry's allowlisted `return_to` through `buildReturnUrl`, the same helper the embedded view uses. When this family has no destination for the target, it falls back to the workspace's Plan & Credits settings on the cloud origin (`checkout/cloudLinks.ts`, `/?settings=plan-credits&workspace=<id>`, the same deep link the contract's `comfyui_credits` target names), so the arrow always renders and always has somewhere to go. - Design review (Alex 2026-09-28): D4. Back arrow destination is `return_to` with the Plan & Credits fallback; the `canGoBack` prop is gone since there is always a destination. - A `payment_element_failed` replaces the whole payment column with the 360-4874 card and a Try again that remounts `StripePaymentForm` and re-disables Pay until the new element is ready. - A plan change (`transition_type` other than `new_subscription`) renders Pay without a card form and subscribes without a confirmation token, as the embedded view does. - Subscribe goes through `useCheckout().subscribe` with the same request fields as the embedded view (quote id and version, proration, credit stop, `return_url` to `/v1/result`). - Reuse: `StripePaymentForm`, `usePreviewSubscribe`, `useCheckout`, `formatQuoteMoney`, and `CheckoutTermsNote` (now exported from `@comfyorg/account-ui/billing/checkout`, one line). - The refusal is a minimal placeholder with i18n copy; FE-3021 owns the real ending screen. - Rebased onto main: the `CheckoutView.vue` refactor is dropped because #19101 owns the M2 `CheckoutView`, the seven `checkout.*` locale keys the full page reads are restored, and `subscribeRequest.ts` serves the full page only. ## Tradeoffs - The subscribe-request builder and `resultUrl` are a copy of the embedded view's, because that view must stay untouched while the flag is off. The copy goes when the embedded variant is retired. - The left column is eyebrow, headline and total only; the ledger grammar, credits line and promo chip are FE-3019 / FE-3020. - The refusal copy is one generic line; the reason stays in the state for FE-3021. - `h-84` placeholder boxes stand in for the Stripe elements until the quote arrives, because `StripePaymentForm` never mounts its elements when the amount is not yet known. - Known gaps, all parity with the embedded view and all for PR 2 (listed so nobody serves `full_page` before then): after Pay the page shows no outcome and keeps Pay locked; a quote needing reactivation confirmation gets the server's coded refusal on Pay instead of the confirm checkbox; a zero-amount quote, an `allowed: false` quote, or one without a payment method configuration leaves Pay disabled with no explanation. - The page is split into `CheckoutSummaryColumn` and `CheckoutPaymentColumn` so the view template stays under the fallow complexity gate. ## Blast Radius Only `billing_web_checkout_ui = full_page`, which Cloud does not serve yet (cloud PR 10904, merged); targeted per account in PostHog. Flag off is byte-identical: `CheckoutView.vue`, `CheckoutPayment.vue`, `EmbeddedCheckout.vue` are untouched and the embedded e2e still passes. The e2e fake Stripe now fires element `ready`, which the embedded view ignores. ## Verification - `pnpm --filter @comfyorg/billing-web typecheck`: clean. - `pnpm --filter @comfyorg/billing-web test:unit`: 25 files, 266 tests pass (13 new component cases in `FullPageCheckoutView.test.ts`; mutating the operation lock, the `canPay` guard in `pay()`, or the `allowed` check each turns one red). - `pnpm exec playwright test` in `apps/billing-web` (fresh production build, `CI=1`): 33 passed. New `e2e/full-page-checkout.spec.ts` asserts the eyebrow names plan and workspace, Pay is labelled "Pay and subscribe" and enabled once ready, and the failed-element column plus Try again. `checkout-ui.spec.ts` still asserts flag-off shows "Confirm your payment". - `pnpm --filter @comfyorg/billing-web lint` (eslint + stylelint), oxfmt and oxlint on changed files, `pnpm knip`: clean. - After the design review: `cloudLinks.test.ts` (the settings deep link with and without a workspace) and a two-row table in `FullPageCheckoutView.test.ts` (Back to `comfyui_workspace`, Back to Plan & Credits for `platform_account`, which the test family cannot resolve). Typecheck and 294 unit tests pass at this head. ## Design questions - 360-4874 drops the back arrow in the whole-column failure; the 368 frames keep it. This PR keeps it, since the summary column stays live and the customer still needs a way back. Intentional in Figma, or a frame slip? - The error card background in Figma is `#2d2e32` (`semantic/secondary/background-hover`), which has no repo token. This uses `bg-secondary-background-hover` (`#313235` in dark). Retoken, or accept? ## AS IS / TO BE Captured from the e2e harness (production build, mocked Cloud, fake Stripe) at 1512x982, `full_page` on. The fake Stripe mounts no real element, so the ready state shows the element area empty. | AS IS (base: empty stub) | TO BE: capture skeleton (479-4848) | |---|---| |  |  | | TO BE: capture ready, Pay enabled | TO BE: element failed, whole column (360-4874) | |---|---| |  |  | ## Where this sits in the plan One linear stack on `main`: each PR is based on the one above it in the table. The former FE-3019/FE-3020 sibling stack now sits on top of FE-3022. | Step | PR | Scope | |---|---|---| | FE-3067 | #19248 (merged) | flag and variant switch | | FE-3018 PR 0 | #19252 | page state union and pure transition | | **FE-3018 PR 1** | **this PR** | **shell, eyebrow, capture skeleton** | | FE-3018 PR 2a | #19263 | saved-method tabs, rail failure taxonomy | | FE-3018 PR 2b | #19264 | inline Pay outcomes, backstop, reactivation | | FE-3018 PR 3a | #19268 | mount reconciliation, placeholders | | FE-3018 PR 3b | #19271 | bfcache and cross-tab re-reconciliation | | FE-3021 PR 1 | #19279 | success, already completed, in progress, received, unconfirmed | | FE-3021 PR 2 | #19280 | refusal, plan not available, couldn't load | | FE-3022 | #19285 | two-phase submit area, 3DS re-open, redirect methods, verification failed | | FE-3019 PR 1 | #19266 | summary ledger model and builder | | FE-3019 PR 2 | #19267 | left-column ledger rendering | | FE-3020 1/3 | #19276 | discount rows, fold rule, Subtotal | | FE-3020 2/3 | #19277 | promo entry state, Pay binding, URL promo | | FE-3020 3/3 | #19278 | promo entry UI, chips, expired card | ```mermaid graph LR M["main (19248 merged)"] --> N19252["19252 page state"] --> N19253["19253 shell"] --> N19263["19263 rails"] --> N19264["19264 outcomes"] --> N19268["19268 mount reconciliation"] --> N19271["19271 bfcache and cross-tab"] --> N19279["19279 money endings"] --> N19280["19280 refusal screens"] --> N19285["19285 payment authentication"] --> N19266["19266 ledger model"] --> N19267["19267 ledger UI"] --> N19276["19276 discount rows"] --> N19277["19277 promo entry state"] --> N19278["19278 promo entry UI"] style N19253 stroke-width:3px ```
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fe3fb31dce8de7c6e03e1a824ab50392f3853abd
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2123 passed, 0 failed · 1 flaky📊 Browser Reports
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T20:07:36.155Z",
"gitSha": "2f42ee310af84677a19ca95c4222832404e1fbe0",
"branch": "backport-19253-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.5879999999652,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.709,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.97400000000005,
"heapDeltaBytes": 1844020,
"heapUsedBytes": 69487980,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.354000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2016.4160000000493,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.278,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.43899999999996,
"heapDeltaBytes": 3556296,
"heapUsedBytes": 71188832,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.326999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.9170000000163,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.308,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 845.427,
"heapDeltaBytes": 237604,
"heapUsedBytes": 67856040,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 166.40500000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1767.5420000000486,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.154999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 851.72,
"heapDeltaBytes": 8219236,
"heapUsedBytes": 75756724,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 167.132,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.404,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.359,
"layouts": 6,
"layoutDurationMs": 1.0839999999999999,
"taskDurationMs": 353.012,
"heapDeltaBytes": 3139880,
"heapUsedBytes": 70720016,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.134000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.8899999999694,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.823999999999998,
"layouts": 6,
"layoutDurationMs": 1.212,
"taskDurationMs": 357.29699999999997,
"heapDeltaBytes": 3122392,
"heapUsedBytes": 70831884,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.017,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 693.8480000000027,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.181999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.084,
"heapDeltaBytes": 18931620,
"heapUsedBytes": 86565416,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 172.161,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 704.8750000000155,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.275999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.82300000000004,
"heapDeltaBytes": 18961256,
"heapUsedBytes": 86550416,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 170.71,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1290.2420000000347,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 944.5509999999999,
"heapDeltaBytes": 13589900,
"heapUsedBytes": 103546612,
"domNodes": -297,
"jsHeapTotalBytes": 22433792,
"scriptDurationMs": 72.809,
"eventListeners": -195,
"totalBlockingTimeMs": 667,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1185.1190000000997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 817.977,
"heapDeltaBytes": 38614608,
"heapUsedBytes": 107227208,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 74.51599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 567,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 857.968000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.3189999999995,
"heapDeltaBytes": 14284176,
"heapUsedBytes": 90867976,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.278,
"eventListeners": 0,
"totalBlockingTimeMs": 238,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 839.1840000000457,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.7269999999999,
"heapDeltaBytes": 14656920,
"heapUsedBytes": 91339784,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.23399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10658.568000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9663.641,
"heapDeltaBytes": -1381900,
"heapUsedBytes": 80610696,
"domNodes": -14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8185.133000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1466,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10254.009999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9428.974999999999,
"heapDeltaBytes": 16738992,
"heapUsedBytes": 98601116,
"domNodes": -16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7769.232000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1065,
"frameDurationMs": 20,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10752.899000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9733.556,
"heapDeltaBytes": 10232484,
"heapUsedBytes": 92751380,
"domNodes": -16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8249.243,
"eventListeners": 0,
"totalBlockingTimeMs": 1356,
"frameDurationMs": 18.883333333333333,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11045.718999999963,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.1360000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10212.298,
"heapDeltaBytes": -7795292,
"heapUsedBytes": 68562968,
"domNodes": -269,
"jsHeapTotalBytes": 2088960,
"scriptDurationMs": 8448.42,
"eventListeners": -174,
"totalBlockingTimeMs": 1501,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2040.633000000014,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.24,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 677.791,
"heapDeltaBytes": -3134340,
"heapUsedBytes": 83556768,
"domNodes": -242,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 38.621,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.8379999999943,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.898000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.182,
"heapDeltaBytes": -5424336,
"heapUsedBytes": 81304836,
"domNodes": -246,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 38.486000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2441.0799999999995,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.748000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1715.258,
"heapDeltaBytes": 19163784,
"heapUsedBytes": 84004712,
"domNodes": 6,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 888.6650000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2418.162999999936,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.103000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1730.5190000000002,
"heapDeltaBytes": -3391856,
"heapUsedBytes": 84669700,
"domNodes": -245,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 896.703,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3657.390000000021,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.935,
"layouts": 60,
"layoutDurationMs": 13.981,
"taskDurationMs": 1809.425,
"heapDeltaBytes": 9728264,
"heapUsedBytes": 75000784,
"domNodes": -254,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 836.1390000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3670.616999999993,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.312000000000003,
"layouts": 60,
"layoutDurationMs": 13.049000000000001,
"taskDurationMs": 1735.0600000000002,
"heapDeltaBytes": 10564360,
"heapUsedBytes": 75723952,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 823.029,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3266.237999999987,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.832999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2110.509,
"heapDeltaBytes": 6680,
"heapUsedBytes": 91082624,
"domNodes": -252,
"jsHeapTotalBytes": -77824,
"scriptDurationMs": 1036.8780000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3164.929000000029,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.189,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2004.0700000000004,
"heapDeltaBytes": 33563224,
"heapUsedBytes": 99510284,
"domNodes": 4,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 1096.051,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.3249999999912,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.274000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.2690000000001,
"heapDeltaBytes": -7071212,
"heapUsedBytes": 80486332,
"domNodes": -253,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 38.88499999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.6700000000428,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.525999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.0190000000001,
"heapDeltaBytes": -4465244,
"heapUsedBytes": 84248936,
"domNodes": -246,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.202,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.5239999999731,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.712,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.827,
"heapDeltaBytes": 14042912,
"heapUsedBytes": 84039040,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 143.947,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.3690000000188,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.214999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.138,
"heapDeltaBytes": 14057528,
"heapUsedBytes": 84024676,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 147.601,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2020.7880000000387,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.038,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.407,
"heapDeltaBytes": -3356640,
"heapUsedBytes": 66566828,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.680000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.9439999999622,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.777000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.928,
"heapDeltaBytes": 440016,
"heapUsedBytes": 63254036,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.444999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.1640000000107,
"styleRecalcs": 47,
"styleRecalcDurationMs": 17.352,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 761.989,
"heapDeltaBytes": 8015288,
"heapUsedBytes": 76901416,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 107.003,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.7409999999709,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.264000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 745.476,
"heapDeltaBytes": 7824172,
"heapUsedBytes": 77292584,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 109.035,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.7649999999549,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.766999999999996,
"layouts": 5,
"layoutDurationMs": 14.051999999999998,
"taskDurationMs": 996.6460000000002,
"heapDeltaBytes": -6556892,
"heapUsedBytes": 86256664,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 33.861,
"eventListeners": 2383,
"totalBlockingTimeMs": 151,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8831.413999999995,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.748000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6190.4839999999995,
"heapDeltaBytes": -5998928,
"heapUsedBytes": 80570640,
"domNodes": -242,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2924.4900000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8420.80800000008,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.085,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5956.0019999999995,
"heapDeltaBytes": -20784804,
"heapUsedBytes": 66099112,
"domNodes": -256,
"jsHeapTotalBytes": 1601536,
"scriptDurationMs": 2821.531,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17856.549000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17255.252999999997,
"heapDeltaBytes": -39223016,
"heapUsedBytes": 168927416,
"domNodes": -8061,
"jsHeapTotalBytes": -11780096,
"scriptDurationMs": 289.34299999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17099.33000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16651.606,
"heapDeltaBytes": -43444476,
"heapUsedBytes": 178129416,
"domNodes": -8061,
"jsHeapTotalBytes": -10555392,
"scriptDurationMs": 286.85099999999994,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21502.663999999982,
"styleRecalcs": 159,
"styleRecalcDurationMs": 18.794000000000032,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21282.375,
"heapDeltaBytes": -49284236,
"heapUsedBytes": 191618568,
"domNodes": -8061,
"jsHeapTotalBytes": -20455424,
"scriptDurationMs": 893.681,
"eventListeners": -14928,
"totalBlockingTimeMs": 102,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21292.546000000017,
"styleRecalcs": 158,
"styleRecalcDurationMs": 19.91599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21078.977000000003,
"heapDeltaBytes": -44688356,
"heapUsedBytes": 180807584,
"domNodes": -8061,
"jsHeapTotalBytes": -15998976,
"scriptDurationMs": 918.4449999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 41,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6388.8580000000275,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.082,
"layouts": 20,
"layoutDurationMs": 25.112999999999996,
"taskDurationMs": 6347.099,
"heapDeltaBytes": -42745696,
"heapUsedBytes": 183053168,
"domNodes": -8061,
"jsHeapTotalBytes": 14864384,
"scriptDurationMs": 116.94600000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 430,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4835.71100000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.06399999999996,
"layouts": 20,
"layoutDurationMs": 23.779999999999994,
"taskDurationMs": 4735.621999999999,
"heapDeltaBytes": -39004920,
"heapUsedBytes": 186844068,
"domNodes": -8061,
"jsHeapTotalBytes": 20471808,
"scriptDurationMs": 93.53399999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 182,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8732.97500000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8493.451000000001,
"heapDeltaBytes": -8626932,
"heapUsedBytes": 177548924,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 134.06400000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8565.662000000088,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8397.273000000003,
"heapDeltaBytes": -21415400,
"heapUsedBytes": 172501376,
"domNodes": 0,
"jsHeapTotalBytes": -23855104,
"scriptDurationMs": 127.26400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 450.7370000000037,
"styleRecalcs": 15,
"styleRecalcDurationMs": 26.037,
"layouts": 4,
"layoutDurationMs": 2.241,
"taskDurationMs": 129.299,
"heapDeltaBytes": 5056820,
"heapUsedBytes": 70191624,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.732,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 110.09300000000621,
"styleRecalcs": 7,
"styleRecalcDurationMs": 17.958,
"layouts": 4,
"layoutDurationMs": 1.997,
"taskDurationMs": 86.22399999999999,
"heapDeltaBytes": 3066168,
"heapUsedBytes": 68670996,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.507999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
…ompleted decline reason (#19670) ## Summary Backport of #19531 to `cloud/1.55`. Accepts the op-status `decline_reason` value `payment_not_completed` so checkout settles once Comfy-Org/cloud#11119 deploys. ## Why Comfy-Org/cloud#11119 is merged on cloud main and ships with the next backend release, before frontend 1.56 reaches cloud prod. On 1.55, `operationLifecycle.ts` parses `GET /billing/ops/:id` with `zBillingOpStatusResponse.safeParse`, whose `decline_reason` is a closed 8-value enum. A `payment_not_completed` value fails the whole parse, so Pay spins and checkout never settles. Prod runs 1.54.15 today, which does not zod-parse op status, so there the new value only degrades copy. 1.55 is what cloud staging and prod move to next. ## Changes Cherry-picked from #19531 (`-x`), one conflict resolved. - `packages/ingest-types`: adds `payment_not_completed` to the op-status `decline_reason` enum and its doc line in `types.gen.ts` and `zod.gen.ts`. No regeneration against cloud main, so no unrelated spec drift. - `account-core` `paymentCopy.ts`: `declineDetailKey` maps it to `authenticationFailedDetail`; adds `billing.reason.payment_not_completed`. - billing-web `payVerdict.ts`: joins the not-completed reasons. The M3 full-page checkout is already on 1.55 (#19460 backport), so this hunk applies as on main. - `billingOperationStore.ts`: `payment_not_completed` plus the raw `payment_method_customer_decline` / `payment_intent_payment_attempt_expired` codes read as the verification detail. - Tests: contract `DECLINE_REASONS` table with a parse row per reason, `paymentCopy`, `paymentProjection`, `payVerdict`, `CheckoutView`, `FullPageCheckoutView`, `subscriptionOperationView`, `billingOperationStore` rows, and the full-page e2e test. Not included: the e2e conflict pulled in a neighbouring main-only test (`314-10612` processing-error card) as hunk context. It is dropped; only the `payment_not_completed` e2e test is kept. ## Verification On the branch after `pnpm install`: - `pnpm typecheck` (root, `--max-old-space-size=8192`): clean. Pre-commit also ran `typecheck:app`, `typecheck:billing-web`, `typecheck:account-core`. - Unit: account-core 1246 passed, billing-web 774 passed, app `src/platform/workspace/billing` + `billingOperationStore` 353 passed. - `pnpm lint`: 0 errors. `pnpm knip`: clean. - Mutation check: removing `'payment_not_completed'` from `zBillingOpStatusResponse` fails `accepts a failed status declined as payment_not_completed`. Refs BE-17784, Comfy-Org/cloud#11119
Backport of #19253 to
cloud/1.55Automatically created by backport workflow.