Repository navigation
FE-3018 / FE-3019 / FE-3020 / FE-3021 / FE-3022 feat(billing-web): Milestone 3 full-page checkout behind billing_web_checkout_ui - #19253
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis pull request adds a full-page billing checkout flow. It supports saved and new payment methods, consent, promotion codes, order summaries, payment-operation reconciliation, and checkout outcome screens. It also adds request and navigation helpers, checkout routing changes, and automated tests. ChangesFull-page billing checkout
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~60 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant Customer
participant FullPageCheckoutView
participant useFullPageCheckout
participant BillingClient
participant operationChannel
Customer->>FullPageCheckoutView: Submit selected payment
FullPageCheckoutView->>useFullPageCheckout: Send payment choice
useFullPageCheckout->>BillingClient: Submit subscription request
BillingClient-->>useFullPageCheckout: Return command and operation result
useFullPageCheckout->>operationChannel: Publish operation notice
operationChannel-->>useFullPageCheckout: Notify sibling checkout to reread status
Suggested reviewers: Merge Risk: 🔵 Low · up to A checkout return after a redirect can show an outdated promotion code or omit a newly applied one. This is a bounded checkout-state issue, not an incorrect charge; the PR is mergeable with an owner follow-up. Security Architecture ReviewSecurity architecture risk: 🟡 Moderate · up to The new checkout preserves important payment and pricing controls, but its handling of overlapping billing operations warrants review because it could show an outcome for the wrong payment attempt. No unauthorized charge or cross-account access was established. Retained concerns
Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2160 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 878db51f1123d0604727803c71f2c6d47b0815df
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle: 10 MB gzip 🔴 +344 kBDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.73 kB) • 🔴 +38 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.43 MB) • 🔴 +27.3 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 124 kB) • 🔴 +9.54 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 643 kB (baseline 621 kB) • 🔴 +21.4 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 39.4 kB (baseline 27.8 kB) • 🔴 +11.6 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +691 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 125 kB (baseline 117 kB) • 🔴 +8.06 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 4.06 MB (baseline 3.6 MB) • 🔴 +461 kBStores, services, APIs, and repositories
Status: 15 added / 16 removed Utilities & Hooks — 582 kB (baseline 559 kB) • 🔴 +23.2 kBHelpers, composables, and utility bundles
Status: 31 added / 30 removed / 6 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -685 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.9 MB (baseline 16.4 MB) • 🔴 +1.54 MBBundles that do not match a named category
Status: 178 added / 174 removed / 122 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T07:35:14.793Z",
"gitSha": "ea2524e576b74ff95e4a82b9f8eb61e98adc4d24",
"branch": "jaewon/fe-3018-full-page-checkout-shell",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2032.6200000000085,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.30400000000003,
"heapDeltaBytes": -16119720,
"heapUsedBytes": 62703844,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.261999999999997,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2029.2799999999716,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.362999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.007,
"heapDeltaBytes": -23974780,
"heapUsedBytes": 55147460,
"domNodes": -228,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 12.585000000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1849.8069999999984,
"styleRecalcs": 74,
"styleRecalcDurationMs": 20.744,
"layouts": 12,
"layoutDurationMs": 5.486000000000001,
"taskDurationMs": 856.2230000000001,
"heapDeltaBytes": -18917184,
"heapUsedBytes": 59896652,
"domNodes": -228,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 157.581,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.817272727272734,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1863.5069999999132,
"styleRecalcs": 74,
"styleRecalcDurationMs": 21.171000000000003,
"layouts": 12,
"layoutDurationMs": 4.774,
"taskDurationMs": 883.3100000000001,
"heapDeltaBytes": -12364436,
"heapUsedBytes": 66221532,
"domNodes": -228,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 163.487,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.81621621621622,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.2820000000074,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.295,
"layouts": 6,
"layoutDurationMs": 1.2770000000000001,
"taskDurationMs": 321.15500000000003,
"heapDeltaBytes": 1478744,
"heapUsedBytes": 80252124,
"domNodes": 53,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 12.507000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.211999999985,
"styleRecalcs": 33,
"styleRecalcDurationMs": 11.549,
"layouts": 6,
"layoutDurationMs": 1.4829999999999999,
"taskDurationMs": 368.378,
"heapDeltaBytes": 1564252,
"heapUsedBytes": 80419944,
"domNodes": 53,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 14.822000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 700.6860000000188,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.31,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.28400000000005,
"heapDeltaBytes": -2795124,
"heapUsedBytes": 95253712,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 161.34,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926822,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 714.5739999999705,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.416999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.82399999999996,
"heapDeltaBytes": -1819112,
"heapUsedBytes": 96918440,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 162.73100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1190.1090000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 828.5140000000001,
"heapDeltaBytes": 6609412,
"heapUsedBytes": 82525880,
"domNodes": 0,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 68.487,
"eventListeners": 0,
"totalBlockingTimeMs": 521,
"frameDurationMs": 32.86944444444445,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1114.385000000084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 750.636,
"heapDeltaBytes": 6360708,
"heapUsedBytes": 82250708,
"domNodes": 0,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 60.045000000000016,
"eventListeners": 0,
"totalBlockingTimeMs": 494,
"frameDurationMs": 33.839393939393936,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 851.6480000000115,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.4219999999999,
"heapDeltaBytes": 15633812,
"heapUsedBytes": 90908132,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 144.123,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.0940000000564,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.13300000000044,
"heapDeltaBytes": 15456252,
"heapUsedBytes": 90125712,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 160.54299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 24.53611111111109,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10511.978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9553.034,
"heapDeltaBytes": 4466564,
"heapUsedBytes": 85616260,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 7805.256,
"eventListeners": 0,
"totalBlockingTimeMs": 835,
"frameDurationMs": 32.30646153846154,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8737.190000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7951.5560000000005,
"heapDeltaBytes": -8796628,
"heapUsedBytes": 66592704,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 6548.951,
"eventListeners": 0,
"totalBlockingTimeMs": 438,
"frameDurationMs": 31.527436823104694,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8895.669999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8021.615000000001,
"heapDeltaBytes": 9278592,
"heapUsedBytes": 90513640,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 6417.266,
"eventListeners": 0,
"totalBlockingTimeMs": 165,
"frameDurationMs": 28.895129870129868,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9284.078000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8330.201000000001,
"heapDeltaBytes": 12032576,
"heapUsedBytes": 92981568,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 6630.905000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 329,
"frameDurationMs": 29.23123028391167,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2052.2359999999935,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.3770000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.6880000000001,
"heapDeltaBytes": -36216348,
"heapUsedBytes": 82846280,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 38.24399999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2038.9829999999165,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3710000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.2629999999999,
"heapDeltaBytes": -36642584,
"heapUsedBytes": 83175476,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 36.91799999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2278.2439999999724,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.406000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1623.3869999999997,
"heapDeltaBytes": -33531292,
"heapUsedBytes": 86432984,
"domNodes": -230,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 797.015,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592592592593,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2428.827999999953,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1665.0229999999997,
"heapDeltaBytes": 19229280,
"heapUsedBytes": 82160780,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 841.286,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666206896551728,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3774.5740000000296,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.060999999999996,
"layouts": 60,
"layoutDurationMs": 16.804,
"taskDurationMs": 1757.68,
"heapDeltaBytes": 12263060,
"heapUsedBytes": 77663828,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 809.0730000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666079295154184,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3715.35300000005,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.566,
"layouts": 60,
"layoutDurationMs": 16.352,
"taskDurationMs": 1750.7839999999999,
"heapDeltaBytes": 9927564,
"heapUsedBytes": 73630432,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 814.307,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666216216216213,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3142.8130000000465,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.040999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1991.766,
"heapDeltaBytes": 28055240,
"heapUsedBytes": 93134748,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1029.976,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84462365591398,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3141.020000000026,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.044000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1961.2930000000001,
"heapDeltaBytes": 25177560,
"heapUsedBytes": 90218880,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 994.048,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903746,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2058.576999999957,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.7760000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.202,
"heapDeltaBytes": -36792868,
"heapUsedBytes": 84046148,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 35.67000000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2008.9460000000372,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.1999999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.03800000000007,
"heapDeltaBytes": 21297812,
"heapUsedBytes": 84429924,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.63200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.7749999999619,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.286,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.527,
"heapDeltaBytes": 13127584,
"heapUsedBytes": 93990560,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 144.672,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 641.3700000000517,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.790000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.408,
"heapDeltaBytes": -18932032,
"heapUsedBytes": 61955012,
"domNodes": -244,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 140.719,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.105263157894736,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2034.8239999999578,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.8789999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.70399999999995,
"heapDeltaBytes": -6741568,
"heapUsedBytes": 74522916,
"domNodes": -244,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 8.711,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2025.8399999999028,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.006000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.27899999999994,
"heapDeltaBytes": -16398696,
"heapUsedBytes": 64829500,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.746,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1779.5529999999644,
"styleRecalcs": 58,
"styleRecalcDurationMs": 18.91,
"layouts": 16,
"layoutDurationMs": 6.241,
"taskDurationMs": 807.544,
"heapDeltaBytes": -14708812,
"heapUsedBytes": 65685628,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 114.11300000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1766.9149999999263,
"styleRecalcs": 76,
"styleRecalcDurationMs": 20.145000000000003,
"layouts": 16,
"layoutDurationMs": 6.814999999999999,
"taskDurationMs": 769.84,
"heapDeltaBytes": -21668876,
"heapUsedBytes": 59576132,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 117.283,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.825714285714284,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.0339999999442,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.218000000000007,
"layouts": 5,
"layoutDurationMs": 12.351,
"taskDurationMs": 925.2059999999998,
"heapDeltaBytes": 23334420,
"heapUsedBytes": 94972480,
"domNodes": 13667,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.166999999999998,
"eventListeners": 2383,
"totalBlockingTimeMs": 124,
"frameDurationMs": 19.906944444444434,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 8421.39499999996,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.532,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5658.996999999999,
"heapDeltaBytes": -39225912,
"heapUsedBytes": 79889092,
"domNodes": -228,
"jsHeapTotalBytes": -167936,
"scriptDurationMs": 2698.868,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8643.93800000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5756.518,
"heapDeltaBytes": -36432916,
"heapUsedBytes": 83100012,
"domNodes": -228,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 2717.226,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69806576402321,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18748.93899999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18553.100000000002,
"heapDeltaBytes": -23736252,
"heapUsedBytes": 185190588,
"domNodes": -3045,
"jsHeapTotalBytes": 7446528,
"scriptDurationMs": 348.334,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.57374749498998,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 17940.40099999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17845.369000000002,
"heapDeltaBytes": -29222500,
"heapUsedBytes": 182266244,
"domNodes": -8049,
"jsHeapTotalBytes": -11853824,
"scriptDurationMs": 300.115,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.689243027888445,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 24018.04400000003,
"styleRecalcs": 178,
"styleRecalcDurationMs": 25.06799999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23900.544,
"heapDeltaBytes": -27094456,
"heapUsedBytes": 180783240,
"domNodes": -3045,
"jsHeapTotalBytes": 7204864,
"scriptDurationMs": 1009.2730000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 93,
"frameDurationMs": 48.19076305220883,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 22522.67500000005,
"styleRecalcs": 164,
"styleRecalcDurationMs": 25.09,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22404.208000000002,
"heapDeltaBytes": -27532092,
"heapUsedBytes": 176474664,
"domNodes": -3046,
"jsHeapTotalBytes": 4730880,
"scriptDurationMs": 1022.819,
"eventListeners": -14915,
"totalBlockingTimeMs": 193,
"frameDurationMs": 44.76302186878728,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6934.257000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.179,
"layouts": 20,
"layoutDurationMs": 27.22000000000001,
"taskDurationMs": 6891.573,
"heapDeltaBytes": -13200844,
"heapUsedBytes": 216697948,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 143.56400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 613,
"frameDurationMs": 41.41497005988025,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6448.5930000000735,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.96899999999998,
"layouts": 20,
"layoutDurationMs": 26.72899999999999,
"taskDurationMs": 6409.727,
"heapDeltaBytes": -19369272,
"heapUsedBytes": 210024320,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 129.81400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 438,
"frameDurationMs": 38.85361445783132,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9862.420000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9743.100000000002,
"heapDeltaBytes": -33527056,
"heapUsedBytes": 165401448,
"domNodes": -3045,
"jsHeapTotalBytes": 12017664,
"scriptDurationMs": 174.3,
"eventListeners": -14919,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.091729323308265,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8981.628,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8910.749000000002,
"heapDeltaBytes": -40865420,
"heapUsedBytes": 162245484,
"domNodes": -3045,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 156.02499999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.88401639344263,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 177.05899999998564,
"styleRecalcs": 12,
"styleRecalcDurationMs": 20.650000000000002,
"layouts": 4,
"layoutDurationMs": 3.6159999999999997,
"taskDurationMs": 144.783,
"heapDeltaBytes": -16611244,
"heapUsedBytes": 79899772,
"domNodes": 122,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 12.53,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.340000000000053,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 163.16500000004908,
"styleRecalcs": 10,
"styleRecalcDurationMs": 16.099,
"layouts": 3,
"layoutDurationMs": 1.8530000000000002,
"taskDurationMs": 150.786,
"heapDeltaBytes": -16439388,
"heapUsedBytes": 80340796,
"domNodes": 114,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.2010000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.5222222222222,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 959.8580000000538,
"styleRecalcs": 78,
"styleRecalcDurationMs": 120.375,
"layouts": 76,
"layoutDurationMs": 26.731,
"taskDurationMs": 933.7149999999999,
"heapDeltaBytes": 18885804,
"heapUsedBytes": 90481496,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 367.328,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1042.6310000000285,
"styleRecalcs": 78,
"styleRecalcDurationMs": 128.374,
"layouts": 76,
"layoutDurationMs": 27.79,
"taskDurationMs": 1007.5639999999999,
"heapDeltaBytes": 19621172,
"heapUsedBytes": 90795572,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 401.87,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66507936507936,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1540.0099999999384,
"styleRecalcs": 78,
"styleRecalcDurationMs": 288.21799999999996,
"layouts": 76,
"layoutDurationMs": 29.590000000000003,
"taskDurationMs": 1532.249,
"heapDeltaBytes": -8309896,
"heapUsedBytes": 114868440,
"domNodes": -7945,
"jsHeapTotalBytes": -5021696,
"scriptDurationMs": 451.104,
"eventListeners": -1226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.697560975609743,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1576.037000000042,
"styleRecalcs": 78,
"styleRecalcDurationMs": 298.676,
"layouts": 76,
"layoutDurationMs": 31.048,
"taskDurationMs": 1555.093,
"heapDeltaBytes": 8371844,
"heapUsedBytes": 131559792,
"domNodes": 76,
"jsHeapTotalBytes": -3448832,
"scriptDurationMs": 483.765,
"eventListeners": -1245,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.873493975903614,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
2c407db to
25e36a6
Compare
62b703c to
3bce85a
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
The exact-head shell is sound. It stays behind the full-page flag, drives capture through the approved reducer, keeps Pay disabled until the quote is allowed and the payment element is ready, locks duplicate submission, preserves the allowlisted return path, and shares the subscribe request builder with the embedded flow without changing its contract. The focused unit and browser coverage exercise loading, readiness, element failure/remount, and request identity.
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at 02ef490a23142c215c294caeb7bbe49189487a9c.
- The rebuilt full-page checkout parent keeps server-priced totals, operation state, and payment readiness authoritative.
- Subscribe and return routing remain bound to the billed workspace selected in this tab.
- Exact-head CI is settled green and all review threads are resolved.
Full context for agent readers
This approval completes the source review recorded while CI was pending. The head and base are unchanged, the checkout remains behind its capability and feature gates, and the current tab's workspace continues through quote, request, recovery, and return handling. Two tabs may intentionally use different workspaces.
|
@dante01yoon Successfully backported to #19459 |
|
@dante01yoon Successfully backported to #19460 |
…omfy-Org#19499) ## Summary Fixes the `full-page-promo.spec.ts` "a code that lapses before Pay" failure that has been red on main since Comfy-Org#19126. The full-page checkout now re-quotes when a subscribe comes back as `QUOTE_STALE`. ## Changes - **What**: Comfy-Org#19253 made `payVerdictOf` re-quote only when a raw `SUBSCRIPTION_QUOTE_STALE` `serverCode` came back. Comfy-Org#19126 then changed account-core to turn a 4xx with that code into `{ code: 'QUOTE_STALE' }` with no `serverCode`. The two PRs were written in parallel and merged about 40 minutes apart. Since then, `payVerdictOf` falls through to `failure`. The page shows "Your quote changed…" instead of re-pricing and showing the expired-promo card. `payVerdictOf` now maps `QUOTE_STALE` to `requote`. - The `payVerdict` and `FullPageCheckoutView` unit tests built the pre-Comfy-Org#19126 result shape by hand, so they missed this. They now use the shape account-core actually returns. ## Review Focus `SUBSCRIPTION_QUOTE_STALE` is gone from `STALE_QUOTE_SERVER_CODES`. Only `subscribe` emits it, and account-core now maps it for 4xx responses. A 5xx that echoes the code arrives as `REQUEST_FAILED`, which account-core treats as an upstream failure, not a stale quote. With this change, that 5xx no longer triggers a re-quote. Red/green: both updated unit tests fail without the `payVerdict.ts` change and pass with it. `pnpm test:e2e:local e2e/full-page-promo.spec.ts` passes 6/6.
…Org#19462) ## Summary Third design-review round on the M3 full-page checkout (Comfy-Org#19253), exactly the six items from Alex Tov's answers on 2026-09-29: five of his decisions plus one wrap bug we found. It was built on `jaewon/fe-3018-full-page-checkout-shell`. Comfy-Org#19253 merged while this was in progress, so the seven commits were rebased onto `main` and the PR targets `main` directly. ## Why On 2026-09-29 Alex settled the questions the second round left open. These were the undated yearly-switch copy, what a link with no `plan` shows, the single saved-method row, balanced ending headings, and the copy for a refusal because a change is already scheduled. Item 6 is ours. A long refusal code broke mid-word on phones. ## Changes - **What**: 1. **Undated yearly switch.** When the quote has no `renewal_at`, the notice now reads "Switching to yearly keeps your subscription, and it renews a year from today at {amount}." The client computes no date. A quote with `renewal_at` keeps the dated line. Root cause: the undated wording from round 2 was a placeholder, so this is a copy change only. 2. **Link with no `plan`.** When the tab is already signed in at the moment the router reads the link and the customer's flag says `full_page`, the link now stays and shows Plan not available with `CHECKOUT_LINK_INVALID` (433-6840). Every other visitor goes straight back to the host, exactly as on `main`. Root cause: the router bounced a planless link to the host before it knew the flag, so the full page never saw it. The page itself already rendered this state after round 2. See Review Focus for the rule and its trade-off. 3. **One saved payment method.** One method now renders as a static row with no chevron and no dropdown. It uses the picker trigger's own fill (`bg-base-background`), its 8px radius (`rounded-lg`) and its 40px height. Two or more methods keep the picker. Root cause: `SavedMethodSelect` always rendered the Reka select. 4. **Balanced ending headings.** Ending headings get `text-balance`, so on a 390px phone the heading reads "We couldn't confirm / your payment" (662-14660). Before, it broke as "…confirm your / payment". 5. **SUBSCRIPTION_CHANGE_IN_PROGRESS copy (643-14654).** The page reads the plan and date from the server: `effective_at` from `GET /billing/status` `scheduled_change`, and the plan from the server's catalog (`GET /billing/plans`), looked up by `plan_slug`. The copy is "Your plan is set to change to {plan} on {date}. Cancel that change in your billing settings to make a different one." The fallback is "Your plan already has a change scheduled. Cancel it in your billing settings to make a different one." It shows when `scheduled_change` is null, when the catalog does not list the slug, or when either read fails. The date is `effective_at`, formatted as-is in UTC, the same way the keep-subscription notice formats dates. The plan name is the catalog entry's tier and duration, rendered through the existing `hosted.plan.name` copy. `SubscriptionPanel` already names the current plan this way, and that code now shares one `planName` helper on `useHostedCopy`. Nothing maps slugs to names on the client. The refusal event carries the facts into the reducer (`refused.scheduled`), and `endingOf` chooses the copy. 6. **Refusal code breaks mid-word.** `SUBSCRIPTION_CHANGE_IN_PROGRESS` broke as "…IN_PRO" / "GRESS" at 390px. Root cause: `break-all` (`word-break: break-all`) on the code. The code now renders with a `<wbr>` after each underscore, plus `wrap-anywhere` and `min-w-0`. It breaks at an underscore first, and mid-word only when one piece alone cannot fit, for example a long operation id. The copied text is unchanged. The code card moved into `EndingCodeCard.vue` to keep `CheckoutEnding`'s template under the fallow cognitive-complexity limit. | Item | Commits | | --- | --- | | 1. Undated yearly switch copy | 7fab333 | | 2. Planless link behind the flag | 723eda1, reworked by 7019df0 (flag-off parity tests) and 8f116ae | | 3. Lone saved method as a static row | d9832e1 | | 4. `text-balance` on ending headings | 2457204 | | 5. Scheduled-change refusal copy | ad38ce8 | | 6. Code wraps at underscores | 0156cc6, b5c6aba (card extracted for the fallow gate) | ## Review Focus - **Item 2, the rule for a link with no `plan`.** The flag is per user and needs a minted session, so it can only be read for a tab that already has one. The router therefore decides from a synchronous read of the session (`billingWebLivePhase`) and never waits for sign-in: - Session already `authenticated` when the link is routed: read the flag (`awaitCheckoutUiVariant`, the memoized answer `CheckoutRouteView` uses, which fails closed to `embedded` after 4s). `full_page` admits the link and shows Plan not available. Anything else goes back to the host. - Anything else (signed out, a Firebase identity with no minted session, the sign-in mode still undecided, loading, error): straight back to the host, synchronously, before any session or flag is asked for. The link's workspace is not bound to the tab first, so a link naming a workspace the customer cannot manage goes back to the host and never reaches the mint refusal. With the flag off this is byte-for-byte `main`: no waiting, no sign-in detour, no mint. The trade-off is accepted. A planless link opened as a fresh page load, which is how the host opens it in a new tab, is never already signed in when it is routed, so it goes back to the host even for a customer on the flag. That is the same answer D21 gives an unreadable link. The full page shows Plan not available only when a tab that is already signed in routes the link, for example the sign-in page returning to it. An earlier version of this item waited for the identity to settle (`billingWebSettledPhase`) and sent a restored identity through the sign-in page. It broke flag-off parity and could bind the tab to the link's workspace, so it was removed. - **Item 5, BE gap.** `scheduled_change` has `plan_slug`, `effective_at` and `team_credit_stop`, but no display name. The plan is named by looking up the slug in the server's catalog. A slug the catalog does not list gets the fallback copy. That covers a legacy or retired plan, and a team plan whose stop the catalog does not expose. A `display_name` (or tier and duration) on `scheduled_change` would remove the extra `GET /billing/plans` read on this refusal and cover those slugs. The name format "Pro · Yearly" comes from the existing `hosted.plan.name` copy and needs Alex's confirmation against 643-14654. - **Item 3.** The static row is a plain `<p>`, so a screen reader reads the card as text and not as a combobox. ## Verification - `apps/billing-web` Vitest: 43 files, 814 tests pass. - `apps/billing-web` Playwright (`CI=1`, fresh production build): 90 pass. - `pnpm typecheck` (billing-web), `pnpm lint` (billing-web, eslint + stylelint), and root `pnpm knip` are clean. `fallow audit` passes against `origin/main` (this PR's base). account-ui is untouched. - Each behaviour's test was run red before its fix. Item 1: the keep-subscription table. Item 2: the planless router table (`router.planless.test.ts`) and the flag-off e2e group failed on the previous head (sign-in detour, extra mint, the refusal for an unmanageable workspace) and pass now. Item 3: the FullPageCheckoutView saved-method test. Item 4: the phone line-layout e2e. Item 5: the reducer, `CheckoutEnding` and the FullPageCheckoutView refusal table. Item 6: the phone code-wrap e2e. ## Screenshots All images come from the **fixture build**: the billing-web Playwright fixtures (`apps/billing-web/e2e/fixtures`, mocked Cloud and a fake Stripe.js), a production `vite build`, the dark theme, and a 1512×982 viewport unless the row says phone (390×844). AS IS is `02ef490a23`, the head of Comfy-Org#19253 as merged. TO BE is this PR's commits before the rebase onto `main`, and the rebase changed no code in these files. None of the images come from a real backend. | Item | AS IS | TO BE | | --- | --- | --- | | 1. Yearly switch, quote with no `renewal_at` | <img width="420" alt="item1 AS IS" src="https://github.com/user-attachments/assets/63a696d2-e53e-4fa5-955b-a159812e065e" /> | <img width="420" alt="item1 TO BE" src="https://github.com/user-attachments/assets/c7ca5e48-e940-4bb5-8e6e-83b22e6060d4" /> | | 2. Link with no `plan`, routed in a tab already signed in, flag on. AS IS leaves for the host (the fixture's "Host app" page). A fresh page load of the same link still looks like AS IS | <img width="420" alt="item2 AS IS" src="https://github.com/user-attachments/assets/c6b62abf-fe75-49e1-a9f0-34c5b1c710fc" /> | <img width="420" alt="item2 TO BE" src="https://github.com/user-attachments/assets/8eca4204-6e42-4e53-9606-1a9f056dbbf4" /> | | 3. One saved method | <img width="420" alt="item3 AS IS" src="https://github.com/user-attachments/assets/6ed40174-3fbd-47ff-9d98-12e0c28c8c00" /> | <img width="420" alt="item3 TO BE" src="https://github.com/user-attachments/assets/6c6060a2-88c2-4082-8cc7-d1a047be84b9" /> | | 4. Ending heading, 390px phone (662-14660) | <img width="220" alt="item4 AS IS" src="https://github.com/user-attachments/assets/3ac68085-f5cf-4d2b-8c09-11c2d4f88407" /> | <img width="220" alt="item4 TO BE" src="https://github.com/user-attachments/assets/eb03568c-0d31-4525-81c6-8732304d92c5" /> | | 5. SUBSCRIPTION_CHANGE_IN_PROGRESS with `scheduled_change` (643-14654) | <img width="420" alt="item5 named AS IS" src="https://github.com/user-attachments/assets/6f6f457d-cbab-450e-bcb6-6fbe07864916" /> | <img width="420" alt="item5 named TO BE" src="https://github.com/user-attachments/assets/2f135a45-a78a-49eb-bc70-a4eddeb10555" /> | | 5. SUBSCRIPTION_CHANGE_IN_PROGRESS, no `scheduled_change` (fallback) | <img width="420" alt="item5 fallback AS IS" src="https://github.com/user-attachments/assets/84b0f93c-cd66-4c50-b615-958eaf123214" /> | <img width="420" alt="item5 fallback TO BE" src="https://github.com/user-attachments/assets/76daf85f-d733-4591-a7c9-3668261177f6" /> | | 6. Long refusal code, 390px phone | <img width="220" alt="item6 AS IS" src="https://github.com/user-attachments/assets/a1302405-a9f2-47a6-aaee-f693a259569c" /> | <img width="220" alt="item6 TO BE" src="https://github.com/user-attachments/assets/aadbeea0-6d35-460d-8649-783fd486944c" /> |
…19499) ## Summary Fixes the `full-page-promo.spec.ts` "a code that lapses before Pay" failure that has been red on main since #19126. The full-page checkout now re-quotes when a subscribe comes back as `QUOTE_STALE`. ## Changes - **What**: #19253 made `payVerdictOf` re-quote only when a raw `SUBSCRIPTION_QUOTE_STALE` `serverCode` came back. #19126 then changed account-core to turn a 4xx with that code into `{ code: 'QUOTE_STALE' }` with no `serverCode`. The two PRs were written in parallel and merged about 40 minutes apart. Since then, `payVerdictOf` falls through to `failure`. The page shows "Your quote changed…" instead of re-pricing and showing the expired-promo card. `payVerdictOf` now maps `QUOTE_STALE` to `requote`. - The `payVerdict` and `FullPageCheckoutView` unit tests built the pre-#19126 result shape by hand, so they missed this. They now use the shape account-core actually returns. ## Review Focus `SUBSCRIPTION_QUOTE_STALE` is gone from `STALE_QUOTE_SERVER_CODES`. Only `subscribe` emits it, and account-core now maps it for 4xx responses. A 5xx that echoes the code arrives as `REQUEST_FAILED`, which account-core treats as an upstream failure, not a stale quote. With this change, that 5xx no longer triggers a re-quote. Red/green: both updated unit tests fail without the `payVerdict.ts` change and pass with it. `pnpm test:e2e:local e2e/full-page-promo.spec.ts` passes 6/6.
…19499) ## Summary Fixes the `full-page-promo.spec.ts` "a code that lapses before Pay" failure that has been red on main since #19126. The full-page checkout now re-quotes when a subscribe comes back as `QUOTE_STALE`. ## Changes - **What**: #19253 made `payVerdictOf` re-quote only when a raw `SUBSCRIPTION_QUOTE_STALE` `serverCode` came back. #19126 then changed account-core to turn a 4xx with that code into `{ code: 'QUOTE_STALE' }` with no `serverCode`. The two PRs were written in parallel and merged about 40 minutes apart. Since then, `payVerdictOf` falls through to `failure`. The page shows "Your quote changed…" instead of re-pricing and showing the expired-promo card. `payVerdictOf` now maps `QUOTE_STALE` to `requote`. - The `payVerdict` and `FullPageCheckoutView` unit tests built the pre-#19126 result shape by hand, so they missed this. They now use the shape account-core actually returns. ## Review Focus `SUBSCRIPTION_QUOTE_STALE` is gone from `STALE_QUOTE_SERVER_CODES`. Only `subscribe` emits it, and account-core now maps it for 4xx responses. A 5xx that echoes the code arrives as `REQUEST_FAILED`, which account-core treats as an upstream failure, not a stale quote. With this change, that 5xx no longer triggers a re-quote. Red/green: both updated unit tests fail without the `payVerdict.ts` change and pass with it. `pnpm test:e2e:local e2e/full-page-promo.spec.ts` passes 6/6.
Why
FE-3018 (Milestone 3, checkout guidebook 1: flow and entry). With
billing_web_checkout_ui = full_page,/v1/checkoutrendered an empty "Checkout" stub. This PR turns it into the two-tone full-page capture from Figma 187-8080, with the loading rule from 479-4848 (DES-1014) and the element-failure column from 360-4874.Root cause
n/a, feature.
How
useFullPageCheckoutreads capabilities, the quote and the Stripe key in parallel on arrival and dispatches one event into theCheckoutPagereducer from the PR below: a deniedcan_subscribe_self_servegoes torefused, a failed read goes tounavailable, a quote goes tocapture. Nothing renders capture before all three are in; the key is awaited becauseStripePaymentFormreads it only on mount.payment_element_ready(the address element's ready does not count). A started operation keeps Pay locked so a second click cannot charge twice; rendering the post-Pay outcome is PR 2 / PR 3.Subscribe to {tier} Plan · {workspace.name}, with the name read from the minted session credential, not the quote.return_tothroughbuildReturnUrl, the same helper the embedded view uses. When this family has no destination for the target, it falls back to the workspace's Plan & Credits settings on the cloud origin (checkout/cloudLinks.ts,/?settings=plan-credits&workspace=<id>, the same deep link the contract'scomfyui_creditstarget names), so the arrow always renders and always has somewhere to go.return_towith the Plan & Credits fallback; thecanGoBackprop is gone since there is always a destination.payment_element_failedreplaces the whole payment column with the 360-4874 card and a Try again that remountsStripePaymentFormand re-disables Pay until the new element is ready.transition_typeother thannew_subscription) renders Pay without a card form and subscribes without a confirmation token, as the embedded view does.useCheckout().subscribewith the same request fields as the embedded view (quote id and version, proration, credit stop,return_urlto/v1/result).StripePaymentForm,usePreviewSubscribe,useCheckout,formatQuoteMoney, andCheckoutTermsNote(now exported from@comfyorg/account-ui/billing/checkout, one line).CheckoutView.vuerefactor is dropped because FE-3046 feat(billing-web): render the shared embedded checkout #19101 owns the M2CheckoutView, the sevencheckout.*locale keys the full page reads are restored, andsubscribeRequest.tsserves the full page only.Tradeoffs
resultUrlare a copy of the embedded view's, because that view must stay untouched while the flag is off. The copy goes when the embedded variant is retired.h-84placeholder boxes stand in for the Stripe elements until the quote arrives, becauseStripePaymentFormnever mounts its elements when the amount is not yet known.full_pagebefore then): after Pay the page shows no outcome and keeps Pay locked; a quote needing reactivation confirmation gets the server's coded refusal on Pay instead of the confirm checkbox; a zero-amount quote, anallowed: falsequote, or one without a payment method configuration leaves Pay disabled with no explanation.CheckoutSummaryColumnandCheckoutPaymentColumnso the view template stays under the fallow complexity gate.Blast Radius
Only
billing_web_checkout_ui = full_page, which Cloud does not serve yet (cloud PR 10904, merged); targeted per account in PostHog. Flag off is byte-identical:CheckoutView.vue,CheckoutPayment.vue,EmbeddedCheckout.vueare untouched and the embedded e2e still passes. The e2e fake Stripe now fires elementready, which the embedded view ignores.Verification
pnpm --filter @comfyorg/billing-web typecheck: clean.pnpm --filter @comfyorg/billing-web test:unit: 25 files, 266 tests pass (13 new component cases inFullPageCheckoutView.test.ts; mutating the operation lock, thecanPayguard inpay(), or theallowedcheck each turns one red).pnpm exec playwright testinapps/billing-web(fresh production build,CI=1): 33 passed. Newe2e/full-page-checkout.spec.tsasserts the eyebrow names plan and workspace, Pay is labelled "Pay and subscribe" and enabled once ready, and the failed-element column plus Try again.checkout-ui.spec.tsstill asserts flag-off shows "Confirm your payment".pnpm --filter @comfyorg/billing-web lint(eslint + stylelint), oxfmt and oxlint on changed files,pnpm knip: clean.cloudLinks.test.ts(the settings deep link with and without a workspace) and a two-row table inFullPageCheckoutView.test.ts(Back tocomfyui_workspace, Back to Plan & Credits forplatform_account, which the test family cannot resolve). Typecheck and 294 unit tests pass at this head.Design questions
#2d2e32(semantic/secondary/background-hover), which has no repo token. This usesbg-secondary-background-hover(#313235in dark). Retoken, or accept?AS IS / TO BE
Captured from the e2e harness (production build, mocked Cloud, fake Stripe) at 1512x982,
full_pageon. The fake Stripe mounts no real element, so the ready state shows the element area empty.Where this sits in the plan
One linear stack on
main: each PR is based on the one above it in the table. The former FE-3019/FE-3020 sibling stack now sits on top of FE-3022.