Repository navigation
[backport cloud/1.54] fix(agent): scroll restored conversation to latest - #19158
Conversation
Open restored Agent conversations at the true bottom instead of the top or slightly above the latest content. Reported in [Slack](https://comfy-organization.slack.com/archives/C0BDJAKKYR0/p1790395975068629). The transcript watcher ran only after subsequent entry changes and originally scrolled a bottom sentinel once. During hydration, Markdown and panel layout can continue growing after that callback; the strict browser regression reproduced a restored overflowing transcript that remained 28 px above its final bottom. - Run follow-to-latest during initial hydration. - Scroll the transcript container directly to its current `scrollHeight`. - Re-follow while transcript content or viewport size changes and follow-latest intent is still active. - Clear follow-latest intent when a real user scroll moves away from the bottom, so later content and resize events do not yank the user down. - Expose a stable test ID for black-box scroll-position coverage. - The cloud refresh-persistence test creates a genuinely overflowing restored transcript and requires exact `distanceFromBottom: 0`. - Component coverage verifies initial restored scrolling, streaming follow behavior, the jump-to-latest control, and the negative case where resize/content changes do not auto-follow after the user scrolls up. - Focused cloud Playwright: 1 passed. - `ConversationView` Vitest: 6 passed. - Browser and app typechecks, targeted lint, formatting, and diff check pass.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1960 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance
🔬 E2E Coverage
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 5 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #19158 +/- ##
=============================================
Coverage ? 83.90%
=============================================
Files ? 2117
Lines ? 126601
Branches ? 34279
=============================================
Hits ? 106228
Misses ? 20196
Partials ? 177
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 7 prior finding(s) across 1 round(s) (7 never answered).
Every reviewer in the matrix failed to contribute — see the panel summary for which cells errored, and the run logs for the underlying cause.
Panel: 0/8 reviewers contributed findings.
Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gemini-3.1-pro:adversarial (error), gpt-5.6-sol-max:adversarial (error), kimi-k3-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gemini-3.1-pro:edge-case (error), gpt-5.6-sol-max:edge-case (error), kimi-k3-max:edge-case (error)
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 3 — ledger: 7 prior finding(s) across 1 round(s) (7 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 5 |
| 🟢 Low | 2 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 4 — ledger: 17 prior finding(s) across 2 round(s) (17 never answered).
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 3 |
| 🟢 Low | 3 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment)
Addresses #19155 (comment) Addresses #19155 (comment) Addresses #19157 (comment)
Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment)
Backports #19052 to
cloud/1.54.Preserves the restored-conversation follow-to-latest behavior and component regression coverage. The newer refresh-persistence browser spec is not present on this release line, so this backport keeps the equivalent component-level proof instead.