Skip to content

[backport cloud/1.54] fix(agent): scroll restored conversation to latest - #19158

Merged
christian-byrne merged 10 commits into
cloud/1.54from
backport-19052-to-cloud-1.54
Sep 28, 2026
Merged

christian-byrne merged 10 commits into
cloud/1.54from
backport-19052-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports #19052 to cloud/1.54.

Preserves the restored-conversation follow-to-latest behavior and component regression coverage. The newer refresh-persistence browser spec is not present on this release line, so this backport keeps the equivalent component-level proof instead.

Open restored Agent conversations at the true bottom instead of the top
or slightly above the latest content. Reported in
[Slack](https://comfy-organization.slack.com/archives/C0BDJAKKYR0/p1790395975068629).

The transcript watcher ran only after subsequent entry changes and
originally scrolled a bottom sentinel once. During hydration, Markdown
and panel layout can continue growing after that callback; the strict
browser regression reproduced a restored overflowing transcript that
remained 28 px above its final bottom.

- Run follow-to-latest during initial hydration.
- Scroll the transcript container directly to its current
`scrollHeight`.
- Re-follow while transcript content or viewport size changes and
follow-latest intent is still active.
- Clear follow-latest intent when a real user scroll moves away from the
bottom, so later content and resize events do not yank the user down.
- Expose a stable test ID for black-box scroll-position coverage.

- The cloud refresh-persistence test creates a genuinely overflowing
restored transcript and requires exact `distanceFromBottom: 0`.
- Component coverage verifies initial restored scrolling, streaming
follow behavior, the jump-to-latest control, and the negative case where
resize/content changes do not auto-follow after the user scrolls up.
- Focused cloud Playwright: 1 passed.
- `ConversationView` Vitest: 6 passed.
- Browser and app typechecks, targeted lint, formatting, and diff check
pass.
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Sep 28, 2026
@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 28, 2026 4:52am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 28, 2026 4:52am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 0a4b0572-8675-4c6a-9eab-93e00d486dc4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/28/2026, 04:54:30 AM UTC

Links

🎭 Playwright: ✅ 1960 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1939 / ❌ 0 / ⚠️ 2 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance

⏳ Performance tests in progress…

🔬 E2E Coverage

⚠️ Coverage collection failed. Check the CI workflow logs.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 7 finding(s).

Severity Count
🟠 High 1
🟡 Medium 5
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

Comment thread browser_tests/fixtures/selectors.ts Resolved
@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nsions/agent/components/agent/ConversationView.vue 92.85% 5 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #19158   +/-   ##
=============================================
  Coverage              ?   83.90%           
=============================================
  Files                 ?     2117           
  Lines                 ?   126601           
  Branches              ?    34279           
=============================================
  Hits                  ?   106228           
  Misses                ?    20196           
  Partials              ?      177           
Flag Coverage Δ
unit 79.07% <92.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...h/extensions/agent/components/agent/AgentPanel.vue 96.82% <ø> (ø)
...nsions/agent/components/agent/ConversationView.vue 95.32% <92.85%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 28, 2026
@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR and removed cursor-review Trigger multi-model Cursor agent review on this PR labels Sep 28, 2026
@christian-byrne
christian-byrne removed the request for review from huang47 September 28, 2026 03:04
@github-actions
github-actions Bot requested a review from huang47 September 28, 2026 03:04
@christian-byrne christian-byrne removed the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 28, 2026
@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 28, 2026
@christian-byrne
christian-byrne removed the request for review from huang47 September 28, 2026 03:09
@github-actions
github-actions Bot requested a review from huang47 September 28, 2026 03:10

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Round 2 — ledger: 7 prior finding(s) across 1 round(s) (7 never answered).

⚠️ Panel did not produce any findings.

Every reviewer in the matrix failed to contribute — see the panel summary for which cells errored, and the run logs for the underlying cause.

Panel: 0/8 reviewers contributed findings.

Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gemini-3.1-pro:adversarial (error), gpt-5.6-sol-max:adversarial (error), kimi-k3-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gemini-3.1-pro:edge-case (error), gpt-5.6-sol-max:edge-case (error), kimi-k3-max:edge-case (error)

@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR and removed cursor-review Trigger multi-model Cursor agent review on this PR labels Sep 28, 2026
@christian-byrne
christian-byrne removed the request for review from huang47 September 28, 2026 03:30

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Round 3 — ledger: 7 prior finding(s) across 1 round(s) (7 never answered).

Found 10 finding(s).

Severity Count
🟠 High 1
🟡 Medium 5
🟢 Low 2
⚪ Nit 2

Panel: 8/8 reviewers contributed findings.

Comment thread browser_tests/fixtures/selectors.ts Resolved
@DrJKL
DrJKL self-requested a review September 28, 2026 03:35

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Round 4 — ledger: 17 prior finding(s) across 2 round(s) (17 never answered).

Found 9 finding(s).

Severity Count
🟠 High 1
🟡 Medium 3
🟢 Low 3
⚪ Nit 2

Panel: 8/8 reviewers contributed findings.

Comment thread browser_tests/fixtures/selectors.ts Resolved
@christian-byrne
christian-byrne merged commit bdffb81 into cloud/1.54 Sep 28, 2026
80 of 82 checks passed
@christian-byrne
christian-byrne deleted the backport-19052-to-cloud-1.54 branch September 28, 2026 04:58

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — 7374cfd7 Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants