Repository navigation
[backport core/1.54] fix(agent): scroll restored conversation to latest - #19155
Conversation
Open restored Agent conversations at the true bottom instead of the top or slightly above the latest content. Reported in [Slack](https://comfy-organization.slack.com/archives/C0BDJAKKYR0/p1790395975068629). The transcript watcher ran only after subsequent entry changes and originally scrolled a bottom sentinel once. During hydration, Markdown and panel layout can continue growing after that callback; the strict browser regression reproduced a restored overflowing transcript that remained 28 px above its final bottom. - Run follow-to-latest during initial hydration. - Scroll the transcript container directly to its current `scrollHeight`. - Re-follow while transcript content or viewport size changes and follow-latest intent is still active. - Clear follow-latest intent when a real user scroll moves away from the bottom, so later content and resize events do not yank the user down. - Expose a stable test ID for black-box scroll-position coverage. - The cloud refresh-persistence test creates a genuinely overflowing restored transcript and requires exact `distanceFromBottom: 0`. - Component coverage verifies initial restored scrolling, streaming follow behavior, the jump-to-latest control, and the negative case where resize/content changes do not auto-follow after the user scrolls up. - Focused cloud Playwright: 1 passed. - `ConversationView` Vitest: 6 passed. - Browser and app typechecks, targeted lint, formatting, and diff check pass.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1959 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-28T03:25:39.110Z",
"gitSha": "1627c7879e98eec952446185837d0dd45b278bed",
"branch": "backport-19052-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2129.5149999999694,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.332000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 744.495,
"heapDeltaBytes": -5061088,
"heapUsedBytes": 64480252,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 14.899000000000003,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2051.6620000000216,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.394,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.974,
"heapDeltaBytes": 9099796,
"heapUsedBytes": 79358772,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.598,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1920.521000000008,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.505,
"layouts": 14,
"layoutDurationMs": 4.4510000000000005,
"taskDurationMs": 957.0949999999999,
"heapDeltaBytes": 8252540,
"heapUsedBytes": 79568976,
"domNodes": -284,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 156.984,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1935.2670000000671,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.677,
"layouts": 14,
"layoutDurationMs": 4.507,
"taskDurationMs": 988.8869999999998,
"heapDeltaBytes": -5497908,
"heapUsedBytes": 64984944,
"domNodes": -282,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 162.84400000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.1510000000062,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.433999999999997,
"layouts": 6,
"layoutDurationMs": 1.345,
"taskDurationMs": 418.831,
"heapDeltaBytes": 4652560,
"heapUsedBytes": 75964168,
"domNodes": 72,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.676999999999996,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.9519999999602,
"styleRecalcs": 30,
"styleRecalcDurationMs": 19.267999999999997,
"layouts": 6,
"layoutDurationMs": 1.4659999999999997,
"taskDurationMs": 468.427,
"heapDeltaBytes": 4654192,
"heapUsedBytes": 75865320,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 16.614,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 724.0079999999693,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.79,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.867,
"heapDeltaBytes": 18022732,
"heapUsedBytes": 88744856,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 163.245,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 725.2809999999954,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.4489999999999,
"heapDeltaBytes": 18060408,
"heapUsedBytes": 88458528,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 169.865,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2062.852000000021,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.7219999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 801.7299999999999,
"heapDeltaBytes": 7695044,
"heapUsedBytes": 84255188,
"domNodes": -273,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 37.749,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2054.4629999999415,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.165,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 801.565,
"heapDeltaBytes": 6468204,
"heapUsedBytes": 82480408,
"domNodes": -279,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 40.839,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2575.7990000000177,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.761,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1720.193,
"heapDeltaBytes": 25455012,
"heapUsedBytes": 92212532,
"domNodes": 0,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 828.388,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2787.975999999958,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.188000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1842.794,
"heapDeltaBytes": 27466972,
"heapUsedBytes": 93688364,
"domNodes": -282,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 864.774,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3776.6730000000166,
"styleRecalcs": 62,
"styleRecalcDurationMs": 13.735000000000001,
"layouts": 60,
"layoutDurationMs": 14.312000000000001,
"taskDurationMs": 1856.33,
"heapDeltaBytes": 10668708,
"heapUsedBytes": 76173908,
"domNodes": -280,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 802.583,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3954.3780000000197,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.916,
"layouts": 60,
"layoutDurationMs": 14.634,
"taskDurationMs": 1929.3809999999999,
"heapDeltaBytes": 8384944,
"heapUsedBytes": 75969444,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 840.444,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3218.2790000000523,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.164,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2177.043,
"heapDeltaBytes": 28272512,
"heapUsedBytes": 95694276,
"domNodes": -280,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1070.8359999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3200.3710000000183,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.019000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2132.838,
"heapDeltaBytes": 22115452,
"heapUsedBytes": 90162756,
"domNodes": -11,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1036.786,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2060.202000000004,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.552999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 767.272,
"heapDeltaBytes": 6721116,
"heapUsedBytes": 84001540,
"domNodes": -281,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 46.612,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2075.962000000004,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.110999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 798.315,
"heapDeltaBytes": 6336196,
"heapUsedBytes": 83688880,
"domNodes": -282,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 40.379,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 644.8819999999955,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.184,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.5400000000001,
"heapDeltaBytes": 14278748,
"heapUsedBytes": 87059928,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 153.923,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 673.35700000001,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.430000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.851,
"heapDeltaBytes": 13594852,
"heapUsedBytes": 86388660,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 146.678,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2039.5939999999655,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.609999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.445,
"heapDeltaBytes": -8872736,
"heapUsedBytes": 63967488,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.043000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.507000000095,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.896999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.1419999999999,
"heapDeltaBytes": -14090448,
"heapUsedBytes": 59265064,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.841,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.0199999999782,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.578,
"layouts": 18,
"layoutDurationMs": 5.699,
"taskDurationMs": 929.144,
"heapDeltaBytes": -10112336,
"heapUsedBytes": 61548708,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 120.83899999999998,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1785.8600000000706,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.086999999999996,
"layouts": 18,
"layoutDurationMs": 5.381,
"taskDurationMs": 925.72,
"heapDeltaBytes": -9103508,
"heapUsedBytes": 63168268,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 123.16000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.4579999999537,
"styleRecalcs": 20,
"styleRecalcDurationMs": 35.62800000000001,
"layouts": 16,
"layoutDurationMs": 16.331,
"taskDurationMs": 1040.603,
"heapDeltaBytes": 21104104,
"heapUsedBytes": 109788760,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 33.272999999999996,
"eventListeners": 2387,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8720.330999999987,
"styleRecalcs": 248,
"styleRecalcDurationMs": 43.265,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6266.985,
"heapDeltaBytes": 9317184,
"heapUsedBytes": 85363120,
"domNodes": -268,
"jsHeapTotalBytes": -172032,
"scriptDurationMs": 2748.818,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9570.187000000033,
"styleRecalcs": 249,
"styleRecalcDurationMs": 45.50899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6465.671,
"heapDeltaBytes": 1219416,
"heapUsedBytes": 77912156,
"domNodes": -282,
"jsHeapTotalBytes": 90112,
"scriptDurationMs": 2817.759,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18630.047999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18362.894,
"heapDeltaBytes": -33661716,
"heapUsedBytes": 178738136,
"domNodes": -8068,
"jsHeapTotalBytes": -7847936,
"scriptDurationMs": 328.085,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18548.072000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18294.021,
"heapDeltaBytes": -43029740,
"heapUsedBytes": 191383016,
"domNodes": -8068,
"jsHeapTotalBytes": -19877888,
"scriptDurationMs": 337.628,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23474.49799999998,
"styleRecalcs": 178,
"styleRecalcDurationMs": 29.050999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23406.37,
"heapDeltaBytes": -23650656,
"heapUsedBytes": 189070220,
"domNodes": -8068,
"jsHeapTotalBytes": -10817536,
"scriptDurationMs": 1016.4780000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 267,
"frameDurationMs": 18.886666666666862,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 24321.831999999973,
"styleRecalcs": 175,
"styleRecalcDurationMs": 25.924999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24184.441999999995,
"heapDeltaBytes": -52504956,
"heapUsedBytes": 168909024,
"domNodes": -8068,
"jsHeapTotalBytes": -13025280,
"scriptDurationMs": 988.4560000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 110,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6770.233000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.96200000000003,
"layouts": 20,
"layoutDurationMs": 30.057000000000002,
"taskDurationMs": 6730.325000000001,
"heapDeltaBytes": -41401080,
"heapUsedBytes": 193530960,
"domNodes": -8068,
"jsHeapTotalBytes": 12013568,
"scriptDurationMs": 139.876,
"eventListeners": -14927,
"totalBlockingTimeMs": 669,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 7373.894999999948,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.53100000000002,
"layouts": 20,
"layoutDurationMs": 27.90200000000001,
"taskDurationMs": 7330.794000000001,
"heapDeltaBytes": -31989472,
"heapUsedBytes": 185632476,
"domNodes": -8072,
"jsHeapTotalBytes": 11259904,
"scriptDurationMs": 146.875,
"eventListeners": -14929,
"totalBlockingTimeMs": 707,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9294.798000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9168.622,
"heapDeltaBytes": 10429296,
"heapUsedBytes": 179304084,
"domNodes": 0,
"jsHeapTotalBytes": -7340032,
"scriptDurationMs": 156.33999999999992,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10259.997999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10038.466000000002,
"heapDeltaBytes": 21149600,
"heapUsedBytes": 189139608,
"domNodes": 0,
"jsHeapTotalBytes": -4194304,
"scriptDurationMs": 187.23199999999994,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 112.45300000001635,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.407999999999998,
"layouts": 2,
"layoutDurationMs": 1.365,
"taskDurationMs": 82.936,
"heapDeltaBytes": 3073536,
"heapUsedBytes": 72340420,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.114000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 166.5019999999231,
"styleRecalcs": 9,
"styleRecalcDurationMs": 30.928000000000004,
"layouts": 3,
"layoutDurationMs": 1.672,
"taskDurationMs": 122.477,
"heapDeltaBytes": 2994336,
"heapUsedBytes": 72223656,
"domNodes": 130,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.3020000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 5 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #19155 +/- ##
=============================================
- Coverage 83.85% 83.80% -0.05%
=============================================
Files 2110 2109 -1
Lines 125247 125629 +382
Branches 31748 33737 +1989
=============================================
+ Hits 105022 105280 +258
- Misses 20047 20171 +124
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 3 — ledger: 8 prior finding(s) across 1 round(s) (8 never answered).
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 3 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 4 — ledger: 15 prior finding(s) across 2 round(s) (15 never answered).
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 4 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment)
Addresses #19155 (comment) Addresses #19155 (comment) Addresses #19157 (comment)
Addresses #19155 (comment) Addresses #19155 (comment) Addresses #19157 (comment)
Addresses #19155 (comment) Addresses #19155 (comment) Addresses #19157 (comment)
Addresses #19155 (comment) Addresses #19155 (comment) Addresses #19157 (comment)
Addresses #19155 (comment) Addresses #19155 (comment) Addresses #19157 (comment)
Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment)
Backports #19052 to
core/1.54.Preserves the restored-conversation follow-to-latest behavior and component regression coverage. The newer refresh-persistence browser spec is not present on this release line, so this backport keeps the equivalent component-level proof instead.