Repository navigation
chore: add import cycle baseline check for src #19085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
908bc61
d91d543
bb255b1
f823954
d2194f1
218206b
9c8c2f9
7bd1e8b
c634582
3345062
38d7392
c5e83a9
a954617
3c3ae4f
8c7b057
5292026
ecaf56f
8f7f86e
83b5c51
a49294d
4bceca3
1a0c7bb
4b04920
c55dc63
d179d8a
8725c51
cfab0d1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import type { IConfiguration } from 'dependency-cruiser' | ||
|
|
||
| const config: IConfiguration = { | ||
| options: { | ||
| tsConfig: { fileName: 'tsconfig.json' }, | ||
| tsPreCompilationDeps: 'specify', | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Medium — Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case). |
||
| doNotFollow: { path: 'node_modules' }, | ||
| exclude: { | ||
| path: ['\\.(test|spec|stories)\\.ts$', '/__tests?__/', '/test/'] | ||
| }, | ||
| enhancedResolveOptions: { | ||
| extensions: ['.ts', '.mts', '.js', '.vue', '.json'], | ||
| mainFields: ['module', 'main', 'types'] | ||
| } | ||
| } | ||
| } | ||
|
|
||
| export default config | ||
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ Nit — This file was registered with knip and
.fallowrc.jsoncbut not added totsconfig.json'sinclude, which enumerates root-level TS config files individually (eslint.config.ts,knip.config.ts,lint-staged.config.ts,playwright.config.ts,vitest.config.ts). TheIConfigurationannotation — the whole reason to author the config in TypeScript — is therefore never checked bypnpm typecheck, and an invalid option would only fail at depcruise runtime.Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).