Repository navigation
[backport cloud/1.55] fix(agent): combine adjacent fragmented assets without reordering captioned assets - #19080
Conversation
…tioned assets (#18090) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729?thread_ts=1789700733.927729&cid=C0BGH348Z0C)_ ## Before / After **Before:** when a batch reply contains multiple generated assets, any tool call or thinking step that falls between two assets breaks the reply's grid into separate fullwidth blocks stacked in one column, instead of the intended grid. **After:** assets in one reply that are actually adjacent (no caption or other prose between them) render in a single grid, regardless of tool calls/thinking interleaved while they were generated. A caption between two assets still keeps that asset in its own group, directly beside its own caption, in the reply's original order — combining a fragmented batch into one grid never moves an asset away from its caption or out of order. ## Root cause (verified, not re-derived) - `src/workbench/extensions/agent/services/agent/agentEventTransport.ts` closes the currently-open `TextPart` (`closeOpenText()`) on every `agent_thinking` / `agent_tool_call` / `agent_active_tab` / `agent_ask` event, and opens a fresh one on the next `agent_message_delta`. A batch of assets separated by a tool call or thinking step therefore ends up as N separate `TextPart`s. - `agentMessageGroup.ts`'s `groupMessageParts` now folds consecutive `TextPart`s that are only separated by `tool`/`thinking` parts into one text group, so `AgentMessageGroup.vue` renders them joined through a single `MarkdownStream` instead of one per fragment. - Within that joined text, `MarkdownStream.vue`'s segment builder already coalesces standalone assets that end up adjacent (no prose between them, even across the original `TextPart` boundary) into one `ReplyAssetGroup` — this fixes the base PM-1135 case (two tool-separated images, no captions). ## What this PR fixes An earlier revision of this branch additionally special-cased "multi-`TextPart`" replies in `MarkdownStream.vue`: it collected every asset in the merged group into a side array and appended them all as one trailing grid, regardless of the prose between them. That broke caption/asset pairing and content order — a caption between two assets (e.g. `Version A:` / `Version B:`) rendered both captions together above a merged gallery instead of each above its own image, and a lone asset followed by unrelated prose (`"The preview above failed to render."`) rendered after that prose instead of before it. This PR removes that special case. The per-position segment builder that already existed for a single `TextPart` handles the merged, multi-`TextPart` text exactly the same way: it flushes prose, then pushes an asset segment, merging it into the previous segment only when that previous segment is *also* an asset segment (i.e. truly adjacent, nothing in between). That is sufficient to combine a fragmented batch into one grid whenever there's nothing between the assets, and it never needs to move an asset out of its original position to do so. Also removed the now-dead `aggregateAssets` prop this required, and the `agentMessageGroup.ts` `hasActivity` parameter that duplicated information already recoverable from `parts` (its only caller already computes it from the same array). **Scope:** "combining a fragmented batch" only ever matters when the transport actually produced multiple `TextPart`s for one reply (i.e. a tool call or thinking step landed between generated assets). A caption alone, with no tool call/thinking step between assets, never creates multiple `TextPart`s — it already lives inside one `TextPart`, where a caption between two assets has always prevented ordinary adjacent-asset coalescing. That single-`TextPart` behavior is unchanged. See linear.app/comfyorg/issue/PM-1135 (parent PM-1313). ## Test Plan - **Vitest** (`AgentMessage.assetGridFragmentation.test.ts`) — rewrote the low-level regression to use `Version A:` / `Version B:` captions (matching the real PM-1135 fixture) instead of two bare images, so it actually exercises caption/asset pairing rather than passing on adjacency alone; queries a stable `data-testid="reply-asset-group"` instead of a `[class*="grid-cols-"]` DOM/Tailwind traversal. Added a companion case for a single asset followed by later, unrelated prose. Verified both fail against the pre-fix code and pass at this head. - **Playwright** (`agentConversationReplay.spec.ts`) — replays the fixture through the real chat panel; kept the image-count assertion and the screenshot, dropped the redundant `grid-cols-*` DOM oracle now that the component test owns exact containment. Trimmed the fixture's workflow seed to the smallest valid empty workflow (the scenario has no graph operations). - `pnpm lint`, `pnpm typecheck`, `pnpm test:unit` clean on the changed files. - [ ] CI screenshot baseline needs regeneration for the corrected layout (applying the "New Browser Test Expectations" label). 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1 --- _Generated by [Claude Code](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: github-actions <github-actions@github.com>
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2124 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6639ea213d83b20842be4d98785e390ea8a0449c
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-27T12:01:33.839Z",
"gitSha": "651add6b490f84b176fc326346608e0ff5a33af7",
"branch": "backport-18090-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.7960000000085,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.402000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.164,
"heapDeltaBytes": 7532636,
"heapUsedBytes": 75340752,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.920000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2017.6910000000134,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.552999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.6039999999999,
"heapDeltaBytes": 8465772,
"heapUsedBytes": 76340380,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.167000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.6169999999543,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.528000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 823.7669999999999,
"heapDeltaBytes": -3411896,
"heapUsedBytes": 64241064,
"domNodes": -258,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 153.251,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1728.379000000018,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.274000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 803.56,
"heapDeltaBytes": -4999352,
"heapUsedBytes": 62610736,
"domNodes": -259,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 143.51500000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.8689999999888,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.938,
"layouts": 6,
"layoutDurationMs": 1.4369999999999998,
"taskDurationMs": 382.11899999999997,
"heapDeltaBytes": 2198012,
"heapUsedBytes": 64635844,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.451,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.3649999999207,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.504,
"layouts": 6,
"layoutDurationMs": 1.2690000000000001,
"taskDurationMs": 348.23099999999994,
"heapDeltaBytes": 2846468,
"heapUsedBytes": 70262728,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.803000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 664.1280000000052,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.897999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.42600000000004,
"heapDeltaBytes": 18353808,
"heapUsedBytes": 80761384,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 168.65,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 674.5169999999234,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.788999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.83199999999994,
"heapDeltaBytes": 18933628,
"heapUsedBytes": 86576452,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 157.457,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1126.895999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 787.812,
"heapDeltaBytes": 38504056,
"heapUsedBytes": 105032360,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 57.117000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 517,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1204.6619999999848,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 893.321,
"heapDeltaBytes": -17082700,
"heapUsedBytes": 72956324,
"domNodes": -297,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 61.515,
"eventListeners": -217,
"totalBlockingTimeMs": 545,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 796.4690000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.2499999999998,
"heapDeltaBytes": 14275456,
"heapUsedBytes": 91499768,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 129.40999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 181,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 793.4440000000222,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.2819999999998,
"heapDeltaBytes": 14767684,
"heapUsedBytes": 90430168,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 135.12500000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 184,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9344.043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8441.243,
"heapDeltaBytes": -230672,
"heapUsedBytes": 81865136,
"domNodes": -14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 6649.335000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 397,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8646.023000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7960.441,
"heapDeltaBytes": 3466744,
"heapUsedBytes": 85894468,
"domNodes": -14,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 6567.597,
"eventListeners": 0,
"totalBlockingTimeMs": 472,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.19999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9148.866999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8391.048999999999,
"heapDeltaBytes": 4121680,
"heapUsedBytes": 86148184,
"domNodes": -16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 6636.210999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 414,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8703.538999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7901.15,
"heapDeltaBytes": 12917628,
"heapUsedBytes": 94617276,
"domNodes": -14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 6200.774,
"eventListeners": 0,
"totalBlockingTimeMs": 171,
"frameDurationMs": 19.44333333333331,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2054.867999999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.7540000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 653.56,
"heapDeltaBytes": -7658972,
"heapUsedBytes": 79173952,
"domNodes": -250,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 37.576,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.6080000000065,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.872000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.5799999999999,
"heapDeltaBytes": -9888920,
"heapUsedBytes": 77273036,
"domNodes": -253,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.669000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2313.289999999995,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.010000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1562.6499999999999,
"heapDeltaBytes": -11396000,
"heapUsedBytes": 76621700,
"domNodes": -243,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 839.8559999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2309.439999999995,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.389999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1600.593,
"heapDeltaBytes": 16108748,
"heapUsedBytes": 80306384,
"domNodes": -241,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 796.602,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3680.909999999926,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.715000000000005,
"layouts": 60,
"layoutDurationMs": 13.949999999999998,
"taskDurationMs": 1802.419,
"heapDeltaBytes": -15519452,
"heapUsedBytes": 73854732,
"domNodes": -258,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 785.5479999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3609.478000000081,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.778999999999998,
"layouts": 60,
"layoutDurationMs": 13.908,
"taskDurationMs": 1706.5560000000003,
"heapDeltaBytes": 8440320,
"heapUsedBytes": 74528636,
"domNodes": -247,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 764.961,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3067.786999999953,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.661999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1776.677,
"heapDeltaBytes": 16181028,
"heapUsedBytes": 82274008,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 959.348,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3182.4510000000146,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.356999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2026.3530000000003,
"heapDeltaBytes": 558604,
"heapUsedBytes": 91124840,
"domNodes": -252,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 987.071,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2005.3649999999834,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.386,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.1089999999999,
"heapDeltaBytes": 20147144,
"heapUsedBytes": 84667384,
"domNodes": -1,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.495999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2019.5620000000645,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.8889999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.7370000000001,
"heapDeltaBytes": -4668704,
"heapUsedBytes": 84497524,
"domNodes": -244,
"jsHeapTotalBytes": -1806336,
"scriptDurationMs": 30.795,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 622.1820000000662,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.493,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.702,
"heapDeltaBytes": 13294032,
"heapUsedBytes": 83714908,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.058,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.4809999999779,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.687,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.394,
"heapDeltaBytes": 14095432,
"heapUsedBytes": 83953396,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.033,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2002.9850000000238,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.379999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.92999999999995,
"heapDeltaBytes": 9784008,
"heapUsedBytes": 79633916,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.569999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.9980000000296,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.211999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.71000000000004,
"heapDeltaBytes": -795480,
"heapUsedBytes": 69157564,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.700000000000003,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.3419999999733,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.149,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 771.1439999999999,
"heapDeltaBytes": 10149508,
"heapUsedBytes": 80134784,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 96.47999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.5899999999874,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.412000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 767.4879999999999,
"heapDeltaBytes": -3972836,
"heapUsedBytes": 65973864,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 100.10900000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.2909999999993,
"styleRecalcs": 16,
"styleRecalcDurationMs": 25.777,
"layouts": 5,
"layoutDurationMs": 11.419000000000002,
"taskDurationMs": 902.3249999999998,
"heapDeltaBytes": -6294516,
"heapUsedBytes": 81971680,
"domNodes": 13667,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 30.244999999999994,
"eventListeners": 2383,
"totalBlockingTimeMs": 123,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8787.5939999999,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.431,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6047.959000000001,
"heapDeltaBytes": -5979964,
"heapUsedBytes": 80539916,
"domNodes": -247,
"jsHeapTotalBytes": 1007616,
"scriptDurationMs": 2761.563,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8415.107999999918,
"styleRecalcs": 252,
"styleRecalcDurationMs": 38.412,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5956.840999999999,
"heapDeltaBytes": -1938264,
"heapUsedBytes": 84876088,
"domNodes": -238,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2754.9680000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15130.751999999917,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14778.872,
"heapDeltaBytes": -65087600,
"heapUsedBytes": 170392968,
"domNodes": -6541,
"jsHeapTotalBytes": -11657216,
"scriptDurationMs": 228.77,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15283.835000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14896.707,
"heapDeltaBytes": -52069632,
"heapUsedBytes": 189228420,
"domNodes": -8065,
"jsHeapTotalBytes": -19861504,
"scriptDurationMs": 250.67800000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18274.432000000048,
"styleRecalcs": 129,
"styleRecalcDurationMs": 16.060999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18159.346999999998,
"heapDeltaBytes": -46651328,
"heapUsedBytes": 168633172,
"domNodes": -8061,
"jsHeapTotalBytes": -11022336,
"scriptDurationMs": 884.389,
"eventListeners": -14928,
"totalBlockingTimeMs": 38,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18225.12000000006,
"styleRecalcs": 123,
"styleRecalcDurationMs": 16.014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18112.911,
"heapDeltaBytes": -28166580,
"heapUsedBytes": 191268208,
"domNodes": -8061,
"jsHeapTotalBytes": -16855040,
"scriptDurationMs": 851.881,
"eventListeners": -14928,
"totalBlockingTimeMs": 38,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5537.255999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.877,
"layouts": 20,
"layoutDurationMs": 24.888999999999996,
"taskDurationMs": 5505.022999999999,
"heapDeltaBytes": -58606912,
"heapUsedBytes": 169236836,
"domNodes": -8061,
"jsHeapTotalBytes": 2945024,
"scriptDurationMs": 93.66,
"eventListeners": -14928,
"totalBlockingTimeMs": 283,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5555.927999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.13699999999999,
"layouts": 20,
"layoutDurationMs": 25.846000000000007,
"taskDurationMs": 5496.8,
"heapDeltaBytes": -45483048,
"heapUsedBytes": 196302832,
"domNodes": -8061,
"jsHeapTotalBytes": 11661312,
"scriptDurationMs": 95.24099999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 374,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7481.873999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7348.407,
"heapDeltaBytes": -1929896,
"heapUsedBytes": 197619604,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 106.61199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5425.917000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5260.854,
"heapDeltaBytes": 4632216,
"heapUsedBytes": 181686936,
"domNodes": 0,
"jsHeapTotalBytes": -5242880,
"scriptDurationMs": 86.542,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 134.4850000000406,
"styleRecalcs": 10,
"styleRecalcDurationMs": 21.518999999999995,
"layouts": 6,
"layoutDurationMs": 3.246,
"taskDurationMs": 113.532,
"heapDeltaBytes": 3330628,
"heapUsedBytes": 69007712,
"domNodes": 135,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.567,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 465.43000000008306,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.026000000000003,
"layouts": 3,
"layoutDurationMs": 0.7909999999999999,
"taskDurationMs": 120.85499999999999,
"heapDeltaBytes": 4906028,
"heapUsedBytes": 70379848,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.893,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
@coderabbitai review |
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
|
/update-playwright |
|
Updating Playwright Expectations |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19080 +/- ##
=============================================
Coverage ? 84.61%
=============================================
Files ? 2300
Lines ? 131898
Branches ? 35637
=============================================
Hits ? 111610
Misses ? 19969
Partials ? 319
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/update-playwright |
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/agent/agentConversationReplay.spec.ts-snapshots/asset-grid-fragmentation-cloud-linux.png` | modified | 40349B -> 39864B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
|
Zero tests actually failed — 23,670 passed, 0 failed. One file collected 0 tests and errored on import:
Why it fires here and not on the core sibling #19079, which merged green with the same 14 files: nothing in Re-ran the job. If it goes green this merges as-is. The durable fix is a |
The file collected zero tests and failed on import: ReferenceError: ResizeObserver is not defined at useVueNodeResizeTracking.ts:101 <- WidgetGrid.vue <- LGraphNodePreview.vue AgentMessage transitively reaches useVueNodeResizeTracking, which builds a ResizeObserver at module scope; jsdom has none, so the import throws before collection. Reproduced in isolation on this branch and confirmed absent on main, so it is an import-chain difference, not flake -- a CI re-run failed the same way. Uses the same hoisted stub as WhatsNewPopup.test.ts. No production code touched.
|
Fixed and verified locally. Correcting my earlier comment: I first read this as sharding luck. It is not — the re-run failed identically, and I reproduced it in isolation on this branch while the same file passes in isolation on
Fix is test-only: the hoisted Verified on this branch's tree: 3 passed, where it previously collected zero. |
Backport of #18090 to
cloud/1.55Automatically created by backport workflow.