Repository navigation
fix(agent): combine adjacent fragmented assets without reordering captioned assets - #18090
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2138 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 10 MB gzip 🟢 -984 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed / 16 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 4 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks
Status: 10 added / 10 removed / 6 unchanged Data & Services — 4 MB (baseline 4 MB) • 🟢 -3.08 kBStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 578 kB (baseline 578 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 26 added / 26 removed / 10 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • 🔴 +13 BExternal libraries and shared vendor chunks
Status: 1 added / 1 removed / 17 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category
Status: 92 added / 92 removed / 209 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T07:06:50.247Z",
"gitSha": "a649a1da243947b7809fb77ea23c044bd8517942",
"branch": "test/pm-1135-asset-grid-fragmentation-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.6160000000177,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.175,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.51399999999995,
"heapDeltaBytes": 3283012,
"heapUsedBytes": 65579604,
"domNodes": -228,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.611,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.8570000000345,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.189,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.7340000000001,
"heapDeltaBytes": -1314840,
"heapUsedBytes": 66266460,
"domNodes": -228,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.664000000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.7220000000043,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.723000000000003,
"layouts": 12,
"layoutDurationMs": 4.502,
"taskDurationMs": 835.657,
"heapDeltaBytes": 1122196,
"heapUsedBytes": 63629836,
"domNodes": -228,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 172.56400000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.9209999999175,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.63,
"layouts": 12,
"layoutDurationMs": 4.595,
"taskDurationMs": 817.365,
"heapDeltaBytes": 5450156,
"heapUsedBytes": 67995020,
"domNodes": -228,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 162.473,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.6659999999897,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.542000000000002,
"layouts": 6,
"layoutDurationMs": 1.384,
"taskDurationMs": 323.74499999999995,
"heapDeltaBytes": 2155996,
"heapUsedBytes": 64626084,
"domNodes": 53,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.606000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1690.8259999999018,
"styleRecalcs": 28,
"styleRecalcDurationMs": 9.5,
"layouts": 6,
"layoutDurationMs": 1.0619999999999998,
"taskDurationMs": 320.324,
"heapDeltaBytes": 2397112,
"heapUsedBytes": 63948672,
"domNodes": 53,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.506000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 677.6790000000119,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.5460000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.38500000000005,
"heapDeltaBytes": 18972584,
"heapUsedBytes": 80800236,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 172.027,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 678.011999999967,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.4750000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.674,
"heapDeltaBytes": 18428068,
"heapUsedBytes": 80855464,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 171.821,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.4280000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 861.1170000000001,
"heapDeltaBytes": 14035152,
"heapUsedBytes": 103479796,
"domNodes": -259,
"jsHeapTotalBytes": 19550208,
"scriptDurationMs": 70.42099999999998,
"eventListeners": -185,
"totalBlockingTimeMs": 569,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1189.6769999999606,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 835.7020000000001,
"heapDeltaBytes": 35542364,
"heapUsedBytes": 103885524,
"domNodes": 0,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 65.84499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 573,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.6129999999871,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.4020000000003,
"heapDeltaBytes": 13790692,
"heapUsedBytes": 90699172,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.73099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 243,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.3240000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.6919999999999,
"heapDeltaBytes": 14469472,
"heapUsedBytes": 91103920,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.302,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10386.881000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9522.761999999999,
"heapDeltaBytes": 13926168,
"heapUsedBytes": 96319912,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8130.851,
"eventListeners": 0,
"totalBlockingTimeMs": 1769,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10859.745999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9858.994,
"heapDeltaBytes": 2680356,
"heapUsedBytes": 85292764,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8243.278999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1281,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11255.585999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10254.725,
"heapDeltaBytes": 569520,
"heapUsedBytes": 83424500,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8592.039999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1588,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11662.23100000002,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.4410000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10769.882000000001,
"heapDeltaBytes": -6029276,
"heapUsedBytes": 71797672,
"domNodes": -228,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9040.036,
"eventListeners": -164,
"totalBlockingTimeMs": 1826,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2024.6230000000196,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.307,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.5029999999999,
"heapDeltaBytes": 1889888,
"heapUsedBytes": 83588432,
"domNodes": -228,
"jsHeapTotalBytes": -1806336,
"scriptDurationMs": 31.775,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2054.177999999979,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.478999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.7359999999999,
"heapDeltaBytes": -6720116,
"heapUsedBytes": 74850304,
"domNodes": -228,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 32.656000000000006,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2460.0150000000554,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.574,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1677.7699999999998,
"heapDeltaBytes": 2946492,
"heapUsedBytes": 85701368,
"domNodes": -228,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 896.4490000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2529.920999999945,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.61,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1632.927,
"heapDeltaBytes": 19062548,
"heapUsedBytes": 83669316,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 867.567,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3519.999999999982,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.768,
"layouts": 60,
"layoutDurationMs": 13.274000000000001,
"taskDurationMs": 1541.9579999999999,
"heapDeltaBytes": 8876692,
"heapUsedBytes": 74756668,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 799.767,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3542.09800000001,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.786999999999999,
"layouts": 60,
"layoutDurationMs": 13.785,
"taskDurationMs": 1598.35,
"heapDeltaBytes": -18395444,
"heapUsedBytes": 65305616,
"domNodes": -228,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 802.988,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3161.1970000000156,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.957000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1942.7660000000003,
"heapDeltaBytes": 26717004,
"heapUsedBytes": 92696084,
"domNodes": 0,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 1009.673,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3142.9749999999785,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.766999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1938.326,
"heapDeltaBytes": 1473720,
"heapUsedBytes": 67837916,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 1020.253,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.0739999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.8419999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.5740000000001,
"heapDeltaBytes": -13930056,
"heapUsedBytes": 74934164,
"domNodes": -228,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 33.007000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2027.4950000000445,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.289,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.88899999999995,
"heapDeltaBytes": -13682132,
"heapUsedBytes": 74831768,
"domNodes": -228,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 32.942,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.804000000001,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.627,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.24099999999993,
"heapDeltaBytes": 13205752,
"heapUsedBytes": 76734992,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.14499999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 636.5180000000237,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.399000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.36300000000006,
"heapDeltaBytes": 14091856,
"heapUsedBytes": 76939636,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 149.29,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2019.1980000000171,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.7820000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.25399999999996,
"heapDeltaBytes": 7507740,
"heapUsedBytes": 71178312,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.013999999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.348999999991,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.143000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.14099999999996,
"heapDeltaBytes": 8036988,
"heapUsedBytes": 70801740,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.168,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.091000000025,
"styleRecalcs": 59,
"styleRecalcDurationMs": 18.076999999999998,
"layouts": 16,
"layoutDurationMs": 6.286,
"taskDurationMs": 787.1360000000001,
"heapDeltaBytes": 11812240,
"heapUsedBytes": 74375644,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 113.83699999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.3920000000326,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.876,
"layouts": 16,
"layoutDurationMs": 5.551,
"taskDurationMs": 770.907,
"heapDeltaBytes": 11368332,
"heapUsedBytes": 75054040,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 110.813,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.7989999999536,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.197000000000006,
"layouts": 5,
"layoutDurationMs": 13.113,
"taskDurationMs": 930.6659999999999,
"heapDeltaBytes": -6243648,
"heapUsedBytes": 82152208,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.168000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8523.445000000038,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.988999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5767.282,
"heapDeltaBytes": -639984,
"heapUsedBytes": 80633580,
"domNodes": -228,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2820.045,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8619.702000000074,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.531000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5809.748,
"heapDeltaBytes": -539476,
"heapUsedBytes": 80966380,
"domNodes": -230,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 2881.329,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16758.16900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16261.606,
"heapDeltaBytes": -41939864,
"heapUsedBytes": 171945816,
"domNodes": -8049,
"jsHeapTotalBytes": -10498048,
"scriptDurationMs": 260.78000000000003,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16732.319000000076,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16200.662999999999,
"heapDeltaBytes": -58948032,
"heapUsedBytes": 178664912,
"domNodes": -8049,
"jsHeapTotalBytes": -14352384,
"scriptDurationMs": 280.9080000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20663.39400000004,
"styleRecalcs": 166,
"styleRecalcDurationMs": 17.128000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20256.508,
"heapDeltaBytes": -18035436,
"heapUsedBytes": 190976980,
"domNodes": -8049,
"jsHeapTotalBytes": -7897088,
"scriptDurationMs": 885.154,
"eventListeners": -14923,
"totalBlockingTimeMs": 85,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20638.50100000002,
"styleRecalcs": 171,
"styleRecalcDurationMs": 17.598000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20215.672000000002,
"heapDeltaBytes": -28012428,
"heapUsedBytes": 191750536,
"domNodes": -8049,
"jsHeapTotalBytes": -17240064,
"scriptDurationMs": 916.944,
"eventListeners": -14923,
"totalBlockingTimeMs": 86,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4689.916000000039,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.71700000000001,
"layouts": 20,
"layoutDurationMs": 23.345000000000006,
"taskDurationMs": 4596.554999999999,
"heapDeltaBytes": -60063568,
"heapUsedBytes": 179811660,
"domNodes": -8049,
"jsHeapTotalBytes": 17670144,
"scriptDurationMs": 90.15499999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 103,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6102.479000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.84900000000003,
"layouts": 20,
"layoutDurationMs": 22.722000000000005,
"taskDurationMs": 5984.259999999999,
"heapDeltaBytes": -23399244,
"heapUsedBytes": 195884200,
"domNodes": -8049,
"jsHeapTotalBytes": 12988416,
"scriptDurationMs": 107.59699999999998,
"eventListeners": -14923,
"totalBlockingTimeMs": 426,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8394.69399999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8124.180999999999,
"heapDeltaBytes": -4085836,
"heapUsedBytes": 178101392,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 127.77400000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8306.793999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8092.286999999998,
"heapDeltaBytes": -3671644,
"heapUsedBytes": 165160984,
"domNodes": 0,
"jsHeapTotalBytes": -20971520,
"scriptDurationMs": 136.499,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 124.67199999991863,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.669999999999998,
"layouts": 3,
"layoutDurationMs": 1.5900000000000003,
"taskDurationMs": 99.60400000000003,
"heapDeltaBytes": 3163400,
"heapUsedBytes": 65209012,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.717,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 454.72800000004554,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17,
"layouts": 4,
"layoutDurationMs": 1.7020000000000002,
"taskDurationMs": 121.45900000000002,
"heapDeltaBytes": 5033560,
"heapUsedBytes": 67214004,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.179,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since eae75fade8a1553a8603b6f34329de137e9f2b3f
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18090 +/- ##
==========================================
+ Coverage 84.07% 85.00% +0.93%
==========================================
Files 3161 2314 -847
Lines 154575 133459 -21116
Branches 41969 36084 -5885
==========================================
- Hits 129954 113453 -16501
+ Misses 23017 19688 -3329
+ Partials 1604 318 -1286
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 870 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Assessed: not a trivial fix — needs a UX decision firstRoot cause recap (matches the PR description, verified against current
Two candidate approaches, both viable, with different tradeoffs:
The open question for deliberation: should grid-grouping span across intervening status/caption text — i.e., merge even genuinely per-image-captioned assets into one grid, accepting that the individual captions get dropped or relocated — or should it only apply when the interruption itself carries no user-facing text (silent tool calls/thinking), leaving genuinely captioned image sequences as separate entries? The linear tickets (PM-1135/PM-1313) and this PR's "After" language point at the first, but that's a real product-visible change to how captioned batches read, not just a chunking bug fix, so flagging it rather than picking one. No code changes made. Posted per the request in the Slack thread to plan first when the fix isn't obviously trivial. Generated by Claude Code |
|
The Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
Fix commit: 5813adcRoot cause recap (unchanged from the PR description/plan comment):
The fix, entirely in the render path (no transport change needed):
UX interpretation (per the earlier plan comment's open question): the plan flagged two options — (a) make tool-calls transparent but leave genuinely per-image-captioned batches as separate grids, or (b) aggregate every asset in a reply into one grid. The pinned repro fixture captions each asset individually ("Version A:" / "Version B:" ahead of each image), so (a) alone can't make it pass. I went with (b), but scoped narrowly: aggregation only kicks in for a group built from more than one underlying Tests:
Generated by Claude Code |
|
Updating Playwright Expectations |
c0fe4a6 to
5eed95c
Compare
|
Force-pushed with Christian's approval: fix commit rewritten without the agent trailers, plus a small complexity extraction so Full context for agent readersOld head c0fe4a6 failed two checks: New history on the same base merge commit:
The refactor was not run locally (host under a resource hold); CI on this push is the verification. If lint/format flags import ordering I will push a follow-up on this branch. |
|
/update-playwright |
|
Video job flake: masked elapsed-time text. Snapshot regen requested via Full context for agent readersFailure: Fix (54178632ec2dd1f869782076e8aef491dbb7293d): pass Masks change the PNG, so the |
|
/update-playwright |
|
Addressed the remaining P3 at |
|
/update-playwright |
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/agent/agentConversationReplay.spec.ts-snapshots/asset-grid-fragmentation-cloud-linux.png` | modified | 38988B -> 40349B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
|
Final exact cloud baseline regenerated at |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve; the remaining P3 is fixed and no new findings remain.
The stale elapsed-time comment and unnecessary summary mask are gone. The regenerated exact baseline now captures the stable Worked summary and still preserves Version A with the red asset, followed by Version B with the blue asset.
Finding dispositions
- Stale elapsed-time mask comment: fixed by
5c31477f54. - Exact baseline after mask removal: fixed by
c99738f17e; direct inspection confirms the intended summary and caption-to-asset order. - Prior screenshot tolerance and stale baseline: remain fixed. The assertion is exact.
- Prior redundant implementation narratives: remain fixed.
- Prior bare-asset falsifier and title mismatch: remain fixed.
- New findings: none.
Verification
- Focused Vitest: 2 files, 20 tests passed.
- Scoped ESLint, oxfmt, and
git diff --checkpassed. - Exact-head video snapshot, lint, typecheck, and repository checks passed. The cloud Playwright matrix was still running when checked.
- Standard-depth correctness, maintainability, idiomaticity, tests with Playwright and test-design lenses, and documentation lanes found no new issues.
Superseded by DrJKL’s 2026-09-27 fresh-head review: “ready to approve,” all prior findings fixed, exact baseline verified, no new findings. All required and cloud E2E checks passed.
|
1 similar comment
|
…ithout reordering captioned assets (#19079) Backport of #18090 to `core/1.55` Automatically created by backport workflow. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: github-actions <github-actions@github.com>
…without reordering captioned assets (#19080) Backport of #18090 to `cloud/1.55` Automatically created by backport workflow. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: bymyself <abolkonsky.rem@gmail.com>
…9078) Manual completion of the automated backport for #18090. The upstream merge cherry-picks cleanly onto cloud/1.54, including exact component and cloud replay coverage. Justification: release-branch regression fix with exact unit/browser coverage. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com>
) Manual backport of #18090 to core/1.54. The release branch predates the extracted `AgentMessageGroup` and replay-fixture infrastructure, so this ports the applicable grouping/markdown production behavior plus focused component regression tests without resurrecting absent cloud-only files. Justification: release-branch regression fix with focused unit coverage. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com>
Requested by Christian Byrne · Slack thread
Before / After
Before: when a batch reply contains multiple generated assets, any tool call or thinking step that falls between two assets breaks the reply's grid into separate fullwidth blocks stacked in one column, instead of the intended grid.
After: assets in one reply that are actually adjacent (no caption or other prose between them) render in a single grid, regardless of tool calls/thinking interleaved while they were generated. A caption between two assets still keeps that asset in its own group, directly beside its own caption, in the reply's original order — combining a fragmented batch into one grid never moves an asset away from its caption or out of order.
Root cause (verified, not re-derived)
src/workbench/extensions/agent/services/agent/agentEventTransport.tscloses the currently-openTextPart(closeOpenText()) on everyagent_thinking/agent_tool_call/agent_active_tab/agent_askevent, and opens a fresh one on the nextagent_message_delta. A batch of assets separated by a tool call or thinking step therefore ends up as N separateTextParts.agentMessageGroup.ts'sgroupMessagePartsnow folds consecutiveTextParts that are only separated bytool/thinkingparts into one text group, soAgentMessageGroup.vuerenders them joined through a singleMarkdownStreaminstead of one per fragment.MarkdownStream.vue's segment builder already coalesces standalone assets that end up adjacent (no prose between them, even across the originalTextPartboundary) into oneReplyAssetGroup— this fixes the base PM-1135 case (two tool-separated images, no captions).What this PR fixes
An earlier revision of this branch additionally special-cased "multi-
TextPart" replies inMarkdownStream.vue: it collected every asset in the merged group into a side array and appended them all as one trailing grid, regardless of the prose between them. That broke caption/asset pairing and content order — a caption between two assets (e.g.Version A:/Version B:) rendered both captions together above a merged gallery instead of each above its own image, and a lone asset followed by unrelated prose ("The preview above failed to render.") rendered after that prose instead of before it.This PR removes that special case. The per-position segment builder that already existed for a single
TextParthandles the merged, multi-TextParttext exactly the same way: it flushes prose, then pushes an asset segment, merging it into the previous segment only when that previous segment is also an asset segment (i.e. truly adjacent, nothing in between). That is sufficient to combine a fragmented batch into one grid whenever there's nothing between the assets, and it never needs to move an asset out of its original position to do so. Also removed the now-deadaggregateAssetsprop this required, and theagentMessageGroup.tshasActivityparameter that duplicated information already recoverable fromparts(its only caller already computes it from the same array).Scope: "combining a fragmented batch" only ever matters when the transport actually produced multiple
TextParts for one reply (i.e. a tool call or thinking step landed between generated assets). A caption alone, with no tool call/thinking step between assets, never creates multipleTextParts — it already lives inside oneTextPart, where a caption between two assets has always prevented ordinary adjacent-asset coalescing. That single-TextPartbehavior is unchanged.See linear.app/comfyorg/issue/PM-1135 (parent PM-1313).
Test Plan
AgentMessage.assetGridFragmentation.test.ts) — rewrote the low-level regression to useVersion A:/Version B:captions (matching the real PM-1135 fixture) instead of two bare images, so it actually exercises caption/asset pairing rather than passing on adjacency alone; queries a stabledata-testid="reply-asset-group"instead of a[class*="grid-cols-"]DOM/Tailwind traversal. Added a companion case for a single asset followed by later, unrelated prose. Verified both fail against the pre-fix code and pass at this head.agentConversationReplay.spec.ts) — replays the fixture through the real chat panel; kept the image-count assertion and the screenshot, dropped the redundantgrid-cols-*DOM oracle now that the component test owns exact containment. Trimmed the fixture's workflow seed to the smallest valid empty workflow (the scenario has no graph operations).pnpm lint,pnpm typecheck,pnpm test:unitclean on the changed files.🤖 Generated with Claude Code
https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1
Generated by Claude Code