Repository navigation
fix(groupNode): pair widget values to their originating node during subgraph conversion - #18596
Conversation
…ubgraph conversion convertToNodes() matched inner-node widgets to the group node's outer widgets by name alone (Array.findIndex), which always resolves to the first widget with a given name. When two inner nodes end up exposing an outer widget with the same name (e.g. two CLIPTextEncode nodes both named `text`), every later widget with that name silently reads the first one's value/index, misassigning values such as denoise/ filename_prefix on conversion. Add findUnconsumedWidgetIndex(), which consumes each matched outer widget index at most once, in the same node-by-node order the inner nodes are unpacked, so a shared name can no longer resolve to the wrong node's widget. Un-pin the regression test in groupNode.spec.ts (removes test.fail()) now that the underlying defect from PR #17464 is fixed, and add unit tests covering the ambiguous-pairing scenario directly.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2140 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fef4b2ba929ccf2f1987bb9666b3a8d786b36de0
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzip 🔴 +271 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.99 MB (baseline 3.99 MB) • 🟢 -735 BStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 576 kB (baseline 576 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • 🔴 +1.76 kBBundles that do not match a named category
Status: 74 added / 74 removed / 227 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T05:06:26.550Z",
"gitSha": "41527c8cde2735cb85f29ff8f410105a7ead2c66",
"branch": "fix/group-node-widget-pairing",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2030.3919999998925,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8339999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.703,
"heapDeltaBytes": -7908284,
"heapUsedBytes": 54561492,
"domNodes": 0,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.047,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2018.8980000000356,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.8330000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.83299999999997,
"heapDeltaBytes": 13322332,
"heapUsedBytes": 75619044,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.307,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.462999999986,
"styleRecalcs": 69,
"styleRecalcDurationMs": 20.379,
"layouts": 12,
"layoutDurationMs": 5.138,
"taskDurationMs": 931.1869999999999,
"heapDeltaBytes": -1484572,
"heapUsedBytes": 65791668,
"domNodes": -228,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 164.06699999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1885.018999999943,
"styleRecalcs": 72,
"styleRecalcDurationMs": 19.99,
"layouts": 12,
"layoutDurationMs": 5.1259999999999994,
"taskDurationMs": 928.8380000000001,
"heapDeltaBytes": 2185736,
"heapUsedBytes": 64715996,
"domNodes": -228,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 171.85,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.4890000000523,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.985000000000001,
"layouts": 6,
"layoutDurationMs": 1.451,
"taskDurationMs": 364.03200000000004,
"heapDeltaBytes": 2376064,
"heapUsedBytes": 63432712,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 13.861000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.1419999999762,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.838,
"layouts": 6,
"layoutDurationMs": 1.421,
"taskDurationMs": 349.143,
"heapDeltaBytes": 2068768,
"heapUsedBytes": 63119976,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.517999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 731.7420000000538,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.1530000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.50800000000004,
"heapDeltaBytes": 18511724,
"heapUsedBytes": 80735960,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 176.13899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 739.3540000000485,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.33,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.676,
"heapDeltaBytes": 19381380,
"heapUsedBytes": 80376900,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 171.982,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1190.2979999999843,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 883.216,
"heapDeltaBytes": -14281936,
"heapUsedBytes": 72074552,
"domNodes": -259,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 69.14499999999998,
"eventListeners": -185,
"totalBlockingTimeMs": 528,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1223.842999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 899.522,
"heapDeltaBytes": 8144628,
"heapUsedBytes": 95984116,
"domNodes": -259,
"jsHeapTotalBytes": 23744512,
"scriptDurationMs": 65.66999999999999,
"eventListeners": -185,
"totalBlockingTimeMs": 592,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.4349999999331,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.2150000000006,
"heapDeltaBytes": 15081412,
"heapUsedBytes": 91458984,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.50999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 873.9480000000412,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.093,
"heapDeltaBytes": 16076436,
"heapUsedBytes": 92741828,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.476,
"eventListeners": 0,
"totalBlockingTimeMs": 236,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9918.667000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8848.862000000001,
"heapDeltaBytes": -1407960,
"heapUsedBytes": 73972108,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7042.841,
"eventListeners": 0,
"totalBlockingTimeMs": 590,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10462.098999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9501.959,
"heapDeltaBytes": 12447512,
"heapUsedBytes": 95131796,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 7672.116,
"eventListeners": 0,
"totalBlockingTimeMs": 768,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9727.86400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8823.838,
"heapDeltaBytes": 5031596,
"heapUsedBytes": 81282832,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7098.683,
"eventListeners": 0,
"totalBlockingTimeMs": 370,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10499.094000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9577.749,
"heapDeltaBytes": -7822680,
"heapUsedBytes": 69700300,
"domNodes": -228,
"jsHeapTotalBytes": 2088960,
"scriptDurationMs": 7731.553,
"eventListeners": -164,
"totalBlockingTimeMs": 644,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2038.1589999999505,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.022999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 691.794,
"heapDeltaBytes": 2388828,
"heapUsedBytes": 83186268,
"domNodes": -228,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 35.976000000000006,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.9830000000538,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7249999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.522,
"heapDeltaBytes": 2036924,
"heapUsedBytes": 83152456,
"domNodes": -228,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 38.956,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2986.7120000000114,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.642000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1835.039,
"heapDeltaBytes": 6557464,
"heapUsedBytes": 94374468,
"domNodes": -228,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 956.819,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2464.652000000001,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.681999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1674.7329999999997,
"heapDeltaBytes": 3038168,
"heapUsedBytes": 85218780,
"domNodes": -228,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 836.442,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3919.0949999999702,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.397,
"layouts": 60,
"layoutDurationMs": 17.256,
"taskDurationMs": 1836.6220000000003,
"heapDeltaBytes": 11711536,
"heapUsedBytes": 94589664,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 847.596,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3853.3140000000685,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.76,
"layouts": 60,
"layoutDurationMs": 16.528,
"taskDurationMs": 1804.985,
"heapDeltaBytes": 8837376,
"heapUsedBytes": 74702452,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 829.837,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3126.944999999978,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.894000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1994.3490000000002,
"heapDeltaBytes": 23557420,
"heapUsedBytes": 89722292,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1011.9850000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3218.350999999984,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.5,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2107.349,
"heapDeltaBytes": -9365904,
"heapUsedBytes": 81495736,
"domNodes": -228,
"jsHeapTotalBytes": 6737920,
"scriptDurationMs": 1051.499,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2026.886999999988,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.808999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.6990000000001,
"heapDeltaBytes": -14307340,
"heapUsedBytes": 73953020,
"domNodes": -228,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 36.591,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2001.177000000098,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.6360000000000021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.006,
"heapDeltaBytes": 19630716,
"heapUsedBytes": 84529460,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.19899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 659.1799999999921,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.994999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.68699999999995,
"heapDeltaBytes": 13861144,
"heapUsedBytes": 77491272,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 153.477,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 672.0970000000079,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.885999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.777,
"heapDeltaBytes": 13491056,
"heapUsedBytes": 76998236,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 151.29199999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.9790000000112,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.013000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.787,
"heapDeltaBytes": 8485736,
"heapUsedBytes": 72265680,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.200999999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.466999999906,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.483,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.854,
"heapDeltaBytes": 7302388,
"heapUsedBytes": 69958996,
"domNodes": -244,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 8.097999999999997,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.7339999999222,
"styleRecalcs": 59,
"styleRecalcDurationMs": 19.205999999999996,
"layouts": 16,
"layoutDurationMs": 6.533999999999999,
"taskDurationMs": 832.3950000000001,
"heapDeltaBytes": 15090588,
"heapUsedBytes": 78314908,
"domNodes": -244,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 118.542,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1733.528999999976,
"styleRecalcs": 72,
"styleRecalcDurationMs": 20.175,
"layouts": 16,
"layoutDurationMs": 6.8660000000000005,
"taskDurationMs": 842.136,
"heapDeltaBytes": 8589964,
"heapUsedBytes": 72269772,
"domNodes": -244,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 117.916,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1033.311000000026,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.104000000000006,
"layouts": 5,
"layoutDurationMs": 12.672000000000002,
"taskDurationMs": 790.2520000000002,
"heapDeltaBytes": -6261732,
"heapUsedBytes": 82180224,
"domNodes": 13667,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 26.790999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9768.350000000055,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.524,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6321.523,
"heapDeltaBytes": 3976216,
"heapUsedBytes": 84688516,
"domNodes": -228,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 2955.028,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8900.138000000083,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.218,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6073.463000000001,
"heapDeltaBytes": 3876540,
"heapUsedBytes": 85012588,
"domNodes": -228,
"jsHeapTotalBytes": 1269760,
"scriptDurationMs": 2838.704,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18184.933999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18025.518,
"heapDeltaBytes": -30490388,
"heapUsedBytes": 183932244,
"domNodes": -8053,
"jsHeapTotalBytes": -11866112,
"scriptDurationMs": 298.42100000000005,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18016.03,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17615.428,
"heapDeltaBytes": -53074436,
"heapUsedBytes": 169050008,
"domNodes": -8049,
"jsHeapTotalBytes": -14737408,
"scriptDurationMs": 315.377,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21953.19799999993,
"styleRecalcs": 153,
"styleRecalcDurationMs": 21.44099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21823.107999999997,
"heapDeltaBytes": -49269492,
"heapUsedBytes": 191658256,
"domNodes": -8049,
"jsHeapTotalBytes": -19931136,
"scriptDurationMs": 895.25,
"eventListeners": -14923,
"totalBlockingTimeMs": 149,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 23561.302999999953,
"styleRecalcs": 177,
"styleRecalcDurationMs": 26.278999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23487.664,
"heapDeltaBytes": -49417868,
"heapUsedBytes": 169999176,
"domNodes": -8049,
"jsHeapTotalBytes": -17047552,
"scriptDurationMs": 963.4759999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 285,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6622.904999999946,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.90100000000002,
"layouts": 20,
"layoutDurationMs": 26.375999999999998,
"taskDurationMs": 6594.013,
"heapDeltaBytes": -40634456,
"heapUsedBytes": 180094796,
"domNodes": -8049,
"jsHeapTotalBytes": 7401472,
"scriptDurationMs": 126.058,
"eventListeners": -14923,
"totalBlockingTimeMs": 469,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6565.804999999955,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.77,
"layouts": 20,
"layoutDurationMs": 26.64999999999999,
"taskDurationMs": 6533.292,
"heapDeltaBytes": -64576412,
"heapUsedBytes": 176884824,
"domNodes": -8049,
"jsHeapTotalBytes": 19066880,
"scriptDurationMs": 125.927,
"eventListeners": -14923,
"totalBlockingTimeMs": 489,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9049.462999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9005.815999999999,
"heapDeltaBytes": 18211932,
"heapUsedBytes": 198969616,
"domNodes": 0,
"jsHeapTotalBytes": -21233664,
"scriptDurationMs": 145.43699999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9247.716000000082,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9220.143999999998,
"heapDeltaBytes": -2878404,
"heapUsedBytes": 191310840,
"domNodes": 0,
"jsHeapTotalBytes": -28835840,
"scriptDurationMs": 162.54199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 491.1329999999907,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.615000000000002,
"layouts": 4,
"layoutDurationMs": 2.205,
"taskDurationMs": 149.494,
"heapDeltaBytes": 5211984,
"heapUsedBytes": 67257032,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.654999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 124.94200000003275,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.761999999999999,
"layouts": 3,
"layoutDurationMs": 1.916,
"taskDurationMs": 90.68500000000002,
"heapDeltaBytes": 3047876,
"heapUsedBytes": 65251524,
"domNodes": 94,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.897000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18596 +/- ##
==========================================
+ Coverage 83.76% 84.97% +1.21%
==========================================
Files 3020 2310 -710
Lines 149241 133253 -15988
Branches 38583 36485 -2098
==========================================
- Hits 125016 113236 -11780
+ Misses 22920 19699 -3221
+ Partials 1305 318 -987
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 910 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
|
CI is red on this PR: exactly one real (non-flaky, reproducible across both the I haven't been able to pin down the exact failing assertion yet: this environment's network policy blocks the raw GitHub Actions log download (redirects to Azure Blob Storage) and the deployed Cloudflare Pages HTML reports, so I can't read the failure detail directly from here. I attempted to independently reproduce the described "duplicate widget name" defect (two Still investigating. Will follow up here once I can see the actual assertion diff (or once someone with unrestricted access to https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35849292975 can share it). Generated by Claude Code |
…-pairing # Conflicts: # src/extensions/core/groupNode.test.ts
processWidgetInputs rejected any input spec whose type was expressed as a combo options array (e.g. sampler_name/scheduler), routing them through processInputSlots instead of the widget path. processInputSlots then looked up each of those slots' internal links by their position in the filtered slots array rather than their real input-slot index, so an unrelated linked input's link got matched instead. For KSampler this caused sampler_name/scheduler to be dropped from the group node type entirely, shifting every later widget value by two positions on conversion (denoise received sampler_name's value, filename_prefix received scheduler's). Fix isValidSpec to accept the combo-array form, and look up each slot's real index by name before consulting linksTo. Adds a regression test against the real group_node_v1.3.3 fixture that pins this exact misalignment.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 3 |
| 🟢 Low | 3 |
Panel: 8/8 reviewers contributed findings.
… review
Cursor review on this PR surfaced several correctness gaps in the widget
pairing fix:
- convertToNodes() marked an outer widget index consumed before
confirming its value was actually copied, so a bail (missing inner
widget, or a PrimitiveNode with fewer outer widgets than expected)
could permanently burn an index a later inner node legitimately
needed. The index is now only marked consumed once the copy succeeds.
- processInputSlots() resolved an inner input's link purely by matching
the synthesized def's input name against the live node's slot name.
This regressed Reroute nodes, whose actual slot is unnamed
(addInput('', '*')) while its synthesized def is keyed by type (e.g.
'MODEL') - the name lookup always missed, so an internally-linked
Reroute input was wrongly exposed as an external group input. Falls
back to the old positional index when the name lookup misses.
- processWidgetInputs() treated every combo-typed input as a widget,
even when it declared forceInput: true, which should always take the
socket path (matching the rule litegraphService applies when actually
building the node).
- processConvertedWidgets() resolved a converted widget's internal link
positionally (slots.length + i) instead of by its own real serialized
slot index (already tracked as the key in the `converted` map),
disagreeing with processWidgetInputs() about how linksTo is keyed.
- Strengthened the KSampler/SaveImage fixture-based unit test: every
asserted value except seed happened to equal that widget's own
node-def default, so the test couldn't tell a real copy from the
value being left untouched. It now edits the live outer widget values
before conversion so only a real copy produces a match.
|
Self-review follow-up: strengthened the real fixture test to assert both colliding CLIPTextEncode prompt values by stable node order. The two accepted lower-severity residual risks are now tracked in FE-3035 with concrete acceptance criteria; they do not block the primary 1.54 corruption fix. |
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the current head including combo/forceInput handling, serialized slot indexing, Reroute fallback, consumption timing, real-fixture propagation, and distinct colliding prompt assertions. Accepted residuals are tracked in FE-3035. CI is still completing on the exact head.
|
1 similar comment
|
…inating node during subgraph conversion (#18596) (#19065) Manual backport of #18596 after conflicts in all three changed files. Resolution preserves the newer `core/1.54` group-node test/mocking architecture and branch-specific `nodeInputs` changes while applying the production fixes. The main-only real-fixture unit harness was replaced with focused release-branch unit coverage; the existing browser regression was retained. Verification: - `pnpm vitest run src/extensions/core/groupNode.test.ts` (22/22) - pre-commit format, oxlint, eslint, `typecheck:app`, and `typecheck:browser` all passed - full browser regression runs in CI Original merge: 8ec223d
|
|
|
|
|
|
…ginating node during subgraph conversion (#18596) (#19141) Manual backport of #18596 to `cloud/1.55`. The source fix and browser regression test are preserved. The conflicting main-only real-fixture unit harness was adapted to the branch-native test architecture with focused widget-collision tests. Verified locally: app and browser typechecks pass. The identical adapted test patch passed 25/25 on `core/1.55`; the cloud rerun is delegated to CI because this checkout’s cached reka-ui 2.6.2 package is missing published runtime entrypoints.
…inating node during subgraph conversion (#18596) (#19140) Manual backport of #18596 to `core/1.55`. The source fix and browser regression test are preserved. The conflicting main-only real-fixture unit harness was adapted to the branch-native test architecture with focused widget-collision tests. Verified locally: 25/25 targeted unit tests, app typecheck, browser typecheck, formatting, oxlint, and ESLint.
Requested by Christian Byrne · Slack thread
Summary
Fixes a data-corruption bug where loading a legacy group node and letting it auto-convert to a subgraph could silently misassign widget values between inner nodes that share a widget name.
Changes
Before: When a legacy group node is loaded, it's automatically unpacked into its constituent nodes inside a subgraph (
GroupNodeHandler.convertToNodes()insrc/extensions/core/groupNode.ts). That code paired each inner node's widget to the group node's own outer widget by searchingnode.widgetsfor a matching name (Array.findIndex). If two inner nodes ended up exposing an outer widget with the same name (e.g. twoCLIPTextEncodenodes both namedtext), the search always resolved to the first widget with that name, so a later widget could silently read the wrong value. QA reported this concretely on agroup_node_v1.3.3fixture: after conversion,KSampler.denoisecame back as'euler'instead of1, andSaveImage.filename_prefixcame back as'normal'instead of'ComfyUI'. Saving the workflow then wrote those wrong values back to disk. This was pinned as a known, expected-to-fail regression test (test.fail()) inbrowser_tests/tests/groupNode.spec.ts, added in #17464.After: Widget lookups during conversion no longer rely on name matching alone. A new helper,
findUnconsumedWidgetIndex(), resolves each requested widget name to an outer widget index while tracking which indices have already been consumed (in aSetshared across the whole conversion), so a name that happens to be shared between two inner nodes' widgets can no longer resolve twice to the same outer widget. The regression test ingroupNode.spec.tsforPreserves group node widget values through subgraph conversionhastest.fail()removed since the underlying defect is fixed.How:
convertToNodes()'s widget-copy loop iterates inner nodes in the same order they were originally declared in the group (nodeData.nodesorder).findUnconsumedWidgetIndex()walks the outer node's widgets, skipping any index already recorded in aconsumedOuterWidgetIndicesset, and returns the first remaining widget whose name matches; that index is then marked consumed before moving on (including all indices touched by a multi-widgetPrimitiveNodecopy). This keeps each widget paired to the widget belonging to its own originating node, in order, rather than resolving to whichever same-named widget happens to come first in the array. Added unit tests insrc/extensions/core/groupNode.test.tsexercisefindUnconsumedWidgetIndex()directly against a deliberate name collision to prove the pairing is now unambiguous.Fixes the defect pinned in #17464 (#17464).
Review Focus
I could not run the Playwright/browser suite against a live ComfyUI backend in the environment this fix was written in (no Docker daemon available to stand up the CI container), so the pinned E2E test (
Preserves group node widget values through subgraph conversion) has not been executed end-to-end here — please let CI confirm it now passes.pnpm typecheck:app,pnpm typecheck:browser,eslint, and thegroupNode.test.tsunit suite (22 tests, including the new ones) all pass locally.Generated by Claude Code