Repository navigation
[backport core/1.55] fix(agent): combine adjacent fragmented assets without reordering captioned assets - #19079
Conversation
…tioned assets (#18090) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729?thread_ts=1789700733.927729&cid=C0BGH348Z0C)_ ## Before / After **Before:** when a batch reply contains multiple generated assets, any tool call or thinking step that falls between two assets breaks the reply's grid into separate fullwidth blocks stacked in one column, instead of the intended grid. **After:** assets in one reply that are actually adjacent (no caption or other prose between them) render in a single grid, regardless of tool calls/thinking interleaved while they were generated. A caption between two assets still keeps that asset in its own group, directly beside its own caption, in the reply's original order — combining a fragmented batch into one grid never moves an asset away from its caption or out of order. ## Root cause (verified, not re-derived) - `src/workbench/extensions/agent/services/agent/agentEventTransport.ts` closes the currently-open `TextPart` (`closeOpenText()`) on every `agent_thinking` / `agent_tool_call` / `agent_active_tab` / `agent_ask` event, and opens a fresh one on the next `agent_message_delta`. A batch of assets separated by a tool call or thinking step therefore ends up as N separate `TextPart`s. - `agentMessageGroup.ts`'s `groupMessageParts` now folds consecutive `TextPart`s that are only separated by `tool`/`thinking` parts into one text group, so `AgentMessageGroup.vue` renders them joined through a single `MarkdownStream` instead of one per fragment. - Within that joined text, `MarkdownStream.vue`'s segment builder already coalesces standalone assets that end up adjacent (no prose between them, even across the original `TextPart` boundary) into one `ReplyAssetGroup` — this fixes the base PM-1135 case (two tool-separated images, no captions). ## What this PR fixes An earlier revision of this branch additionally special-cased "multi-`TextPart`" replies in `MarkdownStream.vue`: it collected every asset in the merged group into a side array and appended them all as one trailing grid, regardless of the prose between them. That broke caption/asset pairing and content order — a caption between two assets (e.g. `Version A:` / `Version B:`) rendered both captions together above a merged gallery instead of each above its own image, and a lone asset followed by unrelated prose (`"The preview above failed to render."`) rendered after that prose instead of before it. This PR removes that special case. The per-position segment builder that already existed for a single `TextPart` handles the merged, multi-`TextPart` text exactly the same way: it flushes prose, then pushes an asset segment, merging it into the previous segment only when that previous segment is *also* an asset segment (i.e. truly adjacent, nothing in between). That is sufficient to combine a fragmented batch into one grid whenever there's nothing between the assets, and it never needs to move an asset out of its original position to do so. Also removed the now-dead `aggregateAssets` prop this required, and the `agentMessageGroup.ts` `hasActivity` parameter that duplicated information already recoverable from `parts` (its only caller already computes it from the same array). **Scope:** "combining a fragmented batch" only ever matters when the transport actually produced multiple `TextPart`s for one reply (i.e. a tool call or thinking step landed between generated assets). A caption alone, with no tool call/thinking step between assets, never creates multiple `TextPart`s — it already lives inside one `TextPart`, where a caption between two assets has always prevented ordinary adjacent-asset coalescing. That single-`TextPart` behavior is unchanged. See linear.app/comfyorg/issue/PM-1135 (parent PM-1313). ## Test Plan - **Vitest** (`AgentMessage.assetGridFragmentation.test.ts`) — rewrote the low-level regression to use `Version A:` / `Version B:` captions (matching the real PM-1135 fixture) instead of two bare images, so it actually exercises caption/asset pairing rather than passing on adjacency alone; queries a stable `data-testid="reply-asset-group"` instead of a `[class*="grid-cols-"]` DOM/Tailwind traversal. Added a companion case for a single asset followed by later, unrelated prose. Verified both fail against the pre-fix code and pass at this head. - **Playwright** (`agentConversationReplay.spec.ts`) — replays the fixture through the real chat panel; kept the image-count assertion and the screenshot, dropped the redundant `grid-cols-*` DOM oracle now that the component test owns exact containment. Trimmed the fixture's workflow seed to the smallest valid empty workflow (the scenario has no graph operations). - `pnpm lint`, `pnpm typecheck`, `pnpm test:unit` clean on the changed files. - [ ] CI screenshot baseline needs regeneration for the corrected layout (applying the "New Browser Test Expectations" label). 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1 --- _Generated by [Claude Code](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: github-actions <github-actions@github.com>
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2120 passed, 0 failed · 2 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 86006a8d8549789563ab6e6f9d45ede3dad4239d
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T08:25:47.485Z",
"gitSha": "50dc70431cac7726d966a2ccdd03dc615cc24832",
"branch": "backport-18090-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.292999999957,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.928,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 259.46799999999996,
"heapDeltaBytes": -5022940,
"heapUsedBytes": 62481176,
"domNodes": -257,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 5.071999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1993.6720000000037,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.932999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 262.124,
"heapDeltaBytes": -12445752,
"heapUsedBytes": 55304680,
"domNodes": -256,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 5.002000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.075000000002,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.751000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.01599999999996,
"heapDeltaBytes": -5363932,
"heapUsedBytes": 62545888,
"domNodes": -257,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 87.76500000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.5600000000281,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.427,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.498,
"heapDeltaBytes": -6485928,
"heapUsedBytes": 61080008,
"domNodes": -257,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 89.468,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.653000000007,
"styleRecalcs": 28,
"styleRecalcDurationMs": 9.177999999999999,
"layouts": 6,
"layoutDurationMs": 0.895,
"taskDurationMs": 181.196,
"heapDeltaBytes": 2787616,
"heapUsedBytes": 70207400,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.766000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1689.9009999999635,
"styleRecalcs": 28,
"styleRecalcDurationMs": 9.652000000000001,
"layouts": 6,
"layoutDurationMs": 0.8779999999999999,
"taskDurationMs": 184.566,
"heapDeltaBytes": 3147816,
"heapUsedBytes": 70648604,
"domNodes": 78,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7.2090000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 397.0560000000205,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.151,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 272.40799999999996,
"heapDeltaBytes": 18667484,
"heapUsedBytes": 86095592,
"domNodes": 25,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 103.158,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 409.3440000000328,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.077000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 270.77399999999994,
"heapDeltaBytes": 18918996,
"heapUsedBytes": 86562900,
"domNodes": 25,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 98.135,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 860.0230000000124,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.292,
"heapDeltaBytes": -16931740,
"heapUsedBytes": 73059544,
"domNodes": -292,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 33.545,
"eventListeners": -217,
"totalBlockingTimeMs": 247,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 859.8920000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.552,
"heapDeltaBytes": -17138576,
"heapUsedBytes": 72821232,
"domNodes": -291,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 36.452999999999996,
"eventListeners": -217,
"totalBlockingTimeMs": 253,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 671.5039999999703,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 237.42600000000013,
"heapDeltaBytes": 14308448,
"heapUsedBytes": 91102624,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 80.295,
"eventListeners": 0,
"totalBlockingTimeMs": 77,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 688.0719999999769,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 256.2870000000004,
"heapDeltaBytes": 14452052,
"heapUsedBytes": 91347804,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 85.379,
"eventListeners": 0,
"totalBlockingTimeMs": 79,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5553.079000000025,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.131,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4614.843,
"heapDeltaBytes": -8749968,
"heapUsedBytes": 73302652,
"domNodes": -12,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 3628.388,
"eventListeners": 0,
"totalBlockingTimeMs": 15,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5785.00200000002,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.9999999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4810.741,
"heapDeltaBytes": 10214472,
"heapUsedBytes": 92558308,
"domNodes": -14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 3815.6760000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5998.676999999987,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.559999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4970.738,
"heapDeltaBytes": 9640616,
"heapUsedBytes": 87815584,
"domNodes": -260,
"jsHeapTotalBytes": 14934016,
"scriptDurationMs": 3973.649,
"eventListeners": -174,
"totalBlockingTimeMs": 11,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5725.248000000021,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.613999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4674.843,
"heapDeltaBytes": 8307956,
"heapUsedBytes": 85486008,
"domNodes": -263,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 3756.374,
"eventListeners": -174,
"totalBlockingTimeMs": 15,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2016.570999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.340999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.10499999999996,
"heapDeltaBytes": -2553164,
"heapUsedBytes": 83606312,
"domNodes": -235,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 16.136999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2008.7550000000078,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.763999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.38100000000003,
"heapDeltaBytes": 2240204,
"heapUsedBytes": 81522400,
"domNodes": -241,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 26.74599999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2118.6500000000024,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.036999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 985.3210000000001,
"heapDeltaBytes": -12181604,
"heapUsedBytes": 67921284,
"domNodes": -209,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 533.587,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2129.697999999962,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.381000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1013.568,
"heapDeltaBytes": -7373060,
"heapUsedBytes": 80040292,
"domNodes": -208,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 538.3059999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3172.803999999985,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.443999999999999,
"layouts": 60,
"layoutDurationMs": 13.694999999999999,
"taskDurationMs": 1108.1239999999998,
"heapDeltaBytes": -14831816,
"heapUsedBytes": 73735220,
"domNodes": -242,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 512.854,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3066.5160000000355,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.758,
"layouts": 60,
"layoutDurationMs": 13.11,
"taskDurationMs": 1050.458,
"heapDeltaBytes": -15527404,
"heapUsedBytes": 73120344,
"domNodes": -246,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 473.40600000000006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2212.982000000011,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1200.963,
"heapDeltaBytes": -16706036,
"heapUsedBytes": 73950980,
"domNodes": -239,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 601.572,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2279.6639999999684,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.770999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1215.227,
"heapDeltaBytes": 16963748,
"heapUsedBytes": 83078080,
"domNodes": 14,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 626.625,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.7430000000195,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.425,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.40999999999997,
"heapDeltaBytes": -4260436,
"heapUsedBytes": 84126120,
"domNodes": -236,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 24.827999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 1990.9720000000561,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.404000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 275.35800000000006,
"heapDeltaBytes": 19789008,
"heapUsedBytes": 86499464,
"domNodes": 16,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.211000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 361.18300000003956,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.713999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 240.87599999999998,
"heapDeltaBytes": 13423420,
"heapUsedBytes": 83490552,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 88.85600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 365.09300000000167,
"styleRecalcs": 49,
"styleRecalcDurationMs": 8.974999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 235.078,
"heapDeltaBytes": 13796144,
"heapUsedBytes": 76894456,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 86.578,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1993.421000000012,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.998000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 261.598,
"heapDeltaBytes": -1020724,
"heapUsedBytes": 62211700,
"domNodes": -272,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 4.733999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.7220000000052,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.173,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 257.696,
"heapDeltaBytes": -6560956,
"heapUsedBytes": 63455636,
"domNodes": -271,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 5.080999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.9509999999937,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.295999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.288,
"heapDeltaBytes": -5968460,
"heapUsedBytes": 57190372,
"domNodes": -271,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 72.393,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.6779999999908,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.212999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.34899999999993,
"heapDeltaBytes": -7428668,
"heapUsedBytes": 62755000,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 71.23199999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 750.4279999999994,
"styleRecalcs": 18,
"styleRecalcDurationMs": 17.298000000000002,
"layouts": 5,
"layoutDurationMs": 7.174000000000001,
"taskDurationMs": 501.48800000000006,
"heapDeltaBytes": -6286284,
"heapUsedBytes": 81135180,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 17.022999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 48,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8207.781999999952,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.369,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3315.491,
"heapDeltaBytes": 4959704,
"heapUsedBytes": 84165192,
"domNodes": -236,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 1669.649,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8137.846000000025,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.718999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3468.787,
"heapDeltaBytes": -14164336,
"heapUsedBytes": 72277152,
"domNodes": -207,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 1819.241,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10432.781000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9545.539,
"heapDeltaBytes": -13143660,
"heapUsedBytes": 202807016,
"domNodes": -8062,
"jsHeapTotalBytes": -8970240,
"scriptDurationMs": 127.54599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10063.536999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8968.944000000001,
"heapDeltaBytes": -37155048,
"heapUsedBytes": 185497464,
"domNodes": -8062,
"jsHeapTotalBytes": -14475264,
"scriptDurationMs": 115.871,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 13310.033999999974,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.951999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12917.611,
"heapDeltaBytes": -31441440,
"heapUsedBytes": 194200924,
"domNodes": -8062,
"jsHeapTotalBytes": -16592896,
"scriptDurationMs": 542.673,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13075.87000000001,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.578000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12582.075,
"heapDeltaBytes": -44894444,
"heapUsedBytes": 191652160,
"domNodes": -8062,
"jsHeapTotalBytes": -20459520,
"scriptDurationMs": 556.547,
"eventListeners": -14928,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 2999.9819999999886,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.319,
"layouts": 20,
"layoutDurationMs": 17.448999999999998,
"taskDurationMs": 2921.3639999999996,
"heapDeltaBytes": -22208180,
"heapUsedBytes": 193469180,
"domNodes": -8062,
"jsHeapTotalBytes": 23535616,
"scriptDurationMs": 46.684,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3796.455999999921,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.093999999999994,
"layouts": 20,
"layoutDurationMs": 17.447000000000003,
"taskDurationMs": 3693.2029999999995,
"heapDeltaBytes": -24485804,
"heapUsedBytes": 198047968,
"domNodes": -8062,
"jsHeapTotalBytes": 23011328,
"scriptDurationMs": 57.149,
"eventListeners": -14928,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5220.9589999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4777.131,
"heapDeltaBytes": -10263608,
"heapUsedBytes": 184906236,
"domNodes": 0,
"jsHeapTotalBytes": -33816576,
"scriptDurationMs": 60.363,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5263.711999999941,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4653.409999999999,
"heapDeltaBytes": 17882608,
"heapUsedBytes": 204518928,
"domNodes": 0,
"jsHeapTotalBytes": -29884416,
"scriptDurationMs": 62.597999999999985,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 417.6970000000324,
"styleRecalcs": 16,
"styleRecalcDurationMs": 18.913,
"layouts": 4,
"layoutDurationMs": 2.7030000000000003,
"taskDurationMs": 89.759,
"heapDeltaBytes": 5067308,
"heapUsedBytes": 70295888,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.018,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 421.436999999969,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.808,
"layouts": 4,
"layoutDurationMs": 1.649,
"taskDurationMs": 87.00300000000001,
"heapDeltaBytes": 4998676,
"heapUsedBytes": 67144932,
"domNodes": 150,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.958,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
@coderabbitai review |
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #19079 +/- ##
=============================================
+ Coverage 84.60% 84.61% +0.01%
=============================================
Files 2298 2299 +1
Lines 131671 131812 +141
Branches 35560 33705 -1855
=============================================
+ Hits 111403 111537 +134
- Misses 19954 19956 +2
- Partials 314 319 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
/update-playwright |
|
Updating Playwright Expectations |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/agent/agentConversationReplay.spec.ts-snapshots/asset-grid-fragmentation-cloud-linux.png` | modified | 40349B -> 39880B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
|
Updating Playwright Expectations |
christian-byrne
left a comment
There was a problem hiding this comment.
Verified against #18090 before approving: identical file list, no conflict markers in the diff. All three required checks green.
Backport of #18090 to
core/1.55Automatically created by backport workflow.