Skip to content

[backport cloud/1.54] Fix duplicate-name stale workflow binding resolution - #18723

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-18155-to-cloud-1.54
Sep 25, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-18155-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #18155 to cloud/1.54

Automatically created by backport workflow.

## Summary

Reject stale Agent workflow bindings when the target ID has a duplicated
cloud name instead of resolving the unrelated saved tab and graph.

## Changes

- **What**: Resolve ID-to-name identity from the full cloud index while
retaining the duplicate-filtered name-to-ID inference map. Add
fresh-store regressions for both resolver entry points and a browser
scenario with duplicate target IDs plus a uniquely named saved
`Portrait` tab.
- **Dependencies**: None.

## Review Focus

The lookup is intentionally asymmetric: duplicated names remain unsafe
for name-to-ID inference, while an exact target ID can still retrieve
its indexed name for stale-binding rejection. This is separate from the
refresh-cache work in #17509 and does not modify that branch.

Focused Vitest is red on `origin/main` (both entry points select
`Portrait`) and green here (14/14). ESLint, formatting, full `pnpm
typecheck`, browser typecheck, and the push-time `knip` gate pass. The
new Playwright case is checked in but runtime proof is blocked on this
worker: both it and the unchanged `agentWorkflowSelection` smoke case
time out before assertions because the Agent entry button is absent on
the local current-main surface. No live model call was made.

## Screenshots (if applicable)

The browser run produced traces/video for the pre-assertion harness
blocker; no passing screenshot is claimed.
@vercel

vercel Bot commented Sep 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 24, 2026 7:06pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 24, 2026 7:06pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1951 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1930 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/24/2026, 07:08:13 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 105ms TBT · 101.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.7 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 3ms TBT · 164.8 MB heap
vue-large-graph-pan: · 57.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 23ms TBT · 183.6 MB heap
vue-node-resize-workload: · 57.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 293ms TBT · 182.0 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 496ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.9 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -195
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 25ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 763ms
canvas-mouse-sweep: script duration 127ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 57.7 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 311ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.4 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 409ms
dom-widget-clipping: script duration 137ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.1 MB
dom-widget-clipping: DOM nodes 21
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 613ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.2 MB
large-graph-idle: DOM nodes -268
large-graph-idle: event listeners -162
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1475ms
large-graph-pan: script duration 681ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 76.9 MB
large-graph-pan: DOM nodes -263
large-graph-pan: event listeners -190
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1552ms
large-graph-zoom: script duration 667ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 82.1 MB
large-graph-zoom: DOM nodes -145
large-graph-zoom: event listeners -93
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1725ms
legacy-node-drag: script duration 832ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 82.7 MB
legacy-node-drag: DOM nodes -121
legacy-node-drag: event listeners 88
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 566ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.0 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -190
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 369ms
subgraph-dom-widget-clipping: script duration 126ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.2 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 499ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.2 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -227
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 744ms
subgraph-mouse-sweep: script duration 96ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.0 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 880ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 105ms
subgraph-transition-enter: heap used 101.2 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 5082ms
viewport-pan-sweep: script duration 2206ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 73.7 MB
viewport-pan-sweep: DOM nodes -273
viewport-pan-sweep: event listeners -174
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15259ms
vue-large-graph-idle: script duration 264ms
vue-large-graph-idle: TBT 3ms
vue-large-graph-idle: heap used 164.8 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 130
vue-large-graph-pan: task duration 17834ms
vue-large-graph-pan: script duration 811ms
vue-large-graph-pan: TBT 23ms
vue-large-graph-pan: heap used 183.6 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14930
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 63ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5511ms
vue-node-resize-workload: script duration 97ms
vue-node-resize-workload: TBT 293ms
vue-node-resize-workload: heap used 182.0 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7612ms
vue-zoom-out-idle: script duration 144ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 4
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 3
workflow-execution: style recalc count 18
workflow-execution: task duration 97ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.1 MB
workflow-execution: DOM nodes 145
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-09-24T19:16:58.389Z",
  "gitSha": "7c1194cc079f326018a57e521c0bfeddee856178",
  "branch": "backport-18155-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2074.1649999999936,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.691000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 514.456,
      "heapDeltaBytes": -3810248,
      "heapUsedBytes": 66687800,
      "domNodes": -282,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 10.968000000000002,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2007.6319999999441,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.016000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 476.89300000000003,
      "heapDeltaBytes": -7915700,
      "heapUsedBytes": 63024176,
      "domNodes": -281,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 9.860000000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1752.0939999999996,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 24.923000000000002,
      "layouts": 14,
      "layoutDurationMs": 3.728,
      "taskDurationMs": 786.959,
      "heapDeltaBytes": -6864892,
      "heapUsedBytes": 63601356,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 129.094,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1719.920000000002,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 24.775,
      "layouts": 14,
      "layoutDurationMs": 3.7239999999999998,
      "taskDurationMs": 739.542,
      "heapDeltaBytes": -13545588,
      "heapUsedBytes": 57458832,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 124.893,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1712.1660000000247,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 12.882,
      "layouts": 6,
      "layoutDurationMs": 0.9329999999999999,
      "taskDurationMs": 291.12399999999997,
      "heapDeltaBytes": 25711312,
      "heapUsedBytes": 83260512,
      "domNodes": 74,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.839000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1684.62999999997,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.748999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.1039999999999999,
      "taskDurationMs": 330.892,
      "heapDeltaBytes": 3506708,
      "heapUsedBytes": 68636160,
      "domNodes": 76,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 12.2,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 542.6600000000121,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.8130000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 399.73099999999994,
      "heapDeltaBytes": 18345600,
      "heapUsedBytes": 88515256,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 134.16699999999997,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 592.2030000000404,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 9.462000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.653,
      "heapDeltaBytes": -7958380,
      "heapUsedBytes": 62782132,
      "domNodes": 24,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 139.892,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.7159999999749,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.166999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 653.8990000000001,
      "heapDeltaBytes": 11347788,
      "heapUsedBytes": 87344296,
      "domNodes": -268,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 34.679,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2031.7300000000387,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.605000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 572.2260000000001,
      "heapDeltaBytes": 10895896,
      "heapUsedBytes": 87138456,
      "domNodes": -267,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 30.115999999999996,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2471.4069999999992,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.402,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1515.1589999999999,
      "heapDeltaBytes": 7731172,
      "heapUsedBytes": 84779124,
      "domNodes": -246,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 690.156,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2232.1570000000293,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.169999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1434.069,
      "heapDeltaBytes": -476028,
      "heapUsedBytes": 76412960,
      "domNodes": -279,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 672.673,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3312.625999999966,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.014000000000003,
      "layouts": 60,
      "layoutDurationMs": 12.194,
      "taskDurationMs": 1513.271,
      "heapDeltaBytes": 12000988,
      "heapUsedBytes": 80152640,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 662.5810000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3469.8230000000194,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.431999999999999,
      "layouts": 60,
      "layoutDurationMs": 12.711,
      "taskDurationMs": 1590.0620000000001,
      "heapDeltaBytes": 12897468,
      "heapUsedBytes": 91932300,
      "domNodes": -290,
      "jsHeapTotalBytes": 3567616,
      "scriptDurationMs": 670.967,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2562.5989999999774,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.694000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1715.1,
      "heapDeltaBytes": 22501664,
      "heapUsedBytes": 90565596,
      "domNodes": 4,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 840.379,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2519.963000000075,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.866,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1734.258,
      "heapDeltaBytes": 1572760,
      "heapUsedBytes": 82884396,
      "domNodes": -246,
      "jsHeapTotalBytes": 315392,
      "scriptDurationMs": 822.882,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.7959999999998,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.082999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 528.529,
      "heapDeltaBytes": 4962300,
      "heapUsedBytes": 82683196,
      "domNodes": -277,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 29.947999999999997,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.0179999999464,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.175,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 603.568,
      "heapDeltaBytes": 8701536,
      "heapUsedBytes": 87138868,
      "domNodes": -269,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 36.403000000000006,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 544.0060000000244,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 355.06999999999994,
      "heapDeltaBytes": 15023248,
      "heapUsedBytes": 88517692,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 120.2,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 562.7860000000737,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.116,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 383.18399999999997,
      "heapDeltaBytes": 15012180,
      "heapUsedBytes": 88045356,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 132.72400000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2039.9080000000254,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.777999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.414,
      "heapDeltaBytes": -3507200,
      "heapUsedBytes": 69008716,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 10.464,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.734000000004,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.323999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 483.494,
      "heapDeltaBytes": 3093664,
      "heapUsedBytes": 76089844,
      "domNodes": -294,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 9.934999999999999,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1725.1999999999725,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 29.946,
      "layouts": 18,
      "layoutDurationMs": 5.107,
      "taskDurationMs": 752.29,
      "heapDeltaBytes": -6711492,
      "heapUsedBytes": 66711712,
      "domNodes": -298,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 98.57400000000001,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1738.0450000000565,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 26.221,
      "layouts": 18,
      "layoutDurationMs": 4.638,
      "taskDurationMs": 734.9129999999999,
      "heapDeltaBytes": -4978408,
      "heapUsedBytes": 67456464,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 93.558,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1334.3100000000732,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 28.014999999999997,
      "layouts": 15,
      "layoutDurationMs": 13.193,
      "taskDurationMs": 879.805,
      "heapDeltaBytes": 21985124,
      "heapUsedBytes": 106117452,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 29.326999999999998,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 105,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8679.758000000049,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 40.443,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5087.645,
      "heapDeltaBytes": 8709504,
      "heapUsedBytes": 85093384,
      "domNodes": -267,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 2205.474,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8727.399999999989,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 39.86,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5076.323,
      "heapDeltaBytes": -6467116,
      "heapUsedBytes": 69446388,
      "domNodes": -279,
      "jsHeapTotalBytes": 4616192,
      "scriptDurationMs": 2206.574,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15303.413000000035,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15091.422000000002,
      "heapDeltaBytes": -58817172,
      "heapUsedBytes": 168768020,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15122432,
      "scriptDurationMs": 252.88100000000003,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15889.679999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15426.130000000001,
      "heapDeltaBytes": -40417352,
      "heapUsedBytes": 176741988,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19079168,
      "scriptDurationMs": 275.99600000000004,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 5,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18127.43999999998,
      "styleRecalcs": 126,
      "styleRecalcDurationMs": 18.19399999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17929.823,
      "heapDeltaBytes": -45417060,
      "heapUsedBytes": 192283072,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16564224,
      "scriptDurationMs": 850.011,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 27,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17975.30800000004,
      "styleRecalcs": 133,
      "styleRecalcDurationMs": 16.82900000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17737.941,
      "heapDeltaBytes": -39978176,
      "heapUsedBytes": 192745848,
      "domNodes": -8068,
      "jsHeapTotalBytes": -24215552,
      "scriptDurationMs": 772.503,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5541.580000000011,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 63.942,
      "layouts": 20,
      "layoutDurationMs": 24.683999999999997,
      "taskDurationMs": 5505.997999999999,
      "heapDeltaBytes": -31659600,
      "heapUsedBytes": 192498644,
      "domNodes": -8068,
      "jsHeapTotalBytes": 15785984,
      "scriptDurationMs": 98.68999999999998,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 274,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5601.737999999955,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 61.60100000000001,
      "layouts": 20,
      "layoutDurationMs": 23.991,
      "taskDurationMs": 5516.366,
      "heapDeltaBytes": -32574152,
      "heapUsedBytes": 189176132,
      "domNodes": -8068,
      "jsHeapTotalBytes": 8732672,
      "scriptDurationMs": 94.506,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 312,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7662.9950000000235,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7614.7919999999995,
      "heapDeltaBytes": -19031928,
      "heapUsedBytes": 163289380,
      "domNodes": 0,
      "jsHeapTotalBytes": -25427968,
      "scriptDurationMs": 140.06299999999993,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7757.343999999989,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7609.388999999998,
      "heapDeltaBytes": 375548,
      "heapUsedBytes": 191377320,
      "domNodes": 0,
      "jsHeapTotalBytes": -33816576,
      "scriptDurationMs": 147.434,
      "eventListeners": 20,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 445.73800000000574,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 19.895000000000003,
      "layouts": 3,
      "layoutDurationMs": 1.439,
      "taskDurationMs": 100.197,
      "heapDeltaBytes": 4985048,
      "heapUsedBytes": 73425488,
      "domNodes": 145,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.950999999999999,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 451.3680000000022,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 18.252000000000002,
      "layouts": 2,
      "layoutDurationMs": 0.9889999999999999,
      "taskDurationMs": 93.77700000000002,
      "heapDeltaBytes": 4870960,
      "heapUsedBytes": 73623180,
      "domNodes": 144,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 9.031,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50604 75749 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from huang47 September 24, 2026 19:07
@datadog-official

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 1 Pipeline job failed

CI: Lint Format | lint-and-format — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cda030f | Docs | View more details | Give us feedback!

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18723   +/-   ##
=============================================
  Coverage              ?   83.80%           
=============================================
  Files                 ?     2113           
  Lines                 ?   125619           
  Branches              ?    34006           
=============================================
  Hits                  ?   105278           
  Misses                ?    20162           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.81% <ø> (?)
unit 78.86% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gent/composables/agent/useAgentWorkflowResolver.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

christian-byrne pushed a commit that referenced this pull request Sep 25, 2026
…ve node/title/widget state (#18075) (#18759)

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-org.slack.com/archives/C0BGH348Z0C/p1789514768597649)_

Manual backport of #18075 to `cloud/1.54`. The automated backport failed
with merge conflicts:
#18075 (comment)

Cherry-picked from `96821ace03bc81d7a29965751a401fcf1818cae3` (`git
cherry-pick -x -m 1`).

## Dependency check

The bot flagged a possible stacking conflict with #18728, #18723 (both
still open against `cloud/1.54`). Neither touches `graphMutations.ts`,
`graphMutations.test.ts`, or `agentConversationFixture.ts` — they are
not the cause of this conflict.

The real causes (same underlying gap as the `core/1.54` backport,
#18758):

- **`graphMutations.ts`** — `cloud/1.54` predates #18191 ("keep the
ghost placement flag out of the document"), which hoisted node flags
into a local `flags` variable (`cloneNodeFlags`) that
`lastSerialization` also started reusing. #18191 is merged to `main` but
carries no `needs-backport` label and was never backported to
`cloud/1.54`. Resolved by keeping `cloud/1.54`'s existing flags handling
(`flags: cloneRecord(payload.flags)` / `lastSerialization:
structuredClone(payload)`) and porting only #18075's actual change:
`resolveNodeTitle(payload, incumbent)` for the title, plus the new
`titleReconcileBaseline` field feeding it.
- **`graphMutations.test.ts`** — pure insertion (no code on the `HEAD`
side of the conflict), accepted the new test cases as-is.
- **`browser_tests/fixtures/agentConversationFixture.ts`** and the new
**`browser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.ts`** —
this Playwright fixture (and the wider main-only agent-test scaffolding
it depends on, e.g. `agentTabSwitchCatchUp.spec.ts`) does not exist on
`cloud/1.54` at all; it isn't introduced by either PR above. Dropped
from this backport, along with the `Topbar.ts#openBlankTabAndReturn()`
helper added only for that spec, so the branch keeps compiling. The
runtime fix ships with its Vitest regression coverage
(`graphMutations.test.ts`, `agentNodeMaterializer.test.ts`); the e2e
visual-proof spec is left for a follow-up once the agent Playwright
fixture infrastructure itself is backported.

## Validation

- `pnpm exec vitest run src/workbench/extensions/agent/crdt` — 827
passed, 5 expected-fail (the intentional `it.fails` cases this PR
introduces/carries).
- `pnpm exec eslint` / `pnpm exec oxfmt --check` clean on all touched
files.
- `pnpm typecheck` clean.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19

---
_Generated by [Claude
Code](https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19)_

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed under the 1.54 backport grant (core/1.54 + cloud/1.54, standing). COMMENT rather than APPROVE: I authored the source commit, so an approval record here would be self-approval in substance. The grant permits the merge without one.

Cherry-pick fidelity. Content-identical to the merged source e5a6ab01b7b146e517c42e05ea4cee8b79ff1df7 (#18155) — diffed the added/removed lines of this PR against the source commit, zero divergence. Source stat 261 insertions(+), 5 deletions(-) across 3 files matches this PR exactly.

The fix is at the cause, not the symptom. cloudIdsByName is deliberately ambiguity-free — it only keeps names appearing exactly once. indexedNameFor was reverse-scanning that map by id, so a workflow whose name is duplicated is absent from it, returned undefined, and bindingIsStale short-circuited to false at the indexedName === undefined guard. A stale binding was therefore never detected precisely in the duplicate-name case it needed to be. Reading cloudIndex (which retains duplicates) fixes the lookup at its source.

The bindingIsStale line-110 change from cloudIdsByName.get to cloudIndex.find widens what counts as stale, and that widening is safe: control only reaches it when indexedName !== boundName, so workflowId is not among the workflows named boundName, and any id found there is necessarily !== workflowId. find-picks-first among duplicates cannot change the boolean.

Regression coverage verified red-on-parent. Reverting only useAgentWorkflowResolver.ts to its pre-fix content and keeping the new tests: 4 failed / 12 passed. With the fix: 16/16 green. The failing case is the intended one — rejects a stale storedWorkflowFor binding when the bound name is duplicated in the cloud index. Plus a 217-line black-box browser spec (agentDuplicateWorkflowNameBinding.spec.ts), so this is harness-covered, not unit-only.

Checks at this exact head. test, storybook-build, validate-licenses, validate-fonts, scan, playwright-video-new-tests all green. The three pr-risk entries are cancelled, not failed — gh pr checks renders both as "fail". No human objections, no review comments outstanding.

Merging under the grant.

@christian-byrne
christian-byrne merged commit 89dd089 into cloud/1.54 Sep 25, 2026
101 of 106 checks passed
@christian-byrne
christian-byrne deleted the backport-18155-to-cloud-1.54 branch September 25, 2026 02:25
comfy-pr-bot pushed a commit that referenced this pull request Sep 25, 2026
… assets flag, retire Comfy.Assets.UseAssetAPI (#18728)

Manual backport of #17117 to `cloud/1.54`.

Cherry-picked from dffad2d (`git
cherry-pick -x`).

## Why

Retires the hidden `Comfy.Assets.UseAssetAPI` setting and the
`Comfy.ToggleAssetAPI` command. Asset surfaces (model library, sidebar
routing, model store) follow `useFeatureFlags().flags.assetsEnabled`,
and widget asset pickers are cloud-only under
`isWidgetAssetPickerEnabled` / `shouldUseWidgetAssetPicker`. On the
cloud build `assetsEnabled` is always true, so asset surfaces stay on,
including for users who had set the hidden setting to `false`. That
opt-out is retired on purpose.

## Dependency check

The bot suggested this might be a stacking conflict with #18723 and
#18644. It is not. Neither PR touches any of the conflicted files:
#18723 changes agent workflow-resolver files, and #18644 changes
lint/typecheck config and a few UI components. The conflict is real. All
7 conflicts are in test files, because `main` went through test-infra
migrations that `cloud/1.54` doesn't have (global Pinia,
`vi.mock(import())`, i18n mock cleanup: #17175, #17176, #17178, #17231,
#17234–#17237, #17270, #16891). All production files, locales, e2e
specs, `scripts/checkAssetsFlagArtifact.*` and
`.github/actions/build-cloud-frontend/action.yaml` applied cleanly.

## Conflict resolution

Test files kept the target branch's mocking style. Only the
setting-to-flag change was ported.

- `src/components/sidebar/tabs/ModelLibrarySidebarTab.test.ts`: kept the
target's `settingState`/`modelsState`/`mockLoadModels` harness. Removed
`useAssetAPI` from the settings mock, added a hoisted `featureFlagState`
and a `useFeatureFlags` mock, and switched the two asset-mode tests to
`featureFlagState.assetsEnabled = true`.
- `src/composables/useCoreCommands.test.ts`: took #17117's
`browseModelAssets()` helper. The auto-merged tests below it already use
it and the existing `mockFeatureFlagState`.
- `src/platform/assets/services/assetService.test.ts`: kept the target's
module mocks and renamed the describe to `shouldUseWidgetAssetPicker`.
Removed the now-dead `settingStore` mock, which referenced the dropped
`mockSettingStoreGet`. `assetService` no longer reads settings.
- `src/platform/assets/utils/assetPreviewUtil.test.ts`: added #17117's
`useFeatureFlags` mock and kept the target's string-form `assetService`
mock.
-
`src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.test.ts`:
kept the target's `axios` import and its two target-only tests
(first-load lifecycle, loading inventory). Took #17117's renamed "widget
asset picker is disabled" test. Dropped the unused `settingStore` mock,
as #17117 did.
- `src/stores/modelStore.test.ts`: took #17117's `remoteConfigHolder` +
`featureState` mocks and the `enableMocks(assetsEnabled)` body. The
auto-merged `beforeEach` depends on them, and they avoid cross-test
leakage.
- `src/stores/workspace/sidebarTabStore.test.ts`: kept the target's
`mockGetSetting`/`registeredCommands` harness. Replaced the
`commandStore.commands` / `mockBrowseModelAssets` stubs with #17117's
`featureFlagState` and `openModelLibraryBrowser` mocks, and ported each
routing test to set the flag instead of `Comfy.Assets.UseAssetAPI`.

No remaining references to `Comfy.Assets.UseAssetAPI`,
`isAssetAPIEnabled`, `shouldUseAssetBrowser`, `ToggleAssetAPI` or
`usesAssetApi`.

## Validation

- `pnpm typecheck`: clean
- `eslint`, `oxlint`, `oxfmt --check` on changed files: clean
- Vitest: touched tests plus `src/stores`, `src/platform/assets`,
`src/components/sidebar`, `src/composables`,
`src/renderer/extensions/vueNodes/widgets`, `src/platform/missingModel`,
`src/extensions/core`, `scripts`. All pass (130 + 332 files).
- `pnpm build:cloud` (`VITE_USE_LEGACY_DEFAULT_GRAPH=true`), then
`EXPECTED_DISTRIBUTION=cloud pnpm test:assets-flag-artifact` against
HEAD: pass. The same cloud dist checked with
`EXPECTED_DISTRIBUTION=localhost` correctly fails.
- `pnpm build`, then `EXPECTED_DISTRIBUTION=localhost pnpm
test:assets-flag-artifact`: pass
- Playwright, cloud project on the cloud dist (`browseModelAssets`,
`cloud-asset-promoted-widget`, `errorsTabCloudMissingModels`,
`checkoutRecovery`, `pricingTableDeepLink`): 30/30. The first run had
one timing failure in `cloud-asset-promoted-widget`. It passed 3/3 in
isolation and on a full rerun.
- `knip` (pre-push hook): clean
- Playwright, chromium project on the localhost dist
(`modelLibraryAssetMode`, `modelLibraryRouting`, `browseModelAssets`):
19/19
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 27, 2026

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — cda030f4 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants