Repository navigation
[backport cloud/1.55] fix: subgraph-interior widgets don't render in Vue mode after insert_workflow - #18679
Conversation
🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 13d3876180d7208d3cfaef252c0c0569f278d84a
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T11:44:47.191Z",
"gitSha": "6eab9648cc5cc59d401be5e939ef6a77545bde46",
"branch": "backport-18634-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.4890000000014,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.8,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.863,
"heapDeltaBytes": -9133992,
"heapUsedBytes": 58717096,
"domNodes": -259,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.793000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1999.102999999991,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.041999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.8260000000001,
"heapDeltaBytes": -7639220,
"heapUsedBytes": 59908328,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.279000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.462999999971,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.522999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 647.417,
"heapDeltaBytes": -5793416,
"heapUsedBytes": 61809392,
"domNodes": -257,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 117.14,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.9010000000726,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.441999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.8019999999999,
"heapDeltaBytes": -7647112,
"heapUsedBytes": 60195228,
"domNodes": -257,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 119.781,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.0300000000216,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.461,
"layouts": 6,
"layoutDurationMs": 0.8929999999999999,
"taskDurationMs": 272.469,
"heapDeltaBytes": 3129140,
"heapUsedBytes": 70774240,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.986,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.814999999996,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.477,
"layouts": 6,
"layoutDurationMs": 0.998,
"taskDurationMs": 279.79900000000004,
"heapDeltaBytes": 3157736,
"heapUsedBytes": 70424096,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.597000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 532.5510000000122,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.188,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.625,
"heapDeltaBytes": 18989356,
"heapUsedBytes": 86556176,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 130.639,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 532.4239999999918,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.658,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.82500000000005,
"heapDeltaBytes": 18993160,
"heapUsedBytes": 86579704,
"domNodes": 23,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 137.304,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1041.6270000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.7360000000001,
"heapDeltaBytes": 38603664,
"heapUsedBytes": 105242816,
"domNodes": 0,
"jsHeapTotalBytes": 18247680,
"scriptDurationMs": 54.036,
"eventListeners": 0,
"totalBlockingTimeMs": 421,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1017.2049999999899,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 651.656,
"heapDeltaBytes": 38595980,
"heapUsedBytes": 107902116,
"domNodes": 0,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 49.45099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 412,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 767.5789999999552,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.99199999999973,
"heapDeltaBytes": 13735956,
"heapUsedBytes": 89730964,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.48800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 155,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 768.0819999999358,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.4959999999998,
"heapDeltaBytes": 14914068,
"heapUsedBytes": 89926908,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.55100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6805.96799999995,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.11800000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6072.75,
"heapDeltaBytes": 12039272,
"heapUsedBytes": 93729700,
"domNodes": -18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 5026.039,
"eventListeners": 0,
"totalBlockingTimeMs": 95,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7965.902000000028,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.5959999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7129.339,
"heapDeltaBytes": -5491424,
"heapUsedBytes": 69380904,
"domNodes": -6,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 5753.329,
"eventListeners": 0,
"totalBlockingTimeMs": 42,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7423.271999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6567.828,
"heapDeltaBytes": -12588956,
"heapUsedBytes": 69296464,
"domNodes": -12,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 5243.551,
"eventListeners": 0,
"totalBlockingTimeMs": 84,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7427.870000000098,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.8500000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6592.699,
"heapDeltaBytes": 9936920,
"heapUsedBytes": 84982652,
"domNodes": -6,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 5284.616,
"eventListeners": 0,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2039.2739999999776,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.88,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.1389999999999,
"heapDeltaBytes": 56612,
"heapUsedBytes": 79837224,
"domNodes": -239,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 31.374,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.632999999928,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.184,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.009,
"heapDeltaBytes": -10264540,
"heapUsedBytes": 76862304,
"domNodes": -246,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.93500000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2200.7729999999697,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.862000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1342.123,
"heapDeltaBytes": 1241660,
"heapUsedBytes": 83388024,
"domNodes": -242,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 667.906,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2154.9569999999676,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.254000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1307.639,
"heapDeltaBytes": -1402508,
"heapUsedBytes": 79888872,
"domNodes": -239,
"jsHeapTotalBytes": 1527808,
"scriptDurationMs": 656.3789999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3234.905000000026,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.055000000000003,
"layouts": 60,
"layoutDurationMs": 12.730000000000002,
"taskDurationMs": 1447.8589999999997,
"heapDeltaBytes": -16116600,
"heapUsedBytes": 73475412,
"domNodes": -248,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 632.0329999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3178.9669999999433,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.812,
"layouts": 60,
"layoutDurationMs": 12.761000000000001,
"taskDurationMs": 1355.864,
"heapDeltaBytes": 8080972,
"heapUsedBytes": 74191152,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 628.232,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2278.2960000000116,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.576,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1620.2590000000002,
"heapDeltaBytes": -9858908,
"heapUsedBytes": 74610316,
"domNodes": -250,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 821.98,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2501.860000000079,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.663,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1616.377,
"heapDeltaBytes": -16609200,
"heapUsedBytes": 74327972,
"domNodes": -250,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 833.561,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2006.5700000000106,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.956999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.6450000000001,
"heapDeltaBytes": 20192908,
"heapUsedBytes": 84150804,
"domNodes": -243,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.949999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.3369999999977,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.116999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.29000000000013,
"heapDeltaBytes": -9834552,
"heapUsedBytes": 79581512,
"domNodes": -247,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 30.103999999999992,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 510.2569999999673,
"styleRecalcs": 50,
"styleRecalcDurationMs": 10.967999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.30799999999994,
"heapDeltaBytes": 14073196,
"heapUsedBytes": 83048680,
"domNodes": 25,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 116.524,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 510.3830000000471,
"styleRecalcs": 50,
"styleRecalcDurationMs": 11.147999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.938,
"heapDeltaBytes": 14092652,
"heapUsedBytes": 83759524,
"domNodes": 25,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 115.80699999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1992.5949999999943,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.744,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.043,
"heapDeltaBytes": 10524780,
"heapUsedBytes": 80375240,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.859,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.0130000000718,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.376,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.12200000000007,
"heapDeltaBytes": -2561528,
"heapUsedBytes": 60587144,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.742000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1687.1649999999931,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.346,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.606,
"heapDeltaBytes": -11181292,
"heapUsedBytes": 59090216,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 82.443,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1685.8190000000377,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.736999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.789,
"heapDeltaBytes": -8994200,
"heapUsedBytes": 61018044,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 89.636,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 918.5179999999491,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.758,
"layouts": 5,
"layoutDurationMs": 9.833000000000002,
"taskDurationMs": 710.0869999999999,
"heapDeltaBytes": -6334028,
"heapUsedBytes": 83439500,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 21.934999999999995,
"eventListeners": 2383,
"totalBlockingTimeMs": 90,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8276.575000000037,
"styleRecalcs": 251,
"styleRecalcDurationMs": 43.215999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4646.125,
"heapDeltaBytes": -21001900,
"heapUsedBytes": 66716012,
"domNodes": -241,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 2203.029,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8261.404999999968,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.871,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4603.937,
"heapDeltaBytes": -10888648,
"heapUsedBytes": 76398112,
"domNodes": -242,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2182.825,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14179.401999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14010.255,
"heapDeltaBytes": -50196152,
"heapUsedBytes": 187301212,
"domNodes": -8062,
"jsHeapTotalBytes": -11120640,
"scriptDurationMs": 204.66900000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14349.973999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14188.203000000001,
"heapDeltaBytes": -42857708,
"heapUsedBytes": 195625532,
"domNodes": -8062,
"jsHeapTotalBytes": -15994880,
"scriptDurationMs": 204.15300000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16959.896000000015,
"styleRecalcs": 118,
"styleRecalcDurationMs": 14.562999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16772.642,
"heapDeltaBytes": -54366508,
"heapUsedBytes": 167795168,
"domNodes": -8062,
"jsHeapTotalBytes": -14999552,
"scriptDurationMs": 717.209,
"eventListeners": -14928,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17080.472999999984,
"styleRecalcs": 119,
"styleRecalcDurationMs": 14.315999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16910.115,
"heapDeltaBytes": -45298048,
"heapUsedBytes": 191907992,
"domNodes": -8091,
"jsHeapTotalBytes": -18530304,
"scriptDurationMs": 705.519,
"eventListeners": -14928,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5220.198000000096,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.96699999999999,
"layouts": 20,
"layoutDurationMs": 20.438,
"taskDurationMs": 5179.3060000000005,
"heapDeltaBytes": -43608320,
"heapUsedBytes": 197645868,
"domNodes": -8062,
"jsHeapTotalBytes": 12644352,
"scriptDurationMs": 87.20899999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 205,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5117.226999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.943,
"layouts": 20,
"layoutDurationMs": 21.497000000000003,
"taskDurationMs": 5084.651000000001,
"heapDeltaBytes": 25265580,
"heapUsedBytes": 199590552,
"domNodes": -8062,
"jsHeapTotalBytes": 19136512,
"scriptDurationMs": 86.33000000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 230,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7063.7329999999565,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7017.703000000001,
"heapDeltaBytes": -8789160,
"heapUsedBytes": 168988580,
"domNodes": 0,
"jsHeapTotalBytes": -19922944,
"scriptDurationMs": 98.113,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7257.798000000093,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7142.977999999999,
"heapDeltaBytes": -8529748,
"heapUsedBytes": 165443232,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 102.30100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 433.744000000047,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.929,
"layouts": 4,
"layoutDurationMs": 1.6179999999999997,
"taskDurationMs": 106.574,
"heapDeltaBytes": 4985508,
"heapUsedBytes": 70646940,
"domNodes": 129,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.522,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 86.80000000003929,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.194,
"layouts": 3,
"layoutDurationMs": 1.5870000000000004,
"taskDurationMs": 62.395,
"heapDeltaBytes": 3047400,
"heapUsedBytes": 68553764,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.920000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @huang47.
Found 5 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 2 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
| ? executionIdFromState(rootGraph, nodeData) | ||
| : createLeafNodeExecutionId(nodeData.id) | ||
| if (!nodeExecId) return [] | ||
| : createNodeExecutionId([nodeData.id]) |
There was a problem hiding this comment.
🟠 High — getHostNode was migrated to getNodeByState so subgraph-interior nodes with colon-bearing ids now resolve, but nodeExecId still comes from executionIdFromState, which returns null for exactly those ids (both the createNodeExecutionId fallback and the locator path reject a colon in the local segment). For the nodes this PR enables, the new null guards therefore permanently suppress missing-model/missing-media highlighting and clearWidgetRelatedErrors even when the graph is ready, so the widget renders and updates but can never surface or clear execution errors; derive the exec id from the already-resolved hostNode (e.g. getExecutionIdByNode(rootGraph, hostNode)) instead of accepting null.
Raised by 5 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
There was a problem hiding this comment.
Verified against the actual code on this branch (identical to the merged main version after #18634) — this is real, but not safely fixable with the one-line change suggested, and I did not want to ship a partial fix that only looks like it works.
Traced executionIdFromState for a subgraph-interior node whose local id contains a colon (state.graphId !== rootGraph.id, so subgraphIdFromState is non-null):
locatorIdFromState→createLeafNodeLocatorId(subgraphUuid, id): with a truthysubgraphUuid, the strict segment check fails (colon) andif (subgraphUuid) return nullkicks in →null.- So
nodeis never resolved by locator, and the function returns itsfallback, which for this branch iscreateNodeExecutionId([localNodeId])— the strict constructor, which also rejects the colon →null.
So yes, nodeExecId is null for exactly the nodes this PR newly renders, and the nodeExecId !== null / if (nodeExecId) guards added here do skip missingModelStore/missingMediaStore lookups and clearWidgetRelatedErrors for them.
However, the suggested fix — getExecutionIdByNode(rootGraph, hostNode) — returns null too in this exact case: for a non-root node.graph, it calls createExecutionIdFromPath(parentPath, node.id), which runs node.id through the same strict, colon-rejecting requireNodeIdSegment as the leaf of the joined path. There's no existing "leaf-tolerant" constructor for a multi-segment execution id anywhere in the codebase — createLeafNodeExecutionId/createLeafNodeLocatorId only tolerate a colon when there's no ancestor segment to disambiguate it from (root-owned nodes). Calling getExecutionIdByNode here would change nothing.
I also checked whether this is a regression at all: scanNodeModelCandidates/scanNodeMediaCandidates (unchanged by this PR) already call the same strict getExecutionIdByNode and return [] when it's null, so missingModelStore/missingMediaStore never had entries for these nodes even before this fix — the new guards don't change that observable behavior. For clearWidgetRelatedErrors/backend execution-error correlation, this is a real, narrower gap, but before #18634 the widget for such a node didn't render in Vue mode at all, so there's no working prior behavior being regressed — it's "renders and updates, but can't yet correlate backend-reported errors for this node" rather than a regression.
A real fix needs a colon-tolerant, leaf-safe multi-segment execution-id builder shared across getExecutionIdByNode and its several callers (the two scan pipelines, isAncestorPathActive, etc.) — a cross-cutting change with its own test/verification needs, not something I want to rush into a stable-branch backport under review-response pressure. Filing this as a follow-up rather than fixing it here.
Generated by Claude Code
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #18679 +/- ##
=============================================
Coverage ? 84.59%
=============================================
Files ? 2294
Lines ? 131285
Branches ? 35436
=============================================
Hits ? 111064
Misses ? 19921
Partials ? 300
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Cursor review follow-ups on #18679 (backport of #18634): - LGraph._nodes_by_id was a plain object literal, so a node id of "__proto__" (accepted by parseNodeId) would repoint the object's prototype on add() instead of creating an own key, permanently hiding that node from getNodeById's new Object.hasOwn guard. Use Object.create(null) so every node id, including "__proto__", is a normal own property. - widgetNodeLocatorId rejected every colon-bearing bareWidgetId, but createLeafNodeLocatorId already tolerates a colon for root-owned ids (no subgraph to disambiguate from) while rejecting it for subgraph-owned ones. Restore that tolerant constructor plus its `?? undefined` normalization so root-owned opaque ids (comfy-multi- player's insert_workflow remapped ids) keep a working nodeLocatorId instead of losing it, and no null return value leaks past this function's NodeLocatorId | undefined contract.
…workflow (#18634) ## Summary Fixes missing Vue widgets on nodes inside a subgraph inserted through `insert_workflow`. Multiplayer assigns inserted nodes colon-bearing local IDs. Those IDs cannot be represented safely as colon-delimited locator or execution paths, so widget rendering now resolves live nodes from the existing `(graphId, nodeId)` state instead. ## Changes - Resolve widget hosts directly within their owning graph without parsing the local node ID. - Continue rendering and updating stored widgets when no valid execution ID exists, while skipping execution-keyed error operations. - Prevent `LGraph.getNodeById` from returning inherited object properties. - Cover the real insert/projection/widget-model path, the pre-graph-ready fallback, scope collisions, and inherited registry keys. ## Verification - `pnpm exec vitest run src/lib/litegraph/src/LGraph.test.ts src/utils/graphTraversalUtil.test.ts src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts src/renderer/extensions/vueNodes/composables/insertWorkflowSubgraphInteriorWidgets.regression.test.ts` (280 passed) - `pnpm typecheck:app` - ESLint, type-aware oxlint, formatting, and Knip passed on the changed files. ---------
Cursor review follow-ups on #18679 (backport of #18634): - LGraph._nodes_by_id was a plain object literal, so a node id of "__proto__" (accepted by parseNodeId) would repoint the object's prototype on add() instead of creating an own key, permanently hiding that node from getNodeById's new Object.hasOwn guard. Use Object.create(null) so every node id, including "__proto__", is a normal own property. - widgetNodeLocatorId rejected every colon-bearing bareWidgetId, but createLeafNodeLocatorId already tolerates a colon for root-owned ids (no subgraph to disambiguate from) while rejecting it for subgraph-owned ones. Restore that tolerant constructor plus its `?? undefined` normalization so root-owned opaque ids (comfy-multi- player's insert_workflow remapped ids) keep a working nodeLocatorId instead of losing it, and no null return value leaks past this function's NodeLocatorId | undefined contract.
…keys A node whose id is exactly constructor/toString/valueOf resolves lastNodeErrors[id] to the inherited Object.prototype member instead of undefined when it has no recorded error, which crashed hasWidgetError's .errors.some(...) call. Add getOwnNodeErrors (Object.hasOwn-guarded, mirroring the LGraph.getNodeById fix) and use it at both lastNodeErrors read sites in processedWidgetRenderModel.ts.
Cursor review follow-ups on #18679 (backport of #18634): - LGraph._nodes_by_id was a plain object literal, so a node id of "__proto__" (accepted by parseNodeId) would repoint the object's prototype on add() instead of creating an own key, permanently hiding that node from getNodeById's new Object.hasOwn guard. Use Object.create(null) so every node id, including "__proto__", is a normal own property. - widgetNodeLocatorId rejected every colon-bearing bareWidgetId, but createLeafNodeLocatorId already tolerates a colon for root-owned ids (no subgraph to disambiguate from) while rejecting it for subgraph-owned ones. Restore that tolerant constructor plus its `?? undefined` normalization so root-owned opaque ids (comfy-multi- player's insert_workflow remapped ids) keep a working nodeLocatorId instead of losing it, and no null return value leaks past this function's NodeLocatorId | undefined contract.
17a90e1 to
8bf692f
Compare
8bf692f to
7d1a9c8
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, and the diff contains no conflict markers. Required checks on this branch are lint-and-format, test and e2e-status; any other red check here is advisory and does not gate the merge.
I force-pushed this branch to strip Co-authored-by trailers for claude/Amp from the commit messages, which is what Check for AI agent co-author trailers was failing on. Message-only rewrite: the tree hash is identical to before, so the code is untouched.
Backport of #18634 to
cloud/1.55Automatically created by backport workflow.