Repository navigation
FE-2891 fix(flags): guard the dev-override storage read and note the override bypass - #18744
Conversation
🎭 Playwright: ✅ 2125 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3225f7526d13f08d910b39da675403e8baa904e4
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.99 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.97 MB (baseline 3.97 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 576 kB (baseline 576 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category Status: 301 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T00:02:40.866Z",
"gitSha": "5181ddc95d40c4874cf39a884f3c47aa1f8c92ee",
"branch": "dante01yoon/fe-2891-dev-override-guard",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.5549999999484,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.6839999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.94100000000003,
"heapDeltaBytes": -1382404,
"heapUsedBytes": 60992232,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.43,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1999.1490000001022,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0559999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.72099999999995,
"heapDeltaBytes": -8080688,
"heapUsedBytes": 54396260,
"domNodes": 0,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.613000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.395000000019,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.456000000000001,
"layouts": 12,
"layoutDurationMs": 3.688,
"taskDurationMs": 678.1919999999999,
"heapDeltaBytes": -7695188,
"heapUsedBytes": 54760956,
"domNodes": 0,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 125.353,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1728.3199999999397,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.804000000000002,
"layouts": 12,
"layoutDurationMs": 4.261,
"taskDurationMs": 667.575,
"heapDeltaBytes": 11272336,
"heapUsedBytes": 73819764,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 125.284,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.0850000000437,
"styleRecalcs": 28,
"styleRecalcDurationMs": 10.164,
"layouts": 6,
"layoutDurationMs": 1.157,
"taskDurationMs": 280.443,
"heapDeltaBytes": 2043932,
"heapUsedBytes": 64425820,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.110999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.1930000000411,
"styleRecalcs": 28,
"styleRecalcDurationMs": 9.609,
"layouts": 6,
"layoutDurationMs": 1.0829999999999997,
"taskDurationMs": 217.852,
"heapDeltaBytes": 2175216,
"heapUsedBytes": 64330608,
"domNodes": 53,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.924999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 528.4050000000207,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.4859999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.476,
"heapDeltaBytes": 18016304,
"heapUsedBytes": 80331608,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.109,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 528.3840000000737,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.5919999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.68100000000004,
"heapDeltaBytes": 17982068,
"heapUsedBytes": 80271996,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 136.098,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1035.2780000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 719.221,
"heapDeltaBytes": -15074260,
"heapUsedBytes": 72496228,
"domNodes": -259,
"jsHeapTotalBytes": 19267584,
"scriptDurationMs": 48.069999999999986,
"eventListeners": -207,
"totalBlockingTimeMs": 387,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1033.7130000000343,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 695.8510000000001,
"heapDeltaBytes": -14005812,
"heapUsedBytes": 71977156,
"domNodes": -259,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 50.57600000000001,
"eventListeners": -207,
"totalBlockingTimeMs": 390,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 764.6540000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.8069999999998,
"heapDeltaBytes": 14647360,
"heapUsedBytes": 91172960,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.66900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 766.6639999999916,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.0490000000004,
"heapDeltaBytes": 13580652,
"heapUsedBytes": 89238728,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.239,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7306.915000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6409.336,
"heapDeltaBytes": 11070024,
"heapUsedBytes": 93104108,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 5079.0560000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6733.559000000014,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05000000000000143,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6099.121,
"heapDeltaBytes": -14004652,
"heapUsedBytes": 68500088,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 5021.674,
"eventListeners": 0,
"totalBlockingTimeMs": 39,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6796.586999999989,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06299999999999709,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6215.223,
"heapDeltaBytes": -2232528,
"heapUsedBytes": 80260336,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 5128.65,
"eventListeners": 0,
"totalBlockingTimeMs": 111,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7108.349999999973,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.35199999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6360.246999999999,
"heapDeltaBytes": -5104984,
"heapUsedBytes": 72294276,
"domNodes": -228,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 5058.763,
"eventListeners": -164,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2017.911999999967,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.062999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.9970000000001,
"heapDeltaBytes": 1841080,
"heapUsedBytes": 83168976,
"domNodes": -228,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 29.197999999999993,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2040.5560000000378,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.009999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.24699999999996,
"heapDeltaBytes": -7031616,
"heapUsedBytes": 74491476,
"domNodes": -228,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 28.074999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2132.9000000000065,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.812,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1336.7680000000003,
"heapDeltaBytes": -5082348,
"heapUsedBytes": 77275604,
"domNodes": -228,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 692.129,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2133.3029999999553,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.565999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1288.089,
"heapDeltaBytes": -1081920,
"heapUsedBytes": 80889936,
"domNodes": -228,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 648,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3175.072,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.671,
"layouts": 60,
"layoutDurationMs": 12.995,
"taskDurationMs": 1368.5489999999998,
"heapDeltaBytes": 8489160,
"heapUsedBytes": 74168068,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 638.1320000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3249.625999999921,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.729,
"layouts": 60,
"layoutDurationMs": 13.969000000000001,
"taskDurationMs": 1444.5320000000002,
"heapDeltaBytes": -7240896,
"heapUsedBytes": 74623616,
"domNodes": -228,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 633.3969999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2281.9240000000036,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.403999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1543.4999999999998,
"heapDeltaBytes": 13801256,
"heapUsedBytes": 99559048,
"domNodes": 0,
"jsHeapTotalBytes": 5959680,
"scriptDurationMs": 777.024,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2418.9420000000155,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.0120000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1582.1430000000003,
"heapDeltaBytes": 19724792,
"heapUsedBytes": 103175220,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 801.2269999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2034.0979999999718,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.526,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.71799999999996,
"heapDeltaBytes": -14026620,
"heapUsedBytes": 74856988,
"domNodes": -228,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 29.761999999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2031.2229999999545,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.3799999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.2120000000001,
"heapDeltaBytes": -13966748,
"heapUsedBytes": 74799524,
"domNodes": -228,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 30.44299999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 512.8760000000057,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.454999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.99100000000004,
"heapDeltaBytes": 14013848,
"heapUsedBytes": 76749080,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 122.82499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 522.640000000024,
"styleRecalcs": 50,
"styleRecalcDurationMs": 7.086999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.58,
"heapDeltaBytes": 13080268,
"heapUsedBytes": 76706060,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 121.78599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 1991.9700000000375,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8839999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.58400000000006,
"heapDeltaBytes": -12270704,
"heapUsedBytes": 57483456,
"domNodes": -244,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1993.6830000000327,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.441,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.66200000000003,
"heapDeltaBytes": -1278056,
"heapUsedBytes": 60973504,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.148999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1672.7450000000204,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.003999999999998,
"layouts": 16,
"layoutDurationMs": 5.28,
"taskDurationMs": 662.4760000000001,
"heapDeltaBytes": -4596976,
"heapUsedBytes": 59022980,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 90.876,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.512000000026,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.217,
"layouts": 16,
"layoutDurationMs": 5.192,
"taskDurationMs": 636.1360000000001,
"heapDeltaBytes": -13050304,
"heapUsedBytes": 56876720,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 88.002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 850.7969999999432,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.220000000000002,
"layouts": 5,
"layoutDurationMs": 9.478,
"taskDurationMs": 674.3570000000001,
"heapDeltaBytes": -6281280,
"heapUsedBytes": 81545344,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 21.094999999999995,
"eventListeners": 2383,
"totalBlockingTimeMs": 86,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8180.361000000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.695,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4670.339,
"heapDeltaBytes": -15243800,
"heapUsedBytes": 66399712,
"domNodes": -228,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 2225.856,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8203.861000000074,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.231,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4651.389,
"heapDeltaBytes": -679944,
"heapUsedBytes": 80875176,
"domNodes": -228,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2208.304,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14203.658000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13758.912,
"heapDeltaBytes": -18241392,
"heapUsedBytes": 195255428,
"domNodes": -8078,
"jsHeapTotalBytes": -15187968,
"scriptDurationMs": 234.39000000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14513.81600000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14378.102000000003,
"heapDeltaBytes": -69843092,
"heapUsedBytes": 171052772,
"domNodes": -8049,
"jsHeapTotalBytes": -12304384,
"scriptDurationMs": 212.184,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17018.58800000002,
"styleRecalcs": 120,
"styleRecalcDurationMs": 14.07799999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16788.773,
"heapDeltaBytes": -67450664,
"heapUsedBytes": 169224884,
"domNodes": -8049,
"jsHeapTotalBytes": -18460672,
"scriptDurationMs": 698.4159999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 4,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16999.83800000007,
"styleRecalcs": 117,
"styleRecalcDurationMs": 14.506999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16888.863,
"heapDeltaBytes": -25690484,
"heapUsedBytes": 187707828,
"domNodes": -8049,
"jsHeapTotalBytes": -9752576,
"scriptDurationMs": 711.4399999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 58,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5222.414999999955,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.11899999999998,
"layouts": 20,
"layoutDurationMs": 23.177000000000003,
"taskDurationMs": 5207.594999999999,
"heapDeltaBytes": -34499900,
"heapUsedBytes": 190756652,
"domNodes": -8049,
"jsHeapTotalBytes": 15880192,
"scriptDurationMs": 88.601,
"eventListeners": -14923,
"totalBlockingTimeMs": 292,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5296.180999999933,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.76399999999998,
"layouts": 20,
"layoutDurationMs": 22.625999999999994,
"taskDurationMs": 5235.1269999999995,
"heapDeltaBytes": -58218368,
"heapUsedBytes": 176197592,
"domNodes": -8049,
"jsHeapTotalBytes": 10706944,
"scriptDurationMs": 104.544,
"eventListeners": -14923,
"totalBlockingTimeMs": 200,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7086.509999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6993.784999999999,
"heapDeltaBytes": -1748440,
"heapUsedBytes": 169023464,
"domNodes": 0,
"jsHeapTotalBytes": -33554432,
"scriptDurationMs": 123.369,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7263.377999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7218.489999999999,
"heapDeltaBytes": -13245280,
"heapUsedBytes": 183836792,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 105.34900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 438.0069999999705,
"styleRecalcs": 14,
"styleRecalcDurationMs": 12.844000000000001,
"layouts": 3,
"layoutDurationMs": 0.966,
"taskDurationMs": 86.65100000000001,
"heapDeltaBytes": 4984836,
"heapUsedBytes": 66975912,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.440000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 95.55299999999534,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.054000000000002,
"layouts": 4,
"layoutDurationMs": 2.034,
"taskDurationMs": 66.94200000000001,
"heapDeltaBytes": 3007600,
"heapUsedBytes": 64975048,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.008999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthrough
ChangesFeature flag overrides
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The storage error now behaves like an unset development override, and the focused test covers that behavior. No actionable merge risk is evident. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18744 +/- ##
==========================================
+ Coverage 83.84% 84.82% +0.97%
==========================================
Files 3052 2302 -750
Lines 150982 132108 -18874
Branches 39085 35653 -3432
==========================================
- Hits 126584 112054 -14530
+ Misses 22980 19753 -3227
+ Partials 1418 301 -1117
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 758 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
The change is right and I would take it. One correction, and it is to my own note rather than to this PR: I overstated the exposure, and the description has inherited that.
getDevOverridereturns on!import.meta.env.DEVbefore it ever touches storage, so the throw was never reachable in a production build. This is a dev-build fix, not a production one.- That does not make it not worth doing — a boot-time throw in dev under blocked storage is real and the guard is free — but the framing should not outlive this PR.
- The guard, the comment and the regression are otherwise exactly right.
Full context for agent readers
Where I was wrong. My note on the flag PR said the unguarded localStorage.getItem propagates
"during boot, on a key that selects how the app authenticates". The first line of the function is
if (!import.meta.env.DEV) return undefined, and the docstring above it says it is stripped from
production builds by tree-shaking. I read the try placement and did not read the line above it. So
the blast radius is a developer running a dev build with storage blocked or partitioned, not a
customer. This PR's "Why" section repeats my framing, including the auth-key emphasis; worth
trimming before it merges, because someone will later cite this as a production fix and it is not.
Why I would still merge it. The guard costs nothing, the failure it prevents is real in the
environment where it can happen, and it fixes the whole class at the source rather than at one call
site — resolveFlag and resolveAuthGatedFlag both route through here, so every flag getter
inherits it. That was the reason for preferring this over anything scoped to the new getter, and it
is what this PR does.
The regression is honest. Stubbing getItem to throw a SecurityError and asserting
undefined fails if the try is removed, which is the property asked for. I checked that the
global stub does not leak, since the test sets one with no local cleanup: vite.config.mts sets
unstubGlobals: true alongside mockReset and restoreMocks, so vitest restores it between tests.
No isolation problem.
The comment is the right one. It names the specific consequence — an override skips the
web_session_enabled pairing — rather than describing the mechanism, so a reader who has never seen
the planning page still learns the thing that matters: overriding this key without being in the
paired set puts the frontend on the session flow against a backend that is still answering with a
Firebase cookie.
One thing deliberately unchanged and correct: getSessionOverride already guards its
sessionStorage read, so there was nothing to do on that path, and this PR does not touch it.
|
Good catch on the |
|
|
…age read (#18762) Backport of #18744 to `cloud/1.55`, done by hand because the automatic backport hit a conflict in `src/composables/useFeatureFlags.ts`. ## Why `getDevOverride` read `localStorage` outside its `try`. In a dev build with blocked or partitioned storage, the `SecurityError` escaped into every flag getter that reads a dev override. Production builds are unaffected: the function returns early on `!import.meta.env.DEV`. ## Root cause In dev builds, only `JSON.parse` was guarded; the storage read before it was not. ## How - Included: the guard in `src/utils/devFeatureFlagOverride.ts` and its regression test, cherry-picked from #18744. - Dropped: the one-line note on `unifiedWebSessionEnabled`. That getter comes from #18708, which is not on `cloud/1.55`, and it caused the automatic backport's conflict. ## AS IS / TO BE No UI; the evidence is the test. - AS IS: a throwing `localStorage.getItem` propagates out of `getDevOverride` in a dev build. - TO BE: it returns `undefined`. `pnpm exec vitest run src/utils/devFeatureFlagOverride.test.ts` → 9 passed.
…ge read (#18761) Backport of #18744 to `core/1.55`, done by hand because the automatic backport hit a conflict in `src/composables/useFeatureFlags.ts`. ## Why `getDevOverride` read `localStorage` outside its `try`. In a dev build with blocked or partitioned storage, the `SecurityError` escaped into every flag getter that reads a dev override. Production builds are unaffected: the function returns early on `!import.meta.env.DEV`. ## Root cause In dev builds, only `JSON.parse` was guarded; the storage read before it was not. ## How - Included: the guard in `src/utils/devFeatureFlagOverride.ts` and its regression test, cherry-picked from #18744. - Dropped: the one-line note on `unifiedWebSessionEnabled`. That getter comes from #18708, which is not on `core/1.55`, and it caused the automatic backport's conflict. ## AS IS / TO BE No UI; the evidence is the test. - AS IS: a throwing `localStorage.getItem` propagates out of `getDevOverride` in a dev build. - TO BE: it returns `undefined`. `pnpm exec vitest run src/utils/devFeatureFlagOverride.test.ts` → 9 passed.
Follow-up to the two non-blocking notes on #18708 (FE-2891).
Why
getDevOverridereadlocalStorageoutside itstry. It returns early on!import.meta.env.DEV, so this was never reachable in a production build: in a dev build with blocked or partitioned storage, theSecurityErrorescaped into every flag getter that goes throughresolveFlag,resolveAuthGatedFlagor the dev override. This is a dev-build robustness fix, not a production one.?ff=/ff:overrides ofunified_web_sessionskip the backend's pairing withweb_session_enabled, and the getter did not say so.Root cause
In dev builds,
getDevOverrideonly guardedJSON.parse, not the storage read before it.getSessionOverridealready guards itssessionStorageread, so the gap was specific to the dev-override path.How
localStorage.getItemcall inside atryingetDevOverride; a throwing read resolves to "no override", the same as an unset key. This fixes every caller at once instead of special-casing one getter.unifiedWebSessionEnabled: overrides skip theweb_session_enabledpairing, so anyone overriding the key must also be in that set.AS IS / TO BE
No UI; the evidence is a test.
localStorage.getItempropagates out ofgetDevOverride.getDevOverridereturnsundefined. The new test stubs a throwinglocalStorage; removing the guard turns it red.eslint and oxlint are clean on the changed files.
Links