Repository navigation
fix(account-ui): re-theme Stripe Elements when the theme changes after mount - #18778
Conversation
… scope StripePaymentForm resolved its appearance tokens on a probe appended to document.body. billing-web scopes .dark-theme to a wrapper div, so the probe read the light tokens: dark labels and text over the dark panel, and white input boxes. Resolve the tokens and font inside the payment element's container so they follow the theme the form renders in.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe Stripe payment form resolves appearance values from its theme root and updates mounted Elements when its ChangesStripe payment theme synchronization
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant ColorPaletteStore
participant UnifiedStripePaymentSelector
participant StripePaymentForm
participant StripeElements
ColorPaletteStore->>UnifiedStripePaymentSelector: Change active palette ID
UnifiedStripePaymentSelector->>StripePaymentForm: Pass palette ID as themeKey
StripePaymentForm->>StripeElements: Update appearance resolved from payment target
StripeElements-->>StripePaymentForm: Return update result
Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk remains for the supported palette-change flow. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The new theme signal changes how the payment form looks after a palette switch, not how it validates payment details or creates confirmation tokens. The form keeps its mounted payment and address fields. Rapid overlapping theme updates remain unverified, but no new payment-security failure was established. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The title and commit subjects use the bug-fix signal "fix". The PR changes frontend files under
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1e98c37aa2104c66bcc3b71a89d51e8c1c11f830
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 2132 passed, 0 failed📊 Browser Reports
📦 Bundle: 10 MB gzipDetailsSummary
Category Glance App Entry Points — 3.77 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.45 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 134 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 639 kBConfiguration panels, inspectors, and settings screens
Status: 28 added User & Accounts — 39.4 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 125 kBReusable component library chunks
Status: 16 added Data & Services — 3.97 MBStores, services, APIs, and repositories
Status: 15 added Utilities & Hooks — 576 kBHelpers, composables, and utility bundles
Status: 36 added Vendor & Third-Party — 17.4 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 17.9 MBBundles that do not match a named category
Status: 301 added ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T05:26:42.976Z",
"gitSha": "1c25356909bdf8878eddd19b7190d4e8d00e1c68",
"branch": "fix/account-ui-stripe-retheme-on-theme-change",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.1130000000412,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.480999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.485,
"heapDeltaBytes": -964880,
"heapUsedBytes": 66530196,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.516999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1991.425999999933,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9580000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.60799999999995,
"heapDeltaBytes": -1667664,
"heapUsedBytes": 60665700,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.539000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1840.265000000045,
"styleRecalcs": 71,
"styleRecalcDurationMs": 17.326999999999998,
"layouts": 12,
"layoutDurationMs": 4.49,
"taskDurationMs": 867.453,
"heapDeltaBytes": -4116120,
"heapUsedBytes": 58314604,
"domNodes": -228,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 158.76800000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1835.916999999995,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.467999999999996,
"layouts": 12,
"layoutDurationMs": 4.326,
"taskDurationMs": 855.4159999999999,
"heapDeltaBytes": 8195288,
"heapUsedBytes": 70569640,
"domNodes": -228,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 153.593,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.5210000000002,
"styleRecalcs": 28,
"styleRecalcDurationMs": 10.857999999999997,
"layouts": 6,
"layoutDurationMs": 1.585,
"taskDurationMs": 343.293,
"heapDeltaBytes": 2175220,
"heapUsedBytes": 64419564,
"domNodes": 53,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.251000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.7959999999503,
"styleRecalcs": 29,
"styleRecalcDurationMs": 10.297999999999998,
"layouts": 6,
"layoutDurationMs": 1.39,
"taskDurationMs": 340.56199999999995,
"heapDeltaBytes": 2206704,
"heapUsedBytes": 64082992,
"domNodes": 53,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.448000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 726.1579999999981,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.998999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.78,
"heapDeltaBytes": 18258980,
"heapUsedBytes": 80480080,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 170.327,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 675.5469999999377,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.4669999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.253,
"heapDeltaBytes": 18598420,
"heapUsedBytes": 81016672,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 164.388,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1211.484999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 885.3729999999999,
"heapDeltaBytes": 12371500,
"heapUsedBytes": 98655820,
"domNodes": -259,
"jsHeapTotalBytes": 22433792,
"scriptDurationMs": 68.106,
"eventListeners": -185,
"totalBlockingTimeMs": 589,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1142.0940000000428,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 819.6310000000001,
"heapDeltaBytes": 34685544,
"heapUsedBytes": 102457340,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 63.462,
"eventListeners": 0,
"totalBlockingTimeMs": 540,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 812.1439999999893,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.44499999999977,
"heapDeltaBytes": 15150800,
"heapUsedBytes": 90855208,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 140.91799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 190,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 810.6520000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.29600000000005,
"heapDeltaBytes": 14180888,
"heapUsedBytes": 91219348,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.002,
"eventListeners": 0,
"totalBlockingTimeMs": 190,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9065.796999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8224.36,
"heapDeltaBytes": 2481048,
"heapUsedBytes": 84830696,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 6740.309,
"eventListeners": 0,
"totalBlockingTimeMs": 693,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8763.048000000026,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04799999999999943,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7938.991,
"heapDeltaBytes": 710088,
"heapUsedBytes": 77413672,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6242.4169999999995,
"eventListeners": -164,
"totalBlockingTimeMs": 196,
"frameDurationMs": 19.44333333333331,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9463.730999999996,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.060000000000001025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8605.981,
"heapDeltaBytes": -4215620,
"heapUsedBytes": 72837856,
"domNodes": -228,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 6751.793,
"eventListeners": -164,
"totalBlockingTimeMs": 431,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9056.87999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8310.565999999999,
"heapDeltaBytes": 9080004,
"heapUsedBytes": 91707892,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 6551.638000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 208,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2040.4000000000337,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.326999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.1560000000001,
"heapDeltaBytes": -6550112,
"heapUsedBytes": 74702776,
"domNodes": -228,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 33.745,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.5289999999495,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.311999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.0699999999998,
"heapDeltaBytes": 1546248,
"heapUsedBytes": 82746032,
"domNodes": -228,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 33.262,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2760.270999999989,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.595,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1707.506,
"heapDeltaBytes": -16506200,
"heapUsedBytes": 65769460,
"domNodes": -228,
"jsHeapTotalBytes": 2650112,
"scriptDurationMs": 832.9440000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2895.3649999999698,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.835000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1672.567,
"heapDeltaBytes": 19816372,
"heapUsedBytes": 84274472,
"domNodes": -228,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 847.3340000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3905.9540000000084,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.654,
"layouts": 60,
"layoutDurationMs": 14.391,
"taskDurationMs": 1742.113,
"heapDeltaBytes": 9354384,
"heapUsedBytes": 74588472,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 783.369,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3857.6450000000477,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.938999999999997,
"layouts": 60,
"layoutDurationMs": 14.244,
"taskDurationMs": 1722.537,
"heapDeltaBytes": 8380124,
"heapUsedBytes": 74390928,
"domNodes": -4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 782.089,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3243.1249999999636,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.375,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2088.817,
"heapDeltaBytes": -642372,
"heapUsedBytes": 84494064,
"domNodes": -228,
"jsHeapTotalBytes": 5951488,
"scriptDurationMs": 999.0790000000001,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3148.078999999939,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.432000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1826.3360000000002,
"heapDeltaBytes": -11948892,
"heapUsedBytes": 73266728,
"domNodes": 0,
"jsHeapTotalBytes": 7630848,
"scriptDurationMs": 995.0580000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 34,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2046.9359999999597,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.9879999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.045,
"heapDeltaBytes": -7902024,
"heapUsedBytes": 80120388,
"domNodes": -228,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.392,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 1990.336999999954,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.6780000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.024,
"heapDeltaBytes": 19683832,
"heapUsedBytes": 84583892,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.841999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 632.2000000000116,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.191000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.74099999999993,
"heapDeltaBytes": 13799092,
"heapUsedBytes": 76503592,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 138.69,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 684.2930000000251,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.177,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.401,
"heapDeltaBytes": 13197712,
"heapUsedBytes": 76929908,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 151.25900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2008.5010000000239,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.409999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.89799999999997,
"heapDeltaBytes": -4967284,
"heapUsedBytes": 58552396,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.263,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.9909999999845,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.132000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.50800000000004,
"heapDeltaBytes": 8731660,
"heapUsedBytes": 72233216,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.744000000000002,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1699.4190000000344,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.455,
"layouts": 16,
"layoutDurationMs": 5.895,
"taskDurationMs": 837.756,
"heapDeltaBytes": -4466532,
"heapUsedBytes": 59094104,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 103.072,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.8499999999704,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.799000000000003,
"layouts": 16,
"layoutDurationMs": 5.811999999999999,
"taskDurationMs": 822.764,
"heapDeltaBytes": 7278624,
"heapUsedBytes": 70910704,
"domNodes": -244,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 103.863,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.433000000021,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.942,
"layouts": 5,
"layoutDurationMs": 11.109,
"taskDurationMs": 931.0590000000001,
"heapDeltaBytes": -6300960,
"heapUsedBytes": 81229940,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.130999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9997.736999999972,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.353,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6191.1449999999995,
"heapDeltaBytes": -13146268,
"heapUsedBytes": 68436404,
"domNodes": -228,
"jsHeapTotalBytes": 2387968,
"scriptDurationMs": 2898.285,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8842.733000000066,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.528000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5340.249,
"heapDeltaBytes": -15404104,
"heapUsedBytes": 66168176,
"domNodes": -228,
"jsHeapTotalBytes": 2650112,
"scriptDurationMs": 2767.7329999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14976.820000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14692.649000000001,
"heapDeltaBytes": -41358460,
"heapUsedBytes": 193613340,
"domNodes": -8049,
"jsHeapTotalBytes": -6938624,
"scriptDurationMs": 250.332,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 15069.155000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14781.091,
"heapDeltaBytes": -56847640,
"heapUsedBytes": 163619556,
"domNodes": -8049,
"jsHeapTotalBytes": -19599360,
"scriptDurationMs": 280.82,
"eventListeners": -14923,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18467.95899999995,
"styleRecalcs": 129,
"styleRecalcDurationMs": 15.776999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18341.477000000003,
"heapDeltaBytes": -72762404,
"heapUsedBytes": 167024372,
"domNodes": -8049,
"jsHeapTotalBytes": -18731008,
"scriptDurationMs": 853.506,
"eventListeners": -14923,
"totalBlockingTimeMs": 20,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 18310.38699999999,
"styleRecalcs": 127,
"styleRecalcDurationMs": 15.561999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18156.996,
"heapDeltaBytes": -61471068,
"heapUsedBytes": 178290476,
"domNodes": -8049,
"jsHeapTotalBytes": -17981440,
"scriptDurationMs": 844.957,
"eventListeners": -14923,
"totalBlockingTimeMs": 17,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5528.772000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.47099999999999,
"layouts": 20,
"layoutDurationMs": 25.52,
"taskDurationMs": 5477.000999999999,
"heapDeltaBytes": -47076596,
"heapUsedBytes": 171813936,
"domNodes": -8050,
"jsHeapTotalBytes": 9691136,
"scriptDurationMs": 95.409,
"eventListeners": -14923,
"totalBlockingTimeMs": 297,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5530.877000000032,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.92099999999999,
"layouts": 20,
"layoutDurationMs": 26.904999999999998,
"taskDurationMs": 5495.068,
"heapDeltaBytes": -66305684,
"heapUsedBytes": 174279184,
"domNodes": -8049,
"jsHeapTotalBytes": 12517376,
"scriptDurationMs": 95.403,
"eventListeners": -14923,
"totalBlockingTimeMs": 414,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7602.426000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7437.598999999998,
"heapDeltaBytes": 20497080,
"heapUsedBytes": 183863344,
"domNodes": 0,
"jsHeapTotalBytes": -22544384,
"scriptDurationMs": 115.643,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7695.499000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7548.862000000002,
"heapDeltaBytes": -4231124,
"heapUsedBytes": 184222988,
"domNodes": 0,
"jsHeapTotalBytes": -26476544,
"scriptDurationMs": 120.82199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 477.4599999999509,
"styleRecalcs": 21,
"styleRecalcDurationMs": 21.906999999999996,
"layouts": 3,
"layoutDurationMs": 1.5790000000000002,
"taskDurationMs": 150.33300000000003,
"heapDeltaBytes": 5242284,
"heapUsedBytes": 67194512,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 17.808,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 450.6169999999656,
"styleRecalcs": 15,
"styleRecalcDurationMs": 20.754,
"layouts": 4,
"layoutDurationMs": 2.165,
"taskDurationMs": 128.55299999999997,
"heapDeltaBytes": 4936808,
"heapUsedBytes": 66940000,
"domNodes": 101,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.114,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18778 +/- ##
==========================================
- Coverage 83.92% 83.90% -0.02%
==========================================
Files 3055 3055
Lines 151149 151155 +6
Branches 39124 41427 +2303
==========================================
- Hits 126855 126832 -23
- Misses 22885 22913 +28
- Partials 1409 1410 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…-retheme-on-theme-change # Conflicts: # packages/account-ui/src/billing/stripe/StripePaymentForm.test.ts # packages/account-ui/src/billing/stripe/StripePaymentForm.vue
christian-byrne
left a comment
There was a problem hiding this comment.
Approving at 16076a87. This closes the note left on the dark-mode PR, and the two details most likely to be got wrong are both right.
- It calls
elements.update({ appearance })rather than recreating, so a customer mid-way through entering a card keeps what they typed. flush: 'post'is the one that matters: the colours are resolved after the DOM has the new theme class, not before.themeKeydefaults to empty, so billing-web is untouched and the watcher never fires there.
Full context for agent readers
Why flush: 'post' is load-bearing. resolveAppearance works by appending a probe element and
reading its computed colour, so it reports whatever the cascade says at the moment it runs. With the
default 'pre' flush the watcher would fire before Vue applied the new palette class, the probe
would read the outgoing theme, and the form would re-theme itself to the colour scheme the user
just left — a bug that looks exactly like the watcher not firing at all, and is much harder to
diagnose. Getting this right is the difference between the feature working and appearing to work in
a test that stubs the DOM.
update rather than recreate. Tearing down and re-creating Elements on a theme change would
discard in-progress card entry. Using elements.update({ appearance }) keeps the mounted Element and
its state, and it mirrors how the existing amount/currency watcher already updates in place, so there
is one pattern here rather than two.
Correctly inert where it is not wanted. themeKey defaults to '' and only the cloud app passes
one, so billing-web's behaviour is unchanged — appropriate, since its theme is fixed per page load
and the scope fix from the earlier PR already resolves its colours correctly at creation. The
watcher also has no immediate: true, which is right: onMounted already resolves the appearance
once at creation, and firing again immediately would be a wasted round-trip.
The host key is the right granularity. Passing colorPaletteStore.activePaletteId rather than a
dark/light boolean means any palette change re-themes, not just the two-way toggle — so this does not
need revisiting when a third palette appears.
Guards and failure handling match the surrounding code. The early return covers a theme change
arriving before the async mount completes, and the .catch reports
payment_element_failed / element_phase: 'update' exactly as the amount/currency watcher does, so a
failed re-theme is visible rather than silent.
Checked: no open threads, no pending checks, nothing failing once CANCELLED superseded runs are
set aside. resolveAppearance still resolves against the form's own theme root, so the scope fix it
builds on is preserved rather than quietly reverted.
|
|
…he theme changes after mount (#18826) Backport of #18778 to `core/1.55` (cherry-pick -x of bf313c7). ## Why testcloud runs `cloud/1.55`; Stripe Elements must re-theme when the palette changes after mount there too. ## Root cause See #18778: the Elements appearance was set only at mount. ## How Cherry-picked cleanly onto #18791's head. The auto-backport conflicted because #18686's backport (#18791) is not on `core/1.55` yet, so this diff includes #18791's commit until it merges. Merge #18791 first. ## AS IS / TO BE Same as #18778.
…the theme changes after mount (#18827) Backport of #18778 to `cloud/1.55` (cherry-pick -x of bf313c7). ## Why testcloud runs `cloud/1.55`; Stripe Elements must re-theme when the palette changes after mount there too. ## Root cause See #18778: the Elements appearance was set only at mount. ## How Cherry-picked cleanly onto #18792's head. The auto-backport conflicted because #18686's backport (#18792) is not on `cloud/1.55` yet, so this diff includes #18792's commit until it merges. Merge #18792 first. ## AS IS / TO BE Same as #18778.
Summary
Stripe Elements now follow a theme switch that happens after the checkout form has mounted: the appearance is re-resolved from the form's theme root and applied with
elements.update({ appearance }), without remounting the Payment/Address Elements.Why
Follow-up to #18686. @christian-byrne's non-blocking note in his approval: "the appearance is still resolved once at Element creation, so a theme change after mount will not re-theme the form."
Root cause
Stripe's
appearancetakes concrete colour strings.StripePaymentFormresolved them once insideonMountedand passed them tostripe.elements(...), and nothing re-read them afterwards. In the cloud app the palette is live:GraphViewtoggles.dark-themeon<html>andcolorPaletteServicerewrites root CSS variables whenevercolorPaletteStore.activePaletteIdchanges. A palette switch with the pricing dialog open left the Stripe form in the old colours.Changes
packages/account-uiStripePaymentForm.vue: appearance building extracted intoresolveAppearance(themeRoot). New optionalthemeKeyprop; when it changes, aflush: 'post'watcher re-resolves against the same theme root and callselements.update({ appearance }). The Elements are not recreated or remounted, so entered card/address data survives. A rejected update reportspayment_element_failed/element_phase: 'update'but does not block payment, since it is cosmetic.UnifiedStripePaymentSelector.vue(cloud host) passescolorPaletteStore.activePaletteIdasthemeKey, reusing the store signal the app already uses to drive its theme, so no MutationObserver is needed.apps/billing-webis unchanged:.dark-themeis hardcoded on its wrapper with no live toggle, so it leavesthemeKeyunset.themeKeyis optional).Review Focus
account-uihost-agnostic and style-less. The package does not observe the DOM or know which theme system the host uses. Observing the theme root's class would not have worked for the cloud app anyway, because the class is on<html>, not on the form's root.flush: 'post'makes sure the host's pre-flush watcher (class toggle) and the palette's CSS variable writes land before the probe reads computed colours.Red → green: the new component test mounts under light tokens, switches the theme root to dark and bumps
themeKey, then assertselements.updatewas called with the darkcolorText/colorBackgroundand thatstripe.elements/create/mounteach ran only once with nodestroy. It fails on b690eb5 (test only) and passes on 3b7374e.Plan position
Screenshots
AS IS / TO BE: placeholder, to be added