Repository navigation
[backport core/1.55] fix: subgraph-interior widgets don't render in Vue mode after insert_workflow - #18677
Conversation
…workflow (#18634) ## Summary Fixes missing Vue widgets on nodes inside a subgraph inserted through `insert_workflow`. Multiplayer assigns inserted nodes colon-bearing local IDs. Those IDs cannot be represented safely as colon-delimited locator or execution paths, so widget rendering now resolves live nodes from the existing `(graphId, nodeId)` state instead. ## Changes - Resolve widget hosts directly within their owning graph without parsing the local node ID. - Continue rendering and updating stored widgets when no valid execution ID exists, while skipping execution-keyed error operations. - Prevent `LGraph.getNodeById` from returning inherited object properties. - Cover the real insert/projection/widget-model path, the pre-graph-ready fallback, scope collisions, and inherited registry keys. ## Verification - `pnpm exec vitest run src/lib/litegraph/src/LGraph.test.ts src/utils/graphTraversalUtil.test.ts src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts src/renderer/extensions/vueNodes/composables/insertWorkflowSubgraphInteriorWidgets.regression.test.ts` (280 passed) - `pnpm typecheck:app` - ESLint, type-aware oxlint, formatting, and Knip passed on the changed files. ---------
🎭 Playwright: ✅ 2116 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e1edc04062b3865d0fd0b1c66473539bdac36979
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T11:46:08.105Z",
"gitSha": "9883defbab21521104d61e512496f591ef0b39a2",
"branch": "backport-18634-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1996.3500000000067,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.679,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.217,
"heapDeltaBytes": 4655084,
"heapUsedBytes": 71360540,
"domNodes": -258,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.493000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1992.746000000011,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.301,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.83799999999997,
"heapDeltaBytes": 8636384,
"heapUsedBytes": 76183724,
"domNodes": -258,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.599999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.27900000002,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.128,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 761.856,
"heapDeltaBytes": -12568584,
"heapUsedBytes": 54855532,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 154.46099999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.7150000000283,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.729000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 777.242,
"heapDeltaBytes": 3704752,
"heapUsedBytes": 71334040,
"domNodes": -260,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 157.191,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1663.3049999999798,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.986,
"layouts": 6,
"layoutDurationMs": 0.885,
"taskDurationMs": 316.4789999999999,
"heapDeltaBytes": 3151172,
"heapUsedBytes": 70707624,
"domNodes": 79,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.913000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.3989999999721,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.555000000000001,
"layouts": 6,
"layoutDurationMs": 1.111,
"taskDurationMs": 321.83000000000004,
"heapDeltaBytes": 3064220,
"heapUsedBytes": 70718932,
"domNodes": 79,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.621999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 616.9199999999933,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.940000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.336,
"heapDeltaBytes": 18835520,
"heapUsedBytes": 86686696,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 167.018,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 597.705000000019,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.665,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.71900000000005,
"heapDeltaBytes": 18952564,
"heapUsedBytes": 85666900,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 168.933,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1245.3500000000304,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 921.137,
"heapDeltaBytes": -13845564,
"heapUsedBytes": 72515364,
"domNodes": -295,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 73.128,
"eventListeners": -217,
"totalBlockingTimeMs": 581,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1167.5420000000258,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 814.758,
"heapDeltaBytes": 12327896,
"heapUsedBytes": 82561624,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 68.25399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 545,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 849.3969999999536,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.97599999999994,
"heapDeltaBytes": 15595232,
"heapUsedBytes": 91970104,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 170.896,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.5689999999549,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.5830000000002,
"heapDeltaBytes": 14843496,
"heapUsedBytes": 91374860,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.77700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9925.483000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8974.889,
"heapDeltaBytes": 2647296,
"heapUsedBytes": 84786752,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7674.277,
"eventListeners": 0,
"totalBlockingTimeMs": 1148,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10160.500999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9318.702,
"heapDeltaBytes": 12643812,
"heapUsedBytes": 93777540,
"domNodes": -10,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7734.642,
"eventListeners": 0,
"totalBlockingTimeMs": 920,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10949.962000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10091.690999999999,
"heapDeltaBytes": 10135740,
"heapUsedBytes": 86326940,
"domNodes": -10,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 8447.139,
"eventListeners": 0,
"totalBlockingTimeMs": 1517,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10898.067999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10077.147,
"heapDeltaBytes": 1540468,
"heapUsedBytes": 83725072,
"domNodes": -14,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 8441.314,
"eventListeners": 0,
"totalBlockingTimeMs": 1366,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2034.086000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.882000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.0479999999999,
"heapDeltaBytes": -3371268,
"heapUsedBytes": 83615788,
"domNodes": -238,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 34.564,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2055.4590000000417,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.684999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.3889999999999,
"heapDeltaBytes": -5569316,
"heapUsedBytes": 81034608,
"domNodes": -245,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.178,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2283.6869999999863,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.807000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1635.5110000000002,
"heapDeltaBytes": -10884904,
"heapUsedBytes": 76494916,
"domNodes": -244,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 850.3870000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2248.9930000000413,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.694,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1640.992,
"heapDeltaBytes": -12294156,
"heapUsedBytes": 75678484,
"domNodes": -221,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 868.449,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3495.568999999989,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.259000000000002,
"layouts": 60,
"layoutDurationMs": 13.054,
"taskDurationMs": 1666.088,
"heapDeltaBytes": 8482968,
"heapUsedBytes": 74484856,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 791.607,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3474.256999999966,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.297999999999998,
"layouts": 60,
"layoutDurationMs": 12.649000000000001,
"taskDurationMs": 1674.712,
"heapDeltaBytes": -15154204,
"heapUsedBytes": 74087828,
"domNodes": -248,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 779.9730000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2929.0090000000077,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.235999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1810.5690000000002,
"heapDeltaBytes": -17184388,
"heapUsedBytes": 73868740,
"domNodes": -228,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 1002.96,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3075.1169999999775,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.631999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1912.784,
"heapDeltaBytes": 26412248,
"heapUsedBytes": 92210540,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1011.9659999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.607999999967,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.723000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.4140000000001,
"heapDeltaBytes": -4428136,
"heapUsedBytes": 84138644,
"domNodes": -248,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 34.604,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.4289999999219,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.978999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.3740000000001,
"heapDeltaBytes": -4485532,
"heapUsedBytes": 84252424,
"domNodes": -244,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 30.961000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.5570000000507,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.002999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.98999999999995,
"heapDeltaBytes": 14073804,
"heapUsedBytes": 83625136,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 142.287,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 570.8339999999907,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.834,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.347,
"heapDeltaBytes": 13798216,
"heapUsedBytes": 83680864,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.853,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.1230000000492,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.551,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.054,
"heapDeltaBytes": 8901328,
"heapUsedBytes": 77897996,
"domNodes": -274,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.537000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.2310000000707,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.045,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.10600000000005,
"heapDeltaBytes": -4644592,
"heapUsedBytes": 57340256,
"domNodes": 21,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.855,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.375999999997,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.734000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 714.3729999999999,
"heapDeltaBytes": 10570828,
"heapUsedBytes": 80297896,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 101.13600000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.8660000000045,
"styleRecalcs": 45,
"styleRecalcDurationMs": 12.586,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 700.412,
"heapDeltaBytes": -6048524,
"heapUsedBytes": 63907276,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 98.842,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.2030000000705,
"styleRecalcs": 16,
"styleRecalcDurationMs": 27.703,
"layouts": 5,
"layoutDurationMs": 12.764999999999999,
"taskDurationMs": 867.6010000000001,
"heapDeltaBytes": -6347092,
"heapUsedBytes": 87008924,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 29.438,
"eventListeners": 2383,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8293.443999999965,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.833000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5598.206,
"heapDeltaBytes": -5858320,
"heapUsedBytes": 81096044,
"domNodes": -241,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 2717.817,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8389.0090000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.774,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5715.497,
"heapDeltaBytes": -10884420,
"heapUsedBytes": 76066612,
"domNodes": -246,
"jsHeapTotalBytes": 2842624,
"scriptDurationMs": 2782.5229999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16507.13000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15867.998,
"heapDeltaBytes": -39793096,
"heapUsedBytes": 173704596,
"domNodes": -8061,
"jsHeapTotalBytes": -13778944,
"scriptDurationMs": 239.466,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16500.079000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15854.855999999998,
"heapDeltaBytes": -73019896,
"heapUsedBytes": 165068104,
"domNodes": -8061,
"jsHeapTotalBytes": -14352384,
"scriptDurationMs": 244.214,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19975.92800000001,
"styleRecalcs": 167,
"styleRecalcDurationMs": 16.483999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19677.55,
"heapDeltaBytes": -42639408,
"heapUsedBytes": 191763348,
"domNodes": -8061,
"jsHeapTotalBytes": -12926976,
"scriptDurationMs": 913.869,
"eventListeners": -14928,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15735.539000000017,
"styleRecalcs": 88,
"styleRecalcDurationMs": 12.225000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15239.096999999998,
"heapDeltaBytes": -40950740,
"heapUsedBytes": 179021980,
"domNodes": -8061,
"jsHeapTotalBytes": -20774912,
"scriptDurationMs": 873.796,
"eventListeners": -14928,
"totalBlockingTimeMs": 82,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5871.939999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.58500000000001,
"layouts": 20,
"layoutDurationMs": 21.62,
"taskDurationMs": 5749.445999999999,
"heapDeltaBytes": -37638604,
"heapUsedBytes": 176592280,
"domNodes": -8060,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 104.99100000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 326,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5889.272000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.01799999999997,
"layouts": 20,
"layoutDurationMs": 21.923000000000012,
"taskDurationMs": 5824.713999999999,
"heapDeltaBytes": -45945772,
"heapUsedBytes": 194780860,
"domNodes": -8061,
"jsHeapTotalBytes": 10067968,
"scriptDurationMs": 100.06200000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 376,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8238.547999999922,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7877.574999999998,
"heapDeltaBytes": -1916616,
"heapUsedBytes": 175991148,
"domNodes": 0,
"jsHeapTotalBytes": -13893632,
"scriptDurationMs": 137.18600000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8386.396999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8103.035999999999,
"heapDeltaBytes": 4067692,
"heapUsedBytes": 171153224,
"domNodes": 0,
"jsHeapTotalBytes": -24379392,
"scriptDurationMs": 116.21099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 479.39499999995405,
"styleRecalcs": 21,
"styleRecalcDurationMs": 29.233999999999998,
"layouts": 6,
"layoutDurationMs": 2.913,
"taskDurationMs": 138.464,
"heapDeltaBytes": 5354720,
"heapUsedBytes": 70760916,
"domNodes": 157,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.933,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 105.52799999993567,
"styleRecalcs": 9,
"styleRecalcDurationMs": 21.403,
"layouts": 4,
"layoutDurationMs": 1.793,
"taskDurationMs": 82.10199999999998,
"heapDeltaBytes": 3063724,
"heapUsedBytes": 68728868,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.773999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @huang47.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 6 |
| 🟢 Low | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #18677 +/- ##
=============================================
+ Coverage 83.65% 84.52% +0.86%
=============================================
Files 3019 2294 -725
Lines 148883 131391 -17492
Branches 40342 33578 -6764
=============================================
- Hits 124553 111054 -13499
+ Misses 23027 20037 -2990
+ Partials 1303 300 -1003
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 735 files with indirect coverage changes 🚀 New features to boost your workflow:
|
- getNodeByState: normalize graphId comparison through subgraphIdFromState so a falsy/empty graphId still resolves against the root graph, matching the "empty = root graph" convention documented elsewhere in the codebase. - executionIdFromState: resolve the node via getNodeByState (graph identity) instead of the old locator-string parsing, which could misattribute a root-owned colon-bearing id to an unrelated interior node when it happened to look like a <uuid>:<id> locator. The fallback execution id is now always the colon-tolerant leaf variant, so a resolvable subgraph-interior node with a colon-bearing local id (PM-1580 remapped insert_workflow ids) no longer silently loses its execution id (and with it, error highlighting and clearing). - widgetNodeLocatorId: only reject a colon-bearing widget id when it is genuinely ambiguous (i.e. needs a subgraph-uuid prefix); a root-owned PM-1580 id has no prefix to collide with and can be kept whole, same as the old createLeafNodeLocatorId behavior. - LGraph._nodes_by_id: back the index with a null-prototype object so a node id of literally "__proto__" becomes an own property instead of reparenting the index's own prototype via the inherited setter. - hasWidgetError / computeProcessedWidgets: look up lastNodeErrors with an Object.hasOwn guard so an execution id that names an inherited Object.prototype property (e.g. "constructor") can't return an inherited function in place of a real error record.
83753e7 to
2f00621
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, and the diff contains no conflict markers. Required checks on this branch are lint-and-format, test and e2e-status; any other red check here is advisory and does not gate the merge.
I force-pushed this branch to strip Co-authored-by trailers for claude/Amp from the commit messages, which is what Check for AI agent co-author trailers was failing on. Message-only rewrite: the tree hash is identical to before, so the code is untouched.
Backport of #18634 to
core/1.55Automatically created by backport workflow.