Repository navigation
fix(cloud/1.55): guard keybind Escape target - #20065
Conversation
event.composedPath()[0] is typed as HTMLElement but is not guaranteed to actually be one. When no element has focus, some browsers (Safari) fire the keydown with document as the target instead of document.body, and Document has no closest() method, throwing `TypeError: target.closest is not a function` from keybindHandler. Guard the role="menu"/menubar Escape check with `target instanceof Element` before calling closest() so a non-Element target falls through to the normal Escape handling instead of throwing. (cherry picked from commit 8c71085)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2149 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 660f9d01c3cb62cb8b354ea2ca9bf3aabdaa5f9e
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-04T04:46:27.179Z",
"gitSha": "140f3102292ee7a84c333c3208d3d6dbe4b3d405",
"branch": "backport/18620-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2003.4420000000068,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.427,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 278.77599999999995,
"heapDeltaBytes": -10225848,
"heapUsedBytes": 58523604,
"domNodes": -256,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.058999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2002.1869999999353,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.330000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.534,
"heapDeltaBytes": -7733568,
"heapUsedBytes": 60976808,
"domNodes": -257,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.192999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1679.0279999999598,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.684999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.77000000000004,
"heapDeltaBytes": 9992264,
"heapUsedBytes": 78772940,
"domNodes": -257,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 88.837,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1726.2839999999642,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.333,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.811,
"heapDeltaBytes": -9040520,
"heapUsedBytes": 59963656,
"domNodes": -259,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 118.051,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.4170000000108,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.423999999999998,
"layouts": 6,
"layoutDurationMs": 1.028,
"taskDurationMs": 236.24900000000005,
"heapDeltaBytes": 3001440,
"heapUsedBytes": 71650800,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.099,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.6830000000646,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.709000000000001,
"layouts": 6,
"layoutDurationMs": 0.9870000000000002,
"taskDurationMs": 184.709,
"heapDeltaBytes": 2181268,
"heapUsedBytes": 64933284,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.982,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 426.3890000000288,
"styleRecalcs": 16,
"styleRecalcDurationMs": 8.219000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.933,
"heapDeltaBytes": 18498408,
"heapUsedBytes": 86665240,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 103.715,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 464.8690000000215,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.5329999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.607,
"heapDeltaBytes": 18278328,
"heapUsedBytes": 81043800,
"domNodes": 19,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 113.06400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 923.1379999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.3,
"heapDeltaBytes": 35916832,
"heapUsedBytes": 102616272,
"domNodes": 0,
"jsHeapTotalBytes": 18247680,
"scriptDurationMs": 38.212999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 327,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 869.2839999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.73900000000003,
"heapDeltaBytes": 11834960,
"heapUsedBytes": 89490372,
"domNodes": 0,
"jsHeapTotalBytes": 20869120,
"scriptDurationMs": 38.04800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 271,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 669.7459999999751,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 253.83900000000014,
"heapDeltaBytes": 14279076,
"heapUsedBytes": 91749332,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 87.60500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 83,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 687.6320000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 279.10800000000035,
"heapDeltaBytes": 15052028,
"heapUsedBytes": 90779412,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 96.111,
"eventListeners": 0,
"totalBlockingTimeMs": 84,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5894.145000000037,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.1509999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4832.661,
"heapDeltaBytes": -14531396,
"heapUsedBytes": 69523488,
"domNodes": -20,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 3934.1389999999997,
"eventListeners": -4,
"totalBlockingTimeMs": 21,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6438.486000000012,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.4879999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5088.437,
"heapDeltaBytes": -8383208,
"heapUsedBytes": 72733420,
"domNodes": -12,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 4121.432000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6343.215000000044,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.184000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4938.589,
"heapDeltaBytes": 9413656,
"heapUsedBytes": 87892004,
"domNodes": -252,
"jsHeapTotalBytes": 12574720,
"scriptDurationMs": 3991.956,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6019.728999999984,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.4229999999999972,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4836.385,
"heapDeltaBytes": 8969544,
"heapUsedBytes": 87084668,
"domNodes": -260,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 3850.82,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2009.2789999999923,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.468000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.359,
"heapDeltaBytes": -24229936,
"heapUsedBytes": 64989388,
"domNodes": -249,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 26.723000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2009.7729999999956,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.9769999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.31100000000004,
"heapDeltaBytes": -17003184,
"heapUsedBytes": 65391144,
"domNodes": -253,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 28.994,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2100.6270000000313,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.836000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1085.344,
"heapDeltaBytes": -1405428,
"heapUsedBytes": 88309784,
"domNodes": -242,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 552.4559999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2111.509999999953,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.906,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1108.873,
"heapDeltaBytes": 31472,
"heapUsedBytes": 64461700,
"domNodes": 14,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 580.8149999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3097.182000000032,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.625,
"layouts": 60,
"layoutDurationMs": 14.309000000000001,
"taskDurationMs": 1127.6320000000003,
"heapDeltaBytes": 25224688,
"heapUsedBytes": 90265040,
"domNodes": 38,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 521.316,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3188.543999999979,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.043,
"layouts": 60,
"layoutDurationMs": 14.616,
"taskDurationMs": 1206.207,
"heapDeltaBytes": -17458016,
"heapUsedBytes": 73324420,
"domNodes": -234,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 527.006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2237.528999999995,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.968,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1244.641,
"heapDeltaBytes": 2508852,
"heapUsedBytes": 68501616,
"domNodes": 14,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 643.362,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2294.826999999941,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.621,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1352.347,
"heapDeltaBytes": 2753076,
"heapUsedBytes": 68561436,
"domNodes": 10,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 700.8800000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1995.1719999999682,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.989999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.943,
"heapDeltaBytes": 9889120,
"heapUsedBytes": 73909144,
"domNodes": -236,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.388999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2006.3299999999344,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.864,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.526,
"heapDeltaBytes": -23247276,
"heapUsedBytes": 67356292,
"domNodes": -246,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 28.903000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 414.211000000023,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.02,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.83299999999997,
"heapDeltaBytes": 13256892,
"heapUsedBytes": 83892296,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 98.06099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.64100000002145,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.184,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 249.568,
"heapDeltaBytes": 13188824,
"heapUsedBytes": 83745696,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 93.271,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1991.628999999989,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.244,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.48299999999995,
"heapDeltaBytes": -5176452,
"heapUsedBytes": 59044924,
"domNodes": -274,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 7.341,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.809999999963,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.945,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.59499999999997,
"heapDeltaBytes": 6294568,
"heapUsedBytes": 76962884,
"domNodes": -273,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.867999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.6010000000106,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.081999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.6899999999999,
"heapDeltaBytes": -11413164,
"heapUsedBytes": 59430172,
"domNodes": -274,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 86.45,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.585999999982,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.174000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.7890000000001,
"heapDeltaBytes": -12692820,
"heapUsedBytes": 58119200,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 83.55000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 801.1070000000018,
"styleRecalcs": 17,
"styleRecalcDurationMs": 20.729000000000003,
"layouts": 5,
"layoutDurationMs": 8.621,
"taskDurationMs": 636.7149999999999,
"heapDeltaBytes": 19332728,
"heapUsedBytes": 108039920,
"domNodes": 13667,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 21.990000000000002,
"eventListeners": 2383,
"totalBlockingTimeMs": 76,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8122.147999999981,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.248000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3806.332,
"heapDeltaBytes": -5585088,
"heapUsedBytes": 76455348,
"domNodes": -252,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 1874.154,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8139.034000000038,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3818.8179999999998,
"heapDeltaBytes": -4023204,
"heapUsedBytes": 84769272,
"domNodes": -244,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 1865.586,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 11631.664,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11264.203,
"heapDeltaBytes": -50682488,
"heapUsedBytes": 189980144,
"domNodes": -8062,
"jsHeapTotalBytes": -13262848,
"scriptDurationMs": 159.775,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11668.784999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11283.673999999999,
"heapDeltaBytes": -30320988,
"heapUsedBytes": 196095224,
"domNodes": -8062,
"jsHeapTotalBytes": -20262912,
"scriptDurationMs": 152.03,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13866.592999999966,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.044,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13678.785000000002,
"heapDeltaBytes": -32657712,
"heapUsedBytes": 193603160,
"domNodes": -8062,
"jsHeapTotalBytes": -21381120,
"scriptDurationMs": 597.843,
"eventListeners": -14928,
"totalBlockingTimeMs": 1,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13704.077999999981,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.854000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13281.824999999999,
"heapDeltaBytes": -53941240,
"heapUsedBytes": 181847184,
"domNodes": -8062,
"jsHeapTotalBytes": -14540800,
"scriptDurationMs": 569.3589999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4089.576999999963,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.44500000000002,
"layouts": 20,
"layoutDurationMs": 29.337000000000003,
"taskDurationMs": 4052.875,
"heapDeltaBytes": -29011896,
"heapUsedBytes": 190696304,
"domNodes": -8062,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 61.474000000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 3,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4333.837000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.62,
"layouts": 20,
"layoutDurationMs": 22.910000000000007,
"taskDurationMs": 4252.399,
"heapDeltaBytes": -28305964,
"heapUsedBytes": 197767244,
"domNodes": -8061,
"jsHeapTotalBytes": 15982592,
"scriptDurationMs": 70.158,
"eventListeners": -14928,
"totalBlockingTimeMs": 13,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5892.542000000049,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5828.5160000000005,
"heapDeltaBytes": -7079648,
"heapUsedBytes": 171035272,
"domNodes": 0,
"jsHeapTotalBytes": -29097984,
"scriptDurationMs": 80.31299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6011.854999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5757.039000000001,
"heapDeltaBytes": -5009076,
"heapUsedBytes": 199502000,
"domNodes": 0,
"jsHeapTotalBytes": -38797312,
"scriptDurationMs": 79.16499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 426.2109999999666,
"styleRecalcs": 15,
"styleRecalcDurationMs": 19.574,
"layouts": 3,
"layoutDurationMs": 0.928,
"taskDurationMs": 97.53,
"heapDeltaBytes": 4979332,
"heapUsedBytes": 71626760,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.3,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 70.23400000002766,
"styleRecalcs": 5,
"styleRecalcDurationMs": 8.088000000000001,
"layouts": 2,
"layoutDurationMs": 0.647,
"taskDurationMs": 49.307000000000016,
"heapDeltaBytes": 3154552,
"heapUsedBytes": 65436632,
"domNodes": 103,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.913999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #20065 +/- ##
=============================================
Coverage ? 84.95%
=============================================
Files ? 2327
Lines ? 133346
Branches ? 36027
=============================================
Hits ? 113286
Misses ? 19698
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Backports #18620 to
cloud/1.55. The cherry-pick is clean and includes the source regression test.Source commit:
8c71085132e81c116ac7f945d19af9d0756f0c36Testing
NODE_OPTIONS=--no-experimental-webstorage pnpm test:unit src/platform/keybindings/keybindingService.escape.test.ts(15 passed)