Repository navigation
fix(cloud/1.54): guard keybind Escape target - #20063
Conversation
event.composedPath()[0] is typed as HTMLElement but is not guaranteed to actually be one. When no element has focus, some browsers (Safari) fire the keydown with document as the target instead of document.body, and Document has no closest() method, throwing `TypeError: target.closest is not a function` from keybindHandler. Guard the role="menu"/menubar Escape check with `target instanceof Element` before calling closest() so a non-Element target falls through to the normal Escape handling instead of throwing. (cherry picked from commit 8c71085)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1990 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-04T04:47:48.559Z",
"gitSha": "6cc016ad0eaf508c821f63019cfd2953f17f6387",
"branch": "backport/18620-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2151.001000000008,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.919000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.984,
"heapDeltaBytes": 5701992,
"heapUsedBytes": 76659548,
"domNodes": -284,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 12.361999999999998,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2033.2049999999526,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.380000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.8530000000001,
"heapDeltaBytes": -13083400,
"heapUsedBytes": 59844708,
"domNodes": -284,
"jsHeapTotalBytes": 3969024,
"scriptDurationMs": 13.166999999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1865.590999999995,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.455000000000002,
"layouts": 14,
"layoutDurationMs": 3.681,
"taskDurationMs": 894.866,
"heapDeltaBytes": -8508704,
"heapUsedBytes": 62570480,
"domNodes": -284,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 165.49800000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1953.2650000000444,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.16,
"layouts": 14,
"layoutDurationMs": 4.605,
"taskDurationMs": 988.2790000000001,
"heapDeltaBytes": -3332676,
"heapUsedBytes": 67765180,
"domNodes": -283,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 183.5,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.9980000000228,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.47,
"layouts": 6,
"layoutDurationMs": 1.055,
"taskDurationMs": 379.4310000000001,
"heapDeltaBytes": 4951828,
"heapUsedBytes": 77921608,
"domNodes": 74,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.563999999999998,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.9509999999818,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.35,
"layouts": 6,
"layoutDurationMs": 1.2810000000000001,
"taskDurationMs": 430.88200000000006,
"heapDeltaBytes": 4494760,
"heapUsedBytes": 75583104,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 16.163999999999998,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 709.5479999999839,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.923,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.493,
"heapDeltaBytes": -7731288,
"heapUsedBytes": 63680656,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 164.67800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 710.3850000000307,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.609999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.2300000000001,
"heapDeltaBytes": -7180204,
"heapUsedBytes": 64928556,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 166.291,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2036.621000000025,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.837999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.644,
"heapDeltaBytes": -7911052,
"heapUsedBytes": 70127268,
"domNodes": -284,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 37.644999999999996,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.7670000000162,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.8220000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.3749999999999,
"heapDeltaBytes": -3528116,
"heapUsedBytes": 77068440,
"domNodes": -269,
"jsHeapTotalBytes": -1798144,
"scriptDurationMs": 35.647999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2202.4579999999787,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.968999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1608.787,
"heapDeltaBytes": -12341972,
"heapUsedBytes": 66467032,
"domNodes": -273,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 818.5880000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2414.3629999999803,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.187,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1744.501,
"heapDeltaBytes": 8533176,
"heapUsedBytes": 90041200,
"domNodes": -282,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 856.2740000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3589.321000000041,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.488999999999999,
"layouts": 60,
"layoutDurationMs": 12.076,
"taskDurationMs": 1691.8000000000002,
"heapDeltaBytes": -570480,
"heapUsedBytes": 67455532,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 801.3950000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3729.4219999999996,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.159,
"layouts": 60,
"layoutDurationMs": 12.587000000000002,
"taskDurationMs": 1850.1799999999998,
"heapDeltaBytes": -15376092,
"heapUsedBytes": 67559096,
"domNodes": -261,
"jsHeapTotalBytes": -1798144,
"scriptDurationMs": 839.6940000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3126.780999999994,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.117,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1883.5979999999997,
"heapDeltaBytes": 8644236,
"heapUsedBytes": 75852636,
"domNodes": -277,
"jsHeapTotalBytes": 978944,
"scriptDurationMs": 972.817,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3232.9050000000734,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.323,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2087.516,
"heapDeltaBytes": 2833772,
"heapUsedBytes": 85388232,
"domNodes": -287,
"jsHeapTotalBytes": 4771840,
"scriptDurationMs": 1046.635,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2009.0379999999755,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.8839999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.1349999999999,
"heapDeltaBytes": 10447916,
"heapUsedBytes": 76710208,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.261,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.5629999999728,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.803,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 677.028,
"heapDeltaBytes": -11601584,
"heapUsedBytes": 67501864,
"domNodes": -283,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 37.454,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.9639999999813,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.740999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.72400000000005,
"heapDeltaBytes": 14903692,
"heapUsedBytes": 88398384,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 144.989,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 646.0260000000062,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.33,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.44399999999996,
"heapDeltaBytes": 14948360,
"heapUsedBytes": 88468692,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.12900000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2030.237999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.570000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.6149999999999,
"heapDeltaBytes": -4954496,
"heapUsedBytes": 71045192,
"domNodes": -297,
"jsHeapTotalBytes": 4231168,
"scriptDurationMs": 9.877000000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2047.0560000000546,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.496,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.7570000000001,
"heapDeltaBytes": 5731160,
"heapUsedBytes": 79394452,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.354000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1789.6590000000288,
"styleRecalcs": 79,
"styleRecalcDurationMs": 31.012,
"layouts": 18,
"layoutDurationMs": 5.088,
"taskDurationMs": 865.1329999999999,
"heapDeltaBytes": -13598608,
"heapUsedBytes": 61849380,
"domNodes": -295,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 117.41799999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1783.721000000014,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.705,
"layouts": 18,
"layoutDurationMs": 5.155,
"taskDurationMs": 919.711,
"heapDeltaBytes": 1438192,
"heapUsedBytes": 77232388,
"domNodes": -296,
"jsHeapTotalBytes": 4231168,
"scriptDurationMs": 123.809,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.0079999999862,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.837999999999994,
"layouts": 15,
"layoutDurationMs": 15.998000000000001,
"taskDurationMs": 1008.6379999999999,
"heapDeltaBytes": -6922012,
"heapUsedBytes": 84358496,
"domNodes": 13831,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 33.355999999999995,
"eventListeners": 2387,
"totalBlockingTimeMs": 153,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8527.292000000045,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.142,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6079.435,
"heapDeltaBytes": 28362016,
"heapUsedBytes": 106693896,
"domNodes": -273,
"jsHeapTotalBytes": 2220032,
"scriptDurationMs": 3048.6879999999996,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8513.598000000002,
"styleRecalcs": 246,
"styleRecalcDurationMs": 37.372,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5949.784000000001,
"heapDeltaBytes": -9828560,
"heapUsedBytes": 68225884,
"domNodes": -271,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 2797.04,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17657.96899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17027.428,
"heapDeltaBytes": -41811332,
"heapUsedBytes": 182325760,
"domNodes": -8068,
"jsHeapTotalBytes": -11599872,
"scriptDurationMs": 288.96900000000005,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17784.07100000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17205.823,
"heapDeltaBytes": -39394844,
"heapUsedBytes": 179155816,
"domNodes": -8068,
"jsHeapTotalBytes": -11022336,
"scriptDurationMs": 301.356,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21334.631999999998,
"styleRecalcs": 168,
"styleRecalcDurationMs": 21.475000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21047.611000000004,
"heapDeltaBytes": -28512924,
"heapUsedBytes": 194219776,
"domNodes": -8068,
"jsHeapTotalBytes": -15806464,
"scriptDurationMs": 934.129,
"eventListeners": -14925,
"totalBlockingTimeMs": 113,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21963.640000000054,
"styleRecalcs": 167,
"styleRecalcDurationMs": 22.239000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21705.43,
"heapDeltaBytes": -51044820,
"heapUsedBytes": 167448760,
"domNodes": -8068,
"jsHeapTotalBytes": -10280960,
"scriptDurationMs": 951.0050000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 70,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-node-resize-workload",
"durationMs": 6292.539000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 98.06300000000002,
"layouts": 20,
"layoutDurationMs": 30.65900000000002,
"taskDurationMs": 6213.828,
"heapDeltaBytes": -44594732,
"heapUsedBytes": 178091116,
"domNodes": -8068,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 116.09000000000002,
"eventListeners": -14929,
"totalBlockingTimeMs": 399,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6449.96100000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.07599999999998,
"layouts": 20,
"layoutDurationMs": 24.581999999999994,
"taskDurationMs": 6327.085,
"heapDeltaBytes": -52003496,
"heapUsedBytes": 176708876,
"domNodes": -8068,
"jsHeapTotalBytes": 2969600,
"scriptDurationMs": 120.00000000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 448,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8808.831999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8554.981999999998,
"heapDeltaBytes": 4373448,
"heapUsedBytes": 177656220,
"domNodes": 0,
"jsHeapTotalBytes": -13893632,
"scriptDurationMs": 151.98499999999993,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9091.057999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8891.398,
"heapDeltaBytes": -469696,
"heapUsedBytes": 175008964,
"domNodes": 0,
"jsHeapTotalBytes": -26476544,
"scriptDurationMs": 164.93599999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 121.00800000001755,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.805,
"layouts": 2,
"layoutDurationMs": 0.818,
"taskDurationMs": 82.786,
"heapDeltaBytes": 3014672,
"heapUsedBytes": 75047732,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.289999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 113.58399999994617,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.423999999999998,
"layouts": 2,
"layoutDurationMs": 0.7090000000000002,
"taskDurationMs": 77.72999999999999,
"heapDeltaBytes": 3018188,
"heapUsedBytes": 72454568,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.471,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
🔗 Commit SHA: c596980 | Docs | View more details | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #20063 +/- ##
=============================================
Coverage ? 84.25%
=============================================
Files ? 2131
Lines ? 128070
Branches ? 32593
=============================================
Hits ? 107909
Misses ? 19980
Partials ? 181
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Independent exact-head backport review at c596980: verified the two-file diff preserves merged source #18620 / source commit 8c71085, including the non-Element Escape regression test; cloud/1.54 tip df8b53e is an ancestor; required test, lint-and-format, and e2e-status checks are green; no review threads or reviewer objections exist. This COMMENT records review under the standing 1.54 backport grant; it does not represent a self-approval.
Summary
Backports #18620 to
cloud/1.54. Guards the Escape menu check whencomposedPath()[0]is a non-Element event target and preserves the release line’s existingrole="menu"behavior. Includes the source regression test.Source commit:
8c71085132e81c116ac7f945d19af9d0756f0c36Testing
NODE_OPTIONS=--no-experimental-webstorage pnpm test:unit src/platform/keybindings/keybindingService.escape.test.ts(14 passed)