Skip to content

fix(cloud/1.54): guard keybind Escape target - #20063

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport/18620-cloud-1.54
Oct 4, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport/18620-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports #18620 to cloud/1.54. Guards the Escape menu check when composedPath()[0] is a non-Element event target and preserves the release line’s existing role="menu" behavior. Includes the source regression test.

Source commit: 8c71085132e81c116ac7f945d19af9d0756f0c36

Testing

  • NODE_OPTIONS=--no-experimental-webstorage pnpm test:unit src/platform/keybindings/keybindingService.escape.test.ts (14 passed)

event.composedPath()[0] is typed as HTMLElement but is not guaranteed to
actually be one. When no element has focus, some browsers (Safari) fire
the keydown with document as the target instead of document.body, and
Document has no closest() method, throwing
`TypeError: target.closest is not a function` from keybindHandler.

Guard the role="menu"/menubar Escape check with `target instanceof
Element` before calling closest() so a non-Element target falls through
to the normal Escape handling instead of throwing.

(cherry picked from commit 8c71085)
@vercel

vercel Bot commented Oct 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 4, 2026 4:36am UTC
billing-web-test Ignored Ignored Oct 4, 2026 4:36am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 049177f5-b0c1-4702-b017-b662663e9dc4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/04/2026, 04:37:56 AM UTC

Links

🎭 Playwright: ✅ 1990 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1969 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 153ms TBT · 80.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.4 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 92ms TBT · 172.5 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 424ms TBT · 169.2 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 7
canvas-idle: task duration 634ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.1 MB
canvas-idle: DOM nodes -284
canvas-idle: event listeners -165
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 942ms
canvas-mouse-sweep: script duration 174ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.1 MB
canvas-mouse-sweep: DOM nodes -284
canvas-mouse-sweep: event listeners -194
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 405ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.2 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 21
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 476ms
dom-widget-clipping: script duration 165ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 61.3 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 583ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 70.2 MB
large-graph-idle: DOM nodes -277
large-graph-idle: event listeners -179
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1677ms
large-graph-pan: script duration 837ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 74.6 MB
large-graph-pan: DOM nodes -278
large-graph-pan: event listeners -177
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 1771ms
large-graph-zoom: script duration 821ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 64.4 MB
large-graph-zoom: DOM nodes -119
large-graph-zoom: event listeners -89
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1986ms
legacy-node-drag: script duration 1010ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 76.9 MB
legacy-node-drag: DOM nodes -282
legacy-node-drag: event listeners -5
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 607ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 68.8 MB
minimap-idle: DOM nodes -281
minimap-idle: event listeners -162
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 435ms
subgraph-dom-widget-clipping: script duration 146ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.3 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 546ms
subgraph-idle: script duration 11ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 71.7 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 31ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 892ms
subgraph-mouse-sweep: script duration 121ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 66.3 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -225
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1009ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 153ms
subgraph-transition-enter: heap used 80.5 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 6015ms
viewport-pan-sweep: script duration 2923ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.4 MB
viewport-pan-sweep: DOM nodes -272
viewport-pan-sweep: event listeners -146
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17117ms
vue-large-graph-idle: script duration 295ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.4 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 22ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 168
vue-large-graph-pan: task duration 21377ms
vue-large-graph-pan: script duration 943ms
vue-large-graph-pan: TBT 92ms
vue-large-graph-pan: heap used 172.5 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 28ms
vue-node-resize-workload: style recalc duration 91ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6270ms
vue-node-resize-workload: script duration 118ms
vue-node-resize-workload: TBT 424ms
vue-node-resize-workload: heap used 169.2 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8723ms
vue-zoom-out-idle: script duration 158ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 168.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 2
workflow-execution: style recalc count 8
workflow-execution: task duration 80ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.3 MB
workflow-execution: DOM nodes 108
workflow-execution: event listeners 33
Raw data
{
  "timestamp": "2026-10-04T04:47:48.559Z",
  "gitSha": "6cc016ad0eaf508c821f63019cfd2953f17f6387",
  "branch": "backport/18620-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2151.001000000008,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.919000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 675.984,
      "heapDeltaBytes": 5701992,
      "heapUsedBytes": 76659548,
      "domNodes": -284,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 12.361999999999998,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2033.2049999999526,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.380000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 592.8530000000001,
      "heapDeltaBytes": -13083400,
      "heapUsedBytes": 59844708,
      "domNodes": -284,
      "jsHeapTotalBytes": 3969024,
      "scriptDurationMs": 13.166999999999998,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1865.590999999995,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 28.455000000000002,
      "layouts": 14,
      "layoutDurationMs": 3.681,
      "taskDurationMs": 894.866,
      "heapDeltaBytes": -8508704,
      "heapUsedBytes": 62570480,
      "domNodes": -284,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 165.49800000000002,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1953.2650000000444,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 34.16,
      "layouts": 14,
      "layoutDurationMs": 4.605,
      "taskDurationMs": 988.2790000000001,
      "heapDeltaBytes": -3332676,
      "heapUsedBytes": 67765180,
      "domNodes": -283,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 183.5,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1717.9980000000228,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.47,
      "layouts": 6,
      "layoutDurationMs": 1.055,
      "taskDurationMs": 379.4310000000001,
      "heapDeltaBytes": 4951828,
      "heapUsedBytes": 77921608,
      "domNodes": 74,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 12.563999999999998,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.9509999999818,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 19.35,
      "layouts": 6,
      "layoutDurationMs": 1.2810000000000001,
      "taskDurationMs": 430.88200000000006,
      "heapDeltaBytes": 4494760,
      "heapUsedBytes": 75583104,
      "domNodes": 75,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 16.163999999999998,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 709.5479999999839,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 9.923,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.493,
      "heapDeltaBytes": -7731288,
      "heapUsedBytes": 63680656,
      "domNodes": 20,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 164.67800000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 710.3850000000307,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 8.609999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.2300000000001,
      "heapDeltaBytes": -7180204,
      "heapUsedBytes": 64928556,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 166.291,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2036.621000000025,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.837999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 581.644,
      "heapDeltaBytes": -7911052,
      "heapUsedBytes": 70127268,
      "domNodes": -284,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 37.644999999999996,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.7670000000162,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.8220000000000023,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 584.3749999999999,
      "heapDeltaBytes": -3528116,
      "heapUsedBytes": 77068440,
      "domNodes": -269,
      "jsHeapTotalBytes": -1798144,
      "scriptDurationMs": 35.647999999999996,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2202.4579999999787,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.968999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1608.787,
      "heapDeltaBytes": -12341972,
      "heapUsedBytes": 66467032,
      "domNodes": -273,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 818.5880000000001,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2414.3629999999803,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.187,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1744.501,
      "heapDeltaBytes": 8533176,
      "heapUsedBytes": 90041200,
      "domNodes": -282,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 856.2740000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3589.321000000041,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.488999999999999,
      "layouts": 60,
      "layoutDurationMs": 12.076,
      "taskDurationMs": 1691.8000000000002,
      "heapDeltaBytes": -570480,
      "heapUsedBytes": 67455532,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 801.3950000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3729.4219999999996,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.159,
      "layouts": 60,
      "layoutDurationMs": 12.587000000000002,
      "taskDurationMs": 1850.1799999999998,
      "heapDeltaBytes": -15376092,
      "heapUsedBytes": 67559096,
      "domNodes": -261,
      "jsHeapTotalBytes": -1798144,
      "scriptDurationMs": 839.6940000000001,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3126.780999999994,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.117,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1883.5979999999997,
      "heapDeltaBytes": 8644236,
      "heapUsedBytes": 75852636,
      "domNodes": -277,
      "jsHeapTotalBytes": 978944,
      "scriptDurationMs": 972.817,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3232.9050000000734,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 8.323,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2087.516,
      "heapDeltaBytes": 2833772,
      "heapUsedBytes": 85388232,
      "domNodes": -287,
      "jsHeapTotalBytes": 4771840,
      "scriptDurationMs": 1046.635,
      "eventListeners": -195,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2009.0379999999755,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.8839999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 537.1349999999999,
      "heapDeltaBytes": 10447916,
      "heapUsedBytes": 76710208,
      "domNodes": -279,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 35.261,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2042.5629999999728,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.803,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 677.028,
      "heapDeltaBytes": -11601584,
      "heapUsedBytes": 67501864,
      "domNodes": -283,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 37.454,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 607.9639999999813,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.740999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 423.72400000000005,
      "heapDeltaBytes": 14903692,
      "heapUsedBytes": 88398384,
      "domNodes": 22,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 144.989,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 646.0260000000062,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.33,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.44399999999996,
      "heapDeltaBytes": 14948360,
      "heapUsedBytes": 88468692,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 147.12900000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2030.237999999997,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.570000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 525.6149999999999,
      "heapDeltaBytes": -4954496,
      "heapUsedBytes": 71045192,
      "domNodes": -297,
      "jsHeapTotalBytes": 4231168,
      "scriptDurationMs": 9.877000000000002,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2047.0560000000546,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.496,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 566.7570000000001,
      "heapDeltaBytes": 5731160,
      "heapUsedBytes": 79394452,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 12.354000000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1789.6590000000288,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 31.012,
      "layouts": 18,
      "layoutDurationMs": 5.088,
      "taskDurationMs": 865.1329999999999,
      "heapDeltaBytes": -13598608,
      "heapUsedBytes": 61849380,
      "domNodes": -295,
      "jsHeapTotalBytes": 5541888,
      "scriptDurationMs": 117.41799999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1783.721000000014,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.705,
      "layouts": 18,
      "layoutDurationMs": 5.155,
      "taskDurationMs": 919.711,
      "heapDeltaBytes": 1438192,
      "heapUsedBytes": 77232388,
      "domNodes": -296,
      "jsHeapTotalBytes": 4231168,
      "scriptDurationMs": 123.809,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1418.0079999999862,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 33.837999999999994,
      "layouts": 15,
      "layoutDurationMs": 15.998000000000001,
      "taskDurationMs": 1008.6379999999999,
      "heapDeltaBytes": -6922012,
      "heapUsedBytes": 84358496,
      "domNodes": 13831,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 33.355999999999995,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 153,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8527.292000000045,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 38.142,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6079.435,
      "heapDeltaBytes": 28362016,
      "heapUsedBytes": 106693896,
      "domNodes": -273,
      "jsHeapTotalBytes": 2220032,
      "scriptDurationMs": 3048.6879999999996,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8513.598000000002,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 37.372,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5949.784000000001,
      "heapDeltaBytes": -9828560,
      "heapUsedBytes": 68225884,
      "domNodes": -271,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 2797.04,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17657.96899999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17027.428,
      "heapDeltaBytes": -41811332,
      "heapUsedBytes": 182325760,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11599872,
      "scriptDurationMs": 288.96900000000005,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17784.07100000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17205.823,
      "heapDeltaBytes": -39394844,
      "heapUsedBytes": 179155816,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11022336,
      "scriptDurationMs": 301.356,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21334.631999999998,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 21.475000000000023,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21047.611000000004,
      "heapDeltaBytes": -28512924,
      "heapUsedBytes": 194219776,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15806464,
      "scriptDurationMs": 934.129,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 113,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21963.640000000054,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 22.239000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21705.43,
      "heapDeltaBytes": -51044820,
      "heapUsedBytes": 167448760,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10280960,
      "scriptDurationMs": 951.0050000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 70,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999995634
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6292.539000000033,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 98.06300000000002,
      "layouts": 20,
      "layoutDurationMs": 30.65900000000002,
      "taskDurationMs": 6213.828,
      "heapDeltaBytes": -44594732,
      "heapUsedBytes": 178091116,
      "domNodes": -8068,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 116.09000000000002,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 399,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6449.96100000003,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 83.07599999999998,
      "layouts": 20,
      "layoutDurationMs": 24.581999999999994,
      "taskDurationMs": 6327.085,
      "heapDeltaBytes": -52003496,
      "heapUsedBytes": 176708876,
      "domNodes": -8068,
      "jsHeapTotalBytes": 2969600,
      "scriptDurationMs": 120.00000000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 448,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8808.831999999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8554.981999999998,
      "heapDeltaBytes": 4373448,
      "heapUsedBytes": 177656220,
      "domNodes": 0,
      "jsHeapTotalBytes": -13893632,
      "scriptDurationMs": 151.98499999999993,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9091.057999999975,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8891.398,
      "heapDeltaBytes": -469696,
      "heapUsedBytes": 175008964,
      "domNodes": 0,
      "jsHeapTotalBytes": -26476544,
      "scriptDurationMs": 164.93599999999998,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 121.00800000001755,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.805,
      "layouts": 2,
      "layoutDurationMs": 0.818,
      "taskDurationMs": 82.786,
      "heapDeltaBytes": 3014672,
      "heapUsedBytes": 75047732,
      "domNodes": 108,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.289999999999999,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 113.58399999994617,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.423999999999998,
      "layouts": 2,
      "layoutDurationMs": 0.7090000000000002,
      "taskDurationMs": 77.72999999999999,
      "heapDeltaBytes": 3018188,
      "heapUsedBytes": 72454568,
      "domNodes": 108,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.471,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51067 76439 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 4, 2026
@datadog-official

datadog-official Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c596980 | Docs | View more details | Give us feedback!

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #20063   +/-   ##
=============================================
  Coverage              ?   84.25%           
=============================================
  Files                 ?     2131           
  Lines                 ?   128070           
  Branches              ?    32593           
=============================================
  Hits                  ?   107909           
  Misses                ?    19980           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.86% <100.00%> (?)
unit 79.55% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/keybindings/keybindingService.ts 91.25% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent exact-head backport review at c596980: verified the two-file diff preserves merged source #18620 / source commit 8c71085, including the non-Element Escape regression test; cloud/1.54 tip df8b53e is an ancestor; required test, lint-and-format, and e2e-status checks are green; no review threads or reviewer objections exist. This COMMENT records review under the standing 1.54 backport grant; it does not represent a self-approval.

@christian-byrne
christian-byrne merged commit 874d547 into cloud/1.54 Oct 4, 2026
126 of 128 checks passed
@christian-byrne
christian-byrne deleted the backport/18620-cloud-1.54 branch October 4, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants