Repository navigation
fix(core/1.54): guard keybind Escape target - #20062
Conversation
event.composedPath()[0] is typed as HTMLElement but is not guaranteed to actually be one. When no element has focus, some browsers (Safari) fire the keydown with document as the target instead of document.body, and Document has no closest() method, throwing `TypeError: target.closest is not a function` from keybindHandler. Guard the role="menu"/menubar Escape check with `target instanceof Element` before calling closest() so a non-Element target falls through to the normal Escape handling instead of throwing. (cherry picked from commit 8c71085)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1984 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-04T04:47:55.409Z",
"gitSha": "f3b9be1d280467c9577a0c759b448068fc25fe99",
"branch": "backport/18620-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2114.5050000000083,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.254999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.091,
"heapDeltaBytes": 9426024,
"heapUsedBytes": 80904352,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.629999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2052.088000000026,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.087,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.7879999999999,
"heapDeltaBytes": -15202900,
"heapUsedBytes": 58481592,
"domNodes": -284,
"jsHeapTotalBytes": 3706880,
"scriptDurationMs": 11.427,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.4800000000118,
"styleRecalcs": 75,
"styleRecalcDurationMs": 26.465000000000003,
"layouts": 14,
"layoutDurationMs": 3.685,
"taskDurationMs": 836.8040000000001,
"heapDeltaBytes": 12770520,
"heapUsedBytes": 84523560,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 155.366,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1949.2380000000367,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.633,
"layouts": 14,
"layoutDurationMs": 4.159999999999999,
"taskDurationMs": 919.6969999999999,
"heapDeltaBytes": 5985316,
"heapUsedBytes": 76922112,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 166.819,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.5940000000037,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.355000000000004,
"layouts": 6,
"layoutDurationMs": 1.1119999999999999,
"taskDurationMs": 394.41100000000006,
"heapDeltaBytes": 4561580,
"heapUsedBytes": 75572372,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.758,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.0320000000156,
"styleRecalcs": 29,
"styleRecalcDurationMs": 16.320999999999998,
"layouts": 6,
"layoutDurationMs": 1.0489999999999997,
"taskDurationMs": 415.469,
"heapDeltaBytes": 4204584,
"heapUsedBytes": 75618772,
"domNodes": 74,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 14.443000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 653.3469999999966,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.072000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.30799999999994,
"heapDeltaBytes": -7741892,
"heapUsedBytes": 63822208,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 165.054,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 732.949000000076,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.519,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.486,
"heapDeltaBytes": -7966572,
"heapUsedBytes": 63349380,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 168.108,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2040.7930000000079,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.297,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.5339999999999,
"heapDeltaBytes": -867588,
"heapUsedBytes": 76864664,
"domNodes": -270,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 41.912,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2017.2900000000027,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.8539999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.0199999999999,
"heapDeltaBytes": -874444,
"heapUsedBytes": 77078924,
"domNodes": -271,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 37.694,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2228.90799999999,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.690000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1592.967,
"heapDeltaBytes": 271260,
"heapUsedBytes": 66618536,
"domNodes": -275,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 817.8140000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2324.096000000054,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.289,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1669.8319999999999,
"heapDeltaBytes": -1371848,
"heapUsedBytes": 76603764,
"domNodes": -282,
"jsHeapTotalBytes": 3792896,
"scriptDurationMs": 847.1469999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3677.4540000000115,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.514999999999999,
"layouts": 60,
"layoutDurationMs": 12.472000000000001,
"taskDurationMs": 1783.6909999999998,
"heapDeltaBytes": -12887820,
"heapUsedBytes": 67018256,
"domNodes": -260,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 805.3679999999999,
"eventListeners": -158,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3542.422999999985,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.465,
"layouts": 60,
"layoutDurationMs": 12.393999999999998,
"taskDurationMs": 1718,
"heapDeltaBytes": -943516,
"heapUsedBytes": 67143316,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 793.6450000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3108.53000000003,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.502,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1888.1419999999998,
"heapDeltaBytes": 4993252,
"heapUsedBytes": 72314824,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 957.182,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3152.3670000000266,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.0200000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1972.921,
"heapDeltaBytes": 15272716,
"heapUsedBytes": 82762316,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1032.4009999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2041.2529999999833,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.189000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.8650000000001,
"heapDeltaBytes": -2616548,
"heapUsedBytes": 77278480,
"domNodes": -272,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 37.074,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.3119999998999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 595.455,
"heapDeltaBytes": 11413188,
"heapUsedBytes": 77896304,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.167,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.9479999999553,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.637999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.27099999999996,
"heapDeltaBytes": 14733236,
"heapUsedBytes": 88221804,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.51500000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.769999999955,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.515,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.56300000000005,
"heapDeltaBytes": 14905816,
"heapUsedBytes": 88364636,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.97,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.318000000027,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.273,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.7959999999999,
"heapDeltaBytes": -12834432,
"heapUsedBytes": 62477332,
"domNodes": -295,
"jsHeapTotalBytes": 4231168,
"scriptDurationMs": 10.216999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2013.1559999999808,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.443000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.727,
"heapDeltaBytes": -6321752,
"heapUsedBytes": 67311264,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 11.722,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1754.0930000000117,
"styleRecalcs": 76,
"styleRecalcDurationMs": 27.164,
"layouts": 18,
"layoutDurationMs": 4.811,
"taskDurationMs": 870.1000000000001,
"heapDeltaBytes": -8441220,
"heapUsedBytes": 64619636,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 115.64899999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1784.5139999999446,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.819000000000006,
"layouts": 18,
"layoutDurationMs": 5.481,
"taskDurationMs": 910.7969999999999,
"heapDeltaBytes": -2818008,
"heapUsedBytes": 70893088,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 123.859,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.4780000000014,
"styleRecalcs": 18,
"styleRecalcDurationMs": 33.75300000000001,
"layouts": 14,
"layoutDurationMs": 16.256,
"taskDurationMs": 1010.3060000000002,
"heapDeltaBytes": -5070612,
"heapUsedBytes": 85554376,
"domNodes": 13831,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 33.302,
"eventListeners": 2387,
"totalBlockingTimeMs": 150,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8371.437000000014,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.836,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5860.845,
"heapDeltaBytes": 11502372,
"heapUsedBytes": 89204356,
"domNodes": -282,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 2771.3959999999997,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8597.152000000051,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6018.276999999999,
"heapDeltaBytes": 8801068,
"heapUsedBytes": 89061088,
"domNodes": -268,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 2848.769,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17869.156999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17231.409999999996,
"heapDeltaBytes": -43752628,
"heapUsedBytes": 178846816,
"domNodes": -8068,
"jsHeapTotalBytes": -15736832,
"scriptDurationMs": 299.392,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17594.761999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16990.323,
"heapDeltaBytes": -33178948,
"heapUsedBytes": 179086520,
"domNodes": -8068,
"jsHeapTotalBytes": -11546624,
"scriptDurationMs": 316.601,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21267.269999999997,
"styleRecalcs": 154,
"styleRecalcDurationMs": 20.102000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20962.468,
"heapDeltaBytes": -58338392,
"heapUsedBytes": 166350396,
"domNodes": -8068,
"jsHeapTotalBytes": -13643776,
"scriptDurationMs": 984.0339999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 84,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21442.412999999986,
"styleRecalcs": 160,
"styleRecalcDurationMs": 21.078999999999958,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21168.085,
"heapDeltaBytes": -48814896,
"heapUsedBytes": 169666608,
"domNodes": -8068,
"jsHeapTotalBytes": -13426688,
"scriptDurationMs": 921.4639999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 74,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6254.2109999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.68200000000003,
"layouts": 20,
"layoutDurationMs": 25.040000000000006,
"taskDurationMs": 6182.955000000001,
"heapDeltaBytes": -35114800,
"heapUsedBytes": 189007908,
"domNodes": -8068,
"jsHeapTotalBytes": 13565952,
"scriptDurationMs": 115.226,
"eventListeners": -14929,
"totalBlockingTimeMs": 403,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6363.625999999954,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.57899999999997,
"layouts": 20,
"layoutDurationMs": 37.762,
"taskDurationMs": 6271.546,
"heapDeltaBytes": -30988132,
"heapUsedBytes": 192024584,
"domNodes": -8068,
"jsHeapTotalBytes": 4116480,
"scriptDurationMs": 112.22100000000002,
"eventListeners": -14931,
"totalBlockingTimeMs": 671,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9159.299999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8699.032000000001,
"heapDeltaBytes": 9515628,
"heapUsedBytes": 179240732,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 150.605,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9012.02599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8574.381000000001,
"heapDeltaBytes": 18815432,
"heapUsedBytes": 180716992,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 153.08599999999996,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 114.29600000002438,
"styleRecalcs": 10,
"styleRecalcDurationMs": 16.319,
"layouts": 2,
"layoutDurationMs": 0.949,
"taskDurationMs": 79.135,
"heapDeltaBytes": 3041244,
"heapUsedBytes": 72166812,
"domNodes": 131,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.930000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 455.2209999999377,
"styleRecalcs": 14,
"styleRecalcDurationMs": 19.146,
"layouts": 3,
"layoutDurationMs": 0.856,
"taskDurationMs": 107.03599999999999,
"heapDeltaBytes": 4758520,
"heapUsedBytes": 74412548,
"domNodes": 121,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.314,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #20062 +/- ##
==========================================
Coverage 84.38% 84.39%
==========================================
Files 2125 2125
Lines 127471 127473 +2
Branches 34352 34355 +3
==========================================
+ Hits 107571 107576 +5
+ Misses 19712 19709 -3
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Backports #18620 to
core/1.54. Guards the Escape menu check whencomposedPath()[0]is a non-Element event target and preserves the release line’s existingrole="menu"behavior. Includes the source regression test.Source commit:
8c71085132e81c116ac7f945d19af9d0756f0c36Testing
NODE_OPTIONS=--no-experimental-webstorage pnpm test:unit src/platform/keybindings/keybindingService.escape.test.ts(14 passed)