Skip to content

[backport cloud/1.54] test(agent): repair persisted tool-summary regression (#18581) - #18582

Merged
christian-byrne merged 2 commits into
cloud/1.54from
fix/agent-work-summary-reload
Sep 23, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
fix/agent-work-summary-reload

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Repair the release-only failing assertion introduced by #18555, with chat-switch coverage from #18581.

Changes

  • cloud/1.54 has ToolCallGroup, not main’s WorkSummary. Its exact accessible name for the existing payload is "Ran 2 tool calls for 0.6 seconds", not "Worked".
  • Preserve all collapse/expand and visible-call assertions. Also require exactly two rows with their separate 0.4s/0.2s durations, no summary in a new chat, and restoration via chat history.
  • Test-only; no runtime, package pins, feature flags, or deployment changes. [backport cloud/1.54] chore: replace comfy-multi-player tarball pin with 0.3.5 #18574 remains untouched.

Review Focus

Baseline e790192 reproduced the exact line-132 failure. Its accessibility snapshot already showed the completed two-call summary and "Found it." Hydration was working; the backport had assumed a newer renderer. This is an exact branch-contract adaptation, not a fallback selector or skipped assertion.

Validation: Cloud browser test plus adjacent prompt-history test: 2 passed (32.3s), retries disabled. Transcript/store/transport/ToolCallGroup/glyph unit tests: 117 passed. Browser typecheck, targeted ESLint/oxfmt passed. Await exact-head CI and source #18581 before merge.

@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 9:51am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 685364d6-b048-4319-8021-09ec8c9fab02

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1943 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1922 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 150ms TBT · 105.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.6 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 118ms TBT · 167.2 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 432ms TBT · 175.3 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 543ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.8 MB
canvas-idle: DOM nodes -278
canvas-idle: event listeners -164
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 962ms
canvas-mouse-sweep: script duration 176ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.6 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 372ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.9 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 462ms
dom-widget-clipping: script duration 167ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.4 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 653ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.1 MB
large-graph-idle: DOM nodes -271
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1652ms
large-graph-pan: script duration 820ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 85.0 MB
large-graph-pan: DOM nodes -275
large-graph-pan: event listeners -78
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1784ms
large-graph-zoom: script duration 802ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 81.4 MB
large-graph-zoom: DOM nodes -137
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1969ms
legacy-node-drag: script duration 990ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 89.5 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 630ms
minimap-idle: script duration 38ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.8 MB
minimap-idle: DOM nodes -274
minimap-idle: event listeners -193
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 422ms
subgraph-dom-widget-clipping: script duration 147ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.8 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 497ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.5 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -241
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 31ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 890ms
subgraph-mouse-sweep: script duration 123ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.2 MB
subgraph-mouse-sweep: DOM nodes -294
subgraph-mouse-sweep: event listeners -240
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 17ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 990ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 150ms
subgraph-transition-enter: heap used 105.7 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 6008ms
viewport-pan-sweep: script duration 2776ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.8 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -146
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16997ms
vue-large-graph-idle: script duration 302ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.6 MB
vue-large-graph-idle: DOM nodes -8069
vue-large-graph-idle: event listeners -14930
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 174
vue-large-graph-pan: task duration 21239ms
vue-large-graph-pan: script duration 938ms
vue-large-graph-pan: TBT 118ms
vue-large-graph-pan: heap used 167.2 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 80ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6286ms
vue-node-resize-workload: script duration 115ms
vue-node-resize-workload: TBT 432ms
vue-node-resize-workload: heap used 175.3 MB
vue-node-resize-workload: DOM nodes -8070
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8618ms
vue-zoom-out-idle: script duration 149ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.0 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 2
workflow-execution: style recalc count 8
workflow-execution: task duration 69ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.7 MB
workflow-execution: DOM nodes 117
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-09-23T10:02:39.267Z",
  "gitSha": "9761932618d0cc2b5ae16a70744d80919905215c",
  "branch": "fix/agent-work-summary-reload",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2063.6160000000245,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.66,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 559.582,
      "heapDeltaBytes": 3841032,
      "heapUsedBytes": 74101764,
      "domNodes": -277,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 11.511000000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2045.1850000000036,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.312,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 525.572,
      "heapDeltaBytes": 2004832,
      "heapUsedBytes": 72201288,
      "domNodes": -278,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.237,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2055.503999999985,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 30.648000000000003,
      "layouts": 14,
      "layoutDurationMs": 4.795000000000001,
      "taskDurationMs": 1000.6250000000001,
      "heapDeltaBytes": 7139632,
      "heapUsedBytes": 78049284,
      "domNodes": -282,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 185.13299999999998,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1846.578999999963,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 29.878,
      "layouts": 14,
      "layoutDurationMs": 4.087000000000001,
      "taskDurationMs": 922.765,
      "heapDeltaBytes": -6852932,
      "heapUsedBytes": 63630752,
      "domNodes": -280,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 167.803,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1689.7769999999923,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.285999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.087,
      "taskDurationMs": 371.618,
      "heapDeltaBytes": 4613392,
      "heapUsedBytes": 75369820,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.678,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.9679999999998,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 17.514999999999997,
      "layouts": 6,
      "layoutDurationMs": 1.3319999999999999,
      "taskDurationMs": 373.162,
      "heapDeltaBytes": 4668412,
      "heapUsedBytes": 75343480,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 12.375999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 710.3889999999637,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.476,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 448.25600000000003,
      "heapDeltaBytes": -7862064,
      "heapUsedBytes": 63402256,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 163.323,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 704.8620000000483,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.254999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 476.631,
      "heapDeltaBytes": -8039304,
      "heapUsedBytes": 63315444,
      "domNodes": 18,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 169.807,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.076999999977,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.3380000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 589.48,
      "heapDeltaBytes": -16282544,
      "heapUsedBytes": 87478264,
      "domNodes": -269,
      "jsHeapTotalBytes": -2166784,
      "scriptDurationMs": 38.513999999999996,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2062.0139999999765,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.151,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 715.904,
      "heapDeltaBytes": 8156376,
      "heapUsedBytes": 84605368,
      "domNodes": -273,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 36.229,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2315.125000000023,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.677999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1636.4159999999997,
      "heapDeltaBytes": 22767196,
      "heapUsedBytes": 88928320,
      "domNodes": -277,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 811.498,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2375.274999999988,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.840000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1668.166,
      "heapDeltaBytes": 22771584,
      "heapUsedBytes": 89263976,
      "domNodes": -272,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 829.485,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3675.2520000000004,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.169,
      "layouts": 60,
      "layoutDurationMs": 12.383000000000001,
      "taskDurationMs": 1769.3310000000001,
      "heapDeltaBytes": 10234568,
      "heapUsedBytes": 77161564,
      "domNodes": -280,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 798.0189999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3814.3380000000207,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.079000000000004,
      "layouts": 60,
      "layoutDurationMs": 12.798,
      "taskDurationMs": 1799.113,
      "heapDeltaBytes": 14582724,
      "heapUsedBytes": 93510980,
      "domNodes": 6,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 804.995,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3194.8189999999954,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.125999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1989.715,
      "heapDeltaBytes": 23311220,
      "heapUsedBytes": 93608892,
      "domNodes": 0,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 1014.8969999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3155.3349999999227,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.830000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1948.4339999999997,
      "heapDeltaBytes": 26058260,
      "heapUsedBytes": 94002580,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 965.2940000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2062.4050000000125,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.104999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 629.342,
      "heapDeltaBytes": 8045068,
      "heapUsedBytes": 86253464,
      "domNodes": -271,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 39.224,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2056.3230000000203,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.477,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 631.211,
      "heapDeltaBytes": 5302420,
      "heapUsedBytes": 83117484,
      "domNodes": -277,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 36.095,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 630.2409999999554,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.462,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 423.643,
      "heapDeltaBytes": 15033032,
      "heapUsedBytes": 87991680,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 146.568,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 578.0240000000276,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.021999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 419.833,
      "heapDeltaBytes": 14638676,
      "heapUsedBytes": 87775600,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 148.136,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2019.0390000000207,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.349999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.98300000000006,
      "heapDeltaBytes": -8561124,
      "heapUsedBytes": 63898832,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.816,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2036.71700000001,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.299999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 506.06699999999995,
      "heapDeltaBytes": -7011756,
      "heapUsedBytes": 65170652,
      "domNodes": -293,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.868,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1755.5019999999786,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 30.306000000000004,
      "layouts": 18,
      "layoutDurationMs": 5.276,
      "taskDurationMs": 851.502,
      "heapDeltaBytes": -6481128,
      "heapUsedBytes": 66515080,
      "domNodes": -292,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 117.46200000000002,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1817.4119999999903,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 32.086999999999996,
      "layouts": 18,
      "layoutDurationMs": 5.394,
      "taskDurationMs": 927.784,
      "heapDeltaBytes": -2804368,
      "heapUsedBytes": 70289180,
      "domNodes": -295,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 128.36,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.9390000000312,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 33.36299999999999,
      "layouts": 17,
      "layoutDurationMs": 16.911,
      "taskDurationMs": 989.8100000000001,
      "heapDeltaBytes": 21116848,
      "heapUsedBytes": 110813724,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 32.249,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 150,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8613.631999999996,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 34.075,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5941.52,
      "heapDeltaBytes": 19587040,
      "heapUsedBytes": 84864956,
      "domNodes": -270,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 2754.612,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8827.804999999898,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 37.139,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6075.396,
      "heapDeltaBytes": 23948008,
      "heapUsedBytes": 90924748,
      "domNodes": -265,
      "jsHeapTotalBytes": 192512,
      "scriptDurationMs": 2798.151,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17847.848999999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17023.85,
      "heapDeltaBytes": -54594924,
      "heapUsedBytes": 181694576,
      "domNodes": -8069,
      "jsHeapTotalBytes": -7987200,
      "scriptDurationMs": 303.42400000000004,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17838.83400000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16970.252,
      "heapDeltaBytes": -59625188,
      "heapUsedBytes": 178152612,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17440768,
      "scriptDurationMs": 299.893,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21649.271999999997,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 19.015000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21287.095999999998,
      "heapDeltaBytes": -25335500,
      "heapUsedBytes": 185357396,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17227776,
      "scriptDurationMs": 926.0949999999999,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 159,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21466.689999999973,
      "styleRecalcs": 178,
      "styleRecalcDurationMs": 20.175999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21190.014000000003,
      "heapDeltaBytes": -67062840,
      "heapUsedBytes": 165207216,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20361216,
      "scriptDurationMs": 948.944,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 76,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6400.285999999995,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.38699999999999,
      "layouts": 20,
      "layoutDurationMs": 24.174,
      "taskDurationMs": 6311.788,
      "heapDeltaBytes": -26494172,
      "heapUsedBytes": 185030996,
      "domNodes": -8068,
      "jsHeapTotalBytes": 5828608,
      "scriptDurationMs": 111.998,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 485,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6382.59000000005,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.27299999999998,
      "layouts": 20,
      "layoutDurationMs": 23.33599999999998,
      "taskDurationMs": 6260.826,
      "heapDeltaBytes": -56156264,
      "heapUsedBytes": 182562500,
      "domNodes": -8072,
      "jsHeapTotalBytes": 12419072,
      "scriptDurationMs": 117.35900000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 379,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9078.759999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8731.974999999999,
      "heapDeltaBytes": 14391444,
      "heapUsedBytes": 178833680,
      "domNodes": 0,
      "jsHeapTotalBytes": -21495808,
      "scriptDurationMs": 150.55200000000002,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8819.850000000088,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8503.895999999999,
      "heapDeltaBytes": 9333516,
      "heapUsedBytes": 177660456,
      "domNodes": 0,
      "jsHeapTotalBytes": -27000832,
      "scriptDurationMs": 147.24100000000007,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 113.4969999999953,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 14.475999999999999,
      "layouts": 2,
      "layoutDurationMs": 0.5400000000000001,
      "taskDurationMs": 77.016,
      "heapDeltaBytes": 3102336,
      "heapUsedBytes": 72270408,
      "domNodes": 111,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.838,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 96.16600000003928,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 12.604,
      "layouts": 2,
      "layoutDurationMs": 1.045,
      "taskDurationMs": 61.269000000000005,
      "heapDeltaBytes": 2944308,
      "heapUsedBytes": 71906116,
      "domNodes": 123,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.656,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

Copy link
Copy Markdown
Contributor Author

Verification update at 180b879: exact-head targeted Playwright repeated 3 times with retries disabled: 3 passed (30.1s). Combined persistence + adjacent prompt-history run: 2 passed. Targeted unit suites: 117 passed. Full app and browser typechecks, lint/format hooks, and Knip passed. Expanded browser capture inspected: Search nodes 0.4s and Add node 0.2s both have normal wrench icons, no failure or streaming indicators. The collapsed-state assertion also rejects a restored failed/running call in this renderer. Awaiting exact-head CI; nothing merged yet.

Copy link
Copy Markdown
Contributor Author

Coordination hold: #18580 was opened concurrently with the same release-label diagnosis. I have asked its existing author to consolidate on this PR because this path also preserves exact row/duration and reload/history assertions from source #18581. No Cloud merge until that handoff is acknowledged and exact-head CI settles. See #18580 for the request.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026
@christian-byrne
christian-byrne merged commit 09b455b into cloud/1.54 Sep 23, 2026
90 checks passed
@christian-byrne
christian-byrne deleted the fix/agent-work-summary-reload branch September 23, 2026 10:06

Copy link
Copy Markdown
Contributor Author

@dante01yoon Please provide the requested post-merge review of this test-only repair, especially the exact release renderer contract and reload → New chat → history restoration. #18580 was closed by its author as superseded: #18580 (comment).

The unchanged release baseline reproduced the missing Worked assertion while its accessibility tree already showed Ran 2 tool calls for 0.6 seconds. The merged assertions preserve collapse/expand and visible rows, require both durations, and check no summary leaks into a new chat. Local browser repetitions passed with retries disabled; expanded capture shows both normal wrench icons. Hosted Cloud browser job is successful; at this observation the unit job is still in progress, so full CI completion is not being claimed.

Source #18581 has a subsequent thread-identity assertion, plus a correction ensuring the overriding GET records requests and the test waits for a fresh read. I am preparing that narrow Cloud follow-up separately; this merged history will not be rewritten. No manual deployment, production pin promotion, feature flags, or workflow changes are part of this repair.

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18582   +/-   ##
=============================================
  Coverage              ?   78.70%           
=============================================
  Files                 ?     2015           
  Lines                 ?   111589           
  Branches              ?    33723           
=============================================
  Hits                  ?    87823           
  Misses                ?    23586           
  Partials              ?      180           
Flag Coverage Δ
unit 78.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

christian-byrne added a commit that referenced this pull request Sep 23, 2026
…ntity (#18581) (#18587)

## Summary
Carry the thread-identity review follow-up from #18581 onto
already-merged #18582, without changing runtime behavior or its
release-specific label assertions.

## Changes
- Record actual GET thread IDs in this spec’s overriding route, require
a fresh history read, then assert the selected chat is the same one
restored on reload.
- Keep tracking test-local because the older release fixture does not
expose main’s historyRequestThreadIds. No shared-fixture backport
needed.
- Preserve all collapsed/expanded, row-label/duration, and
new-chat/no-leak assertions. One test file only; no pins, flags,
workflow or production changes.

## Review Focus
The first identity-only source follow-up went red locally with an
undefined ID because this GET override bypasses the shared fixture’s
recorder. Source correction now records the override and waits for a new
read, preventing stale-ID false positives. This Cloud follow-up
preserves those assertions with a local recorder.

Local validation: the affected persistence test passes. In the combined
run, the unchanged preceding inline-prompt test failed its final
keyboard-edit assertion; that failure is recorded rather than reported
as green. Hosted exact-head checks remain required before merge. #18580
was closed by its author as superseded; #18582 is already merged and its
history is untouched.

---------

Co-authored-by: Amp <amp@ampcode.com>
claude Bot pushed a commit that referenced this pull request Sep 23, 2026
The cherry-picked spec looked for a button matching /^Worked/ -- main's
AgentMessage.vue WorkSummary label. cloud/1.54 has ToolCallGroup
instead, whose CollapsibleTrigger accessible name is always
"Ran N tool call(s)[ for Xs]" regardless of running/done state (only
the leading icon changes, via toolGlyph's loader-circle for
'streaming') -- confirmed against ToolCallGroup.vue/agentToolGlyph.ts,
and matching the same adaptation #18582 already made for a different
persisted-tool-summary spec on this branch. Row-level assertions
(loader-circle class, "Add node" label) already matched this branch's
DOM and needed no change.
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants