Repository navigation
[backport cloud/1.54] test(agent): repair persisted tool-summary regression (#18581) - #18582
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1943 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T10:02:39.267Z",
"gitSha": "9761932618d0cc2b5ae16a70744d80919905215c",
"branch": "fix/agent-work-summary-reload",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2063.6160000000245,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.66,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.582,
"heapDeltaBytes": 3841032,
"heapUsedBytes": 74101764,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.511000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2045.1850000000036,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.312,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.572,
"heapDeltaBytes": 2004832,
"heapUsedBytes": 72201288,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.237,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2055.503999999985,
"styleRecalcs": 76,
"styleRecalcDurationMs": 30.648000000000003,
"layouts": 14,
"layoutDurationMs": 4.795000000000001,
"taskDurationMs": 1000.6250000000001,
"heapDeltaBytes": 7139632,
"heapUsedBytes": 78049284,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 185.13299999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1846.578999999963,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.878,
"layouts": 14,
"layoutDurationMs": 4.087000000000001,
"taskDurationMs": 922.765,
"heapDeltaBytes": -6852932,
"heapUsedBytes": 63630752,
"domNodes": -280,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 167.803,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1689.7769999999923,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.285999999999998,
"layouts": 6,
"layoutDurationMs": 1.087,
"taskDurationMs": 371.618,
"heapDeltaBytes": 4613392,
"heapUsedBytes": 75369820,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.678,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.9679999999998,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.514999999999997,
"layouts": 6,
"layoutDurationMs": 1.3319999999999999,
"taskDurationMs": 373.162,
"heapDeltaBytes": 4668412,
"heapUsedBytes": 75343480,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.375999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 710.3889999999637,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.476,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.25600000000003,
"heapDeltaBytes": -7862064,
"heapUsedBytes": 63402256,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 163.323,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 704.8620000000483,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.254999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.631,
"heapDeltaBytes": -8039304,
"heapUsedBytes": 63315444,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 169.807,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2024.076999999977,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.3380000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.48,
"heapDeltaBytes": -16282544,
"heapUsedBytes": 87478264,
"domNodes": -269,
"jsHeapTotalBytes": -2166784,
"scriptDurationMs": 38.513999999999996,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2062.0139999999765,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.151,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 715.904,
"heapDeltaBytes": 8156376,
"heapUsedBytes": 84605368,
"domNodes": -273,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 36.229,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2315.125000000023,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.677999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1636.4159999999997,
"heapDeltaBytes": 22767196,
"heapUsedBytes": 88928320,
"domNodes": -277,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 811.498,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2375.274999999988,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.840000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1668.166,
"heapDeltaBytes": 22771584,
"heapUsedBytes": 89263976,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 829.485,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3675.2520000000004,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.169,
"layouts": 60,
"layoutDurationMs": 12.383000000000001,
"taskDurationMs": 1769.3310000000001,
"heapDeltaBytes": 10234568,
"heapUsedBytes": 77161564,
"domNodes": -280,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 798.0189999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3814.3380000000207,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.079000000000004,
"layouts": 60,
"layoutDurationMs": 12.798,
"taskDurationMs": 1799.113,
"heapDeltaBytes": 14582724,
"heapUsedBytes": 93510980,
"domNodes": 6,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 804.995,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3194.8189999999954,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.125999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1989.715,
"heapDeltaBytes": 23311220,
"heapUsedBytes": 93608892,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1014.8969999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3155.3349999999227,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.830000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1948.4339999999997,
"heapDeltaBytes": 26058260,
"heapUsedBytes": 94002580,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 965.2940000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2062.4050000000125,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.104999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.342,
"heapDeltaBytes": 8045068,
"heapUsedBytes": 86253464,
"domNodes": -271,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 39.224,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2056.3230000000203,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.477,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.211,
"heapDeltaBytes": 5302420,
"heapUsedBytes": 83117484,
"domNodes": -277,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 36.095,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.2409999999554,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.462,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.643,
"heapDeltaBytes": 15033032,
"heapUsedBytes": 87991680,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.568,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.0240000000276,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.021999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.833,
"heapDeltaBytes": 14638676,
"heapUsedBytes": 87775600,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 148.136,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.0390000000207,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.349999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.98300000000006,
"heapDeltaBytes": -8561124,
"heapUsedBytes": 63898832,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.816,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2036.71700000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.299999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.06699999999995,
"heapDeltaBytes": -7011756,
"heapUsedBytes": 65170652,
"domNodes": -293,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.868,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.5019999999786,
"styleRecalcs": 78,
"styleRecalcDurationMs": 30.306000000000004,
"layouts": 18,
"layoutDurationMs": 5.276,
"taskDurationMs": 851.502,
"heapDeltaBytes": -6481128,
"heapUsedBytes": 66515080,
"domNodes": -292,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 117.46200000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1817.4119999999903,
"styleRecalcs": 79,
"styleRecalcDurationMs": 32.086999999999996,
"layouts": 18,
"layoutDurationMs": 5.394,
"taskDurationMs": 927.784,
"heapDeltaBytes": -2804368,
"heapUsedBytes": 70289180,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 128.36,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.9390000000312,
"styleRecalcs": 21,
"styleRecalcDurationMs": 33.36299999999999,
"layouts": 17,
"layoutDurationMs": 16.911,
"taskDurationMs": 989.8100000000001,
"heapDeltaBytes": 21116848,
"heapUsedBytes": 110813724,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 32.249,
"eventListeners": 2385,
"totalBlockingTimeMs": 150,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8613.631999999996,
"styleRecalcs": 246,
"styleRecalcDurationMs": 34.075,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5941.52,
"heapDeltaBytes": 19587040,
"heapUsedBytes": 84864956,
"domNodes": -270,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 2754.612,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8827.804999999898,
"styleRecalcs": 245,
"styleRecalcDurationMs": 37.139,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6075.396,
"heapDeltaBytes": 23948008,
"heapUsedBytes": 90924748,
"domNodes": -265,
"jsHeapTotalBytes": 192512,
"scriptDurationMs": 2798.151,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17847.848999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17023.85,
"heapDeltaBytes": -54594924,
"heapUsedBytes": 181694576,
"domNodes": -8069,
"jsHeapTotalBytes": -7987200,
"scriptDurationMs": 303.42400000000004,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17838.83400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16970.252,
"heapDeltaBytes": -59625188,
"heapUsedBytes": 178152612,
"domNodes": -8068,
"jsHeapTotalBytes": -17440768,
"scriptDurationMs": 299.893,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21649.271999999997,
"styleRecalcs": 169,
"styleRecalcDurationMs": 19.015000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21287.095999999998,
"heapDeltaBytes": -25335500,
"heapUsedBytes": 185357396,
"domNodes": -8068,
"jsHeapTotalBytes": -17227776,
"scriptDurationMs": 926.0949999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 159,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21466.689999999973,
"styleRecalcs": 178,
"styleRecalcDurationMs": 20.175999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21190.014000000003,
"heapDeltaBytes": -67062840,
"heapUsedBytes": 165207216,
"domNodes": -8068,
"jsHeapTotalBytes": -20361216,
"scriptDurationMs": 948.944,
"eventListeners": -14929,
"totalBlockingTimeMs": 76,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6400.285999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.38699999999999,
"layouts": 20,
"layoutDurationMs": 24.174,
"taskDurationMs": 6311.788,
"heapDeltaBytes": -26494172,
"heapUsedBytes": 185030996,
"domNodes": -8068,
"jsHeapTotalBytes": 5828608,
"scriptDurationMs": 111.998,
"eventListeners": -14931,
"totalBlockingTimeMs": 485,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6382.59000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.27299999999998,
"layouts": 20,
"layoutDurationMs": 23.33599999999998,
"taskDurationMs": 6260.826,
"heapDeltaBytes": -56156264,
"heapUsedBytes": 182562500,
"domNodes": -8072,
"jsHeapTotalBytes": 12419072,
"scriptDurationMs": 117.35900000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 379,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9078.759999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8731.974999999999,
"heapDeltaBytes": 14391444,
"heapUsedBytes": 178833680,
"domNodes": 0,
"jsHeapTotalBytes": -21495808,
"scriptDurationMs": 150.55200000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8819.850000000088,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8503.895999999999,
"heapDeltaBytes": 9333516,
"heapUsedBytes": 177660456,
"domNodes": 0,
"jsHeapTotalBytes": -27000832,
"scriptDurationMs": 147.24100000000007,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 113.4969999999953,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.475999999999999,
"layouts": 2,
"layoutDurationMs": 0.5400000000000001,
"taskDurationMs": 77.016,
"heapDeltaBytes": 3102336,
"heapUsedBytes": 72270408,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.838,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 96.16600000003928,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.604,
"layouts": 2,
"layoutDurationMs": 1.045,
"taskDurationMs": 61.269000000000005,
"heapDeltaBytes": 2944308,
"heapUsedBytes": 71906116,
"domNodes": 123,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.656,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
|
Verification update at 180b879: exact-head targeted Playwright repeated 3 times with retries disabled: 3 passed (30.1s). Combined persistence + adjacent prompt-history run: 2 passed. Targeted unit suites: 117 passed. Full app and browser typechecks, lint/format hooks, and Knip passed. Expanded browser capture inspected: Search nodes 0.4s and Add node 0.2s both have normal wrench icons, no failure or streaming indicators. The collapsed-state assertion also rejects a restored failed/running call in this renderer. Awaiting exact-head CI; nothing merged yet. |
|
Coordination hold: #18580 was opened concurrently with the same release-label diagnosis. I have asked its existing author to consolidate on this PR because this path also preserves exact row/duration and reload/history assertions from source #18581. No Cloud merge until that handoff is acknowledged and exact-head CI settles. See #18580 for the request. |
|
@dante01yoon Please provide the requested post-merge review of this test-only repair, especially the exact release renderer contract and reload → New chat → history restoration. #18580 was closed by its author as superseded: #18580 (comment). The unchanged release baseline reproduced the missing Worked assertion while its accessibility tree already showed Ran 2 tool calls for 0.6 seconds. The merged assertions preserve collapse/expand and visible rows, require both durations, and check no summary leaks into a new chat. Local browser repetitions passed with retries disabled; expanded capture shows both normal wrench icons. Hosted Cloud browser job is successful; at this observation the unit job is still in progress, so full CI completion is not being claimed. Source #18581 has a subsequent thread-identity assertion, plus a correction ensuring the overriding GET records requests and the test waits for a fresh read. I am preparing that narrow Cloud follow-up separately; this merged history will not be rewritten. No manual deployment, production pin promotion, feature flags, or workflow changes are part of this repair. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18582 +/- ##
=============================================
Coverage ? 78.70%
=============================================
Files ? 2015
Lines ? 111589
Branches ? 33723
=============================================
Hits ? 87823
Misses ? 23586
Partials ? 180
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…ntity (#18581) (#18587) ## Summary Carry the thread-identity review follow-up from #18581 onto already-merged #18582, without changing runtime behavior or its release-specific label assertions. ## Changes - Record actual GET thread IDs in this spec’s overriding route, require a fresh history read, then assert the selected chat is the same one restored on reload. - Keep tracking test-local because the older release fixture does not expose main’s historyRequestThreadIds. No shared-fixture backport needed. - Preserve all collapsed/expanded, row-label/duration, and new-chat/no-leak assertions. One test file only; no pins, flags, workflow or production changes. ## Review Focus The first identity-only source follow-up went red locally with an undefined ID because this GET override bypasses the shared fixture’s recorder. Source correction now records the override and waits for a new read, preventing stale-ID false positives. This Cloud follow-up preserves those assertions with a local recorder. Local validation: the affected persistence test passes. In the combined run, the unchanged preceding inline-prompt test failed its final keyboard-edit assertion; that failure is recorded rather than reported as green. Hosted exact-head checks remain required before merge. #18580 was closed by its author as superseded; #18582 is already merged and its history is untouched. --------- Co-authored-by: Amp <amp@ampcode.com>
The cherry-picked spec looked for a button matching /^Worked/ -- main's AgentMessage.vue WorkSummary label. cloud/1.54 has ToolCallGroup instead, whose CollapsibleTrigger accessible name is always "Ran N tool call(s)[ for Xs]" regardless of running/done state (only the leading icon changes, via toolGlyph's loader-circle for 'streaming') -- confirmed against ToolCallGroup.vue/agentToolGlyph.ts, and matching the same adaptation #18582 already made for a different persisted-tool-summary spec on this branch. Row-level assertions (loader-circle class, "Add node" label) already matched this branch's DOM and needed no change.
Summary
Repair the release-only failing assertion introduced by #18555, with chat-switch coverage from #18581.
Changes
Review Focus
Baseline e790192 reproduced the exact line-132 failure. Its accessibility snapshot already showed the completed two-call summary and "Found it." Hydration was working; the backport had assumed a newer renderer. This is an exact branch-contract adaptation, not a fallback selector or skipped assertion.
Validation: Cloud browser test plus adjacent prompt-history test: 2 passed (32.3s), retries disabled. Transcript/store/transport/ToolCallGroup/glyph unit tests: 117 passed. Browser typecheck, targeted ESLint/oxfmt passed. Await exact-head CI and source #18581 before merge.