Repository navigation
fix: adapt work-summary persistence spec to cloud/1.54's ToolCallGroup UI - #18580
claude[bot] wants to merge 1 commit into
Conversation
…up UI The #18555 backport of "restore tool-call work summary on reload and chat switch" ported browser_tests/tests/agent/agentToolCallHistoryPersistence.spec.ts verbatim from main, where the completed-turn summary trigger is main-only WorkSummary.vue (labeled "Worked"). cloud/1.54 predates that rename and still renders the older ToolCallGroup.vue, whose trigger reads "Ran N tool calls...". The data-layer restoration logic (agentTranscript.ts, agentEventTransport.ts, agentApiSchema.ts) backported correctly; only the spec's UI assertion was stale, causing the deterministic "Worked" button-not-found failure blocking playwright-tests (cloud).
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1941 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T09:54:29.547Z",
"gitSha": "dd5701bc67b061eab325cbce5ba9a1c1b05e144d",
"branch": "claude/fix-work-summary-cloud-1.54-dff48ac4b0",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2086.9670000000156,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.774,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.2679999999999,
"heapDeltaBytes": -9587756,
"heapUsedBytes": 60639856,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.250000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2071.737999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.083,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.1899999999999,
"heapDeltaBytes": 5118544,
"heapUsedBytes": 76267768,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.355999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1814.31699999996,
"styleRecalcs": 76,
"styleRecalcDurationMs": 28.104999999999997,
"layouts": 14,
"layoutDurationMs": 3.856,
"taskDurationMs": 872.2460000000001,
"heapDeltaBytes": -5237796,
"heapUsedBytes": 64807028,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 160.23299999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1872.7760000000444,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.455,
"layouts": 14,
"layoutDurationMs": 4.335,
"taskDurationMs": 907.278,
"heapDeltaBytes": -3498024,
"heapUsedBytes": 67620880,
"domNodes": -279,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 165.35300000000004,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.474999999994,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.322,
"layouts": 6,
"layoutDurationMs": 1.1,
"taskDurationMs": 364.13000000000005,
"heapDeltaBytes": 4627556,
"heapUsedBytes": 75519704,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.892000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.6800000000185,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.2,
"layouts": 6,
"layoutDurationMs": 1.183,
"taskDurationMs": 405.962,
"heapDeltaBytes": 4629748,
"heapUsedBytes": 75457316,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.544000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 632.9290000000469,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.4209999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.86800000000005,
"heapDeltaBytes": -8226072,
"heapUsedBytes": 62966528,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 157.96099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 674.0459999999757,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.209000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.57399999999996,
"heapDeltaBytes": 18040008,
"heapUsedBytes": 88291804,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 157.04500000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.8759999999925,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.474000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.6560000000001,
"heapDeltaBytes": -16112740,
"heapUsedBytes": 87417052,
"domNodes": -266,
"jsHeapTotalBytes": -331776,
"scriptDurationMs": 40.20900000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.3619999999455,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.372999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 653.134,
"heapDeltaBytes": 6518452,
"heapUsedBytes": 83480460,
"domNodes": -278,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 32.372,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2340.8769999999777,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.797,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1643.6669999999997,
"heapDeltaBytes": 20367152,
"heapUsedBytes": 87364208,
"domNodes": 4,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 819.783,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2376.5589999999293,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.047999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1682.3949999999998,
"heapDeltaBytes": 22039128,
"heapUsedBytes": 87962912,
"domNodes": -275,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 808.624,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3590.003999999965,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.094000000000003,
"layouts": 60,
"layoutDurationMs": 12.171000000000001,
"taskDurationMs": 1732.371,
"heapDeltaBytes": 8194756,
"heapUsedBytes": 76043424,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 770.089,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3575.2449999999953,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.915000000000001,
"layouts": 60,
"layoutDurationMs": 11.923999999999998,
"taskDurationMs": 1760.014,
"heapDeltaBytes": 10199436,
"heapUsedBytes": 76560196,
"domNodes": -282,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 788.192,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3173.5850000000028,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.77,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2052.9990000000003,
"heapDeltaBytes": 6000072,
"heapUsedBytes": 86573756,
"domNodes": -255,
"jsHeapTotalBytes": 573440,
"scriptDurationMs": 990.3729999999999,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3155.3250000000617,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.052,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1962.6520000000003,
"heapDeltaBytes": 3978220,
"heapUsedBytes": 85281608,
"domNodes": -283,
"jsHeapTotalBytes": 1359872,
"scriptDurationMs": 953.602,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.8589999999544,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.321999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.3990000000001,
"heapDeltaBytes": 9908544,
"heapUsedBytes": 88032268,
"domNodes": -270,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 33.44,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2078.8330000000315,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.322999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.9730000000001,
"heapDeltaBytes": 4768888,
"heapUsedBytes": 82260988,
"domNodes": -280,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 38.09700000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.7479999999714,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.02,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.44499999999994,
"heapDeltaBytes": 15083308,
"heapUsedBytes": 88358636,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 139.172,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 627.8700000000299,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.16,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.43100000000004,
"heapDeltaBytes": 14638828,
"heapUsedBytes": 87988872,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 153.807,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2030.6629999999473,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.300999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.206,
"heapDeltaBytes": -14676940,
"heapUsedBytes": 58562764,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.109,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.2400000000107,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.038999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.311,
"heapDeltaBytes": -14858012,
"heapUsedBytes": 58417204,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.165,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.5369999999803,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.584000000000003,
"layouts": 18,
"layoutDurationMs": 4.809000000000001,
"taskDurationMs": 837.545,
"heapDeltaBytes": -5434480,
"heapUsedBytes": 67871496,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 119.478,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1750.9569999999712,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.762,
"layouts": 18,
"layoutDurationMs": 4.779,
"taskDurationMs": 847.9270000000001,
"heapDeltaBytes": 278004,
"heapUsedBytes": 73548708,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 112.35800000000002,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.3289999999715,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.528999999999996,
"layouts": 15,
"layoutDurationMs": 16.235000000000003,
"taskDurationMs": 974.4439999999998,
"heapDeltaBytes": -5313544,
"heapUsedBytes": 84671068,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 32.122,
"eventListeners": 2385,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9324.092000000008,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.27100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6216.047,
"heapDeltaBytes": 19541552,
"heapUsedBytes": 96134680,
"domNodes": -272,
"jsHeapTotalBytes": 610304,
"scriptDurationMs": 2841.02,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8930.276999999933,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.104,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6091.120999999999,
"heapDeltaBytes": -9671436,
"heapUsedBytes": 94078412,
"domNodes": -267,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 2740.377,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17107.100000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16616.171000000002,
"heapDeltaBytes": -72127472,
"heapUsedBytes": 165727820,
"domNodes": -8068,
"jsHeapTotalBytes": -16191488,
"scriptDurationMs": 282.542,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17876.30200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17092.047000000002,
"heapDeltaBytes": -40821024,
"heapUsedBytes": 176654532,
"domNodes": -8068,
"jsHeapTotalBytes": -12115968,
"scriptDurationMs": 355.783,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21183.99900000003,
"styleRecalcs": 170,
"styleRecalcDurationMs": 18.965999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20848.343,
"heapDeltaBytes": -49319732,
"heapUsedBytes": 168562300,
"domNodes": -8068,
"jsHeapTotalBytes": -10518528,
"scriptDurationMs": 895.0579999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 17,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20906.053000000044,
"styleRecalcs": 167,
"styleRecalcDurationMs": 19.652,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20632.425000000003,
"heapDeltaBytes": -52425096,
"heapUsedBytes": 178942760,
"domNodes": -8068,
"jsHeapTotalBytes": -17739776,
"scriptDurationMs": 904.827,
"eventListeners": -14927,
"totalBlockingTimeMs": 58,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6175.283999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.94800000000002,
"layouts": 20,
"layoutDurationMs": 21.95100000000001,
"taskDurationMs": 6040.933,
"heapDeltaBytes": -41266220,
"heapUsedBytes": 176362008,
"domNodes": -8068,
"jsHeapTotalBytes": 8638464,
"scriptDurationMs": 113.341,
"eventListeners": -14933,
"totalBlockingTimeMs": 368,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6264.404000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.368,
"layouts": 20,
"layoutDurationMs": 24.13299999999999,
"taskDurationMs": 6212.279999999999,
"heapDeltaBytes": -33932644,
"heapUsedBytes": 184138060,
"domNodes": -8068,
"jsHeapTotalBytes": 14667776,
"scriptDurationMs": 122.93200000000002,
"eventListeners": -14931,
"totalBlockingTimeMs": 459,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9014.913000000091,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8803.964,
"heapDeltaBytes": -1146076,
"heapUsedBytes": 179674676,
"domNodes": 0,
"jsHeapTotalBytes": -27787264,
"scriptDurationMs": 153.39899999999994,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8836.749000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8560.782,
"heapDeltaBytes": 20176920,
"heapUsedBytes": 178628300,
"domNodes": -1,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 140.4080000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 490.8030000000281,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.353,
"layouts": 3,
"layoutDurationMs": 1.569,
"taskDurationMs": 135.087,
"heapDeltaBytes": 5025292,
"heapUsedBytes": 74359064,
"domNodes": 151,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 14.302999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 110.62500000002728,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.670000000000003,
"layouts": 3,
"layoutDurationMs": 1.3270000000000002,
"taskDurationMs": 72.934,
"heapDeltaBytes": 2957384,
"heapUsedBytes": 70614568,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.728999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
|
@claude Coordination before merge: this overlaps #18582, which I opened from the same cloud/1.54 baseline while independently reproducing this failure. We agree on the root cause: ToolCallGroup is already hydrated; Worked belongs to main’s newer renderer. Please hold merge here and confirm consolidation on #18582. It preserves every existing visibility/collapse assertion, uses the exact shipped header, asserts both row durations, and adds New chat → history → original chat restoration via source #18581. Local proof at its published head: 2 browser tests passed; targeted persistence repeated independently 3 times with retries disabled (3 passed); 117 unit tests; app/browser typecheck and hooks/Knip passed. Hosted CI remains pending and no checks will be waived. I will retain ownership of CI qualification and the authorized post-check merge, with a post-merge review request. If you have additional requirements or verification not in this PR, please flag them before we retire the duplicate. No production deployment, feature flags, or package pins are involved. |
|
Closing this as superseded by #18582, which independently fixes the same regression and additionally covers chat-switch persistence (per Christian Byrne's request), which this PR does not. Generated by Claude Code |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18580 +/- ##
=============================================
Coverage ? 78.70%
=============================================
Files ? 2015
Lines ? 111589
Branches ? 33723
=============================================
Hits ? 87823
Misses ? 23586
Partials ? 180
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…ntity (#18581) (#18587) ## Summary Carry the thread-identity review follow-up from #18581 onto already-merged #18582, without changing runtime behavior or its release-specific label assertions. ## Changes - Record actual GET thread IDs in this spec’s overriding route, require a fresh history read, then assert the selected chat is the same one restored on reload. - Keep tracking test-local because the older release fixture does not expose main’s historyRequestThreadIds. No shared-fixture backport needed. - Preserve all collapsed/expanded, row-label/duration, and new-chat/no-leak assertions. One test file only; no pins, flags, workflow or production changes. ## Review Focus The first identity-only source follow-up went red locally with an undefined ID because this GET override bypasses the shared fixture’s recorder. Source correction now records the override and waits for a new read, preventing stale-ID false positives. This Cloud follow-up preserves those assertions with a local recorder. Local validation: the affected persistence test passes. In the combined run, the unchanged preceding inline-prompt test failed its final keyboard-edit assertion; that failure is recorded rather than reported as green. Hosted exact-head checks remain required before merge. #18580 was closed by its author as superseded; #18582 is already merged and its history is untouched. --------- Co-authored-by: Amp <amp@ampcode.com>
<!-- ccr-slack-attribution -->
Requested by Christian Byrne · Slack thread
Summary
browser_tests/tests/agent/agentToolCallHistoryPersistence.spec.ts:24("keeps a completed turn work summary after a browser refresh") has been deterministically failing oncloud/1.54since #18555 merged, blockingplaywright-tests (cloud)on every subsequent PR:Same regression, same cause, on
core/1.54via the parallel backport #18554.Root cause
#18555 (backport of #18282, "restore tool-call work summary on reload and chat switch") correctly ported the data-layer restoration logic —
agentTranscript.ts,agentEventTransport.ts,agentApiSchema.ts— which reads a persisted assistant row'scontent.tool_callsand folds it into the sameToolParts the live WebSocket path builds.But it also cherry-picked the new Playwright spec verbatim from
main, where the completed-turn summary trigger isWorkSummary.vue(added by a separate, unrelated main-only rename/refactor that replacedToolCallGroup.vue/ToolCallCard.vuewithWorkSummary.vue/ActivityTrace.vue).WorkSummary.vueunconditionally renderst('agent.worked')("Worked").cloud/1.54predates that rename: it still renders the olderToolCallGroup.vue, whose trigger shows a dynamic status label —"Ran {count} tool call(s)[ for {seconds} seconds]"— and never "Worked".agent.workedis an orphaned i18n key on this branch (present inlocales/*/main.json, referenced by no component). So the persistence behavior was already correctly restored — only the test's UI assertion targeted a component that doesn't exist here.Porting the full
WorkSummary/ActivityTracerename was considered and rejected as out of scope for this fix: it would also require rewriting the several existing, intentional assertions inToolCallGroup.test.tsthat pin the current"Ran N tool calls"label.Fix
Adapt the spec's final assertions to this branch's actual (working) UI, the same kind of branch-specific adaptation the backport already made for the entry-button locator (
agent.askComfyAgentvs. main'sagent.entryButton):name: enMessages.agent.worked, exact: true→name: /^Ran 2 tool calls for 0\.6 seconds/(2 calls: 420ms + 180ms from the test's own mock data).No production code changed — this is a test-only fix.
Verification
pnpm exec eslinton the changed file — cleanpnpm exec oxfmt --check— cleanpnpm typecheck/pnpm typecheck:browser(also run via the pre-commit hook) — cleanToolCallGroup.vue,ToolCallCard.vue,agentTranscript.ts, the feat: restore tool-call work summary on reload and chat switch #18282/[backport cloud/1.54] feat: restore tool-call work summary on reload and chat switch #18555 diffs, and confirmingWorkSummary.vueexists only onmain(git ls-treecomparison againstorigin/main)playwright-tests (cloud)to confirm the specific previously-failing test now passesMerge note
Given the severity (blocking CI on this release branch for every subsequent PR) and per explicit maintainer authorization, this PR is being admin-merged ahead of the normal review wait. A post-merge review is requested via comment.
Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
🤖 Generated with Claude Code
https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
Generated by Claude Code