Skip to content

fix: adapt work-summary persistence spec to cloud/1.54's ToolCallGroup UI - #18580

Closed
claude[bot] wants to merge 1 commit into
cloud/1.54from
claude/fix-work-summary-cloud-1.54-dff48ac4b0
Closed

claude[bot] wants to merge 1 commit into
cloud/1.54from
claude/fix-work-summary-cloud-1.54-dff48ac4b0

Conversation

@claude

@claude claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

<!-- ccr-slack-attribution -->
Requested by Christian Byrne · Slack thread

Summary

browser_tests/tests/agent/agentToolCallHistoryPersistence.spec.ts:24 ("keeps a completed turn work summary after a browser refresh") has been deterministically failing on cloud/1.54 since #18555 merged, blocking playwright-tests (cloud) on every subsequent PR:

Error: expect(locator).toBeVisible() failed
Locator: locator('#agent-panel-root').getByRole('button', { name: 'Worked', exact: true })

Same regression, same cause, on core/1.54 via the parallel backport #18554.

Root cause

#18555 (backport of #18282, "restore tool-call work summary on reload and chat switch") correctly ported the data-layer restoration logic — agentTranscript.ts, agentEventTransport.ts, agentApiSchema.ts — which reads a persisted assistant row's content.tool_calls and folds it into the same ToolParts the live WebSocket path builds.

But it also cherry-picked the new Playwright spec verbatim from main, where the completed-turn summary trigger is WorkSummary.vue (added by a separate, unrelated main-only rename/refactor that replaced ToolCallGroup.vue/ToolCallCard.vue with WorkSummary.vue/ActivityTrace.vue). WorkSummary.vue unconditionally renders t('agent.worked') ("Worked").

cloud/1.54 predates that rename: it still renders the older ToolCallGroup.vue, whose trigger shows a dynamic status label — "Ran {count} tool call(s)[ for {seconds} seconds]" — and never "Worked". agent.worked is an orphaned i18n key on this branch (present in locales/*/main.json, referenced by no component). So the persistence behavior was already correctly restored — only the test's UI assertion targeted a component that doesn't exist here.

Porting the full WorkSummary/ActivityTrace rename was considered and rejected as out of scope for this fix: it would also require rewriting the several existing, intentional assertions in ToolCallGroup.test.ts that pin the current "Ran N tool calls" label.

Fix

Adapt the spec's final assertions to this branch's actual (working) UI, the same kind of branch-specific adaptation the backport already made for the entry-button locator (agent.askComfyAgent vs. main's agent.entryButton):

  • Trigger button matcher: name: enMessages.agent.worked, exact: true → name: /^Ran 2 tool calls for 0\.6 seconds/ (2 calls: 420ms + 180ms from the test's own mock data).
  • Corrected an inaccurate code comment that still referenced "WorkSummary UI".

No production code changed — this is a test-only fix.

Verification

Merge note

Given the severity (blocking CI on this release branch for every subsequent PR) and per explicit maintainer authorization, this PR is being admin-merged ahead of the normal review wait. A post-merge review is requested via comment.

Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY


🤖 Generated with Claude Code

https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY


Generated by Claude Code

…up UI

The #18555 backport of "restore tool-call work summary on reload and
chat switch" ported browser_tests/tests/agent/agentToolCallHistoryPersistence.spec.ts
verbatim from main, where the completed-turn summary trigger is
main-only WorkSummary.vue (labeled "Worked"). cloud/1.54 predates that
rename and still renders the older ToolCallGroup.vue, whose trigger
reads "Ran N tool calls...". The data-layer restoration logic
(agentTranscript.ts, agentEventTransport.ts, agentApiSchema.ts) backported
correctly; only the spec's UI assertion was stale, causing the
deterministic "Worked" button-not-found failure blocking
playwright-tests (cloud).
@vercel

vercel Bot commented Sep 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 9:43am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 5442731f-80c7-47ac-9576-7dfda7423d44

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1941 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1920 / ❌ 0 / ⚠️ 2 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 148ms TBT · 80.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.7 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 163.3 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 38ms TBT · 165.7 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 414ms TBT · 171.9 MB heap
vue-zoom-out-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 584ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.3 MB
canvas-idle: DOM nodes -279
canvas-idle: event listeners -181
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 890ms
canvas-mouse-sweep: script duration 163ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.1 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -194
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 385ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.0 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 445ms
dom-widget-clipping: script duration 158ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.1 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 645ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.5 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1663ms
large-graph-pan: script duration 814ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.6 MB
large-graph-pan: DOM nodes -136
large-graph-pan: event listeners -78
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1746ms
large-graph-zoom: script duration 779ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.8 MB
large-graph-zoom: DOM nodes -141
large-graph-zoom: event listeners -90
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 2008ms
legacy-node-drag: script duration 972ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.9 MB
legacy-node-drag: DOM nodes -269
legacy-node-drag: event listeners -11
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 640ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.2 MB
minimap-idle: DOM nodes -275
minimap-idle: event listeners -177
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 418ms
subgraph-dom-widget-clipping: script duration 146ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.1 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 528ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 55.8 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -210
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 843ms
subgraph-mouse-sweep: script duration 116ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 67.4 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -227
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 974ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 148ms
subgraph-transition-enter: heap used 80.7 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 6154ms
viewport-pan-sweep: script duration 2791ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 90.7 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -160
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16854ms
vue-large-graph-idle: script duration 319ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 163.3 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 169
vue-large-graph-pan: task duration 20740ms
vue-large-graph-pan: script duration 900ms
vue-large-graph-pan: TBT 38ms
vue-large-graph-pan: heap used 165.7 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14925
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 79ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6127ms
vue-node-resize-workload: script duration 118ms
vue-node-resize-workload: TBT 414ms
vue-node-resize-workload: heap used 171.9 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14932
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8682ms
vue-zoom-out-idle: script duration 147ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.9 MB
vue-zoom-out-idle: DOM nodes -1
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 104ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.1 MB
workflow-execution: DOM nodes 139
workflow-execution: event listeners 41
Raw data
{
  "timestamp": "2026-09-23T09:54:29.547Z",
  "gitSha": "dd5701bc67b061eab325cbce5ba9a1c1b05e144d",
  "branch": "claude/fix-work-summary-cloud-1.54-dff48ac4b0",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2086.9670000000156,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.774,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 637.2679999999999,
      "heapDeltaBytes": -9587756,
      "heapUsedBytes": 60639856,
      "domNodes": -278,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 10.250000000000002,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2071.737999999982,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.083,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 530.1899999999999,
      "heapDeltaBytes": 5118544,
      "heapUsedBytes": 76267768,
      "domNodes": -280,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.355999999999996,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1814.31699999996,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 28.104999999999997,
      "layouts": 14,
      "layoutDurationMs": 3.856,
      "taskDurationMs": 872.2460000000001,
      "heapDeltaBytes": -5237796,
      "heapUsedBytes": 64807028,
      "domNodes": -279,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 160.23299999999998,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1872.7760000000444,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 32.455,
      "layouts": 14,
      "layoutDurationMs": 4.335,
      "taskDurationMs": 907.278,
      "heapDeltaBytes": -3498024,
      "heapUsedBytes": 67620880,
      "domNodes": -279,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 165.35300000000004,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.474999999994,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.322,
      "layouts": 6,
      "layoutDurationMs": 1.1,
      "taskDurationMs": 364.13000000000005,
      "heapDeltaBytes": 4627556,
      "heapUsedBytes": 75519704,
      "domNodes": 76,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 10.892000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1667.6800000000185,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.2,
      "layouts": 6,
      "layoutDurationMs": 1.183,
      "taskDurationMs": 405.962,
      "heapDeltaBytes": 4629748,
      "heapUsedBytes": 75457316,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 13.544000000000004,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 632.9290000000469,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.4209999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 440.86800000000005,
      "heapDeltaBytes": -8226072,
      "heapUsedBytes": 62966528,
      "domNodes": 18,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 157.96099999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 674.0459999999757,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.209000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 448.57399999999996,
      "heapDeltaBytes": 18040008,
      "heapUsedBytes": 88291804,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 157.04500000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.8759999999925,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.474000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 637.6560000000001,
      "heapDeltaBytes": -16112740,
      "heapUsedBytes": 87417052,
      "domNodes": -266,
      "jsHeapTotalBytes": -331776,
      "scriptDurationMs": 40.20900000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.3619999999455,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.372999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 653.134,
      "heapDeltaBytes": 6518452,
      "heapUsedBytes": 83480460,
      "domNodes": -278,
      "jsHeapTotalBytes": -2203648,
      "scriptDurationMs": 32.372,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2340.8769999999777,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.797,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1643.6669999999997,
      "heapDeltaBytes": 20367152,
      "heapUsedBytes": 87364208,
      "domNodes": 4,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 819.783,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2376.5589999999293,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.047999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1682.3949999999998,
      "heapDeltaBytes": 22039128,
      "heapUsedBytes": 87962912,
      "domNodes": -275,
      "jsHeapTotalBytes": 1536000,
      "scriptDurationMs": 808.624,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3590.003999999965,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.094000000000003,
      "layouts": 60,
      "layoutDurationMs": 12.171000000000001,
      "taskDurationMs": 1732.371,
      "heapDeltaBytes": 8194756,
      "heapUsedBytes": 76043424,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 770.089,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3575.2449999999953,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 10.915000000000001,
      "layouts": 60,
      "layoutDurationMs": 11.923999999999998,
      "taskDurationMs": 1760.014,
      "heapDeltaBytes": 10199436,
      "heapUsedBytes": 76560196,
      "domNodes": -282,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 788.192,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3173.5850000000028,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 7.77,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2052.9990000000003,
      "heapDeltaBytes": 6000072,
      "heapUsedBytes": 86573756,
      "domNodes": -255,
      "jsHeapTotalBytes": 573440,
      "scriptDurationMs": 990.3729999999999,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3155.3250000000617,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 7.052,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1962.6520000000003,
      "heapDeltaBytes": 3978220,
      "heapUsedBytes": 85281608,
      "domNodes": -283,
      "jsHeapTotalBytes": 1359872,
      "scriptDurationMs": 953.602,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.8589999999544,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.321999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 609.3990000000001,
      "heapDeltaBytes": 9908544,
      "heapUsedBytes": 88032268,
      "domNodes": -270,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 33.44,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2078.8330000000315,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 10.322999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 670.9730000000001,
      "heapDeltaBytes": 4768888,
      "heapUsedBytes": 82260988,
      "domNodes": -280,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 38.09700000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 580.7479999999714,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.02,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.44499999999994,
      "heapDeltaBytes": 15083308,
      "heapUsedBytes": 88358636,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 139.172,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 627.8700000000299,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.16,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.43100000000004,
      "heapDeltaBytes": 14638828,
      "heapUsedBytes": 87988872,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 153.807,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2030.6629999999473,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.300999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 542.206,
      "heapDeltaBytes": -14676940,
      "heapUsedBytes": 58562764,
      "domNodes": -295,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 11.109,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.2400000000107,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.038999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 513.311,
      "heapDeltaBytes": -14858012,
      "heapUsedBytes": 58417204,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.165,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1756.5369999999803,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 28.584000000000003,
      "layouts": 18,
      "layoutDurationMs": 4.809000000000001,
      "taskDurationMs": 837.545,
      "heapDeltaBytes": -5434480,
      "heapUsedBytes": 67871496,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 119.478,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1750.9569999999712,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 28.762,
      "layouts": 18,
      "layoutDurationMs": 4.779,
      "taskDurationMs": 847.9270000000001,
      "heapDeltaBytes": 278004,
      "heapUsedBytes": 73548708,
      "domNodes": -295,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 112.35800000000002,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1418.3289999999715,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 33.528999999999996,
      "layouts": 15,
      "layoutDurationMs": 16.235000000000003,
      "taskDurationMs": 974.4439999999998,
      "heapDeltaBytes": -5313544,
      "heapUsedBytes": 84671068,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 32.122,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 148,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9324.092000000008,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.27100000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6216.047,
      "heapDeltaBytes": 19541552,
      "heapUsedBytes": 96134680,
      "domNodes": -272,
      "jsHeapTotalBytes": 610304,
      "scriptDurationMs": 2841.02,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8930.276999999933,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.104,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6091.120999999999,
      "heapDeltaBytes": -9671436,
      "heapUsedBytes": 94078412,
      "domNodes": -267,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 2740.377,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17107.100000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16616.171000000002,
      "heapDeltaBytes": -72127472,
      "heapUsedBytes": 165727820,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16191488,
      "scriptDurationMs": 282.542,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17876.30200000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17092.047000000002,
      "heapDeltaBytes": -40821024,
      "heapUsedBytes": 176654532,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12115968,
      "scriptDurationMs": 355.783,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21183.99900000003,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 18.965999999999983,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20848.343,
      "heapDeltaBytes": -49319732,
      "heapUsedBytes": 168562300,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10518528,
      "scriptDurationMs": 895.0579999999999,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 17,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20906.053000000044,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 19.652,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20632.425000000003,
      "heapDeltaBytes": -52425096,
      "heapUsedBytes": 178942760,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17739776,
      "scriptDurationMs": 904.827,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 58,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6175.283999999976,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.94800000000002,
      "layouts": 20,
      "layoutDurationMs": 21.95100000000001,
      "taskDurationMs": 6040.933,
      "heapDeltaBytes": -41266220,
      "heapUsedBytes": 176362008,
      "domNodes": -8068,
      "jsHeapTotalBytes": 8638464,
      "scriptDurationMs": 113.341,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 368,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6264.404000000013,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.368,
      "layouts": 20,
      "layoutDurationMs": 24.13299999999999,
      "taskDurationMs": 6212.279999999999,
      "heapDeltaBytes": -33932644,
      "heapUsedBytes": 184138060,
      "domNodes": -8068,
      "jsHeapTotalBytes": 14667776,
      "scriptDurationMs": 122.93200000000002,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 459,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9014.913000000091,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8803.964,
      "heapDeltaBytes": -1146076,
      "heapUsedBytes": 179674676,
      "domNodes": 0,
      "jsHeapTotalBytes": -27787264,
      "scriptDurationMs": 153.39899999999994,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8836.749000000054,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8560.782,
      "heapDeltaBytes": 20176920,
      "heapUsedBytes": 178628300,
      "domNodes": -1,
      "jsHeapTotalBytes": -10223616,
      "scriptDurationMs": 140.4080000000001,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 490.8030000000281,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 28.353,
      "layouts": 3,
      "layoutDurationMs": 1.569,
      "taskDurationMs": 135.087,
      "heapDeltaBytes": 5025292,
      "heapUsedBytes": 74359064,
      "domNodes": 151,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 14.302999999999999,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 110.62500000002728,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 15.670000000000003,
      "layouts": 3,
      "layoutDurationMs": 1.3270000000000002,
      "taskDurationMs": 72.934,
      "heapDeltaBytes": 2957384,
      "heapUsedBytes": 70614568,
      "domNodes": 127,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.728999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026

Copy link
Copy Markdown
Contributor

@claude Coordination before merge: this overlaps #18582, which I opened from the same cloud/1.54 baseline while independently reproducing this failure. We agree on the root cause: ToolCallGroup is already hydrated; Worked belongs to main’s newer renderer.

Please hold merge here and confirm consolidation on #18582. It preserves every existing visibility/collapse assertion, uses the exact shipped header, asserts both row durations, and adds New chat → history → original chat restoration via source #18581. Local proof at its published head: 2 browser tests passed; targeted persistence repeated independently 3 times with retries disabled (3 passed); 117 unit tests; app/browser typecheck and hooks/Knip passed. Hosted CI remains pending and no checks will be waived.

I will retain ownership of CI qualification and the authorized post-check merge, with a post-merge review request. If you have additional requirements or verification not in this PR, please flag them before we retire the duplicate. No production deployment, feature flags, or package pins are involved.

@claude

claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Closing this as superseded by #18582, which independently fixes the same regression and additionally covers chat-switch persistence (per Christian Byrne's request), which this PR does not.

Generated by Claude Code

@claude claude Bot closed this Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18580   +/-   ##
=============================================
  Coverage              ?   78.70%           
=============================================
  Files                 ?     2015           
  Lines                 ?   111589           
  Branches              ?    33723           
=============================================
  Hits                  ?    87823           
  Misses                ?    23586           
  Partials              ?      180           
Flag Coverage Δ
unit 78.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

christian-byrne added a commit that referenced this pull request Sep 23, 2026
…ntity (#18581) (#18587)

## Summary
Carry the thread-identity review follow-up from #18581 onto
already-merged #18582, without changing runtime behavior or its
release-specific label assertions.

## Changes
- Record actual GET thread IDs in this spec’s overriding route, require
a fresh history read, then assert the selected chat is the same one
restored on reload.
- Keep tracking test-local because the older release fixture does not
expose main’s historyRequestThreadIds. No shared-fixture backport
needed.
- Preserve all collapsed/expanded, row-label/duration, and
new-chat/no-leak assertions. One test file only; no pins, flags,
workflow or production changes.

## Review Focus
The first identity-only source follow-up went red locally with an
undefined ID because this GET override bypasses the shared fixture’s
recorder. Source correction now records the override and waits for a new
read, preventing stale-ID false positives. This Cloud follow-up
preserves those assertions with a local recorder.

Local validation: the affected persistence test passes. In the combined
run, the unchanged preceding inline-prompt test failed its final
keyboard-edit assertion; that failure is recorded rather than reported
as green. Hosted exact-head checks remain required before merge. #18580
was closed by its author as superseded; #18582 is already merged and its
history is untouched.

---------

Co-authored-by: Amp <amp@ampcode.com>
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants