Repository navigation
[backport cloud/1.54] test(agent): verify restored history thread identity (#18581) - #18587
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Final local verification at 919d8183ab: affected persistence scenario repeated independently with retries disabled: 3 passed (34.5s). Commit/push hooks passed oxfmt, type-aware oxlint, ESLint, full app typecheck, browser typecheck and Knip. The earlier neighboring keyboard-edit failure remains recorded in the PR description. No source fixture, runtime, package, flag, or workflow changes. Please route further changes through this repair owner so exact-head qualification is not invalidated by concurrent pushes. Merge awaits source #18581 and this head’s hosted checks; no pending or failed checks will be bypassed. |
🎭 Playwright: ✅ 1945 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T10:25:37.179Z",
"gitSha": "75ac0631878783cda8a4861a26c56daa951e34c1",
"branch": "test/cloud-summary-history-identity",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2078.972999999962,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.120999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.762,
"heapDeltaBytes": -9572800,
"heapUsedBytes": 61265352,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.450000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2055.253999999991,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.743,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.5970000000001,
"heapDeltaBytes": -11965180,
"heapUsedBytes": 58549420,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.323,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2177.7910000000134,
"styleRecalcs": 81,
"styleRecalcDurationMs": 42.099,
"layouts": 14,
"layoutDurationMs": 4.893,
"taskDurationMs": 1098.9410000000003,
"heapDeltaBytes": 6014500,
"heapUsedBytes": 76854240,
"domNodes": -277,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 194.549,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1816.5319999999383,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.117,
"layouts": 14,
"layoutDurationMs": 3.641,
"taskDurationMs": 834.723,
"heapDeltaBytes": 8767188,
"heapUsedBytes": 79997192,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 151.967,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.3739999999607,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.963,
"layouts": 6,
"layoutDurationMs": 1.2429999999999999,
"taskDurationMs": 405.59700000000004,
"heapDeltaBytes": 4548232,
"heapUsedBytes": 74989888,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 14.991999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.407999999973,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.209999999999999,
"layouts": 6,
"layoutDurationMs": 0.9240000000000002,
"taskDurationMs": 337.55,
"heapDeltaBytes": 4612244,
"heapUsedBytes": 75666544,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.953,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 704.9209999999562,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.688999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.29900000000004,
"heapDeltaBytes": -7825912,
"heapUsedBytes": 63156324,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 168.61499999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 642.2179999999571,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.356999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.408,
"heapDeltaBytes": 18717964,
"heapUsedBytes": 88757260,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 162.07000000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.9049999999957,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.721000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 611.432,
"heapDeltaBytes": 6693648,
"heapUsedBytes": 83321000,
"domNodes": -274,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 31.997999999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2044.8159999999689,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.007000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.913,
"heapDeltaBytes": 11001988,
"heapUsedBytes": 87621772,
"domNodes": -271,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 27.345999999999997,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2379.1630000000055,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.641,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1654.1560000000002,
"heapDeltaBytes": 3637132,
"heapUsedBytes": 80979332,
"domNodes": -276,
"jsHeapTotalBytes": 118784,
"scriptDurationMs": 807.498,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2233.2480000000032,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.843000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1608.861,
"heapDeltaBytes": 19057528,
"heapUsedBytes": 85180624,
"domNodes": -277,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 812.142,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3521.616999999992,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.714,
"layouts": 60,
"layoutDurationMs": 12.145,
"taskDurationMs": 1728.333,
"heapDeltaBytes": 9940340,
"heapUsedBytes": 76967780,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 779.1199999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3537.9120000000057,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.186000000000003,
"layouts": 60,
"layoutDurationMs": 11.437000000000001,
"taskDurationMs": 1672.3999999999999,
"heapDeltaBytes": 7753112,
"heapUsedBytes": 75769888,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 773.398,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3153.0930000000126,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.090999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1986.0090000000002,
"heapDeltaBytes": 23901360,
"heapUsedBytes": 89160368,
"domNodes": -282,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 978.3019999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3195.9580000000187,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.692000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1987.7289999999998,
"heapDeltaBytes": 7109812,
"heapUsedBytes": 87598520,
"domNodes": -256,
"jsHeapTotalBytes": -999424,
"scriptDurationMs": 975.861,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.1090000000436,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.847999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.34,
"heapDeltaBytes": 9928852,
"heapUsedBytes": 87596468,
"domNodes": -269,
"jsHeapTotalBytes": -2465792,
"scriptDurationMs": 32.086000000000006,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2031.5779999999677,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.213999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.4519999999999,
"heapDeltaBytes": 5420168,
"heapUsedBytes": 82929352,
"domNodes": -282,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 32.48999999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.1219999999798,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.319999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.1020000000001,
"heapDeltaBytes": 13918712,
"heapUsedBytes": 86528892,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.12800000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.3179999999584,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.607999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.7219999999999,
"heapDeltaBytes": 15038872,
"heapUsedBytes": 88439456,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 142.486,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2034.0850000000046,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.089,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.2249999999999,
"heapDeltaBytes": -14517924,
"heapUsedBytes": 58564068,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.748,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.2810000000964,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.49,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.178,
"heapDeltaBytes": 8408396,
"heapUsedBytes": 81782260,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.202,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.9169999999717,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.646000000000004,
"layouts": 18,
"layoutDurationMs": 4.56,
"taskDurationMs": 792.4689999999999,
"heapDeltaBytes": -7222336,
"heapUsedBytes": 65265672,
"domNodes": -294,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 105.877,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1751.3360000000375,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.726,
"layouts": 18,
"layoutDurationMs": 4.562,
"taskDurationMs": 795.195,
"heapDeltaBytes": -15858160,
"heapUsedBytes": 57283660,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 104.175,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.2790000000077,
"styleRecalcs": 20,
"styleRecalcDurationMs": 33.980999999999995,
"layouts": 16,
"layoutDurationMs": 16.133000000000003,
"taskDurationMs": 926.0909999999998,
"heapDeltaBytes": 21510804,
"heapUsedBytes": 106493816,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.125,
"eventListeners": 2387,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9421.294999999987,
"styleRecalcs": 248,
"styleRecalcDurationMs": 41.269,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6244.666,
"heapDeltaBytes": -13008996,
"heapUsedBytes": 90387668,
"domNodes": -266,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 2861.451,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8401.281000000039,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.611000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5784.166,
"heapDeltaBytes": 9877084,
"heapUsedBytes": 85671228,
"domNodes": -248,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 2769.6169999999997,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16892.626000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16328.629000000003,
"heapDeltaBytes": -49977676,
"heapUsedBytes": 177717264,
"domNodes": -8068,
"jsHeapTotalBytes": -19881984,
"scriptDurationMs": 308.743,
"eventListeners": -14935,
"totalBlockingTimeMs": 1,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16773.505999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16189.904000000002,
"heapDeltaBytes": -40434508,
"heapUsedBytes": 176717412,
"domNodes": -8068,
"jsHeapTotalBytes": -8925184,
"scriptDurationMs": 307.51099999999997,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20752.545,
"styleRecalcs": 176,
"styleRecalcDurationMs": 17.612000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20401.753999999997,
"heapDeltaBytes": -59117588,
"heapUsedBytes": 178575656,
"domNodes": -8068,
"jsHeapTotalBytes": -16670720,
"scriptDurationMs": 905.558,
"eventListeners": -14925,
"totalBlockingTimeMs": 197,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20903.737999999976,
"styleRecalcs": 172,
"styleRecalcDurationMs": 18.08499999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20517.94,
"heapDeltaBytes": -56237784,
"heapUsedBytes": 182904420,
"domNodes": -8068,
"jsHeapTotalBytes": -18264064,
"scriptDurationMs": 925.6679999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 94,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5934.52400000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.428,
"layouts": 20,
"layoutDurationMs": 22.744,
"taskDurationMs": 5844.249,
"heapDeltaBytes": -36516332,
"heapUsedBytes": 182220036,
"domNodes": -8068,
"jsHeapTotalBytes": 13074432,
"scriptDurationMs": 103.22399999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 387,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6086.167000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 104.50999999999999,
"layouts": 20,
"layoutDurationMs": 34.529,
"taskDurationMs": 5976.33,
"heapDeltaBytes": -46682608,
"heapUsedBytes": 177486256,
"domNodes": -8068,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 154.334,
"eventListeners": -14927,
"totalBlockingTimeMs": 510,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8292.146000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7896.593000000001,
"heapDeltaBytes": 14018184,
"heapUsedBytes": 188410904,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 120.49100000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8608.306999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8361.968,
"heapDeltaBytes": -11987548,
"heapUsedBytes": 178337768,
"domNodes": 0,
"jsHeapTotalBytes": -20971520,
"scriptDurationMs": 152.82000000000008,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 451.87299999997776,
"styleRecalcs": 14,
"styleRecalcDurationMs": 22.053000000000004,
"layouts": 3,
"layoutDurationMs": 0.7739999999999999,
"taskDurationMs": 106.37,
"heapDeltaBytes": 4780468,
"heapUsedBytes": 73845172,
"domNodes": 122,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.02,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 106.87100000006922,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.671000000000001,
"layouts": 2,
"layoutDurationMs": 0.632,
"taskDurationMs": 65.55199999999999,
"heapDeltaBytes": 3014200,
"heapUsedBytes": 67485720,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.584999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18587 +/- ##
=============================================
Coverage ? 83.66%
=============================================
Files ? 2105
Lines ? 124599
Branches ? 31587
=============================================
Hits ? 104246
Misses ? 20174
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Admin-merged the qualified head 919d818 under the incident repair authorization after all exact-head checks passed, including the full browser aggregate, Cloud browser job, unit tests, lint/typechecks, performance and ecosystem. Source #18581 is now merged and had CodeRabbit approval at its final tested head. The release adapter uses a test-local request tracker because this branch does not expose the newer source fixture tracker; it preserves the same fresh-request and thread-identity assertions. @dante01yoon please perform post-merge review of this narrow follow-up and the release-label repair in #18582, especially reload → New chat → original history selection and both rendered tool-call rows. The earlier local neighboring keyboard-edit failure is retained in the PR description; this exact head’s hosted browser suite passed. No manual deployment, production pin change, feature-flag change or workflow change was performed. Standard merge-triggered automation is being tracked separately. |
|
Qualification detail from the final Cloud job logs: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35847632249/job/107138248714 passed under the configured CI retry policy with 218 passed, 1 flaky and 2 skipped. The flaky case was the unchanged agentInlinePrompt.spec.ts:148 keyboard-edit assertion, consistent with the preceding local neighboring-test failure already recorded here. The repaired persistence scenario was not listed as flaky and passed three independent local runs with retries disabled. No assertion or retry configuration was changed to obtain green checks. |
|
Automatic pipeline receipt: dispatch https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35849830032 and downstream https://github.com/Comfy-Org/cloud/actions/runs/35849843457 both succeeded. Downstream resolve logs bind TARGET_REF to merge commit b2fd9e4 and TARGET_BRANCH to cloud/1.54. All build/upload jobs, automatic testcloud update and staging runtime verification completed successfully. No manual workflow dispatch, production pin promotion or feature-flag change was performed. Post-merge review of #18582 and this follow-up remains requested from @dante01yoon. |
Summary
Carry the thread-identity review follow-up from #18581 onto already-merged #18582, without changing runtime behavior or its release-specific label assertions.
Changes
Review Focus
The first identity-only source follow-up went red locally with an undefined ID because this GET override bypasses the shared fixture’s recorder. Source correction now records the override and waits for a new read, preventing stale-ID false positives. This Cloud follow-up preserves those assertions with a local recorder.
Local validation: the affected persistence test passes. In the combined run, the unchanged preceding inline-prompt test failed its final keyboard-edit assertion; that failure is recorded rather than reported as green. Hosted exact-head checks remain required before merge. #18580 was closed by its author as superseded; #18582 is already merged and its history is untouched.