Repository navigation
[backport cloud/1.54] fix(agent): defer What's New popup while agent onboarding runs (#18287) - #18556
Conversation
A new user going through the agent onboarding tour also got the What's New popup at the same time, so the two overlapped on screen. The popup now waits until the onboarding coach is gone, then shows on its own. - Fixes PM-1461 - **What**: `shouldShowPopup` in `releaseStore.ts` now also returns false while an onboarding overlay is active, right next to the check that already defers to the first-run tour. When the overlay clears, the popup re-evaluates and can show. A new platform `onboardingOverlayStore` holds that signal as a registry of getters, and `OnboardingCoach.vue` registers its own running state into it and drops it with the component's scope on unmount. - **Breaking**: None. The agent onboarding coach is a separate system from the tour store, so it does not set `activeTour` and the existing first-run deferral never saw it. This adds a second deferral signal rather than folding the coach into the tour store. Unifying the two is a larger change: `activeTour` is a tagged value the tour store depends on elsewhere, not a boolean, so it does not collapse cleanly. Worth a look at `releaseStore.ts:177-184` to confirm the two guards reading as one intent is acceptable. The store lives in platform, not workbench, because `releaseStore` reads it and platform cannot import the agent code in workbench. The register-a-getter shape is what keeps that direction legal. - [x] Unit: 654 passing across the touched platform and agent suites - [x] Unit: `onboardingOverlayStore` covers no-source, reactive source, OR over sources, deregister, and per-source deregister - [x] Red-green: removing the `releaseStore` guard fails the overlay deferral test; restoring it passes - [x] Mutation: 4/4 killed on changed lines, 0 survivors; the per-source deregister test kills the disposer clear-all mutant - [x] Manual (staging): sign in, open the agent panel, accept consent, and confirm the four-step onboarding coach shows with no What's New popup over it; finish or skip the coach and confirm the popup is then free to appear
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1940 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T06:02:37.584Z",
"gitSha": "5f768cbc2512e1365120f951046374e809466c9a",
"branch": "backport-18287-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2071.7200000000275,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.431999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 653.732,
"heapDeltaBytes": 8675136,
"heapUsedBytes": 78737088,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 13.078,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2037.4380000000656,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.757,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.91600000000005,
"heapDeltaBytes": 3098264,
"heapUsedBytes": 73265200,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 15.33,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1867.6399999999944,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.702999999999996,
"layouts": 14,
"layoutDurationMs": 4.0489999999999995,
"taskDurationMs": 924.8409999999999,
"heapDeltaBytes": 1732412,
"heapUsedBytes": 72393180,
"domNodes": -280,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 166.107,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.1469999999917,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.345000000000002,
"layouts": 14,
"layoutDurationMs": 3.8850000000000002,
"taskDurationMs": 865.6049999999999,
"heapDeltaBytes": 8665144,
"heapUsedBytes": 79124240,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 159.124,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1681.9619999999986,
"styleRecalcs": 29,
"styleRecalcDurationMs": 16.382,
"layouts": 6,
"layoutDurationMs": 1.071,
"taskDurationMs": 422.71000000000004,
"heapDeltaBytes": 4651120,
"heapUsedBytes": 75339184,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 15.463000000000001,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.036999999953,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.758000000000003,
"layouts": 6,
"layoutDurationMs": 1.1,
"taskDurationMs": 379.313,
"heapDeltaBytes": 4650024,
"heapUsedBytes": 75380216,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.094000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 711.8970000000218,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.558,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.30799999999994,
"heapDeltaBytes": -7870152,
"heapUsedBytes": 63175820,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 169.242,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 664.6030000000565,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.163,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.845,
"heapDeltaBytes": -7884016,
"heapUsedBytes": 63183944,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 168.242,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2068.956999999955,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.08,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 730.0049999999999,
"heapDeltaBytes": 7032452,
"heapUsedBytes": 82951876,
"domNodes": -275,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 39.04400000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.013000000007,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.785,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 668.7990000000001,
"heapDeltaBytes": 9743064,
"heapUsedBytes": 85378072,
"domNodes": -271,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 35.886999999999986,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2621.3730000000055,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.211000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1810.1309999999999,
"heapDeltaBytes": 23466404,
"heapUsedBytes": 89749848,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 886.745,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2621.093999999971,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.723000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1831.502,
"heapDeltaBytes": 7989348,
"heapUsedBytes": 84948100,
"domNodes": -248,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 905.88,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3793.3610000000044,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.387999999999998,
"layouts": 60,
"layoutDurationMs": 12.52,
"taskDurationMs": 1819.028,
"heapDeltaBytes": 8032264,
"heapUsedBytes": 75964176,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 810.773,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3674.323999999956,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.047999999999998,
"layouts": 60,
"layoutDurationMs": 12.228,
"taskDurationMs": 1764.6829999999998,
"heapDeltaBytes": 8306092,
"heapUsedBytes": 76123348,
"domNodes": -280,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 795.0849999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3105.8949999999754,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.937,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2034.1950000000004,
"heapDeltaBytes": 22417916,
"heapUsedBytes": 89284328,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 972.41,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3127.6300000000674,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.895999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1988.9530000000002,
"heapDeltaBytes": 13761528,
"heapUsedBytes": 81341080,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 976.6429999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.1840000000425,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.8990000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 645.459,
"heapDeltaBytes": 22094676,
"heapUsedBytes": 88004744,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.719,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2064.1669999999976,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.703,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 653.6990000000001,
"heapDeltaBytes": 5302260,
"heapUsedBytes": 82637768,
"domNodes": -280,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 40.743,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 586.7620000000215,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.383999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.21,
"heapDeltaBytes": 14724180,
"heapUsedBytes": 87482832,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 144.91799999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.5670000000127,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.166999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.57,
"heapDeltaBytes": 14953712,
"heapUsedBytes": 88260040,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 148.032,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2012.4870000000215,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.06,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.6750000000001,
"heapDeltaBytes": -8981116,
"heapUsedBytes": 63028480,
"domNodes": -292,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.488999999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2031.8240000000287,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.932000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.281,
"heapDeltaBytes": -2170720,
"heapUsedBytes": 69540908,
"domNodes": -294,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.658,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1737.3610000000212,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.648,
"layouts": 18,
"layoutDurationMs": 5.514,
"taskDurationMs": 913.138,
"heapDeltaBytes": -4358120,
"heapUsedBytes": 68232608,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 125.81500000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.9749999999958,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.961,
"layouts": 18,
"layoutDurationMs": 5.551,
"taskDurationMs": 837.527,
"heapDeltaBytes": -7721296,
"heapUsedBytes": 64434296,
"domNodes": -295,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 112.836,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.6319999999732,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.71300000000001,
"layouts": 15,
"layoutDurationMs": 16.118,
"taskDurationMs": 908.8180000000001,
"heapDeltaBytes": 21109960,
"heapUsedBytes": 109620852,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 33.166,
"eventListeners": 2385,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10382.586000000003,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.357,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6735.486,
"heapDeltaBytes": 22897792,
"heapUsedBytes": 99368752,
"domNodes": -268,
"jsHeapTotalBytes": 2707456,
"scriptDurationMs": 3181.94,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8832.331999999951,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.970000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6150.764999999999,
"heapDeltaBytes": 3991812,
"heapUsedBytes": 80329216,
"domNodes": -273,
"jsHeapTotalBytes": -667648,
"scriptDurationMs": 2746.385,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17488,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16875.202999999998,
"heapDeltaBytes": -58220672,
"heapUsedBytes": 178442580,
"domNodes": -8068,
"jsHeapTotalBytes": -15642624,
"scriptDurationMs": 287.285,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17587.701000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16975.835,
"heapDeltaBytes": -63388232,
"heapUsedBytes": 178812772,
"domNodes": -8068,
"jsHeapTotalBytes": -18829312,
"scriptDurationMs": 285.65299999999996,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21335.54499999997,
"styleRecalcs": 165,
"styleRecalcDurationMs": 20.334000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21017.909,
"heapDeltaBytes": -39068988,
"heapUsedBytes": 192748392,
"domNodes": -8068,
"jsHeapTotalBytes": -19906560,
"scriptDurationMs": 912.1279999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20694.60300000003,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.538999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20290.816,
"heapDeltaBytes": -26091516,
"heapUsedBytes": 192646488,
"domNodes": -8068,
"jsHeapTotalBytes": -10088448,
"scriptDurationMs": 902.9050000000001,
"eventListeners": -14925,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6381.9830000000475,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.27799999999996,
"layouts": 20,
"layoutDurationMs": 26.073,
"taskDurationMs": 6265.668,
"heapDeltaBytes": -56208496,
"heapUsedBytes": 181991896,
"domNodes": -8068,
"jsHeapTotalBytes": 12156928,
"scriptDurationMs": 114.21699999999998,
"eventListeners": -14929,
"totalBlockingTimeMs": 540,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6234.493000000043,
"styleRecalcs": 20,
"styleRecalcDurationMs": 98.59899999999999,
"layouts": 20,
"layoutDurationMs": 28.758999999999993,
"taskDurationMs": 6117.361,
"heapDeltaBytes": -50764392,
"heapUsedBytes": 175764692,
"domNodes": -8068,
"jsHeapTotalBytes": 2662400,
"scriptDurationMs": 110.73800000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 623,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8857.357999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8474.716,
"heapDeltaBytes": 13403752,
"heapUsedBytes": 178063484,
"domNodes": 0,
"jsHeapTotalBytes": -23592960,
"scriptDurationMs": 143.94099999999997,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8628.17199999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8411.821000000002,
"heapDeltaBytes": 12297072,
"heapUsedBytes": 181762692,
"domNodes": 0,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 133.78699999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 121.9539999999597,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.332,
"layouts": 3,
"layoutDurationMs": 1.662,
"taskDurationMs": 78.888,
"heapDeltaBytes": 3064008,
"heapUsedBytes": 71880164,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.371999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 84.63099999994483,
"styleRecalcs": 5,
"styleRecalcDurationMs": 12.991,
"layouts": 2,
"layoutDurationMs": 0.5930000000000001,
"taskDurationMs": 62.891000000000005,
"heapDeltaBytes": 3007520,
"heapUsedBytes": 71894120,
"domNodes": 102,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.671999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18556 +/- ##
=============================================
Coverage ? 78.68%
=============================================
Files ? 2010
Lines ? 111163
Branches ? 31434
=============================================
Hits ? 87474
Misses ? 23510
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Manual backport of #18287 to
cloud/1.54after the label-driven cherry-pick conflicted insrc/platform/updates/common/releaseStore.test.ts.Resolution
mocks.tourreactive tour-store mock, which its own tests drive directly.releaseStore.ts,onboardingOverlayStore.tsandOnboardingCoach.vueapplied cleanly.Verification
pnpm typecheckpnpm typecheck:browserpnpm test:unit src/platform/updates/common/releaseStore.test.ts— 52 passedpnpm test:unit src/platform/onboarding/onboardingOverlayStore.test.ts src/workbench/extensions/agent/components/agent/OnboardingCoach.test.ts— 19 passedknip