Skip to content

[backport cloud/1.54] fix(agent): defer What's New popup while agent onboarding runs (#18287) - #18556

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-18287-to-cloud-1.54
Sep 23, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-18287-to-cloud-1.54

Conversation

@MaanilVerma

Copy link
Copy Markdown
Collaborator

Summary

Manual backport of #18287 to cloud/1.54 after the label-driven cherry-pick conflicted in src/platform/updates/common/releaseStore.test.ts.

Resolution

  • Keeps the release branch's mocks.tour reactive tour-store mock, which its own tests drive directly.
  • Adds only the overlay-store getter spy the new What's New deferral tests need.
  • releaseStore.ts, onboardingOverlayStore.ts and OnboardingCoach.vue applied cleanly.

Verification

  • pnpm typecheck
  • pnpm typecheck:browser
  • pnpm test:unit src/platform/updates/common/releaseStore.test.ts — 52 passed
  • pnpm test:unit src/platform/onboarding/onboardingOverlayStore.test.ts src/workbench/extensions/agent/components/agent/OnboardingCoach.test.ts — 19 passed
  • pre-push knip

A new user going through the agent onboarding tour also got the What's
New popup at the same time, so the two overlapped on screen. The popup
now waits until the onboarding coach is gone, then shows on its own.

- Fixes PM-1461

- **What**: `shouldShowPopup` in `releaseStore.ts` now also returns
false while an onboarding overlay is active, right next to the check
that already defers to the first-run tour. When the overlay clears, the
popup re-evaluates and can show. A new platform `onboardingOverlayStore`
holds that signal as a registry of getters, and `OnboardingCoach.vue`
registers its own running state into it and drops it with the
component's scope on unmount.
- **Breaking**: None.

The agent onboarding coach is a separate system from the tour store, so
it does not set `activeTour` and the existing first-run deferral never
saw it. This adds a second deferral signal rather than folding the coach
into the tour store. Unifying the two is a larger change: `activeTour`
is a tagged value the tour store depends on elsewhere, not a boolean, so
it does not collapse cleanly. Worth a look at `releaseStore.ts:177-184`
to confirm the two guards reading as one intent is acceptable.

The store lives in platform, not workbench, because `releaseStore` reads
it and platform cannot import the agent code in workbench. The
register-a-getter shape is what keeps that direction legal.

- [x] Unit: 654 passing across the touched platform and agent suites
- [x] Unit: `onboardingOverlayStore` covers no-source, reactive source,
OR over sources, deregister, and per-source deregister
- [x] Red-green: removing the `releaseStore` guard fails the overlay
deferral test; restoring it passes
- [x] Mutation: 4/4 killed on changed lines, 0 survivors; the per-source
deregister test kills the disposer clear-all mutant
- [x] Manual (staging): sign in, open the agent panel, accept consent,
and confirm the four-step onboarding coach shows with no What's New
popup over it; finish or skip the coach and confirm the popup is then
free to appear
@MaanilVerma MaanilVerma added the backport Backporting a PR onto a release candidate label Sep 23, 2026
@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 5:43am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3a384408-6dba-4967-8ac9-23b40d19834b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 05:58:25 AM UTC

Links

🎭 Playwright: ✅ 1940 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1919 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 140ms TBT · 104.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.7 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.4 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 21ms TBT · 183.8 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 582ms TBT · 170.6 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 10ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 580ms
canvas-idle: script duration 14ms
canvas-idle: TBT 0ms
canvas-idle: heap used 72.5 MB
canvas-idle: DOM nodes -278
canvas-idle: event listeners -164
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 29ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 895ms
canvas-mouse-sweep: script duration 163ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.2 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 401ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.9 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 469ms
dom-widget-clipping: script duration 169ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.3 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 699ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.3 MB
large-graph-idle: DOM nodes -273
large-graph-idle: event listeners -192
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1821ms
large-graph-pan: script duration 896ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.3 MB
large-graph-pan: DOM nodes -259
large-graph-pan: event listeners -177
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1792ms
large-graph-zoom: script duration 803ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.5 MB
large-graph-zoom: DOM nodes -140
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2012ms
legacy-node-drag: script duration 975ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.4 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 650ms
minimap-idle: script duration 40ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.4 MB
minimap-idle: DOM nodes -279
minimap-idle: event listeners -177
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 431ms
subgraph-dom-widget-clipping: script duration 146ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.8 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 528ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.2 MB
subgraph-idle: DOM nodes -293
subgraph-idle: event listeners -226
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 875ms
subgraph-mouse-sweep: script duration 119ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 63.3 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -242
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 909ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 140ms
subgraph-transition-enter: heap used 104.5 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6443ms
viewport-pan-sweep: script duration 2964ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.7 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -159
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16926ms
vue-large-graph-idle: script duration 286ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.4 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 169
vue-large-graph-pan: task duration 20654ms
vue-large-graph-pan: script duration 908ms
vue-large-graph-pan: TBT 21ms
vue-large-graph-pan: heap used 183.8 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14925
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 27ms
vue-node-resize-workload: style recalc duration 93ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6192ms
vue-node-resize-workload: script duration 112ms
vue-node-resize-workload: TBT 582ms
vue-node-resize-workload: heap used 170.6 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8443ms
vue-zoom-out-idle: script duration 139ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.6 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 7
workflow-execution: task duration 71ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.6 MB
workflow-execution: DOM nodes 116
workflow-execution: event listeners 26
Raw data
{
  "timestamp": "2026-09-23T06:02:37.584Z",
  "gitSha": "5f768cbc2512e1365120f951046374e809466c9a",
  "branch": "backport-18287-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2071.7200000000275,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.431999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 653.732,
      "heapDeltaBytes": 8675136,
      "heapUsedBytes": 78737088,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 13.078,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.4380000000656,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.757,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 505.91600000000005,
      "heapDeltaBytes": 3098264,
      "heapUsedBytes": 73265200,
      "domNodes": -277,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 15.33,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1867.6399999999944,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 29.702999999999996,
      "layouts": 14,
      "layoutDurationMs": 4.0489999999999995,
      "taskDurationMs": 924.8409999999999,
      "heapDeltaBytes": 1732412,
      "heapUsedBytes": 72393180,
      "domNodes": -280,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 166.107,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1826.1469999999917,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 27.345000000000002,
      "layouts": 14,
      "layoutDurationMs": 3.8850000000000002,
      "taskDurationMs": 865.6049999999999,
      "heapDeltaBytes": 8665144,
      "heapUsedBytes": 79124240,
      "domNodes": -277,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 159.124,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1681.9619999999986,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 16.382,
      "layouts": 6,
      "layoutDurationMs": 1.071,
      "taskDurationMs": 422.71000000000004,
      "heapDeltaBytes": 4651120,
      "heapUsedBytes": 75339184,
      "domNodes": 75,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 15.463000000000001,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.036999999953,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.758000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.1,
      "taskDurationMs": 379.313,
      "heapDeltaBytes": 4650024,
      "heapUsedBytes": 75380216,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 13.094000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 711.8970000000218,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.558,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.30799999999994,
      "heapDeltaBytes": -7870152,
      "heapUsedBytes": 63175820,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 169.242,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 664.6030000000565,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.163,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.845,
      "heapDeltaBytes": -7884016,
      "heapUsedBytes": 63183944,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 168.242,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2068.956999999955,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 8.08,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 730.0049999999999,
      "heapDeltaBytes": 7032452,
      "heapUsedBytes": 82951876,
      "domNodes": -275,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 39.04400000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2056.013000000007,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.785,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 668.7990000000001,
      "heapDeltaBytes": 9743064,
      "heapUsedBytes": 85378072,
      "domNodes": -271,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 35.886999999999986,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2621.3730000000055,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.211000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1810.1309999999999,
      "heapDeltaBytes": 23466404,
      "heapUsedBytes": 89749848,
      "domNodes": -269,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 886.745,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2621.093999999971,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.723000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1831.502,
      "heapDeltaBytes": 7989348,
      "heapUsedBytes": 84948100,
      "domNodes": -248,
      "jsHeapTotalBytes": -405504,
      "scriptDurationMs": 905.88,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3793.3610000000044,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.387999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.52,
      "taskDurationMs": 1819.028,
      "heapDeltaBytes": 8032264,
      "heapUsedBytes": 75964176,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 810.773,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3674.323999999956,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.047999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.228,
      "taskDurationMs": 1764.6829999999998,
      "heapDeltaBytes": 8306092,
      "heapUsedBytes": 76123348,
      "domNodes": -280,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 795.0849999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3105.8949999999754,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.937,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2034.1950000000004,
      "heapDeltaBytes": 22417916,
      "heapUsedBytes": 89284328,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 972.41,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3127.6300000000674,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.895999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1988.9530000000002,
      "heapDeltaBytes": 13761528,
      "heapUsedBytes": 81341080,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 976.6429999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2005.1840000000425,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.8990000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 645.459,
      "heapDeltaBytes": 22094676,
      "heapUsedBytes": 88004744,
      "domNodes": -277,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 38.719,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2064.1669999999976,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 9.703,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 653.6990000000001,
      "heapDeltaBytes": 5302260,
      "heapUsedBytes": 82637768,
      "domNodes": -280,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 40.743,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 586.7620000000215,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.383999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 424.21,
      "heapDeltaBytes": 14724180,
      "heapUsedBytes": 87482832,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 144.91799999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 612.5670000000127,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 13.166999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 437.57,
      "heapDeltaBytes": 14953712,
      "heapUsedBytes": 88260040,
      "domNodes": 22,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 148.032,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2012.4870000000215,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.06,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 548.6750000000001,
      "heapDeltaBytes": -8981116,
      "heapUsedBytes": 63028480,
      "domNodes": -292,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 10.488999999999999,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2031.8240000000287,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.932000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 508.281,
      "heapDeltaBytes": -2170720,
      "heapUsedBytes": 69540908,
      "domNodes": -294,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.658,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1737.3610000000212,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.648,
      "layouts": 18,
      "layoutDurationMs": 5.514,
      "taskDurationMs": 913.138,
      "heapDeltaBytes": -4358120,
      "heapUsedBytes": 68232608,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 125.81500000000001,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.9749999999958,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.961,
      "layouts": 18,
      "layoutDurationMs": 5.551,
      "taskDurationMs": 837.527,
      "heapDeltaBytes": -7721296,
      "heapUsedBytes": 64434296,
      "domNodes": -295,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 112.836,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.6319999999732,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 32.71300000000001,
      "layouts": 15,
      "layoutDurationMs": 16.118,
      "taskDurationMs": 908.8180000000001,
      "heapDeltaBytes": 21109960,
      "heapUsedBytes": 109620852,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 33.166,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10382.586000000003,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.357,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6735.486,
      "heapDeltaBytes": 22897792,
      "heapUsedBytes": 99368752,
      "domNodes": -268,
      "jsHeapTotalBytes": 2707456,
      "scriptDurationMs": 3181.94,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8832.331999999951,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 36.970000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6150.764999999999,
      "heapDeltaBytes": 3991812,
      "heapUsedBytes": 80329216,
      "domNodes": -273,
      "jsHeapTotalBytes": -667648,
      "scriptDurationMs": 2746.385,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17488,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16875.202999999998,
      "heapDeltaBytes": -58220672,
      "heapUsedBytes": 178442580,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15642624,
      "scriptDurationMs": 287.285,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17587.701000000037,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16975.835,
      "heapDeltaBytes": -63388232,
      "heapUsedBytes": 178812772,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18829312,
      "scriptDurationMs": 285.65299999999996,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21335.54499999997,
      "styleRecalcs": 165,
      "styleRecalcDurationMs": 20.334000000000017,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21017.909,
      "heapDeltaBytes": -39068988,
      "heapUsedBytes": 192748392,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19906560,
      "scriptDurationMs": 912.1279999999999,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 32,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20694.60300000003,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 17.538999999999973,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20290.816,
      "heapDeltaBytes": -26091516,
      "heapUsedBytes": 192646488,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10088448,
      "scriptDurationMs": 902.9050000000001,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 10,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6381.9830000000475,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 87.27799999999996,
      "layouts": 20,
      "layoutDurationMs": 26.073,
      "taskDurationMs": 6265.668,
      "heapDeltaBytes": -56208496,
      "heapUsedBytes": 181991896,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12156928,
      "scriptDurationMs": 114.21699999999998,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 540,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6234.493000000043,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 98.59899999999999,
      "layouts": 20,
      "layoutDurationMs": 28.758999999999993,
      "taskDurationMs": 6117.361,
      "heapDeltaBytes": -50764392,
      "heapUsedBytes": 175764692,
      "domNodes": -8068,
      "jsHeapTotalBytes": 2662400,
      "scriptDurationMs": 110.73800000000001,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 623,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8857.357999999977,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8474.716,
      "heapDeltaBytes": 13403752,
      "heapUsedBytes": 178063484,
      "domNodes": 0,
      "jsHeapTotalBytes": -23592960,
      "scriptDurationMs": 143.94099999999997,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8628.17199999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8411.821000000002,
      "heapDeltaBytes": 12297072,
      "heapUsedBytes": 181762692,
      "domNodes": 0,
      "jsHeapTotalBytes": -3932160,
      "scriptDurationMs": 133.78699999999998,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 121.9539999999597,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 16.332,
      "layouts": 3,
      "layoutDurationMs": 1.662,
      "taskDurationMs": 78.888,
      "heapDeltaBytes": 3064008,
      "heapUsedBytes": 71880164,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.371999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 84.63099999994483,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 12.991,
      "layouts": 2,
      "layoutDurationMs": 0.5930000000000001,
      "taskDurationMs": 62.891000000000005,
      "heapDeltaBytes": 3007520,
      "heapUsedBytes": 71894120,
      "domNodes": 102,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.671999999999999,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026
@christian-byrne
christian-byrne enabled auto-merge (squash) September 23, 2026 06:05
@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18556   +/-   ##
=============================================
  Coverage              ?   78.68%           
=============================================
  Files                 ?     2010           
  Lines                 ?   111163           
  Branches              ?    31434           
=============================================
  Hits                  ?    87474           
  Misses                ?    23510           
  Partials              ?      179           
Flag Coverage Δ
unit 78.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/onboarding/onboardingOverlayStore.ts 100.00% <100.00%> (ø)
src/platform/updates/common/releaseStore.ts 83.58% <100.00%> (ø)
...ensions/agent/components/agent/OnboardingCoach.vue 97.29% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit 2717406 into cloud/1.54 Sep 23, 2026
105 checks passed
@christian-byrne
christian-byrne deleted the backport-18287-to-cloud-1.54 branch September 23, 2026 06:19
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-onboarding Agent consent, first-use tour or onboarding gates agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-onboarding Agent consent, first-use tour or onboarding gates agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants