Skip to content

[backport core/1.54] fix(agent): signal the onboarding overlay only while a coach card is on screen (#18439) - #18557

Closed
MaanilVerma wants to merge 1 commit into
backport-18287-to-core-1.54from
backport-18439-to-core-1.54
Closed

MaanilVerma wants to merge 1 commit into
backport-18287-to-core-1.54from
backport-18439-to-core-1.54

Conversation

@MaanilVerma

Copy link
Copy Markdown
Collaborator

Summary

Manual backport of #18439 to core/1.54. The label-driven cherry-pick conflicted in OnboardingCoach.vue only because #18287 was not on the branch yet; on top of #18553 it applies cleanly.

Resolution

Verification

  • pnpm typecheck
  • pnpm typecheck:browser
  • pnpm test:unit src/workbench/extensions/agent/components/agent/OnboardingCoach.test.ts src/platform/updates/common/releaseStore.test.ts src/platform/onboarding/onboardingOverlayStore.test.ts

…on screen (#18439)

## Summary

The Agent coach told the What's New popup to stay away from the moment
it mounted, even when its own card was not on screen yet. If a coach
step's target never mounts, that held the popup back for the whole
session with nothing visible to dismiss. The signal now follows the card
itself.

Follow-up to #18287.

## Changes

- `OnboardingCoach.vue` registers its overlay source as `active &&
target !== null`, the same condition the template renders on, through
one `visible` computed used by both.
- `OnboardingCoach.test.ts` pins that the overlay stays clear while the
target is absent and turns on once a late target mounts.

## Review Focus

The popup hides a tick later than before: after the target resolves
rather than at mount. `WhatsNewPopup.vue` gates on a reactive `v-if` and
showing it writes no seen flag, so nothing is burned in that window.

## QA

- [x] Unit: 71 passing across `OnboardingCoach`, `releaseStore` and
`onboardingOverlayStore`
- [x] Revert-red: the tightened target-absent test fails on the previous
source and passes on this one
- [x] Manual: open the Agent panel with the chat history view showing
(no `#agent-composer` on screen), confirm the What's New popup is not
withheld
@MaanilVerma MaanilVerma added backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) labels Sep 23, 2026
@MaanilVerma MaanilVerma self-assigned this Sep 23, 2026
@vercel

vercel Bot commented Sep 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 5:45am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1a04371b-7437-45d5-960e-04b4331f2e96

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Closing: this was stacked on the #18287 backport, but backports here go independently against the release branch, not stacked. #18439 keeps its needs-backport + core/1.54 + cloud/1.54 labels; once the #18287 backports (#18553 core, #18556 cloud) land, re-trigger the backport bot (remove and re-add needs-backport on #18439) and it will open this cleanly, since the OnboardingCoach.vue conflict was only #18287 missing from the branch.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1941 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1920 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 06:01:22 AM UTC

Links

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                      Coverage Diff                       @@
##           backport-18287-to-core-1.54   #18557     +/-   ##
==============================================================
  Coverage                        83.62%   83.62%             
==============================================================
  Files                             2098     2098             
  Lines                           123869   123869             
  Branches                         33401    31550   -1851     
==============================================================
+ Hits                            103583   103587      +4     
+ Misses                           20107    20103      -4     
  Partials                           179      179             
Flag Coverage Δ
unit 78.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ensions/agent/components/agent/OnboardingCoach.vue 97.29% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-onboarding Agent consent, first-use tour or onboarding gates agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-onboarding Agent consent, first-use tour or onboarding gates agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants