Repository navigation
[backport cloud/1.54] fix(agent): signal the onboarding overlay only while a coach card is on screen (#18439) - #18558
MaanilVerma wants to merge 1 commit into
Conversation
…on screen (#18439) ## Summary The Agent coach told the What's New popup to stay away from the moment it mounted, even when its own card was not on screen yet. If a coach step's target never mounts, that held the popup back for the whole session with nothing visible to dismiss. The signal now follows the card itself. Follow-up to #18287. ## Changes - `OnboardingCoach.vue` registers its overlay source as `active && target !== null`, the same condition the template renders on, through one `visible` computed used by both. - `OnboardingCoach.test.ts` pins that the overlay stays clear while the target is absent and turns on once a late target mounts. ## Review Focus The popup hides a tick later than before: after the target resolves rather than at mount. `WhatsNewPopup.vue` gates on a reactive `v-if` and showing it writes no seen flag, so nothing is burned in that window. ## QA - [x] Unit: 71 passing across `OnboardingCoach`, `releaseStore` and `onboardingOverlayStore` - [x] Revert-red: the tightened target-absent test fails on the previous source and passes on this one - [x] Manual: open the Agent panel with the chat history view showing (no `#agent-composer` on screen), confirm the What's New popup is not withheld
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Closing: this was stacked on the #18287 backport, but backports here go independently against the release branch, not stacked. #18439 keeps its needs-backport + core/1.54 + cloud/1.54 labels; once the #18287 backports (#18553 core, #18556 cloud) land, re-trigger the backport bot (remove and re-add needs-backport on #18439) and it will open this cleanly, since the OnboardingCoach.vue conflict was only #18287 missing from the branch. |
🎭 Playwright: ✅ 1940 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## backport-18287-to-cloud-1.54 #18558 +/- ##
=============================================================
Coverage 78.68% 78.68%
=============================================================
Files 2010 2010
Lines 111163 111163
Branches 31434 31433 -1
=============================================================
Hits 87474 87474
Misses 23510 23510
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Manual backport of #18439 to
cloud/1.54. The label-driven cherry-pick conflicted inOnboardingCoach.vueonly because #18287 was not on the branch yet; on top of #18556 it applies cleanly.Resolution
cloud/1.54once that one merges; merge [backport cloud/1.54] fix(agent): defer What's New popup while agent onboarding runs (#18287) #18556 first.Verification
pnpm typecheckpnpm typecheck:browserpnpm test:unit src/workbench/extensions/agent/components/agent/OnboardingCoach.test.ts src/platform/updates/common/releaseStore.test.ts src/platform/onboarding/onboardingOverlayStore.test.ts