Skip to content

[backport cloud/1.54] test(agent-crdt): repro schema-gate latch leaving canvas at zero nodes - #18542

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-18099-to-cloud-1.54
Sep 23, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-18099-to-cloud-1.54

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Manual backport of #18099 to cloud/1.54 after the label-driven cherry-pick conflicted in layoutFollowerBridge.ts.

Resolution

  • Preserves the release branch inline stale/gap/read-gate implementation.
  • Applies the production behavior and focused follower unit coverage.
  • Omits the main-only browser spec and its fixture helpers because the 1.54 browser harness lacks the APIs required to typecheck it.

Verification

  • pnpm typecheck
  • pnpm typecheck:browser
  • pnpm test:unit src/workbench/extensions/agent/crdt/followerSubscription.test.ts — 41 passed
  • pre-push knip

@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Sep 23, 2026
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 65ba8c23-2fe9-42d2-8973-901cc8503108

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 4:54am UTC

Request Review

Backport the production fix and focused follower unit coverage. The main-branch browser spec is omitted because the 1.54 browser harness lacks its required APIs.
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 05:16:30 AM UTC

Links

🎭 Playwright: ✅ 1938 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1917 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18542   +/-   ##
=============================================
  Coverage              ?   78.68%           
=============================================
  Files                 ?     2009           
  Lines                 ?   111134           
  Branches              ?    31429           
=============================================
  Hits                  ?    87445           
  Misses                ?    23510           
  Partials              ?      179           
Flag Coverage Δ
unit 78.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ench/extensions/agent/crdt/layoutFollowerBridge.ts 97.60% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit 15466b9 into cloud/1.54 Sep 23, 2026
90 checks passed
@christian-byrne
christian-byrne deleted the backport-18099-to-cloud-1.54 branch September 23, 2026 05:44
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants